subject:"Re\: \[Django\] #27234\: Clarify the type of the django.server logger's 'request' extra context"

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2023-10-19 Thread Django

#27234: Clarify the type of the django.server logger's 'request' extra context
-+-
 Reporter:  Ben Whale|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  django.request   | Triage Stage:  Accepted
  runserver WSGIRequest socket   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Ticket #34781 was recently filed and fixed and I did not spot this ticket
 in my "duplicate search", but someone mentioned it today during Django
 Sprints in Durham. Closing as dupe of #34781.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018b496439d1-a36cf7bf-bed9-4813-a733-4cd9c921536f-00%40eu-central-1.amazonses.com.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2016-09-22 Thread Django

#27234: Clarify the type of the django.server logger's 'request' extra context
-+-
 Reporter:  Ben Whale|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  django.request   | Triage Stage:  Accepted
  runserver WSGIRequest socket   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ben Whale):

 Oke doke. Thanks for the thoughts.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.be433b332fa894c8c02391818c402fc6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2016-09-22 Thread Django

#27234: Clarify the type of the django.server logger's 'request' extra context
-+-
 Reporter:  Ben Whale|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  django.request   | Triage Stage:  Accepted
  runserver WSGIRequest socket   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I don't think making `django.request` do the logging of `django.server` is
 desirable. The purpose of having two loggers is to keep `runserver`
 logging separate from other logging.

 I don't have any strong feelings about your documentation proposal. I'm
 sure there are plenty of apps out there that use Django logging for all
 requests and I don't see any problems with that.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.69082e9ed03a3a04f9f5d00ef126%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2016-09-21 Thread Django

#27234: Clarify the type of the django.server logger's 'request' extra context
-+-
 Reporter:  Ben Whale|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  django.request   | Triage Stage:  Accepted
  runserver WSGIRequest socket   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ben Whale):

 Agreed, and even if it was possible it'd be along way off. The additional
 work required for beginners to get up and running would also need to be
 considered.

 It might be possible to replace the calls to django.server with calls to
 django.request without removing {{{runserver}}} or do you think
 django.server is too tightly integrated? Such a change might make it
 easier to remove {{{runserver}}} in the future?

 As a side point, would you be against including a comment in the django
 logging documentation that certain kinds of logging (e.g. all incoming
 requests) are better handled by the actual webserver (e.g. Apache or
 Nginx) in a production or remote development environment?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.23a77d14781567f24b40052f4f662bb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2016-09-20 Thread Django

Comment (by Tim Graham):

No, I don't think the PR you mentioned has an effect on this.

From the documentation:

`django.request`: "Log messages related to the handling of requests."

`django.server`: Log messages related to the handling of requests received
by the server invoked by the `runserver` command.

If that distinction isn't clear, then I guess the documentation should be
clarified. Perhaps it was all less confusing before `runserver` was
modified to use logging (#25684).

My ideal scenario involves deprecating `runserver` in favor of a normal
wsgi runserver such as gunicorn (#21978) so that Django doesn't need to
maintain it's own minimal server, but it's unclear if it's feasible.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.5754abfc140f26ab62ca4cb629641271%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

2016-09-20 Thread Django

Comment (by Ben Whale):

I'll leave that judgement to you.

Does #26688 standardise django.request and django.server so that they both
receive WSGIRequests or both receive sockets? This might effect
documentation changes for 1.11.

Because I'm curious, why have both django.request and django.server
loggers? The documentation implies that they do the same thing, after
#26688 they will log the same things and they both run when using
{{{python manage.py runserver}}}. Would it be sensible to look to removing
django.server in favour of django.request at some future point? For
example as an additional patch to 1.11 or even 1.12? If you think it's
worth looking into I'm happy to do some digging to find out what the
changes would look like (I want to learn more about the django internals
in any case).

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.65bb4e50b268b8a402c4dd4c25bcf45a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context (was: django.request receives a socket object rather than a request object in logging)

2016-09-19 Thread Django

#27234: Clarify the type of the django.server logger's 'request' extra context
-+-
 Reporter:  ben-whale|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  django.request   | Triage Stage:  Accepted
  runserver WSGIRequest socket   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * component:  Uncategorized => Documentation
 * stage:  Unreviewed => Accepted
 * type:  Bug => Cleanup/optimization


Comment:

 I think updating [https://docs.djangoproject.com/en/1.10/topics/logging
 /#django-server the docs] is the correct resolution.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4250422fd9a6f2b972678894f492734d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context

Re: [Django] #27234: Clarify the type of the django.server logger's 'request' extra context (was: django.request receives a socket object rather than a request object in logging)

7 matches

Site Navigation

Mail list logo

Footer information