Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.11b5a346b622d0684d2a5c1f4199941c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I didn't follow the manager changes closely enough to say what the
 expected behavior is.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.019f8e0f2a9acac95d6fe80787c0ad92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florent Messa):

 Replying to [comment:3 Tim Graham]:
 > Looking at your code, I don't think we broke any public APIs, so I'd say
 it's up to you to investigate and say why it's a bug and to propose a fix.
 Maybe Loic can advise without too much effort.

 The **contribute_to_class** is called twice in 1.9.x on the abstract level
 and child.

 That's not the case on 1.10.x your child model needs to declare explicitly
 the manager even if it's inherited.

 I can update my code on my side on every child to redeclare the manager,
 as you have said it's not a public API as it's not documented. I can
 investigate more on my side and provide a fix for that but will you
 consider it?

 Btw, thank you for you reactivity ;)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2a84c04ccc92a8a146516342296a057b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * cc: Loic Bistuer (added)


Comment:

 Looking at your code, I don't think we broke any public APIs, so I'd say
 it's up to you to investigate and say why it's a bug and to propose a fix.
 Maybe Loic can advise without too much effort.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1ba54729a2d815a5811d096d4a9db904%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florent Messa):

 Replying to [comment:1 Tim Graham]:
 > Hi, you should
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/#bisecting-a-regression bisect] to find the commit where the
 behavior changed. If I had to guess it might be
 ed0ff913c648b16c4471fc9a9441d1ee48cb5420 or
 3a47d42fa33012b2156bf04058d933df6b3082d2.

 It was introduced by 3a47d42fa33012b2156bf04058d933df6b3082d2

 Build is available on [[https://travis-ci.org/thoas/django-signals-
 wtf/builds/167683086|travis]], **110a** is the parent commit of
 3a47d42fa33012b2156bf04058d933df6b3082d2 and **110b** is located at
 3a47d42fa33012b2156bf04058d933df6b3082d2

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.94350c4682f66d51326ebdd32f26ca48%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27350: Attaching signals to abstract models don't work as it used to be

[Django]

#27350: Attaching signals to abstract models don't work as it used to be
-+-
 Reporter:  Florent Messa|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Hi, you should
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/#bisecting-a-regression bisect] to find the commit where the
 behavior changed. If I had to guess it might be
 ed0ff913c648b16c4471fc9a9441d1ee48cb5420 or
 3a47d42fa33012b2156bf04058d933df6b3082d2.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3020fe8f7fd14d1259b9aa164ae9d476%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.