Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-02-01 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  annotate, bitand,| Triage Stage:  Ready for
  filter, integerfield, overflow |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak ):

 In [changeset:"741f080ab595fa34ad0d682a096026abade0dcab" 741f080]:
 {{{#!CommitTicketReference repository=""
 revision="741f080ab595fa34ad0d682a096026abade0dcab"
 [5.0.x] Fixed #35147 -- Added backward incompatibility note about
 filtering against overflowing integers.

 Backport of 0630ca5725ba5b17c61cd1f6a05dce2660c4724e from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d662cc7af-6257e291-423b-4fb0-91c7-a000cf76f70f-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-02-01 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  annotate, bitand,| Triage Stage:  Ready for
  filter, integerfield, overflow |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed

Comment:

 In [changeset:"0630ca5725ba5b17c61cd1f6a05dce2660c4724e" 0630ca5]:
 {{{#!CommitTicketReference repository=""
 revision="0630ca5725ba5b17c61cd1f6a05dce2660c4724e"
 Fixed #35147 -- Added backward incompatibility note about filtering
 against overflowing integers.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d662c55da-39c83393-ece6-4e27-a954-696c907e9cc6-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-02-01 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Ready for
  filter, integerfield, overflow |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d65c129f6-a3f45d74-d359-489a-8e87-0ea1223971c8-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-01-31 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d6307c647-d9e86031-a5dc-498e-882c-70133e07e6dd-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-01-31 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d61156c33-b4eac48d-66b5-4534-a2f3-ea52ebe4f9b4-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-01-29 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  Petar
 Type:   |  Netev
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Petar Netev):

 * owner:  nobody => Petar Netev
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d5920f1ce-e79a6a19-e001-452f-a653-546aa3a3cd98-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-01-29 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Simon Charette):

 Replying to [comment:6 Petar Netev]:
 > Hi Natalia and Simon,
 >
 > I would like to prepare the patch, but I would need some clarifications
 on it.
 >
 > - Do we refference the release notes for version 5.0, specifically
 https://docs.djangoproject.com/en/5.0/releases/5.0/#models ?
 > - Do we refference the documentation of the F()
 https://docs.djangoproject.com/en/5.0/releases/5.0/#models ?
 >
 > Simon, can you share the commit related to "I'm fairly certain this
 relates to a commit meant to address a SQLite crash and a DDOS vector on
 Postgres only present in 5.0" in order to mention it in the docs
 improvements?

 dde2537fbb04ad78a673092a931b449245a2d6ae is the commit I was referring to,
 we don't refer to commits or ticket numbers in docs though.

 I think the existing documentation is clear enough that
 `ExpressionWrapper` might be necessary in these cases, the only admonition
 I would add, assuming we believe it might be valuable is a note in
 [https://docs.djangoproject.com/en/5.0/releases/5.0/#miscellaneous the
 miscellaneous section] of the 5.0 release notes mentioning that explicit
 `ExpressionWrapper` wrapping might be necessary for integer field
 arithmetic that can overflow while it wasn't the case in previous release
 by referencing at the documentation mentioned in comment:2.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d583824a3-0a777954-36c5-445f-a780-7637f0d7898c-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field

2024-01-29 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Tim Graham):

 Replying to [comment:6 Petar Netev]:
 > Hi Natalia and Simon,
 >
 > I would like to prepare the patch, but I would need some clarifications
 on it.
 >
 > - Do we reference the release notes for version 5.0, specifically
 https://docs.djangoproject.com/en/5.0/releases/5.0/#models ?
 > - Do we reference the documentation of the F()
 https://docs.djangoproject.com/en/5.0/releases/5.0/#models ?
 >
 > Simon, can you share the commit related to "I'm fairly certain this
 relates to a commit meant to address a SQLite crash and a DDOS vector on
 Postgres only present in 5.0" in order to mention it in the docs
 improvements?
 >
 > Thank you both!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d5830df33-0c9bfe3b-3613-4bc7-86c2-4208fc8c3993-00%40eu-central-1.amazonses.com.


Re: [Django] #35147: Document that non-wrapped arithmetic with integer fields might require explicit output_field (was: Extend release docs to mention that non-wrapped arithmetic against integer field

2024-01-29 Thread Django
#35147: Document that non-wrapped arithmetic with integer fields might require
explicit output_field
-+-
 Reporter:  Petar Netev  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  annotate, bitand,| Triage Stage:  Accepted
  filter, integerfield, overflow |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Database layer (models, ORM) => Documentation
 * summary:
 Extend release docs to mention that non-wrapped arithmetic against
 integer fields might require explicit output_field
 =>
 Document that non-wrapped arithmetic with integer fields might require
 explicit output_field

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d58308d87-e1c6bb51-8e75-4531-9ffa-8c7f22f83b3a-00%40eu-central-1.amazonses.com.