Re: [PATCH] loop/010: Add test for mode 0 fallocate() on loop devices

2023-11-09 Thread Sarthak Kukreti
I meant to add a reference to the latest REQ_OP_PROVISION patch series that this patch accompanied, I'll reword the commit so that it is clearer: [1] https://lore.kernel.org/lkml/20231110010139.3901150-1-sarthakkukr...@chromium.org/ Best Sarthak On Thu, Nov 9, 2023 at 5:28 PM Yi Zhang wrote:

Re: [PATCH] loop/010: Add test for mode 0 fallocate() on loop devices

2023-11-09 Thread Yi Zhang
On Fri, Nov 10, 2023 at 9:02 AM Sarthak Kukreti wrote: > > A recent patch series[1] adds support for calling fallocate() in mode 0 The patch link is missing in this patch. > on block devices. This test adds a basic sanity test for loopback devices > setup on a sparse file and validates that

[PATCH] loop/010: Add test for mode 0 fallocate() on loop devices

2023-11-09 Thread Sarthak Kukreti
A recent patch series[1] adds support for calling fallocate() in mode 0 on block devices. This test adds a basic sanity test for loopback devices setup on a sparse file and validates that writes to the loopback device succeed, even when the underlying filesystem runs out of space. Signed-off-by:

[PATCH v9 3/3] loop: Add support for provision requests

2023-11-09 Thread Sarthak Kukreti
Add support for provision requests to loopback devices. Loop devices will configure provision support based on whether the underlying block device/file can support the provision request and, upon receiving a provision bio, will map it to the backing device/storage. For loop devices over files, a

[PATCH v9 1/3] block: Introduce provisioning primitives

2023-11-09 Thread Sarthak Kukreti
Introduce block request REQ_OP_PROVISION. The intent of this request is to request underlying storage to preallocate disk space for the given block range. Block devices that support this capability will export a provision limit within their request queues. This patch also adds the capability to

[PATCH v9 2/3] dm: Add block provisioning support

2023-11-09 Thread Sarthak Kukreti
Add block provisioning support for device-mapper targets. dm-crypt and dm-linear will, by default, passthrough REQ_OP_PROVISION requests to the underlying device, if supported. Signed-off-by: Sarthak Kukreti Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 4 +++-

[PATCH v9 0/3] [PATCH v9 0/3] Introduce provisioning primitives

2023-11-09 Thread Sarthak Kukreti
Hi, This patch series is version 9 of the patch series to introduce block-level provisioning mechanism (original [1]), which is useful for provisioning space across thinly provisioned storage architectures (loop devices backed by sparse files, dm-thin devices, virtio-blk). This series has minimal

[PATCH v2 1/6] libmultipath: Add max_retries config option

2023-11-09 Thread Benjamin Marzinski
This option lets multipath set a scsi disk's max_retries sysfs value. Setting this can be helpful for cases where the path checker succeeds, but IO commands hang and timeout. By default, the SCSI layer will retry IOs 5 times. Reducing this value will allow multipath to retry the IO down another

[PATCH v2 6/6] multipathd: Add auto_resize config option

2023-11-09 Thread Benjamin Marzinski
This option gives multipathd the ability to automatically resize a device when it detects that all of the path devices have changed. By default it is set to never, and multipathd will continue to work like it always has, where a users must manually resize a multipath device. Signed-off-by:

[PATCH v2 3/6] multipathd: check and update all paths when in cli_resize

2023-11-09 Thread Benjamin Marzinski
When resizing a multipath device, make sure that all the paths have been updated to the new size first. Signed-off-by: Benjamin Marzinski --- multipathd/cli_handlers.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/multipathd/cli_handlers.c

[PATCH v2 5/6] multipathd: move resize_map() to multipathd/main.c

2023-11-09 Thread Benjamin Marzinski
No functional changes. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- multipathd/cli_handlers.c | 29 - multipathd/main.c | 29 + multipathd/main.h | 2 ++ 3 files changed, 31 insertions(+), 29

[PATCH v2 2/6] libmutipath: Retain device size if sysfs_get_size fails.

2023-11-09 Thread Benjamin Marzinski
When paths are allocated their size is initialized to 0. If they've already set a size, and a future call to sysfs_get_size() fails during the parsing, assume that the size hasn't changed, instead of setting it to 0. All other failures in sysfs_get_size() already retain the existing size.

[PATCH v2 0/6] Two multipath features.

2023-11-09 Thread Benjamin Marzinski
This patchset implements two features that I had requests for. The first commit adds the ability for multipath to control the scsi max_retries sysfs setting. This is useful for instances where a path hangs when attempting IO, but the path checker completes successfully. It allows the multipath

[PATCH v2 4/6] multipathd: move post-reloading commands into resize_map()

2023-11-09 Thread Benjamin Marzinski
In preparation for reusing resize_map() in other code, move all code necessary to resize the map to the resize_map() function. Also track if map was removed in the function. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- multipathd/cli_handlers.c | 16 +--- 1 file

Re: [PATCH 1/7] libmultipath: Add max_retries config option

2023-11-09 Thread Martin Wilck
On Thu, 2023-11-09 at 12:26 -0500, Benjamin Marzinski wrote: > On Thu, Nov 09, 2023 at 09:07:23AM +, Martin Wilck wrote: > > > > In the case were the path_checker keeps succeeding, but the IOs > > > keep > > > hanging, multipathd will just keep restoring this path over and > > > over > > >

Re: [PATCH 1/7] libmultipath: Add max_retries config option

2023-11-09 Thread Benjamin Marzinski
On Thu, Nov 09, 2023 at 09:07:23AM +, Martin Wilck wrote: > Hi Ben, > > On Wed, 2023-11-08 at 17:08 -0500, Benjamin Marzinski wrote: > > On Wed, Nov 08, 2023 at 03:36:14PM +, Martin Wilck wrote: > > > On Thu, 2023-11-02 at 18:15 -0400, Benjamin Marzinski wrote: > > > > This option lets

Crash in dm-verity/bufio if use with tasklets

2023-11-09 Thread Milan Broz
Hi, there is a kernel crash during when running our cryptsetup testsuite if using veritysetup with --use-tasklets option (try_verify_in_tasklet table option). With # veritysetup format /dev/sdb /dev/sdc # veritysetup open /dev/sdb test /dev/sdc --use-tasklets it generates BUG below,

Re: [PATCH 1/7] libmultipath: Add max_retries config option

2023-11-09 Thread Martin Wilck
Hi Ben, On Wed, 2023-11-08 at 17:08 -0500, Benjamin Marzinski wrote: > On Wed, Nov 08, 2023 at 03:36:14PM +, Martin Wilck wrote: > > On Thu, 2023-11-02 at 18:15 -0400, Benjamin Marzinski wrote: > > > This option lets multipath set a scsi disk's max_retries sysfs > > > value. > > > Setting