Re: [dm-devel] dm mirror: fix crash caused by NULL-pointer dereference

Hi Mike, On 06/26/2017 09:43 PM, Mike Snitzer wrote: On Mon, Jun 26 2017 at 7:49am -0400, Zdenek Kabelac wrote: [...snip...] Jon (cc'd) tested it and found that the original issue wasn't reproducible. But that the commit in question was the source of crashes (likely

Re: [dm-devel] dm mirror: fix crash caused by NULL-pointer dereference

Hi, On 06/26/2017 11:27 PM, Eric Ren wrote: Hi Mike, On 06/26/2017 10:37 PM, Mike Snitzer wrote: On Mon, Jun 26 2017 at 9:47am -0400, Eric Ren wrote: [...snip...] """ Revert "dm mirror: use all available legs on multiple failures" dm io: fix duplicate bio completion due to

Re: [dm-devel] dm-cache coherence issue

On Mon, Jun 26 2017 at 4:36pm -0400, Johannes Bauer wrote: > On 26.06.2017 21:56, Mike Snitzer wrote: > > >> Interesting, I did *not* change to writethrough. However, there > >> shouldn't have been any I/O on the device (it was not accessed by > >> anything after I

Re: [dm-devel] dm-cache coherence issue

On 26.06.2017 21:56, Mike Snitzer wrote: >> Interesting, I did *not* change to writethrough. However, there >> shouldn't have been any I/O on the device (it was not accessed by >> anything after I switched to the cleaner policy). [...] >> Anyways, I'll try to replicate my scenario again because

Re: [dm-devel] dm-cache coherence issue

On Mon, Jun 26 2017 at 3:08pm -0400, Johannes Bauer wrote: > Hi Joe, > > On 26.06.2017 17:58, Joe Thornber wrote: > > On Mon, Jun 26, 2017 at 12:33:42PM +0100, Joe Thornber wrote: > >> On Sat, Jun 24, 2017 at 03:56:54PM +0200, Johannes Bauer wrote: > >>> So I seem to have

Re: [dm-devel] dm-cache coherence issue

Hi Joe, On 26.06.2017 17:58, Joe Thornber wrote: > On Mon, Jun 26, 2017 at 12:33:42PM +0100, Joe Thornber wrote: >> On Sat, Jun 24, 2017 at 03:56:54PM +0200, Johannes Bauer wrote: >>> So I seem to have a very basic misunderstanding of what the cleaner >>> policy/dirty pages mean. Is there a way

Re: [dm-devel] dm thin: do not queue freed thin mapping for next stage processing

On Fri, Jun 23 2017 at 2:53pm -0400, Vallish Vaidyeshwara wrote: > process_prepared_discard_passdown_pt1() should cleanup > dm_thin_new_mapping in cases of error. > > dm_pool_inc_data_range() can fail trying to get a block reference: > > metadata operation

[dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

This updated config comes from hp. Signed-off-by: Benjamin Marzinski --- libmultipath/hwtable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 390d143..54bdcfc 100644 --- a/libmultipath/hwtable.c +++

Re: [dm-devel] dm-cache coherence issue

On Mon, Jun 26, 2017 at 12:33:42PM +0100, Joe Thornber wrote: > On Sat, Jun 24, 2017 at 03:56:54PM +0200, Johannes Bauer wrote: > > So I seem to have a very basic misunderstanding of what the cleaner > > policy/dirty pages mean. Is there a way to force the cache to flush > > entirely? Apparently,

Re: [dm-devel] dm mirror: fix crash caused by NULL-pointer dereference

On Mon, Jun 26 2017 at 9:47am -0400, Eric Ren wrote: > Hi, > > On 06/26/2017 06:55 PM, Eric Ren wrote: > >Hi Zdenek, > > > > > >On 06/26/2017 05:46 PM, Zdenek Kabelac wrote: > >>Dne 26.6.2017 v 11:08 Eric Ren napsal(a): > >>> > >>[... snip...] > >> > >>Hi > >> > >>Which kernel

Re: [dm-devel] dm mirror: fix crash caused by NULL-pointer dereference

Hi Mike, On 06/26/2017 09:43 PM, Mike Snitzer wrote: On Mon, Jun 26 2017 at 7:49am -0400, Zdenek Kabelac wrote: [...snip...] Ohh - I've -rc6 - while this 'revert' patch went to 4.12-rc7. I'm now starting to wonder why? It's been a real fix for a real issue - and

Re: [dm-devel] [PATCH] dm mirror: fix crash caused by NULL-pointer dereference

Hi, On 06/26/2017 06:55 PM, Eric Ren wrote: Hi Zdenek, On 06/26/2017 05:46 PM, Zdenek Kabelac wrote: Dne 26.6.2017 v 11:08 Eric Ren napsal(a): [... snip...] Hi Which kernel version is this ? I'd thought we've already fixed this BZ for old mirrors:

Re: [dm-devel] dm mirror: fix crash caused by NULL-pointer dereference

On Mon, Jun 26 2017 at 7:49am -0400, Zdenek Kabelac wrote: > Dne 26.6.2017 v 12:55 Eric Ren napsal(a): > >Hi Zdenek, > > > > > >On 06/26/2017 05:46 PM, Zdenek Kabelac wrote: > >>Dne 26.6.2017 v 11:08 Eric Ren napsal(a): > >>> > >>[... snip...] > >> > >>Hi > >> > >>Which

Re: [dm-devel] [PATCH] dm mirror: fix crash caused by NULL-pointer dereference

Dne 26.6.2017 v 12:55 Eric Ren napsal(a): Hi Zdenek, On 06/26/2017 05:46 PM, Zdenek Kabelac wrote: Dne 26.6.2017 v 11:08 Eric Ren napsal(a): [... snip...] Hi Which kernel version is this ? I'd thought we've already fixed this BZ for old mirrors:

Re: [dm-devel] dm-cache coherence issue

On Sat, Jun 24, 2017 at 03:56:54PM +0200, Johannes Bauer wrote: > So I seem to have a very basic misunderstanding of what the cleaner > policy/dirty pages mean. Is there a way to force the cache to flush > entirely? Apparently, "dmsetup wait" and/or "sync" don't do the job. Your understanding is

Re: [dm-devel] [PATCH] dm mirror: fix crash caused by NULL-pointer dereference

Hi Zdenek, On 06/26/2017 05:46 PM, Zdenek Kabelac wrote: Dne 26.6.2017 v 11:08 Eric Ren napsal(a): [... snip...] Hi Which kernel version is this ? I'd thought we've already fixed this BZ for old mirrors: https://bugzilla.redhat.com/show_bug.cgi?id=1382382 There similar BZ for md-raid

Re: [dm-devel] [PATCH] dm mirror: fix crash caused by NULL-pointer dereference

Hi, On 06/26/2017 05:14 PM, Johannes Thumshirn wrote: On Mon, Jun 26, 2017 at 05:08:48PM +0800, Eric Ren wrote: When the primary mirror device fails, activating a mirrored LV will crash the kernel. It can be reproduced 100% with the scripts below: """ dd if=/dev/zero of=file.raw bs=1G count=1

Re: [dm-devel] move bounce limits settings into the drivers

ping? On Mon, Jun 19, 2017 at 09:26:18AM +0200, Christoph Hellwig wrote: > Currently we still default to a bounce all highmem setting for block > drivers. This series defaults to no bouncing and instead adds call > to blk_queue_bounce_limit to those drivers that need it. It also > has a few

Re: [dm-devel] [PATCH] dm mirror: fix crash caused by NULL-pointer dereference

On Mon, Jun 26, 2017 at 05:08:48PM +0800, Eric Ren wrote: > When the primary mirror device fails, activating a mirrored > LV will crash the kernel. It can be reproduced 100% with the > scripts below: > > """ > dd if=/dev/zero of=file.raw bs=1G count=1 > loopdev=$(losetup -f) > losetup $loopdev

[dm-devel] [PATCH] dm ioctl: constify ioctl lookup table

From: Eric Biggers Constify the lookup table for device-mapper ioctls so that it is placed in .rodata. Signed-off-by: Eric Biggers --- drivers/md/dm-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ioctl.c

[dm-devel] [PATCH] dm: constify argument arrays

From: Eric Biggers The arrays of 'struct dm_arg' are never modified by the device-mapper core, so constify them so that they are placed in .rodata. (Exception: the args array in dm-raid cannot be constified because it is allocated on the stack and modified.) Signed-off-by:

Re: [dm-devel] [PATCH v4 09/11] libmultipath: retain_attached_hw_handler obsolete with 4.3+

On Fri, 2017-06-23 at 19:25 +0200, Xose Vazquez Perez wrote: > On 06/22/2017 04:59 PM, Martin Wilck wrote: > > > Kernels 4.3 and newer (commit 1bab0de0 "dm-mpath, scsi_dh: don't > > let dm detach device handlers") imply "retain_attached_hw_handler > > yes". > > > > Clarify this in the propsel

[dm-devel] [PATCH] dm thin: do not queue freed thin mapping for next stage processing

process_prepared_discard_passdown_pt1() should cleanup dm_thin_new_mapping in cases of error. dm_pool_inc_data_range() can fail trying to get a block reference: metadata operation 'dm_pool_inc_data_range' failed: error = -61 When dm_pool_inc_data_range() fails, dm thin aborts current metadata

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

On Thu, 2017-06-22 at 18:46 +0200, Xose Vazquez Perez wrote: > Mainly running scripts/Lindent, from kernel dir, to replace indent spaces > by tabs. Hello Xose, Why do you think this kind of changes is useful? Are you aware that whitespace-only changes are very annoying to anyone else who is

Re: [dm-devel] [PATCH v6 0/2] IV Generation algorithms for dm-crypt

On Fri, Jun 23, 2017 at 04:13:41PM +0800, Herbert Xu wrote: > Binoy Jayan wrote: > > === > > dm-crypt optimization for larger block sizes > >