On 2019/11/08 16:17, Hannes Reinecke wrote:
> On 11/8/19 2:56 AM, Damien Le Moal wrote:
>> No known partitioning tool supports zoned block devices, especially the
>> host managed flavor with strong sequential write constraints.
>> Furthermore, there are also no known user nor use cases for
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Avoid the need to allocate a potentially large array of struct blk_zone
> in the block layer by switching the ->report_zones method interface to
> a callback model. Now the caller simply supplies a callback that is
>
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> There is no need to arbitrarily limit the size of a report zone to the
> number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
> calculate the report buffer size needed for the requested number of
> zones without exceeding the device total
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Make the instance name match the method name and define the name to NULL
> instead of providing an inline stub, which is rather pointless for a
> method call.
>
> Signed-off-by: Christoph Hellwig
> Signed-off-by: Damien Le
On 11/8/19 2:57 AM, Damien Le Moal wrote:
> For a null_blk device with zoned mode enabled, the number of
> conventional zones can be configured through configfs with the
> zone_nr_conv parameter. Add this missing parameter in the features
> string.
>
> Signed-off-by: Damien Le Moal
> ---
>
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> From: Christoph Hellwig
>
> Remove the pointless stub open and release methods, give the operations
> vector a slightly less confusing name, and use normal alignment for the
> assignment operators.
>
> Signed-off-by: Christoph Hellwig
>
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> No known partitioning tool supports zoned block devices, especially the
> host managed flavor with strong sequential write constraints.
> Furthermore, there are also no known user nor use cases for partitioned
> zoned block devices.
>
> This patch
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> All kernel users of blkdev_report_zones() as well as applications use
> through ioctl(BLKZONEREPORT) expect to potentially get less zone
> descriptors than requested. As such, the use of the internal report
> zones command execution loop implemented by
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> From: Christoph Hellwig
>
> blk_revalidate_disk_zones is never called for non-zoned devices. Just
> return early and warn instead of trying to handle this case.
>
> Signed-off-by: Christoph Hellwig
> Signed-off-by: Damien Le Moal
> ---
>
On 11/8/19 2:56 AM, Damien Le Moal wrote:
> For ZBC and ZAC zoned devices, the scsi driver revalidation processing
> implemented by sd_revalidate_disk() includes a call to
> sd_zbc_read_zones() which executes a full disk zone report used to
> check that all zones of the disk are the same size.
On 2019/11/07 9:19, Dmitry Fomichev wrote:
> Commit 75d66ffb48efb3 added backing device health checks and as a part
> of these checks, check_events() block ops template call is invoked
> in dm-zoned mapping path as well as in reclaim and flush path. Calling
> check_events() with ATA or SCSI
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good:
Reviewed-by: Christoph Hellwig
Note that this has a conflict with my series that cleans up the area
around rescan_partitions, but that series will only get simpler after
this patch is merged.
--
dm-devel mailing list
dm-devel@redhat.com
From: Christoph Hellwig
Make the instance name match the method name and define the name to NULL
instead of providing an inline stub, which is rather pointless for a
method call.
Signed-off-by: Christoph Hellwig
Signed-off-by: Damien Le Moal
---
drivers/block/null_blk.h | 11
From: Christoph Hellwig
blk_revalidate_disk_zones is never called for non-zoned devices. Just
return early and warn instead of trying to handle this case.
Signed-off-by: Christoph Hellwig
Signed-off-by: Damien Le Moal
---
block/blk-zoned.c | 7 ---
1 file changed, 4 insertions(+), 3
No known partitioning tool supports zoned block devices, especially the
host managed flavor with strong sequential write constraints.
Furthermore, there are also no known user nor use cases for partitioned
zoned block devices.
This patch removes partition device creation for zoned block devices,
For a null_blk device with zoned mode enabled, the number of
conventional zones can be configured through configfs with the
zone_nr_conv parameter. Add this missing parameter in the features
string.
Signed-off-by: Damien Le Moal
---
drivers/block/null_blk_main.c | 2 +-
1 file changed, 1
From: Christoph Hellwig
Avoid the need to allocate a potentially large array of struct blk_zone
in the block layer by switching the ->report_zones method interface to
a callback model. Now the caller simply supplies a callback that is
executed on each reported zone, and private data for it.
For ZBC and ZAC zoned devices, the scsi driver revalidation processing
implemented by sd_revalidate_disk() includes a call to
sd_zbc_read_zones() which executes a full disk zone report used to
check that all zones of the disk are the same size. This processing is
followed by a call to
There is no need to arbitrarily limit the size of a report zone to the
number of zones defined by SD_ZBC_REPORT_MAX_ZONES. Rather, simply
calculate the report buffer size needed for the requested number of
zones without exceeding the device total number of zones. This buffer
size limitation to the
From: Christoph Hellwig
Remove the pointless stub open and release methods, give the operations
vector a slightly less confusing name, and use normal alignment for the
assignment operators.
Signed-off-by: Christoph Hellwig
Signed-off-by: Damien Le Moal
---
drivers/block/null_blk_main.c | 19
This series of patches introduces changes to zoned block device handling
code with the intent to simplify the code while optimizing run-time
operation, particularly in the area of zone reporting.
The first patch lifts the device zone check code out of the sd driver
and reimplements these zone
All kernel users of blkdev_report_zones() as well as applications use
through ioctl(BLKZONEREPORT) expect to potentially get less zone
descriptors than requested. As such, the use of the internal report
zones command execution loop implemented by blk_report_zones() is
not necessary and can even be
Dne 07. 11. 19 v 20:50 Mikulas Patocka napsal(a):
On Thu, 7 Nov 2019, Maged Mokhtar wrote:
On 07/11/2019 21:09, Mike Snitzer wrote:
On Thu, Nov 07 2019 at 1:55pm -0500,
Maged Mokhtar wrote:
On 06/11/2019 17:08, Mike Snitzer wrote:
On Tue, Nov 05 2019 at 4:19pm -0500,
Maged Mokhtar
On Thu, Nov 07 2019 at 2:29pm -0500,
Maged Mokhtar wrote:
>
>
> On 07/11/2019 21:09, Mike Snitzer wrote:
> >On Thu, Nov 07 2019 at 1:55pm -0500,
> >Maged Mokhtar wrote:
> >
> >>
> >>
> >>On 06/11/2019 17:08, Mike Snitzer wrote:
> >>>On Tue, Nov 05 2019 at 4:19pm -0500,
> >>>Maged Mokhtar
On Thu, Nov 07 2019 at 1:55pm -0500,
Maged Mokhtar wrote:
>
>
> On 06/11/2019 17:08, Mike Snitzer wrote:
> >On Tue, Nov 05 2019 at 4:19pm -0500,
> >Maged Mokhtar wrote:
> >
> >>Gentle ping please.
> >>
> >>It could add flexibility in changing cache parameters after device creation.
> >
>
On 10/27/19 8:05 AM, Damien Le Moal wrote:
> This series implements a few improvements and cleanups to zone block
> device zone reset operations with the first three patches.
>
> The remaining of the series patches introduce zone open, close and
> finish support, allowing users of zoned block
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Looks good,
Reviewed-by: Christoph Hellwig
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
From: Martin Wilck
Hi Christophe, hi Ben, hi Bart,
(I found a glitch in the v2 submission of this series. Details below).
here is a series with cleanup patches and minor fixes for multipath-tools.
Sorry about the number of patches, I hope this way the series will be easier
to review. There are
From: Martin Wilck
snprintf() returns int, but the size argument "n" is size_t.
Use safe_snprintf() to avoid -Wsign-compare warnings. At the same
time, improve these macros to check for errors in snprintf(), too.
Note: there are more uses of snprintf() in our code that may
need review, too. For
37 matches
Mail list logo
