Please have a review for this patch, hope for your comments.
Thanks
发件人: peng.lia...@zte.com.cn
收件人: christophe varoqui ,
抄送: zhang.ka...@zte.com.cn, dm-devel@redhat.com, peng liang
日期: 2016-08-17 15:06
主题: [dm-devel] [PATCH] libmultipath: remove redundant code in
store_
Hello Bart,
Thanks for your attention. I don't think it is necessary to do that.
Whatever returning 1 or ENOMEM it will reply "fail\n" and set the
returning to 1.
The executed code in uxsock_trigger as follows.
if (r > 0) {
if (r == ETIMEDOUT)
*rep
Hi Christoph,
Thanks for your reply. Comments inline...
On 2016/10/9 23:16, Christoph Hellwig wrote:
Hi Yibin,
On Sun, Oct 09, 2016 at 01:12:41PM +, wangyibin wrote:
1. Improper dm_pr_ops implementation.
The dm_pr_ops functions, except register/unregister, all result in
infinite loop by r
On 2016/10/13 17:19, Yibin Wang wrote:
Hi Christoph,
Thanks for your reply. Comments inline...
On 2016/10/9 23:16, Christoph Hellwig wrote:
..
- For regisetr, we should stop iteration on failure, and
followed by a
non-stopping unregister operation.
What do you mean with "non
Hi,
We have been pushing thin pool performance beyond what most would normally
do. In the process we have noticed an IOPS performance ceiling within a
single thin pool. Jon Bernard started an email thread about this problem
which is linked below.
https://www.redhat.com/archives/dm-devel/2016-July
On 10/12/2016 11:30 PM, peng.lia...@zte.com.cn wrote:
Thanks for your attention. I don't think it is necessary to do that.
Whatever returning 1 or ENOMEM it will reply "fail\n" and set the
returning to 1.
The executed code in uxsock_trigger as follows.
if (r > 0) {
if (r
From: Xose Vazquez Perez
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 1ecaf19..01d3c53 100644
--- a/
From: Xose Vazquez Perez
Only F20 and 800 were included:
2105F20 IBM Enterprise Storage Server Model F20
2105800 IBM TotalStorage Enterprise Storage Server Model 800
Added all of them with just "^2105"
2105E10 IBM Enterprise Storage Server Model E10
2105E20 IBM Enterprise Storage Server Model E2
From: Xose Vazquez Perez
It's already the default pgpolicy.
Cc: Mike Christie
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
From: Xose Vazquez Perez
Based on info from the manufacturer.
And also add ^ to Axiom.
Cc: Srinivasan Ramani
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 16
1 file changed, 12 insertions(+), 4 deletions
From: Xose Vazquez Perez
Confirmed by the original manufacturer(NetApp).
Cc: Sean Stewart
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/hw
From: Xose Vazquez Perez
Cc: Hannes Reinecke
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index bfe5df4..9a
From: Xose Vazquez Perez
This is a combo patch.
Reorder keyworks as in code and manpage for "(NETAPP|LSI|ENGENIO)"/"INF-01-00",
and clone its configuration to ALL other RDAC devices.
There are only two differences in all rdac devices. And they look minor:
.features and .no_path_retry
devices
From: Xose Vazquez Perez
Replace six spaces with any number of them.
Exact regex is "3303[ ]{6,6}NVDISK", but it looks too overloaded.
Tested with a regex checker from:
http://eli.thegreenplace.net/2012/11/14/some-notes-on-posix-regular-expressions
Cc: Brian King
Cc: Christophe Varoqui
Cc: de
From: Xose Vazquez Perez
It's a RDAC device, confirmed by the original manufacturer(NetApp).
Cc: Sean Stewart
Cc: Hannes Reinecke
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 13 +
1 file changed, 13 inserti
From: Xose Vazquez Perez
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
multipath/multipath.conf.5 | 1 -
1 file changed, 1 deletion(-)
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index acc1f51..b34a320 100644
--- a/multipa
From: Xose Vazquez Perez
Exact devices are in drivers/scsi/scsi_dh.c
{"COMPAQ", "MSA1000 VOLUME","hp_sw" },
{"COMPAQ", "HSV110","hp_sw" },
{"HP", "HSV100","hp_sw"},
Cc: Hannes Reinecke
Cc: Christophe Varoqui
Cc: device-mapper development
From: Xose Vazquez Perez
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
libmultipath/hwtable.c | 4 ++--
multipath/multipath.conf.5 | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwta
From: Xose Vazquez Perez
It is only for kernel dm patches.
Cc: Christophe Varoqui
Cc: device-mapper development
Signed-off-by: Xose Vazquez Perez
---
README | 1 -
1 file changed, 1 deletion(-)
diff --git a/README b/README
index c1c53fc..77b79b8 100644
--- a/README
+++ b/README
@@ -25,6 +25
I am very sorry , because of my faulty operation ,make a mistake of
sendmail , please remove the patch had committed in dm-devel Archives.
I apologize for any inconvenience caused
thanks very much.
[dm-devel] [PATCH 24/94] multipath-tools: document vendor, product,
revision and bl_product ar
From: 10144149
Problem: multipathd dead when we run "show map spathx json" command with
system messages as follows:
Oct 13 11:37:30 rhel7-1 multipathd: *** Error in `/sbin/multipathd': realloc():
invalid next size: 0x7f8cf8004210 ***
Oct 13 11:37:30 rhel7-1 multipathd: === Backtrace: ===
On 10/14/2016 04:08 AM, huang.we...@zte.com.cn wrote:
> From: "wei.huang"
>
> Problem:
> when we configure device like vendor is COMPELNT in multipath.conf,
> multipathd will be coredump.
>
> Reasons:
> some vonders are not configured features in default_hw. In add_feature,
> strstr's first pa
On 10/14/2016 04:03 AM, huang.we...@zte.com.cn wrote:
> From: "wei.huang"
>
> Problem:
> when we configure a device like vendor, product, revision all null in
> multipath.conf, hwe_regmatch always return 0.
>
> Reasons:
> \!hwe2->vendor, \!hwe2->product and \!hwe2->revision are all true.
>
> S
23 matches
Mail list logo
