[dmidecode] [PATCH] dmioem: Reflect HPE's new company name.

2017-08-25 Thread Jerry Hoemann
After Hewlett Packard Enterprise split from Hewlett-Packard, DMI OEM tables reflect the new company name. Gen10 and subsequent systems will use HPE. Gen9 and prior systems continue to use the old "HP" name. Signed-off-by: Jerry Hoemann Reviewed-by: Randy Wright --- dmi

Re: [dmidecode] [PATCH] dmioem: Reflect HPE's new company name.

2017-09-13 Thread Jerry Hoemann
On Wed, Sep 06, 2017 at 02:29:44PM +0200, Jean Delvare wrote: > Hi Jerry, > > Sorry for the delay, I was on vacation. Thanks Erwan for the > preliminary review - overall I agree, the patch looks essentially good. > To the details now... > > On Fri, 25 Aug 2017 17:54:43 -0600

[dmidecode] [PATCH v2] dmioem: Reflect HPE's new company name.

2017-09-13 Thread Jerry Hoemann
mpany name on type 209 and 221. Jerry Hoemann (1): dmioem: Reflect HPE's new company name. dmioem.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) -- 2.9.4 ___ https://lists.nongnu.org/mailman/lis

[dmidecode] [PATCH v2] dmioem: Reflect HPE's new company name.

2017-09-13 Thread Jerry Hoemann
After Hewlett Packard Enterprise split from Hewlett-Packard, DMI OEM tables reflect the new company name. Gen10 and subsequent systems will use HPE. Gen9 and prior systems continue to use the old "HP" name. Signed-off-by: Jerry Hoemann --- dmioem.c | 32 +++--

[dmidecode] [PATCH] dmioem: decode HPE UEFI type 219 Misc Features

2018-04-09 Thread Jerry Hoemann
The incorrect "Misc Feature" bit in type 219 table was being used to identify that the platform is capable of booting with UEFI. For cooresponding kernel change please see: commit(c42cbe41727a) in linux-stable. Signed-off-by: Jerry Hoemann --- dmioem.c | 2 +- 1 file

Re: [dmidecode] [PATCH] dmioem: decode HPE UEFI type 219 Misc Features

2018-04-10 Thread Jerry Hoemann
On Tue, Apr 10, 2018 at 08:31:57AM +0200, Jean Delvare wrote: > Hi Jerry, > > On Mon, 9 Apr 2018 18:15:33 -0600, Jerry Hoemann wrote: > > The incorrect "Misc Feature" bit in type 219 table was being used to > > identify that the platform is capable of

Re: [dmidecode] [PATCH] dmioem: decode HPE UEFI type 219 Misc Features

2018-04-10 Thread Jerry Hoemann
On Tue, Apr 10, 2018 at 06:14:14PM +0200, Jean Delvare wrote: > On Tue, 10 Apr 2018 10:03:30 -0600, Jerry Hoemann wrote: > > On Tue, Apr 10, 2018 at 08:31:57AM +0200, Jean Delvare wrote: > > > Hi Jerry, > > > > > > On Mon, 9 Apr 2018 18:15:33 -0600, Jerry Ho

[dmidecode] [PATCH v2] dmioem: decode HPE UEFI type 219 Misc Features

2018-04-10 Thread Jerry Hoemann
The incorrect "Misc Feature" bit in type 219 table was being used to identify that the platform is capable of booting with UEFI. For corresponding kernel change please see: commit(c42cbe41727a) in linux. Signed-off-by: Jerry Hoemann --- dmioem.c | 2 +- 1 file changed, 1

[dmidecode] [PATCH] dmidecode: Extensions to Memory Device (Type 17)

2018-06-11 Thread Jerry Hoemann
The DSP0134 v3.2.0 extended the Memory Device (Type 17) structure starting at offset 28h continuing to 4Ch to reflect persistent memory. Signed-off-by: Jerry Hoemann --- dmidecode.c | 113 1 file changed, 113 insertions(+) diff --git

Re: [dmidecode] [PATCH] dmidecode: Extensions to Memory Device (Type 17)

2018-06-14 Thread Jerry Hoemann
On Mon, Jun 11, 2018 at 11:40:07AM -0600, Jerry Hoemann wrote: > The DSP0134 v3.2.0 extended the Memory Device (Type 17) structure > starting at offset 28h continuing to 4Ch to reflect persistent memory. > > Signed-off-by: Jerry Hoemann > --- >

Re: [dmidecode] [PATCH] dmidecode: Extensions to Memory Device (Type 17)

2018-06-15 Thread Jerry Hoemann
On Fri, Jun 15, 2018 at 09:26:23AM +0200, Jean Delvare wrote: > Hi Jerry, > > On Thu, 14 Jun 2018 18:14:55 -0600, Jerry Hoemann wrote: > > > +static void dmi_memory_manufacturer_id(u16 code) > > > +{ > > > + /* 7.18.8 */ > > > + /* 7.18.10 */

Re: [dmidecode] [PATCH] dmidecode: Extensions to Memory Device (Type 17)

2018-06-15 Thread Jerry Hoemann
On Fri, Jun 15, 2018 at 10:01:02AM +0200, Jean Delvare wrote: > Hi Jerry, > > On Mon, 11 Jun 2018 11:40:07 -0600, Jerry Hoemann wrote: > > The DSP0134 v3.2.0 extended the Memory Device (Type 17) structure > > starting at offset 28h continuing to 4Ch to reflect persistent mem

Re: [dmidecode] [PATCH] dmidecode: Extensions to Memory Device (Type 17)

2018-06-18 Thread Jerry Hoemann
On Sat, Jun 16, 2018 at 07:07:57PM +0200, Jean Delvare wrote: > On Fri, 15 Jun 2018 15:08:39 -0600, Jerry Hoemann wrote: > > On Fri, Jun 15, 2018 at 10:01:02AM +0200, Jean Delvare wrote: > > > On Mon, 11 Jun 2018 11:40:07 -0600, Jerry Hoemann wrote: > > > > +static

[dmidecode] [PATCH v2 0/1] dmidecode: Extensions to Memory Device (Type 17)

2018-06-18 Thread Jerry Hoemann
range checked. v1 dmidecode: Extensions to Memory Device (Type 17) The DSP0134 v3.2.0 extended the Memory Device (Type 17) structure starting at offset 28h continuing to 4Ch to reflect persistent memory. Jerry Hoemann (1): dmidecode: Extensions to Memory Device (Type 17) dmid

[dmidecode] [PATCH v2 1/1] dmidecode: Extensions to Memory Device (Type 17)

2018-06-18 Thread Jerry Hoemann
The DSP0134 v3.2.0 extended the Memory Device (Type 17) structure starting at offset 28h continuing to 4Ch to reflect persistent memory. Signed-off-by: Jerry Hoemann --- dmidecode.c | 110 1 file changed, 110 insertions(+) diff --git

[dmidecode] [PATCH] dmidecode: Add option to filter output based upon handle.

2018-06-28 Thread Jerry Hoemann
Add option "--handle HANDLE" to dmiopt to allow user to filter ouput to only those entrie(s) that match HANDLE. Signed-off-by: Jerry Hoemann --- dmidecode.c | 2 ++ dmiopt.c| 22 +- dmiopt.h| 1 + man/dmidecode.8 | 4 4 files c

Re: [dmidecode] [PATCH] dmidecode: Add option to filter output based upon handle

2018-06-29 Thread Jerry Hoemann
On Fri, Jun 29, 2018 at 11:08:36AM +0200, Jean Delvare wrote: > Hi Jerry, > > On Thu, 28 Jun 2018 14:08:06 -0600, Jerry Hoemann wrote: > > Add option "--handle HANDLE" to dmiopt to allow user to filter > > ouput to only those entrie(s) that match HANDLE. >

[dmidecode] [PATCH v2 0/2] dmidecode: Add --handle option

2018-06-29 Thread Jerry Hoemann
p strtoul use in parse_opt_type and parse_opt_oem_string. V1 dmidecode: Add option to filter output based upon handle. Jerry Hoemann (2): dmidecode: Add option to filter output based upon handle. dmidecode: Argument processing dmidecode.c | 2 ++ dmiopt.c| 32 +

[dmidecode] [PATCH v2 1/2] dmidecode: Add option to filter output based upon handle.

2018-06-29 Thread Jerry Hoemann
Add option "--handle HANDLE" to dmiopt to allow user to filter ouput to only those entrie(s) that match HANDLE. Signed-off-by: Jerry Hoemann --- dmidecode.c | 2 ++ dmiopt.c| 28 +++- dmiopt.h| 1 + man/dmidecode.8 | 4 4 files c

[dmidecode] [PATCH v2 2/2] dmidecode: Argument processing

2018-06-29 Thread Jerry Hoemann
Tighten up the numberic argument processing for parse_opt_type and parse_opt_oem_string to catch more typos. Signed-off-by: Jerry Hoemann --- dmiopt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dmiopt.c b/dmiopt.c index 7a9963c..a142698 100644 --- a/dmiopt.c +++ b

Re: [dmidecode] [PATCH v2 0/2] dmidecode: Add --handle option

2018-07-02 Thread Jerry Hoemann
On Mon, Jul 02, 2018 at 07:02:21PM +0200, Jean Delvare wrote: > On Fri, 29 Jun 2018 15:32:59 -0600, Jerry Hoemann wrote: > > Changes in v2 > > Addressed the following review comments > > 01. Removed extra Parens in dmi_table_decode > > 02. Removed defensive pointer val

Re: [dmidecode] [PATCH] dmidecode: Add "Logical non-volatile device" to the memory device types

2019-01-15 Thread Jerry Hoemann
ssing enumerated value. > > Signed-off-by: Jean Delvare > Cc: Jerry Hoemann > --- > dmidecode.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Jerry Hoemann Thanks. > > --- dmidecode.orig/dmidecode.c2019-01-15 12:59:08.942308166 +0100

Re: [dmidecode] Adding -s bios-revision & -s firmware-revision support

2019-09-20 Thread Jerry Hoemann
t; + break; > case 0x108: > dmi_system_uuid(data + offset, ver); > printf("\n"); > diff --git a/dmiopt.c b/dmiopt.c > index 2f285f34a96b..cefe27d4554a 100644 > --- a/dmiopt.c > +++ b/dmio

Re: [dmidecode] [PATCH] dmidecode: Add enumerated values from SMBIOS 3.3.0

2019-10-17 Thread Jerry Hoemann
;ANNEX C: Change log", or something else? Thanks Reviewed-by: Jerry Hoemann > > --- dmidecode.orig/dmidecode.c2019-10-15 14:24:46.517465808 +0200 > +++ dmidecode/dmidecode.c 2019-10-16 15:29:30.036734954 +0200 > @@ -936,6 +936,10 @@ static const char *dmi

Re: [dmidecode] OEM type 236 for HPe Gen10(+) servers

2020-11-06 Thread Jerry Hoemann
8 *data = h->data; > @@ -422,6 +459,8 @@ int dmi_decode_oem(const struct dmi_header *h) > case VENDOR_IBM: > case VENDOR_LENOVO: > return dmi_decode_i

Re: [dmidecode] OEM type 236 for HPe Gen10(+) servers

2020-11-09 Thread Jerry Hoemann
addressing is rare and usually avoided in > major standards because not all controllers support it. In the examples > I have, when there are 2 type 236 records, the first one has I2C > address 0xA0 and the second 0xA2. Note that both have bit 0 set to 0, > and th

Re: [dmidecode] OEM type 236 for HPe Gen10(+) servers

2020-11-12 Thread Jerry Hoemann
ier. Thanks Jerry ----- Jerry Hoemann Software Engineer Hewlett Packard Enterprise - _

[dmidecode] [PATCH 0/4] dmidecode: Decode HPE OEM record 236.

2020-11-19 Thread Jerry Hoemann
records that appear before Type 1 records will not be decoded. patch 1: Sort OEM records in dmi_decode_hp patch 2: Some OEM records require Product Name patch 3: Use product name to determine Generation patch 4: Decode HPE OEM record 236 Thanks to Erwan Velu who did the initial version

[dmidecode] [PATCH 1/4] dmioem: Sort OEM records in dmi_decode_hp

2020-11-19 Thread Jerry Hoemann
White space change. Sort the OEM records in dmi_decode_hp. Signed-off-by: Jerry Hoemann --- dmioem.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/dmioem.c b/dmioem.c index 60b6674..beb3df0 100644 --- a/dmioem.c

[dmidecode] [PATCH 3/4] dmioem: Use product name to determine Generation.

2020-11-19 Thread Jerry Hoemann
string. Signed-off-by: Jerry Hoemann --- dmioem.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/dmioem.c b/dmioem.c index 36820e4..16f4488 100644 --- a/dmioem.c +++ b/dmioem.c @@ -150,12 +150,41 @@ static void dmi_print_hp_net_iface_rec(u8

[dmidecode] [PATCH 4/4] dmioem: Decode HPE OEM record 236

2020-11-19 Thread Jerry Hoemann
HPE OEM record 236 describes the HPE ProLiant HDD Backplane. A non-backward compatible change was introduced with Gen10 Plus which retracted three fields and made them "Reserved." Signed-off-by: Jerry Hoemann --- dmioem.c | 41 + 1 file c

[dmidecode] [PATCH 2/4] dmidecode: Some OEM records require Product Name

2020-11-19 Thread Jerry Hoemann
Decoding of OEM records can depend upon the product in addition to the manufacturer. So, save "Product Name" from type 1 record in addition to "Manufacturer" in dmi_set_vendor. Signed-off-by: Jerry Hoemann --- dmidecode.c | 4 ++-- dmioem.c| 5 - dmioem.h| 2 +-

[dmidecode] [PATCH v2 3/4] dmioem: Use product name to determine Generation.

2020-11-29 Thread Jerry Hoemann
string. Signed-off-by: Jerry Hoemann --- dmioem.c | 32 1 file changed, 32 insertions(+) diff --git a/dmioem.c b/dmioem.c index 36820e4..4798f89 100644 --- a/dmioem.c +++ b/dmioem.c @@ -23,6 +23,7 @@ #include #include "types.h" +#include "

[dmidecode] [PATCH v2 0/4] dmidecode: Decode HPE OEM record 236.

2020-11-29 Thread Jerry Hoemann
atch 4. === Changes in version 2 === patch 1: Updated Submit comment patch 2: None, as maintainer plans to address separately. patch 3: Applied review comments. patch 4: Applied review comments. Jerry Hoemann (4): dmioem: Sort OEM records in dmi_decode_hp dmidecode: Some OEM records

[dmidecode] [PATCH v2 1/4] dmioem: Sort OEM records in dmi_decode_hp

2020-11-29 Thread Jerry Hoemann
Non-functional change. Sort the OEM records in dmi_decode_hp. Signed-off-by: Jerry Hoemann --- dmioem.c | 58 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/dmioem.c b/dmioem.c index 60b6674..beb3df0 100644 --- a

[dmidecode] [PATCH v2 4/4] dmioem: Decode HPE OEM record 236

2020-11-29 Thread Jerry Hoemann
HPE OEM record 236 describes the HPE ProLiant HDD Backplane. A non-backward compatible change was introduced with Gen10 Plus which retracted three fields and made them "Reserved." Signed-off-by: Jerry Hoemann --- dmioem.c | 35 +++ 1 file changed, 35

[dmidecode] [PATCH v2 2/4] dmidecode: Some OEM records require Product Name

2020-11-29 Thread Jerry Hoemann
Decoding of OEM records can depend upon the product in addition to the manufacturer. So, save "Product Name" from type 1 record in addition to "Manufacturer" in dmi_set_vendor. Signed-off-by: Jerry Hoemann --- dmidecode.c | 4 ++-- dmioem.c| 5 - dmioem.h| 2 +-

[dmidecode] [PATCH 1/2] dmioem: Decode HPE OEM Record 240

2020-12-16 Thread Jerry Hoemann
HP Firmware Inventory Record (Type 240) Signed-off-by: Jerry Hoemann --- dmioem.c | 41 + 1 file changed, 41 insertions(+) diff --git a/dmioem.c b/dmioem.c index 180a95d..d8cab2c 100644 --- a/dmioem.c +++ b/dmioem.c @@ -361,6 +361,47 @@ static int

[dmidecode] [PATCH 0/2] dmidecode: Decode HPE OEM Records 203 and 240.

2020-12-16 Thread Jerry Hoemann
Decode the following OEM records: HP Firmware Inventory Record (Type OEM Record 240) HP Device Correlation Record (Type OEM Record 203) Jerry Hoemann (2): dmioem: Decode HPE OEM Record 240 dmioem: Decode HPE OEM Record 203 dmioem.c | 194

[dmidecode] [PATCH 2/2] dmioem: Decode HPE OEM Record 203

2020-12-16 Thread Jerry Hoemann
HP Device Correlation Record (Type 203) Signed-off-by: Jerry Hoemann --- dmioem.c | 153 +++ 1 file changed, 153 insertions(+) diff --git a/dmioem.c b/dmioem.c index d8cab2c..7983664 100644 --- a/dmioem.c +++ b/dmioem.c @@ -186,6 +186,87

Re: [dmidecode] [PATCH 1/2] dmioem: Decode HPE OEM Record 240

2021-01-11 Thread Jerry Hoemann
On Tue, Jan 05, 2021 at 01:56:09PM +0100, Jean Delvare wrote: > Hi Jerry, > > On Wed, 16 Dec 2020 14:18:58 -0700, Jerry Hoemann wrote: > > HP Firmware Inventory Record (Type 240) > > > > Signed-off-by: Jerry Hoemann > > --- > > dmioem.c | 41 +

Re: [dmidecode] [PATCH 2/2] dmioem: Decode HPE OEM Record 203

2021-01-11 Thread Jerry Hoemann
On Tue, Jan 05, 2021 at 04:31:54PM +0100, Jean Delvare wrote: > Hi Jerry, > > On Wed, 16 Dec 2020 14:18:59 -0700, Jerry Hoemann wrote: > > HP Device Correlation Record (Type 203) > > > > Signed-off-by: Jerry Hoemann

[dmidecode] [PATCH v2 0/4] dmidecode: Decode HPE OEM Records 203 and 240.

2021-01-12 Thread Jerry Hoemann
of record 240 and 203 based up code review. Added new patch to check minimal length of record when decoing HPE OEM 236. Jerry Hoemann (4): dmidecode: Make dmi_print_memory_size global. dmioem: Decode HPE OEM Record 240 dmioem: Decode HPE OEM Record 203 dmioem: Fix HPE OEM 236 dmidecode.c

[dmidecode] [PATCH v2 1/4] dmidecode: Make dmi_print_memory_size global.

2021-01-12 Thread Jerry Hoemann
Make dmi_print_memory_size() global so that it can be called from outside of dmidecode.c Signed-off-by: Jerry Hoemann --- dmidecode.c | 2 +- dmidecode.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dmidecode.c b/dmidecode.c index 864a193..2a075c1 100644 --- a

[dmidecode] [PATCH v2 3/4] dmioem: Decode HPE OEM Record 203

2021-01-12 Thread Jerry Hoemann
HP Device Correlation Record (Type 203) Signed-off-by: Jerry Hoemann --- dmioem.c | 180 +++ 1 file changed, 180 insertions(+) diff --git a/dmioem.c b/dmioem.c index 4a7ff2b..2f38229 100644 --- a/dmioem.c +++ b/dmioem.c @@ -204,6 +204,106

[dmidecode] [PATCH v2 2/4] dmioem: Decode HPE OEM Record 240

2021-01-12 Thread Jerry Hoemann
HP Firmware Inventory Record (Type 240) Signed-off-by: Jerry Hoemann --- dmioem.c | 62 +++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/dmioem.c b/dmioem.c index 180a95d..4a7ff2b 100644 --- a/dmioem.c +++ b/dmioem.c @@ -27,6

[dmidecode] [PATCH v2 4/4] dmioem: Fix HPE OEM 236

2021-01-12 Thread Jerry Hoemann
Check for minimal length of record when decoding HPE OEM 236. Signed-off-by: Jerry Hoemann --- dmioem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dmioem.c b/dmioem.c index 2f38229..f8ca3b4 100644 --- a/dmioem.c +++ b/dmioem.c @@ -543,6 +543,7 @@ static int dmi_decode_hp(const struct

Re: [dmidecode] [PATCH v2 3/4] dmioem: Decode HPE OEM Record 203

2021-01-12 Thread Jerry Hoemann
On Tue, Jan 12, 2021 at 06:01:43PM +0100, Jean Delvare wrote: > Hi Jerry, > > Thanks for the updated patches. Here's my review: > > On Tue, 12 Jan 2021 01:05:04 -0700, Jerry Hoemann wrote: > > HP Device Correlation Record (Type 203) > > > > Signed-off-by

Re: [dmidecode] [PATCH v2 2/4] dmioem: Decode HPE OEM Record 240

2021-01-12 Thread Jerry Hoemann
On Tue, Jan 12, 2021 at 04:12:45PM +0100, Jean Delvare wrote: > On Tue, 12 Jan 2021 01:05:03 -0700, Jerry Hoemann wrote: > > HP Firmware Inventory Record (Type 240) ... > > > > static int dmi_decode_hp(const struct dmi_header *h) > > { > > u8 *dat

[dmidecode] [PATCH v3 2/4] dmioem: Decode HPE OEM Record 240

2021-01-13 Thread Jerry Hoemann
HP Firmware Inventory Record (Type 240) Signed-off-by: Jerry Hoemann --- dmioem.c | 61 1 file changed, 61 insertions(+) diff --git a/dmioem.c b/dmioem.c index 180a95d..d77d7b2 100644 --- a/dmioem.c +++ b/dmioem.c @@ -27,6 +27,7

[dmidecode] [PATCH v3 0/4] dmidecode: Decode HPE OEM Records 203 and 240.

2021-01-13 Thread Jerry Hoemann
displayed. Capitialization of hex numbers. patch 0004: dmioem: Fix HPE OEM 236 No Change. Jerry Hoemann (4): dmidecode: Make dmi_print_memory_size global. dmioem: Decode HPE OEM Record 240 dmioem: Decode HPE OEM Record 203 dmioem: Fix HPE OEM 236 dmidecode.c | 2 +- dmideco

[dmidecode] [PATCH v3 3/4] dmioem: Decode HPE OEM Record 203

2021-01-13 Thread Jerry Hoemann
HP Device Correlation Record (Type 203) Signed-off-by: Jerry Hoemann --- dmioem.c | 172 +++ 1 file changed, 172 insertions(+) diff --git a/dmioem.c b/dmioem.c index d77d7b2..3f819ce 100644 --- a/dmioem.c +++ b/dmioem.c @@ -204,6 +204,97

[dmidecode] [PATCH v3 1/4] dmidecode: Make dmi_print_memory_size global.

2021-01-13 Thread Jerry Hoemann
Make dmi_print_memory_size() global so that it can be called from outside of dmidecode.c Signed-off-by: Jerry Hoemann --- dmidecode.c | 2 +- dmidecode.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dmidecode.c b/dmidecode.c index 864a193..2a075c1 100644 --- a

[dmidecode] [PATCH v3 4/4] dmioem: Fix HPE OEM 236

2021-01-13 Thread Jerry Hoemann
Check for minimal length of record when decoding HPE OEM 236. Signed-off-by: Jerry Hoemann --- dmioem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dmioem.c b/dmioem.c index 3f819ce..bce7fc4 100644 --- a/dmioem.c +++ b/dmioem.c @@ -536,6 +536,7 @@ static int dmi_decode_hp(const struct

Re: [dmidecode] [PATCH] dmidecode: Set vendor early

2021-01-13 Thread Jerry Hoemann
; - dmi_set_vendor(_dmi_string(&h, data[0x04], 0), > - _dmi_string(&h, data[0x05], 0)); > - > /* Fixup a common mistake */ > if (h.type == 34) > dmi_fixup_type_34(&h, display); > > > -- > Jean Delvare > SUSE L3 Support -- - Jerry Hoemann Software Engineer Hewlett Packard Enterprise - ___ https://lists.nongnu.org/mailman/listinfo/dmidecode-devel

Re: [dmidecode] [PATCH] dmioem: Present HPE type 240 attributes in a nicer way

2021-01-15 Thread Jerry Hoemann
pr_attr("Image Size", "Not Available"); > > - dmi_hp_240_attr("Attributes Def", QWORD(data + 0x13)); > -

[dmidecode] Bug: dmidecode -ut4 segfaults

2021-01-18 Thread Jerry Hoemann
ave not RCA'd the issue. Can you reproduce in your environment? Thanks Jerry -- --------- Jerry Hoemann

Re: [dmidecode] [PATCH] dmidecode: Fix crash with option -u

2021-01-18 Thread Jerry Hoemann
On Mon, Jan 18, 2021 at 02:11:01PM +0100, Jean Delvare wrote: > A segmentation fault was reported with option -u. Turns out to be a > stupid thinko where the buffer offset was reset at the wrong loop > depth. > > Reported-by: Jerry Hoemann > Fixes: da06888d08b9 ("dmidecode

Re: [dmidecode] Bug: dmidecode -ut4 segfaults

2021-01-18 Thread Jerry Hoemann
On Mon, Jan 18, 2021 at 01:49:37PM +0100, Jean Delvare wrote: > Hi Jerry, > > On Mon, 18 Jan 2021 01:26:10 -0700, Jerry Hoemann wrote: > > On current dmidecode I build, I am seeing core dumps (SEGFAULT) when > > running: > > > > ./dmidecode -ut4 --from-d

[dmidecode] [PATCH 0/1] dmioem: Decode HPE OEM Records 199

2021-02-25 Thread Jerry Hoemann
4 records. As a given BIOS can support multiple CPU SKUs, the BIOS may contain patches for CPUs not present on the system. Jerry Hoemann (1): dmioem: HPE OEM Record 199 dmioem.c | 30 ++ 1 file changed, 30 insertions(+)

[dmidecode] [PATCH 1/1] dmioem: HPE OEM Record 199

2021-02-25 Thread Jerry Hoemann
Decode HPE OEM Record 199: CPU Microcode Patch. Signed-off-by: Jerry Hoemann --- dmioem.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/dmioem.c b/dmioem.c index 8fe84e0..58ad400 100644 --- a/dmioem.c +++ b/dmioem.c @@ -310,6 +310,36 @@ static int

Re: [dmidecode] [PATCH 1/1] dmioem: HPE OEM Record 199

2021-03-01 Thread Jerry Hoemann
On Mon, Mar 01, 2021 at 07:56:31PM +0100, Jean Delvare wrote: > Hi Jerry, > > On Thu, 25 Feb 2021 12:39:55 -0700, Jerry Hoemann wrote: > > Decode HPE OEM Record 199: CPU Microcode Patch. > > > > Signed-off-by: Jerry Hoemann > > --- > > dmioem.c | 30 +++

Re: [dmidecode] [PATCH 1/1] dmioem: HPE OEM Record 199

2021-03-03 Thread Jerry Hoemann
On Tue, Mar 02, 2021 at 01:57:43PM +0100, Jean Delvare wrote: > On Mon, 1 Mar 2021 23:11:23 -0700, Jerry Hoemann wrote: > > On Mon, Mar 01, 2021 at 07:56:31PM +0100, Jean Delvare wrote: ... > > > > > + cpuid = DWORD(data + ptr +

Re: [dmidecode] [PATCH 3/6] dmidecode: Split CPUID type detection from dmi_processor_id

2021-03-04 Thread Jerry Hoemann
definitions. Try: extern enum cpuid_type cpuid_type; > + > int is_printable(const u8 *data, int len); > const char *dmi_string(const struct dmi_header *dm, u8 s); > void dmi_print_memory_size(const char *addr, u64 code, int shift); > > -- > Jean Delvare > SUSE L3

Re: [dmidecode] [PATCH 6/6] dmidecode: Save the CPUID format

2021-03-04 Thread Jerry Hoemann
ne) Inverted sense on cpuid_type comparison. Should be: if (h.type == 4 && h.length >= 0x1A && cpuid_type == cpuid_none) > + cpuid_type = dmi_get_cpuid_type(&h); > data = next; > } > > > -- >

[dmidecode] [PATCH v2 0/1] dmioem: Decode HPE OEM Records 199

2021-03-06 Thread Jerry Hoemann
n ISO 8601 format: -MM-DD o Use pr_attr/pr_subattr to visually group the individual ucode patches. o Print patch id in 0x%x format to be consistent with intel documentation. o Change order of fields to have CPU ID 1st, then date, then patchid. Jerry Hoemann (1): dmioem: HPE OEM Record 199

[dmidecode] [PATCH v2 1/1] dmioem: HPE OEM Record 199

2021-03-06 Thread Jerry Hoemann
Decode HPE OEM Record 199: CPU Microcode Patch. Signed-off-by: Jerry Hoemann --- dmioem.c | 25 + 1 file changed, 25 insertions(+) diff --git a/dmioem.c b/dmioem.c index 3cdfdea..08e4d91 100644 --- a/dmioem.c +++ b/dmioem.c @@ -313,6 +313,31 @@ static int dmi_decode_hp

Re: [dmidecode] [PATCH v2 1/1] dmioem: HPE OEM Record 199

2021-03-09 Thread Jerry Hoemann
D field, it > doesn't look like an actual CPUID number. Any idea? > > -- > Jean Delvare > SUSE L3 Support -- - Jerry Hoemann Software Engineer Hewlett Packard Enterprise - ___ https://lists.nongnu.org/mailman/listinfo/dmidecode-devel

Re: [dmidecode] [PATCH v2 1/1] dmioem: HPE OEM Record 199

2021-03-10 Thread Jerry Hoemann
tel format the same. It will be a few days before I can send you an updated patch. Jerry -- --------- Jerry Hoemann Software Engineer

[dmidecode] [PATCH v3 0/1] dmioem: Decode HPE OEM Records 199

2021-03-15 Thread Jerry Hoemann
know that the chip is either Intel or AMD. b. Proliant that we're decoding the OEM 199 record on don't have the older AMD processors which have family <= 15. This allows us to reconstruct the CPUID by suppling the base family. o restrict to Gen9 and later. Jer

[dmidecode] [PATCH v3 1/1] dmioem: HPE OEM Record 199

2021-03-15 Thread Jerry Hoemann
Decode HPE OEM Record 199: CPU Microcode Patch. Signed-off-by: Jerry Hoemann --- dmioem.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/dmioem.c b/dmioem.c index 3cdfdea..3ed5f61 100644 --- a/dmioem.c +++ b/dmioem.c @@ -313,6 +313,37 @@ static int

[dmidecode] [PATCH v4 0/1] dmioem: Decode HPE OEM Records 199

2021-06-19 Thread Jerry Hoemann
hanges for v4 = o return 0 if (gen < G9). o change comment from "//" to "/* ... */" o Fix two double spaces. Note: Depends upon Jean's in progress 4-Mar patch to create function dmi_print_cpuid(). Jerry Hoemann (1): dmioem: HPE OEM Record 199 dmi

[dmidecode] [PATCH v4 1/1] dmioem: HPE OEM Record 199

2021-06-19 Thread Jerry Hoemann
Decode HPE OEM Record 199: CPU Microcode Patch. Signed-off-by: Jerry Hoemann --- dmioem.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/dmioem.c b/dmioem.c index 3cdfdea..53ac9e9 100644 --- a/dmioem.c +++ b/dmioem.c @@ -313,6 +313,37 @@ static int

Re: [dmidecode] [PATCH] dmioem: Fix HP type 203 preliminary checks and header

2022-05-24 Thread Jerry Hoemann
her records are handled. > > Also drop the duplicate company name in the header. > > Signed-off-by: Jean Delvare > Cc: Jerry Hoemann > --- > dmioem.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jerry Hoemann > > --- dmidecode.

[dmidecode] [PATCH] dmioem: Decode HPE OEM Record 238

2022-05-25 Thread Jerry Hoemann
Decode HPE OEM Record 238: USB Port Connector Correlation Record. Signed-off-by: Jerry Hoemann --- dmioem.c | 89 1 file changed, 89 insertions(+) diff --git a/dmioem.c b/dmioem.c index 61569a6..e42a35f 100644 --- a/dmioem.c +++ b

Re: [dmidecode] [PATCH] dmioem: Decode HPE OEM Record 238

2022-05-30 Thread Jerry Hoemann
On Mon, May 30, 2022 at 03:00:45PM +0200, Jean Delvare wrote: > Hi Jerry, > > On Wed, 25 May 2022 16:35:42 -0600, Jerry Hoemann wrote: > > Decode HPE OEM Record 238: USB Port Connector Correlation Record. > > > > Signed-off-by: Jerry Hoemann

[dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 238

2022-05-30 Thread Jerry Hoemann
Decode HPE OEM Record 238: USB Port Connector Correlation Record. Signed-off-by: Jerry Hoemann --- dmioem.c | 89 1 file changed, 89 insertions(+) diff --git a/dmioem.c b/dmioem.c index 61569a6..9f38a2f 100644 --- a/dmioem.c +++ b

[dmidecode] [PATCH v2 0/1] Decode HPE OEM Record 238

2022-05-30 Thread Jerry Hoemann
Decode HPE OEM Record 238: USB Port Connector Correlation Record. === Changes for v2 === Address code review comments from Jean Delvare. [1] [1] https://lists.nongnu.org/archive/html/dmidecode-devel/2022-05/msg00014.html Jerry Hoemann (1): dmioem: Decode HPE OEM Record 238 dmioem.c

Re: [dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 238

2022-05-31 Thread Jerry Hoemann
On Tue, May 31, 2022 at 09:34:22AM +0200, Jean Delvare wrote: > On Mon, 30 May 2022 12:30:09 -0600, Jerry Hoemann wrote: > > Decode HPE OEM Record 238: USB Port Connector Correlation Record. > > > > Signed-off-by: Jerry Hoemann >

Re: [dmidecode] [PATCH] dmioem: Nicer display of PCI device (HPE type 238)

2022-06-02 Thread Jerry Hoemann
On Wed, Jun 01, 2022 at 10:06:15AM +0200, Jean Delvare wrote: > Use the standard PCI device format (bus:dev.fn) to designate the > parent PCI device of the USB port, so it is much easier to lookup > in the output of lspci for example. > > Signed-off-by: Jean Delvare > Cc: Jer

[dmidecode] [PATCH] dmioem: Decode HPE OEM Record 194

2022-06-03 Thread Jerry Hoemann
Decode HPE OEM Record 194: Super IO Enable/Disable Features Signed-off-by: Jerry Hoemann --- dmioem.c | 21 + 1 file changed, 21 insertions(+) diff --git a/dmioem.c b/dmioem.c index 759d778..f15247a 100644 --- a/dmioem.c +++ b/dmioem.c @@ -364,6 +364,27 @@ static int

[dmidecode] [PATCH] dmioem: Decode HPE OEM Record 237

2022-06-07 Thread Jerry Hoemann
Decode HPE OEM Record 237: DIMM Vendor Part Number Information Signed-off-by: Jerry Hoemann --- dmioem.c | 28 1 file changed, 28 insertions(+) diff --git a/dmioem.c b/dmioem.c index b542c5a..567fb7f 100644 --- a/dmioem.c +++ b/dmioem.c @@ -663,6 +663,34 @@ static

[dmidecode] [PATCH] dmioem: Incorrect use of static

2022-06-17 Thread Jerry Hoemann
The *str = "Reserved" is intended as the default value when index is outside of the array. str shouldn't retain values from an earlier invocation of the function. Signed-off-by: Jerry Hoemann --- dmioem.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --g

[dmidecode] [PATCH] dmioem: Decode HPE OEM Record 224

2022-06-21 Thread Jerry Hoemann
Decode HPE OEM Record 224: Trusted Module (TPM or TCM) Status (Type 224) Signed-off-by: Jerry Hoemann --- dmioem.c | 119 +++ 1 file changed, 119 insertions(+) diff --git a/dmioem.c b/dmioem.c index c26fff9..982e94e 100644 --- a/dmioem.c

Re: [dmidecode] [PATCH] dmioem: Decode HPE OEM Record 224

2022-06-27 Thread Jerry Hoemann
On Thu, Jun 23, 2022 at 01:20:54PM +0200, Jean Delvare wrote: > Hi Jerry, > > On Tue, 21 Jun 2022 15:59:07 -0600, Jerry Hoemann wrote: > > Decode HPE OEM Record 224: Trusted Module (TPM or TCM) Status (Type 224) > > > > Signed-off-by: Jerry Hoemann

[dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 224

2022-06-27 Thread Jerry Hoemann
Decode HPE OEM Record 224: Trusted Module (TPM or TCM) Status (Type 224) Signed-off-by: Jerry Hoemann --- dmioem.c | 120 +++ 1 file changed, 120 insertions(+) diff --git a/dmioem.c b/dmioem.c index c26fff9..a46790a 100644 --- a/dmioem.c

[dmidecode] [PATCH v2 0/1] dmioem: Decode HPE OEM Record 224

2022-06-27 Thread Jerry Hoemann
Decode HPE OEM Record 224: Trusted Module (TPM or TCM) Status (Type 224) === Changes for v2 === Address code review comments from Jean Delvare. [1] [1] https://lists.nongnu.org/archive/html/dmidecode-devel/2022-06/msg00010.html Jerry Hoemann (1): dmioem: Decode HPE OEM Record 224 dmioem.c

Re: [dmidecode] [PATCH v2 0/1] dmioem: Decode HPE OEM Record 224

2022-07-14 Thread Jerry Hoemann
On Mon, Jun 27, 2022 at 02:37:45PM -0600, Jerry Hoemann wrote: > Decode HPE OEM Record 224: Trusted Module (TPM or TCM) Status (Type 224) > > === Changes for v2 === Jean, did you have any questions on this? Jerry > > Address code review comments from Jean Delvare. [1] &g

[dmidecode] [PATCH] dmioem: Decode HPE OEM Record 230

2022-07-19 Thread Jerry Hoemann
Decode HPE OEM Record 230: Power Supply Information Signed-off-by: Jerry Hoemann --- dmioem.c | 52 1 file changed, 52 insertions(+) diff --git a/dmioem.c b/dmioem.c index 0c73771..24b2b9e 100644 --- a/dmioem.c +++ b/dmioem.c @@ -389,6

Re: [dmidecode] [PATCH] dmioem: Fix segmentation fault in dmi_hp_240_attr()

2022-08-04 Thread Jerry Hoemann
HPE type 240 attributes in a nicer way") > Cc: Jerry Hoemann Tested-by: Jerry Hoemann Did you consider adding a check that format is nonzero to pr_attr() like pr_list_start() does? Thanks Jerry > --- > dmioem.c|5 +++-- > dmioutput.c | 12 > dmio

Re: [dmidecode] [PATCH] dmioem: Decode HPE OEM Record 230

2022-08-04 Thread Jerry Hoemann
On Wed, Aug 03, 2022 at 02:59:40PM +0200, Jean Delvare wrote: > Hi Jerry, > > On Tue, 19 Jul 2022 15:47:03 -0600, Jerry Hoemann wrote: > > Decode HPE OEM Record 230: Power Supply Information > > > > Signed-off-by: Jerry Hoemann

Re: [dmidecode] [PATCH] dmioem: Fix segmentation fault in dmi_hp_240_attr()

2022-08-08 Thread Jerry Hoemann
On Fri, Aug 05, 2022 at 11:57:04AM +0200, Jean Delvare wrote: > On Fri, 5 Aug 2022 11:45:19 +0200, Jean Delvare wrote: > > On Thu, 4 Aug 2022 11:29:05 -0600, Jerry Hoemann wrote: > > > Did you consider adding a check that format is nonzero to pr_attr() > > >

[dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 230

2022-08-08 Thread Jerry Hoemann
Decode HPE OEM Record 230: Power Supply Information Signed-off-by: Jerry Hoemann --- dmioem.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/dmioem.c b/dmioem.c index 0c73771..c4db435 100644 --- a/dmioem.c +++ b/dmioem.c @@ -389,6

[dmidecode] [PATCH v2 0/1] dmioem: Decode HPE OEM Record 230

2022-08-08 Thread Jerry Hoemann
Decode HPE OEM Record 230: Power Supply Information === Changes for v2 === Address code review comments from Jean Delvare. [1] [1] https://lists.nongnu.org/archive/html/dmidecode-devel/2022-08/msg3.html Jerry Hoemann (1): dmioem: Decode HPE OEM Record 230 dmioem.c | 51

Re: [dmidecode] [PATCH v2 0/1] dmioem: Decode HPE OEM Record 230

2022-08-29 Thread Jerry Hoemann
On Mon, Aug 08, 2022 at 01:30:36PM -0600, Jerry Hoemann wrote: > Decode HPE OEM Record 230: Power Supply Information > Jean, Did you have any questions/comments on version 2 of the patch? Thanks Jerry > > === Changes for v2 === > > Address code review comments from

Re: [dmidecode] [PATCH v2 1/1] dmioem: Decode HPE OEM Record 230

2022-09-12 Thread Jerry Hoemann
On Wed, Sep 07, 2022 at 11:53:13AM +0200, Jean Delvare wrote: > Hi Jerry, > > On Mon, 8 Aug 2022 13:30:37 -0600, Jerry Hoemann wrote: > > Decode HPE OEM Record 230: Power Supply Information > > > > Signed-off-by: Jerry Hoemann

[dmidecode] [PATCH v3 0/1] dmioem: Decode HPE OEM Record 230

2022-09-13 Thread Jerry Hoemann
s" by 1 bit. [1] https://lists.nongnu.org/archive/html/dmidecode-devel/2022-08/msg3.html [2] https://lists.nongnu.org/archive/html/dmidecode-devel/2022-09/msg2.html Jerry Hoemann (1): dmioem: Decode HPE OEM Record 230 dmioem.c | 52

[dmidecode] [PATCH v3 1/1] dmioem: Decode HPE OEM Record 230

2022-09-13 Thread Jerry Hoemann
Decode HPE OEM Record 230: Power Supply Information Signed-off-by: Jerry Hoemann --- dmioem.c | 52 1 file changed, 52 insertions(+) diff --git a/dmioem.c b/dmioem.c index 2c24bfb..7049537 100644 --- a/dmioem.c +++ b/dmioem.c @@ -390,6

[dmidecode] [PATCH] dmioem: Update HPE OEM Record 238

2022-09-19 Thread Jerry Hoemann
Spec was updated to clarify that the device is a USB Hub for NAND controller. Not the NAND controller itself. Signed-off-by: Jerry Hoemann --- dmioem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dmioem.c b/dmioem.c index 9f6c7e9..6000e1c 100644 --- a/dmioem.c +++ b

[dmidecode] [RFC] dmioem: Decode HPE OEM Record 242

2022-09-27 Thread Jerry Hoemann
From: Jerry Hoemann Decode HPE OEM Record 242: Hard Drive Inventory Record Signed-off-by: Jerry Hoemann --- dmioem.c | 117 +++ 1 file changed, 117 insertions(+) diff --git a/dmioem.c b/dmioem.c index 6000e1c..250c2c6 100644 --- a/dmioem.c

  1   2   >