On 21/08/18 21:22, Petr Mensik wrote:
> Hi Simon and all others,
>
> I have tried running dnsmasq under coverity, static analysis tool. It
> found some warnings. I have fixed some things. Most obvious error was
> inconsistent handling of buffer length of interface names. Buffer size
> is IFNAMSIZ
On 10/08/18 13:37, Petr Menšík wrote:
> Hello,
>
> we discovered our dnsmasq were using also privileged source ports when
> sending queries. Interesting enough, it has right to do it, because it
> has to listen also on privileged port. It never drops such privilege.
>
> It was fixed in commit
Thanks for chasing that down. Your patch will fix it, but I think it's
probably better to solve the problem at source, where we copy addresses
out of packets, rather than pass unaligned pointers to struct in6_addr
around and patch things up at the other end. That stops this coming and
biting us
Hi Simon and all others,
I have tried running dnsmasq under coverity, static analysis tool. It
found some warnings. I have fixed some things. Most obvious error was
inconsistent handling of buffer length of interface names. Buffer size
is IFNAMSIZ long, that is 16 bytes. But if interface should
Hi, Simon
Faced with dnsmasq crash on aarch64 (32bit userspace,
arm-buildroot-linux-gnueabi-gcc 5.3.0) with dhcpv6 stateful configured.
Unaligned packet’s req_addr is used in lease6_allocate() for struct copy since
2.67test15 (commit 89500e31f199e9ae1eadc86213b911ff44d30d6f).
As for other
