Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-19 Thread Simon Kelley
On 14/09/2021 13:43, Dominik DL6ER wrote: > Hey Simon, > > > I'm resubmitting the patch with these changes: > > 0. Submit the correct patch with the correct memory allocation > > 1. Rebased onto Petr's change to option.c > > 2. Removed the explain feature > > 3. Added failsafe checks to the

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-14 Thread Dominik DL6ER
Hey Simon, I'm resubmitting the patch with these changes: 0. Submit the correct patch with the correct memory allocation 1. Rebased onto Petr's change to option.c 2. Removed the explain feature 3. Added failsafe checks to the mallocs 4. Added a hint in network.c when there are more servers

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-12 Thread Dominik DL6ER
Hey Simon, On Sat, 2021-09-11 at 23:42 +0100, Simon Kelley wrote: > 1) gen_rev6 fails to allocate the *domains array, and crashes. what did you try? It didn't crash for me. But I see that adding malloc failsafe checks is something I've forgotten. I'll resubmit the patch, also with removed

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-11 Thread Simon Kelley
On 11/09/2021 16:23, Dominik DL6ER wrote: > Hey Simon, > > On Fri, 2021-09-10 at 23:48 +0100, Simon Kelley wrote: >> For IPv6, this seems like an obviously good thing to do, since >> one >> --rev-server can create as most eight .ip6.arpa, but for >> IPv4, that >> goes up to 128 since for

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-11 Thread Dominik DL6ER
Hey Simon, On Fri, 2021-09-10 at 23:48 +0100, Simon Kelley wrote: > For IPv6, this seems like an obviously good thing to do, since > one > --rev-server can create as most eight .ip6.arpa, but for > IPv4, that > goes up to 128 since for instance 192.168.1.0/25 expands to > >

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-10 Thread Simon Kelley
On 10/09/2021 11:27, Dominik DL6ER wrote: > Hey Joerg, > > On Fri, 2021-09-10 at 10:13 +0200, jo...@schuetter.org wrote: >> rev-server=fe80::/10,192.168.178.1 > > dnsmasq always only accepted IPv6 prefixes that are a multiple of > 4. There was just no enforcing of this before v2.86. > > Looking

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-10 Thread joerg
Hello Dominik On 2021-09-10 12:27, Dominik DL6ER wrote: Hey Joerg, On Fri, 2021-09-10 at 10:13 +0200, jo...@schuetter.org wrote: rev-server=fe80::/10,192.168.178.1 dnsmasq always only accepted IPv6 prefixes that are a multiple of 4. There was just no enforcing of this before v2.86. From

Re: [Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-10 Thread Dominik DL6ER
Hey Joerg, On Fri, 2021-09-10 at 10:13 +0200, jo...@schuetter.org wrote: > rev-server=fe80::/10,192.168.178.1 dnsmasq always only accepted IPv6 prefixes that are a multiple of 4. There was just no enforcing of this before v2.86. Looking at the v2.85 code, dnsmasq will have added > fe80::/8 for

[Dnsmasq-discuss] rev-server=fe80::/10, 192.168.178.1 no longer accepted (version 2.86)

2021-09-10 Thread joerg
Hello After upgrading dnsmasq from 2.85 to 2.86 (debian sid) the rev-server lines regarding IPv6 are no longer accepted error: bad IPv6 prefix at line 26 of /etc/dnsmasq.d/05-local.conf config line: rev-server=fe80::/10,192.168.178.1 Best Regards