Re: [Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

On Wed, Jun 28, 2017 at 09:21:49PM +, Rosen Penev wrote: > As far as I can tell, BSDs use GCC 4.2.1 because of GPLv2. The format > attribute has been supported since at least 3.3.2. It's not a C89 issue. > Clang has always supported the attribute. Most BSDs have migrated to Clang > because of L

Re: [Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

As far as I can tell, BSDs use GCC 4.2.1 because of GPLv2. The format attribute has been supported since at least 3.3.2. It's not a C89 issue. Clang has always supported the attribute. Most BSDs have migrated to Clang because of License. Not that I'm against removing the attribute. Just curious ab

Re: [Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

On 28/06/17 03:20, Rosen Penev wrote: > AFAIK Clang and GCC both support it. Any other relevant compilers? > > What do *BSD use? dnsmasq supports them? Policy is C89 and always has been. Cheers, Simon. > On Tue, Jun 27, 2017, 15:40 Simon Kelley > wrote: > >

Re: [Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

AFAIK Clang and GCC both support it. Any other relevant compilers? On Tue, Jun 27, 2017, 15:40 Simon Kelley wrote: > Patch applied, with the exception of the gcc-specific __attribute__ stuff. > > > Cheers, > > Simon. > > On 27/06/17 00:37, Rosen Penev wrote: > > --- > > contrib/lease-tools/dhcp

Re: [Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

Patch applied, with the exception of the gcc-specific __attribute__ stuff. Cheers, Simon. On 27/06/17 00:37, Rosen Penev wrote: > --- > contrib/lease-tools/dhcp_lease_time.c | 8 > src/auth.c| 6 +++--- > src/cache.c | 2 +- > src/

[Dnsmasq-discuss] [PATCH 2/2] Printf related fixes

--- contrib/lease-tools/dhcp_lease_time.c | 8 src/auth.c| 6 +++--- src/cache.c | 2 +- src/dnsmasq.h | 3 +++ src/lease.c | 1 + src/option.c | 2 +- src/tftp