Re: [Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-15 Thread Andy Hawkins
Hi, In article , Andy Hawkins wrote: > I'll take a look at your version of the code in git and see how it looks > compared to mine. Ok, things are a bit clearer after looking at the actual commit. My only comment (and it's a fairly personal one) is that I generally dislike seeing vari

Re: [Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-15 Thread Andy Hawkins
Hi, In article <0f10b5dc-7504-a92a-824d-ecc091b00...@thekelleys.org.uk>, Simon Kelley wrote: > Patch applied, with two modifications. > > 1) I added a check for strlen(in->name) not being zero. I don't know if > inotify could give us a zero-length filename, but if it did, we'd make > an

Re: [Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-14 Thread Simon Kelley
Patch applied, with two modifications. 1) I added a check for strlen(in->name) not being zero. I don't know if inotify could give us a zero-length filename, but if it did, we'd make an out-of-bounds array reference to in->name[-1]. I also saved the return from strlen(in->name) in a variable, rathe