Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-26 Thread David Woodhouse
On Mon, 2010-08-23 at 18:04 +0100, Timo Sirainen wrote: On Mon, 2010-08-23 at 17:33 +0100, David Woodhouse wrote: And thanks for not (yet) making it reject the invalid command with the 1:* in it I changed it in v2.0. -- I'll need to come up with a strategy for migrating to the

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-26 Thread Timo Sirainen
On Thu, 2010-08-26 at 14:32 +0100, David Woodhouse wrote: Or if you want flags for messages you haven't even seen yet, 1:4294967295 should work too. 1:4294967295 doesn't really fill me with joy either -- that assumes that a UID is limited to 32 bits unsigned... It is, as defined by RFC

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-26 Thread David Woodhouse
On Thu, 2010-08-26 at 17:02 +0100, Timo Sirainen wrote: On Thu, 2010-08-26 at 14:32 +0100, David Woodhouse wrote: Or if you want flags for messages you haven't even seen yet, 1:4294967295 should work too. 1:4294967295 doesn't really fill me with joy either -- that assumes that a

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-23 Thread Timo Sirainen
On Sat, 2010-08-21 at 16:15 +0100, David Woodhouse wrote: A00131 SELECT lists.bluez (QRESYNC (1154090296 1861 (1,120,1578,2064,2226,2280,2298 1,120,12037,12523,12685,12739,12757))) Dovecot doesn't like that though: A00131 BAD Error in IMAP command SELECT: Invalid QRESYNC parameters

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-23 Thread David Woodhouse
On Mon, 2010-08-23 at 15:40 +0100, Timo Sirainen wrote: Whops. Looks like I read the RFC a bit wrong. Fixed in v2.0 and v1.2 hg now. I guess I should release 1.2.14 then. Could you try that the fix works properly? At least it doesn't give any errors anymore.

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-23 Thread Timo Sirainen
On Mon, 2010-08-23 at 17:33 +0100, David Woodhouse wrote: And thanks for not (yet) making it reject the invalid command with the 1:* in it I changed it in v2.0. -- I'll need to come up with a strategy for migrating to the 'correct' command on the client side, given that older versions of

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-21 Thread David Woodhouse
On Thu, 2010-08-19 at 18:37 +0100, Timo Sirainen wrote: On Wed, 2010-08-18 at 22:27 +0100, David Woodhouse wrote: Aug 18 22:07:31 twosheds IMAP(dwmw2): : Panic: file mail-index-transaction.c: line 637 (mail_index_transaction_lookup): assertion failed: (seq = t-first_new_seq

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-19 Thread Timo Sirainen
On Wed, 2010-08-18 at 22:27 +0100, David Woodhouse wrote: Aug 18 22:07:31 twosheds IMAP(dwmw2): : Panic: file mail-index-transaction.c: line 637 (mail_index_transaction_lookup): assertion failed: (seq = t-first_new_seq seq = t-last_new_seq) A00131 SELECT lists.bluez (QRESYNC

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-19 Thread David Woodhouse
On Thu, 2010-08-19 at 18:37 +0100, Timo Sirainen wrote: Thanks, fixed: http://hg.dovecot.org/dovecot-1.2/rev/70fa6178380e Thanks. Obviously you've been able to test on exactly the same mailbox I'm using, so you'll not be surprised to hear that the patch works fine here too. Do shout if you see

Re: [Dovecot] 1.2.13 QRESYNC crash.

2010-08-19 Thread fakessh
On Thu, 19 Aug 2010 18:37:16 +0100, Timo Sirainen t...@iki.fi wrote: On Wed, 2010-08-18 at 22:27 +0100, David Woodhouse wrote: Aug 18 22:07:31 twosheds IMAP(dwmw2): : Panic: file mail-index-transaction.c: line 637 (mail_index_transaction_lookup): assertion failed: (seq =