Locking question for DRM

2010-04-23 Thread Dave Airlie
On Fri, Apr 23, 2010 at 8:37 PM, Alan Cox wrote: >> > and I can't see what makes this safe if the drm_release for the master >> > and a client occur at the same time ? >> >> lock_kernel in drm_release. We probably need to clean that up. > > I don't think that works. drm_open_helper doesn't appear

Locking question for DRM

2010-04-23 Thread Dave Airlie
On Fri, Apr 23, 2010 at 8:22 PM, Alan Cox wrote: > > Various bits of the DRM deal with minor->master: > > In the case of the open helper its protected by the struct mutex. > > In the release path it's protected on some paths, but not this one ... > > ? ? /* if the master has gone away we can't do

[PATCH] drm/radeon/kms: add accel parameter

2010-04-23 Thread Alex Deucher

[PATCH] drm/radeon/kms: add accel parameter

2010-04-23 Thread Alex Deucher
passing accel=0 will disable acceleration. This is useful for debugging. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/evergreen.c |2 +- drivers/gpu/drm/radeon/r100.c |2 +- drivers/gpu/drm/radeon/r300.c |2 +- drivers/gpu/drm/radeon/r420.c |2 +- dr

[Bug 27517] KMS breaks 3D on R200

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27517 --- Comment #6 from Pekka Oinas 2010-04-23 15:46:16 PDT --- I am also affected by this. It is caused by incorrect fake texture handling in CS checker or something. More and a possible "fix" (it just disables texture checking) here: https://bugs.f

[Bug 27517] KMS breaks 3D on R200

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27517 --- Comment #6 from Pekka Oinas 2010-04-23 15:46:16 PDT --- I am also affected by this. It is caused by incorrect fake texture handling in CS checker or something. More and a possible "fix" (it just disables texture checking) here: https://bugs.

[PATCH] drm/radeon/kms: add accel parameter

2010-04-23 Thread Alex Deucher
>From 114f3491a411f50a0de1d59475fc267efd5afa6a Mon Sep 17 00:00:00 2001 From: Alex Deucher Date: Fri, 23 Apr 2010 17:12:46 -0400 Subject: [PATCH] drm/radeon/kms: add accel parameter passing accel=0 will disable acceleration. This is useful for debugging. Signed-off-by: Alex Deucher --- driver

2.6.34-rc5: Reported regressions from 2.6.33

2010-04-23 Thread Jerome Glisse
On Wed, Apr 21, 2010 at 12:57:58PM -0400, Nick Bowler wrote: > On Wed, Apr 21, 2010 at 07:15:38AM +0200, Rafael J. Wysocki wrote: > > On Tuesday 20 April 2010, Nick Bowler wrote: > > > Please list these two similar regressions from 2.6.33 in the r600 DRM: > > > > > > * r600 CS checker rejects GL_

[Bug 26715] random freeze in ioquake3 like games

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=26715 --- Comment #6 from Eemil Lagerspetz 2010-04-23 12:04:22 PDT --- > proceeded to start compiz . Correction no compiz. Compiz messes up openarena's refresh rate for me and results in a black screen which is responsive (ctrl-alt-F1) until the random

[Bug 26715] random freeze in ioquake3 like games

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=26715 --- Comment #6 from Eemil Lagerspetz 2010-04-23 12:04:22 PDT --- > proceeded to start compiz . Correction no compiz. Compiz messes up openarena's refresh rate for me and results in a black screen which is responsive (ctrl-alt-F1) until the rando

Locking question for DRM

2010-04-23 Thread Alan Cox
> > I don't think that works. drm_open_helper doesn't appear to be under the > > BKL merely the struct mutex. > > It blocks the case you specified of two releases happening together. But not parallel open/release > > But setmaster can sleep so the BKL is dropped on contention of the > > struct_m

Locking question for DRM

2010-04-23 Thread Alan Cox
> > and I can't see what makes this safe if the drm_release for the master > > and a client occur at the same time ? > > lock_kernel in drm_release. We probably need to clean that up. I don't think that works. drm_open_helper doesn't appear to be under the BKL merely the struct mutex. > > The se

[Bug 26715] random freeze in ioquake3 like games

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=26715 --- Comment #5 from Eemil Lagerspetz 2010-04-23 11:24:22 PDT --- This is on an eee pc 901, i915, and also with latest git drivers from http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/ . I downloaded the ubuntu xorg-edgers intel drivers f

[Bug 26715] random freeze in ioquake3 like games

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=26715 --- Comment #5 from Eemil Lagerspetz 2010-04-23 11:24:22 PDT --- This is on an eee pc 901, i915, and also with latest git drivers from http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/ . I downloaded the ubuntu xorg-edgers intel drivers

Locking question for DRM

2010-04-23 Thread Alan Cox
Various bits of the DRM deal with minor->master: In the case of the open helper its protected by the struct mutex. In the release path it's protected on some paths, but not this one ... /* if the master has gone away we can't do anything with the lock */ if (file_priv->minor->maste

[git pull] drm radeon fixes

2010-04-23 Thread Dave Airlie
Some minor fixes to the radeon KMS driver three evergreen related one for earlier cards. The following changes since commit b78315f051de8d207bead90470aa216c0617572b: Jesse Barnes (1): drm: delay vblank cleanup until after driver unload are available in the git repository at: ssh://

[Bug 27443] radeonFreeTexImageData: Assertion `!image->base.Data' failed when running Ogre3D samples

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27443 Laurent carlier changed: What|Removed |Added CC||crazy-ivano...@gmx.net --- Comment #4

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27810 Laurent carlier changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 27443] radeonFreeTexImageData: Assertion `!image->base.Data' failed when running Ogre3D samples

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27443 Laurent carlier changed: What|Removed |Added CC||crazy-ivanovic at gmx.net --- Comment

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27810 Laurent carlier changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 26114] Black screen on The Sims 3 beginning

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=26114 --- Comment #7 from Rafał Miłecki 2010-04-23 04:34:34 PDT --- This is totally crazy/random :| Earlier this month I updated mesa to: commit 4c26cdbe01619abad413b09317f2842dcf1a4d57 Author: Dave Airlie Date: Sat Apr 3 21:52:09 2010 +1000 r300g

[Bug 26114] Black screen on The Sims 3 beginning

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=26114 --- Comment #7 from Rafa? Mi?ecki 2010-04-23 04:34:34 PDT --- This is totally crazy/random :| Earlier this month I updated mesa to: commit 4c26cdbe01619abad413b09317f2842dcf1a4d57 Author: Dave Airlie Date: Sat Apr 3 21:52:09 2010 +1000 r300

Re: Locking question for DRM

2010-04-23 Thread Alan Cox
> > I don't think that works. drm_open_helper doesn't appear to be under the > > BKL merely the struct mutex. > > It blocks the case you specified of two releases happening together. But not parallel open/release > > But setmaster can sleep so the BKL is dropped on contention of the > > struct_m

Locking question for DRM

2010-04-23 Thread Alan Cox
Various bits of the DRM deal with minor->master: In the case of the open helper its protected by the struct mutex. In the release path it's protected on some paths, but not this one ... /* if the master has gone away we can't do anything with the lock */ if (file_priv->minor->maste

Re: Locking question for DRM

2010-04-23 Thread Dave Airlie
On Fri, Apr 23, 2010 at 8:37 PM, Alan Cox wrote: >> > and I can't see what makes this safe if the drm_release for the master >> > and a client occur at the same time ? >> >> lock_kernel in drm_release. We probably need to clean that up. > > I don't think that works. drm_open_helper doesn't appear

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #3 from Nils Kneuper 2010-04-23 03:33:12 PDT --- Created an attachment (id=35252) --> (https://bugs.freedesktop.org/attachment.cgi?id=35252) glxinfo output -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #3 from Nils Kneuper 2010-04-23 03:33:12 PDT --- Created an attachment (id=35252) --> (https://bugs.freedesktop.org/attachment.cgi?id=35252) glxinfo output -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #2 from Nils Kneuper 2010-04-23 03:32:54 PDT --- Created an attachment (id=35251) --> (https://bugs.freedesktop.org/attachment.cgi?id=35251) Xorg.0.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #2 from Nils Kneuper 2010-04-23 03:32:54 PDT --- Created an attachment (id=35251) --> (https://bugs.freedesktop.org/attachment.cgi?id=35251) Xorg.0.log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #1 from Nils Kneuper 2010-04-23 03:32:32 PDT --- Created an attachment (id=35250) --> (https://bugs.freedesktop.org/attachment.cgi?id=35250) dmesg output for my system -- Configure bugmail: https://bugs.freedesktop.org/userprefs.c

[Bug 27810] R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27810 --- Comment #1 from Nils Kneuper 2010-04-23 03:32:32 PDT --- Created an attachment (id=35250) --> (https://bugs.freedesktop.org/attachment.cgi?id=35250) dmesg output for my system -- Configure bugmail: https://bugs.freedesktop.org/userprefs.c

Re: Locking question for DRM

2010-04-23 Thread Alan Cox
> > and I can't see what makes this safe if the drm_release for the master > > and a client occur at the same time ? > > lock_kernel in drm_release. We probably need to clean that up. I don't think that works. drm_open_helper doesn't appear to be under the BKL merely the struct mutex. > > The se

[Bug 27810] New: R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27810 Summary: R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (Al

[Bug 27810] New: R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27810 Summary: R600: using >=2.6.34-rc4 JackKeane and Ankh2 crash at start, after (rendered) intro sequences Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (Al

Re: Locking question for DRM

2010-04-23 Thread Dave Airlie
On Fri, Apr 23, 2010 at 8:22 PM, Alan Cox wrote: > > Various bits of the DRM deal with minor->master: > > In the case of the open helper its protected by the struct mutex. > > In the release path it's protected on some paths, but not this one ... > >     /* if the master has gone away we can't do

Re: 2.6.34-rc5: Reported regressions from 2.6.33

2010-04-23 Thread Jerome Glisse
On Wed, Apr 21, 2010 at 12:57:58PM -0400, Nick Bowler wrote: > On Wed, Apr 21, 2010 at 07:15:38AM +0200, Rafael J. Wysocki wrote: > > On Tuesday 20 April 2010, Nick Bowler wrote: > > > Please list these two similar regressions from 2.6.33 in the r600 DRM: > > > > > > * r600 CS checker rejects GL_

[Bug 27571] Regression: r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer.

2010-04-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27571 Jerome Glisse changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 27571] Regression: r600 CS checker rejects GL_DEPTH_TEST w/o depth buffer.

2010-04-23 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=27571 Jerome Glisse changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[PATCH] drm/radeon/kms/evergreen: No EnableYUV table

2010-04-23 Thread Alex Deucher

[PATCH] drm/radeon/kms/evergreen: No EnableYUV table

2010-04-23 Thread Alex Deucher
DCE4 cards don't have an EnableYUV table. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_encoders.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c index 559c9ce..256036b