Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread SF Markus Elfring
>> It seems that I got no responses so far for clarification requests >> according to the documentation in a direction I hoped for. > > That's because you are pretty unresponsive to direction. From which places did you get this impression? > You've gotten _many_ replies to your patches I got t

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Archit Taneja
On 11/28/2017 06:35 AM, Brian Norris wrote: Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Reviewed-by: Archit Taneja Signed-off-by:

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Archit Taneja
Hi, Thanks a lot for working on this. Some comments below. On 11/28/2017 07:25 AM, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|

[git pull resend] drm fixes

2017-11-27 Thread Dave Airlie
Hi Linus, I sent this last week as a follow on to the one you pulled, the tag hasn't changed but the pull request has as you pulled the old tag. This has a TTM regression fix for some virt gpus (bochs vga), a few i915 stable fixes, one vc4 fix, one uapi fix. Dave. The following changes since co

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-27 Thread Christian Zigotzky
Is it better to enable SWIOTLB? Are there any advantages with SWIOTLB enabled? — Christian Sent from my iPhone > On 27. Nov 2017, at 15:53, Michel Dänzer wrote: > >> On 2017-11-27 01:17 PM, Tom St Denis wrote: >>> On 27/11/17 07:02 AM, Michel Dänzer wrote: On 2017-11-27 12:50 PM, Christia

Re: [PATCH 13/15] drm/vmwgfx: Use drm_mode_get_hv_timing() to populate plane clip rectangle

2017-11-27 Thread Sinclair Yeh
This looks okay to me. Reviewed-by: Sinclair Yeh On Thu, Nov 23, 2017 at 09:05:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. > > Note that this replaces crtc_state->adjusted_mode usage with > crtc_state->mode. The

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Brian Norris
Hi Nickey, Thanks for the quick version 2. You've fixed most of the the problems I pointed out, but you've missed at least one. On Tue, Nov 28, 2017 at 09:55:24AM +0800, Nickey Yang wrote: > Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge

[Bug 103808] [radeonsi, bisected] World of Warcraft scribbling all over screen

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103808 --- Comment #8 from Shmerl --- Marek pushed this fix: https://cgit.freedesktop.org/mesa/mesa/commit/?id=b5444877c0820b7848c07d1bc4e9a706f90894a5 I've just tested it with The Witcher 3 in Wine, and flickering is gone along with performance drop!

[Bug 103949] REG_WAIT timeout - dce110_stream_encoder_dp_blank line:930 - 4.15-rc1

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103949 --- Comment #1 from Barry G --- Created attachment 135744 --> https://bugs.freedesktop.org/attachment.cgi?id=135744&action=edit Xorg.0.log file -- You are receiving this mail because: You are the assignee for the bug.

[Bug 103949] REG_WAIT timeout - dce110_stream_encoder_dp_blank line:930 - 4.15-rc1

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103949 Bug ID: 103949 Summary: REG_WAIT timeout - dce110_stream_encoder_dp_blank line:930 - 4.15-rc1 Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: Li

Re: [PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Nickey Yang
Hi Brian, Below comments fixed in patch-v2:https://patchwork.kernel.org/patch/10078527/ but :"get_drvdata()" Thanks for review. Nickey. On 2017年11月28日 09:51, Brian Norris wrote: Hi Nickey, Several people already made comments on the initial version of this patch [1], and I don't think you'

[radeon-alex:amd-staging-drm-next 417/475] drivers/staging/vboxvideo/vbox_ttm.c:240:10: error: initialization from incompatible pointer type

2017-11-27 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: f3769c94f4e6a794dbb72601936199d9b258f7b7 commit: 67e032a0a9a8e26db6960aae59e7a319ac900f95 [417/475] drm/ttm: add context to driver move callback as well config: i386-allmodconfig (attached as .config) compiler: gcc-

[PATCH 1/3] drm: drm_fourcc: Add scaling and padding factor to drm_format_info

2017-11-27 Thread Hyun Kwon
From: Satish Kumar Nagireddy 'cpp_scale' can be used as a multiplying factor to calculate bytes per component based on color format. For eg. scaling factor of YUV420 8 bit format is 1 so multiplying factor is 1 (8/8) scaling factor of YUV420 10 bit format is 1.25 (10/8) 'padding_

[PATCH 0/3] Adding new drm formats needed by Xilinx IPs

2017-11-27 Thread Hyun Kwon
Hi, This series is to add new drm formats needed by some Xilinx IPs. Some formats have unique characteristics such as pixels not being byte-aligned. For instance, some 10bit formats have 2bit padding after every 3-10bit components: 32b[0]: 10b comp0 - 10b comp1 - 10b comp2 - 2b padding

[PATCH 2/3] uapi: drm: New fourcc codes needed by Xilinx Video IP

2017-11-27 Thread Hyun Kwon
From: Jeffrey Mouroux The Xilinx Video Mixer and Xilinx Video Framebuffer DMA IP support video memory formats that are not represented in the current DRM fourcc library. This patch adds those missing fourcc codes. Signed-off-by: Jeffrey Mouroux Signed-off-by: Hyun Kwon --- include/uapi/drm/d

[PATCH 3/3] drm: fourcc: Update DRM Framework with new fourcc codes

2017-11-27 Thread Hyun Kwon
From: Jeffrey Mouroux New fourcc codes have been added to support new YUV semi-planar and packed formats (including greyscale) needed by new Xilinx Video IP. This patch includes recognition of these new formats in the DRM framework library functions. Signed-off-by: Jeffrey Mouroux Signed-off-b

[radeon-alex:amd-staging-drm-next 413/475] drivers/staging/vboxvideo/vbox_ttm.c:392:8: error: too many arguments to function 'ttm_bo_validate'

2017-11-27 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: f3769c94f4e6a794dbb72601936199d9b258f7b7 commit: f4d284ea58186199a9e2757dd9571d8386172141 [413/475] drm/ttm: add operation ctx to ttm_bo_validate v2 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (D

[radeon-alex:amd-staging-drm-next 413/475] drivers/staging/vboxvideo/vbox_ttm.c:392:30: sparse: too many arguments for function ttm_bo_validate

2017-11-27 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: f3769c94f4e6a794dbb72601936199d9b258f7b7 commit: f4d284ea58186199a9e2757dd9571d8386172141 [413/475] drm/ttm: add operation ctx to ttm_bo_validate v2 reproduce: # apt-get install sparse git checkout f

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Matthias Kaehlcke
El Mon, Nov 27, 2017 at 05:05:38PM -0800 Brian Norris ha dit: > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back to us for removal. > > Signed-off-by: Brian

[PATCH v2 3/3] arm64: dts: rockchip: update mipi node for RK3399

2017-11-27 Thread Nickey Yang
This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399

[PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Nickey Yang
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH v2 1/3] dt-bindings: display: rockchip: update DSI controller

2017-11-27 Thread Nickey Yang
This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++ 1 file changed, 19 insertions(+), 4 de

[PATCH v2 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

2017-11-27 Thread Nickey Yang
We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. ChangeLog: v2: add err_p

Re: [PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Brian Norris
Hi Nickey, Several people already made comments on the initial version of this patch [1], and I don't think you've caught them all here yet. I'll repeat a few. Not sure if I've caught them all. [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/780120 On Tue, Nov 28,

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread Joe Perches
On Mon, 2017-11-27 at 22:48 +0100, SF Markus Elfring wrote: > It seems that I got no responses so far for clarification requests > according to the documentation in a direction I hoped for. That's because you are pretty unresponsive to direction. You've gotten _many_ replies to your patches to wh

[Bug 103783] atombios stuck in loop for more than 5secs

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103783 --- Comment #13 from Rene Barbosa --- Hey, Is your system using 'pcieport' module? I've added it to RUNTIME_PM_DRIVER_BLACKLIST in TLP's configuration and now the problem is fixed! Not sure why it's happening in Linux 4.13+ and not in 4.4 wi

[PATCH 3/3] arm64: dts: rockchip: update mipi node for RK3399

2017-11-27 Thread Nickey Yang
This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399

[PATCH 1/3] dt-bindings: display: rockchip: update DSI controller

2017-11-27 Thread Nickey Yang
This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++ 1 file changed, 19 insertions(+), 4 de

[PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

2017-11-27 Thread Nickey Yang
Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

2017-11-27 Thread Nickey Yang
We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Nickey Yang (3): dt-bindi

[PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-27 Thread Brian Norris
Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 +

[PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature

2017-11-27 Thread Anusha Srivatsa
Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions. v2: Add dri-devel to the CC list Cc: dri-devel@lists.freedesktop.org Cc: Ville Syrjala Cc: Jani Nikula Cc: Manasi Navare Signed-off-by: Anusha Srivatsa --- include/drm/drm_dp_helper.h |

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-11-27 Thread Brian Norris
(Dropping Mark, whose Rockchip address is dead; and fixing Chris's email again) On Mon, Nov 27, 2017 at 4:29 PM, Brian Norris wrote: > On Thu, Oct 26, 2017 at 09:44:14AM +, Philippe CORNU wrote: >> On 10/26/2017 06:13 AM, Archit Taneja wrote: >> > On 10/26/2017 06:39 AM, Brian Norris wrote: >

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-11-27 Thread Brian Norris
On Thu, Oct 26, 2017 at 09:44:14AM +, Philippe CORNU wrote: > On 10/26/2017 06:13 AM, Archit Taneja wrote: > > On 10/26/2017 06:39 AM, Brian Norris wrote: > >> somebody already working on refactoring existing Rockchip code to use > >> this? > > > > I don't know. If rockchip isn't interested in

Re: [PATCH] drm/ttm: fix populate_and_map() functions once more

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 7:21 AM, Christian König wrote: > This reverts "drm/ttm: Fix configuration error around populate_and_map() > functions". > > This fix has gone into the wrong direction. Those helpers should be > available even when neither CONFIG_INTEL_IOMMU nor CONFIG_SWIOTLB are > set. >

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

2017-11-27 Thread Alex Deucher
On Fri, Nov 24, 2017 at 5:32 AM, Christian König wrote: > Fixes interface changes done in the following commits: > drm/ttm: add operation ctx to ttm_bo_validate v2 > drm/ttm: add context to driver move callback as well > > I missed this driver because it is in the staging area. > > Signed-off-by:

[PATCH v2 0/2] qxl cursor fixes

2017-11-27 Thread Ray Strode
From: Ray Strode This series includes a small leak fix and a fix for an initial invisible cursor on wayland sessions. Ray Strode (2): drm/qxl: unref cursor bo when finished with it drm/qxl: reapply cursor after resetting primary drivers/gpu/drm/qxl/qxl_display.c | 63 ++

[PATCH 1/2] drm/qxl: unref cursor bo when finished with it

2017-11-27 Thread Ray Strode
From: Ray Strode qxl_cursor_atomic_update allocs a bo for the cursor that it never frees up at the end of the function. This commit fixes that. Signed-off-by: Ray Strode --- drivers/gpu/drm/qxl/qxl_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH 2/2] drm/qxl: reapply cursor after resetting primary

2017-11-27 Thread Ray Strode
From: Ray Strode QXL associates mouse state with its primary plane. Destroying a primary plane and putting a new one in place has the side effect of destroying the cursor as well. This commit changes the driver to reapply the cursor any time a new primary is created. It achieves this by keeping

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread SF Markus Elfring
> There is the generic stack dump on OOM so the module/line > is already known. Can such an implementation detail become better documented than in C source code? > The existence of these messages increases code size which > also make the OOM condition slightly more likely. Interesting view …

Re: [PATCH] drm/qxl: reapply cursor after resetting primary

2017-11-27 Thread Ray Strode
Hi, On Mon, Nov 27, 2017 at 4:07 PM Ray Strode wrote: ... > This commit changes the driver to reapply the cursor any time a new > primary is created. It achieves this by keeping a reference to the > cursor bo on the qxl_crtc struct. So i forgot this is on top of a small leak fix, too. For clarit

[PATCH 5/5] radeon_backlight: Delete a jump target in radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 22:03:03 +0100 * Replace a goto statement by a direct call of the function "kfree" in an if branch. * Delete the jump label "error" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/video/fbdev/aty/radeon_

[PATCH 4/5] radeon_backlight: Return directly after a failed kmalloc() in radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 21:50:28 +0100 Return directly after a call of the function "kmalloc" failed at the beginning. Signed-off-by: Markus Elfring --- drivers/video/fbdev/aty/radeon_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vi

[PATCH 3/5] radeon_backlight: Delete an unnecessary return statement in radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 21:37:52 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function. Signed-off-by: Markus Elfring --- drivers

[PATCH 1/5] radeon_backlight: Delete an error message for a failed memory allocation in radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 21:27:51 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/aty/radeon_backlight.c | 4 +--- 1 file changed, 1

[PATCH 2/5] radeon_backlight: Improve a size determination in radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 21:30:06 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 0/5] Radeon backlight: Adjustments for radeonfb_bl_init()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 22:14:04 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an error message for a failed memory allocation Improve a size determination Delete an unnecessary return statement Ret

[PATCH] drm/qxl: reapply cursor after resetting primary

2017-11-27 Thread Ray Strode
From: Ray Strode QXL associates mouse state with its primary plane. Destroying a primary plane and putting a new one in place has the side effect of destroying the cursor as well. This commit changes the driver to reapply the cursor any time a new primary is created. It achieves this by keeping

Re: [PATCH 09/13] staging: sm750fb: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Sudip Mukherjee
On Mon, Nov 27, 2017 at 11:25:05AM +0100, Daniel Vetter wrote: > On Fri, Nov 24, 2017 at 06:53:33PM +0100, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > > --- > > Why exactly do we have an fbdev driver in staging? Afaiui fbdev is > entirely closed for new drivers (pls convert to an

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-27 Thread Sudip Mukherjee
On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > > Almost all drivers using remove_conflicting_framebuffers() wrap it with > > the same code. Extract common part from PCI drivers into separate > > remove_conflicting_

[Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103743 --- Comment #6 from Nicolai Hähnle --- Thanks. To give you an update, this is a super subtle control flow handling bug in LLVM -- and the difference between the original shader and your modification at the LLVM input is merely that the sense of

[Bug 103783] atombios stuck in loop for more than 5secs

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103783 --- Comment #12 from vkr...@yahoo.com --- Uninstalling tlp and tlp-rdw packages eliminates the error. What I don't get is that runtime pm for amggpu driver is supposed to be disabled by default according to TLP docs. I'll try reinstalling TLP

[PATCH libdrm] Android: disable warnings causing errors

2017-11-27 Thread Rob Herring
AOSP master has changed the build default to -Werror making all the warnings errors. Override that with -Wno-error. Signed-off-by: Rob Herring --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index d487acb95fd4..e3de1069dfad 100644 -

Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

2017-11-27 Thread Harry Wentland
On 2017-11-27 09:57 AM, Gustavo A. R. Silva wrote: > dm_new_crtc_state->stream and disconnected_acrtc are being dereferenced > before they are null checked, hence there is a potential null pointer > dereference. > > Fix this by null checking such pointers before they are dereferenced. > > Address

Re: [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread Joe Perches
On Mon, 2017-11-27 at 10:43 -0600, Andrew F. Davis wrote: > On 11/26/2017 12:55 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 26 Nov 2017 19:46:09 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue was detected by usi

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread Geert Uytterhoeven
Hi Markus, On Mon, Nov 27, 2017 at 7:12 PM, SF Markus Elfring wrote: >>> Can a default allocation failure report provide the information >>> which you might expect so far? >> >> You should be able to answer that question yourself. > > I can not answer this detail completely myself because my know

[Bug 100387] War Thunder game has visual errors, missing textures

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100387 --- Comment #20 from russianneuroman...@ya.ru --- Possibly this bug is duplicate of bug 99349 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-de

[Bug 103913] DRM/Radeon GPU hang

2017-11-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103913 --- Comment #2 from ro...@beardandsandals.co.uk --- No applications are running other than gnome desktop itself. I doubt this actually a real GPU hang, that is just what it says in the syslog messages. Are fences used by the driver for anything o

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread SF Markus Elfring
>> Can a default allocation failure report provide the information >> which you might expect so far? > > You should be able to answer that question yourself. I can not answer this detail completely myself because my knowledge is incomplete about your concrete expectations for the exception handli

Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()

2017-11-27 Thread Jingoo Han
On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:03:03 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a

Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe()

2017-11-27 Thread Jingoo Han
On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Sun, 26 Nov 2017 15:00:16 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus El

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 1:00 PM, Michel Dänzer wrote: > On 2017-11-27 06:21 PM, Alex Deucher wrote: >> On AMD GPUs, we use several mechanisms to fetch the vbios >> rom depending on the platform. We try to read the rom >> back via the rom BAR and fall back to other methods in >> some cases. This

[PATCH 3/3] video: au1100fb: Delete an unnecessary variable initialisation in au1100fb_drv_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 18:40:23 +0100 The local variable "fbdev" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/video/fbdev/au1100fb.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

2017-11-27 Thread Michel Dänzer
On 2017-11-27 06:21 PM, Alex Deucher wrote: > On AMD GPUs, we use several mechanisms to fetch the vbios > rom depending on the platform. We try to read the rom > back via the rom BAR and fall back to other methods in > some cases. This leads to spurious error messages > from the pci rom code whic

[PATCH 2/3] video: au1100fb: Improve a size determination in au1100fb_drv_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 18:18:34 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/3] video: au1100fb: Delete an error message for a failed memory allocation in au1100fb_drv_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 18:14:41 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/au1100fb.c | 4 +--- 1 file changed, 1 insertion(+

[PATCH 0/3] video/fbdev/au1100fb: Adjustments for au1100fb_drv_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 18:53:21 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Improve a size determination Delete an unnecessary variable initialisatio

GPF with kernel 4.15-rc1, and display locks up

2017-11-27 Thread Mike Keehan
Hi, I am getting a General Protection Fault on 4.15-rc1, and the X11 screen locks up. Nov 27 10:16:37 babelfish kernel: Call Trace: Nov 27 10:16:37 babelfish kernel: ? __i915_gem_object_flush_for_display+0x13/0x40 [i915] Nov 27 10:16:37 babelfish kernel: i915_gem_object_wait_priority+0xb2/0x170

Re: [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

2017-11-27 Thread Timur Tabi
On 11/27/17 3:00 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 27 Nov 2017 09:56:09 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Timur Tabi _

[PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

2017-11-27 Thread Gustavo A. R. Silva
dm_new_crtc_state->stream and disconnected_acrtc are being dereferenced before they are null checked, hence there is a potential null pointer dereference. Fix this by null checking such pointers before they are dereferenced. Addresses-Coverity-ID: 1423745 ("Dereference before null check") Address

[PATCH V3 10/29] drm/nouveau: deprecate pci_get_bus_and_slot()

2017-11-27 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Replace pci_get_bus_and

[PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-27 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Extract the domain numb

Re: [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread Andrew F. Davis
On 11/26/2017 12:55 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 26 Nov 2017 19:46:09 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- n

Re: [PATCH v2 05/18] drm/sun4i: Force the mixer rate at 150MHz

2017-11-27 Thread Jernej Škrabec
Hi Maxime, Dne ponedeljek, 27. november 2017 ob 16:41:29 CET je Maxime Ripard napisal(a): > It seems like the mixer can only run properly when clocked at 150MHz. In > order to have something more robust than simply a fire-and-forget > assigned-clocks-rate, let's put that in the code. > > Signed-o

Re: [PATCH v2 11/18] drm/sun4i: Add A83T support

2017-11-27 Thread Jernej Škrabec
Hi Maxime, Dne ponedeljek, 27. november 2017 ob 16:41:35 CET je Maxime Ripard napisal(a): > Add support for the A83T display pipeline. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++ > drivers/gpu/drm/s

Re: [PATCH v2 00/18] drm/sun4i: Add A83t LVDS support

2017-11-27 Thread Jernej Škrabec
Hi, Dne ponedeljek, 27. november 2017 ob 16:41:24 CET je Maxime Ripard napisal(a): > Hi, > > Here is an attempt at supporting the LVDS output in our DRM driver. This > has been tested on the A83T (with DE2), but since everything is basically > in the TCON, it should also be usable on the older So

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

2017-11-27 Thread Nick Bowler
Hi, On 11/27/17, Laurent Pinchart wrote: > The driver should print a "PHY PLL failed to lock" error message to the > kernel log in that case. Nick, does that happen on your system ? I will try to test the other things later today, but after bootup there were no messages whatsoever printed to the

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-27 Thread SF Markus Elfring
>> Omit an extra message for a memory allocation failure in these functions. … > nak, unlike many others, these message give extra info on which > allocation failed, that can be useful. Can a default allocation failure report provide the information which you might expect so far? Regards, Markus

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

2017-11-27 Thread Christian König
Am 27.11.2017 um 18:21 schrieb Alex Deucher: On AMD GPUs, we use several mechanisms to fetch the vbios rom depending on the platform. We try to read the rom back via the rom BAR and fall back to other methods in some cases. This leads to spurious error messages from the pci rom code which are h

[PATCH] PCI: use dev_info rather than dev_err for rom validation

2017-11-27 Thread Alex Deucher
On AMD GPUs, we use several mechanisms to fetch the vbios rom depending on the platform. We try to read the rom back via the rom BAR and fall back to other methods in some cases. This leads to spurious error messages from the pci rom code which are harmless in our case. This leads to bugs being f

[PATCH] video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 17:53:05 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/auo_k190x.c | 1 - 1 file changed, 1 deletion(-)

[PATCH v2] fbdev: pxa3xx: use ktime_get_ts64 for time stamps

2017-11-27 Thread Arnd Bergmann
do_gettimeofday() is deprecated because it is not y2038 safe, so I'm changing the calculation for the diagnostic output over to using 'timespec64'. We really only print time deltas here, so changing it to monotonic time makes this more robust, the correct accessor for this is ktime_get_ts64(). Si

[PATCH] video: bf537-lq035: Delete an error message for a failed memory allocation in bfin_lq035_probe()

2017-11-27 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 27 Nov 2017 17:27:51 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/bf537-lq035.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Mark Brown
On Mon, Nov 27, 2017 at 05:12:23PM +0100, Daniel Vetter wrote: > commit model ftw, we have 400+ patches for 4.16 already merged and tested > and all ready, right when -rc1 gets tagged. Makes the merge window the > most relaxed time of all, because all the other maintainers are drowning > and wont

Re: [PATCH] drm/via: use monotonic time for VIA_WAIT_IRQ

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 12:17:03PM +0100, Arnd Bergmann wrote: > The normal DRM vblank interrupt events started using monotonic times in > commit c61eef726a78 ("drm: add support for monotonic vblank timestamps"), > which is useful for a number of reasons, including the possible y2038 > overflow. >

Re: [PATCH v2 11/18] drm/sun4i: Add A83T support

2017-11-27 Thread Chen-Yu Tsai
On Mon, Nov 27, 2017 at 11:41 PM, Maxime Ripard wrote: > Add support for the A83T display pipeline. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++ Rob mentioned that he'd like to see these multiple one-

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-27 Thread Daniel Vetter
On Mon, Nov 27, 2017 at 12:43:57PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote: > > 2017-11-09 22:17 GMT+01:00 Laura Abbott : > > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: > > >> > > >> Instead a getting only one common device "/dev/

[PATCH v2 18/18] ARM: dts: sun8i: a711: Enable the LCD

2017-11-27 Thread Maxime Ripard
The A711 has 1024x600 LVDS panel, with a PWM-based backlight. Add it to our DT. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 61 - 1 file changed, 61 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a7

[PATCH v2 17/18] ARM: dts: sun8i: a711: Reinstate the PMIC compatible

2017-11-27 Thread Maxime Ripard
When we added the regulator support in commit 90c5d7cdae64 ("ARM: dts: sun8i: a711: Add regulator support"), we also dropped the PMIC's compatible. Since it's not in the PMIC DTSI, unlike most other PMIC DTSI, it obviously wasn't probing anymore. Re-add it so that everything works again. Fixes: 9

[PATCH v2 08/18] drm/sun4i: Reorder and document DE2 mixer registers

2017-11-27 Thread Maxime Ripard
Some registers values have been hardcoded so far, or were not as descriptive as supposed to, because of missing information. The various BSP that poped up since have given us more details, some hopefully we can be more explicit about things. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i

[PATCH v2 01/18] dt-bindings: panel: lvds: Document power-supply property

2017-11-27 Thread Maxime Ripard
The power-supply property is used by a vast majority of panels, including panel-simple. Let's document it as a common property Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/panel/panel-common.txt | 6 ++ Documentation/devicetree/bindings/display/panel/panel-lvds.

[PATCH v2 11/18] drm/sun4i: Add A83T support

2017-11-27 Thread Maxime Ripard
Add support for the A83T display pipeline. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++ drivers/gpu/drm/sun4i/sun4i_drv.c | 2 ++ drivers/gpu/drm/sun4i/sun4i_tcon.c

[PATCH v2 09/18] drm/sun4i: Create minimal multipliers and dividers

2017-11-27 Thread Maxime Ripard
The various outputs the TCON can provide have different constraints on the dotclock divider. Let's make them configurable by the various mode_set functions. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_dotclock.c | 10 +++--- drivers/gpu/drm/sun4i/s

[PATCH v2 04/18] drm/sun4i: Fix error path handling

2017-11-27 Thread Maxime Ripard
The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") moved a bunch of logic around, but forgot to update the gotos after the introduction of the err_free_dotclock label. It means that if we fail later that the one introduced in that commit, we'll just to the old

[PATCH v2 05/18] drm/sun4i: Force the mixer rate at 150MHz

2017-11-27 Thread Maxime Ripard
It seems like the mixer can only run properly when clocked at 150MHz. In order to have something more robust than simply a fire-and-forget assigned-clocks-rate, let's put that in the code. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 7 +++ 1 file changed, 7 inserti

[PATCH v2 06/18] drm/sun4i: Rename layers to UI planes

2017-11-27 Thread Maxime Ripard
The currently supported planes for DE2 are actually only UI planes, and the VI planes will differ both in terms of code and features. It will make sense to support them in a separate file, so let's make sure we don't create a confusing file name. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime R

[PATCH v2 07/18] drm/sun4i: sun8i: Rework the UI channels code

2017-11-27 Thread Maxime Ripard
The current code makes the assumption that the only channel we want to use for the first (and only) UI channel is the number of VI channels (so last VI + 1), which is accurate. However, it does so in pretty much every plane-related function using a local variable that makes it quite difficult to r

[PATCH v2 15/18] ARM: dts: sun8i: a83t: Add LVDS pins group

2017-11-27 Thread Maxime Ripard
The A83T has an LVDS bus that can be connected to a panel or a bridge. Add the pinctrl group for it. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun8i-a83t.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/a

[PATCH v2 02/18] drm/panel: lvds: Add support for the power-supply property

2017-11-27 Thread Maxime Ripard
A significant number of panels need to power up a regulator in order to operate properly. Add support for the power-supply property to enable and disable such a regulator whenever needed. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-lvds.c | 23

[PATCH v2 14/18] ARM: dts: sun8i: a83t: Enable the PWM

2017-11-27 Thread Maxime Ripard
The A83T has the same PWM block than the H3. Add it to our DT. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun8i-a83t.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index

  1   2   3   >