https://bugs.freedesktop.org/show_bug.cgi?id=109206
Luya Tshimbalanga changed:
What|Removed |Added
Summary|Kernel 4.20 amdgpu fails to |Kernel 5.3.11 and onward
https://bugzilla.kernel.org/show_bug.cgi?id=205521
Luya Tshimbalanga (l...@fedoraproject.org) changed:
What|Removed |Added
URL|
https://bugs.freedesktop.org/show_bug.cgi?id=109206
--- Comment #64 from Luya Tshimbalanga ---
Created attachment 145952
--> https://bugs.freedesktop.org/attachment.cgi?id=145952=edit
Journal boot from hp envy x360 cp0xxx
The bug caused the Raven Ridge firmware to fail is back on kernel
komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might
be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
vsnprintf(c->name, sizeof(c->name), name_fmt, args);
^
https://bugzilla.kernel.org/show_bug.cgi?id=205523
Bug ID: 205523
Summary: AMDGPU display lockup during boot with 5.4 RC on Ryzen
2700u
Product: Drivers
Version: 2.5
Kernel Version: 5.4.0-rc7
Hardware: x86-64
https://bugs.freedesktop.org/show_bug.cgi?id=112267
Andre Klapper changed:
What|Removed |Added
Product|DRI |Spam
Status|NEW
https://bugzilla.kernel.org/show_bug.cgi?id=205521
Luya Tshimbalanga (l...@fedoraproject.org) changed:
What|Removed |Added
Regression|No |Yes
--
You
https://bugzilla.kernel.org/show_bug.cgi?id=205521
--- Comment #1 from Luya Tshimbalanga (l...@fedoraproject.org) ---
Created attachment 285905
--> https://bugzilla.kernel.org/attachment.cgi?id=285905=edit
dmesg with the latest git snapshot
Recent kernel git snapshot is also affected:
--
You
https://bugzilla.kernel.org/show_bug.cgi?id=205521
Bug ID: 205521
Summary: 5.3.11 update broke AMDGPU Raven Ridge
Product: Drivers
Version: 2.5
Kernel Version: 5.3.11 and up
Hardware: x86-64
OS: Linux
Tree:
On 11/13/19 3:22 PM, John Hubbard wrote:
> On 11/13/19 2:43 AM, Jan Kara wrote:
> ...
>> How does FOLL_PIN result in grabbing (at least normal, for now) page
>> reference?
>> I didn't find that anywhere in this patch but it is a prerequisite to
>> converting any user to pin_user_pages()
Hi Dave and Daniel,
Here goes drm-intel-fixes-2019-11-13:
- MOCS table fixes for EHL and TGL
- Update Display's rawclock on resume
- GVT's dmabuf reference drop fix
Thanks,
Rodrigo.
The following changes since commit 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c:
Linux 5.4-rc7 (2019-11-10
Hi all,
Today's linux-next merge of the hmm tree got a conflict in:
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
between commit:
4d8e54d2b9d3 ("drm/amdgpu/mn: fix documentation for amdgpu_mn_read_lock")
from the drm tree and commit:
a2849b5dcc9e ("drm/amdgpu: Use mmu_interval_insert instead
On Wed, Nov 13, 2019 at 9:53 PM Sam Bobroff wrote:
>
> Currently, binding the radeon driver to a Radeon FirePro (PCI
> 1002:68f2) that has been passed through to a guest on a Power8 machine
> causes a bad DMA read which causes the device to be frozen, leading to
> the driver failing to bind and
Currently, binding the radeon driver to a Radeon FirePro (PCI
1002:68f2) that has been passed through to a guest on a Power8 machine
causes a bad DMA read which causes the device to be frozen, leading to
the driver failing to bind and other problems.
The bad DMA is to the address written into the
https://bugs.freedesktop.org/show_bug.cgi?id=112266
Bug ID: 112266
Summary: [Navi] Pathfinder: Kingmaker is causing a GPU hang:
flip_done timed out error
Product: DRI
Version: unspecified
Hardware: x86-64 (AMD64)
On Fri, 8 Nov 2019 01:02:52 +0100, Heiko Stuebner wrote:
> The px30 SoC also uses a dw-mipi-dsi controller, so add the
> compatible value for it.
>
> Signed-off-by: Heiko Stuebner
> ---
> .../bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 6 --
> 1 file changed, 4 insertions(+),
On Wed, Nov 13, 2019 at 12:39:54PM +0100, Daniel Vetter wrote:
> On Wed, Nov 13, 2019 at 02:01:53AM +, james qian wang (Arm Technology
> China) wrote:
> > On Fri, Nov 08, 2019 at 04:09:54PM +, Ayan Halder wrote:
> > > On Mon, Nov 04, 2019 at 11:12:27PM +0100, Andrzej Pietrasiewicz wrote:
On Fri, 8 Nov 2019 01:02:50 +0100, Heiko Stuebner wrote:
> Some dw-mipi-dsi instances in Rockchip SoCs use external dphys.
> In these cases the needs clock will also be generated externally
> so these don't need the ref-clock as well.
>
> Signed-off-by: Heiko Stuebner
> ---
>
The landing of the i915 CVE fixes into Linus tree has created a bit of
a mess in linux-next and downstream in drm-next trees.
I talked to Daniel and he had talked to Joonas a bit, and I decided to
go with what Daniel describes as the YOLO merge, where I just solve it
and pray, and everyone else
On Tue, Oct 22, 2019 at 11:25 PM Gerd Hoffmann wrote:
>
> Little patch series doing some cleanups in the virtio driver.
> Patches #1 + #2 have been on the list before as single patches,
> includes here again for patch dependency reasons.
>
> v2:
> - fix sparse errors.
> - drop merged patches
https://bugs.freedesktop.org/show_bug.cgi?id=111481
--- Comment #230 from Daniel Suarez ---
(In reply to John Smith from comment #225)
> (In reply to Pierre-Eric Pelloux-Prayer from comment #141)
>
> > For radeonsi the AMD_DEBUG=nodma environment variable is a workaround until
> > we figure out
Hi Flora,
FYI, the error/warning still remains.
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2
head: a48b0cc1cdf3900e3e73801f9de64afbb70dc193
commit: cc8e420623914e7a903534abddf086dad609a455 [2701/2834] drm/amdkcl: drop
https://bugzilla.kernel.org/show_bug.cgi?id=205517
--- Comment #1 from Todd Brandt (todd.e.bra...@linux.intel.com) ---
Created attachment 285895
--> https://bugzilla.kernel.org/attachment.cgi?id=285895=edit
otcpl-dell-p5510-xeon-1_mem.html
--
You are receiving this mail because:
You are
https://bugzilla.kernel.org/show_bug.cgi?id=205517
Todd Brandt (todd.e.bra...@linux.intel.com) changed:
What|Removed |Added
Blocks||178231
https://bugzilla.kernel.org/show_bug.cgi?id=205517
Bug ID: 205517
Summary: nouveau MMIO read of FAULT at 619444
Product: Drivers
Version: 2.5
Kernel Version: 5.3.0
Hardware: All
OS: Linux
Tree:
On 11/13/19 11:09 AM, Ira Weiny wrote:
...
diff --git a/mm/gup.c b/mm/gup.c
index 82e7e4ce5027..90f5f95ee7ac 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1756,11 +1756,11 @@ long get_user_pages(unsigned long start, unsigned long
nr_pages,
struct vm_area_struct **vmas)
{
/*
On 11/13/19 2:43 AM, Jan Kara wrote:
...
How does FOLL_PIN result in grabbing (at least normal, for now) page reference?
I didn't find that anywhere in this patch but it is a prerequisite to
converting any user to pin_user_pages() interface, right?
ohhh, I messed up on this intermediate
On 11/13/19 3:15 AM, Jan Kara wrote:
On Tue 12-11-19 20:26:49, John Hubbard wrote:
There are four locations in gup.c that have a fair amount of code
duplication. This means that changing one requires making the same
changes in four places, not to mention reading the same code four
times, and
Hi Adam,
FYI, the error/warning still remains.
tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.2
head: a48b0cc1cdf3900e3e73801f9de64afbb70dc193
commit: ce2ac7946ad9ad370cf8212eab6d5651ba5520c6 [2163/2834] drm/amdkcl: use
kcl to leverage drm_crtc_accurate_vblank_count
On Wed, Nov 13, 2019 at 02:00:06PM -0800, Dan Williams wrote:
> On Wed, Nov 13, 2019 at 11:23 AM Dan Williams
> wrote:
> >
> > On Tue, Nov 12, 2019 at 8:27 PM John Hubbard wrote:
> > >
> > > An upcoming patch changes and complicates the refcounting and
> > > especially the "put page" aspects of
On 11/13/19 2:55 PM, Dan Williams wrote:
On Wed, Nov 13, 2019 at 2:49 PM John Hubbard wrote:
On 11/13/19 2:00 PM, Dan Williams wrote:
...
Ugh, when did all this HMM specific manipulation sneak into the
generic ZONE_DEVICE path? It used to be gated by pgmap type with its
own
On Wed, Nov 13, 2019 at 2:49 PM John Hubbard wrote:
>
> On 11/13/19 2:00 PM, Dan Williams wrote:
> ...
> >> Ugh, when did all this HMM specific manipulation sneak into the
> >> generic ZONE_DEVICE path? It used to be gated by pgmap type with its
> >> own put_zone_device_private_page(). For
On 11/13/19 2:00 PM, Dan Williams wrote:
...
Ugh, when did all this HMM specific manipulation sneak into the
generic ZONE_DEVICE path? It used to be gated by pgmap type with its
own put_zone_device_private_page(). For example it's certainly
unnecessary and might be broken (would need to check)
In case of tiled displays, if we hotplug just one connector,
fbcon currently just selects the preferred mode and if it is
tiled mode then that becomes a problem if rest of the tiles are
not present.
So in the fbdev driver on hotplug when we probe the client modeset,
if we dont find all the
https://bugs.freedesktop.org/show_bug.cgi?id=112265
--- Comment #3 from john.p.donne...@oracle.com ---
Created attachment 145950
--> https://bugs.freedesktop.org/attachment.cgi?id=145950=edit
Running startx on the console
This likely doesn't help much
On a 4.18 kernel ; when I do "startx"
On Wed, Nov 13, 2019 at 11:23 AM Dan Williams wrote:
>
> On Tue, Nov 12, 2019 at 8:27 PM John Hubbard wrote:
> >
> > An upcoming patch changes and complicates the refcounting and
> > especially the "put page" aspects of it. In order to keep
> > everything clean, refactor the devmap page release
https://bugs.freedesktop.org/show_bug.cgi?id=112265
--- Comment #2 from john.p.donne...@oracle.com ---
debugfs content :
With gnome running
# for f in `find . -type f ` ; do
> echo "$f : `cat $f` "
> done
./VGA-1/edid_override :
./VGA-1/force : unspecified
./internal_clients :
> On Nov 13, 2019, at 2:06 PM, Daniel Vetter wrote:
>
> On Wed, Nov 13, 2019 at 6:42 PM John Donnelly
> wrote:
>>
>> Hi Thomas: See below
>>
>>> On Nov 13, 2019, at 2:17 AM, Thomas Zimmermann wrote:
>>>
>>> Hi John
>>>
>>> Am 12.11.19 um 20:13 schrieb John Donnelly:
In short
https://bugs.freedesktop.org/show_bug.cgi?id=112265
john.p.donne...@oracle.com changed:
What|Removed |Added
CC||john.p.donne...@oracle.com
https://bugs.freedesktop.org/show_bug.cgi?id=112265
Bug ID: 112265
Summary: Drm: mgag200. Video adapter issue with 5.4.0-rc3 ; no
graphics
Product: DRI
Version: DRI git
Hardware: x86-64 (AMD64)
OS: Linux
Hi Dave & Daniel,
Just one msm patch this week. Looks like -misc is going to be perfect when merge
window rolls around :-)
drm-misc-next-fixes-2019-11-13:
- Fix memory leak in gpu debugfs node's release (Johan)
Cc: Johan Hovold
Cheers, Sean
The following changes since commit
On 11/13/19 3:43 AM, Daniel Vetter wrote:
...
Can't we call this unpin_user_page then, for some symmetry? Or is that
even more churn?
Looking from afar the naming here seems really confusing.
That look from afar is valuable, because I'm too close to the problem to see
how the naming looks.
On 11/13/19 10:59 AM, Ira Weiny wrote:
On Tue, Nov 12, 2019 at 08:26:56PM -0800, John Hubbard wrote:
Introduce pin_user_pages*() variations of get_user_pages*() calls,
and also pin_longterm_pages*() variations.
These variants all set FOLL_PIN, which is also introduced, and
thoroughly
On 11/13/19 11:17 AM, Ira Weiny wrote:
...
@@ -348,33 +347,13 @@ static int vaddr_get_pfn(struct mm_struct *mm, unsigned
long vaddr,
flags |= FOLL_WRITE;
down_read(>mmap_sem);
- if (mm == current->mm) {
- ret = get_user_pages(vaddr, 1, flags |
n linus/master]
[also build test WARNING on v5.4-rc7 next-20191113]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/
On Wed, Nov 13, 2019 at 6:42 PM John Donnelly
wrote:
>
> Hi Thomas: See below
>
> > On Nov 13, 2019, at 2:17 AM, Thomas Zimmermann wrote:
> >
> > Hi John
> >
> > Am 12.11.19 um 20:13 schrieb John Donnelly:
> >>
> >> In short . I started with :
> >>
> >> git bisect start
> >>
> >> git bisect
> On Nov 13, 2019, at 11:42 AM, John Donnelly
> wrote:
>
> Hi Thomas: See below
>
>> On Nov 13, 2019, at 2:17 AM, Thomas Zimmermann wrote:
>>
>> Hi John
>>
>> Am 12.11.19 um 20:13 schrieb John Donnelly:
>>>
>>> In short . I started with :
>>>
>>> git bisect start
>>>
>>> git
On Tue, Nov 12, 2019 at 8:27 PM John Hubbard wrote:
>
> An upcoming patch changes and complicates the refcounting and
> especially the "put page" aspects of it. In order to keep
> everything clean, refactor the devmap page release routines:
>
> * Rename put_devmap_managed_page() to
On Wed, Nov 13, 2019 at 11:56 AM Joe Perches wrote:
>
> On Wed, 2019-11-13 at 20:44 +0800, yu kuai wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c: In function
> > ‘gfx_v6_0_constants_init’:
> > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1579:6:
On Wed, Nov 13, 2019 at 09:02:02AM -0400, Jason Gunthorpe wrote:
> On Tue, Nov 12, 2019 at 08:26:55PM -0800, John Hubbard wrote:
> > As it says in the updated comment in gup.c: current FOLL_LONGTERM
> > behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the
> > FS DAX check
On Tue, Nov 12, 2019 at 08:26:51PM -0800, John Hubbard wrote:
> An upcoming patch changes and complicates the refcounting and
> especially the "put page" aspects of it. In order to keep
> everything clean, refactor the devmap page release routines:
>
> * Rename put_devmap_managed_page() to
On Tue, Nov 12, 2019 at 08:27:10PM -0800, John Hubbard wrote:
> Now that all other kernel callers of get_user_pages(FOLL_LONGTERM)
> have been converted to pin_longterm_pages(), lock it down:
>
> 1) Add an assertion to get_user_pages(), preventing callers from
>passing FOLL_LONGTERM (in
On Tue, Nov 12, 2019 at 08:27:09PM -0800, John Hubbard wrote:
> It's good to have basic unit test coverage of the new FOLL_PIN
> behavior. Fortunately, the gup_benchmark unit test is extremely
> fast (a few milliseconds), so adding it the the run_vmtests suite
> is going to cause no noticeable
On Tue, Nov 12, 2019 at 08:27:08PM -0800, John Hubbard wrote:
> Up until now, gup_benchmark supported testing of the
> following kernel functions:
>
> * get_user_pages(): via the '-U' command line option
> * get_user_pages_longterm(): via the '-L' command line option
> * get_user_pages_fast(): as
On Tue, Nov 12, 2019 at 08:27:07PM -0800, John Hubbard wrote:
> Fix the gup benchmark flags to use the symbolic FOLL_WRITE,
> instead of a hard-coded "1" value.
>
> Also, clean up the filtering of gup flags a little, by just doing
> it once before issuing any of the get_user_pages*() calls. This
On Tue, Nov 12, 2019 at 08:26:56PM -0800, John Hubbard wrote:
> Introduce pin_user_pages*() variations of get_user_pages*() calls,
> and also pin_longterm_pages*() variations.
>
> These variants all set FOLL_PIN, which is also introduced, and
> thoroughly documented.
>
> The pin_longterm*()
On Tue, Nov 12, 2019 at 08:26:55PM -0800, John Hubbard wrote:
> As it says in the updated comment in gup.c: current FOLL_LONGTERM
> behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the
> FS DAX check requirement on vmas.
>
> However, the corresponding restriction in
On Wed, Nov 13, 2019 at 2:43 AM Jan Kara wrote:
>
> On Tue 12-11-19 20:26:56, John Hubbard wrote:
> > Introduce pin_user_pages*() variations of get_user_pages*() calls,
> > and also pin_longterm_pages*() variations.
> >
> > These variants all set FOLL_PIN, which is also introduced, and
> >
On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote:
> > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig wrote:
> > >
> > > On Tue, Nov 12, 2019 at 10:24:23PM +, Luis Chamberlain wrote:
> > > > I think this would
On Tue, Nov 12, 2019 at 08:26:50PM -0800, John Hubbard wrote:
> An upcoming patch uses try_get_compound_head() more widely,
> so move it to the top of gup.c.
>
> Also fix a tiny spelling error and a checkpatch.pl warning.
>
> Signed-off-by: John Hubbard
Simple enough...
Reviewed-by: Ira Weiny
> > +/**
> > + * pin_user_pages_fast() - pin user pages in memory without taking locks
> > + *
> > + * Nearly the same as get_user_pages_fast(), except that FOLL_PIN is set.
> > See
> > + * get_user_pages_fast() for documentation on the function arguments,
> > because
> > + * the arguments here
2019. 11. 13. 18:25 keltezéssel, Ilia Mirkin írta:
On Wed, Nov 13, 2019 at 11:59 AM Böszörményi Zoltán wrote:
2019. 11. 12. 17:41 keltezéssel, Ilia Mirkin írta:
On Tue, Nov 12, 2019 at 9:23 AM Böszörményi Zoltán wrote:
But no, all GPU devices (now only one, the UDL device) have screen 0
Hi Thomas: See below
> On Nov 13, 2019, at 2:17 AM, Thomas Zimmermann wrote:
>
> Hi John
>
> Am 12.11.19 um 20:13 schrieb John Donnelly:
>>
>> In short . I started with :
>>
>> git bisect start
>>
>> git bisect bad be8454afc50f
>>
>> git bisect good fec88ab0af97
>>
>> And at the
On Wed, Nov 13, 2019 at 02:52:23PM +0100, Linus Walleij wrote:
> On Tue, Nov 5, 2019 at 4:41 PM Daniel Vetter wrote:
> > On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij
> > wrote:
> > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov
> > > wrote:
>
> > > I'm happy to merge it into the GPIO tree
On Wed, Nov 13, 2019 at 11:59 AM Böszörményi Zoltán wrote:
>
> 2019. 11. 12. 17:41 keltezéssel, Ilia Mirkin írta:
> > On Tue, Nov 12, 2019 at 9:23 AM Böszörményi Zoltán wrote:
> >> But no, all GPU devices (now only one, the UDL device) have screen 0
> >> (a.k.a. DISPLAY=:0.0) set when
Hi,
On 11/13/19 3:16 PM, Christoph Hellwig wrote:
On Wed, Nov 13, 2019 at 10:51:43AM +0100, Thomas Hellström (VMware) wrote:
From: Thomas Hellstrom
We're gradually moving towards using DMA coherent memory in most
situations, although TTM interactions with the DMA layers is still a
2019. 11. 12. 17:41 keltezéssel, Ilia Mirkin írta:
On Tue, Nov 12, 2019 at 9:23 AM Böszörményi Zoltán wrote:
But no, all GPU devices (now only one, the UDL device) have screen 0
(a.k.a. DISPLAY=:0.0) set when AutoBindGPU is true:
[ 2444.576] xf86AutoConfigOutputDevices: xf86NumScreens 2
On Wed, 2019-11-13 at 20:44 +0800, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c: In function
> ‘gfx_v6_0_constants_init’:
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1579:6: warning: variable
> ‘mc_shared_chmap’ set but not used
If the new video=... panel_orientation option is set for a connector, honor
it and setup a matching "panel orientation" property on the connector.
BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_connector.c | 7
fb_get_options() will return fb_mode_option if no video=
argument is present on the kernel commandline, so there is no need to also
do this in drm_mode_parse_command_line_for_connector() as our only caller
uses fb_get_options() to get the mode_option argument.
Changes in v2:
-Split out the
From: Derek Basehore
Not every platform needs quirk detection for panel orientation, so
split the drm_connector_init_panel_orientation_property into two
functions. One for platforms without the need for quirks, and the
other for platforms that need quirks.
Hans de Goede (changes in v2):
Rename
Some options which can be specified on the commandline, such as
margin_right=..., margin_left=..., etc. are applied not only to the
specified mode, but to all modes. As such it would be nice if the user
can simply say e.g.
video=HDMI-1:margin_right=14,margin_left=24,margin_bottom=36,margin_top=42
drm_connector_get_cmdline_mode() calls
drm_mode_parse_command_line_for_connector() with >cmdline_mode
as mode argument, so anything which we store in the mode arguments gets
kept even if we return false.
Avoid storing a possibly false-postive bpp/refresh_specified setting
in
Before this commit it was impossible to combine an extra mode argument
specified directly after the resolution with an option, e.g.
video=HDMI-1:720x480e,rotate=180 would not work, either the "e" to force
enable would need to be dropped or the ",rotate=180", otherwise the
mode_option would not be
Add a freestanding function argument to drm_mode_parse_cmdline_options()
similar to how drm_mode_parse_cmdline_extra() already has this.
This is a preparation patch for allowing parsing of stand-alone options
without a mode before them, e.g.: video=HDMI-1:margin_right=14,...
Acked-by: Maxime
Sometimes we want to override a connector's panel_orientation from the
kernel commandline. Either for testing and for special cases, e.g. a kiosk
like setup which uses a TV mounted in portrait mode.
Users can already specify a "rotate" option through a video= kernel cmdline
option. But that only
Instead of only setting mode->specified on false on an early exit and
leaving e.g. mode->bpp_specified and mode->refresh_specified as is,
lets be consistent and just zero out the entire passed in struct at
the top of drm_mode_parse_command_line_for_connector()
Signed-off-by: Hans de Goede
---
Refactor drm_mode_parse_cmdline_options() so that it takes a pointer
to the first option, rather then a pointer to the ',' before the first
option.
This is a preparation patch for allowing parsing of stand-alone options
without a mode before them, e.g.: video=HDMI-1:margin_right=14,...
Acked-by:
We are not supposed to modify the passed in string, make char pointers
used in drm_mode_parse_cmdline_options() const char * where possible.
Acked-by: Maxime Ripard
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_modes.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Before this commit, if the last option of a video=... option is for
example "rotate" without a "=" after it then delim will point to
the terminating 0 of the string, and value which is sets to
will point one position past the end of the string.
This commit fixes this by enforcing that the
Before this commit it was impossible to add an extra mode argument after
a bpp or refresh specifier, combined with an option, e.g.
video=HDMI-1:720x480-24e,rotate=180 would not work, either the "e" to
force enable would need to be dropped or the ",rotate=180", otherwise
the mode_option would not
On Wed, Nov 13, 2019 at 04:58:57PM +0100, Thomas Zimmermann wrote:
> Both callbacks are deprecated. Remove them and call functions explicitly.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/ast/ast_drv.c | 13 +
> 1 file changed, 9
On Wed, Nov 13, 2019 at 05:35:41PM +0100, Daniel Vetter wrote:
> On Wed, Nov 13, 2019 at 04:58:56PM +0100, Thomas Zimmermann wrote:
> > Both functions are deprecated. Open-code them them in preparation
> > of removing struct drm_driver.{load,unload}.
> >
> > Signed-off-by: Thomas Zimmermann
> >
On Wed, 13 Nov 2019, Emil Velikov
wrote:
On Wed, 6 Nov 2019 at 16:30, Adrian Ratiu
wrote:
Convert the common bridge code and the two rockchip & stm
drivers which currently use it to the regmap API in
anticipation for further changes to make it more generic and
add older DSI host
On Wed, Nov 13, 2019 at 04:58:56PM +0100, Thomas Zimmermann wrote:
> Both functions are deprecated. Open-code them them in preparation
> of removing struct drm_driver.{load,unload}.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/ast/ast_drv.c | 31 +--
>
On Wed, Nov 13, 2019 at 02:56:12PM +0100, Gerd Hoffmann wrote:
> When mapping ttm objects via drm_gem_ttm_mmap() helper
> drm_gem_mmap_obj() will take an object reference. That gets
> never released due to ttm having its own reference counting.
>
> Fix that by dropping the gem object reference
On Wed, Nov 13, 2019 at 07:53:56AM -0600, Rob Herring wrote:
> On Wed, Nov 13, 2019 at 2:18 AM Daniel Vetter wrote:
> >
> > On Wed, Nov 13, 2019 at 8:39 AM Gerd Hoffmann wrote:
> > >
> > > Hi,
> > >
> > > > > > >> VRAM helpers use drm_gem_ttm_mmap(), which wraps
> > > > > > >>
On Wed, Nov 13, 2019 at 02:51:45PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > ... but after looking again I think we are all green here. Given that
> > > only self-import works we'll only see vram gem objects in the mmap code
> > > path, which should have everything set up correctly. Same goes
https://bugs.freedesktop.org/show_bug.cgi?id=23
--- Comment #4 from Leonardo da Silva ---
i have the same problem, I bought 2x 3400g with A320-S2H, one machine running
ubuntu 19.10 and the other Arch Linux, both with the same problem described
above when using integrated graphics.
--
You
On Mon, Nov 11, 2019 at 06:25:33PM +0100, Hans de Goede wrote:
> Hi,
>
> On 11-11-2019 13:53, Maxime Ripard wrote:
> > Hi Hans,
> >
> > Thanks for this series (and thanks for bouncing the mails too).
> >
> > All the previous patches are
> > Acked-by: Maxime Ripard
>
> Thank you for the review.
>
On Wed, 6 Nov 2019 at 16:31, Adrian Ratiu wrote:
>
> Reviewed-by: Neil Armstrong
> Reviewed-by: Emil Velikov
Please drop this one. I'm not that experienced in DT to provide
meaningful review.
Actually, I've just noticed that respective maintainers/lists are not
CC'd on the series.
Please use
Both functions are deprecated. Open-code them them in preparation
of removing struct drm_driver.{load,unload}.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git
Both callbacks are deprecated. Remove them and call functions explicitly.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index
This patchset removes the load/unload callback functions from ast. Tested
on AST 2100 HW.
Thomas Zimmermann (2):
drm/ast: Replace drm_get_pci_device() and drm_put_dev()
drm/ast: Call struct drm_driver.{load,unload} before registering
device
drivers/gpu/drm/ast/ast_drv.c | 42
Hi,
On 12-11-2019 14:47, Daniel Vetter wrote:
On Tue, Nov 12, 2019 at 2:39 PM Hans de Goede wrote:
Hi,
On 12-11-2019 14:32, Daniel Vetter wrote:
On Tue, Nov 12, 2019 at 11:43 AM Hans de Goede wrote:
Hi,
On 12-11-2019 10:47, Daniel Vetter wrote:
On Sun, Nov 10, 2019 at 04:41:01PM
Am 13.11.19 um 16:41 schrieb Thomas Zimmermann:
>> Either way you choose:
>
> Glad you like it :)
>
more like this
>>
>> Btw, nice diffstat!
Glad you like it :)
>>
>>> if (ret)
>>> goto err;
>>>
>>> @@ -367,6 +368,4 @@ void udl_fini(struct drm_device *dev)
>>>
>>>
On Wed, 6 Nov 2019 at 16:31, Adrian Ratiu wrote:
>
> This adds support for the Synopsis DesignWare MIPI DSI v1.01 host
> controller which is embedded in i.MX 6 SoCs.
>
> Based on following patches, but updated/extended to work with existing
> support found in the kernel:
>
> - drm: imx: Support
Hi
Am 13.11.19 um 16:26 schrieb Noralf Trønnes:
>
>
> Den 13.11.2019 12.52, skrev Thomas Zimmermann:
>> The udl driver can use the generic fbdev implementation. Convert it.
>>
>> v4:
>> * hardcode console bpp to 16
>> v3:
>> * remove module parameter fb_bpp in favor of fbdev's video
Den 13.11.2019 12.52, skrev Thomas Zimmermann:
> There are no external callers of unlink_framebuffer() left. Make the
> function an internal interface.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
___
dri-devel mailing
Den 13.11.2019 12.52, skrev Thomas Zimmermann:
> There are no callers of drm_fb_helper_unlink_fbi() left. Remove the
> function.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Noralf Trønnes
___
dri-devel mailing list
1 - 100 of 141 matches
Mail list logo
