Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread John Hubbard
On 12/18/19 10:52 PM, Dan Williams wrote: On Wed, Dec 18, 2019 at 9:51 PM John Hubbard wrote: On 12/18/19 9:27 PM, Dan Williams wrote: ... @@ -461,5 +449,5 @@ void __put_devmap_managed_page(struct page *page) page->mapping = NULL; page->pgmap->ops->page_free(page); }

Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread Dan Williams
On Wed, Dec 18, 2019 at 9:51 PM John Hubbard wrote: > > On 12/18/19 9:27 PM, Dan Williams wrote: > ... > >> @@ -461,5 +449,5 @@ void __put_devmap_managed_page(struct page *page) > >> page->mapping = NULL; > >> page->pgmap->ops->page_free(page); > >> } > >>

Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread John Hubbard
On 12/18/19 9:27 PM, Dan Williams wrote: ... @@ -461,5 +449,5 @@ void __put_devmap_managed_page(struct page *page) page->mapping = NULL; page->pgmap->ops->page_free(page); } -EXPORT_SYMBOL(__put_devmap_managed_page); +EXPORT_SYMBOL(free_devmap_managed_page); This patch does

Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread Dan Williams
On Mon, Dec 16, 2019 at 2:26 PM John Hubbard wrote: > > An upcoming patch changes and complicates the refcounting and > especially the "put page" aspects of it. In order to keep > everything clean, refactor the devmap page release routines: > > * Rename put_devmap_managed_page() to

Re: [PATCH 2/2] drm/amdgpu/display: use msleep rather than udelay for HDCP

2019-12-18 Thread Alex Deucher
On Wed, Dec 18, 2019 at 6:07 PM Dave Airlie wrote: > > Hey, > > I've pulled in these two patches to drm-next directly because my arm > test build was broken. Sounds good. Alex > > Dave. > > On Wed, 18 Dec 2019 at 06:47, Alex Deucher wrote: > > > > ARM has a 2000us limit for udelay. Switch to

[PATCH 4/6] drm/virtio: simplify getting fake offset

2019-12-18 Thread Gurchetan Singh
This is a little simpler. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 8 +--- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +--- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 6/6] drm/virtio: move drm_connector_to_virtio_gpu_output to virtgpu_display

2019-12-18 Thread Gurchetan Singh
That's the only file that uses it. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_display.c | 3 +++ drivers/gpu/drm/virtio/virtgpu_drv.h | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c

[PATCH 2/6] drm/virtio: static-ify virtio_gpu_framebuffer_init

2019-12-18 Thread Gurchetan Singh
Not used anywhere else. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c

[PATCH 3/6] drm/virtio: get rid of drm_encoder_to_virtio_gpu_output

2019-12-18 Thread Gurchetan Singh
Not used anywhere. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index cf09e4af2fc5..3e0580a8d818 100644 ---

[PATCH 5/6] drm/virtio: move to_virtio_fence inside virtgpu_fence

2019-12-18 Thread Gurchetan Singh
That's the only file that uses it. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 -- drivers/gpu/drm/virtio/virtgpu_fence.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH 1/6] drm/virtio: static-ify virtio_fence_signaled

2019-12-18 Thread Gurchetan Singh
Not used anywhere else. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 - drivers/gpu/drm/virtio/virtgpu_fence.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH v12] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread John Hubbard
An upcoming patch changes and complicates the refcounting and especially the "put page" aspects of it. In order to keep everything clean, refactor the devmap page release routines: * Rename put_devmap_managed_page() to page_is_devmap_managed(), and limit the functionality to "read only": return

Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread John Hubbard
On 12/18/19 8:04 AM, Kirill A. Shutemov wrote: On Mon, Dec 16, 2019 at 02:25:16PM -0800, John Hubbard wrote: An upcoming patch changes and complicates the refcounting and especially the "put page" aspects of it. In order to keep everything clean, refactor the devmap page release routines: *

[GIT PULL] exynos-drm-fixes

2019-12-18 Thread Inki Dae
Hi Dave, Just one bug fixup which makes sure to unregister a component for Exynos gscaler driver. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit d1eef1c619749b2a57e514a3fa67d9a516ffa919: Linux 5.5-rc2 (2019-12-15 15:16:08

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Manasi Navare
On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: > >On 2019-12-18 10:13 a.m., Animesh Manna wrote: > >>[Why]: > >>Aligh with DP spec wanted to follow same naming convention. > >> > >>[How]: > >>Changed the macro name of the dpcd

Re: [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-18 Thread Niranjana Vishwanathapura
On Tue, Dec 17, 2019 at 08:18:21PM +, Jason Gunthorpe wrote: On Fri, Dec 13, 2019 at 01:56:04PM -0800, Niranjana Vishwanathapura wrote: + ctx = i915_gem_context_lookup(file->driver_priv, args->rsvd1); + if (!ctx || !rcu_access_pointer(ctx->vm)) + return -ENOENT; +

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-18 Thread Niranjana Vishwanathapura
On Tue, Dec 17, 2019 at 12:01:26PM -0600, Jason Ekstrand wrote: On Sun, Dec 15, 2019 at 10:24 PM Niranjan Vishwanathapura wrote: On Sat, Dec 14, 2019 at 10:31:37AM +, Chris Wilson wrote: >Quoting Jason Ekstrand (2019-12-14 00:36:19) >> On Fri, Dec 13, 2019 at 5:24 PM

linux-next: build warning after merge of the amdgpu tree

2019-12-18 Thread Stephen Rothwell
Hi all, After merging the amdgpu tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c: In function 'vcn_v2_5_hw_init': drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:288:5: warning: 'r' may be used uninitialized in this function

Re: [PATCH 2/2] drm/amdgpu/display: use msleep rather than udelay for HDCP

2019-12-18 Thread Dave Airlie
Hey, I've pulled in these two patches to drm-next directly because my arm test build was broken. Dave. On Wed, 18 Dec 2019 at 06:47, Alex Deucher wrote: > > ARM has a 2000us limit for udelay. Switch to msleep. This code > executes in a worker thread so shouldn't be an atomic context. > >

Re: [Intel-gfx] [RFC v2 02/12] drm/i915/svm: Runtime (RT) allocator support

2019-12-18 Thread Niranjana Vishwanathapura
On Sun, Dec 15, 2019 at 08:15:24PM -0800, Niranjan Vishwanathapura wrote: On Sat, Dec 14, 2019 at 10:56:54AM +, Chris Wilson wrote: Quoting Niranjana Vishwanathapura (2019-12-13 21:56:04) Shared Virtual Memory (SVM) runtime allocator support allows binding a shared virtual address to a

Re: [RFC v2 05/12] drm/i915/svm: Page table mirroring support

2019-12-18 Thread Niranjana Vishwanathapura
On Tue, Dec 17, 2019 at 08:31:07PM +, Jason Gunthorpe wrote: On Fri, Dec 13, 2019 at 01:56:07PM -0800, Niranjana Vishwanathapura wrote: +static struct i915_svm *vm_get_svm(struct i915_address_space *vm) +{ + struct i915_svm *svm = vm->svm; + + mutex_lock(>svm_mutex); + if

Re: [PATCH v11 01/25] mm/gup: factor out duplicate code from four routines

2019-12-18 Thread Kirill A. Shutemov
On Wed, Dec 18, 2019 at 02:15:53PM -0800, John Hubbard wrote: > On 12/18/19 7:52 AM, Kirill A. Shutemov wrote: > > On Mon, Dec 16, 2019 at 02:25:13PM -0800, John Hubbard wrote: > > > +static void put_compound_head(struct page *page, int refs) > > > +{ > > > + /* Do a get_page() first, in case refs

Re: [PATCH v2 9/9] drm/bridge: ti-sn65dsi86: Avoid invalid rates

2019-12-18 Thread Doug Anderson
Hi, On Tue, Dec 17, 2019 at 8:03 PM Rob Clark wrote: > > > > + for (i = 0; i < ARRAY_SIZE(sink_rates); i++) { > > > + rate_times_200khz = le16_to_cpu(sink_rates[i]); > > > + > > > + if (!rate_times_200khz) > > > +

[PATCH v3 1/9] drm/bridge: ti-sn65dsi86: Split the setting of the dp and dsi rates

2019-12-18 Thread Douglas Anderson
These two things were in one function. Split into two. This looks like it's duplicating some code, but don't worry. This is is just in preparation for future changes. This is intended to have zero functional change and will just make future patches easier to understand. Signed-off-by: Douglas

[PATCH v3 0/9] drm/bridge: ti-sn65dsi86: Improve support for AUO B116XAK01 + other DP

2019-12-18 Thread Douglas Anderson
This series contains a pile of patches that was created to support hooking up the AUO B116XAK01 panel to the eDP side of the bridge. In general it should be useful for hooking up a wider variety of DP panels to the bridge, especially those with lower resolution and lower bits per pixel. The

[PATCH v3 2/9] drm/bridge: ti-sn65dsi86: zero is never greater than an unsigned int

2019-12-18 Thread Douglas Anderson
When we iterate over ti_sn_bridge_dp_rate_lut, there's no reason to start at index 0 which always contains the value 0. 0 is not a valid link rate. This change should have no real effect but is a small cleanup. Signed-off-by: Douglas Anderson Tested-by: Rob Clark Reviewed-by: Rob Clark ---

[PATCH v3 7/9] drm/bridge: ti-sn65dsi86: Group DP link training bits in a function

2019-12-18 Thread Douglas Anderson
We'll re-organize the ti_sn_bridge_enable() function a bit to group together all the parts relating to link training and split them into a sub-function. This is not intended to have any functional change and is in preparation for trying link training several times at different rates. One small

[PATCH v3 3/9] drm/bridge: ti-sn65dsi86: Don't use MIPI variables for DP link

2019-12-18 Thread Douglas Anderson
The ti-sn65dsi86 is a bridge from MIPI to DP and thus has two links: the MIPI link and the DP link. The two links do not need to have the same format or number of lanes. Stop using MIPI variables when talking about the DP link. This has zero functional change because: * currently we are

[PATCH v3 9/9] drm/bridge: ti-sn65dsi86: Avoid invalid rates

2019-12-18 Thread Douglas Anderson
Based on work by Bjorn Andersson , Jeffrey Hugo , and Rob Clark . Let's read the SUPPORTED_LINK_RATES and/or MAX_LINK_RATE (depending on the eDP version of the sink) to figure out what eDP rates are supported and pick the ideal one. NOTE: I have only personally tested this code on eDP panels

[PATCH v3 8/9] drm/bridge: ti-sn65dsi86: Train at faster rates if slower ones fail

2019-12-18 Thread Douglas Anderson
If we fail training at a lower DP link rate let's now keep trying until we run out of rates to try. Basically the algorithm here is to start at the link rate that is the theoretical minimum and then slowly bump up until we run out of rates or hit the max rate of the sink. We query the sink using

[PATCH v3 5/9] drm/bridge: ti-sn65dsi86: Read num lanes from the DP sink

2019-12-18 Thread Douglas Anderson
At least one panel hooked up to the bridge (AUO B116XAK01) only supports 1 lane of DP. Let's read this information and stop hardcoding 4 DP lanes. Signed-off-by: Douglas Anderson Tested-by: Rob Clark Reviewed-by: Rob Clark --- Changes in v3: None Changes in v2: None

[PATCH v3 4/9] drm/bridge: ti-sn65dsi86: Config number of DP lanes Mo' Betta

2019-12-18 Thread Douglas Anderson
The driver used to say that the value to program into bridge register 0x93 was dp_lanes - 1. Looking at the datasheet for the bridge, this is wrong. The data sheet says: * 1 = 1 lane * 2 = 2 lanes * 3 = 4 lanes A more proper way to express this encoding is min(dp_lanes, 3). At the moment this

[PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2019-12-18 Thread Douglas Anderson
The current bridge driver always forced us to use 24 bits per pixel over the DP link. This is a waste if you are hooked up to a panel that only supports 6 bits per color or fewer, since in that case you ran run at 18 bits per pixel and thus end up at a lower DP clock rate. Let's support this.

Re: [PATCH v4 3/3] drm/udl: simplify gem object mapping.

2019-12-18 Thread Chia-I Wu
On Wed, Dec 18, 2019 at 4:56 AM Gerd Hoffmann wrote: > > With shmem helpers allowing to update pgprot caching flags via > drm_gem_shmem_object.map_cached we can just use that and ditch > our own implementations of mmap() and vmap(). > > We also don't need a special case for imported objects, any

Re: [RFC v2 06/12] drm/i915/svm: Device memory support

2019-12-18 Thread Niranjana Vishwanathapura
On Tue, Dec 17, 2019 at 08:35:47PM +, Jason Gunthorpe wrote: On Fri, Dec 13, 2019 at 01:56:08PM -0800, Niranjana Vishwanathapura wrote: @@ -169,6 +170,11 @@ static int i915_range_fault(struct svm_notifier *sn, return ret; } + /* For

Re: [PATCH v11 01/25] mm/gup: factor out duplicate code from four routines

2019-12-18 Thread John Hubbard
On 12/18/19 7:52 AM, Kirill A. Shutemov wrote: On Mon, Dec 16, 2019 at 02:25:13PM -0800, John Hubbard wrote: +static void put_compound_head(struct page *page, int refs) +{ + /* Do a get_page() first, in case refs == page->_refcount */ + get_page(page); + page_ref_sub(page,

Re: [PATCH v11 06/25] mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM

2019-12-18 Thread John Hubbard
On 12/18/19 8:19 AM, Kirill A. Shutemov wrote: ... diff --git a/mm/gup.c b/mm/gup.c index 3ecce297a47f..c0c56888e7cc 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -29,6 +29,13 @@ struct follow_page_context { unsigned int page_mask; }; +static __always_inline long

Re: [PATCH 1/1] drm/sun4i: hdmi: Remove duplicate cleanup calls

2019-12-18 Thread Maxime Ripard
On Tue, Dec 17, 2019 at 02:46:32PM +0200, Stefan Mavrodiev wrote: > When the HDMI unbinds drm_connector_cleanup() and drm_encoder_cleanup() > are called. This also happens when the connector and the encoder are > destroyed. This double call triggers a NULL pointer exception. > > The patch fixes

Re: [PATCH v13 4/7] drm/sun4i: dsi: Handle bus clock via regmap_mmio_attach_clk

2019-12-18 Thread Maxime Ripard
On Thu, Dec 19, 2019 at 12:40:14AM +0530, Jagan Teki wrote: > regmap has special API to enable the controller bus clock while > initializing register space, and current driver is using > devm_regmap_init_mmio_clk which require to specify bus > clk_id argument as "bus" > > But, the usage of clocks

Re: [PATCH v4 2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272

2019-12-18 Thread Rob Herring
On Tue, 17 Dec 2019 23:29:05 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The XPP055C272 is a 5.5" 720x1280 DSI display. > > changes in v4: > - fix id (Maxime) > - drop port (Maxime) > changes in v2: > - add size info into binding title (Sam) > - add more required properties (Sam) >

Re: [PATCH v4 1/3] dt-bindings: Add vendor prefix for Xinpeng Technology

2019-12-18 Thread Rob Herring
On Tue, 17 Dec 2019 23:29:04 +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > Shenzhen Xinpeng Technology Co., Ltd produces for example display panels. > > Signed-off-by: Heiko Stuebner > Acked-by: Sam Ravnborg > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1

Re: [PATCH v4 1/8] dt-bindings: add img,pvrsgx.yaml for Imagination GPUs

2019-12-18 Thread Rob Herring
On Tue, Dec 17, 2019 at 07:01:59PM +0100, H. Nikolaus Schaller wrote: > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo > and others. > > With this binding, we describe how the SGX processor is > interfaced to the SoC

Re: [PATCH v5 3/4] dt-bindings: Add binding for IT6505.

2019-12-18 Thread Rob Herring
On Sat, Dec 14, 2019 at 09:21:45AM +0100, Sam Ravnborg wrote: > Hi Allen. > > On Tue, Dec 10, 2019 at 01:53:41PM +0800, allen wrote: > > Add a DT binding documentation for IT6505. > > > > Signed-off-by: Allen Chen > > Signed-off-by: Pi-Hsun Shih > > --- > >

Re: [PATCH v6 5/6] dt-bindings: display: Add idk-2121wr binding

2019-12-18 Thread Rob Herring
On Tue, Dec 17, 2019 at 01:46:00PM +, Fabrizio Castro wrote: > Add binding for the idk-2121wr LVDS panel from Advantech. > > Some panel-specific documentation can be found here: > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > >

Re: [PATCH v6 5/6] dt-bindings: display: Add idk-2121wr binding

2019-12-18 Thread Rob Herring
On Tue, Dec 17, 2019 at 01:46:00PM +, Fabrizio Castro wrote: > Add binding for the idk-2121wr LVDS panel from Advantech. > > Some panel-specific documentation can be found here: > https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm > >

Re: [PATCH 3/3] gpu: drm: dead code elimination

2019-12-18 Thread Alex Deucher
On Wed, Dec 18, 2019 at 3:14 AM Pan Zhang wrote: > > this set adds support for removal of gpu drm dead code. > > patch3 is similar with patch 1: > `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, > > so there is a impossible condition '(num > 255) => (0-255 > 255)'. > > Signed-off-by:

Re: [PATCH 1/3] gpu: drm: dead code elimination

2019-12-18 Thread Alex Deucher
On Wed, Dec 18, 2019 at 3:13 AM Pan Zhang wrote: > > this set adds support for removal of gpu drm dead code. > > patch1: > `num` is a data of u8 type and ATOM_MAX_HW_I2C_READ == 255, > > so there is a impossible condition '(num > 255) => (0-255 > 255)'. > > Signed-off-by: Pan Zhang This change

Re: [GIT PULL] Please pull hmm changes

2019-12-18 Thread Linus Torvalds
On Wed, Dec 18, 2019 at 10:37 AM Jason Gunthorpe wrote: > > I think this is what you are looking for? I think that with these names, I would have had an easier time reading the original patch that made me go "Eww", yes. Of course, now that it's just a rename patch, it's not like the patch is

[PATCH v13 5/7] drm/sun4i: dsi: Add Allwinner A64 MIPI DSI support

2019-12-18 Thread Jagan Teki
The MIPI DSI controller in Allwinner A64 is similar to A33. But unlike A33, A64 doesn't have DSI_SCLK gating so add compatible for Allwinner A64 with uninitialized has_mod_clk driver. Signed-off-by: Jagan Teki Tested-by: Merlijn Wajer --- Changes for v13: - update the changes since has_mod_clk

[PATCH v13 3/7] drm/sun4i: dsi: Get the mod clock for A31

2019-12-18 Thread Jagan Teki
As per the user manual, look like mod clock is not mandatory for all Allwinner MIPI DSI controllers, it is connected to CLK_DSI_SCLK for A31 and not available in A64. So, add compatible check for A31 and get mod clock accordingly. Tested-by: Merlijn Wajer Signed-off-by: Jagan Teki --- Changes

[PATCH v13 2/7] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)

2019-12-18 Thread Jagan Teki
The MIPI DSI PHY controller on Allwinner A64 is similar on the one on A31. Add A64 compatible and append A31 compatible as fallback. Reviewed-by: Rob Herring Signed-off-by: Jagan Teki --- Changes for v13: - collect Rob review tag .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml |

[DO NOT MERGE] [PATCH v13 7/7] arm64: dts: allwinner: bananapi-m64: Enable Bananapi S070WV20-CT16 DSI panel

2019-12-18 Thread Jagan Teki
This patch add support for Bananapi S070WV20-CT16 DSI panel to BPI-M64 board. DSI panel connected via board DSI port with, - DLDO1 as VCC-DSI supply - DCDC1 as VDD supply - PD7 gpio for lcd enable pin - PD6 gpio for lcd reset pin - PD5 gpio for backlight enable pin Signed-off-by: Jagan Teki ---

[PATCH v13 1/7] dt-bindings: sun6i-dsi: Document A64 MIPI-DSI controller

2019-12-18 Thread Jagan Teki
The MIPI DSI controller in Allwinner A64 is similar to A33. But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid to have separate compatible for A64 on the same driver. DSI_SCLK uses mod clock-names on dt-bindings, so the same is not required for A64. On that note - A64 require

[PATCH v13 6/7] arm64: dts: allwinner: a64: Add MIPI DSI pipeline

2019-12-18 Thread Jagan Teki
Add MIPI DSI pipeline for Allwinner A64. - dsi node, with A64 compatible since it doesn't support DSI_SCLK gating unlike A33 - dphy node, with A64 compatible with A33 fallback since DPHY on A64 and A33 is similar - finally, attach the dsi_in to tcon0 for complete MIPI DSI Signed-off-by:

[PATCH v13 0/7] drm/sun4i: Allwinner A64 MIPI-DSI support

2019-12-18 Thread Jagan Teki
This is v13 version for Allwinner A64 MIPI-DSI support and here is the previous version set[1] Changes for v13: - update dt-bindings for A64 - drop has_mod_clk variant - use regmap bus clock properly Changes for v12: - use enum insted of oneOf+const - handle bus clock using regmap attach clk -

[PATCH v13 4/7] drm/sun4i: dsi: Handle bus clock via regmap_mmio_attach_clk

2019-12-18 Thread Jagan Teki
regmap has special API to enable the controller bus clock while initializing register space, and current driver is using devm_regmap_init_mmio_clk which require to specify bus clk_id argument as "bus" But, the usage of clocks are varies between different Allwinner DSI controllers. Clocking in A33

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-18 Thread Ezequiel Garcia
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote: > Hi Ezequiel, > > Many thanks for the review, I am just preparing the next version to send. > [..] > > > + > > > +#define PAGE1_VSTART 0x6b > > > +#define PAGE2_SPI_CFG3 0x82 > > > +#define I2C_TO_SPI_RESET

Re: [resend PATCH v6 02/12] dt-bindings: mediatek: Add compatible for mt7623

2019-12-18 Thread Rob Herring
On Sat, 7 Dec 2019 23:47:30 +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > MediaTek mt7623 uses the mt2701 binings as fallback. > Document this in the binding description. > > Signed-off-by: Matthias Brugger > --- >

Re: [GIT PULL] Please pull hmm changes

2019-12-18 Thread Linus Torvalds
On Wed, Dec 18, 2019 at 6:59 AM Jason Gunthorpe wrote: > > Do you think calling it 'mmn_subscriptions' is clear? Why do you want that "mmn"? Guys, the "mmn" part is clear from the _context_. The function name is When the function name is something like "mmu_interval_read_begin()", and the

Re: [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys binding description

2019-12-18 Thread Rob Herring
On Sat, Dec 07, 2019 at 11:47:29PM +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > The MediaTek DRM has a block called mmsys, which sets > the routing and enalbes the different blocks. typo > This patch adds one line for the mmsys bindings description. > > Signed-off-by:

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Harry Wentland
On 2019-12-18 11:13 a.m., Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: >> On 2019-12-18 10:13 a.m., Animesh Manna wrote: >>> [Why]: >>> Aligh with DP spec wanted to follow same naming convention. >>> >>> [How]: >>> Changed the macro name of the dpcd address used for

Re: [PATCH v11 06/25] mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM

2019-12-18 Thread Kirill A. Shutemov
On Mon, Dec 16, 2019 at 02:25:18PM -0800, John Hubbard wrote: > As it says in the updated comment in gup.c: current FOLL_LONGTERM > behavior is incompatible with FAULT_FLAG_ALLOW_RETRY because of the > FS DAX check requirement on vmas. > > However, the corresponding restriction in

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Manna, Animesh
On 18-12-2019 21:12, Harry Wentland wrote: On 2019-12-18 10:13 a.m., Animesh Manna wrote: [Why]: Aligh with DP spec wanted to follow same naming convention. [How]: Changed the macro name of the dpcd address used for getting requested test-pattern. Please roll this into your patch that

Re: [PATCH v11 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages

2019-12-18 Thread Kirill A. Shutemov
On Mon, Dec 16, 2019 at 02:25:16PM -0800, John Hubbard wrote: > An upcoming patch changes and complicates the refcounting and > especially the "put page" aspects of it. In order to keep > everything clean, refactor the devmap page release routines: > > * Rename put_devmap_managed_page() to

Re: [PATCH v11 01/25] mm/gup: factor out duplicate code from four routines

2019-12-18 Thread Kirill A. Shutemov
On Mon, Dec 16, 2019 at 02:25:13PM -0800, John Hubbard wrote: > +static void put_compound_head(struct page *page, int refs) > +{ > + /* Do a get_page() first, in case refs == page->_refcount */ > + get_page(page); > + page_ref_sub(page, refs); > + put_page(page); > +} It's not

Re: [PATCH v3 02/10] drm/bridge: dw-hdmi: add max bpc connector property

2019-12-18 Thread Laurent Pinchart
Hi Neil and Jonas, Thank you for the patch. On Wed, Dec 18, 2019 at 04:46:29PM +0100, Neil Armstrong wrote: > From: Jonas Karlman > > Add the max_bpc property to the dw-hdmi connector to prepare support > for 10, 12 & 16bit output support. > > Signed-off-by: Jonas Karlman > Signed-off-by:

[PATCH v3 06/10] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs

2019-12-18 Thread Neil Armstrong
Switch the dw-hdmi driver to drm_bridge_funcs by implementing a new local bridge, connecting it to the dw-hdmi bridge, then implement the atomic_get_input_bus_fmts/atomic_get_output_bus_fmts. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 98

[PATCH v3 10/10] drm/meson: Add YUV420 output support

2019-12-18 Thread Neil Armstrong
This patch adds support for the YUV420 output from the Amlogic Meson SoCs Video Processing Unit to the HDMI Controller. The YUV420 is obtained by generating a YUV444 pixel stream like the classic HDMI display modes, but then the Video Encoder output can be configured to down-sample the YUV444

[PATCH v3 02/10] drm/bridge: dw-hdmi: add max bpc connector property

2019-12-18 Thread Neil Armstrong
From: Jonas Karlman Add the max_bpc property to the dw-hdmi connector to prepare support for 10, 12 & 16bit output support. Signed-off-by: Jonas Karlman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH v3 03/10] drm/bridge: synopsys: dw-hdmi: add bus format negociation

2019-12-18 Thread Neil Armstrong
Add the atomic_get_output_bus_fmts, atomic_get_input_bus_fmts to negociate the possible output and input formats for the current mode and monitor, and use the negotiated formats in a basic atomic_check callback. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 272

[PATCH v3 08/10] drm/meson: venc: add support for YUV420 setup

2019-12-18 Thread Neil Armstrong
This patch adds encoding support for the YUV420 output from the Amlogic Meson SoCs Video Processing Unit to the HDMI Controller. The YUV420 is obtained by generating a YUV444 pixel stream like the classic HDMI display modes, but then the Video Encoder output can be configured to down-sample the

[PATCH v3 07/10] drm/meson: dw-hdmi: stop enforcing input_bus_format

2019-12-18 Thread Neil Armstrong
To allow using formats from negotiation, stop enforcing input_bus_format in the private dw-plat-data struct. Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 05/10] drm/meson: venc: make drm_display_mode const

2019-12-18 Thread Neil Armstrong
Before switching to bridge funcs, make sure drm_display_mode is passed as const to the venc functions. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 2 +- drivers/gpu/drm/meson/meson_venc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 09/10] drm/meson: vclk: add support for YUV420 setup

2019-12-18 Thread Neil Armstrong
This patch adds clocking support for the YUV420 output from the Amlogic Meson SoCs Video Processing Unit to the HDMI Controller. The YUV420 is obtained by generating a YUV444 pixel stream like the classic HDMI display modes, but then the Video Encoder output can be configured to down-sample the

[PATCH v3 01/10] drm/bridge: dw-hdmi: set mtmdsclock for deep color

2019-12-18 Thread Neil Armstrong
From: Jonas Karlman Configure the correct mtmdsclock for deep colors to prepare support for 10, 12 & 16bit output. Signed-off-by: Jonas Karlman Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH v3 04/10] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2019-12-18 Thread Neil Armstrong
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support for these modes in the connector if the platform supports them. We limit these modes to DW-HDMI IP version >= 0x200a which are designed to support HDMI2.0 display modes. Signed-off-by: Neil Armstrong ---

[PATCH v3 00/10] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support

2019-12-18 Thread Neil Armstrong
This patchset is based on Boris's v4 "drm: Add support for bus-format negotiation" at [1] patchset to implement full bus-format negotiation for DW-HDMI, including YUV420 support and 10/12/16bit YUV444, YUV422 and RGB. The Color Space Converter support is already implemented. And the

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Harry Wentland
On 2019-12-18 10:13 a.m., Animesh Manna wrote: > [Why]: > Aligh with DP spec wanted to follow same naming convention. > > [How]: > Changed the macro name of the dpcd address used for getting requested > test-pattern. > Please roll this into your patch that renames the definition. All patches

Re: [PATCH v3 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2019-12-18 Thread Tomi Valkeinen
On 18/12/2019 16:46, Laurent Pinchart wrote: Hi Tomi, On Wed, Dec 18, 2019 at 09:07:52AM +0200, Tomi Valkeinen wrote: On 18/12/2019 04:03, Laurent Pinchart wrote: Hopefully we can soon have this series landed so we can start working on top of the new bridge/connector handling. I assume it

[PATCH v2 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2019-12-18 Thread Animesh Manna
vswing/pre-emphasis adjustment calculation is needed in processing of auto phy compliance request other than link training, so moved the same function in intel_dp.c. No functional change. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 32 +++

[PATCH v2 6/9] drm/i915/dp: Add debugfs entry for DP phy compliance.

2019-12-18 Thread Animesh Manna
These debugfs entry will help testapp to understand the test request during dp phy compliance mode. Acked-by: Manasi Navare Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_debugfs.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH v2 5/9] drm/i915/dsb: Send uevent to testapp.

2019-12-18 Thread Animesh Manna
Send uevent to testapp and set test_active flag. To align with link compliance design existing intel_dp_compliance tool will be used to get the phy request in userspace through uevent. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_dp.c | 10 -- 1 file changed, 8

[PATCH v2 7/9] drm/i915/dp: Register definition for DP compliance register

2019-12-18 Thread Animesh Manna
DP_COMP_CTL and DP_COMP_PAT register used to program DP compliance pattern. Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_reg.h | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[PATCH v2 8/9] drm/i915/dp: Update the pattern as per request

2019-12-18 Thread Animesh Manna
As per request from DP phy compliance test few special test pattern need to set by source. Added function to set pattern in DP_COMP_CTL register. It will be called along with other test parameters like vswing, pre-emphasis programming in atomic_commit_tail path. Signed-off-by: Animesh Manna ---

[PATCH v2 9/9] drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern

2019-12-18 Thread Animesh Manna
This patch process phy compliance request by programming requested vswing, pre-emphasis and test pattern. Note: FIXME tag added as design discusion is ongoing in previous patch series. Some temporary fix added and the patch is under-development, not for review. Signed-off-by: Animesh Manna ---

[PATCH v2 4/9] drm/i915/dp: Preparation for DP phy compliance auto test

2019-12-18 Thread Animesh Manna
During DP phy compliance auto test mode, sink will request combination of different test pattern with differnt level of vswing, pre-emphasis. Function added to prepare for it. Reviewed-by: Manasi Navare Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 1 +

[PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Animesh Manna
[Why]: Aligh with DP spec wanted to follow same naming convention. [How]: Changed the macro name of the dpcd address used for getting requested test-pattern. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Animesh Manna --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file

[PATCH v2 1/9] drm/dp: get/set phy compliance pattern

2019-12-18 Thread Animesh Manna
During phy compliance auto test mode source need to read requested test pattern from sink through DPCD. After processing the request source need to set the pattern. So set/get method added in drm layer as it is DP protocol. v2: As per review feedback from Manasi on RFC version, - added dp

[PATCH v2 0/9] DP Phy compliance auto test

2019-12-18 Thread Animesh Manna
Driver changes mainly to process the request coming from Test equipment as short pulse hpd interrupt to change link-pattern/v-swing/pre-emphasis Complete auto test suite takes much lesser time than manual run. Overall design: -- Automate test request will come to source device as HDP

Re: [GIT PULL FOR v5.6] R-Car DU new features

2019-12-18 Thread Daniel Vetter
git://linuxtv.org/pinchartl/media.git tags/du-next-20191218 > > for you to fetch changes up to c267782c5f0efbd20c560101738e68bb30d4fad5: > > drm: rcar-du: Add r8a77980 support (2019-12-18 02:40:29 +0200) > > --

[GIT PULL FOR v5.6] R-Car DU new features

2019-12-18 Thread Laurent Pinchart
Hi Dave and Daniel, The following changes since commit d1eef1c619749b2a57e514a3fa67d9a516ffa919: Linux 5.5-rc2 (2019-12-15 15:16:08 -0800) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git tags/du-next-20191218 for you to fetch changes up

Re: [Intel-gfx] [PATCH 1/5] drm: Add __drm_atomic_helper_crtc_state_reset() & co.

2019-12-18 Thread Ville Syrjälä
On Fri, Dec 13, 2019 at 03:38:53PM -0800, Lucas De Marchi wrote: > On Thu, Nov 07, 2019 at 04:24:13PM +0200, Ville Syrjälä wrote: > >From: Ville Syrjälä > > > >Annoyingly __drm_atomic_helper_crtc_reset() does two > >totally separate things: > >a) reset the state to defaults values > >b) assign

Re: [PATCH v3 00/50] drm/omap: Replace custom display drivers with drm_bridge and drm_panel

2019-12-18 Thread Laurent Pinchart
Hi Tomi, On Wed, Dec 18, 2019 at 09:07:52AM +0200, Tomi Valkeinen wrote: > On 18/12/2019 04:03, Laurent Pinchart wrote: > >> Hopefully we can soon have this series landed so we can start > >> working on top of the new bridge/connector handling. > >> > >> I assume it will be applied direct to

Re: [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom,gpu-pwrlevels" absence

2019-12-18 Thread Fabio Estevam
Hi Rob, On Tue, Dec 10, 2019 at 8:12 PM Fabio Estevam wrote: > > Booting the adreno driver on a imx53 board leads to the following > error message: > > adreno 3000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU > powerlevels > > As the "qcom,gpu-pwrlevels" property is optional

Re: [PATCH v3 36/50] drm/omap: Switch the HDMI and VENC outputs to drm_bridge

2019-12-18 Thread Tomi Valkeinen
On 11/12/2019 00:57, Laurent Pinchart wrote: The TPD12S015, OPA362 and analog and HDMI connectors are now supported by DRM bridge drivers, and the omapdrm HDMI and VENC outputs can be handled through the drm_bridge API. Switch the outputs to drm_bridge by making the next bridge mandatory and

Re: [PATCH] drm/bridge: panel: Fix typo in drm_panel_bridge_add docs

2019-12-18 Thread Laurent Pinchart
Hi Enric, Thank you for the patch. On Wed, Dec 18, 2019 at 01:12:23PM +0100, Enric Balletbo i Serra wrote: > Fix the 'manged' typo with 'managed' in the drm_panel_bridge_add > kernel-doc documentation. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart > --- > >

Re: [GIT PULL FOR v5.6] R-Car DU & LVDS decoder

2019-12-18 Thread Laurent Pinchart
Hi Neil, On Wed, Dec 18, 2019 at 12:55:24PM +0100, Neil Armstrong wrote: > On 18/12/2019 12:22, Neil Armstrong wrote: > > On 18/12/2019 01:44, Laurent Pinchart wrote: > >> On Tue, Dec 17, 2019 at 02:23:57PM +0100, Neil Armstrong wrote: > >>> On 17/12/2019 13:43, Daniel Vetter wrote: > On

[PATCH v4 1/3] drm/shmem: add support for per object caching flags.

2019-12-18 Thread Gerd Hoffmann
Add map_cached bool to drm_gem_shmem_object, to request cached mappings on a per-object base. Check the flag before adding writecombine to pgprot bits. Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_shmem_helper.h | 5 + drivers/gpu/drm/drm_gem_shmem_helper.c | 12 +---

[PATCH v4 3/3] drm/udl: simplify gem object mapping.

2019-12-18 Thread Gerd Hoffmann
With shmem helpers allowing to update pgprot caching flags via drm_gem_shmem_object.map_cached we can just use that and ditch our own implementations of mmap() and vmap(). We also don't need a special case for imported objects, any map requests are handled by the exporter not udl. Signed-off-by:

[PATCH v4 2/3] drm/virtio: fix mmap page attributes

2019-12-18 Thread Gerd Hoffmann
virtio-gpu uses cached mappings, set drm_gem_shmem_object.map_cached accordingly. Reported-by: Gurchetan Singh Signed-off-by: Gerd Hoffmann virtio fixup --- drivers/gpu/drm/virtio/virtgpu_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c

  1   2   >