Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-11 Thread Pan, Xinhui
> 2020年2月11日 23:43,Christian König 写道: > > When non-imported BOs are resurrected for delayed delete we replace > the dma_resv object to allow for easy reclaiming of the resources. > > v2: move that to ttm_bo_individualize_resv > v3: add a comment to explain what's going on > > Signed-off-by:

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Tue, Feb 11, 2020 at 8:05 PM Jeffrey Hugo wrote: > > On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo > > wrote: > > > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > >

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Nicolas Boichat
On Wed, Feb 12, 2020 at 4:09 AM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat > > wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Rob Herring
On Tue, Feb 11, 2020 at 2:09 PM Saravana Kannan wrote: > > On Tue, Feb 11, 2020 at 11:44 AM Rob Herring wrote: > > > > +Saravana > > > > On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat > > wrote: > > > > > > When there is a single power domain per device, the core will > > > ensure the power

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-11 Thread Luben Tuikov
On 2020-02-11 4:27 p.m., Andrey Grodzovsky wrote: > > On 2/11/20 10:55 AM, Andrey Grodzovsky wrote: >> On 2/10/20 4:50 PM, Luben Tuikov wrote: >>> Hi Lucas, >>> >>> Thank you for bringing awareness of this issue, publicly. >>> >>> As soon as this patch showed up back in November of 2019, >>> I

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > > > >> > > > >> On 2020-02-06 20:29,

[PATCH 3/4] drm/virtio: track whether or not a context has been initiated

2020-02-11 Thread Gurchetan Singh
We only want create a new virglrenderer context after the first 3D ioctl. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_ioctl.c | 5 + drivers/gpu/drm/virtio/virtgpu_kms.c | 2 ++ 3 files changed, 8 insertions(+) diff

Re: [Intel-gfx] [PATCH] drm/mm: Break long searches in fragmented address spaces

2020-02-11 Thread Andi Shyti
Hi Chris, On Fri, Feb 07, 2020 at 03:17:20PM +, Chris Wilson wrote: > We try hard to select a suitable hole in the drm_mm first time. But if > that is unsuccessful, we then have to look at neighbouring nodes, and > this requires traversing the rbtree. Walking the rbtree can be slow > (much

[PATCH 4/4] drm/virtio: enqueue virtio_gpu_create_context after first 3D ioctl

2020-02-11 Thread Gurchetan Singh
With virtio_gpu_notify(..), the create context command now is batched with the first 3D hypercall. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 5 + drivers/gpu/drm/virtio/virtgpu_kms.c | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 2/4] drm/virtio: factor out context create cmd

2020-02-11 Thread Gurchetan Singh
We currently do it when open the DRM fd, let's delay it. First step, remove the hyercall from initialization. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 ++ drivers/gpu/drm/virtio/virtgpu_ioctl.c | 16 drivers/gpu/drm/virtio/virtgpu_kms.c |

[PATCH 0/4] *** Delay enqueuing context create command ***

2020-02-11 Thread Gurchetan Singh
Let's delay enqueuing the context creation command until the first 3D ioctl, as we add more context types. This is based on kraxel's "drm/virtio: rework batching" patch and needs that to work correctly. Gurchetan Singh (4): drm/virtio: use consistent names for drm_files drm/virtio: factor

[PATCH 1/4] drm/virtio: use consistent names for drm_files

2020-02-11 Thread Gurchetan Singh
Minor cleanup, change: - file_priv--> file, - drm_file --> file. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

Re: [PATCH] drm/virtio: rework batching

2020-02-11 Thread Gurchetan Singh
On Tue, Feb 11, 2020 at 4:58 AM Gerd Hoffmann wrote: > > Drop the virtio_gpu_{disable,enable}_notify(). Add a new > virtio_gpu_notify() call instead, which must be called whenever > the driver wants make sure the host is notified needed. > > Drop notification from command submission. Add

Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter

2020-02-11 Thread Andrew Lunn
On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote: > This is needed to give the MIPS Ingenic CI20 board a stable MAC address > which can be optionally provided by vendor U-Boot. > > For get_mac_addr() we use an adapted copy of from ksz884x.c which > has very similar

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-11 Thread Andrey Grodzovsky
On 2/11/20 10:55 AM, Andrey Grodzovsky wrote: On 2/10/20 4:50 PM, Luben Tuikov wrote: Hi Lucas, Thank you for bringing awareness of this issue, publicly. As soon as this patch showed up back in November of 2019, I objected to it, privately. I didn't find this objection in my mail actually

[PATCH v8 libdrm 2/2] Add drmModeGetFB2

2020-02-11 Thread Juston Li
From: Daniel Stone Add a wrapper around the getfb2 ioctl, which returns extended framebuffer information mirroring addfb2, including multiple planes and modifiers. Changes since v7: - add new symbols to core-symbol.txt (Eric Engestrom) Changes since v5: - style change Changes since v4: -

[PATCH v8 libdrm 1/2] include/drm: sync up drm.h

2020-02-11 Thread Juston Li
a) delta: Adds DRM_IOCTL_MODE_GETFB2 b) Generated using make headers_install c) Taken from drm-next-misc: commit 3ff4c24bdb1f494c217c80348f9db4896043ed81 Author: Lyude Paul Date: Fri Jan 17 17:47:48 2020 -0500 drm/dp_mst: Fix indenting in

Re: [PATCH] dt-bindings: display: sunxi: Fix compatible

2020-02-11 Thread Rob Herring
On Mon, Feb 10, 2020 at 4:05 AM Maxime Ripard wrote: > > Commit f5a98bfe7b37 ("dt-bindings: display: Convert Allwinner display > pipeline to schemas") introduced a YAML schema for the Allwinner TCON DT > binding, but the H6 TCON-TV compatible was mistakenly set to fallback on > the A83t's, while

Re: [PATCH v4 5/7] drm/panfrost: Add support for multiple power domains

2020-02-11 Thread Rob Herring
+Saravana On Thu, Feb 6, 2020 at 11:27 PM Nicolas Boichat wrote: > > When there is a single power domain per device, the core will > ensure the power domain is switched on (so it is technically > equivalent to having not power domain specified at all). > > However, when there are multiple

[PATCH v7 libdrm 2/2] Add drmModeGetFB2

2020-02-11 Thread Juston Li
From: Daniel Stone Add a wrapper around the getfb2 ioctl, which returns extended framebuffer information mirroring addfb2, including multiple planes and modifiers. Changes since v5: - style change Changes since v4: - Set fb_id at init instead of memclear() and set (Eric Engestrom) Changes

[PATCH v7 libdrm 1/2] include/drm: sync up drm.h

2020-02-11 Thread Juston Li
a) delta: Adds DRM_IOCTL_MODE_GETFB2 b) Generated using make headers_install c) Taken from drm-next-misc: commit 3ff4c24bdb1f494c217c80348f9db4896043ed81 Author: Lyude Paul Date: Fri Jan 17 17:47:48 2020 -0500 drm/dp_mst: Fix indenting in

[PATCH v2 2/3] drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel

2020-02-11 Thread Lyude Paul
The X1 Extreme is one of the systems that lies about which backlight interface that it uses in its VBIOS as PWM backlight controls don't work at all on this machine. It's possible that this panel could be one of the infamous ones that can switch between PWM mode and DPCD backlight control mode,

[PATCH v2 3/3] drm/i915: Force DPCD backlight mode for some Dell CML 2020 panels

2020-02-11 Thread Lyude Paul
According to Dell, trying to match their panels via OUI is not reliable enough and we've been told that we should check against the EDID instead. As well, Dell seems to have some panels that are actually intended to switch between using PWM for backlight controls and DPCD for backlight controls

[PATCH v2 1/3] drm/dp: Introduce EDID-based quirks

2020-02-11 Thread Lyude Paul
The whole point of using OUIs is so that we can recognize certain devices and potentially apply quirks for them. Normally this should work quite well, but there appears to be quite a number of laptop panels out there that will fill the OUI but not the device ID. As such, for devices like this I

[PATCH v2 0/3] drm/dp, i915: eDP DPCD backlight control detection fixes

2020-02-11 Thread Lyude Paul
Unfortunately, it turned out that the DPCD is also not a reliable way of probing for DPCD backlight support as some panels will lie and say they have DPCD backlight controls when they don't actually. So, revert back to the old behavior and add a bunch of EDID-based DP quirks for the panels that

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Tomi Valkeinen
On 11/02/2020 18:27, Tony Lindgren wrote: We are still missing DSI command mode support, and moving it to the common DRM model. Nope, DSI command mode support has been working just fine for a while now :) And Sebastian has a WIP git tree of the common DRM Indeed... It had been going on for

Re: [Nouveau] [PATCH 4/4] drm/nouveau: Remove struct nouveau_framebuffer

2020-02-11 Thread James Jones
On 2/10/20 3:35 PM, Ben Skeggs wrote: On Tue, 11 Feb 2020 at 09:17, James Jones wrote: On 2/10/20 12:25 AM, Thomas Zimmermann wrote: Hi Am 10.02.20 um 09:20 schrieb Ben Skeggs: On Sat, 8 Feb 2020 at 07:10, James Jones wrote: I've sent out a v4 version of the format modifier patches

Re: [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-02-11 Thread Ville Syrjälä
On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 06:22:08PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Let's simplify life of driver by allowing them to leave > > encoder->possible_crtcs unset if they have no restrictions > > in

Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Ville Syrjälä
On Tue, Feb 11, 2020 at 06:02:33PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Many drivers are populating encoder->possible_clones wrong. Let's > > persuade them to get it right by adding some loud WARNs. > > > >

Re: [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:22:08PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Let's simplify life of driver by allowing them to leave > encoder->possible_crtcs unset if they have no restrictions > in crtc<->encoder linkage. We'll just populate possible_crtcs > with the full crtc mask

Re: [PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:22:07PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > WARN if the encoder possible_crtcs is effectively empty or contains > bits for non-existing crtcs. > > v2: Move to drm_mode_config_validate() (Daniel) > Make the docs say we WARN when this is wrong

Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Many drivers are populating encoder->possible_clones wrong. Let's > persuade them to get it right by adding some loud WARNs. > > We'll cross check the bits between any two encoders. So either > both

Re: [PATCH v3 1/7] drm: Include the encoder itself in possible_clones

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:22:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The docs say possible_clones should always include the encoder itself. > Since most drivers don't want to deal with the complexities of cloning > let's allow them to set possible_clones=0 and instead we'll

Re: [PATCH] drm/irq: remove check on dev->dev_private

2020-02-11 Thread Jani Nikula
On Tue, 11 Feb 2020, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 04:47:53PM +0200, Jani Nikula wrote: >> There is no real reason to require drivers to set and use >> dev->dev_private. Indeed, the current recommendation, as documented in >> drm_device.h, is to embed struct drm_device in the

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Tomi Valkeinen
On 11/02/2020 18:05, Tony Lindgren wrote: * Merlijn Wajer [200211 12:54]: Hi, On 11/02/2020 12:08, Tomi Valkeinen wrote: On 11/02/2020 13:07, Laurent Pinchart wrote: Hopefully soon (in five years? =) we can say that omapdrm supports all the boards, and we can deprecate omapfb. I'd love

Re: [RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status'

2020-02-11 Thread Alex Deucher
On Mon, Feb 10, 2020 at 10:38 AM YueHaibing wrote: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: > In function dcn10_post_unlock_program_front_end: > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2623:29: > warning: variable stream_status set but

[PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä Let's simplify life of driver by allowing them to leave encoder->possible_crtcs unset if they have no restrictions in crtc<->encoder linkage. We'll just populate possible_crtcs with the full crtc mask when registering the encoder so that userspace doesn't have to deal with

[PATCH v3 6/7] drm: Validate encoder->possible_crtcs

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä WARN if the encoder possible_crtcs is effectively empty or contains bits for non-existing crtcs. v2: Move to drm_mode_config_validate() (Daniel) Make the docs say we WARN when this is wrong (Daniel) Extract full_crtc_mask() Cc: Thomas Zimmermann Cc: Daniel Vetter

[PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä Many drivers are populating encoder->possible_clones wrong. Let's persuade them to get it right by adding some loud WARNs. We'll cross check the bits between any two encoders. So either both encoders can clone with the other, or neither can. We'll also complain about

[PATCH v3 3/7] drm/exynos: Use drm_encoder_mask()

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä Replace the hand rolled encoder bitmask thing with drm_encoder_mask() Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Acked-by: Thomas Zimmermann Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 ++--- 1 file changed, 2

[PATCH v3 0/7] drm: Try to fix encoder possible_clones/crtc

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä Another respin of the possible_clones/crtcs fixing. Changes based on v2 review: - introduce drm_mode_config_validate() - WARN for possible_clones!=0 when the encoder itself isn't in the mask - update the documentation to match the code Other changes: - sligth refactoring

[PATCH v3 2/7] drm/gma500: Sanitize possible_clones

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä I doubt the DP+DP and SDVO+SDVO cloning works for this driver. i915 at least doesn't do those. Truthfully there could be some very specific circumstances where some of them would do doable, but genereally it's too much pain to deal with so we've chose not to bother. Let's use

[PATCH v3 4/7] drm/imx: Remove the bogus possible_clones setup

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä It's not at all clear what cloning options this driver supports. So let's just clear possible_clones instead of setting it to some bogus value. v2: Adjust the FIXME (Daniel) Cc: Philipp Zabel Acked-by: Daniel Vetter Signed-off-by: Ville Syrjälä ---

[PATCH v3 1/7] drm: Include the encoder itself in possible_clones

2020-02-11 Thread Ville Syrjala
From: Ville Syrjälä The docs say possible_clones should always include the encoder itself. Since most drivers don't want to deal with the complexities of cloning let's allow them to set possible_clones=0 and instead we'll fix that up in the core. We can't put this special case into

Re: [PATCH 13/15] drm/amdgpu/display: split dp connector registration (v3)

2020-02-11 Thread Alex Deucher
Ping? Alex On Fri, Feb 7, 2020 at 4:17 PM Alex Deucher wrote: > > Split into init and register functions to avoid a segfault > in some configs when the load/unload callbacks are removed. > > v2: > - add back accidently dropped has_aux setting > - set dev in late_register > > v3: > - fix dp cec

[PATCH V7] drm: Add support for DP 1.4 Compliance edid corruption test

2020-02-11 Thread Jerry (Fangzhi) Zuo
Unlike DP 1.2 edid corruption test, DP 1.4 requires to calculate real CRC value of the last edid data block, and write it back. Current edid CRC calculates routine adds the last CRC byte, and check if non-zero. This behavior is not accurate; actually, we need to return the actual CRC value when

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-11 Thread Andrey Grodzovsky
On 2/10/20 4:50 PM, Luben Tuikov wrote: Hi Lucas, Thank you for bringing awareness of this issue, publicly. As soon as this patch showed up back in November of 2019, I objected to it, privately. I didn't find this objection in my mail actually I suggested to instead use a _list_ to

Applied "drm/mediatek: exit earlier if failed to register audio driver" to the asoc tree

2020-02-11 Thread Mark Brown
The patch drm/mediatek: exit earlier if failed to register audio driver has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Applied "ASoC: mediatek: mt8173-rt5650: support HDMI jack reporting" to the asoc tree

2020-02-11 Thread Mark Brown
The patch ASoC: mediatek: mt8173-rt5650: support HDMI jack reporting has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next

Applied "drm/mediatek: support HDMI jack status reporting" to the asoc tree

2020-02-11 Thread Mark Brown
The patch drm/mediatek: support HDMI jack status reporting has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours)

Re: [PATCH v3 0/2] drm/panel: simple: Rocktech RK101II01D-CT + binding

2020-02-11 Thread Sam Ravnborg
Hi Jyri On Tue, Feb 11, 2020 at 02:17:16PM +0200, Jyri Sarha wrote: > Add support for Rocktech RK101II01D-CT panel to panel-simple and add > yaml binding for it. > > Changes since v2: > - No separate binding document, just add new compatible to panel-simple.yaml > > Changes since first fersion:

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 04:43:26PM +0100, Christian König wrote: > When non-imported BOs are resurrected for delayed delete we replace > the dma_resv object to allow for easy reclaiming of the resources. > > v2: move that to ttm_bo_individualize_resv > v3: add a comment to explain what's going on

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Rob Clark
On Mon, Feb 10, 2020 at 9:58 PM wrote: > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > >> > >> On 2020-02-06 20:29, Jeffrey Hugo wrote: > >> > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P > >> > wrote: > >> >> > >> >> For a given byte clock, if VCO

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 11:46:26AM +, Emil Velikov wrote: > On Tue, 11 Feb 2020 at 08:06, Pekka Paalanen wrote: > > > > On Mon, 10 Feb 2020 19:01:06 + > > Emil Velikov wrote: > > > > > Thanks for having a look Daniel. > > > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > >

[PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-11 Thread Christian König
When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. v2: move that to ttm_bo_individualize_resv v3: add a comment to explain what's going on Signed-off-by: Christian König Reviewed-by: xinhui pan ---

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 04:40:21PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 03:00:30PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 11, 2020 at 11:11:34AM +0200, Tomi Valkeinen wrote: > > > Hi Ville, > > > > > > On 10/02/2020 18:03, Ville Syrjälä wrote: > > > > > > > The usual

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 03:00:30PM +0200, Ville Syrjälä wrote: > On Tue, Feb 11, 2020 at 11:11:34AM +0200, Tomi Valkeinen wrote: > > Hi Ville, > > > > On 10/02/2020 18:03, Ville Syrjälä wrote: > > > > > The usual approach we follow in i915 for things that affect more > > > than one plane is is

Re: [Freedreno] [PATCH] drm/msm/a6xx: Correct the highestbank configuration

2020-02-11 Thread Rob Clark
On Fri, Jan 31, 2020 at 12:00 AM Akhil P Oommen wrote: > > On 1/24/2020 11:56 PM, Jordan Crouse wrote: > > On Fri, Jan 24, 2020 at 05:50:11PM +0530, Akhil P Oommen wrote: > >> Highest bank bit configuration is different for a618 gpu. Update > >> it with the correct configuration which is the

Re: [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 4:23 PM Christian König wrote: > > Am 11.02.20 um 16:02 schrieb Pan, Xinhui: > > > >> 2020年2月11日 22:14,Daniel Vetter 写道: > >> > >> On Mon, Feb 10, 2020 at 04:09:06PM +0100, Christian König wrote: > >>> When non-imported BOs are resurrected for delayed delete we replace >

Re: [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2

2020-02-11 Thread Christian König
Am 11.02.20 um 16:02 schrieb Pan, Xinhui: 2020年2月11日 22:14,Daniel Vetter 写道: On Mon, Feb 10, 2020 at 04:09:06PM +0100, Christian König wrote: When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. v2: move that

Re: [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2

2020-02-11 Thread Christian König
Am 11.02.20 um 15:14 schrieb Daniel Vetter: On Mon, Feb 10, 2020 at 04:09:06PM +0100, Christian König wrote: When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. v2: move that to ttm_bo_individualize_resv

Re: [PATCH] drm/irq: remove check on dev->dev_private

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 04:47:53PM +0200, Jani Nikula wrote: > There is no real reason to require drivers to set and use > dev->dev_private. Indeed, the current recommendation, as documented in > drm_device.h, is to embed struct drm_device in the per-device struct > instead of using dev_private. >

Re: [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2

2020-02-11 Thread Pan, Xinhui
> 2020年2月11日 22:14,Daniel Vetter 写道: > > On Mon, Feb 10, 2020 at 04:09:06PM +0100, Christian König wrote: >> When non-imported BOs are resurrected for delayed delete we replace >> the dma_resv object to allow for easy reclaiming of the resources. >> >> v2: move that to

[bug report] drm: revocation check at drm subsystem

2020-02-11 Thread Dan Carpenter
Hello Ramalingam C, The patch 6498bf5800a3: "drm: revocation check at drm subsystem" from May 7, 2019, leads to the following static checker warning: drivers/gpu/drm/drm_hdcp.c:195 drm_hdcp_parse_hdcp2_srm() warn: mask and shift to zero drivers/gpu/drm/drm_hdcp.c 190

[PATCH] drm/irq: remove check on dev->dev_private

2020-02-11 Thread Jani Nikula
There is no real reason to require drivers to set and use dev->dev_private. Indeed, the current recommendation, as documented in drm_device.h, is to embed struct drm_device in the per-device struct instead of using dev_private. Remove the requirement for dev_private to have been set to indicate

Re: [PATCH v4] drm/virtio: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 02:58:04PM +0100, Gerd Hoffmann wrote: > Split virtio_gpu_deinit(), move the drm shutdown and release to > virtio_gpu_release(). Drop vqs_ready variable, instead use > drm_dev_{enter,exit,unplug} to avoid touching hardware after > device removal. Tidy up here and there. >

Re: [PATCH v4] drm/cirrus: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 02:55:22PM +0100, Gerd Hoffmann wrote: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). > > Use drm_dev_{enter,exit,unplug} to avoid touching hardware after > device removal. > > v4: add

Re: [PATCH v4] drm/bochs: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 02:52:18PM +0100, Gerd Hoffmann wrote: > Call bochs_unload via drm_driver.release to make sure we release stuff > when it is safe to do so. Use drm_dev_{enter,exit,unplug} to avoid > touching hardware after device removal. Tidy up here and there. > > v4: add changelog. >

Re: [PATCH 5/6] drm/ttm: replace dma_resv object on deleted BOs v2

2020-02-11 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 04:09:06PM +0100, Christian König wrote: > When non-imported BOs are resurrected for delayed delete we replace > the dma_resv object to allow for easy reclaiming of the resources. > > v2: move that to ttm_bo_individualize_resv > > Signed-off-by: Christian König > --- >

Re: [PATCH] drm/ttm: rework BO delayed delete. v2

2020-02-11 Thread Pan, Xinhui
Reviewed-by: xinhui pan > 2020年2月11日 21:43,Christian König 写道: > > This patch reworks the whole delayed deletion of BOs which aren't idle. > > Instead of having two counters for the BO structure we resurrect the BO > when we find that a deleted BO is not idle yet. > > This has many

Re: [PATCH v2 00/12] drm/i915/display: convert to drm_device based logging macros.

2020-02-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Wambui Karuga wrote: > This patchset continues the conversion of the printk based drm logging > macros in drm/i915 to use the struct drm_device based logging macros. > This series was done both using coccinelle and manually. Thank you for the patches! I pushed all the

Re: [PATCH v2 06/12] drm/i915/dp_aux_backlight: convert to drm_device based logging macros.

2020-02-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Wambui Karuga wrote: > Conversion of the printk based drm logging macros to the struct > drm_device based logging macros in display/intel_dp_aux_backlight.c. > This also involves extracting the drm_i915_private device pointer from > various intel types to use in the macros. >

Re: [PATCH v2 09/12] drm/i915/dp_mst: convert to drm_device based logging macros.

2020-02-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Wambui Karuga wrote: > Conversion of instances of the printk based drm logging macros to the > struct drm_device based logging macros in i915/display/intel_dp_mst.c. > This also involves extracting the drm_i915_private device pointer from > various intel types to use in the

Re: [PATCH v2 01/12] drm/i915/dp: convert to struct drm_device based logging macros.

2020-02-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Wambui Karuga wrote: > @@ -5990,11 +6040,13 @@ int intel_dp_hdcp_write_an_aksv(struct > intel_digital_port *intel_dig_port, > static int intel_dp_hdcp_read_bksv(struct intel_digital_port *intel_dig_port, > u8 *bksv) > { > + struct

[PATCH v4] drm/virtio: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Split virtio_gpu_deinit(), move the drm shutdown and release to virtio_gpu_release(). Drop vqs_ready variable, instead use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. Tidy up here and there. v4: add changelog. v3: use drm_dev_*(). Signed-off-by: Gerd Hoffmann

[PATCH v4] drm/cirrus: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Move final cleanups from cirrus_pci_remove() to the new callback. Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). Use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. v4: add changelog. v3: use drm_dev*. v2: stop touching hardware after pci_remove().

[PATCH v4] drm/bochs: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Call bochs_unload via drm_driver.release to make sure we release stuff when it is safe to do so. Use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. Tidy up here and there. v4: add changelog. v3: use drm_dev_*(). v2: move hardware deinit to pci_remove().

[PATCH 0/2] drm/virtio: locking/reservation fixes

2020-02-11 Thread Gerd Hoffmann
Gerd Hoffmann (2): drm/virtio: fix virtio_gpu_execbuffer_ioctl locking drm/virtio: fix virtio_gpu_cursor_plane_update(). drivers/gpu/drm/virtio/virtgpu_ioctl.c | 20 ++-- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 2 files changed, 11 insertions(+), 10 deletions(-) --

[PATCH 1/2] drm/virtio: fix virtio_gpu_execbuffer_ioctl locking

2020-02-11 Thread Gerd Hoffmann
Lockdep says we can't call vmemdup() while having objects reserved because it needs the mmap semaphore. So reorder the calls reserve the objects later. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 20 ++-- 1 file changed, 10 insertions(+), 10

[PATCH 2/2] drm/virtio: fix virtio_gpu_cursor_plane_update().

2020-02-11 Thread Gerd Hoffmann
Add missing virtio_gpu_array_lock_resv() call. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index ac42c84d2d7f..d1c3f5fbfee4 100644 ---

Re: [PATCH v2 11/12] drm/i915/hdmi: convert to struct drm_device based logging macros.

2020-02-11 Thread Jani Nikula
On Thu, 06 Feb 2020, Wambui Karuga wrote: > @@ -1364,11 +1372,15 @@ int intel_hdmi_hdcp_write_an_aksv(struct > intel_digital_port *intel_dig_port, > static int intel_hdmi_hdcp_read_bksv(struct intel_digital_port > *intel_dig_port, >u8 *bksv) > { > +

[PATCH] drm/ttm: rework BO delayed delete. v2

2020-02-11 Thread Christian König
This patch reworks the whole delayed deletion of BOs which aren't idle. Instead of having two counters for the BO structure we resurrect the BO when we find that a deleted BO is not idle yet. This has many advantages, especially that we don't need to increment/decrement the BOs reference counter

Re: [PATCH 4/6] drm/ttm: rework BO delayed delete.

2020-02-11 Thread Christian König
[SNIP] + /* +* Make NO_EVICT bos immediately available to +* shrinkers, now that they are queued for +* destruction. +*/ + if (bo->mem.placement & TTM_PL_FLAG_NO_EVICT) { +

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-11 Thread Ville Syrjälä
On Tue, Feb 11, 2020 at 11:11:34AM +0200, Tomi Valkeinen wrote: > Hi Ville, > > On 10/02/2020 18:03, Ville Syrjälä wrote: > > > The usual approach we follow in i915 for things that affect more > > than one plane is is to collect that state into the crtc state. > > That way we get to remember it

Re: [PATCH v2 2/3] drm/virtio: never kick in virtio_gpu_queue_ctrl_sgs

2020-02-11 Thread Gerd Hoffmann
Hi, > @@ -541,6 +539,7 @@ void virtio_gpu_cmd_unref_resource(struct > virtio_gpu_device *vgdev, > cmd_p->resource_id = cpu_to_le32(resource_id); > > virtio_gpu_queue_ctrl_buffer(vgdev, vbuf); > + virtio_gpu_commit_ctrl(vgdev); > } Well, I was more thinking about adding that

[PATCH] drm/virtio: rework batching

2020-02-11 Thread Gerd Hoffmann
Drop the virtio_gpu_{disable,enable}_notify(). Add a new virtio_gpu_notify() call instead, which must be called whenever the driver wants make sure the host is notified needed. Drop notification from command submission. Add virtio_gpu_notify() calls everywhere instead. This results in more

[PATCH v3 0/2] drm/panel: simple: Rocktech RK101II01D-CT + binding

2020-02-11 Thread Jyri Sarha
Add support for Rocktech RK101II01D-CT panel to panel-simple and add yaml binding for it. Changes since v2: - No separate binding document, just add new compatible to panel-simple.yaml Changes since first fersion: - Move to yaml binding Jyri Sarha (2): dt-bindings: panel-simple: Add

[PATCH v3 2/2] drm/panel: simple: Add Rocktech RK101II01D-CT panel

2020-02-11 Thread Jyri Sarha
Add support for Rocktech RK101II01D-CT, 10.1" 1280x800 TFT with LVDS interface, LED backlight and integrated Goodix GT928 capacitive touch panel. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32

[PATCH v3 1/2] dt-bindings: panel-simple: Add rocktech, rk101ii01d-ct compatible

2020-02-11 Thread Jyri Sarha
Add compatible to panel-simple for Rocktech Displays Limited RK101II01D-CT 10.1" TFT 1280x800 Pixels with LVDS interface, LED Backlight, and capacitive touch panel ("goodix,gt928" compatible). Signed-off-by: Jyri Sarha --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++

Re: [PATCH v4 libdrm 2/2] Add drmModeGetFB2

2020-02-11 Thread Eric Engestrom
On Thursday, 2020-02-06 17:46:36 +, Li, Juston wrote: > On Wed, 2020-02-05 at 23:27 +, Eric Engestrom wrote: > > On Wednesday, 2020-02-05 23:10:21 +, Li, Juston wrote: > > > On Wed, 2020-02-05 at 22:25 +, Eric Engestrom wrote: > > > > On Friday, 2020-01-31 13:41:09 -0800, Juston Li

Re: [PATCH 2/2] drm/udl: Clear struct drm_connector_funcs.dpms

2020-02-11 Thread Emil Velikov
On Mon, 10 Feb 2020 at 08:10, Thomas Zimmermann wrote: > > Hi > > Am 07.02.20 um 17:41 schrieb Daniel Vetter: > > On Fri, Feb 07, 2020 at 03:16:02PM +0100, Thomas Zimmermann wrote: > >> Atomic modesetting doesn't use struct drm_connector_funcs.dpms and > >> the set function,

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Emil Velikov
On Mon, 10 Feb 2020 at 21:54, Daniel Vetter wrote: > > On Mon, Feb 10, 2020 at 8:01 PM Emil Velikov wrote: > > > > Thanks for having a look Daniel. > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > > From:

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Emil Velikov
On Tue, 11 Feb 2020 at 08:06, Pekka Paalanen wrote: > > On Mon, 10 Feb 2020 19:01:06 + > Emil Velikov wrote: > > > Thanks for having a look Daniel. > > > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > >

Re: [PATCH 4/4] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI

2020-02-11 Thread Lisovskiy, Stanislav
On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > TGL timeouts when disabling MST transcoder and fifo underruns over > MST > transcoders are fixed when setting TRANS_DDI_MODE_SELECT to 0(HDMI > mode) during the disable sequence. > > Although BSpec disable sequence don't require

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Tomi Valkeinen
On 11/02/2020 13:07, Laurent Pinchart wrote: Hopefully soon (in five years? =) we can say that omapdrm supports all the boards, and we can deprecate omapfb. I'd love to send a patch to remove omapfb, but I'll let you do the honours :-) Not before we add DSI support to omapdrm... Tomi --

Re: [PATCH 0/5] disable drm_global_mutex for most drivers, take 2

2020-02-11 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 10:47:36AM +0100, Thomas Zimmermann wrote: > Hi, > > I smoke-tested the patchset by running X11, Weston and fbdev emulation > on ast and udl. No apparent problems found, so > > Tested-by: Thomas Zimmermann Merged patches 2-5 (first one needs to wait for amdgpu/radeon

Re: Cleanup TTMs delayed delete handling

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 11:06:53AM +, Pan, Xinhui wrote: > [AMD Official Use Only - Internal Distribution Only] Uh might want to fix your email setup. -Daniel > > For patch 1/2/3/5/6 > Reviewed-by: xinhui pan > > From: Christian König > Sent: Monday,

Re: [PATCH v3] drm/bochs: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 10:55:29AM +0100, Gerd Hoffmann wrote: > Call bochs_unload via drm_driver.release to make sure we release stuff > when it is safe to do so. Use drm_dev_{enter,exit,unplug} to avoid > touching hardware after device removal. Tidy up here and there. > > Signed-off-by: Gerd

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Laurent Pinchart
On Tue, Feb 11, 2020 at 01:08:12PM +0200, Tomi Valkeinen wrote: > On 11/02/2020 13:07, Laurent Pinchart wrote: > > >> Hopefully soon (in five years? =) we can say that omapdrm supports all > >> the boards, and we can deprecate omapfb. > > > > I'd love to send a patch to remove omapfb, but I'll

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Laurent Pinchart
Hi Tomi, On Tue, Feb 11, 2020 at 12:01:31PM +0200, Tomi Valkeinen wrote: > On 13/01/2020 14:01, Tomi Valkeinen wrote: > > On 12/12/2019 22:35, Laurent Pinchart wrote: > >> On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote: > >>> On 11/12/2019 18:53, Tony Lindgren wrote: > *

  1   2   >