Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Nicolas Boichat
+Weiyi Lu +Nick Fan @MTK who may have more ideas. On Thu, Feb 13, 2020 at 2:14 AM Rob Herring wrote: > > On Wed, Feb 12, 2020 at 2:49 AM Nicolas Boichat wrote: > > > > +Viresh Kumar +Stephen Boyd for clock advice. > > > > On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat > > wrote: > > > > > >

[drm-intel:drm-intel-next-queued 5/5] drivers/gpu/drm/i915/gt/intel_lrc.c:2335:16: error: unused variable 'regs'

2020-02-12 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: c616d2387aeeb987f03eee848f04ffdc248c7aae commit: c616d2387aeeb987f03eee848f04ffdc248c7aae [5/5] drm/i915/gt: Expand bad CS completion event debug config: i386-randconfig-h003-20200213 (attached as .config) compiler:

Re: [PATCH v4 libdrm 2/2] Add drmModeGetFB2

2020-02-12 Thread Daniel Stone
Hi, On Tue, 11 Feb 2020 at 23:21, Eric Engestrom wrote: > On Thursday, 2020-02-06 17:46:36 +, Li, Juston wrote: > > Yes, drm.h was copied from 'make headers_install' from drm-misc-next. > > It had been updated fairly recently so GETFB2 is the only delta. > > > > Sorry, I didn't see the

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Pan, Xinhui
> 2020年2月12日 19:53,Christian König 写道: > > Am 12.02.20 um 07:23 schrieb Pan, Xinhui: >> >>> 2020年2月11日 23:43,Christian König 写道: >>> >>> When non-imported BOs are resurrected for delayed delete we replace >>> the dma_resv object to allow for easy reclaiming of the resources. >>> >>> v2:

Re: [PATCH 2/2] drm/mediatek: add fb swap in async_update

2020-02-12 Thread CK Hu
Hi, Bibby: On Thu, 2020-02-13 at 09:23 +0800, Bibby Hsieh wrote: > Besides x, y position, width and height, > fb also need updating in async update. > Reviewed-by: CK Hu > Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic > update") > > Signed-off-by: Bibby Hsieh >

Re: [PATCH 1/2] drm/mediatek: add plane check in async_check function

2020-02-12 Thread CK Hu
Hi, Bibby: On Thu, 2020-02-13 at 09:23 +0800, Bibby Hsieh wrote: > MTK do rotation checking and transferring in layer check function, > but we do not check that in atomic_check, > so add back in atomic_check function. > Reviewed-by: CK Hu > Fixes: 920fffcc8912 ("drm/mediatek: update cursors

Re: [resend PATCH v6 00/12] arm/arm64: mediatek: Fix mmsys device probing

2020-02-12 Thread CK Hu
Hi, Matthias: Would you work on this series in a short time? Some Yongqiang's patches [1] also modify mmsys driver, and now it depend on your patch to prevent conflicts. If you would not work on this series in a short time, I would like to apply Yongqiang's patch without this series. [1]

Re: [PATCH 3/4] drm/virtio: track whether or not a context has been initiated

2020-02-12 Thread Chia-I Wu
On Wed, Feb 12, 2020 at 5:54 PM Gurchetan Singh wrote: > > On Wed, Feb 12, 2020 at 10:50 AM Chia-I Wu wrote: > > > > On Tue, Feb 11, 2020 at 3:56 PM Gurchetan Singh > > wrote: > > > > > > We only want create a new virglrenderer context after the first > > > 3D ioctl. > > > > > > Signed-off-by:

Re: [PATCH v2 2/3] drm/mediatek: support HDMI jack status reporting

2020-02-12 Thread CK Hu
Hi, Tzung-Bi: On Wed, 2020-02-12 at 19:31 +0800, Tzung-Bi Shih wrote: > On Wed, Feb 12, 2020 at 4:19 PM CK Hu wrote: > > I think hdmi_conn_detect() and mtk_hdmi_audio_hook_plugged_cb() would be > > called in different thread. So it's necessary to use a mutex to protect > > this. > > Thanks for

Re: [PATCH 3/4] drm/virtio: track whether or not a context has been initiated

2020-02-12 Thread Gurchetan Singh
On Wed, Feb 12, 2020 at 10:50 AM Chia-I Wu wrote: > > On Tue, Feb 11, 2020 at 3:56 PM Gurchetan Singh > wrote: > > > > We only want create a new virglrenderer context after the first > > 3D ioctl. > > > > Signed-off-by: Gurchetan Singh > > --- > > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + >

Re: [PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

2020-02-12 Thread Bibby Hsieh
On Wed, 2020-02-12 at 18:48 +0800, CK Hu wrote: > On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote: > > In order to use GCE function, we need add some information > > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). > > > > Signed-off-by: Bibby Hsieh > >

[PATCH 2/2] drm/mediatek: add fb swap in async_update

2020-02-12 Thread Bibby Hsieh
Besides x, y position, width and height, fb also need updating in async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/2] drm/mediatek: add plane check in async_check function

2020-02-12 Thread Bibby Hsieh
MTK do rotation checking and transferring in layer check function, but we do not check that in atomic_check, so add back in atomic_check function. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Signed-off-by: Bibby Hsieh ---

[PATCH] drm/nouveau/kms/gv100-: Re-set LUT after clearing for modesets

2020-02-12 Thread Lyude Paul
While certain modeset operations on gv100+ need us to temporarily disable the LUT, we make the mistake of sometimes neglecting to reprogram the LUT after such modesets. In particular, moving a head from one encoder to another seems to trigger this quite often. GV100+ is very picky about having a

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-02-12 Thread Doug Anderson
Andrzej / Neil, On Mon, Feb 3, 2020 at 4:21 PM Doug Anderson wrote: > > Andrzej / Neil, > > On Mon, Feb 3, 2020 at 3:37 PM Bjorn Andersson > wrote: > > > > On Wed 18 Dec 14:35 PST 2019, Douglas Anderson wrote: > > > > > The current bridge driver always forced us to use 24 bits per pixel > > >

[PATCH 3/4] drm/nouveau/kms/nv50-: Move 8BPC limit for MST into nv50_mstc_get_modes()

2020-02-12 Thread Lyude Paul
This just limits the BPC for MST connectors to a maximum of 8 from nv50_mstc_get_modes(), instead of doing so during nv50_msto_atomic_check(). This doesn't introduce any functional changes yet (other then userspace now lying about the max bpc, but we can't support that yet anyway so meh). But,

[PATCH 2/4] drm/nouveau/kms/gv100-: Add support for interlaced modes

2020-02-12 Thread Lyude Paul
We advertise being able to set interlaced modes, so let's actually make sure to do that. Otherwise, we'll end up hanging the display engine due to trying to set a mode with timings adjusted for interlacing without telling the hardware it's actually an interlaced mode. Signed-off-by: Lyude Paul

[PATCH 1/4] drm/nouveau/kms/nv50-: Probe SOR caps for DP interlacing support

2020-02-12 Thread Lyude Paul
Right now, we make the mistake of allowing interlacing on all connectors. Nvidia hardware does not always support interlacing with DP though, so we need to make sure that we don't allow interlaced modes to be set in such situations as otherwise we'll end up accidentally hanging the display HW.

[PATCH 0/4] drm/nouveau: DP interlace fixes

2020-02-12 Thread Lyude Paul
Currently, nouveau doesn't actually bother to try probing whether or not it can actually handle interlaced modes over DisplayPort. As a result, on volta and later we'll end up trying to set an interlaced mode even when it's not supported and cause the front end for the display engine to hang. So,

[PATCH 4/4] drm/nouveau/kms/nv50-: Share DP SST mode_valid() handling with MST

2020-02-12 Thread Lyude Paul
Currently, the nv50_mstc_mode_valid() function is happy to take any and all modes, even the ones we can't actually support sometimes like interlaced modes. Luckily, the only difference between the mode validation that needs to be performed for MST vs. SST is that eventually we'll need to check

[pull] amdgpu 5.6 fixes

2020-02-12 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.6. The following changes since commit bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9: Linux 5.6-rc1 (2020-02-09 16:08:48 -0800) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.6-2020-02-12 for you to fetch

Re: [PATCH -next] drm/panfrost: Remove set but not used variable 'bo'

2020-02-12 Thread Rob Herring
On Mon, Feb 3, 2020 at 9:33 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup': > drivers/gpu/drm/panfrost/panfrost_job.c:278:31: warning: > variable 'bo' set but not used

Re: [PATCH] drm/panfrost: perfcnt: Reserve/use the AS attached to the perfcnt MMU context

2020-02-12 Thread Rob Herring
On Thu, Feb 6, 2020 at 8:13 AM Boris Brezillon wrote: > > We need to use the AS attached to the opened FD when dumping counters. > > Reported-by: Antonio Caggiano > Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces") > Cc: > Signed-off-by: Boris Brezillon > --- >

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: > > On 12/02/2020 16:33, Ville Syrjälä wrote: > > On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > >> On 12/02/2020 15:59, Jyri Sarha wrote: > >>> The old implementation of placing planes on the CRTC while configuring > >>> the planes

Re: LED backlight on Droid 4 and others

2020-02-12 Thread Pavel Machek
Hi! > > > It would be good to get LED backlight to work in clean way for 5.6 > > > kernel. > ... > > > [If you have an idea what else is needed, it would be welcome; it > > > works for me in development tree but not in tree I'd like to > > > upstream.] > > > > > > Lee, would you be willing to

[PATCH v2] drm/panfrost: Don't try to map on error faults

2020-02-12 Thread Rob Herring
From: Tomeu Vizoso If the exception type isn't a translation fault, don't try to map and instead go straight to a terminal fault. Otherwise, we can get flooded by kernel warnings and further faults. Signed-off-by: Tomeu Vizoso Signed-off-by: Rob Herring --- I rewrote this some simplifying

[PATCH] drm/qxl: replace zero-length array with flexible-array member

2020-02-12 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 12:53 PM Christian König wrote: > > Am 12.02.20 um 07:23 schrieb Pan, Xinhui: > > > >> 2020年2月11日 23:43,Christian König 写道: > >> > >> When non-imported BOs are resurrected for delayed delete we replace > >> the dma_resv object to allow for easy reclaiming of the

Re: [PATCH 3/4] drm/virtio: track whether or not a context has been initiated

2020-02-12 Thread Chia-I Wu
On Tue, Feb 11, 2020 at 3:56 PM Gurchetan Singh wrote: > > We only want create a new virglrenderer context after the first > 3D ioctl. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 5 + >

Re: [PATCH 2/4] drm/virtio: factor out context create cmd

2020-02-12 Thread Chia-I Wu
On Tue, Feb 11, 2020 at 3:56 PM Gurchetan Singh wrote: > > We currently do it when open the DRM fd, let's delay it. First step, > remove the hyercall from initialization. > > Signed-off-by: Gurchetan Singh > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 2 ++ >

Re: [PATCH v2] drm/virtio: rework batching

2020-02-12 Thread Chia-I Wu
On Wed, Feb 12, 2020 at 3:13 AM Gerd Hoffmann wrote: > > Drop the virtio_gpu_{disable,enable}_notify(). Add a new > virtio_gpu_notify() call instead, which must be called whenever > the driver wants make sure the host is notified needed. > > Drop notification from command submission. Add

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 16:33, Ville Syrjälä wrote: > On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: >> On 12/02/2020 15:59, Jyri Sarha wrote: >>> The old implementation of placing planes on the CRTC while configuring >>> the planes was naive and relied on the order in which the planes were >>>

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Rob Herring
On Wed, Feb 12, 2020 at 2:49 AM Nicolas Boichat wrote: > > +Viresh Kumar +Stephen Boyd for clock advice. > > On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat wrote: > > > > The Bifrost GPU on MT8183 uses 2 regulators (core and SRAM) for > > devfreq, and provides OPP table with 2 sets of voltages.

Re: [PATCH 0/2] drm/virtio: locking/reservation fixes

2020-02-12 Thread Chia-I Wu
The fixes look reasonable. Reviewed-by: Chia-I Wu On Tue, Feb 11, 2020 at 5:50 AM Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > drm/virtio: fix virtio_gpu_execbuffer_ioctl locking > drm/virtio: fix virtio_gpu_cursor_plane_update(). > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 20

Re: [PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Alex Deucher
On Wed, Feb 12, 2020 at 7:12 AM Christian König wrote: > > Am 12.02.20 um 13:07 schrieb Dan Carpenter: > > The copy_to_user() function returns the number of bytes remaining to be > > copied, but we want to return a negative error code to the user. > > > > Fixes: 030d5b97a54b ("drm/amdgpu: use

Re: [PATCH v2] drm/i915: Disable -Wtautological-constant-out-of-range-compare

2020-02-12 Thread Michel Dänzer
On 2020-02-12 6:07 p.m., Nathan Chancellor wrote: > On Wed, Feb 12, 2020 at 09:52:52AM +0100, Michel Dänzer wrote: >> On 2020-02-11 9:39 p.m., Nathan Chancellor wrote: >>> On Tue, Feb 11, 2020 at 10:41:48AM +0100, Michel Dänzer wrote: On 2020-02-11 7:13 a.m., Nathan Chancellor wrote: > A

Re: [PATCH v4] drm/scheduler: Avoid accessing freed bad job.

2020-02-12 Thread Andrey Grodzovsky
On 2/11/20 7:53 PM, Luben Tuikov wrote: On 2020-02-11 4:27 p.m., Andrey Grodzovsky wrote: On 2/11/20 10:55 AM, Andrey Grodzovsky wrote: On 2/10/20 4:50 PM, Luben Tuikov wrote: Hi Lucas, Thank you for bringing awareness of this issue, publicly. As soon as this patch showed up back in

Re: [PATCH v3 0/2] drm/modes: Apply video parameters with only reflect option

2020-02-12 Thread Stephan Gerhold
Hi Maxime, On Fri, Jan 17, 2020 at 07:51:00PM +0100, Maxime Ripard wrote: > On Fri, Jan 17, 2020 at 04:34:27PM +0100, Stephan Gerhold wrote: > > At the moment, video mode parameters like video=540x960,reflect_x, > > (without rotation set) are not taken into account when applying the > > mode in

Re: i2c: jz4780: silence log flood on txabrt

2020-02-12 Thread Wolfram Sang
Hi, > > Sorry, normally I don't do counter patches. Yet, this time I realized > > that it would be faster to actually do what I envisioned than to > > describe it in words. I hope you don't feel offended. > > No problem. I had thought a little about that myself, but did not > dare to solve more

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Ville Syrjälä
On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: > On 12/02/2020 15:59, Jyri Sarha wrote: > > The old implementation of placing planes on the CRTC while configuring > > the planes was naive and relied on the order in which the planes were > > configured, enabled, and disabled. The

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 15:59, Jyri Sarha wrote: > The old implementation of placing planes on the CRTC while configuring > the planes was naive and relied on the order in which the planes were > configured, enabled, and disabled. The situation where a plane's zpos > was changed on the fly was completely

[PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
The old implementation of placing planes on the CRTC while configuring the planes was naive and relied on the order in which the planes were configured, enabled, and disabled. The situation where a plane's zpos was changed on the fly was completely broken. The usual symptoms of this problem was

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 11/02/2020 17:41, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 04:40:21PM +0100, Daniel Vetter wrote: >> On Tue, Feb 11, 2020 at 03:00:30PM +0200, Ville Syrjälä wrote: >>> On Tue, Feb 11, 2020 at 11:11:34AM +0200, Tomi Valkeinen wrote: Hi Ville, On 10/02/2020 18:03, Ville

[PATCH] drm/bridge: adv7511: Replace hardcoded number

2020-02-12 Thread Fabio Estevam
The hardcoded '12' means the number of elements in the adv7511_csc_ycbcr_to_rgb[] array, so use the ARRAY_SIZE() macro to let the code less error prone. Signed-off-by: Fabio Estevam --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 16 1 file changed, 8 insertions(+), 8

Re: [PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Christian König
Am 12.02.20 um 13:07 schrieb Dan Carpenter: The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return a negative error code to the user. Fixes: 030d5b97a54b ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read") Signed-off-by: Dan

[PATCH] drm/amdgpu: return -EFAULT if copy_to_user() fails

2020-02-12 Thread Dan Carpenter
The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return a negative error code to the user. Fixes: 030d5b97a54b ("drm/amdgpu: use amdgpu_device_vram_access in amdgpu_ttm_vram_read") Signed-off-by: Dan Carpenter ---

Re: [PATCH] drm/ttm: replace dma_resv object on deleted BOs v3

2020-02-12 Thread Christian König
Am 12.02.20 um 07:23 schrieb Pan, Xinhui: 2020年2月11日 23:43,Christian König 写道: When non-imported BOs are resurrected for delayed delete we replace the dma_resv object to allow for easy reclaiming of the resources. v2: move that to ttm_bo_individualize_resv v3: add a comment to explain

Re: [PATCH v2 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Ramalingam C
On 2020-02-12 at 13:31:45 +0200, Jani Nikula wrote: > On Wed, 12 Feb 2020, Ramalingam C wrote: > > Converts remaining instances of the printk based logging macros in > > i915/display/intel_hdcp.c with the struct drm_device based macros > > manually. > > > > This is continuation of commit

Re: [PATCH v2 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Jani Nikula
On Wed, 12 Feb 2020, Ramalingam C wrote: > Converts remaining instances of the printk based logging macros in > i915/display/intel_hdcp.c with the struct drm_device based macros > manually. > > This is continuation of commit 65833c463886 ("drm/i915/hdcp: conversion > to struct drm_device based

[PATCH v2] drm/virtio: rework batching

2020-02-12 Thread Gerd Hoffmann
Drop the virtio_gpu_{disable,enable}_notify(). Add a new virtio_gpu_notify() call instead, which must be called whenever the driver wants make sure the host is notified needed. Drop notification from command submission. Add virtio_gpu_notify() calls everywhere instead. This results in more

Re: [PATCH 3/4] drm/virtio: track whether or not a context has been initiated

2020-02-12 Thread Gerd Hoffmann
Hi, > --- a/drivers/gpu/drm/virtio/virtgpu_kms.c > +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c > @@ -270,7 +270,9 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct > drm_file *file) > return id; > } > > + > vfpriv->ctx_id = id; checkpatch warning here:

Re: [PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

2020-02-12 Thread CK Hu
On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote: > In order to use GCE function, we need add some information > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). > > Signed-off-by: Bibby Hsieh > Signed-off-by: Yongqiang Niu > --- >

Re: [PATCH 2/2] drm/mediatek: move gce event property to mutex device node

2020-02-12 Thread CK Hu
Hi, Bibby: On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote: > According mtk hardware design, stream_done0 and stream_done1 are > generated by mutex, so we move gce event property to mutex device mode. > Reviewed-by: CK Hu > Signed-off-by: Bibby Hsieh > --- >

Re: [PATCH v4 3/7] drm/panfrost: Improve error reporting in panfrost_gpu_power_on

2020-02-12 Thread Matthias Brugger
On 07/02/2020 06:26, Nicolas Boichat wrote: > It is useful to know which component cannot be powered on. > > Signed-off-by: Nicolas Boichat > Reviewed-by: Steven Price > Reviewed-by: Alyssa Rosenzweig Reviewed-by: Matthias Brugger > --- > > Was useful when trying to probe Bifrost GPU,

[PATCH v2 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Ramalingam C
Converts remaining instances of the printk based logging macros in i915/display/intel_hdcp.c with the struct drm_device based macros manually. This is continuation of commit 65833c463886 ("drm/i915/hdcp: conversion to struct drm_device based logging macros.") v2: i915_dev_priv is used instead

[PATCH v2 2/5] drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS

2020-02-12 Thread Ramalingam C
Need to extract the 2 most significant bits from a byte for constructing the revoked KSV count of the SRM. Signed-off-by: Ramalingam C --- include/drm/drm_hdcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index

[PATCH v2 4/5] drm/i915: dont retry stream management at seq_num_m roll over

2020-02-12 Thread Ramalingam C
When roll over detected for seq_num_m, we shouldn't continue with stream management with rolled over value. So we are terminating the stream management retry, on roll over of the seq_num_m. v2: using drm_dbg_kms instead of DRM_DEBUG_KMS [Anshuman] v3: dev_priv is used as i915 [JaniN]

[PATCH v2 3/5] drm/i915: terminate reauth at stream management failure

2020-02-12 Thread Ramalingam C
As per the HDCP2.2 compliance test 1B-10 expectation, when stream management for a repeater fails, we retry thrice and when it fails in all retries, HDCP2.2 reauthentication aborted at kernel. v2: seq_num_m++ is extended for steam management failures too.[Anshuman] v3: use drm_dbg_kms instead

[PATCH v2 1/5] drm/hdcp: optimizing the srm handling

2020-02-12 Thread Ramalingam C
As we are not using the sysfs infrastructure anymore, link to it is removed. And global srm data and mutex to protect it are removed, with required handling at revocation check function. v2: srm_data is dropped and few more comments are addressed. v3: ptr passing around is fixed with

[PATCH v2 0/5] HDCP misc

2020-02-12 Thread Ramalingam C
Combined HDCP patches together. Few for DRM SRM handling and few more for hdcp2.2 compliance fix at I915. v2: minor changes in i915 related 3 patches. Ramalingam C (5): drm/hdcp: optimizing the srm handling drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS drm/i915: terminate reauth at stream

Re: [PATCH 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Ramalingam C
On 2020-02-12 at 12:01:08 +0200, Jani Nikula wrote: > On Wed, 12 Feb 2020, Ramalingam C wrote: > > Converts remaining instances of the printk based logging macros in > > i915/display/intel_hdcp.c with the struct drm_device based macros > > manually. > > > > This is continuation of commit

Re: [PATCH 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Jani Nikula
On Wed, 12 Feb 2020, Ramalingam C wrote: > Converts remaining instances of the printk based logging macros in > i915/display/intel_hdcp.c with the struct drm_device based macros > manually. > > This is continuation of commit 65833c463886 ("drm/i915/hdcp: conversion > to struct drm_device based

[PATCH 2/2] drm/mediatek: move gce event property to mutex device node

2020-02-12 Thread Bibby Hsieh
According mtk hardware design, stream_done0 and stream_done1 are generated by mutex, so we move gce event property to mutex device mode. Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

2020-02-12 Thread Bibby Hsieh
In order to use GCE function, we need add some information into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events). Signed-off-by: Bibby Hsieh Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 1 file changed, 16 insertions(+)

i2c: jz4780: silence log flood on txabrt

2020-02-12 Thread Wolfram Sang
The printout for txabrt is way too talkative. Reduce it to the minimum, the rest can be gained by I2C core debugging and datasheet information. Also, make it a debug printout, it won't help the regular user. Reported-by: H. Nikolaus Schaller Signed-off-by: Wolfram Sang --- Sorry, normally I

[PATCH 3/5] drm/i915: terminate reauth at stream management failure

2020-02-12 Thread Ramalingam C
As per the HDCP2.2 compliance test 1B-10 expectation, when stream management for a repeater fails, we retry thrice and when it fails in all retries, HDCP2.2 reauthentication aborted at kernel. v2: seq_num_m++ is extended for steam management failures too.[Anshuman] v3: use drm_dbg_kms instead

[PATCH 4/5] drm/i915: dont retry stream management at seq_num_m roll over

2020-02-12 Thread Ramalingam C
When roll over detected for seq_num_m, we shouldn't continue with stream management with rolled over value. So we are terminating the stream management retry, on roll over of the seq_num_m. v2: using drm_dbg_kms instead of DRM_DEBUG_KMS [Anshuman] Signed-off-by: Ramalingam C ---

[PATCH 5/5] drm/i915/hdcp: conversion to struct drm_device based logging macros.

2020-02-12 Thread Ramalingam C
Converts remaining instances of the printk based logging macros in i915/display/intel_hdcp.c with the struct drm_device based macros manually. This is continuation of commit 65833c463886 ("drm/i915/hdcp: conversion to struct drm_device based logging macros.") Signed-off-by: Ramalingam C cc:

Re: [PATCH v4] drm/virtio: add drm_driver.release callback.

2020-02-12 Thread Gerd Hoffmann
On Tue, Feb 11, 2020 at 03:27:11PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 02:58:04PM +0100, Gerd Hoffmann wrote: > > Split virtio_gpu_deinit(), move the drm shutdown and release to > > virtio_gpu_release(). Drop vqs_ready variable, instead use > > drm_dev_{enter,exit,unplug} to

[PATCH 2/5] drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS

2020-02-12 Thread Ramalingam C
Need to extract the 2 most significant bits from a byte for constructing the revoked KSV count of the SRM. Signed-off-by: Ramalingam C --- include/drm/drm_hdcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index

[PATCH 1/5] drm/hdcp: optimizing the srm handling

2020-02-12 Thread Ramalingam C
As we are not using the sysfs infrastructure anymore, link to it is removed. And global srm data and mutex to protect it are removed, with required handling at revocation check function. v2: srm_data is dropped and few more comments are addressed. v3: ptr passing around is fixed with

[PATCH 0/5] HDCP misc

2020-02-12 Thread Ramalingam C
Combined HDCP patches together. Few for DRM SRM handling and few more for hdcp2.2 compliance fix at I915. Ramalingam C (5): drm/hdcp: optimizing the srm handling drm/hdcp: fix DRM_HDCP_2_KSV_COUNT_2_LSBITS drm/i915: terminate reauth at stream management failure drm/i915: dont retry stream

Re: [PATCH v4] drm/bochs: add drm_driver.release callback.

2020-02-12 Thread Gerd Hoffmann
On Tue, Feb 11, 2020 at 03:19:56PM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 02:52:18PM +0100, Gerd Hoffmann wrote: > > Call bochs_unload via drm_driver.release to make sure we release stuff > > when it is safe to do so. Use drm_dev_{enter,exit,unplug} to avoid > > touching hardware

Re: [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-02-12 Thread Daniel Vetter
On Wed, Feb 12, 2020 at 10:07:55AM +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 07:14:51PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > > > On Tue, Feb 11, 2020 at 06:22:08PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

Re: [PATCH v3 7/7] drm: Allow drivers to leave encoder->possible_crtcs==0

2020-02-12 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 07:14:51PM +0200, Ville Syrjälä wrote: > On Tue, Feb 11, 2020 at 06:05:45PM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 06:22:08PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Let's simplify life of driver by allowing them to leave > > >

Re: [PATCH v3 5/7] drm: Validate encoder->possible_clones

2020-02-12 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 07:13:31PM +0200, Ville Syrjälä wrote: > On Tue, Feb 11, 2020 at 06:02:33PM +0100, Daniel Vetter wrote: > > On Tue, Feb 11, 2020 at 06:22:06PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Many drivers are populating encoder->possible_clones wrong.

Re: [PATCH v2] drm/i915: Disable -Wtautological-constant-out-of-range-compare

2020-02-12 Thread Michel Dänzer
On 2020-02-11 9:39 p.m., Nathan Chancellor wrote: > On Tue, Feb 11, 2020 at 10:41:48AM +0100, Michel Dänzer wrote: >> On 2020-02-11 7:13 a.m., Nathan Chancellor wrote: >>> A recent commit in clang added -Wtautological-compare to -Wall, which is >>> enabled for i915 so we see the following warning:

Re: [PATCH v4 7/7] RFC: drm/panfrost: devfreq: Add support for 2 regulators

2020-02-12 Thread Nicolas Boichat
+Viresh Kumar +Stephen Boyd for clock advice. On Fri, Feb 7, 2020 at 1:27 PM Nicolas Boichat wrote: > > The Bifrost GPU on MT8183 uses 2 regulators (core and SRAM) for > devfreq, and provides OPP table with 2 sets of voltages. > > TODO: This is incomplete as we'll need add support for setting >

Re: [Letux-kernel] [PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600

2020-02-12 Thread Andreas Kemnade
On Tue, 11 Feb 2020 22:41:24 +0100 "H. Nikolaus Schaller" wrote: > There is a ACT8600 on the CI20 board and the bindings of the > ACT8865 driver have changed without updating the CI20 device > tree. Therefore the PMU can not be probed successfully and > is running in power-on reset state. > >

[PATCH 06/14] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers

2020-02-12 Thread H. Nikolaus Schaller
DTS has been augmented to add some gpio-leds. We need the leds-gpio driver and enable the triggers. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig

[PATCH 12/14] MIPS: DTS: CI20: add DT node for SW1 as Enter button

2020-02-12 Thread H. Nikolaus Schaller
The SW1 button can be used as a simple one-button keyboard and is connected to PD17. Note: SW1 has a second meaning to change the boot sequence when pressed while powering on. Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/ci20.dts | 12 1 file changed, 12

[v2] arm64: dts: sc7180: add dsi controller and phy entries for idp dts

2020-02-12 Thread Harigovindan P
Adding dsi controller and phy entries for idp dt. Signed-off-by: Harigovindan P --- Changes in v1: - Added dsi controller and dsi phy entries for idp dts Changes in v2: - Adding dependency patchwork series - Removing suspend configuration - Adding blank before

[PATCH 10/14] MIPS: DTS: CI20: add DT node for IR sensor

2020-02-12 Thread H. Nikolaus Schaller
From: Alex Smith The infrared sensor on the CI20 board is connected to a GPIO and can be operated by using the gpio-ir-recv driver. Add a DT node for the sensor to allow that driver to be used. Signed-off-by: Alex Smith Signed-off-by: H. Nikolaus Schaller ---

[PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600

2020-02-12 Thread H. Nikolaus Schaller
There is a ACT8600 on the CI20 board and the bindings of the ACT8865 driver have changed without updating the CI20 device tree. Therefore the PMU can not be probed successfully and is running in power-on reset state. Fix DT to match the latest act8865-regulator bindings. Signed-off-by: H.

[PATCH v5 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-02-12 Thread Yuti Amonkar
This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards. It integrates uCPU running the embedded Firmware(FW) interfaced over APB interface. Basically, it takes a DPI

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-12 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > > > On Fri, Feb 7,

build error: f7655d42fcee drm/edid: Add CTA-861-G modes with VIC >= 193

2020-02-12 Thread Frank Rowand
I am getting a kernel build error at version 5.6-rc1: drivers/gpu/drm/drm_edid.c: In function 'cea_mode_alternate_timings': drivers/gpu/drm/drm_edid.c:3275:2: error: call to '__compiletime_assert_3282' declared with attribute error: BUILD_BUG_ON failed: cea_mode_for_vic(8)->vtotal != 262 ||

[PATCH 01/14] i2c: jz4780: suppress txabrt reports for i2cdetect

2020-02-12 Thread H. Nikolaus Schaller
This suppresses "simple" error reasons ABRT_7B_ADDR_NOACK ABRT_10ADDR1_NOACK ABRT_10ADDR2_NOACK from flooding the console log when running i2cdetect on addresses without a responding slave. Additionally, reading the JZ4780_I2C_TAR in this situation seems to harm the

Re: build error: f7655d42fcee drm/edid: Add CTA-861-G modes with VIC >= 193

2020-02-12 Thread Frank Rowand
On 2/11/20 12:48 PM, Frank Rowand wrote: > I am getting a kernel build error at version 5.6-rc1: > > drivers/gpu/drm/drm_edid.c: In function 'cea_mode_alternate_timings': > drivers/gpu/drm/drm_edid.c:3275:2: error: call to '__compiletime_assert_3282' > declared with attribute error: BUILD_BUG_ON

[PATCH 13/14] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m

2020-02-12 Thread H. Nikolaus Schaller
The SW1 button is hooked up to send input events. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index 0458ea4d54e8..0db0088bbc1c 100644 ---

[PATCH v5 3/3] drm: bridge: cdns-mhdp: add j721e wrapper

2020-02-12 Thread Yuti Amonkar
Add j721e wrapper for mhdp, which sets up the clock and data muxes. Signed-off-by: Yuti Amonkar Signed-off-by: Jyri Sarha --- drivers/gpu/drm/bridge/Kconfig | 12 drivers/gpu/drm/bridge/Makefile | 3 + drivers/gpu/drm/bridge/cdns-mhdp-core.c | 14 +

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-12 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > > >> > > >> On 2020-02-06 20:29, Jeffrey Hugo wrote: > > >> > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P

[PATCH v5 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-02-12 Thread Yuti Amonkar
This patch series adds new DRM driver for Cadence Display Port. The Cadence Display Port is also referred as MHDP (Mobile High Definition Link, High-Definition Multimedia Interface Display Port) Cadence Display Port complies with VESA DisplayPort (DP) and embedded Display Port (eDP) standards.

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-12 Thread Tony Lindgren
* Tomi Valkeinen [200211 16:14]: > On 11/02/2020 18:05, Tony Lindgren wrote: > > * Merlijn Wajer [200211 12:54]: > > > Hi, > > > > > > On 11/02/2020 12:08, Tomi Valkeinen wrote: > > > > On 11/02/2020 13:07, Laurent Pinchart wrote: > > > > > > > > > > Hopefully soon (in five years? =) we can

Re: [PATCH 1/1] Support LVDS output on Allwinner A20

2020-02-12 Thread Andrey Lebedev
Maxime, thanks for your comments. I'll update the patch, but meanwhile, I have some remarks/questions, see below. On Tue, Feb 11, 2020 at 08:20:04AM +0100, Maxime Ripard wrote: > > + regmap_update_bits(tcon->regs, SUN4I_TCON0_LVDS_ANA1_REG, > > +

[PATCH 00/14] MIPS: Fixes and improvements for CI20 board (JZ4780)

2020-02-12 Thread H. Nikolaus Schaller
This patch set provides several improvements for the CI20 board: * suppress warnings from i2c if device is not responding * make ingenic-drm found through DT * allow davicom dm9000 ethernet controller to use MAC address provided by U-Boot * fix #include in jz4780.dtsi * configure for loadable

[PATCH 02/14] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-02-12 Thread H. Nikolaus Schaller
Add MODULE_DEVICE_TABLE so that the driver can load by matching the device tree if compiled as module. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-12 Thread Tony Lindgren
* Merlijn Wajer [200211 12:54]: > Hi, > > On 11/02/2020 12:08, Tomi Valkeinen wrote: > > On 11/02/2020 13:07, Laurent Pinchart wrote: > > > >>> Hopefully soon (in five years? =) we can say that omapdrm supports all > >>> the boards, and we can deprecate omapfb. > >> > >> I'd love to send a

[PATCH 11/14] MIPS: CI20: defconfig: compile gpio-ir driver

2020-02-12 Thread H. Nikolaus Schaller
The CI20 board has a gpio based IR receiver. Signed-off-by: H. Nikolaus Schaller --- arch/mips/configs/ci20_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index 74e5775b8a05..0458ea4d54e8 100644 ---

[PATCH 04/14] MIPS: DTS: jz4780: fix #includes for irq.h and gpio.h

2020-02-12 Thread H. Nikolaus Schaller
The constants from irq.h and gpio.h can be used in the jz4780.dtsi and derived DTS like ci20.dts. Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi

  1   2   >