Re: [PATCH 33/44] drm/mcde: Don't use drm_device->dev_private

2020-04-11 Thread Linus Walleij
On Fri, Apr 3, 2020 at 3:59 PM Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Linus Walleij Nice, thanks! Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh

2020-04-11 Thread Linus Walleij
On Fri, Apr 3, 2020 at 10:41 PM Ville Syrjala wrote: > From: Ville Syrjälä > > htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it. > > Cc: Linus Walleij > Cc: Sam Ravnborg > Signed-off-by: Ville Syrjälä Indeed :) Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH AUTOSEL 4.4 09/16] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 4.9 08/26] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 4.9 15/26] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 4.14 21/37] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 4.19 33/66] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 4.19 39/66] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

[PATCH AUTOSEL 4.14 12/37] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 4.19 48/66] drm/msm/a5xx: Always set an OPP supported hardware value

2020-04-11 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 4.19 47/66] drm/msm: fix leaks if initialization fails

2020-04-11 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 4.19 66/66] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-04-11 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 4.19 36/66] drm/stm: ltdc: check crtc state before enabling LIE

2020-04-11 Thread Sasha Levin
From: Yannick Fertre [ Upstream commit a6bd58c51ac43083f3977057a7ad668def55812f ] Following investigations of a hardware bug, the LIE interrupt can occur while the display controller is not activated. LIE interrupt (vblank) don't have to be set if the CRTC is not enabled. Signed-off-by:

[PATCH AUTOSEL 4.19 30/66] drm/sun4i: dsi: Use NULL to signify "no panel"

2020-04-11 Thread Sasha Levin
From: Samuel Holland [ Upstream commit 0e4e3fb4901d19f49e5c0a582f383b10dda8d1c5 ] The continued use of an ERR_PTR to signify "no panel" outside of sun6i_dsi_attach is confusing because it is a double negative. Because the connector always reports itself as connected, there is also the

[PATCH AUTOSEL 4.19 20/66] drm/amd/display: Fix default logger mask definition

2020-04-11 Thread Sasha Levin
From: Eric Bernstein [ Upstream commit ccb6af1e25830e5601b6beacc698390f0245316f ] [Why] Logger mask was updated to uint64_t, however default mask definition was not updated for unsigned long long [How] Update DC_DEFAULT_LOG_MASK to support uint64_t type Signed-off-by: Eric Bernstein

[PATCH AUTOSEL 4.19 17/66] drm/amd/display: writing stereo polarity register if swapped

2020-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit e592e85f3378246dd66b861fa60ef803d8cece6b ] [why] on some displays that prefer swapped polarity we were seeing L/R images swapped because OTG_STEREO_SYNC_OUTPUT_POLARITY would always be mapped to 0 [how] fix initial dal3 implementation to properly update the

[PATCH AUTOSEL 4.19 15/66] drm/amd/display: Stop if retimer is not available

2020-04-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit a0e40018dcc3f59a10ca21d58f8ea8ceb1b035ac ] Raven provides retimer feature support that requires i2c interaction in order to make it work well, all settings required for this configuration are loaded from the Atom bios which include the i2c address. If

[PATCH AUTOSEL 5.4 108/108] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-04-11 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 4.19 14/66] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 5.4 051/108] drm/stm: ltdc: check crtc state before enabling LIE

2020-04-11 Thread Sasha Levin
From: Yannick Fertre [ Upstream commit a6bd58c51ac43083f3977057a7ad668def55812f ] Following investigations of a hardware bug, the LIE interrupt can occur while the display controller is not activated. LIE interrupt (vblank) don't have to be set if the CRTC is not enabled. Signed-off-by:

[PATCH AUTOSEL 5.4 074/108] drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers

2020-04-11 Thread Sasha Levin
From: Rob Clark [ Upstream commit e515af8d4a6f18f96c360724568a7497868101a8 ] Also log buffers with the DUMP flag set, to ensure we capture all useful cmdstream in crashdump state with modern mesa. Otherwise we miss out on the contents of "state object" cmdstream buffers. v2: add missing

[PATCH AUTOSEL 5.4 054/108] drm/amdgpu: fix parentheses in amdgpu_vm_update_ptes

2020-04-11 Thread Sasha Levin
From: Christian König [ Upstream commit bfcd6c69e4c3f73f2f92b997983537f9a3ac3b29 ] For the root PD mask can be 0x as well which would overrun to 0 if we don't cast it before we add one. Signed-off-by: Christian König Tested-by: Tom St Denis Reviewed-by: Felix Kuehling Signed-off-by:

[PATCH AUTOSEL 5.4 073/108] drm/msm/a5xx: Always set an OPP supported hardware value

2020-04-11 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 5.4 062/108] drm/amd/display: System crashes when add_ptb_to_table() gets called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 0062972b9d9f888d0273c6496769d02e8f509135 ] [Why] Unused VMIDs were not evicted correctly [How] 1. evict_vmids() logic was fixed; 2. Added boundary check for add_ptb_to_table() and clear_entry_from_vmid_table() to avoid crash caused by array out of

[PATCH AUTOSEL 5.4 055/108] drm/amd/display: dc_get_vmid_use_vector() crashes when get called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 68bbca15e7062f4ae16531e29893f78d0b4840b6 ] [Why] int i can go out of boundary which will cause crash [How] Fixed the maximum value of i to avoid i going out of boundary Signed-off-by: Peikang Zhang Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha

[PATCH AUTOSEL 5.4 052/108] fbdev: potential information leak in do_fb_ioctl()

2020-04-11 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit d3d19d6fc5736a798b118971935ce274f7deaa82 ] The "fix" struct has a 2 byte hole after ->ywrapstep and the "fix = info->fix;" assignment doesn't necessarily clear it. It depends on the compiler. The solution is just to replace the assignment with an

[PATCH AUTOSEL 5.4 053/108] drm/crc: Actually allow to change the crc source

2020-04-11 Thread Sasha Levin
From: Daniel Vetter [ Upstream commit 3cb6d8e5cf9811a62e27f366fd1c05f90310a8fd ] Oops. Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs") Cc: Tomeu Vizoso Cc: Emil Velikov Cc: Benjamin Gaignard Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä Link:

[PATCH AUTOSEL 5.4 063/108] drm/omap: dss: Cleanup DSS ports on initialisation failure

2020-04-11 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 2a0a3ae17d36fa86dcf7c8e8d7b7f056ebd6c064 ] When the DSS initialises its output DPI and SDI ports, failures don't clean up previous successfully initialised ports. This can lead to resource leak or memory corruption. Fix it. Reported-by: Hans Verkuil

[PATCH AUTOSEL 5.4 061/108] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

[PATCH AUTOSEL 5.4 072/108] drm/msm: fix leaks if initialization fails

2020-04-11 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 5.4 048/108] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 5.4 042/108] drm/sun4i: dsi: Use NULL to signify "no panel"

2020-04-11 Thread Sasha Levin
From: Samuel Holland [ Upstream commit 0e4e3fb4901d19f49e5c0a582f383b10dda8d1c5 ] The continued use of an ERR_PTR to signify "no panel" outside of sun6i_dsi_attach is confusing because it is a double negative. Because the connector always reports itself as connected, there is also the

[PATCH AUTOSEL 5.4 029/108] drm/amd/display: Fix default logger mask definition

2020-04-11 Thread Sasha Levin
From: Eric Bernstein [ Upstream commit ccb6af1e25830e5601b6beacc698390f0245316f ] [Why] Logger mask was updated to uint64_t, however default mask definition was not updated for unsigned long long [How] Update DC_DEFAULT_LOG_MASK to support uint64_t type Signed-off-by: Eric Bernstein

[PATCH AUTOSEL 5.4 032/108] drm/amd/display: Only round InfoFrame refresh rates

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 3fc6376ed6f2f67bc9fb0c7a3cf07967d6aa6216 ] [Why] When calculating nominal refresh rates, don't round. Only the VSIF needs to be rounded. [How] Revert rounding change for nominal and just round when forming the FreeSync VSIF. Signed-off-by: Aric Cyr

[PATCH AUTOSEL 5.4 026/108] drm/amd/display: writing stereo polarity register if swapped

2020-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit e592e85f3378246dd66b861fa60ef803d8cece6b ] [why] on some displays that prefer swapped polarity we were seeing L/R images swapped because OTG_STEREO_SYNC_OUTPUT_POLARITY would always be mapped to 0 [how] fix initial dal3 implementation to properly update the

[PATCH AUTOSEL 5.5 121/121] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-04-11 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 5.4 012/108] drm/amd/display: Explicitly disable triplebuffer flips

2020-04-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 2d673560b7b83f8fe4163610f35c51b4d095525c ] [Why] This is enabled by default on Renoir but there's userspace/API support to actually make use of this. Since we're not passing this down through surface updates, let's explicitly disable this for now.

[PATCH AUTOSEL 5.4 024/108] drm/amd/display: Stop if retimer is not available

2020-04-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit a0e40018dcc3f59a10ca21d58f8ea8ceb1b035ac ] Raven provides retimer feature support that requires i2c interaction in order to make it work well, all settings required for this configuration are loaded from the Atom bios which include the i2c address. If

[PATCH AUTOSEL 5.4 022/108] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 5.5 085/121] drm/msm/a5xx: Always set an OPP supported hardware value

2020-04-11 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 5.5 084/121] drm/msm: fix leaks if initialization fails

2020-04-11 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 5.5 069/121] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

[PATCH AUTOSEL 5.5 062/121] drm/amdgpu: fix parentheses in amdgpu_vm_update_ptes

2020-04-11 Thread Sasha Levin
From: Christian König [ Upstream commit bfcd6c69e4c3f73f2f92b997983537f9a3ac3b29 ] For the root PD mask can be 0x as well which would overrun to 0 if we don't cast it before we add one. Signed-off-by: Christian König Tested-by: Tom St Denis Reviewed-by: Felix Kuehling Signed-off-by:

[PATCH AUTOSEL 5.5 070/121] drm/amd/display: System crashes when add_ptb_to_table() gets called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 0062972b9d9f888d0273c6496769d02e8f509135 ] [Why] Unused VMIDs were not evicted correctly [How] 1. evict_vmids() logic was fixed; 2. Added boundary check for add_ptb_to_table() and clear_entry_from_vmid_table() to avoid crash caused by array out of

[PATCH AUTOSEL 5.5 059/121] drm/stm: ltdc: check crtc state before enabling LIE

2020-04-11 Thread Sasha Levin
From: Yannick Fertre [ Upstream commit a6bd58c51ac43083f3977057a7ad668def55812f ] Following investigations of a hardware bug, the LIE interrupt can occur while the display controller is not activated. LIE interrupt (vblank) don't have to be set if the CRTC is not enabled. Signed-off-by:

[PATCH AUTOSEL 5.5 063/121] drm/amd/display: dc_get_vmid_use_vector() crashes when get called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 68bbca15e7062f4ae16531e29893f78d0b4840b6 ] [Why] int i can go out of boundary which will cause crash [How] Fixed the maximum value of i to avoid i going out of boundary Signed-off-by: Peikang Zhang Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha

[PATCH AUTOSEL 5.5 033/121] drm/amd/display: Fix default logger mask definition

2020-04-11 Thread Sasha Levin
From: Eric Bernstein [ Upstream commit ccb6af1e25830e5601b6beacc698390f0245316f ] [Why] Logger mask was updated to uint64_t, however default mask definition was not updated for unsigned long long [How] Update DC_DEFAULT_LOG_MASK to support uint64_t type Signed-off-by: Eric Bernstein

[PATCH AUTOSEL 5.5 037/121] drm/amd/display: Only round InfoFrame refresh rates

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 3fc6376ed6f2f67bc9fb0c7a3cf07967d6aa6216 ] [Why] When calculating nominal refresh rates, don't round. Only the VSIF needs to be rounded. [How] Revert rounding change for nominal and just round when forming the FreeSync VSIF. Signed-off-by: Aric Cyr

[PATCH AUTOSEL 5.5 048/121] drm/sun4i: dsi: Use NULL to signify "no panel"

2020-04-11 Thread Sasha Levin
From: Samuel Holland [ Upstream commit 0e4e3fb4901d19f49e5c0a582f383b10dda8d1c5 ] The continued use of an ERR_PTR to signify "no panel" outside of sun6i_dsi_attach is confusing because it is a double negative. Because the connector always reports itself as connected, there is also the

[PATCH AUTOSEL 5.5 060/121] fbdev: potential information leak in do_fb_ioctl()

2020-04-11 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit d3d19d6fc5736a798b118971935ce274f7deaa82 ] The "fix" struct has a 2 byte hole after ->ywrapstep and the "fix = info->fix;" assignment doesn't necessarily clear it. It depends on the compiler. The solution is just to replace the assignment with an

[PATCH AUTOSEL 5.5 056/121] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 5.5 061/121] drm/crc: Actually allow to change the crc source

2020-04-11 Thread Sasha Levin
From: Daniel Vetter [ Upstream commit 3cb6d8e5cf9811a62e27f366fd1c05f90310a8fd ] Oops. Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs") Cc: Tomeu Vizoso Cc: Emil Velikov Cc: Benjamin Gaignard Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä Link:

[PATCH AUTOSEL 5.5 039/121] drm/panel: simple: fix osd070t1718_19ts sync drive edge

2020-04-11 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit fb0629db6622c16da1aa76a4520daf9a46e2 ] The panel datasheet says that the panel samples at falling edge, but does not say anything about h/v sync signals. Testing shows that if the sync signals are driven on falling edge, the picture on the panel will

[PATCH AUTOSEL 5.5 071/121] drm/omap: dss: Cleanup DSS ports on initialisation failure

2020-04-11 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 2a0a3ae17d36fa86dcf7c8e8d7b7f056ebd6c064 ] When the DSS initialises its output DPI and SDI ports, failures don't clean up previous successfully initialised ports. This can lead to resource leak or memory corruption. Fix it. Reported-by: Hans Verkuil

[PATCH AUTOSEL 5.5 028/121] drm/amd/display: Stop if retimer is not available

2020-04-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit a0e40018dcc3f59a10ca21d58f8ea8ceb1b035ac ] Raven provides retimer feature support that requires i2c interaction in order to make it work well, all settings required for this configuration are loaded from the Atom bios which include the i2c address. If

[PATCH AUTOSEL 5.5 026/121] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 5.5 030/121] drm/amd/display: writing stereo polarity register if swapped

2020-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit e592e85f3378246dd66b861fa60ef803d8cece6b ] [why] on some displays that prefer swapped polarity we were seeing L/R images swapped because OTG_STEREO_SYNC_OUTPUT_POLARITY would always be mapped to 0 [how] fix initial dal3 implementation to properly update the

[PATCH AUTOSEL 5.5 013/121] drm/amd/display: Explicitly disable triplebuffer flips

2020-04-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 2d673560b7b83f8fe4163610f35c51b4d095525c ] [Why] This is enabled by default on Renoir but there's userspace/API support to actually make use of this. Since we're not passing this down through surface updates, let's explicitly disable this for now.

[PATCH AUTOSEL 5.6 149/149] PCI: Use ioremap(), not phys_to_virt() for platform ROM

2020-04-11 Thread Sasha Levin
From: Mikel Rychliski [ Upstream commit 72e0ef0e5f067fd991f702f0b2635d911d0cf208 ] On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using

[PATCH AUTOSEL 5.6 105/149] drm/msm: fix leaks if initialization fails

2020-04-11 Thread Sasha Levin
From: Pavel Machek [ Upstream commit 66be340f827554cb1c8a1ed7dea97920b4085af2 ] We should free resources in unlikely case of allocation failure. Signed-off-by: Pavel Machek Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_drv.c | 6 -- 1 file changed, 4

[PATCH AUTOSEL 5.6 090/149] drm/amdkfd: Fix a memory leak in queue creation error handling

2020-04-11 Thread Sasha Levin
From: Yong Zhao [ Upstream commit 66f28b9a169855367d6e3ef71001969a8bffb19b ] When the queue creation failed, some resources were not freed. Fix it. Signed-off-by: Yong Zhao Acked-by: Alex Deucher Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 106/149] drm/msm/a5xx: Always set an OPP supported hardware value

2020-04-11 Thread Sasha Levin
From: Jordan Crouse [ Upstream commit 0478b4fc5f37f4d494245fe7bcce3f531cf380e9 ] If the opp table specifies opp-supported-hw as a property but the driver has not set a supported hardware value the OPP subsystem will reject all the table entries. Set a "default" value that will match the

[PATCH AUTOSEL 5.6 089/149] drm/omap: dss: Cleanup DSS ports on initialisation failure

2020-04-11 Thread Sasha Levin
From: Laurent Pinchart [ Upstream commit 2a0a3ae17d36fa86dcf7c8e8d7b7f056ebd6c064 ] When the DSS initialises its output DPI and SDI ports, failures don't clean up previous successfully initialised ports. This can lead to resource leak or memory corruption. Fix it. Reported-by: Hans Verkuil

[PATCH AUTOSEL 5.6 095/149] drm/amd/display: Fix dmub_psr_destroy()

2020-04-11 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit e599f01f44a77578c43530b027886933d9d2bb5b ] This is freeing the wrong variable so it will crash. It should be freeing "*dmub" instead of "dmub". Fixes: 4c1a1335dfe0 ("drm/amd/display: Driverside changes to support PSR in DMCUB") Reviewed-by: Nicholas

[PATCH AUTOSEL 5.6 088/149] drm/amd/display: System crashes when add_ptb_to_table() gets called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 0062972b9d9f888d0273c6496769d02e8f509135 ] [Why] Unused VMIDs were not evicted correctly [How] 1. evict_vmids() logic was fixed; 2. Added boundary check for add_ptb_to_table() and clear_entry_from_vmid_table() to avoid crash caused by array out of

[PATCH AUTOSEL 5.6 076/149] drm/amd/display: dc_get_vmid_use_vector() crashes when get called

2020-04-11 Thread Sasha Levin
From: Peikang Zhang [ Upstream commit 68bbca15e7062f4ae16531e29893f78d0b4840b6 ] [Why] int i can go out of boundary which will cause crash [How] Fixed the maximum value of i to avoid i going out of boundary Signed-off-by: Peikang Zhang Reviewed-by: Jun Lei Acked-by: Bhawanpreet Lakha

[PATCH AUTOSEL 5.6 047/149] drm/amd/display: Fix HDMI repeater authentication

2020-04-11 Thread Sasha Levin
From: Bhawanpreet Lakha [ Upstream commit 63a85ff6c35d8a7aaf0fb60ddbab93530d495bf3 ] when the rxstatus split was done the index was incorrect. This lead to HDMI repeater authentication failure for HDCP2.X So fix it Fixes: 302169003733 ("drm/amd/display: split rxstatus for hdmi and dp")

[PATCH AUTOSEL 5.6 049/149] drm/panel: simple: fix osd070t1718_19ts sync drive edge

2020-04-11 Thread Sasha Levin
From: Tomi Valkeinen [ Upstream commit fb0629db6622c16da1aa76a4520daf9a46e2 ] The panel datasheet says that the panel samples at falling edge, but does not say anything about h/v sync signals. Testing shows that if the sync signals are driven on falling edge, the picture on the panel will

[PATCH AUTOSEL 5.6 074/149] drm/crc: Actually allow to change the crc source

2020-04-11 Thread Sasha Levin
From: Daniel Vetter [ Upstream commit 3cb6d8e5cf9811a62e27f366fd1c05f90310a8fd ] Oops. Fixes: 9edbf1fa600a ("drm: Add API for capturing frame CRCs") Cc: Tomeu Vizoso Cc: Emil Velikov Cc: Benjamin Gaignard Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä Link:

[PATCH AUTOSEL 5.6 075/149] drm/amdgpu: fix parentheses in amdgpu_vm_update_ptes

2020-04-11 Thread Sasha Levin
From: Christian König [ Upstream commit bfcd6c69e4c3f73f2f92b997983537f9a3ac3b29 ] For the root PD mask can be 0x as well which would overrun to 0 if we don't cast it before we add one. Signed-off-by: Christian König Tested-by: Tom St Denis Reviewed-by: Felix Kuehling Signed-off-by:

[PATCH AUTOSEL 5.6 046/149] drm/amd/display: Only round InfoFrame refresh rates

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 3fc6376ed6f2f67bc9fb0c7a3cf07967d6aa6216 ] [Why] When calculating nominal refresh rates, don't round. Only the VSIF needs to be rounded. [How] Revert rounding change for nominal and just round when forming the FreeSync VSIF. Signed-off-by: Aric Cyr

[PATCH AUTOSEL 5.6 087/149] drm/amd/display: dal_ddc_i2c_payloads_create can fail causing panic

2020-04-11 Thread Sasha Levin
From: Aric Cyr [ Upstream commit 6a6c4a4d459ecacc9013c45dcbf2bc9747fdbdbd ] [Why] Since the i2c payload allocation can fail need to check return codes [How] Clean up i2c payload allocations and check for errors Signed-off-by: Aric Cyr Reviewed-by: Joshua Aberback Acked-by: Rodrigo Siqueira

[PATCH AUTOSEL 5.6 065/149] drm/amdgpu: Fix missing error check in suspend

2020-04-11 Thread Sasha Levin
From: Rajneesh Bhardwaj [ Upstream commit 70bedd68e7b3a7f1d7f3198bb698fc23bc5aaa68 ] amdgpu_device_suspend might return an error code since it can be called from both runtime and system suspend flows. Add the missing return code in case of a failure. Reviewed-by: Oak Zeng Reviewed-by: Felix

[PATCH AUTOSEL 5.6 033/149] drm/amd/display: Stop if retimer is not available

2020-04-11 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit a0e40018dcc3f59a10ca21d58f8ea8ceb1b035ac ] Raven provides retimer feature support that requires i2c interaction in order to make it work well, all settings required for this configuration are loaded from the Atom bios which include the i2c address. If

[PATCH AUTOSEL 5.6 072/149] drm/stm: ltdc: check crtc state before enabling LIE

2020-04-11 Thread Sasha Levin
From: Yannick Fertre [ Upstream commit a6bd58c51ac43083f3977057a7ad668def55812f ] Following investigations of a hardware bug, the LIE interrupt can occur while the display controller is not activated. LIE interrupt (vblank) don't have to be set if the CRTC is not enabled. Signed-off-by:

[PATCH AUTOSEL 5.6 036/149] drm/amd/display: writing stereo polarity register if swapped

2020-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit e592e85f3378246dd66b861fa60ef803d8cece6b ] [why] on some displays that prefer swapped polarity we were seeing L/R images swapped because OTG_STEREO_SYNC_OUTPUT_POLARITY would always be mapped to 0 [how] fix initial dal3 implementation to properly update the

[PATCH AUTOSEL 5.6 068/149] drm/amd/display: always apply T7/T9 delay logic

2020-04-11 Thread Sasha Levin
From: Martin Leung [ Upstream commit cb8348fec250e517b5facb4cab3125ddc597f9aa ] [why] before we exit early in edp_reciever_ready if we detect that panel is not edp or below rev 1.2. This will skip the backlight/t7 delay panel patch. [how] edit logic to ensure panel patch is applied regardless

[PATCH AUTOSEL 5.6 059/149] drm/sun4i: dsi: Use NULL to signify "no panel"

2020-04-11 Thread Sasha Levin
From: Samuel Holland [ Upstream commit 0e4e3fb4901d19f49e5c0a582f383b10dda8d1c5 ] The continued use of an ERR_PTR to signify "no panel" outside of sun6i_dsi_attach is confusing because it is a double negative. Because the connector always reports itself as connected, there is also the

[PATCH AUTOSEL 5.6 069/149] drm/omap: fix possible object reference leak

2020-04-11 Thread Sasha Levin
From: Wen Yang [ Upstream commit 47340e46f34a3b1d80e40b43ae3d7a8da34a3541 ] The call to of_find_matching_node returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings:

[PATCH AUTOSEL 5.6 073/149] fbdev: potential information leak in do_fb_ioctl()

2020-04-11 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit d3d19d6fc5736a798b118971935ce274f7deaa82 ] The "fix" struct has a 2 byte hole after ->ywrapstep and the "fix = info->fix;" assignment doesn't necessarily clear it. It depends on the compiler. The solution is just to replace the assignment with an

[PATCH AUTOSEL 5.6 031/149] drm/tegra: dc: Release PM and RGB output when client's registration fails

2020-04-11 Thread Sasha Levin
From: Dmitry Osipenko [ Upstream commit 0411ea89a689531e1829fdf8af3747646c02c721 ] Runtime PM and RGB output need to be released when host1x client registration fails. The releasing is missed in the code, let's correct it. Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding

[PATCH AUTOSEL 5.6 039/149] drm/amd/display: Fix default logger mask definition

2020-04-11 Thread Sasha Levin
From: Eric Bernstein [ Upstream commit ccb6af1e25830e5601b6beacc698390f0245316f ] [Why] Logger mask was updated to uint64_t, however default mask definition was not updated for unsigned long long [How] Update DC_DEFAULT_LOG_MASK to support uint64_t type Signed-off-by: Eric Bernstein

[PATCH AUTOSEL 5.6 015/149] drm/amd/display: Explicitly disable triplebuffer flips

2020-04-11 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 2d673560b7b83f8fe4163610f35c51b4d095525c ] [Why] This is enabled by default on Renoir but there's userspace/API support to actually make use of this. Since we're not passing this down through surface updates, let's explicitly disable this for now.

[PATCH AUTOSEL 5.6 023/149] drm/amdgpu: check GFX RAS capability before reset counters

2020-04-11 Thread Sasha Levin
From: Hawking Zhang [ Upstream commit 06dcd7eb83ee65382305ce48686e3dadaad42088 ] disallow the logical to be enabled on platforms that don't support gfx ras at this stage, like sriov skus, dgpu with legacy ras.etc Signed-off-by: Hawking Zhang Reviewed-by: Monk Liu Signed-off-by: Alex Deucher

[PATCH AUTOSEL 5.6 010/149] drm/amd/display: differentiate vsc sdp colorimetry use criteria between MST and SST

2020-04-11 Thread Sasha Levin
From: Martin Tsai [ Upstream commit c38cc6770fd5f78a0918ed0b01af14de31aba5cb ] [Why] We should check MST BU support capability on output port before building vsc info packet. [How] Add a new definition for port and sink capability check. Signed-off-by: Martin Tsai Reviewed-by: Wenjing Liu

[PATCH AUTOSEL 5.6 016/149] drm/amd/display: Fix test pattern color space inconsistency for Linux

2020-04-11 Thread Sasha Levin
From: "Jerry (Fangzhi) Zuo" [ Upstream commit ef65c702d40637ed9ee25edc8e8a994168a32377 ] [why] When reprogram MSA with updated color space, the test color space shows inconsistency. Linux has separate routine to set up test pattern color space, but it fails to configure RGB. [How] Add RGB to

[PATCH v2] component: Silence bind error on -EPROBE_DEFER

2020-04-11 Thread James Hilliard
If a component fails to bind due to -EPROBE_DEFER we should not log an error as this is not a real failure. Fixes: vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517 vc4-drm soc:gpu: master bind failed: -517 Signed-off-by: James Hilliard --- Changes v1 -> v2: - remove

[Bug 207199] New: VC4: debugfs error message

2020-04-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207199 Bug ID: 207199 Summary: VC4: debugfs error message Product: Drivers Version: 2.5 Kernel Version: 5.4.23 Hardware: ARM OS: Linux Tree: Mainline

[Bug 206575] [amdgpu] [drm] No video signal on resume from suspend, R9 380

2020-04-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206575 --- Comment #21 from Noel Maersk (veox+ker...@veox.pw) --- Created attachment 288351 --> https://bugzilla.kernel.org/attachment.cgi?id=288351=edit git bisect log to find the culprit Attaching original git bisect log (was posted to github

[Bug 206575] [amdgpu] [drm] No video signal on resume from suspend, R9 380

2020-04-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206575 --- Comment #20 from Noel Maersk (veox+ker...@veox.pw) --- I'll do a bisect to identify the fix. Roughly 15 steps. -- You are receiving this mail because: You are watching the assignee of the bug. ___

RE: [PATCH 20/28] mm: remove the pgprot argument to __vmalloc

2020-04-11 Thread Michael Kelley
From: Christoph Hellwig Sent: Wednesday, April 8, 2020 4:59 AM > > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove > it. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/hyperv/hv_init.c | 3 +-- > arch/x86/include/asm/kvm_host.h| 3 +-- >

RE: [PATCH 01/28] x86/hyperv: use vmalloc_exec for the hypercall page

2020-04-11 Thread Michael Kelley
From: Christoph Hellwig Sent: Wednesday, April 8, 2020 4:59 AM > > Use the designated helper for allocating executable kernel memory, and > remove the now unused PAGE_KERNEL_RX define. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/hyperv/hv_init.c| 2 +- >

Re: [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-11 Thread Sultan Alsawaf
On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > From: Sultan Alsawaf > > > > The following deadlock exists in i915_active_wait() due to a double lock > > on ref->mutex (call chain listed in order from top to bottom):

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-11 Thread Saeed Mahameed
On Fri, 2020-04-10 at 14:13 -0300, Jason Gunthorpe wrote: > On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > > > This assumes that the module using FOO has its own flag > > representing > > FOO which is not always the case. > > > > for example in mlx5 we use VXLAN config flag

Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-11 Thread Markus Elfring
>> I found 20 source files from the software “Linux next-20200408” >> which seem to contain similar update candidates. >> Would you like to clarify any extensions for improved applications >> of scripts with the semantic patch language (Coccinelle software) >> for corresponding analysis and

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-11 Thread Jason Gunthorpe
On Fri, Apr 10, 2020 at 02:40:42AM +, Saeed Mahameed wrote: > This assumes that the module using FOO has its own flag representing > FOO which is not always the case. > > for example in mlx5 we use VXLAN config flag directly to compile VXLAN > related files: > > mlx5/core/Makefile: > >

Re: drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()

2020-04-11 Thread Markus Elfring
> The right way to check for errors is to check if the return value is > less than 0. Thanks for your constructive feedback. I was unsure if I noticed another programming mistake. > Could you please audit all uses of platform_get_irq() in drivers/gpu/ I found 20 source files from the software

Re: BUG: kernel NULL pointer dereference, address: 0000000000000026 after switching to 5.7 kernel

2020-04-11 Thread Hillf Danton
On Sat, 11 Apr 2020 00:51:48 +0500 Mikhail Gavrilov wrote: > Hi folks. > After upgrade kernel to 5.7 I see every boot in kernel log following > error messages: > > [2.569513] [drm] Found UVD firmware ENC: 1.2 DEC: .43 Family ID: 19 > [2.569538] [drm] PSP loading UVD firmware > [

Re: [PATCH] drm/hisilicon: Code refactoring for hibmc_drv_vdac

2020-04-11 Thread tiantao (H)
Thank you, your suggestion is accepted and I will issue v2 在 2020/4/11 11:43, Joe Perches 写道: On Sat, 2020-04-11 at 10:49 +0800, Tian Tao wrote: code refactoring for hibmc_drv_vdac.c, no actual function changes. Seems sensible. diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c

[PATCH] drm/hisilicon: Add the shutdown for hibmc_pci_driver

2020-04-11 Thread Tian Tao
add the shutdown function to release the resource. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

  1   2   >