Re: nouveau PUSHBUFFER_ERR on 5.9.0-rc2-next-20200824

2020-08-30 Thread Ben Skeggs
On Tue, 25 Aug 2020 at 17:21, Alexander Kapshuk wrote: > > Since upgrading to linux-next based on 5.9.0-rc1 and 5.9.0-rc2 I have > had my mouse pointer disappear soon after logging in, and I have > observed the system freezing temporarily when clicking on objects and > when typing text. > I have

Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-08-30 Thread Ben Skeggs
On Wed, 26 Aug 2020 at 02:52, Lyude Paul wrote: > > On Tue, 2020-08-25 at 08:28 +1000, Ben Skeggs wrote: > > On Tue, 25 Aug 2020 at 04:33, Lyude Paul wrote: > > > Not entirely sure why this never came up when I originally tested this > > > (maybe some BIOSes already have this setup?) but the

Re: [PATCH v2 2/2] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-30 Thread Ezequiel Garcia
Hi Paul, On Thu, 27 Aug 2020 at 09:04, Paul Cercueil wrote: > > Even if support for the IPU was compiled in, we may run on a device > (e.g. the Qi LB60) where the IPU is not available, or simply with an old > devicetree without the IPU node. In that case the ingenic-drm refused to > probe. > >

Re: [PATCH v5 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to > drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' > information. > >

Re: [PATCH v5 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-30 Thread Chun-Kuang Hu
Hi, Chunfeng & Kishon: How do you feel about this patch? Regards, Chun-Kuang. Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > From: CK Hu > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy

Re: [PATCH AUTOSEL 5.8 52/63] drm/amdgpu: disable gfxoff for navy_flounder

2020-08-30 Thread Sasha Levin
On Mon, Aug 24, 2020 at 02:23:42PM -0400, Alex Deucher wrote: On Mon, Aug 24, 2020 at 12:36 PM Sasha Levin wrote: From: Jiansong Chen [ Upstream commit 9c9b17a7d19a8e21db2e378784fff1128b46c9d3 ] gfxoff is temporarily disabled for navy_flounder, since at present the feature has broken some

Re: [v4,04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-08-30 Thread Sam Ravnborg
Hi Marek. On Thu, Aug 27, 2020 at 01:39:06PM +0200, Marek Szyprowski wrote: > Hi Sam, > > On 26.07.2020 22:33, Sam Ravnborg wrote: > > Prepare the tc358764 bridge driver for use in a chained setup by > > replacing direct use of drm_panel with drm_panel_bridge support. > > > > The bridge panel

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Sam Ravnborg
Hi Laurent. > > > > Please read the cover letter, it explains why it's done this way. The > > whole point of this patchset is to merge DSI and DBI frameworks in a > > way that can be maintained. > > I think this proves the point that the proposed naming is confusing. At > least a rename would

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Laurent Pinchart
Hi Paul, On Sun, Aug 30, 2020 at 06:48:12PM +0200, Paul Cercueil wrote: > Le dim. 30 août 2020 à 16:36, 何小龙 (Leon He) a écrit : > >> +struct ili9341 { > >> + struct drm_panel panel; > >> + struct mipi_dsi_device *dsi; > >> + const struct ili9341_pdata *pdata; > >> + > >> +

[Bug 209071] Nouveau dual monitor setup: After unlock xscreensaver, VGA-1 remains black

2020-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209071 Oscar Megía (megia.os...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Leon He
> +struct ili9341 { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + const struct ili9341_pdata *pdata; > + > + struct gpio_desc*reset_gpiod; > + u32 rotation; > +}; > + Hi Paul, you put the mipi_dsi_device inside the struct. I think it maybe

[PATCH v6 0/3] drm/vkms: Introduces writeback support

2020-08-30 Thread Rodrigo Siqueira
This is the V5 version of a series that introduces the writeback support to VKMS. The first two patches of this series are a pre-work for the latest patch that adds the writeback connector, this patchset can be seen in two parts: * A pre-work that aims to make vkms composer operations a little

[PATCH v6 2/3] drm/vkms: Compute CRC without change input data

2020-08-30 Thread Rodrigo Siqueira
The compute_crc() function is responsible for calculating the framebuffer CRC value; due to the XRGB format, this function has to ignore the alpha channel during the CRC computation. Therefore, compute_crc() set zero to the alpha channel directly in the input framebuffer, which is not a problem

[PATCH v6 3/3] drm/vkms: Add support for writeback

2020-08-30 Thread Rodrigo Siqueira
This patch implements the necessary functions to add writeback support for vkms. This feature is useful for testing compositors if you don't have hardware with writeback support. Change in V4 (Emil and Melissa): - Move signal completion above drm_crtc_add_crc_entry() - Make writeback always

[PATCH v6 1/3] drm/vkms: Decouple crc operations from composer

2020-08-30 Thread Rodrigo Siqueira
In the vkms_composer.c, some of the functions related to CRC and compose have interdependence between each other. This patch reworks some functions inside vkms_composer to make crc and composer computation decoupled. This patch is preparation work for making vkms able to support new features.

Re: [PATCH v2] drm/vkms: add alpha-premultiplied color blending

2020-08-30 Thread Rodrigo Siqueira
Reviewed-by: Rodrigo Siqueira On 08/25, Melissa Wen wrote: > The VKMS blend function was ignoring the alpha channel and just > overwriting vaddr_src with vaddr_dst. This XRGB approach triggers a > warning when running the kms_cursor_crc/cursor-alpha-transparent test > case. In IGT,

[PATCH v8 12/17] pwm: crc: Implement apply() method to support the new atomic PWM API

2020-08-30 Thread Hans de Goede
Replace the enable, disable and config pwm_ops with an apply op, to support the new atomic PWM API. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v6: - Rebase on 5.9-rc1 - Use do_div when calculating level because pwm_state.period and .duty_cycle are now u64 Changes

[PATCH v8 17/17] drm/i915: panel: Use atomic PWM API for devs with an external PWM controller

2020-08-30 Thread Hans de Goede
Now that the PWM drivers which we use have been converted to the atomic PWM API, we can move the i915 panel code over to using the atomic PWM API. The removes a long standing FIXME and this removes a flicker where the backlight brightness would jump to 100% when i915 loads even if using the

[PATCH v8 08/17] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-08-30 Thread Hans de Goede
While looking into adding atomic-pwm support to the pwm-crc driver I noticed something odd, there is a PWM_BASE_CLK define of 6 MHz and there is a clock-divider which divides this with a value between 1-128, and there are 256 duty-cycle steps. The pwm-crc code before this commit assumed that a

[PATCH v8 09/17] pwm: crc: Fix off-by-one error in the clock-divider calculations

2020-08-30 Thread Hans de Goede
The CRC PWM controller has a clock-divider which divides the clock with a value between 1-128. But as can seen from the PWM_DIV_CLK_xxx defines, this range maps to a register value of 0-127. So after calculating the clock-divider we must subtract 1 to get the register value, unless the requested

[PATCH v8 10/17] pwm: crc: Fix period changes not having any effect

2020-08-30 Thread Hans de Goede
The pwm-crc code is using 2 different enable bits: 1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE) 2. bit 0 of the BACKLIGHT_EN register The BACKLIGHT_EN register at address 0x51 really controls a separate output-only GPIO which is earmarked to be used as output connected to the backlight-enable

[PATCH v8 16/17] drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller

2020-08-30 Thread Hans de Goede
So far for devices using an external PWM controller (devices using pwm_setup_backlight()), we have been hardcoding the minimum allowed PWM level to 0. But several of these devices specify a non 0 minimum setting in their VBT. Change pwm_setup_backlight() to use get_backlight_min_vbt() to get the

[PATCH v8 15/17] drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller

2020-08-30 Thread Hans de Goede
So far for devices using an external PWM controller (devices using pwm_setup_backlight()), we have been hardcoding the period-time passed to pwm_config() to 21333 ns. I suspect this was done because many VBTs set the PWM frequency to 200 which corresponds to a period-time of 500 ns, which

[PATCH v8 07/17] pwm: lpss: Always update state and set update bit

2020-08-30 Thread Hans de Goede
This commit removes a check where we would skip writing the ctrl register and then setting the update bit in case the ctrl register already contains the correct values. In a perfect world skipping the update should be fine in these cases, but on Cherry Trail devices the AML code in the GFX0

[PATCH v8 13/17] pwm: crc: Implement get_state() method

2020-08-30 Thread Hans de Goede
Implement the pwm_ops.get_state() method to complete the support for the new atomic PWM API. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v6: - Rebase on 5.9-rc1 - Use DIV_ROUND_UP_ULL because pwm_state.period and .duty_cycle are now u64 Changes in v5: - Fix an

[PATCH v8 14/17] drm/i915: panel: Add get_vbt_pwm_freq() helper

2020-08-30 Thread Hans de Goede
Factor the code which checks and drm_dbg_kms-s the VBT PWM frequency out of get_backlight_max_vbt(). This is a preparation patch for honering the VBT PWM frequency for devices which use an external PWM controller (devices using pwm_setup_backlight()). Acked-by: Jani Nikula Signed-off-by: Hans

[PATCH v8 11/17] pwm: crc: Enable/disable PWM output on enable/disable

2020-08-30 Thread Hans de Goede
The pwm-crc code is using 2 different enable bits: 1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE) 2. bit 0 of the BACKLIGHT_EN register So far we've kept the PWM_OUTPUT_ENABLE bit set when disabling the PWM, this commit makes crc_pwm_disable() clear it on disable and makes crc_pwm_enable() set

[PATCH v8 05/17] pwm: lpss: Add pwm_lpss_prepare_enable() helper

2020-08-30 Thread Hans de Goede
In the not-enabled -> enabled path pwm_lpss_apply() needs to get a runtime-pm reference; and then on any errors it needs to release it again. This leads to somewhat hard to read code. This commit introduces a new pwm_lpss_prepare_enable() helper and moves all the steps necessary for the

[PATCH v8 06/17] pwm: lpss: Use pwm_lpss_restore() when restoring state on resume

2020-08-30 Thread Hans de Goede
Before this commit a suspend + resume of the LPSS PWM controller would result in the controller being reset to its defaults of output-freq = clock/256, duty-cycle=100%, until someone changes to the output-freq and/or duty-cycle are made. This problem has been masked so far because the main

[PATCH v8 02/17] ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)

2020-08-30 Thread Hans de Goede
The DSDTs on most Cherry Trail devices have an ugly clutch where the PWM controller gets turned off from the _PS3 method of the graphics-card dev: Method (_PS3, 0, Serialized) // _PS3: Power State 3 { ... PWMB = PWMC /*

[PATCH v8 03/17] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()

2020-08-30 Thread Hans de Goede
According to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter overflowing determines the PWM output frequency. So assuming e.g. a 16 bit counter this means that if base_unit is set to 1, after 65535 input

[PATCH v8 04/17] pwm: lpss: Add range limit check for the base_unit register value

2020-08-30 Thread Hans de Goede
When the user requests a high enough period ns value, then the calculations in pwm_lpss_prepare() might result in a base_unit value of 0. But according to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter

[PATCH v8 00/17] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-08-30 Thread Hans de Goede
Hi All, Unfortunately while testing some unrelated things I found another issue with this series related to the CHT ACPI GFX0._PS3 code poking the PWM controller in unexpected ways. This new version contains a new patch: "[PATCH v8 07/17] pwm: lpss: Always update state and set update bit" fixing

[PATCH v8 01/17] ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase

2020-08-30 Thread Hans de Goede
The DSDTs on most Cherry Trail devices have an ugly clutch where the PWM controller gets poked from the _PS0 method of the graphics-card device: Local0 = PSAT /* \_SB_.PCI0.GFX0.PSAT */ If (((Local0 & 0x03) == 0x03)) { PSAT &= 0xFFFC Local1 =

[PATCH] fbdev: remove mbx framebuffer driver

2020-08-30 Thread Mike Rapoport
From: Mike Rapoport The only in-tree user for mbx driver for Intel 2700G graphics chip was cm-x270 platform. Since this platform was removed by the commit 9d3239147d6d ("ARM: pxa: remove Compulab pxa2xx boards") there is no point to keep the obsolete framebuffer driver. Signed-off-by: Mike

[PATCH] dt-bindings: gpu: samsung-rotator: Use unevaluatedProperties

2020-08-30 Thread Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. power domains) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm/boot/dts/exynos4210-i9100.dt.yaml: rotator@1281: 'iommus', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by:

[PATCH] dt-bindings: gpu: arm,mali-utgard: Correct Maxime's email

2020-08-30 Thread Krzysztof Kozlowski
Update the address of Maxime Ripard as one in @free-electrons.com does not work. Cc: Maxime Ripard Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/arm,mali-utgard.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] dt-bindings: gpu: arm,mali-utgard: Use unevaluatedProperties

2020-08-30 Thread Krzysztof Kozlowski
Additional properties or nodes actually might appear (e.g. operating points table) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm/boot/dts/exynos4210-i9100.dt.yaml: gpu@1300: 'opp_table' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by:

[PATCH 2/2] drm/radeon: Add vddc hwmon sensor

2020-08-30 Thread Sandeep Raghuraman
Signed-off-by: Sandeep Raghuraman --- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_asic.c | 1 + drivers/gpu/drm/radeon/radeon_asic.h | 1 + drivers/gpu/drm/radeon/radeon_pm.c | 21 + drivers/gpu/drm/radeon/sumo_dpm.c| 20

[PATCH 1/2] drm/radeon: Add sclk frequency as hwmon sensor

2020-08-30 Thread Sandeep Raghuraman
This patch series adds support for reporting sclk and vddc values for Radeon GPUs, where supported. Signed-off-by: Sandeep Raghuraman --- drivers/gpu/drm/radeon/radeon_pm.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git

[Bug 208839] AMDGPU: DPM is not enabled after hibernate and resume for CIK/Hawaii GPUs (e.g R9 390)

2020-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208839 sandy.8...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 207137] AMDGPU incorrectly reports vddgfx voltage for R9 390

2020-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207137 sandy.8...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PULL] drm-misc-next

2020-08-30 Thread Daniel Vetter
On Wed, Aug 26, 2020 at 12:02 PM Jani Nikula wrote: > > On Thu, 20 Aug 2020, Maxime Ripard wrote: > > This PR diffstat is pretty massive since we merged 5.9-rc1 and it's not > > (yet?) in drm-next. > > > > I'm not entirely sure how to tackle this (if it causes an issue?). > > > > Let me know,