[PATCH v2 2/2] drm/kmb: Do not report 0 (success) in case of error

2021-05-26 Thread Christophe JAILLET
'ret' is known to be 0 at this point. Reporting the error from the previous 'platform_get_irq()' call is likely, so add the missing assignment. Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Christophe JAILLET --- v2: New patch --- drivers/gpu/drm/kmb/kmb_drv.c |

[PATCH v2 1/2] drm/kmb: Fix an error handling path

2021-05-26 Thread Christophe JAILLET
If 'platform_get_irq()' fails, it is spurious to call 'of_reserved_mem_device_release()' in the error handling path, because 'of_reserved_mem_device_init() has not been called yet. Moreover, a previous 'kmb_initialize_clocks()' is unbalanced by a corresponding 'kmb_display_clk_disable()' call, has

[v1] drm/msm/disp/dpu1: avoid perf update in frame done event

2021-05-26 Thread Krishna Manikandan
Crtc perf update from frame event work can result in wrong bandwidth and clock update from dpu if the work is scheduled after the swap state has happened. Avoid such issues by moving perf update to complete commit once the frame is accepted by the hardware. Fixes: a29c8c024165 ("drm/msm/disp/dpu1

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Jason Ekstrand
On May 26, 2021 13:15:08 Daniel Stone wrote: Hey, On Wed, 26 May 2021 at 16:24, Jason Ekstrand wrote: On Wed, May 26, 2021 at 6:09 AM Daniel Stone wrote: Typing out the Wayland protocol isn't the hard bit. If we just need to copy and sed syncobj to weirdsyncobj, no problem really, and it g

Re: [PATCH 24/34] drm/amd/display/modules/hdcp/hdcp_psp: Remove unused function 'mod_hdcp_hdcp1_get_link_encryption_status()'

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: > warning: no previous prototype for > ‘mod_hdcp_hdcp1_get_link_encryption_status’ [-Wmissing-protot

Re: [PATCH 23/34] drm/amd/display/dmub/src/dmub_srv_stat: Convert function header to kernel-doc

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv_stat.c:38: warning: > Cannot understand > ***

Re: [PATCH 22/34] drm/amd/display/dc/core/dc: Convert function headers to kernel-doc

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3324: warning: Cannot > understand > * >

Re: [PATCH 21/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include header containing our prototypes

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:929:6: > warning: no previous prototype for ‘dce110_edp_wait_for_T12’ > [-Wmissing-prototypes] > > C

Re: [PATCH 20/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Fix kernel-doc formatting issue

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: > Function parameter or member 'interrupt_params' not described in > 'dm_dcn_vertical_interrupt0

Re: [PATCH 19/34] drm/amd/amdgpu/amdgpu_device: Make local function static

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4624:6: warning: no previous > prototype for ‘amdgpu_device_recheck_guilty_jobs’ [-Wmissing-prototypes] > > Cc: Alex Deucher >

Re: [PATCH 18/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270

Re: [PATCH 17/34] drm/amd/display/dc/dce/dce_mem_input: Remove duplicate initialisation of GRPH_CONTROL__GRPH_NUM_BANKS_{SHIFT, MASK}

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:29: > > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_sh_mask.h:7270

Re: [PATCH 16/34] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,

2021-05-26 Thread Alex Deucher
On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:374:22: > warning: no previous prototype for ‘mod_hdcp_hdcp1_get_link_encryption_status’ > In file included from > drivers/gpu

Re: [PATCH 15/34] drm/amd/display/dc/dce110/dce110_hw_sequencer: Include our own header

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:927:6: > warning: no previous prototype for ‘dce110_edp_wait_for_T12’ > [-Wmissing-prototypes] > > C

Re: [PATCH 14/34] drm/amd/display/dc/gpio/gpio_service: Pass around correct dce_{version, environment} types

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c: In function > ‘dal_gpio_service_create’: > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_service.c:71:4

Re: [PATCH 13/34] drm/amd/display/dc/dce/dmub_outbox: Convert over to kernel-doc

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_outbox.c:30: warning: > Cannot understand > ***

Re: [PATCH 12/34] drm/amd/display/amdgpu_dm/amdgpu_dm: Functions must directly follow their headers

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:608: warning: > Function parameter or member 'interrupt_params' not described in > 'dm_dcn_vertical_interrupt0

Re: [PATCH 10/34] drm/amd/display/dc/bios/bios_parser: Fix formatting and misnaming issues

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: > expecting prototype for get_ss_info_from_table(). Prototype was for > get_ss_info_from_tbl() i

Re: [PATCH 09/34] drm/amd/display/dc/bios/command_table_helper2: Fix function name 'dal_cmd_table_helper_transmitter_bp_to_atom2()'

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:141: > warning: expecting prototype for translate_transmitter_bp_to_atom2(). > Prototype was for dal

Re: [PATCH 08/34] drm/amd/display/dc/bios/command_table_helper: Fix function name for 'dal_cmd_table_helper_transmitter_bp_to_atom()'

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:48 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:127: > warning: expecting prototype for translate_transmitter_bp_to_atom(). > Prototype was for dal_c

Re: [PATCH 07/34] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Provide function name 'vega20_init_smc_table()'

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:781: > warning: expecting prototype for Initializes the SMC table and uploads it(). > Prototype was for ve

Re: [PATCH 06/34] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Kernel-doc headers must contain function names

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:547: > warning: This comment starts with '/**', but isn't a kernel-doc comment. > Refer Documentation/doc-

Re: [PATCH 05/34] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Provide 'vega12_init_smc_table()' function name

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:812: > warning: expecting prototype for Initializes the SMC table and uploads it(). > Prototype was for ve

Re: [PATCH 04/34] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Provide function name

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:171: > warning: expecting prototype for Set the requested temperature range for high > and low alert sig

Re: [PATCH 03/34] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Provide function name for 'smu7_fan_ctrl_set_default_mode()'

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:132: > warning: This comment starts with '/**', but isn't a kernel-doc comment. > Refer Documentation/doc-

Re: [PATCH 02/34] drm/amd/pm/swsmu/smu13/aldebaran_ppt: Remove unused variable 'ret'

2021-05-26 Thread Alex Deucher
This should be checked. Will send out a patch momentarily. Thanks, Alex On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/aldebaran_ppt.c: In function > ‘aldebaran_is_dpm_running’: > drivers

Re: [PATCH 01/34] drm/amd/pm/inc/smu_v13_0: Move table into the only source file that uses it

2021-05-26 Thread Alex Deucher
Applied. Thanks! On Wed, May 26, 2021 at 4:47 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/inc/smu_v13_0.h:54:43: warning: > ‘smu13_thermal_policy’ defined but not used [-Wunused-const-variable=] > > Cc: Alex Deucher > Cc: "Chri

Re: [PATCH v9 07/10] mm: Device exclusive memory access

2021-05-26 Thread Alistair Popple
On Thursday, 27 May 2021 5:28:32 AM AEST Peter Xu wrote: > On Mon, May 24, 2021 at 11:27:22PM +1000, Alistair Popple wrote: > > Some devices require exclusive write access to shared virtual > > memory (SVM) ranges to perform atomic operations on that memory. This > > requires CPU page tables to be

[pull] amdgpu, amdkfd drm-fixes-5.13

2021-05-26 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.13. The following changes since commit a2b4785f01280a4291edb9fda69032fc2e4bfd3f: drm/amdgpu: stop touching sched.ready in the backend (2021-05-19 18:07:43 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-d

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Engine relative MMIO

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 07:43:02PM -0700, Matthew Brost wrote: > On Wed, May 26, 2021 at 06:34:44PM -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 5/26/2021 12:11 PM, Matthew Brost wrote: > > > With virtual engines, it is no longer possible to know which specific > > > physical engine a give

Re: [PATCH] drm/msm/dpu: remove unused variable cmd_enc

2021-05-26 Thread Austin Kim
2021년 5월 21일 (금) 오후 1:16, Austin Kim 님이 작성: > > After the call to to_dpu_encoder_phys_cmd() is made, > 'cmd_enc' is not used. Where to_dpu_encoder_phys_cmd() is simply replaced with > container_of(x, struct dpu_encoder_phys_cmd, base) by compiler. > > So it had better remove W=1 kernel build warnin

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Engine relative MMIO

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 06:34:44PM -0700, Daniele Ceraolo Spurio wrote: > > > On 5/26/2021 12:11 PM, Matthew Brost wrote: > > With virtual engines, it is no longer possible to know which specific > > physical engine a given request will be executed on at the time that > > request is generated. Th

Re: [PATCH v2] drm/ast: Add detect function support

2021-05-26 Thread Ainux Wang
You're welcome! Best regards Ainux Wang Thomas Zimmermann 于2021年5月27日周四 上午3:15写道: > > Hi > > Am 26.05.21 um 13:15 schrieb ainux.w...@gmail.com: > > From: Ainux > > > > The existence of the connector cannot be detected, > > so add the detect function to support. > > > > Signed-off-by: Ainux >

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

2021-05-26 Thread Alex Deucher
Acked-by: Alex Deucher for the amdgpu changes. On Wed, May 26, 2021 at 3:21 PM Thomas Zimmermann wrote: > > ping for further a-bs / r-bs > > Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: > > This is a cleanup patchset to remove drm_format_name_buf et al. There > > are two instances in drivers

Re: [Intel-gfx] [PATCH v4 14/17] drm/i915/pxp: User interface for Protected buffer

2021-05-26 Thread Daniele Ceraolo Spurio
On 5/25/2021 11:36 AM, Tang, CQ wrote: -Original Message- From: Intel-gfx On Behalf Of Daniele Ceraolo Spurio Sent: Monday, May 24, 2021 10:48 PM To: intel-...@lists.freedesktop.org Cc: Vetter, Daniel ; Huang Sean Z ; dri-devel@lists.freedesktop.org; Chris Wilson ; Kondapally Kalyan

Re: [PATCH v4 14/17] drm/i915/pxp: User interface for Protected buffer

2021-05-26 Thread Daniele Ceraolo Spurio
On 5/25/2021 6:32 AM, Daniel Vetter wrote: On Mon, May 24, 2021 at 10:48:00PM -0700, Daniele Ceraolo Spurio wrote: From: Bommu Krishnaiah This api allow user mode to create Protected buffers. Only contexts marked as protected are allowed to operate on protected buffers. We only allow setti

Re: [PATCH v9 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-05-26 Thread Peter Xu
On Thu, May 27, 2021 at 11:20:36AM +1000, Alistair Popple wrote: > On Thursday, 27 May 2021 5:50:05 AM AEST Peter Xu wrote: > > On Mon, May 24, 2021 at 11:27:21PM +1000, Alistair Popple wrote: > > > Currently if copy_nonpresent_pte() returns a non-zero value it is > > > assumed to be a swap entry w

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Engine relative MMIO

2021-05-26 Thread Daniele Ceraolo Spurio
On 5/26/2021 12:11 PM, Matthew Brost wrote: With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that the request itself must be engine agnostic - any direct register writes m

[PATCH 2/2] drm/amdgpu: stop bookkeeping of temporary GTT allocation

2021-05-26 Thread Lang Yu
To improve buffer migration performace, stop bookkeeping of temporary GTT allocation, including allocation for BO evicted from VRAM and bounce buffer. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++

[PATCH 1/2] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY

2021-05-26 Thread Lang Yu
Make TTM_PL_FLAG_* start from zero and add TTM_PL_FLAG_TEMPORARY flag for temporary GTT allocation use. Signed-off-by: Lang Yu --- include/drm/ttm/ttm_placement.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placem

Re: [PATCH v9 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-05-26 Thread Alistair Popple
On Thursday, 27 May 2021 5:50:05 AM AEST Peter Xu wrote: > On Mon, May 24, 2021 at 11:27:21PM +1000, Alistair Popple wrote: > > Currently if copy_nonpresent_pte() returns a non-zero value it is > > assumed to be a swap entry which requires further processing outside the > > loop in copy_pte_range()

Re: [PATCH][next] nouveau/svm: Fix missing failure check on call to make_device_exclusive_range

2021-05-26 Thread Alistair Popple
On Thursday, 27 May 2021 12:04:59 AM AEST Colin King wrote: > The call to make_device_exclusive_range can potentially fail leaving > pointer page not initialized that leads to an uninitialized pointer > read issue. Fix this by adding a check to see if the call failed and > returning the error code.

Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations

2021-05-26 Thread Dave Airlie
On Thu, 27 May 2021 at 02:37, Daniel Vetter wrote: > > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than

RE: [PATCH] drm/kmb: Fix an error handling path

2021-05-26 Thread Chrisanthus, Anitha
Hi Christophe, Thanks for the patch, good catch! Patch looks good, few minor comments. Anitha > -Original Message- > From: Christophe JAILLET > Sent: Wednesday, May 19, 2021 1:47 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; airl...@linux.ie; dan...@ffwll.ch; > s...@ravnborg.org > Cc:

[RFC PATCH 1/2] drm/doc/rfc: i915 GuC submission / DRM scheduler

2021-05-26 Thread Matthew Brost
Add entry for i915 GuC submission / DRM scheduler integration plan. Follow up patch with details of new parallel submission uAPI to come. v2: (Daniel Vetter) - Expand explaination of why bonding isn't supported for GuC submission - CC some of the DRM scheduler maintainers - Add priority

[RFC PATCH 2/2] drm/doc/rfc: i915 new parallel submission uAPI plan

2021-05-26 Thread Matthew Brost
Add entry for i915 new parallel submission uAPI plan. v2: (Daniel Vetter): - Expand logical order explaination - Add dummy header - Only allow N BBs in execbuf IOCTL - Configure parallel submission per slot not per gem context v3: (Marcin Ślusarz): - Lot's of typos / bad english fixed

[RFC PATCH 0/2] GuC submission / DRM scheduler integration plan + new uAPI

2021-05-26 Thread Matthew Brost
Subject and patches say it all. v2: Address comments, patches have details of changes v3: Address comments, patches have details of changes Signed-off-by: Matthew Brost Matthew Brost (2): drm/doc/rfc: i915 GuC submission / DRM scheduler drm/doc/rfc: i915 new parallel submission uAPI plan

[PATCH 2/2] drm/i915/guc: Use guc_class instead of engine_class in fw interface

2021-05-26 Thread Matthew Brost
From: Daniele Ceraolo Spurio GuC has its own defines for the engine classes. They're currently mapping 1:1 to the defines used by the driver, but there is no guarantee this will continue in the future. Given that we've been caught off-guard in the past by similar divergences, we can prepare for t

[PATCH 1/2] drm/i915/guc: Early initialization of GuC send registers

2021-05-26 Thread Matthew Brost
From: Michal Wajdeczko Base offset and count of the GuC scratch registers, used for sending MMIO messages to GuC, can be initialized earlier with other GuC members that also depends on platform. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost Cc: Daniel

[PATCH 0/2] A couple more prerequisite patches to GuC submission

2021-05-26 Thread Matthew Brost
As discussed in [1] we are breaking that large series into a several smaller ones. This series includes 2 patches with no other dependencies and are fully reviewed discussed as part of step #4. Assuming CI looks good these patches can be merged immediately. [1] https://patchwork.freedesktop.org/s

Re: [RFC PATCH 34/97] drm/i915/guc: Use guc_class instead of engine_class in fw interface

2021-05-26 Thread Matthew Brost
On Thu, May 06, 2021 at 12:13:48PM -0700, Matthew Brost wrote: > From: Daniele Ceraolo Spurio > > GuC has its own defines for the engine classes. They're currently > mapping 1:1 to the defines used by the driver, but there is no guarantee > this will continue in the future. Given that we've been

Re: [RFC PATCH 31/97] drm/i915/guc: Early initialization of GuC send registers

2021-05-26 Thread Matthew Brost
On Thu, May 06, 2021 at 12:13:45PM -0700, Matthew Brost wrote: > From: Michal Wajdeczko > > Base offset and count of the GuC scratch registers, used for > sending MMIO messages to GuC, can be initialized earlier with > other GuC members that also depends on platform. > > Signed-off-by: Michal Wa

Re: [PATCH] drm/i915: Use generic_access_phys

2021-05-26 Thread kernel test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

2021-05-26 Thread Sakari Ailus
On Wed, May 26, 2021 at 09:21:10PM +0200, Thomas Zimmermann wrote: > ping for further a-bs / r-bs Thanks for the ping. For the series: Reviewed-by: Sakari Ailus > > Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: > > This is a cleanup patchset to remove drm_format_name_buf et al. There > > ar

Re: [PATCH v9 06/10] mm/memory.c: Allow different return codes for copy_nonpresent_pte()

2021-05-26 Thread Peter Xu
On Mon, May 24, 2021 at 11:27:21PM +1000, Alistair Popple wrote: > Currently if copy_nonpresent_pte() returns a non-zero value it is > assumed to be a swap entry which requires further processing outside the > loop in copy_pte_range() after dropping locks. This prevents other > values being returne

[PATCH 1/1] drm/i915: Introduce i915_sched_engine object

2021-05-26 Thread Matthew Brost
Introduce i915_sched_engine object which is lower level data structure that i915_scheduler / generic code can operate on without touching execlist specific structures. This allows additional submission backends to be added without breaking the layering. This is a bit of detour to integrating the i

[PATCH 0/1] Introduce i915_sched_engine object

2021-05-26 Thread Matthew Brost
As discussed in [1] we are breaking that large series into a several smaller ones. This series is stand alone patch part of step #4 which has no other dependencies or patches relevant to it. Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/series/89844/ Matthew Brost (1): dr

Re: [PATCH v5 1/3] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-05-26 Thread Thomas Zimmermann
Hi Am 20.05.21 um 07:41 schrieb Dexuan Cui: From: Deepak Rawat Sent: Wednesday, May 19, 2021 9:38 AM ... +static int hyperv_vmbus_suspend(struct hv_device *hdev) +{ + struct drm_device *dev = hv_get_drvdata(hdev); + int ret; + + ret = drm_mode_config_helper_suspend(dev); If

Re: [PATCH v9 05/10] mm: Rename migrate_pgmap_owner

2021-05-26 Thread Peter Xu
On Mon, May 24, 2021 at 11:27:20PM +1000, Alistair Popple wrote: > @@ -521,14 +521,14 @@ static inline void mmu_notifier_range_init(struct > mmu_notifier_range *range, > range->flags = flags; > } > > -static inline void mmu_notifier_range_init_migrate( > - struct mmu_n

Re: [PATCH] fbdev: matrox: use modern module_init()

2021-05-26 Thread Thomas Zimmermann
Am 14.05.21 um 23:33 schrieb Arnd Bergmann: From: Arnd Bergmann This is one of the last drivers with a global init_module() function instead of the modern module_init() annotation. Convert it over. Signed-off-by: Arnd Bergmann Added to drm-misc-next. Thank you. Best regards Thomas ---

Re: [PATCH v9 07/10] mm: Device exclusive memory access

2021-05-26 Thread Peter Xu
On Mon, May 24, 2021 at 11:27:22PM +1000, Alistair Popple wrote: > Some devices require exclusive write access to shared virtual > memory (SVM) ranges to perform atomic operations on that memory. This > requires CPU page tables to be updated to deny access whilst atomic > operations are occurring.

Re: [PATCH v2] drm/fb-helper: improve DRM fbdev emulation device names

2021-05-26 Thread Thomas Zimmermann
Am 25.05.21 um 17:13 schrieb Javier Martinez Canillas: Framebuffer devices that are registered by DRM drivers for fbdev emulation have a "drmfb" suffix in their name. But makes them to be quite confusing for drivers that already have "drm" in their name: $ cat /proc/fb 0 rockchipdrmdrmfb $ ca

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

2021-05-26 Thread Thomas Zimmermann
ping for further a-bs / r-bs Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: This is a cleanup patchset to remove drm_format_name_buf et al. There are two instances in drivers that need to be replaced with the %4cc printk format modifier. Patch 3 was left over back from an earlier patchset. [1]

Re: [PATCH RESEND] drm/hisilicon/kirin: Use the correct HiSilicon copyright

2021-05-26 Thread Thomas Zimmermann
Am 22.05.21 um 12:15 schrieb Hao Fang: s/Hisilicon/HiSilicon/. It should use capital S, according to https://www.hisilicon.com/en. Signed-off-by: Hao Fang Acked-by: Tian Tao Applied to drm-misc-next. Thanks a lot. Best regards Thomas --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c

Re: [PATCH] drm: fix leaked dma handles after removing drm_pci_free

2021-05-26 Thread Thomas Zimmermann
Am 18.05.21 um 23:28 schrieb Joseph Kogut: After removing drm_pci_alloc/free, some instances where drm_pci_free() would have kfreed the dma handle were skipped. Ensure these handles are freed properly. Signed-off-by: Joseph Kogut Applied to drm-misc-next. Thanks Best regards Thomas ---

Re: [PATCH v2] drm/ast: Add detect function support

2021-05-26 Thread Thomas Zimmermann
Hi Am 26.05.21 um 13:15 schrieb ainux.w...@gmail.com: From: Ainux The existence of the connector cannot be detected, so add the detect function to support. Signed-off-by: Ainux Looks good. If no one else comments, I'll merge the patch soon. Thanks a lot. Best regards Thomas --- driv

Re: [PATCH] drm/i915: Use generic_access_phys

2021-05-26 Thread kernel test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH 1/1] drm/i915: Engine relative MMIO

2021-05-26 Thread Matthew Brost
With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated. This means that the request itself must be engine agnostic - any direct register writes must be relative to the engine and not absolute ad

[PATCH 0/1] Engine relative MMIO

2021-05-26 Thread Matthew Brost
As discussed in [1] we are breaking that large series into a several smaller ones. This series is stand alone patch part of step #4 which has no other dependencies or patches relevant to it. Taking ownership of the patch in this series from John Harrison per his request. Trybot CI [2] looks good,

Re: [Intel-gfx] [RFC PATCH 60/97] drm/i915: Track 'serial' counts for virtual engines

2021-05-26 Thread John Harrison
On 5/26/2021 01:40, Tvrtko Ursulin wrote: On 25/05/2021 18:52, Matthew Brost wrote: On Tue, May 25, 2021 at 11:16:12AM +0100, Tvrtko Ursulin wrote: On 06/05/2021 20:14, Matthew Brost wrote: From: John Harrison The serial number tracking of engines happens at the backend of request submissio

Re: [PATCH 5/5] PCI: Support ASpeed VGA cards behind a misbehaving bridge

2021-05-26 Thread Bjorn Helgaas
On Wed, May 26, 2021 at 01:00:33PM +1000, Dave Airlie wrote: > > > > > I think I would see if it's possible to call > > > > > vga_arb_select_default_device() from vga_arbiter_add_pci_device() > > > > > instead of from vga_arb_device_init(). > > > > > > > > > > I would also (as a separate patch) try

Re: [Intel-gfx] [RFC PATCH 39/97] drm/i915/guc: Increase size of CTB buffers

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 10:30:27AM +0100, Tvrtko Ursulin wrote: > > On 25/05/2021 18:15, Matthew Brost wrote: > > On Tue, May 25, 2021 at 10:24:09AM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/05/2021 20:13, Matthew Brost wrote: > > > > With the introduction of non-blocking CTBs more than one

Re: [Intel-gfx] [RFC PATCH 55/97] drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 10:21:05AM +0100, Tvrtko Ursulin wrote: > > On 25/05/2021 18:07, Matthew Brost wrote: > > On Tue, May 25, 2021 at 11:06:00AM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/05/2021 20:14, Matthew Brost wrote: > > > > When running the GuC the GPU can't be considered idle if

Re: [Intel-gfx] [RFC PATCH 53/97] drm/i915/guc: Disable semaphores when using GuC scheduling

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 10:25:13AM +0100, Tvrtko Ursulin wrote: > > On 25/05/2021 18:01, Matthew Brost wrote: > > On Tue, May 25, 2021 at 10:52:01AM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/05/2021 20:14, Matthew Brost wrote: > > > > Disable semaphores when using GuC scheduling as semaphore

Re: [Intel-gfx] [RFC PATCH 36/97] drm/i915/guc: Add non blocking CTB send function

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 09:57:10AM +0100, Tvrtko Ursulin wrote: > > On 25/05/2021 18:21, Matthew Brost wrote: > > On Tue, May 25, 2021 at 10:21:00AM +0100, Tvrtko Ursulin wrote: > > > > > > On 06/05/2021 20:13, Matthew Brost wrote: > > > > Add non blocking CTB send function, intel_guc_send_nb. In

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Stone
Hey, On Wed, 26 May 2021 at 16:24, Jason Ekstrand wrote: > On Wed, May 26, 2021 at 6:09 AM Daniel Stone wrote: > > Typing out the Wayland protocol isn't the hard bit. If we just need to > > copy and sed syncobj to weirdsyncobj, no problem really, and it gives > > us a six-month head start on pai

Re: [PATCH 15/18] drm/i915/guc: Ensure H2G buffer updates visible before tail update

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 02:36:18PM +0200, Michal Wajdeczko wrote: > > > On 26.05.2021 08:42, Matthew Brost wrote: > > Ensure H2G buffer updates are visible before descriptor tail updates by > > inserting a barrier between the H2G buffer update and the tail. The > > barrier is simple wmb() for SME

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Stone
Hey, On Wed, 26 May 2021 at 17:53, Daniel Vetter wrote: > On Wed, May 26, 2021 at 5:13 PM Daniel Stone wrote: > > > Shared is shared, I just meant to say that we always add the shared fence. > > > So an explicit ioctl to add more shared fences is kinda pointless. > > > > > > So yeah on a good dr

Re: [PATCH 13/18] drm/i915/guc: Relax CTB response timeout

2021-05-26 Thread Matthew Brost
On Wed, May 26, 2021 at 02:25:26PM +0200, Michal Wajdeczko wrote: > > > On 26.05.2021 08:42, Matthew Brost wrote: > > From: Michal Wajdeczko > > > > In upcoming patch we will allow more CTB requests to be sent in > > parallel to the GuC for processing, so we shouldn't assume any more > > that G

Re: [PATCH v4 15/15] drm/i915: Use ttm mmap handling for ttm bo's.

2021-05-26 Thread Thomas Hellström
On 5/26/21 1:32 PM, Thomas Hellström wrote: From: Maarten Lankhorst Use the ttm handlers for servicing page faults, and vm_access. We do our own validation of read-only access, otherwise use the ttm handlers as much as possible. Because the ttm handlers expect the vma_node at vma->base, we

Re: [PATCH v4 13/15] drm/i915: Disable mmap ioctl for gen12+

2021-05-26 Thread Intel
On 5/26/21 1:32 PM, Thomas Hellström wrote: From: Maarten Lankhorst The paltform should exclusively use mmap_offset, one less path to worry Hmm, Thought this was fixed, but s/paltform/platform/

Re: [PATCH 0/3] Clean a few backend interfaces in the i915

2021-05-26 Thread Daniel Vetter
On Tue, May 25, 2021 at 08:53:42AM -0700, Matthew Brost wrote: > On Tue, May 25, 2021 at 03:56:56PM +0200, Daniel Vetter wrote: > > On Fri, May 21, 2021 at 11:32:12AM -0700, Matthew Brost wrote: > > > As discussed in [1] start merging some support patches as a precursor to > > > GuC submission the

Re: [Intel-gfx] [PATCH 0/3] Clean a few backend interfaces in the i915

2021-05-26 Thread Daniel Vetter
On Tue, May 25, 2021 at 08:54:38AM -0700, Matthew Brost wrote: > On Tue, May 25, 2021 at 04:27:49PM +0100, Tvrtko Ursulin wrote: > > > > On 25/05/2021 14:56, Daniel Vetter wrote: > > > On Fri, May 21, 2021 at 11:32:12AM -0700, Matthew Brost wrote: > > > > As discussed in [1] start merging some sup

Re: [PATCH 7/7] RFC: dma-buf: Add an API for importing sync files (v7)

2021-05-26 Thread Daniel Vetter
On Tue, May 25, 2021 at 04:17:53PM -0500, Jason Ekstrand wrote: > This patch is analogous to the previous sync file export patch in that > it allows you to import a sync_file into a dma-buf. Unlike the previous > patch, however, this does add genuinely new functionality to dma-buf. > Without this,

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Vetter
On Wed, May 26, 2021 at 5:13 PM Daniel Stone wrote: > On Wed, 26 May 2021 at 14:44, Daniel Vetter wrote: > > On Wed, May 26, 2021 at 02:08:19PM +0100, Daniel Stone wrote: > > > Are you saying that if a compositor imports a client-provided dmabuf > > > as an EGLImage to use as a source texture for

[PATCH] drm/i915: Disable gpu relocations

2021-05-26 Thread Daniel Vetter
Media userspace was the last userspace to still use them, and they converted now too: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 This means no reason anymore to make relocations faster than they've been for the first 9 years of gem. This code was added i

Re: [PATCH] drm/i915: only disable default vga device

2021-05-26 Thread Emil Velikov
Hi Ville, On Tue, 18 May 2021 at 12:17, Ville Syrjälä wrote: > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > Hi Ville, > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > wrote: > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > From: Vive

Re: [PATCH v7 14/15] dt-bindings: of: Add restricted DMA pool

2021-05-26 Thread Will Deacon
On Wed, May 26, 2021 at 01:13:22PM +0100, Will Deacon wrote: > On Tue, May 18, 2021 at 02:42:14PM +0800, Claire Chang wrote: > > @@ -138,4 +160,9 @@ one for multimedia processing (named > > multimedia-memory@7700, 64MiB). > > memory-region = <&multimedia_reserved>; > >

[PATCH] drm/i915: Use generic_access_phys

2021-05-26 Thread Daniel Vetter
Since commit 96667f8a4382db9ed042332ca6ee165ae9b91307 Author: Daniel Vetter Date: Fri Nov 27 17:41:21 2020 +0100 mm: Close race in generic_access_phys it is race-free and can therefore be safely used for dynamic mappings like we have too. v2 git commit --amend *sigh* Cc: Jon Bloomfield

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Jason Ekstrand
On Wed, May 26, 2021 at 6:09 AM Daniel Stone wrote: > On Mon, 24 May 2021 at 18:11, Jason Ekstrand wrote: > > 3. Userspace memory fences. > > > > Note that timeline syncobj is NOT in that list. IMO, all the "wait > > for submit" stuff is an implementation detail we needed in order to > > get th

Re: [PATCH 4/4] RFC: dma-buf: Add an API for importing sync files (v6)

2021-05-26 Thread Daniel Stone
On Wed, 26 May 2021 at 14:44, Daniel Vetter wrote: > On Wed, May 26, 2021 at 02:08:19PM +0100, Daniel Stone wrote: > > Are you saying that if a compositor imports a client-provided dmabuf > > as an EGLImage to use as a source texture for its rendering, and then > > provides it to VA-API or V4L2 to

[PATCH] drm/i915: Use generic_access_phys

2021-05-26 Thread Daniel Vetter
Since commit 96667f8a4382db9ed042332ca6ee165ae9b91307 Author: Daniel Vetter Date: Fri Nov 27 17:41:21 2020 +0100 mm: Close race in generic_access_phys it is race-free and can therefore be safely used for dynamic mappings like we have too. Cc: Jon Bloomfield Signed-off-by: Daniel Vetter

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-26 Thread Jeffrey Hugo
On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > Hello Jeff, > > On 21-05-21, 08:09, Jeffrey Hugo wrote: > > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > > > Display Stream Compression (DSC) compresses the display stream in host > > > which > > > is later decoded by panel. Thi

[PATCH 2/3] drm/vgem: use shmem helpers

2021-05-26 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking a

[PATCH 3/3] drm/shmem-helper: Align to page size in dumb_create

2021-05-26 Thread Daniel Vetter
shmem helpers seem a bit sloppy here by automatically rounding up when actually creating the buffer, which results in under-reporting of what we actually have. Caught by igt/vgem_basic tests. Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: T

[PATCH 1/3] dma-buf: Require VM_PFNMAP vma for mmap

2021-05-26 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident sys

Re: [PATCH v2] drm/i915/params: Align visibility of device level and global modparams

2021-05-26 Thread Jani Nikula
On Wed, 26 May 2021, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We have a few modparams which get conditionaly exposed based on a Kconfig > options and in most cases this also means portions of the driver > implementing the respective feature are also left out. > > Align the visibility of d

[PATCH v2 12/12] drm/i915/gem: Manage all set-domain waits explicitly

2021-05-26 Thread Tvrtko Ursulin
From: Chris Wilson Only perform the domain transition under the object lock, and push the required waits to outside the lock. v2 (Tvrtko): * Rebase. v3 (Tvrtko): * Restore write to gtt domain in coherency selftest. (Matt) Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-of

Re: [PATCH v4 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting()

2021-05-26 Thread Christian König
Am 26.05.21 um 13:32 schrieb Thomas Hellström: If the bo is idle when calling ttm_bo_pipeline_gutting(), we unnecessarily create a ghost object and push it out to delayed destroy. Fix this by adding a path for idle, and document the function. Also avoid having the bo end up in a bad state vulner

Re: [PATCH 12/12] drm/i915/gem: Manage all set-domain waits explicitly

2021-05-26 Thread Matthew Auld
On 26/05/2021 15:14, Tvrtko Ursulin wrote: From: Chris Wilson Only perform the domain transition under the object lock, and push the required waits to outside the lock. v2 (Tvrtko): * Rebase. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld # v1 Signed-off-by: Tvrtko Ursulin --- d

  1   2   3   >