Re: [PATCH] drm/bridge: lt8912b: Drop unused includes

2021-05-29 Thread Adrien Grassein
Reviewed-by: Adren Grassein Le sam. 29 mai 2021 à 02:30, Linus Walleij a écrit : > > The Lontium bridge is including legacy header files for GPIO > but not using them. Delete the includes. > > Cc: Adrien Grassein > Cc: Robert Foss > Signed-off-by: Linus Walleij > --- >

Re: [RFC PATCH 46/97] drm/i915/guc: Implement GuC context operations for new inteface

2021-05-29 Thread Michal Wajdeczko
On 06.05.2021 21:14, Matthew Brost wrote: > Implement GuC context operations which includes GuC specific operations > pin, unpin, and destroy. > > Signed-off-by: John Harrison > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/intel_context.c | 5 + >

Re: [RFC PATCH 5/5] mm: changes to unref pages with Generic type

2021-05-29 Thread Felix Kuehling
Am 2021-05-29 um 2:42 a.m. schrieb Christoph Hellwig: > On Thu, May 27, 2021 at 07:08:09PM -0400, Felix Kuehling wrote: >> From: Alex Sierra >> >> pages in device mapping refcounts are 1-based, instead >> of 0-based. If refcount 1, means it can be freed. >> This logic is not set for Generic

Re: [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM

2021-05-29 Thread Felix Kuehling
Am 2021-05-29 um 2:38 a.m. schrieb Christoph Hellwig: > On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote: >> diff --git a/kernel/resource.c b/kernel/resource.c >> index 627e61b0c124..da137553b83e 100644 >> --- a/kernel/resource.c >> +++ b/kernel/resource.c >> @@ -783,7 +783,7 @@

Re: [RFC PATCH 0/5] Support DEVICE_GENERIC memory in migrate_vma_*

2021-05-29 Thread Felix Kuehling
Am 2021-05-29 um 2:41 a.m. schrieb Christoph Hellwig: > On Fri, May 28, 2021 at 11:56:36AM -0400, Felix Kuehling wrote: >> Am 2021-05-28 um 9:08 a.m. schrieb Jason Gunthorpe: >>> On Thu, May 27, 2021 at 07:08:04PM -0400, Felix Kuehling wrote: Now we're trying to migrate data to and from that

Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP

2021-05-29 Thread Bjorn Andersson
On Fri 28 May 18:40 CDT 2021, abhin...@codeaurora.org wrote: > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The eDP controller found in SC8180x is at large compatible with the > > current implementation, but has its register blocks at slightly > > different offsets. > > > > Add the compatible

Re: [PATCH 06/13] drm/ttm: flip over the range manager to self allocated nodes

2021-05-29 Thread Intel
Hi, Christian, On 4/30/21 11:25 AM, Christian König wrote: Start with the range manager to make the resource object the base class for the allocated nodes. While at it cleanup a lot of the code around that. Could you briefly describe the design thoughts around this. While it's clear to me

Re: ttm_resource_manager::use_tt

2021-05-29 Thread Intel
On 5/28/21 9:30 PM, Zack Rusin wrote: On 5/22/21 3:13 AM, Christian König wrote: Hi Zack, IIRC that was for the VMW_PL_GMR type, wasn't it? As far as I have seen that backend was just giving out unique numbers and it looked questionable that we allocated pages for that. E.g. when you set

[Bug 212293] [amdgpu] divide error: 0000 on resume from S3

2021-05-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212293 Sefa Eyeoglu (cont...@scrumplex.net) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] drm/amd/display: fix gcc set but not used warning of variable 'link_bandwidth_kbps'

2021-05-29 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yu-Kuai/drm-amd-display-fix-gcc-set-but-not-used-warning-of-variable-link_bandwidth_kbps/20210529-172249 base:3e029760e6f8ce90c122c267a039ae73b3f1f5a4 config: ia64-allmodconfig

[PATCH v3 4/5] drm: rockchip: add alpha support for RK3036, RK3066, RK3126 and RK3188

2021-05-29 Thread Alex Bee
With commit 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") alpha support was introduced for PX30's VOP. RK3036, RK3066, RK3126 and RK3188 VOPs support alpha blending in the same manner. With the exception of RK3066 all of them support pre-multiplied alpha.

[PATCH v4 1/2] drm/sun4i: Add mode_set callback to the engine

2021-05-29 Thread Roman Stratiienko
Create callback to allow updating engine's registers on mode change. Signed-off-by: Roman Stratiienko Reviewed-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++ drivers/gpu/drm/sun4i/sunxi_engine.h | 12 2 files changed, 15 insertions(+) diff --git

Re: [PATCH v4 2/2] drm/sun4i: Use CRTC size instead of primary plane size as mixer frame

2021-05-29 Thread Roman Stratiienko
+CC: jernej.skra...@gmail.com пт, 28 мая 2021 г. в 23:31, Roman Stratiienko : > > Fixes corrupted display picture when primary plane isn't full-screen. > > Signed-off-by: Roman Stratiienko > --- > drivers/gpu/drm/sun4i/sun8i_mixer.c| 28 >

[PATCH v4 0/2] drm/sun4i: Set mixer frame to display size for DE2.0+

2021-05-29 Thread Roman Stratiienko
This patchset fixes corrupted display picture when primary plane isn't full-screen. Please review/merge. v2: - Split commit in 2 parts - Add Fixes line to the commit message v3: - Address review comments of v2 + removed 3 local varibles - Change 'Fixes' line v4: Resend (author's email

[PATCH v3 5/5] drm: rockchip: set alpha_en to 0 if it is not used

2021-05-29 Thread Alex Bee
alpha_en should be set to 0 if it is not used, i.e. to disable alpha blending if it was enabled before and should be disabled now. Fixes: 2aae8ed1f390 ("drm/rockchip: Add per-pixel alpha support for the PX30 VOP") Signed-off-by: Alex Bee --- Changes in v2: - capitalize "F" of "Fixes" in the

[PATCH v4 2/2] drm/sun4i: Use CRTC size instead of primary plane size as mixer frame

2021-05-29 Thread Roman Stratiienko
Fixes corrupted display picture when primary plane isn't full-screen. Signed-off-by: Roman Stratiienko --- drivers/gpu/drm/sun4i/sun8i_mixer.c| 28 drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 30 -- 2 files changed, 28 insertions(+), 30

[PATCH v3 0/5] drm: rockchip: various ports for older VOPs

2021-05-29 Thread Alex Bee
Hi list, this is v3 of a series I posted almost 1 year ago. I considered now all feedback I got at that time. It mainly ports existining functionality to older SoCs - most importantly enables alpha blending for RK3036, RK3066, RK3126 and RK3188 Note some of the patches are required to let VOP

[PATCH v3 2/5] drm: rockchip: add missing registers for RK3188

2021-05-29 Thread Alex Bee
Add dither_up, dsp_lut_en and data_blank registers to enable their respective functionality for RK3188's VOP. While at that also fix .dsp_blank register which is (only) set with BIT24 (same as RK3066) Signed-off-by: Alex Bee --- Changes in v2: - drop the not yet upstreamed dsp_data_swap and

[PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest()

2021-05-29 Thread Zhihao Cheng
In case of error, the function live_context() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...") Reported-by: Hulk Robot Signed-off-by: Zhihao Cheng ---

[PATCH] vgaarb: Call vga_arb_device_init() after PCI enumeration

2021-05-29 Thread Huacai Chen
We should call vga_arb_device_init() after PCI enumeration, otherwise it may fail to select the default VGA device. Since vga_arb_device_init() and PCI enumeration function (i.e., pcibios_init() or acpi_init()) are both wrapped by subsys_initcall(), their sequence is not assured. So, we use

[PATCH v3 1/5] drm: rockchip: add scaling for RK3036 win1

2021-05-29 Thread Alex Bee
Add the registers needed to make scaling work on RK3036's win1. Signed-off-by: Alex Bee --- Changes in v2: - rephrase commit message drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH v3 3/5] drm: rockchip: add missing registers for RK3066

2021-05-29 Thread Alex Bee
Add dither_up, dsp_lut_en and data_blank registers to enable their respective functionality for RK3066's VOP. While at that also fix .rb_swap and .format registers for all windows, which have to be set though RK3066_SYS_CTRL1 register. Also remove .scl from win1: Scaling is only supported on the

[PATCH] drm/i915/gem: Remove the repeated declaration

2021-05-29 Thread Shaokun Zhang
Function 'i915_gem_object_truncate' is declared twice, so remove the repeated declaration. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Shaokun Zhang --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH V2] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-29 Thread Yu Kuai
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yu Kuai --- changes in V2: -

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-29 Thread yukuai (C)
ping ... On 2021/05/18 20:58, Robert Foss wrote: On Tue, 18 May 2021 at 09:42, Johan Hovold wrote: On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: Hey Yu, On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: pm_runtime_get_sync will increment pm usage counter even it failed.

Re: [PATCH 0/2] cleanup patches for PM reference leak

2021-05-29 Thread yukuai (C)
ping ... On 2021/05/17 16:14, Yu Kuai wrote: Yu Kuai (2): drm/v3d: Fix PM reference leak in v3d_get_param_ioctl() drm/v3d: Fix PM reference leak in v3d_v3d_debugfs_ident() drivers/gpu/drm/v3d/v3d_debugfs.c | 4 ++-- drivers/gpu/drm/v3d/v3d_drv.c | 2 +- 2 files changed, 3

[PATCH] drm/amd/display: fix gcc set but not used warning of variable 'link_bandwidth_kbps'

2021-05-29 Thread Yu Kuai
apply_dsc_policy_for_stream() will only be used if 'CONFIG_DRM_AMD_DC_DCN' is enabled, thus the function can be declared inside the ifdefine marco. Fix gcc warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5577:11: warning: variable ‘link_bandwidth_kbps’ set but not used

[PATCH] drm/amd/display: fix gcc set but not used warning of variable 'old_plane_state'

2021-05-29 Thread Yu Kuai
define a new macro for_each_new_plane_in_state_reverse to replace for_each_oldnew_plane_in_state_reverse, so that the unused variable 'old_plane_state' can be removed. Fix gcc warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:10066:26: warning: variable ‘old_plane_state’ set