[PATCH v2 2/4] dt-bindings: vendor-prefixes: Add an entry for SKOV A/S

2021-07-13 Thread Oleksij Rempel
Add "skov" entry for the SKOV A/S: https://www.skov.com/en/ Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

[PATCH v2 0/4] Mainline imx6 based SKOV boards

2021-07-13 Thread Oleksij Rempel
changes v2: - remove unnecessary newlines. - change linux,wakeup to wakeup-source - change switch@3 unit-address to @0 - sort aliases alphabetically Mainline imx6 based DTs for SKOV A/S boards Oleksij Rempel (3): dt-bindings: display: simple: add some Logic Technologies and Multi-Inno

[PATCH v2 1/4] dt-bindings: display: simple: add some Logic Technologies and Multi-Inno panels

2021-07-13 Thread Oleksij Rempel
Add Logictechno and Multi-Inno panels: - Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module - Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch Module - Multi-Inno Technology Co.,Ltd MI1010AIT-1CP 10.1" 1280x800 LVDS IPS Cap Touch Mod. Signed-off-by:

[PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-07-13 Thread Oleksij Rempel
From: Sam Ravnborg Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. Signed-off-by: Sam Ravnborg Signed-off-by: Søren Andersen Signed-off-by: Juergen Borleis Signed-off-by: Ulrich Ölmann Signed-off-by: Michael Grzeschik Signed-off-by: Marco Felsch Signed-off-by: Lucas Stach

[PATCH v2 3/4] dt-bindings: arm: fsl: add SKOV imx6q and imx6dl based boards

2021-07-13 Thread Oleksij Rempel
Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. Signed-off-by: Oleksij Rempel --- Documentation/devicetree/bindings/arm/fsl.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index

[PATCH 4/4] drm/vmwgfx: Use 2.19 version number to recognize mks-stats ioctls

2021-07-13 Thread Zack Rusin
"vmwgfx" -#define VMWGFX_DRIVER_DATE "20210218" +#define VMWGFX_DRIVER_DATE "20210713" #define VMWGFX_DRIVER_MAJOR 2 -#define VMWGFX_DRIVER_MINOR 18 -#define VMWGFX_DRIVER_PATCHLEVEL 1 +#define VMWGFX_DRIVER_MINOR 19 +#define VMWGFX_DRIVER_PATCHLEVEL 0 #define VMWG

[PATCH 2/4] drm/vmwgfx: Switch to using DRM_IOCTL_DEF_DRV

2021-07-13 Thread Zack Rusin
The macro has been accounting for DRM_COMMAND_BASE for a long time now so there's no reason to still be duplicating it. Plus we were leaving the name undefined which meant that all the DRM ioctl warnings/errors were always listing "null" ioctl at the culprit. This fixes the undefined ioctl name

[PATCH 1/4] drm/vmwgfx: Add support for CursorMob and CursorBypass 4

2021-07-13 Thread Zack Rusin
From: Martin Krastev * Add support for CursorMob * Add support for CursorBypass 4 Reviewed-by: Zack Rusin Signed-off-by: Martin Krastev Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 45 +++- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 6 +++

[PATCH 3/4] drm/vmwgfx: Be a lot more flexible with MOB limits

2021-07-13 Thread Zack Rusin
The code was trying to keep a strict limit on the amount of mob memory that was used in the guest by making it match the host settings. There's technically no reason to do that (guests can certainly use more than the host can have resident in renderers at the same time). In particular this is

Re: [PATCH v1 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards

2021-07-13 Thread Shawn Guo
On Wed, Jun 09, 2021 at 02:10:50PM +0200, Oleksij Rempel wrote: > From: Sam Ravnborg > > Add SKOV imx6q/dl LT2, LT6 and mi1010ait-1cp1 boards. > > Signed-off-by: Sam Ravnborg > Signed-off-by: Søren Andersen > Signed-off-by: Juergen Borleis > Signed-off-by: Ulrich Ölmann > Signed-off-by:

Re: [PATCH 06/16] drm/i915/guc/slpc: Allocate, initialize and release slpc

2021-07-13 Thread Belgaumkar, Vinay
On 7/10/2021 9:05 AM, Michal Wajdeczko wrote: On 10.07.2021 03:20, Vinay Belgaumkar wrote: Allocate data structures for SLPC and functions for initializing on host side. Signed-off-by: Vinay Belgaumkar Signed-off-by: Sundaresan Sujaritha --- drivers/gpu/drm/i915/gt/uc/intel_guc.c

Re: [PATCH v2 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-13 Thread Andy Yan
Hi Alex: On 7/13/21 7:40 PM, Alex Bee wrote: Hi Benjamin, Am 07.07.21 um 14:03 schrieb Benjamin Gaignard: Add a new dw_hdmi_plat_data struct and new compatible for rk3568. This version of the HDMI hardware block need two clocks to provide phy reference clock: hclk_vio and hclk.

Re: [PATCH 05/16] drm/i915/guc/slpc: Adding slpc communication interfaces

2021-07-13 Thread Belgaumkar, Vinay
On 7/10/2021 8:52 AM, Michal Wajdeczko wrote: On 10.07.2021 03:20, Vinay Belgaumkar wrote: Replicate the SLPC header file in GuC for the most part. There are what you mean by "replicate" here? some SLPC mode based parameters which haven't been included since we are not using them.

Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure

2021-07-13 Thread khsieh
On 2021-07-07 01:37, Jani Nikula wrote: On Tue, 06 Jul 2021, Kuogee Hsieh wrote: From: Rajkumar Subbiah Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") added some debug code for sideband message tracing. But it seems to have unintentionally changed the

Re: [PATCH v9 1/4] dt-bindings:drm/bridge:anx7625:add vendor define flags

2021-07-13 Thread Rob Herring
On Wed, Jul 07, 2021 at 03:30:51PM +0800, Xin Ji wrote: > On Thu, Jun 24, 2021 at 01:57:22PM +0200, Robert Foss wrote: > > Hey Xin, > > > > I would like to merge this series now, but this patch needs a review > > first. Maybe Laurent/Rob Herring are good candidates. > > > > > > Rob. > Hi Rob, I

[PATCH v4 4/4] drm/vgem: use shmem helpers

2021-07-13 Thread Daniel Vetter
Aside from deleting lots of code the real motivation here is to switch the mmap over to VM_PFNMAP, to be more consistent with what real gpu drivers do. They're all VM_PFNMP, which means get_user_pages doesn't work, and even if you try and there's a struct page behind that, touching it and mucking

[PATCH v4 1/4] dma-buf: Require VM_PFNMAP vma for mmap

2021-07-13 Thread Daniel Vetter
tldr; DMA buffers aren't normal memory, expecting that you can use them like that (like calling get_user_pages works, or that they're accounting like any other normal memory) cannot be guaranteed. Since some userspace only runs on integrated devices, where all buffers are actually all resident

[PATCH v4 3/4] drm/shmem-helpers: Allocate wc pages on x86

2021-07-13 Thread Daniel Vetter
intel-gfx-ci realized that something is not quite coherent anymore on some platforms for our i915+vgem tests, when I tried to switch vgem over to shmem helpers. After lots of head-scratching I realized that I've removed calls to drm_clflush. And we need those. To make this a bit cleaner use the

[PATCH v4 2/4] drm/shmem-helper: Switch to vmf_insert_pfn

2021-07-13 Thread Daniel Vetter
We want to stop gup, which isn't the case if we use vmf_insert_page and VM_MIXEDMAP, because that does not set pte_special. v2: With this shmem gem helpers now definitely need CONFIG_MMU (0day) v3: add more depends on MMU. For usb drivers this is a bit awkward, but really it's correct: To be

[PATCH v4 0/4] shmem helpers for vgem

2021-07-13 Thread Daniel Vetter
Hi all I've found another potential issue, so lets try this again and see what intel-gfx-ci says. Also Thomas tried to unify vgem more, which motivated me to dig this all out again. Test-with: 20210527140732.5762-1-daniel.vet...@ffwll.ch Review very much welcome, as always! Cheers, Daniel

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-07-13 Thread Ville Syrjälä
On Tue, Jul 13, 2021 at 09:59:18PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter wrote: > > > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > > wrote: > > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > > From: Ville Syrjälä > > > > > > > > The

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

2021-07-13 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 10:11 AM Daniel Vetter wrote: > > We kinda left this out, and I like the wording from the drm-intel > side, so add that. Motivated by a discussion with Christian. > > Cc: Christian König > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann >

Re: [PATCH] drm/fb-helper: Try to protect cleanup against delayed setup

2021-07-13 Thread Sam Ravnborg
Hi Daniel, On Tue, Jul 13, 2021 at 03:59:22PM +0200, Daniel Vetter wrote: > Some vague evidences suggests this can go wrong. Try to prevent it by > holding the right mutex and clearing ->deferred_setup to make sure we > later on don't accidentally try to re-register the fbdev when the > driver

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-07-13 Thread Rodrigo Vivi
On Tue, Jul 13, 2021 at 09:59:18PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter wrote: > > > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > > wrote: > > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > > From: Ville Syrjälä > > > > > > > > The

Re: [PATCH v1 1/1] drm: bridge: Mark mode_fixup deprecated

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 9:33 PM Sam Ravnborg wrote: > > Make it obvious that mode_fixup is deprecated and new drivers shall use > atomic_check. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Andrzej Hajda > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann >

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter wrote: > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > wrote: > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > From: Ville Syrjälä > > > > > > The conversion to ww mutexes failed to address the fence code which > > > already returns

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-07-13 Thread Daniel Vetter
On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst wrote: > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > The conversion to ww mutexes failed to address the fence code which > > already returns -EDEADLK when we run out of fences. Ww mutexes on > > the other hand

Re: [PATCH] video: fbdev: kyrofb: fix a DoS bug by restricting user input

2021-07-13 Thread Sam Ravnborg
Hi On Tue, Jul 13, 2021 at 12:51:14PM +, Zheyu Ma wrote: > The user can pass in any value to the driver through the 'ioctl' > interface. The driver dost not check, which may cause DoS bugs. > > Fix this by checking if the divisor is 0 This fix is trying to avoid the situation on a too low

Re: [RFC] drm: return int error code from mode_fixup

2021-07-13 Thread Sam Ravnborg
On Tue, Jul 13, 2021 at 07:44:12PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 7:14 PM Grace An wrote: > > When CONFIG_PROVE_LOCKING is defined, the kernel randomly injects > > -EDEADLK errors for all the ww_mutex. This results in > > drm_atomic_get_private_obj_state randomly returning

[PATCH v1 1/1] drm: bridge: Mark mode_fixup deprecated

2021-07-13 Thread Sam Ravnborg
Make it obvious that mode_fixup is deprecated and new drivers shall use atomic_check. Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Andrzej Hajda Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- include/drm/drm_bridge.h | 3 +++

[PATCH V2] video: backlight: Drop maximum brightness override for brightness zero

2021-07-13 Thread Marek Vasut
The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") says that gpio-backlight uses brightness as power state. This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: Correct initial power state handling") and other backlight drivers do not

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Ville Syrjälä
On Tue, Jul 13, 2021 at 07:24:23PM +0100, Matthew Auld wrote: > On Tue, 13 Jul 2021 at 18:47, Ville Syrjälä > wrote: > > > > On Tue, Jul 13, 2021 at 05:13:37PM +0100, Matthew Auld wrote: > > > On Tue, 13 Jul 2021 at 16:55, Ville Syrjälä > > > wrote: > > > > > > > > On Tue, Jul 13, 2021 at

Re: [PATCH 21/47] drm/i915/guc: Ensure G2H response has space in buffer

2021-07-13 Thread John Harrison
On 6/24/2021 00:04, Matthew Brost wrote: Ensure G2H response has space in the buffer before sending H2G CTB as the GuC can't handle any backpressure on the G2H interface. Signed-off-by: John Harrison Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 13 +++-

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Matthew Auld
On Tue, 13 Jul 2021 at 18:47, Ville Syrjälä wrote: > > On Tue, Jul 13, 2021 at 05:13:37PM +0100, Matthew Auld wrote: > > On Tue, 13 Jul 2021 at 16:55, Ville Syrjälä > > wrote: > > > > > > On Tue, Jul 13, 2021 at 11:45:50AM +0100, Matthew Auld wrote: > > > > + /** > > > > + *

Re: [PATCH v3 3/5] drm/i915/uapi: reject caching ioctls for discrete

2021-07-13 Thread Kenneth Graunke
On Monday, July 5, 2021 6:53:08 AM PDT Matthew Auld wrote: > It's a noop on DG1, and in the future when need to support other devices > which let us control the coherency, then it should be an immutable > creation time property for the BO. This will likely be controlled > through a new

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Ville Syrjälä
On Tue, Jul 13, 2021 at 05:13:37PM +0100, Matthew Auld wrote: > On Tue, 13 Jul 2021 at 16:55, Ville Syrjälä > wrote: > > > > On Tue, Jul 13, 2021 at 11:45:50AM +0100, Matthew Auld wrote: > > > + /** > > > + * @cache_coherent: > > > + * > > > + * Track whether the pages are

Re: [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 7:42 PM Rob Clark wrote: > On Tue, Jul 13, 2021 at 9:58 AM Daniel Vetter wrote: > > > > On Tue, Jul 13, 2021 at 6:51 PM Rob Clark wrote: > > > > > > On Mon, Jul 12, 2021 at 1:02 PM Daniel Vetter > > > wrote: > > > > > > > > There's only one exclusive slot, and we must

Re: [RFC] drm: return int error code from mode_fixup

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 7:14 PM Grace An wrote: > When CONFIG_PROVE_LOCKING is defined, the kernel randomly injects > -EDEADLK errors for all the ww_mutex. This results in > drm_atomic_get_private_obj_state randomly returning -EDEADLK. > However, the mode_fixup functions do not propagate these

Re: [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering

2021-07-13 Thread Rob Clark
On Tue, Jul 13, 2021 at 9:58 AM Daniel Vetter wrote: > > On Tue, Jul 13, 2021 at 6:51 PM Rob Clark wrote: > > > > On Mon, Jul 12, 2021 at 1:02 PM Daniel Vetter > > wrote: > > > > > > There's only one exclusive slot, and we must not break the ordering. > > > > > > Adding a new exclusive fence

Re: [PATCH v3 0/2] allow simple{fb, drm} drivers to be used on non-x86 EFI platforms

2021-07-13 Thread Javier Martinez Canillas
On 6/25/21 3:09 PM, Javier Martinez Canillas wrote: > The simplefb and simpledrm drivers match against a "simple-framebuffer" > device, but for aarch64 this is only registered when using Device Trees > and there's a node with a "simple-framebuffer" compatible string. > > There is no code to

Re: [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 6:51 PM Rob Clark wrote: > > On Mon, Jul 12, 2021 at 1:02 PM Daniel Vetter wrote: > > > > There's only one exclusive slot, and we must not break the ordering. > > > > Adding a new exclusive fence drops all previous fences from the > > dma_resv. To avoid violating the

Re: [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering

2021-07-13 Thread Rob Clark
On Mon, Jul 12, 2021 at 1:02 PM Daniel Vetter wrote: > > There's only one exclusive slot, and we must not break the ordering. > > Adding a new exclusive fence drops all previous fences from the > dma_resv. To avoid violating the signalling order we err on the side of > over-synchronizing by

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 6:14 PM Matthew Auld wrote: > On Tue, 13 Jul 2021 at 16:55, Ville Syrjälä > wrote: > > > > On Tue, Jul 13, 2021 at 11:45:50AM +0100, Matthew Auld wrote: > > > + /** > > > + * @cache_coherent: > > > + * > > > + * Track whether the pages are coherent with

Re: [PATCH] drm/stm: dsi: compute the transition time from LP to HS and back

2021-07-13 Thread Philippe CORNU
Hi Antonio, On 7/13/21 4:49 PM, Antonio Borneo wrote: The driver uses a conservative set of hardcoded values for the maximum time delay of the transitions between LP and HS, either for data and clock lanes. By using the info in STM32MP157 datasheet, valid also for other ST devices, compute the

Re: [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 6:11 PM Andrey Grodzovsky wrote: > On 2021-07-13 5:10 a.m., Daniel Vetter wrote: > > On Tue, Jul 13, 2021 at 9:25 AM Christian König > > wrote: > >> Am 13.07.21 um 08:50 schrieb Daniel Vetter: > >>> On Tue, Jul 13, 2021 at 8:35 AM Christian König > >>> wrote: > Am

Re: [PATCH] drm/stm: ltdc: Silence -EPROBE_DEFER till bridge attached

2021-07-13 Thread Philippe CORNU
Hi Jagan, On 7/4/21 3:59 PM, Jagan Teki wrote: As dw-mipi-dsi supported all possible ways to find the DSI devices. It can take multiple iterations for ltdc to find all components attached to the DSI bridge. The current ltdc driver failed to find the endpoint as it returned -EINVAL for the

Re: [Freedreno] [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-07-13 Thread Rob Clark
On Tue, Jun 29, 2021 at 12:04 PM Abhinav Kumar wrote: > > During board bringups its useful to have a DSI test pattern > generator to isolate a DPU vs a DSI issue and focus on the relevant > hardware block. > > To facilitate this, add an API which triggers the DSI controller > test pattern. The

[PATCH] drm/stm: dsi: compute the transition time from LP to HS and back

2021-07-13 Thread Antonio Borneo
The driver uses a conservative set of hardcoded values for the maximum time delay of the transitions between LP and HS, either for data and clock lanes. By using the info in STM32MP157 datasheet, valid also for other ST devices, compute the actual delay from the lane's bps. Signed-off-by:

[PATCH] video: fbdev: kyrofb: fix a DoS bug by restricting user input

2021-07-13 Thread Zheyu Ma
The user can pass in any value to the driver through the 'ioctl' interface. The driver dost not check, which may cause DoS bugs. Fix this by checking if the divisor is 0 The following log reveals it: divide error: [#1] PREEMPT SMP KASAN PTI RIP: 0010:SetOverlayViewPort+0x133/0x5f0

Re: [PATCH v2 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-13 Thread Alex Bee
Hi Benjamin, Am 07.07.21 um 14:03 schrieb Benjamin Gaignard: Add a new dw_hdmi_plat_data struct and new compatible for rk3568. This version of the HDMI hardware block need two clocks to provide phy reference clock: hclk_vio and hclk. Signed-off-by: Benjamin Gaignard --- version 2: - Add the

[Bug 213715] failed to change brightness of HDR panel on AMD GREEN_SARDINE through aux

2021-07-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213715 --- Comment #1 from Pengyu Ma (mapen...@gmail.com) --- Created attachment 297821 --> https://bugzilla.kernel.org/attachment.cgi?id=297821=edit 4k display edid -- You may reply to this email to add a comment. You are receiving this mail

[Bug 213715] New: failed to change brightness of HDR panel on AMD GREEN_SARDINE through aux

2021-07-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213715 Bug ID: 213715 Summary: failed to change brightness of HDR panel on AMD GREEN_SARDINE through aux Product: Drivers Version: 2.5 Kernel Version: 5.14.0-rc1+ Hardware:

Re: [PATCH] drm/of: free the iterator object on failure

2021-07-13 Thread Steven Price
On 12/07/2021 22:55, Laurent Pinchart wrote: > Hi Steven, Hi Laurent, > On Mon, Jul 12, 2021 at 10:31:52PM +0100, Steven Price wrote: >> On 12/07/2021 17:50, Laurent Pinchart wrote: >>> On Mon, Jul 12, 2021 at 04:57:58PM +0100, Steven Price wrote: When bailing out due to the sanity check

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Matthew Auld
On Tue, 13 Jul 2021 at 16:55, Ville Syrjälä wrote: > > On Tue, Jul 13, 2021 at 11:45:50AM +0100, Matthew Auld wrote: > > + /** > > + * @cache_coherent: > > + * > > + * Track whether the pages are coherent with the GPU if reading or > > + * writing through the CPU cache. >

Re: [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-13 Thread Andrey Grodzovsky
On 2021-07-13 5:10 a.m., Daniel Vetter wrote: On Tue, Jul 13, 2021 at 9:25 AM Christian König wrote: Am 13.07.21 um 08:50 schrieb Daniel Vetter: On Tue, Jul 13, 2021 at 8:35 AM Christian König wrote: Am 12.07.21 um 19:53 schrieb Daniel Vetter: It might be good enough on x86 with just

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Ville Syrjälä
On Tue, Jul 13, 2021 at 11:45:50AM +0100, Matthew Auld wrote: > + /** > + * @cache_coherent: > + * > + * Track whether the pages are coherent with the GPU if reading or > + * writing through the CPU cache. > + * > + * This largely depends on the @cache_level, for

[PATCH v2 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-13 Thread Kuogee Hsieh
Main link symbol locked is achieved at end of link training 2. Some dongle main link symbol may become unlocked again if host did not end link training soon enough after completion of link training 2. Host have to re train main link if loss of symbol lock detected before end link training so that

[PATCH v2 6/7] drm/msm/dp: do not end dp link training until video is ready

2021-07-13 Thread Kuogee Hsieh
Initialize both pre-emphasis and voltage swing level to 0 before start link training and do not end link training until video is ready to reduce the period between end of link training and video start to meet Link Layer CTS requirement. This fixes Link Layer CTS cases 4.3.2.1, 4.3.2.2, 4.3.2.3

[PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-13 Thread Kuogee Hsieh
Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-07-13 Thread Kuogee Hsieh
Aux hardware calibration sequence requires resetting the aux controller in order for the new setting to take effect. However resetting the AUX controller will also clear HPD interrupt status which may accidentally cause pending unplug interrupt to get lost. Therefore reset aux controller only when

[PATCH v2 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-07-13 Thread Kuogee Hsieh
Remove special handling of replug interrupt and instead treat replug event as a sequential unplug followed by a plugin event. This is needed to meet the requirements of DP Link Layer CTS test case 4.2.1.3. Changes in V2: -- add fixes statement Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd

[PATCH v2 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-13 Thread Kuogee Hsieh
Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link training started to fix Link Layer CTS case 4.3.1.6. Changes in V2: -- replaced cr_status

[PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-07-13 Thread Kuogee Hsieh
DP cable should always connect to DPU during the entire PHY compliance testing run. Since DP PHY compliance test is executed at irq_hpd event context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). dp_ctrl_off() is used for unplug event which is triggered when DP cable is dis

[PATCH v2 0/7] add fixes to pass DP Link Layer compliance test cases

2021-07-13 Thread Kuogee Hsieh
add fixes to pass DP Link Layer compliance test cases Kuogee Hsieh (7): drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run drm/msm/dp: reduce link rate if failed at link training 1 drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed. drm/msm/dp: replug

Re: [PATCH v3] backlight: ktd253: Stabilize backlight

2021-07-13 Thread Linus Walleij
On Fri, Jun 4, 2021 at 8:34 AM Linus Walleij wrote: > Remove interrupt disablement during backlight setting. It is > way to dangerous and makes platforms instable by having it > miss vblank IRQs leading to the graphics derailing. > > The code is using ndelay() which is not available on >

Re: [PATCH v3 1/1] drm/ttm: Fix COW check

2021-07-13 Thread Felix Kuehling
Am 2021-07-13 um 2:57 a.m. schrieb Christian König: > > > Am 13.07.21 um 00:06 schrieb Felix Kuehling: >> KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. >> is_cow_mapping returns true for these mappings. Add a check for >> vm_flags & VM_WRITE to avoid mmap failures on private

Re: [PATCH v3 1/1] drm/ttm: Fix COW check

2021-07-13 Thread Alex Deucher
On Tue, Jul 13, 2021 at 2:57 AM Christian König wrote: > > > > Am 13.07.21 um 00:06 schrieb Felix Kuehling: > > KFD Thunk maps invisible VRAM BOs with PROT_NONE, MAP_PRIVATE. > > is_cow_mapping returns true for these mappings. Add a check for > > vm_flags & VM_WRITE to avoid mmap failures on

Re: [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf attach time (v5)

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 04:06:13PM +0100, Matthew Auld wrote: > On Tue, 13 Jul 2021 at 15:44, Daniel Vetter wrote: > > > > On Mon, Jul 12, 2021 at 06:12:34PM -0500, Jason Ekstrand wrote: > > > From: Thomas Hellström > > > > > > Until we support p2p dma or as a complement to that, migrate data >

Re: [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf attach time (v5)

2021-07-13 Thread Matthew Auld
On Tue, 13 Jul 2021 at 15:44, Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 06:12:34PM -0500, Jason Ekstrand wrote: > > From: Thomas Hellström > > > > Until we support p2p dma or as a complement to that, migrate data > > to system memory at dma-buf attach time if possible. > > > > v2: > > -

Re: [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf attach time (v5)

2021-07-13 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 06:12:34PM -0500, Jason Ekstrand wrote: > From: Thomas Hellström > > Until we support p2p dma or as a complement to that, migrate data > to system memory at dma-buf attach time if possible. > > v2: > - Rebase on dynamic exporter. Update the igt_dmabuf_import_same_driver

Re: [PATCH 1/2] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v5)

2021-07-13 Thread Jason Ekstrand
On Tue, Jul 13, 2021 at 9:40 AM Daniel Vetter wrote: > > On Mon, Jul 12, 2021 at 06:12:33PM -0500, Jason Ekstrand wrote: > > From: Thomas Hellström > > > > If our exported dma-bufs are imported by another instance of our driver, > > that instance will typically have the imported dma-bufs locked

Re: [PATCH 1/2] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v5)

2021-07-13 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 06:12:33PM -0500, Jason Ekstrand wrote: > From: Thomas Hellström > > If our exported dma-bufs are imported by another instance of our driver, > that instance will typically have the imported dma-bufs locked during > dma_buf_map_attachment(). But the exporter also locks

[PATCH v2 3/4] drm/amd/display: Add control mechanism for FPU utilization

2021-07-13 Thread Rodrigo Siqueira
DC invokes DC_FPU_START/END in multiple parts of the code; this can create a situation where we invoke this FPU operation in a nested way or exit too early. For avoiding this situation, this commit adds a mechanism where dc_fpu_begin/end manages the access to kernel_fpu_begin/end. Change since

[PATCH v2 4/4] drm/amd/display: Add DC_FP helper to check FPU state

2021-07-13 Thread Rodrigo Siqueira
To fully isolate FPU operations in a single place, we must avoid situations where compilers spill FP values to registers due to FP enable in a specific C file. Note that even if we isolate all FPU functions in a single file and call its interface from other files, the compiler might enable the use

[PATCH v2 2/4] drm/amd/display: Add FPU event trace

2021-07-13 Thread Rodrigo Siqueira
We don't have any mechanism for tracing FPU operations inside the display core, making the debug work a little bit tricky. This commit introduces a trace mechanism inside our DC_FP_START/END macros for trying to alleviate this problem. Signed-off-by: Rodrigo Siqueira ---

[PATCH v2 1/4] drm/amd/display: Introduce FPU directory inside DC

2021-07-13 Thread Rodrigo Siqueira
The display core files rely on FPU operation, which requires to be compiled with special flags. Ideally, we don't want these FPU operations spread around the DC code; nevertheless, it happens in the current source. This commit introduces a new directory named fpu_operations that intends to

[PATCH v2 0/4] drm/amd/display: Base changes for isolating FPU operation in a single place

2021-07-13 Thread Rodrigo Siqueira
Hi, In the display core, we utilize floats and doubles units for calculating modesetting parameters. One side effect of our approach to use double-precision is the fact that we spread multiple FPU access across our driver, which means that we can accidentally clobber user space FPU state. #

[PATCH v2] gpu: ipu-v3: use swap()

2021-07-13 Thread Salah Triki
Use swap() instead of implementing it since it makes code cleaner. Signed-off-by: Salah Triki --- Changes since v1: - Remove the declaration of tmp - Fix typo in the description drivers/gpu/ipu-v3/ipu-image-convert.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH] drm/fb-helper: Try to protect cleanup against delayed setup

2021-07-13 Thread Daniel Vetter
Some vague evidences suggests this can go wrong. Try to prevent it by holding the right mutex and clearing ->deferred_setup to make sure we later on don't accidentally try to re-register the fbdev when the driver thought it had it all cleaned up already. v2: I realized that this is fundamentally

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-13 Thread Harry Wentland
On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: > On Mon, 12 Jul 2021 12:15:59 -0400 > Harry Wentland wrote: > >> On 2021-07-12 4:03 a.m., Pekka Paalanen wrote: >>> On Fri, 9 Jul 2021 18:23:26 +0200 >>> Raphael Gallais-Pou wrote: >>> On 7/9/21 10:04 AM, Pekka Paalanen wrote: >

Re: [PATCH] gpu: ipu-v3: use swap()

2021-07-13 Thread Fabio Estevam
Hi Salah, On Tue, Jul 13, 2021 at 10:33 AM Salah Triki wrote: > > Use swap() instead of implementing it since it makes code more clean. s/more clean/cleaner > Signed-off-by: Salah Triki > --- > drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++- > 1 file changed, 2 insertions(+), 5

Re: [PULL] drm-misc-fixes

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 10:44:05AM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > these two fixes in drm-misc-fixes got lost during last cycle. Sending them > now. Applied to drm-fixes, thanks. -Daniel > > Best regards > Thomas > > drm-misc-fixes-2021-07-13: > Short summary of

Re: [PATCH] drm/shmem-helper: Switch to vmf_insert_pfn

2021-07-13 Thread Daniel Vetter
On Thu, Jun 03, 2021 at 11:08:31PM +0200, Daniel Vetter wrote: > We want to stop gup, which isn't the case if we use vmf_insert_page > and VM_MIXEDMAP, because that does not set pte_special. > > v2: With this shmem gem helpers now definitely need CONFIG_MMU (0day) > > v3: add more depends on

Re: [PATCH v2] drm/dp: Move panel DP AUX backlight support to drm_dp_helper

2021-07-13 Thread Doug Anderson
Hi, On Mon, Jul 12, 2021 at 8:02 AM Douglas Anderson wrote: > > We were getting a depmod error: > depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper > > It looks like the rule is that drm_kms_helper can call into drm, but > drm can't call into drm_kms_helper. That means

Re: [PATCH] drm/i915/gtt: drop the page table optimisation

2021-07-13 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 02:04:31PM +0100, Matthew Auld wrote: > We skip filling out the pt with scratch entries if the va range covers > the entire pt, since we later have to fill it with the PTEs for the > object pages anyway. However this might leave open a small window where > the PTEs don't

[PATCH] gpu: ipu-v3: use swap()

2021-07-13 Thread Salah Triki
Use swap() instead of implementing it since it makes code more clean. Signed-off-by: Salah Triki --- drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c

Re: [PATCH] use swap()

2021-07-13 Thread Alex Deucher
On Tue, Jul 13, 2021 at 3:09 AM Salah Triki wrote: > > Use swap() instead of implementing it since it makes code more clean. > > Signed-off-by: Salah Triki Patches for this driver generally have the following prefix in the subject: gpu: ipu-v3: Alex > --- >

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

2021-07-13 Thread Thomas Zimmermann
Am 09.07.21 um 10:11 schrieb Daniel Vetter: We kinda left this out, and I like the wording from the drm-intel side, so add that. Motivated by a discussion with Christian. I always thought this goes without saying. Cc: Christian König Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

[PATCH] drm/i915/gtt: drop the page table optimisation

2021-07-13 Thread Matthew Auld
We skip filling out the pt with scratch entries if the va range covers the entire pt, since we later have to fill it with the PTEs for the object pages anyway. However this might leave open a small window where the PTEs don't point to anything valid for the HW to consume. When for example using

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Mika Kuoppala
Matthew Auld writes: > Try to document the object caching related bits, like cache_coherent and > cache_dirty. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > --- > .../gpu/drm/i915/gem/i915_gem_object_types.h | 135 +- > drivers/gpu/drm/i915/i915_drv.h

Re: [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled

2021-07-13 Thread Christian König
Am 13.07.21 um 11:10 schrieb Daniel Vetter: On Tue, Jul 13, 2021 at 9:25 AM Christian König wrote: Am 13.07.21 um 08:50 schrieb Daniel Vetter: On Tue, Jul 13, 2021 at 8:35 AM Christian König wrote: Am 12.07.21 um 19:53 schrieb Daniel Vetter: It might be good enough on x86 with just

Re: [PATCH 1/1] fbmem: Do not delete the mode that is still in use

2021-07-13 Thread Daniel Vetter
On Mon, Jul 12, 2021 at 4:37 PM Daniel Vetter wrote: > On Mon, Jul 12, 2021 at 04:55:44PM +0800, Zhen Lei wrote: > > The execution of fb_delete_videomode() is not based on the result of the > > previous fbcon_mode_deleted(). As a result, the mode is directly deleted, > > regardless of whether it

[PATCH 4/5] drm/i915: pull in some more kernel-doc

2021-07-13 Thread Matthew Auld
Pull in the kernel-doc for drm_i915_gem_object. Signed-off-by: Matthew Auld Cc: Daniel Vetter --- Documentation/gpu/i915.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 204ebdaadb45..77558084e989 100644 ---

[PATCH 2/5] drm/i915/uapi: convert drm_i915_gem_madvise to kernel-doc

2021-07-13 Thread Matthew Auld
Add some kernel doc for this. We can then just reference this later when documenting madv in the kernel. Signed-off-by: Matthew Auld Cc: Daniel Vetter --- include/uapi/drm/i915_drm.h | 50 +++-- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git

[PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Matthew Auld
Try to document the object caching related bits, like cache_coherent and cache_dirty. Suggested-by: Daniel Vetter Signed-off-by: Matthew Auld --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 135 +- drivers/gpu/drm/i915/i915_drv.h | 9 -- 2 files changed, 131

[PATCH 5/5] drm/i915/ehl: unconditionally flush the pages on acquire

2021-07-13 Thread Matthew Auld
EHL and JSL add the 'Bypass LLC' MOCS entry, which should make it possible for userspace to bypass the GTT caching bits set by the kernel, as per the given object cache_level. This is troublesome since the heavy flush we apply when first acquiring the pages is skipped if the kernel thinks the

[PATCH 3/5] drm/i915: convert drm_i915_gem_object to kernel-doc

2021-07-13 Thread Matthew Auld
Before we can pull in the previous kernel doc for the caching bits, we first get to add kernel doc for all of drm_i915_gem_object so this actually builds. Signed-off-by: Matthew Auld Cc: Daniel Vetter --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 422 +++--- 1 file changed,

Re: [PATCH v2 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-13 Thread Robin Murphy
On 2021-07-07 13:03, Benjamin Gaignard wrote: Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Do you know what hclk_vio is and whether it's actually necessary? I don't see any mention of it

Re: [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-07-13 Thread Marijn Suijten
On 6/29/21 9:04 PM, Abhinav Kumar wrote: During board bringups its useful to have a DSI test pattern generator to isolate a DPU vs a DSI issue and focus on the relevant hardware block. To facilitate this, add an API which triggers the DSI controller test pattern. The expected output is a

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more gentle with exiting non-persistent context

2021-07-13 Thread Tvrtko Ursulin
Ping for any reviewers? This fixes a customer issue on heavily loaded transcode boxes by avoiding false GPU hang reports upon pressing Ctrl-C. Regards, Tvrtko On 16/06/2021 11:09, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When a non-persistent context exits we currently mark it as

  1   2   >