Re: [PATCH 02/30] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-24 Thread Lucas De Marchi
On Sat, Jul 24, 2021 at 06:41:21PM +0100, Christoph Hellwig wrote: Still tests fine: Tested-by: Christoph Hellwig I just pushed this to drm-intel-next as part of another series and added your Tested-by. Rodrigo, can you pick this up for -fixes? This should go with your other patch to fix

[PATCH 4/4] drm/msm/dp: Add sc8180x DP controllers

2021-07-24 Thread Bjorn Andersson
The sc8180x has 2 DP and 1 eDP controllers, add support for these to the DP driver. Link: https://lore.kernel.org/linux-arm-msm/20210511042043.592802-5-bjorn.anders...@linaro.org/ Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 12 1 file changed, 12

[PATCH 5/5] drm/msm/dp: Add sc8180x DP controllers

2021-07-24 Thread Bjorn Andersson
The sc8180x has 2 DP and 1 eDP controllers, add support for these to the DP driver. Link: https://lore.kernel.org/linux-arm-msm/20210511042043.592802-5-bjorn.anders...@linaro.org/ Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 12 1 file changed, 12

[PATCH 4/5] dt-bindings: msm/dp: Add SC8180x compatibles

2021-07-24 Thread Bjorn Andersson
The Qualcomm SC8180x has 2 DP controllers and 1 eDP controller, add compatibles for these to the msm/dp binding. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/display/msm/dp-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/5] drm/msm/dp: Remove global g_dp_display variable

2021-07-24 Thread Bjorn Andersson
As the Qualcomm DisplayPort driver only supports a single instance of the driver the commonly used struct dp_display is kept in a global variable. As we introduce additional instances this obviously doesn't work. Replace this with a combination of existing references to adjacent objects and

[PATCH 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-07-24 Thread Bjorn Andersson
Based on the removal of the g_dp_display and the movement of the priv->dp lookup into the DP code it's now possible to have multiple DP instances. In line with the other controllers in the MSM driver, introduce a per-compatible list of base addresses which is used to resolve the "instance id" for

[PATCH 2/5] drm/msm/dp: Modify prototype of encoder based API

2021-07-24 Thread Bjorn Andersson
Functions in the DisplayPort code that relates to individual instances (encoders) are passed both the struct msm_dp and the struct drm_encoder. But in a situation where multiple DP instances would exist this means that the caller need to resolve which struct msm_dp relates to the struct

[PATCH 0/5] drm/msm/dp: Support multiple DP instances and add sc8180x

2021-07-24 Thread Bjorn Andersson
The current implementation supports a single DP instance and the DPU code will only match it against INTF_DP instance 0. These patches extends this to allow multiple DP instances and support for matching against DP instances beyond 0. This is based on v4 of Dmitry's work on multiple DSI

Re: [PATCH v4 7/7] drm/msm/kms: drop set_encoder_mode callback

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > set_encoder_mode callback is completely unused now. Drop it from > msm_kms_func(). > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/msm_kms.h | 3

Re: [PATCH v4 6/7] drm/msm/dsi: stop calling set_encoder_mode callback

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- >

Re: [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- >

Re: [PATCH v4 4/7] drm/msm/mdp5: move mdp5_encoder_set_intf_mode after msm_dsi_modeset_init

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > Move a call to mdp5_encoder_set_intf_mode() after > msm_dsi_modeset_init(), removing set_encoder_mode callback. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- >

Re: [PATCH v4 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > Move setting up encoders from set_encoder_mode to > _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This > allows us to support not only "single DSI" and "bonded DSI" but also "two > independent DSI" configurations. In future

Re: [PATCH v4 2/7] drm/msm/dsi: add three helper functions

2021-07-24 Thread Bjorn Andersson
On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > Add three helper functions to be used by display drivers for setting up > encoders. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dsi/dsi.c | 7 +++ >

Re: [PATCH 09/10] drm/i915: move vma slab to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

[RFC PATCH] drm/i915: slab_vmas can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/i915_vma.c:41:19: warning: symbol 'slab_vmas' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- i915_vma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c

[PATCH] drm: msm: Add 680 gpu to the adreno gpu list

2021-07-24 Thread Bjorn Andersson
This patch adds a Adreno 680 entry to the gpulist. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 +++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 12 +++- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 2 +-

Re: [PATCH 09/14] drm/i915/guc/slpc: Add debugfs for SLPC info

2021-07-24 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc2 next-20210723] [If your patch is applied to the wrong git tree,

[PATCH 3/3] video: fbdev: asiliantfb: add a check against divide error

2021-07-24 Thread Zheyu Ma
The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of 'pixclock', it may cause divide error. Fix this by checking whether 'pixclock' is zero first. The following log reveals it: [ 43.861711] divide error: [#1]

[PATCH 2/3] video: fbdev: riva: add a check against divide error

2021-07-24 Thread Zheyu Ma
The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of 'pixclock', it may cause divide error. Fix this by checking whether 'pixclock' is zero first. The following log reveals it: [ 33.396850] divide error: [#1]

[PATCH 1/3] video: fbdev: kyro: add a check against divide error

2021-07-24 Thread Zheyu Ma
The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of 'pixclock', it may cause divide error because the value of 'lineclock' and 'frameclock' will be zero. Fix this by checking whether 'pixclock' is zero in

[PATCH 0/3] add checks against divide error

2021-07-24 Thread Zheyu Ma
Zheyu Ma (3): video: fbdev: kyro: add a check against divide error video: fbdev: riva: add a check against divide error video: fbdev: asiliantfb: add a check against divide error drivers/video/fbdev/asiliantfb.c | 3 +++ drivers/video/fbdev/kyro/fbdev.c | 3 +++

Re: [PATCH 13/14] drm/mediatek: add pseudo ovl support for MT8195

2021-07-24 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年7月22日 週四 下午5:46寫道: > > Add pseudo ovl module files: My English is not good. The word 'pseudo' seems like 'looks like but indeed not the same'. I think the 'real' ovl also has rdma and mixer inside it, so I prefer to treat these two ovl as different kind of ovl, not

Re: [Intel-gfx] [PATCH 08/10] drm/i915: move scheduler slabs to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

[RFC PATCH] drm/i915: slab_dependencies can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/i915_scheduler.c:13:19: warning: symbol 'slab_dependencies' was not declared. Should it be static? drivers/gpu/drm/i915/i915_scheduler.c:14:19: warning: symbol 'slab_priorities' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel

Re: [PATCH v3, 2/3] drm/mediatek: add mt8183 aal support

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > This patch add mt8183 private data Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu

Re: [PATCH v3, 1/3] drm/mediatek: Separate aal module

2021-07-24 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2021年7月16日 週五 下午2:32寫道: > > mt8183 aal has no gamma function Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Yongqiang Niu >

Re: [Intel-gfx] [PATCH 01/33] drm/i915/guc: GuC virtual engines

2021-07-24 Thread Matthew Brost
On Fri, Jul 23, 2021 at 05:47:45PM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/22/2021 4:53 PM, Matthew Brost wrote: > > Implement GuC virtual engines. Rather simple implementation, basically > > just allocate an engine, setup context enter / exit function to virtual > > engine specific

Re: [PATCH 07/10] drm/i915: move request slabs to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

[RFC PATCH] drm/i915: slab_requests can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/i915_request.c:54:19: warning: symbol 'slab_requests' was not declared. Should it be static? drivers/gpu/drm/i915/i915_request.c:55:19: warning: symbol 'slab_execute_cbs' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot

[PATCH] drm/nouveau/kms/nv50-: use DRM_NOUVEAU_BACKLIGHT consistently

2021-07-24 Thread trix
From: Tom Rix A build error when DRM_NOUVEAU_BACKLIGHT is not defined disp.c:1665:52: error: 'struct nouveau_connector' has no member named 'backlight' Use ifdef's similar to elsewhere in disp.c to conditionally use the new backlight support. Move scope of drm to where it is used, inside the

Re: [PATCH v2 1/3] staging/fbtft: Remove all strcpy() uses

2021-07-24 Thread Andy Shevchenko
On Sat, Jul 24, 2021 at 7:05 PM Len Baker wrote: > > strcpy() performs no bounds checking on the destination buffer. This > could result in linear overflows beyond the end of the buffer, leading > to all kinds of misbehaviors. The safe replacement is strscpy() but in > this case it is simpler to

[RFC PATCH] drm/i915: slab_objects can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/gem/i915_gem_object.c:36:19: warning: symbol 'slab_objects' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- i915_gem_object.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 01/30] drm/i915: fix not reading DSC disable fuse in GLK

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:45PM -0700, Lucas De Marchi wrote: > We were using GRAPHICS_VER() to handle SKL_DFSM register, which means we > were not handling GLK correctly since that has GRAPHICS_VER == 9, but > DISPLAY_VER == 10. Switch the entire branch to check DISPLAY_VER > which makes it

Re: [PATCH 06/30] drm/i915/display: remove explicit CNL handling from intel_combo_phy.c

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:50PM -0700, Lucas De Marchi wrote: > The only real platform with DISPLAY_VER == 10 is GLK, that doesn't have > combo phys. We don't need to handle CNL explicitly in > intel_combo_phy.c. > > Remove code and rename functions/macros accordingly to use ICL prefix. > >

Re: [Intel-gfx] [PATCH 06/10] drm/i915: move gem_objects slab to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

Re: [PATCH 07/30] drm/i915/display: remove explicit CNL handling from intel_crtc.c

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:51PM -0700, Lucas De Marchi wrote: > No need for special CNL handling as there is no real platform with that > configuration. > > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- > 1 file changed, 1

Re: [PATCH 05/30] drm/i915/display: remove explicit CNL handling from intel_color.c

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:49PM -0700, Lucas De Marchi wrote: > The only real platform with DISPLAY_VER == 10 is GLK, so we don't need > any checks and supporting code for CNL. For DISPLAY_VER >= 11, > ilk_load_csc_matrix() is not used, so make it handle GLK only. > > Signed-off-by: Lucas De

Re: [PATCH 04/30] drm/i915/display: remove explicit CNL handling from intel_cdclk.c

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:48PM -0700, Lucas De Marchi wrote: > The only real platform with DISPLAY_VER == 10 is GLK, so we don't need > any checks and supporting code for CNL. Remove code and rename > functions/macros accordingly. > > Signed-off-by: Lucas De Marchi > --- >

Re: [Freedreno] [PATCH 2/2] drm/msm/a6xx: Add support for Adreno 7c Gen 3 gpu

2021-07-24 Thread Rob Clark
() On Fri, Jul 23, 2021 at 3:38 AM Akhil P Oommen wrote: > > This patch adds support for the gpu found in the Snapdragon 7c Gen 3 > compute platform. This gpu is similar to the exisiting a660 gpu with > minor delta in the programing sequence. As the Adreno GPUs are moving > away from a numeric

Re: [PATCH 03/30] drm/i915/display: remove PORT_F workaround for CNL

2021-07-24 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:47PM -0700, Lucas De Marchi wrote: > Explicit support for CNL is being removed from the driver as it's not > expected to work. Remove the workaround for PORT_F from > display/intel_bios.c so we can also remove the generic DISPLAY_VER == 10 > calls to intel_ddi_init():

Re: [PATCH v2 3/3] staging/fbtft: Fix braces coding style

2021-07-24 Thread Geert Uytterhoeven
Hi Len, On Sat, Jul 24, 2021 at 7:44 PM Len Baker wrote: > Add braces to the "for" loop and remove braces from the "if" statement. > This way the kernel coding style is followed. > > Signed-off-by: Len Baker Thanks for your patch! > --- a/drivers/staging/fbtft/fbtft-core.c > +++

[PATCH v2 3/3] staging/fbtft: Fix braces coding style

2021-07-24 Thread Len Baker
Add braces to the "for" loop and remove braces from the "if" statement. This way the kernel coding style is followed. Signed-off-by: Len Baker --- drivers/staging/fbtft/fbtft-core.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-24 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- This patch has dependency on the GPUCC bindings patch here: https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t...@codeaurora.org/ Changes in v2: - formatting update

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-24 Thread Frank Wunderlich
>On 12.07.21 19:16, Frank Wunderlich wrote: >> Hi, >> >> it turns out that problem is the read+or of the new value >> >> i reverted my patch and changed >> >> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; >> writel_relaxed(reg, mmsys->regs + routes[i].addr); >> >> to >>

[PATCH v2 2/3] staging/fbtft: Remove unnecessary variable initialization

2021-07-24 Thread Len Baker
Remove the initialization of the variable "i" since it is written a few lines later. Signed-off-by: Len Baker --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index

Re: [PATCH 06/14] drm/i915/guc/slpc: Enable SLPC and add related H2G events

2021-07-24 Thread kernel test robot
Hi Vinay, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc2 next-20210723] [If your patch is applied to the wrong git tree,

Re: [PATCH 3/3] drm/panel-simple: add Gopher 2b LCD panel

2021-07-24 Thread Artjom Vejsel
Hello, thanks, Paul. I've sent V2. On 22/07/2021 17.12, Paul Cercueil wrote: Hi Artjom, Le jeu., juil. 22 2021 at 17:04:32 +0300, Artjom Vejsel a écrit : The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected.

[PATCH v2 1/3] staging/fbtft: Remove all strcpy() uses

2021-07-24 Thread Len Baker
strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy() but in this case it is simpler to use the "%*ph" format specifier. Signed-off-by: Len Baker

[PATCH v2 0/3] Remove all strcpy() uses

2021-07-24 Thread Len Baker
strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. So, this serie removes all strcpy uses from the "staging/fbtft" subsystem. Also, refactor the code a bit to follow the kernel

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 4:14 PM Karol Herbst wrote: > > we use the MXM_WMI in code. We also have to keep arm in mind and not > break stuff there. So I will try to play around with your changes and > see how that goes. Ok, should find any randconfig build failures for arm, arm64 or x86 over the

Re: [Intel-gfx] [PATCH 05/10] drm/i915: move gem_context slab to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

[RFC PATCH] drm/i915: slab_luts can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/gem/i915_gem_context.c:87:19: warning: symbol 'slab_luts' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- i915_gem_context.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 4:05 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 2:52 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > - You run into dependency loops that prevent a

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 2:10 PM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 1:56 PM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > > > > > In the past this only led to compilation

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 11:55 AM Karol Herbst wrote: > > On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > > > In the past this only led to compilation issues. Also the small amount of > > > extra .text shouldn't really

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

[RFC PATCH] drm/i915: slab_ce can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/gt/intel_context.c:17:19: warning: symbol 'slab_ce' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- intel_context.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 3/3] drm/vmwgfx: fix potential UAF in vmwgfx_surface.c

2021-07-24 Thread Desmond Cheong Zhi Xi
drm_file.master should be protected by either drm_device.master_mutex or drm_file.master_lookup_lock when being dereferenced. However, drm_master_get is called on unprotected file_priv->master pointers in vmw_surface_define_ioctl and vmw_gb_surface_define_internal. This is fixed by replacing

[PATCH v2 2/3] drm: clarify usage of drm leases

2021-07-24 Thread Desmond Cheong Zhi Xi
We make the following changes to the documentation of drm leases to make it easier to reason about their usage. In particular, we clarify the lifetime and locking rules of lease fields in drm_master: 1. Make it clear that _device.mode_config.idr_mutex protects the lease idr and list structures

[PATCH v2 1/3] drm: use the lookup lock in drm_is_current_master

2021-07-24 Thread Desmond Cheong Zhi Xi
Inside drm_is_current_master, using the outer drm_device.master_mutex to protect reads of drm_file.master makes the function prone to creating lock hierarchy inversions. Instead, we can use the drm_file.master_lookup_lock that sits at the bottom of the lock hierarchy. Reported-by: Daniel Vetter

[PATCH v2 0/3] drm, drm/vmwgfx: fixes and updates related to drm_master

2021-07-24 Thread Desmond Cheong Zhi Xi
Hi, Just a note that only patch 2 changed from v1 to v2 of this series. This series contains some improvements that Daniel Vetter proposed following a discussion on a recent series: https://lore.kernel.org/lkml/20210712043508.11584-1-desmondcheon...@gmail.com/ While preparing these patches, I

Re: [PATCH] staging/fbtft: Remove all strcpy() uses

2021-07-24 Thread Len Baker
On Mon, Jul 19, 2021 at 09:53:29AM +0200, Geert Uytterhoeven wrote: > On Sun, Jul 18, 2021 at 9:43 PM Andy Shevchenko > wrote: > > On Sun, Jul 18, 2021 at 4:43 PM Len Baker wrote: > > > strcpy() performs no bounds checking on the destination buffer. This > > > could result in linear overflows

Re: [PATCH] staging/fbtft: Remove all strcpy() uses

2021-07-24 Thread Len Baker
Hi, On Sun, Jul 18, 2021 at 10:42:42PM +0300, Andy Shevchenko wrote: > On Sun, Jul 18, 2021 at 4:43 PM Len Baker wrote: > > > > strcpy() performs no bounds checking on the destination buffer. This > > could result in linear overflows beyond the end of the buffer, leading > > to all kinds of

[PATCH v2 3/3] drm/panel-simple: add Gopher 2b LCD panel

2021-07-24 Thread Artjom Vejsel
The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. It has no specific name, since it's unique to that handhelds. lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047 Drive IC 480(RGB)*272 No Touch

[PATCH v2 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

2021-07-24 Thread Artjom Vejsel
Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel. Signed-off-by: Artjom Vejsel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

[PATCH v2 1/3] dt-bindings: Add QiShenglong vendor prefix

2021-07-24 Thread Artjom Vejsel
Add vendor prefix for Shenzhen QiShenglong Industrialist Co., Ltd. QiShenglong is a Chinese manufacturer of handheld gaming consoles, most of which run (very old) versions of Linux. QiShenglong is known as Hamy. Signed-off-by: Artjom Vejsel ---

[PATCH v2 0/3] add Gopher 2b LCD panel

2021-07-24 Thread Artjom Vejsel
The Gopher 2b LCD panel is used in Gopher 2b handhelds. It's simple panel with NewVision NV3047 driver, but SPI lines are not connected. It has no specific name, since it's unique to that handhelds. lot name at AliExpress: 4.3 inch 40PIN TFT LCD Screen COG NV3047 Drive IC 480(RGB)*272 No Touch

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Karol Herbst
On Sat, Jul 24, 2021 at 8:55 AM Arnd Bergmann wrote: > > On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > > > In the past this only led to compilation issues. Also the small amount of > > extra .text shouldn't really matter compared to the entire nouveau driver > > anyway. > > > > >

Re: [PATCH v2 0/9] PCI/VGA: Rework default VGA device selection

2021-07-24 Thread Huacai Chen
Hi, Bjorn, On Sat, Jul 24, 2021 at 8:10 AM Bjorn Helgaas wrote: > > On Fri, Jul 23, 2021 at 05:53:36PM +0800, Huacai Chen wrote: > > Hi, Bjorn, > > > > On Fri, Jul 23, 2021 at 5:29 AM Bjorn Helgaas wrote: > > > > > > From: Bjorn Helgaas > > > > > > This is a little bit of rework and extension

[RFC PATCH] drm/i915: slab_blocks can be static

2021-07-24 Thread kernel test robot
drivers/gpu/drm/i915/i915_buddy.c:13:19: warning: symbol 'slab_blocks' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- i915_buddy.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 03/10] drm/i915: move i915_buddy slab to direct module init/exit

2021-07-24 Thread kernel test robot
, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Check-for-nomodeset-in-i915_init-first/20210724-033145 base: git://anongit.freedesktop.org

Re: [PATCH] nouveau: make backlight support non optional

2021-07-24 Thread Arnd Bergmann
On Sat, Jul 24, 2021 at 12:47 AM Karol Herbst wrote: > > In the past this only led to compilation issues. Also the small amount of > extra .text shouldn't really matter compared to the entire nouveau driver > anyway. > > select DRM_TTM_HELPER > - select BACKLIGHT_CLASS_DEVICE if