Re: [PATCH] drm/msm/dp: add wide bus support

2022-01-28 Thread Dmitry Baryshkov
Hi, Thank you for your patch. On Fri, 28 Jan 2022 at 20:29, Kuogee Hsieh wrote: > > Normally, mdp will push one pixel of data per pixel clock to > interface to display. Wide bus feature will increase bus > width from 32 bits to 64 bits so that it can push two > pixel of data per pixel clock to i

Re: [PATCH 1/3] drm/panel: Rename Sony ACX424 to Novatek NT35560

2022-01-28 Thread Linus Walleij
On Mon, Jan 3, 2022 at 12:40 PM Linus Walleij wrote: > A code drop from Sony Mobile reveals that the ACX424 panels are > built around the Novatek NT35560 panel controllers so just bite > the bullet and rename the driver and all basic symbols so that > we can modify this driver to cover any other

[PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-01-28 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246 dp_perform_8b_10b_link_training() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +- 1 file changed, 5 inser

Re: (subset) [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru

2022-01-28 Thread Mark Brown
On Fri, 14 Jan 2022 15:02:06 -0800, Brian Norris wrote: > This series fixes DP/HDMI audio for RK3399 Gru systems. > > First, there was a regression with the switch to SPDIF. Patch 1 can be > taken separately as a regression fix if desired. But it's not quite so > useful (at least on Chrome OS syst

Re: [Intel-gfx] [PATCH] drm/i915: Fix a race between vma / object destruction and unbinding

2022-01-28 Thread Tvrtko Ursulin
On 27/01/2022 11:56, Thomas Hellström wrote: The vma destruction code was using an unlocked advisory check for drm_mm_node_allocated() to avoid racing with eviction code unbinding the vma. This is very fragile and prohibits the dereference of non-refcounted pointers of dying vmas after a call

Re: [PATCH 01/14] iosys-map: Introduce renamed dma-buf-map

2022-01-28 Thread Daniel Vetter
On Fri, Jan 28, 2022 at 10:39:49AM +0100, Thomas Zimmermann wrote: > Hi > > Am 28.01.22 um 10:24 schrieb Lucas De Marchi: > > On Fri, Jan 28, 2022 at 09:53:59AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 28.01.22 um 09:36 schrieb Lucas De Marchi: > > > > Add a new type, struct iosys_

Re: [PATCH 2/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-01-28 Thread kernel test robot
Hi "Uwe, Thank you for the patch! Yet something to improve: [auto build test ERROR on shawnguo/for-next] [also build test ERROR on robh/for-next pza/reset/next v5.17-rc1 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we su

Re: [RFC PATCH] component: Add common helpers for compare/release functions

2022-01-28 Thread Daniel Vetter
On Fri, Jan 28, 2022 at 04:11:01PM +0800, Yong Wu wrote: > The component requires the compare/release functions, there are so many > copy in current kernel. Just define three common helpers for them. > No functional change. > > Signed-off-by: Yong Wu > --- > Base on v5.17-rc1 > --- > .../gpu/drm

Re: [RFC PATCH v6 0/3] Add support modifiers for drivers whose planes only support linear layout

2022-01-28 Thread Daniel Vetter
On Fri, Jan 28, 2022 at 03:08:33PM +0900, Tomohito Esaki wrote: > Some drivers whose planes only support linear layout fb do not support format > modifiers. > These drivers should support modifiers, however the DRM core should handle > this > rather than open-coding in every driver. > > In this p

Re: [PATCH v6, 06/15] media: mtk-vcodec: Refactor get and put capture buffer flow

2022-01-28 Thread Nicolas Dufresne
Hi Yunfei, thanks for you work, see comments below... Le samedi 22 janvier 2022 à 11:53 +0800, Yunfei Dong a écrit : > For lat and core decode in parallel, need to get capture buffer > when core start to decode and put capture buffer to display > list when core decode done. > > Signed-off-by: Yu

Re: [PATCH 2/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-01-28 Thread kernel test robot
Hi "Uwe, Thank you for the patch! Yet something to improve: [auto build test ERROR on shawnguo/for-next] [also build test ERROR on robh/for-next pza/reset/next v5.17-rc1 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we su

[PATCH v5 08/10] lib: add support for device coherent type in test_hmm

2022-01-28 Thread Alex Sierra
Device Coherent type uses device memory that is coherently accesible by the CPU. This could be shown as SP (special purpose) memory range at the BIOS-e820 memory enumeration. If no SP memory is supported in system, this could be faked by setting CONFIG_EFI_FAKE_MEMMAP. Currently, test_hmm only sup

[PATCH v5 06/10] lib: test_hmm add ioctl to get zone device type

2022-01-28 Thread Alex Sierra
new ioctl cmd added to query zone device type. This will be used once the test_hmm adds zone device coherent type. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair Poppple --- lib/test_hmm.c | 23 +-- lib/test_hmm_uapi.h | 8 2 files

[PATCH v5 10/10] tools: update test_hmm script to support SP config

2022-01-28 Thread Alex Sierra
Add two more parameters to set spm_addr_dev0 & spm_addr_dev1 addresses. These two parameters configure the start SP addresses for each device in test_hmm driver. Consequently, this configures zone device type as coherent. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling Reviewed-by: Alistair

[PATCH v5 09/10] tools: update hmm-test to support device coherent type

2022-01-28 Thread Alex Sierra
Test cases such as migrate_fault and migrate_multiple, were modified to explicit migrate from device to sys memory without the need of page faults, when using device coherent type. Snapshot test case updated to read memory device type first and based on that, get the proper returned results migrat

[PATCH v5 07/10] lib: test_hmm add module param for zone device type

2022-01-28 Thread Alex Sierra
In order to configure device coherent in test_hmm, two module parameters should be passed, which correspond to the SP start address of each device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, private device type is configured. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling

[PATCH v5 05/10] drm/amdkfd: coherent type as sys mem on migration to ram

2022-01-28 Thread Alex Sierra
Coherent device type memory on VRAM to RAM migration, has similar access as System RAM from the CPU. This flag sets the source from the sender. Which in Coherent type case, should be set as MIGRATE_VMA_SELECT_DEVICE_COHERENT. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling --- drivers/gp

[PATCH v5 03/10] mm/gup: fail get_user_pages for LONGTERM dev coherent type

2022-01-28 Thread Alex Sierra
Avoid long term pinning for Coherent device type pages. This could interfere with their own device memory manager. For now, we are just returning error for PIN_LONGTERM Coherent device type pages. Eventually, these type of pages will get migrated to system memory, once the device migration pages su

[PATCH v5 04/10] drm/amdkfd: add SPM support for SVM

2022-01-28 Thread Alex Sierra
When CPU is connected throug XGMI, it has coherent access to VRAM resource. In this case that resource is taken from a table in the device gmc aperture base. This resource is used along with the device type, which could be DEVICE_PRIVATE or DEVICE_COHERENT to create the device page map region. Sig

[PATCH v5 01/10] mm: add zone device coherent type memory support

2022-01-28 Thread Alex Sierra
Device memory that is cache coherent from device and CPU point of view. This is used on platforms that have an advanced system bus (like CAPI or CXL). Any page of a process can be migrated to such memory. However, no one should be allowed to pin such memory so that it can always be evicted. Signed

[PATCH v5 02/10] mm: add device coherent vma selection for memory migration

2022-01-28 Thread Alex Sierra
This case is used to migrate pages from device memory, back to system memory. Device coherent type memory is cache coherent from device and CPU point of view. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling --- v2: condition added when migrations from device coherent pages. --- include/linu

[PATCH v5 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-28 Thread Alex Sierra
This patch series introduces MEMORY_DEVICE_COHERENT, a type of memory owned by a device that can be mapped into CPU page tables like MEMORY_DEVICE_GENERIC and can also be migrated like MEMORY_DEVICE_PRIVATE. Christoph, the suggestion to incorporate Ralph Campbell’s refcount cleanup patch into our

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:58 PM Karol Herbst wrote: > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > > ban. > > > I pushed this already but

Re: [PATCH] Revert "drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()"

2022-01-28 Thread Lyude Paul
on further reconsideration: Self-NAKing this. I don't see any issues with those patches. On Fri, 2022-01-28 at 14:29 -0500, Lyude Paul wrote: > This reverts commit 2343bcdb4747d4f418a4daf2e898b94f86c24a59. > > Unfortunately, as Greg pointed out I totally missed the fact that this > patch came fro

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Karol Herbst
On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > ban. > > I pushed this already but I will go ahead and send a revert for this patch. > > Will cc you on

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Lyude Paul
On Fri, 2022-01-28 at 14:53 -0500, Alex Deucher wrote: > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > ban. > > I pushed this already but I will go ahead and send a revert for this > > patch. > > Will cc you

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. > Will cc you on it as well. This seems short-sighted. If the patch is valid I see no

Re: [RFC v3 00/12] Define and use reset domain for GPU recovery in amdgpu

2022-01-28 Thread Andrey Grodzovsky
Just a gentle ping if people have more comments on this patch set ? Especially last 5 patches as first 7 are exact same as V2 and we already went over them mostly. Andrey On 2022-01-25 17:37, Andrey Grodzovsky wrote: This patchset is based on earlier work by Boris[1] that allowed to have an or

[PATCH] Revert "drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()"

2022-01-28 Thread Lyude Paul
This reverts commit 2343bcdb4747d4f418a4daf2e898b94f86c24a59. Unfortunately, as Greg pointed out I totally missed the fact that this patch came from a umn.edu patch. umn.edu is still banned from contributing to the Linux kernel, so let's revert this for the time being. I'll re-evaluate this fix my

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Lyude Paul
Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. I pushed this already but I will go ahead and send a revert for this patch. Will cc you on it as well. On Fri, 2022-01-28 at 11:18 +0100, Greg KH wrote: > On Tue, Jan 25, 2022 at 12:58:55AM +0800, Zhou Qingyang wrote: >

Re: [PATCH 09/14] drm/nouveau: Replace dma-buf-map with iosys-map

2022-01-28 Thread Lyude Paul
For this patch: Reviewed-by: Lyude Paul On Fri, 2022-01-28 at 00:36 -0800, Lucas De Marchi wrote: > iosys-map is the new name for dma-buf-map and will gain new > capabitilities. Replace with the new API in nouveau. > > Signed-off-by: Lucas De Marchi > --- >  drivers/gpu/drm/nouveau/nouveau_gem

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-28 Thread Peter Geis
On Thu, Jan 27, 2022 at 4:33 AM Sascha Hauer wrote: > > Hi Peter, > > On Wed, Jan 26, 2022 at 03:24:26PM -0500, Peter Geis wrote: > > The hdmi-cec clock must be 32khz in order for cec to work correctly. > > Ensure after enabling the clock we set it in order for the hardware to > > work as expected

Re: [PATCH][next] drm/amd/display: fix spelling mistake: synatpics -> synaptics

2022-01-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 28, 2022 at 12:59 PM Harry Wentland wrote: > > > > On 2022-01-28 12:35, Colin Ian King wrote: > > There are quite a few spelling mistakes in various function names > > and error messages. Fix these. > > > > Signed-off-by: Colin Ian King > > Reviewed-by: Harry

[PATCH 5/5] drm/i915/guc: Allow user to override driver load failure without GuC

2022-01-28 Thread Ramalingam C
From: Stuart Summers The driver is set currently to fail modprobe when GuC is disabled (enable_guc=0) after GuC has been loaded on a previous modprobe. For GuC deprivilege, the BIOS is setting the locked bit, so the driver always considers the GuC to have been loaded and thus does not support ena

[PATCH 4/5] drm/i915/dg2: Add Wa_22011100796

2022-01-28 Thread Ramalingam C
From: Bruce Chang Whenever Full soft reset is required, reset all individual engines first, and then do a full soft reset. Signed-off-by: Bruce Chang cc: Matt Roper Cc: Rodrigo Vivi Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_reset.c | 9 + 1 file changed, 9 insert

[PATCH 2/5] drm/i915: align the plane_vma to min_page_size of stolen mem

2022-01-28 Thread Ramalingam C
Align the plane vma size to the stolem memory regions' min_page_size. Signed-off-by: Ramalingam C cc: Matthew Auld cc: Chris P Wilson --- drivers/gpu/drm/i915/display/intel_plane_initial.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/int

[PATCH 3/5] drm/i915: More gt idling time with guc submission

2022-01-28 Thread Ramalingam C
On i915_selftest@live@gt_timelines, we create many contexts in loop and create and submit request and then destoy contexts. Destroying the context needs to disable scheduling, wait for G2H, deregister context and wait for G2H to destroy each context. Idling of the gt has to wait for all this to com

[PATCH 1/5] drm/i915/dg2: Add Wa_22011450934

2022-01-28 Thread Ramalingam C
An indirect ctx wabb is implemented as per Wa_22011450934 to avoid rcs restore hang during context restore of a preempted context in GPGPU mode Signed-off-by: Ramalingam C cc: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 28 drivers/gpu/drm/i915/i915_reg.h

[PATCH 0/5] Misc DG2 enabling patches

2022-01-28 Thread Ramalingam C
Assorted DG2 enabling patches. Bruce Chang (1): drm/i915/dg2: Add Wa_22011100796 Ramalingam C (3): drm/i915/dg2: Add Wa_22011450934 drm/i915: align the plane_vma to min_page_size of stolen mem drm/i915: More gt idling time with guc submission Stuart Summers (1): drm/i915/guc: Allow use

Re: [PATCH] drm/amd/pm: remove duplicate include in 'arcturus_ppt.c'

2022-01-28 Thread Alex Deucher
Applied. thanks! Alex On Fri, Jan 28, 2022 at 2:19 AM wrote: > > From: Changcheng Deng > > 'amdgpu_dpm.h' included in 'arcturus_ppt.c' is duplicated. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 1 - > 1 file change

Re: [PATCH] drm/amdgpu: remove duplicate include in 'amdgpu_device.c'

2022-01-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jan 28, 2022 at 2:05 AM wrote: > > From: Changcheng Deng > > 'linux/pci.h' included in 'amdgpu_device.c' is duplicated. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - > 1 file changed, 1 de

[PATCH v2 3/3] drm/i915: Do not spam log with missing arch support

2022-01-28 Thread Lucas De Marchi
Following what was done in drm_cache.c, when the stub for remap_io_mapping() was added in commit 67c430bbaae1 ("drm/i915: Skip remap_io_mapping() for non-x86 platforms"), it included a log message with pr_err(). However just the warning is already enough and switching to WARN_ONCE() allows us to k

[PATCH v2 2/3] drm/i915: Fix header test for !CONFIG_X86

2022-01-28 Thread Lucas De Marchi
Architectures others than x86 have a stub implementation calling WARN_ON_ONCE(). The appropriate headers need to be included, otherwise the header-test target will fail with: HDRTEST drivers/gpu/drm/i915/i915_mm.h In file included from : ./drivers/gpu/drm/i915/i915_mm.h: In function ‘remap_io_ma

[PATCH v2 1/3] drm: Stop spamming log with drm_cache message

2022-01-28 Thread Lucas De Marchi
Only x86 and in some cases PPC have support added in drm_cache.c for the clflush class of functions. However warning once is sufficient to taint the log instead of spamming it with "Architecture has no drm_cache.c support" every few millisecond. Switch to WARN_ONCE() so we still get the log message

[PATCH v2 0/3] drm/i915: Fix header test and log spam on !x86

2022-01-28 Thread Lucas De Marchi
Some minor fixes and changes to help porting i915 to arm64, or even anything !x86. Lucas De Marchi (3): drm: Stop spamming log with drm_cache message drm/i915: Fix header test for !CONFIG_X86 drm/i915: Do not spam log with missing arch support drivers/gpu/drm/drm_cache.c| 9 +++--

Re: [PATCH][next] drm/amd/display: fix spelling mistake: synatpics -> synaptics

2022-01-28 Thread Harry Wentland
On 2022-01-28 12:35, Colin Ian King wrote: > There are quite a few spelling mistakes in various function names > and error messages. Fix these. > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 32 +-

Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-01-28 Thread Uwe Kleine-König
Hello Rob, On Fri, Jan 28, 2022 at 07:04:10AM -0600, Rob Herring wrote: > On Fri, Jan 28, 2022 at 4:59 AM Uwe Kleine-König > wrote: > > > > From: Marian Cichy > > > > This files documents the device tree for the new imx21-lcdc DRM driver. > > No, bindings document h/w and the h/w has not change

[PATCH] drm/msm/dp: add wide bus support

2022-01-28 Thread Kuogee Hsieh
Normally, mdp will push one pixel of data per pixel clock to interface to display. Wide bus feature will increase bus width from 32 bits to 64 bits so that it can push two pixel of data per pixel clock to interface to display. This feature is pre requirement to support 4k resolution. Signed-off-by

Re: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-28 Thread Felix Kuehling
Thank you, Alex for your persistence with this patch series. Fee free to add my Acked-by to all the patches that don't already have my R-b. I have done pretty through reviews of previous versions of those patches, but obviously missed a lot of issues pointed out by real MM experts. Thank you A

Re: [RFC v2 4/8] drm/amdgpu: Serialize non TDR gpu recovery with TDRs

2022-01-28 Thread Grodzovsky, Andrey
Just a gentle ping. Andrey From: Grodzovsky, Andrey Sent: 26 January 2022 10:52 To: Christian König ; Koenig, Christian ; Lazar, Lijo ; dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Chen, JingWen Cc: Chen, Horace ; Liu, Monk Subject: Re: [

Re: [PATCH v1, 3/4] drm/mediatek: split postmask component

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > add postmask private data for differnt soc support > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/Makefile| 1 + > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + > drivers/gpu/drm/mediatek/mtk_dis

Re: [PATCH v1, 4/4] drm/mediatek: add mt8186 display support

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 39 ++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_dr

Re: [PATCH v1, 2/4] soc: mediatek: add mtk mutex support for MT8186

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > Add mtk mutex support for MT8186 SoC. > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mtk-mutex.c | 45 > 1 file changed, 45 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c

Re: [PATCH v1, 1/4] soc: mediatek: mmsys: Add mt8186 mmsys routing table

2022-01-28 Thread Chun-Kuang Hu
Hi, Yongqiang: Yongqiang Niu 於 2022年1月28日 週五 下午8:07寫道: > > mt8186 routing registers is different with other Soc > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mt8186-mmsys.h | 113 > drivers/soc/mediatek/mtk-mmsys.c| 11 +++ > 2 files changed, 12

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-28 Thread Daniel Vetter
On Fri, Jan 28, 2022 at 12:36 PM Thomas Zimmermann wrote: > > Hi > > Am 28.01.22 um 12:00 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 4:18 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 27.01.22 um 16:03 schrieb Daniel Vetter: > >>> On Thu, Jan 27, 2022 at 12:58:30PM +0100, Tho

Re: [PATCH v3] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-28 Thread Chun-Kuang Hu
AngeloGioacchino Del Regno 於 2022年1月28日 週五 下午5:13寫道: > > Il 27/01/22 16:46, AngeloGioacchino Del Regno ha scritto: > > Il 27/01/22 16:21, Chun-Kuang Hu ha scritto: > >> Hi, Angelo: > >> > >> AngeloGioacchino Del Regno 於 > >> 2022年1月27日 週四 下午10:36寫道: > >>> > >>> DRM bridge drivers are now attachin

RE: [PATCH v4 00/10] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping

2022-01-28 Thread Deucher, Alexander
[Public] > -Original Message- > From: Sierra Guiza, Alejandro (Alex) > Sent: Thursday, January 27, 2022 6:21 PM > To: Andrew Morton > Cc: Kuehling, Felix ; linux...@kvack.org; > rcampb...@nvidia.com; linux-e...@vger.kernel.org; linux- > x...@vger.kernel.org; amd-...@lists.freedesktop.org

Re: [PATCH v2 1/28] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-01-28 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: RyanLin Sent: Thursday, January 27, 2022 10:47 PM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; david1.z...@amd.com ; airl...@linux.ie ; dan...@ffwll.ch ; seanp...@chromium.org ;

Re: [PATCH v11 5/5] drm/amdgpu: add drm buddy support to amdgpu

2022-01-28 Thread Matthew Auld
On Thu, 27 Jan 2022 at 14:11, Arunpravin wrote: > > - Remove drm_mm references and replace with drm buddy functionalities > - Add res cursor support for drm buddy > > v2(Matthew Auld): > - replace spinlock with mutex as we call kmem_cache_zalloc > (..., GFP_KERNEL) in drm_buddy_alloc() funct

[PATCH v3] drm/v3d: fix missing unlock

2022-01-28 Thread Yongzhi Liu
[why] Unlock is needed on the error handling path to prevent dead lock. v3d_submit_cl_ioctl and v3d_submit_csd_ioctl is missing unlock. [how] Fix this by changing goto target on the error handling path. So changing the goto to target an error handling path that includes drm_gem_unlock reservations

Re: [PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-01-28 Thread Rob Herring
On Fri, Jan 28, 2022 at 4:59 AM Uwe Kleine-König wrote: > > From: Marian Cichy > > This files documents the device tree for the new imx21-lcdc DRM driver. No, bindings document h/w and the h/w has not changed. We already have a binding for the LCDC. > > Signed-off-by: Marian Cichy > Signed-off

Re: [RFC PATCH] component: Add common helpers for compare/release functions

2022-01-28 Thread Robin Murphy
On 2022-01-28 08:11, Yong Wu wrote: [...] diff --git a/include/linux/component.h b/include/linux/component.h index 16de18f473d7..5a7468ea827c 100644 --- a/include/linux/component.h +++ b/include/linux/component.h @@ -2,6 +2,8 @@ #ifndef COMPONENT_H #define COMPONENT_H +#include +#include

Re: [PATCH v2] drm/v3d: fix missing unlock

2022-01-28 Thread Melissa Wen
On 01/27, Yongzhi Liu wrote: > [why] > Unlock is needed on the error handling path to prevent dead lock. > v3d_submit_cl_ioctl and v3d_submit_csd_ioctl is missing unlock. > > [how] > Fix this by change goto target on the error handling path. s/change/changing/g I would just say: `Changing the got

Re: [PATCH v10 02/13] iommu/mediatek-v1: Free the existed fwspec if the master dev already has

2022-01-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Jan 2022 13:40:55 +0100 Mauro Carvalho Chehab escreveu: > Hi Matthias/Yong, > > Are you ok if this patch gets merged via the media tree together with the > remaining series, or do you prefer to apply it via SoC tree instead? Same questions for other patches touching files outside dri

Re: [PATCH v10 02/13] iommu/mediatek-v1: Free the existed fwspec if the master dev already has

2022-01-28 Thread Mauro Carvalho Chehab
Hi Matthias/Yong, Are you ok if this patch gets merged via the media tree together with the remaining series, or do you prefer to apply it via SoC tree instead? Regards, Mauro Em Mon, 17 Jan 2022 15:04:59 +0800 Yong Wu escreveu: > When the iommu master device enters of_iommu_xlate, the ops ma

[PATCH v1, 4/4] drm/mediatek: add mt8186 display support

2022-01-28 Thread Yongqiang Niu
Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 6efb423ccc92..754b1be25d0d 100644 --- a/drivers/gpu/drm/me

[PATCH v1, 3/4] drm/mediatek: split postmask component

2022-01-28 Thread Yongqiang Niu
add postmask private data for differnt soc support Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 155 +++ drivers/gpu/drm/mediatek/mtk_drm

[PATCH v1, 1/4] soc: mediatek: mmsys: Add mt8186 mmsys routing table

2022-01-28 Thread Yongqiang Niu
mt8186 routing registers is different with other Soc Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mt8186-mmsys.h | 113 drivers/soc/mediatek/mtk-mmsys.c| 11 +++ 2 files changed, 124 insertions(+) create mode 100644 drivers/soc/mediatek/mt8186-mmsys.h

[PATCH v1, 0/4] add display support for mediatek SOC MT8186

2022-01-28 Thread Yongqiang Niu
Yongqiang Niu (4): soc: mediatek: mmsys: Add mt8186 mmsys routing table soc: mediatek: add mtk mutex support for MT8186 drm/mediatek: split postmask component drm/mediatek: add mt8186 display support drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp

[PATCH v1, 2/4] soc: mediatek: add mtk mutex support for MT8186

2022-01-28 Thread Yongqiang Niu
Add mtk mutex support for MT8186 SoC. Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mtk-mutex.c | 45 1 file changed, 45 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index 2ca55bb5a8be..ebd95fd0f36e 10064

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 12:36 schrieb Laurent Pinchart: Hi Thomas, On Fri, Jan 28, 2022 at 12:26:03PM +0100, Thomas Zimmermann wrote: Am 28.01.22 um 12:04 schrieb Laurent Pinchart: On Fri, Jan 28, 2022 at 11:46:49AM +0100, Thomas Zimmermann wrote: Am 28.01.22 um 11:34 schrieb Laurent Pinchart: On

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Laurent Pinchart
Hi Thomas, On Fri, Jan 28, 2022 at 12:26:03PM +0100, Thomas Zimmermann wrote: > Am 28.01.22 um 12:04 schrieb Laurent Pinchart: > > On Fri, Jan 28, 2022 at 11:46:49AM +0100, Thomas Zimmermann wrote: > >> Am 28.01.22 um 11:34 schrieb Laurent Pinchart: > >>> On Fri, Jan 28, 2022 at 10:33:21AM +0100,

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 12:00 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 4:18 PM Thomas Zimmermann wrote: Hi Am 27.01.22 um 16:03 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at 12:58:30PM +0100, Thomas Zimmermann wrote: Hi Am 27.01.22 um 12:42 schrieb Daniel Vetter: On Thu, Jan 27, 2022 at

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 12:04 schrieb Laurent Pinchart: Hi Thomas, On Fri, Jan 28, 2022 at 11:46:49AM +0100, Thomas Zimmermann wrote: Am 28.01.22 um 11:34 schrieb Laurent Pinchart: On Fri, Jan 28, 2022 at 10:33:21AM +0100, Thomas Zimmermann wrote: Am 28.01.22 um 10:13 schrieb Kieran Bingham: Quot

Re: [Intel-gfx] [PATCH] drm/i915: Allow dead vm to unbind vma's without lock.

2022-01-28 Thread Maarten Lankhorst
Op 28-01-2022 om 12:02 schreef Thomas Hellström (Intel): > > On 1/28/22 09:57, Maarten Lankhorst wrote: >> i915_gem_vm_close may take the lock, and we currently have no better way >> of handling this. At least for now, allow a path in which holding vm->mutex >> is sufficient. This is the case, beca

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Javier Martinez Canillas
On 1/28/22 11:46, Thomas Zimmermann wrote: > Am 28.01.22 um 11:34 schrieb Laurent Pinchart: [snip] >>> >>> It cannot be 'mode-setted'. We get a pre-configured framebuffer from the >>> firmware or bootloader. Whatever we draw there shows up on the screen. >> >> I doubt that's going to work as you

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Laurent Pinchart
Hi Thomas, On Fri, Jan 28, 2022 at 11:46:49AM +0100, Thomas Zimmermann wrote: > Am 28.01.22 um 11:34 schrieb Laurent Pinchart: > > On Fri, Jan 28, 2022 at 10:33:21AM +0100, Thomas Zimmermann wrote: > >> Am 28.01.22 um 10:13 schrieb Kieran Bingham: > >>> Quoting Javier Martinez Canillas (2021-12-17

Re: [Intel-gfx] [PATCH] drm/i915: Allow dead vm to unbind vma's without lock.

2022-01-28 Thread Intel
On 1/28/22 09:57, Maarten Lankhorst wrote: i915_gem_vm_close may take the lock, and we currently have no better way of handling this. At least for now, allow a path in which holding vm->mutex is sufficient. This is the case, because the object destroy path will forcefully take vm->mutex now. S

Re: [PATCH] drm/fb-helper: Mark screen buffers in system memory with FB_VIRTFB

2022-01-28 Thread Daniel Vetter
On Thu, Jan 27, 2022 at 4:18 PM Thomas Zimmermann wrote: > > Hi > > Am 27.01.22 um 16:03 schrieb Daniel Vetter: > > On Thu, Jan 27, 2022 at 12:58:30PM +0100, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 27.01.22 um 12:42 schrieb Daniel Vetter: > >>> On Thu, Jan 27, 2022 at 11:26:21AM +0100, Thoma

[PATCH 0/2] drm/imx/lcdc: drm driver for imx21/25/27

2022-01-28 Thread Uwe Kleine-König
Hello, this patchset was created mostly by Marian Cichy, who in the meantime left Pengutronix. I still kept his name and email address as author, but note that the email address doesn't reach Marian any more. There is already a maintainer entry for imx DRM drivers that matches good enough. This

[PATCH 1/2] dt-bindings: display: imx: Add fsl,imx21-lcdc docs

2022-01-28 Thread Uwe Kleine-König
From: Marian Cichy This files documents the device tree for the new imx21-lcdc DRM driver. Signed-off-by: Marian Cichy Signed-off-by: Uwe Kleine-König --- .../bindings/display/imx/fsl,imx21-lcdc.yaml | 79 +++ 1 file changed, 79 insertions(+) create mode 100644 Documentatio

[PATCH 2/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-01-28 Thread Uwe Kleine-König
From: Marian Cichy Add support for the LCD Controller found on i.MX21, i.MX25 and i.MX27 Note there is already a fb driver for this hardware in the tree that is supposed to be superseded by this one. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/imx/Kconfig | 9 + driv

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 11:34 schrieb Laurent Pinchart: Hi Thomas, On Fri, Jan 28, 2022 at 10:33:21AM +0100, Thomas Zimmermann wrote: Am 28.01.22 um 10:13 schrieb Kieran Bingham: Quoting Javier Martinez Canillas (2021-12-17 00:37:46) According to disable Documentation/admin-guide/kernel-parameters

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Laurent Pinchart
Hi Thomas, On Fri, Jan 28, 2022 at 10:33:21AM +0100, Thomas Zimmermann wrote: > Am 28.01.22 um 10:13 schrieb Kieran Bingham: > > Quoting Javier Martinez Canillas (2021-12-17 00:37:46) > >> According to disable Documentation/admin-guide/kernel-parameters.txt, this > >> parameter can be used to disa

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Greg KH
On Tue, Jan 25, 2022 at 12:58:55AM +0800, Zhou Qingyang wrote: > In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly > passed to memcpy(), which could lead to undefined behavior on failure > of kmalloc(). > > Fix this bug by using kmemdup() instead of kmalloc()+memcpy(). > > Thi

Re: [PATCH] drm/amd/display: Fix a NULL pointer dereference in amdgpu_dm_connector_add_common_modes()

2022-01-28 Thread Greg KH
On Tue, Jan 25, 2022 at 12:57:29AM +0800, Zhou Qingyang wrote: > In amdgpu_dm_connector_add_common_modes(), amdgpu_dm_create_common_mode() > is assigned to mode and is passed to drm_mode_probed_add() directly after > that. drm_mode_probed_add() passes &mode->head to list_add_tail(), and > there is

Re: [PATCH] drm/amd/display/dc/calcs/dce_calcs: Fix a memleak in calculate_bandwidth()

2022-01-28 Thread Greg KH
On Tue, Jan 25, 2022 at 12:55:51AM +0800, Zhou Qingyang wrote: > In calculate_bandwidth(), the tag free_sclk and free_yclk are reversed, > which could lead to a memory leak of yclk. > > Fix this bug by changing the location of free_sclk and free_yclk. > > This bug was found by a static analyzer.

Re: [PATCH 00/14] Rename dma-buf-map

2022-01-28 Thread Christian König
Am 28.01.22 um 10:40 schrieb Lucas De Marchi: On Fri, Jan 28, 2022 at 10:22:00AM +0100, Christian König wrote: Am 28.01.22 um 10:12 schrieb Lucas De Marchi: On Fri, Jan 28, 2022 at 09:41:14AM +0100, Christian König wrote: Rule #1 is to never ever break the build. Because of this all those pat

Re: [PATCH 00/14] Rename dma-buf-map

2022-01-28 Thread Lucas De Marchi
On Fri, Jan 28, 2022 at 10:22:00AM +0100, Christian König wrote: Am 28.01.22 um 10:12 schrieb Lucas De Marchi: On Fri, Jan 28, 2022 at 09:41:14AM +0100, Christian König wrote: Rule #1 is to never ever break the build. Because of this all those patches needs to be squashed into a single one as

Re: [PATCH 01/14] iosys-map: Introduce renamed dma-buf-map

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 10:24 schrieb Lucas De Marchi: On Fri, Jan 28, 2022 at 09:53:59AM +0100, Thomas Zimmermann wrote: Hi Am 28.01.22 um 09:36 schrieb Lucas De Marchi: Add a new type, struct iosys_map, to eventually replace struct dma_buf_map and its helpers defiend in include/linux/dma-buf-map.

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 10:13 schrieb Kieran Bingham: Hi Javier, Quoting Javier Martinez Canillas (2021-12-17 00:37:46) According to disable Documentation/admin-guide/kernel-parameters.txt, this parameter can be used to disable kernel modesetting. DRM drivers will not perform display-mode changes o

Re: [PATCH 01/14] iosys-map: Introduce renamed dma-buf-map

2022-01-28 Thread Lucas De Marchi
On Fri, Jan 28, 2022 at 09:53:59AM +0100, Thomas Zimmermann wrote: Hi Am 28.01.22 um 09:36 schrieb Lucas De Marchi: Add a new type, struct iosys_map, to eventually replace struct dma_buf_map and its helpers defiend in include/linux/dma-buf-map.h. This is mostly a copy of dma-buf-map with the r

Re: [PATCH 00/14] Rename dma-buf-map

2022-01-28 Thread Christian König
Am 28.01.22 um 10:12 schrieb Lucas De Marchi: On Fri, Jan 28, 2022 at 09:41:14AM +0100, Christian König wrote: Rule #1 is to never ever break the build. Because of this all those patches needs to be squashed into a single one as far as I can see. what config are you building on? Well I'm n

[PATCH] drm/imx: dw_hdmi-imx: Fix bailout in error cases of probe

2022-01-28 Thread Liu Ying
In dw_hdmi_imx_probe(), if error happens after dw_hdmi_probe() returns successfully, dw_hdmi_remove() should be called where necessary as bailout. Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into probe") Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc:

Re: [PATCH v2 31/37] drm: rcar-du: Add support for the nomodeset kernel parameter

2022-01-28 Thread Kieran Bingham
Hi Javier, Quoting Javier Martinez Canillas (2021-12-17 00:37:46) > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the syste

Re: [PATCH v3] drm/mediatek: mtk_dsi: Avoid EPROBE_DEFER loop with external bridge

2022-01-28 Thread AngeloGioacchino Del Regno
Il 27/01/22 16:46, AngeloGioacchino Del Regno ha scritto: Il 27/01/22 16:21, Chun-Kuang Hu ha scritto: Hi, Angelo: AngeloGioacchino Del Regno 於 2022年1月27日 週四 下午10:36寫道: DRM bridge drivers are now attaching their DSI device at probe time, which requires us to register our DSI host in order to

Re: [PATCH 00/14] Rename dma-buf-map

2022-01-28 Thread Lucas De Marchi
On Fri, Jan 28, 2022 at 09:41:14AM +0100, Christian König wrote: Rule #1 is to never ever break the build. Because of this all those patches needs to be squashed into a single one as far as I can see. what config are you building on? I built this series, full config with CONFIG_COMPILE_TEST a

[PATCH] drm/i915: Allow dead vm to unbind vma's without lock.

2022-01-28 Thread Maarten Lankhorst
i915_gem_vm_close may take the lock, and we currently have no better way of handling this. At least for now, allow a path in which holding vm->mutex is sufficient. This is the case, because the object destroy path will forcefully take vm->mutex now. Signed-off-by: Maarten Lankhorst --- drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-28 Thread Maarten Lankhorst
Op 27-01-2022 om 13:45 schreef Thomas Hellström: > > On 1/27/22 13:38, Maarten Lankhorst wrote: >> Op 27-01-2022 om 13:09 schreef Thomas Hellström: >>> On 1/27/22 13:05, Thomas Hellström wrote: > The bug on vm_close is a separate bug, and would probably best be > fixed in a separate patch.

Re: [PATCH 01/14] iosys-map: Introduce renamed dma-buf-map

2022-01-28 Thread Thomas Zimmermann
Hi Am 28.01.22 um 09:36 schrieb Lucas De Marchi: Add a new type, struct iosys_map, to eventually replace struct dma_buf_map and its helpers defiend in include/linux/dma-buf-map.h. This is mostly a copy of dma-buf-map with the renames in place and slightly different wording to avoid tying iosys_

  1   2   >