Re: [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-03-25 Thread kernel test robot
Hi Zhi, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next next-20220325] [cannot apply to tegra-drm/drm/tegra/for-next airlied/drm-next v5.17] [If your patch is applied to the wrong git tree

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-25 Thread Olsak, Marek
[AMD Official Use Only] amdgpu has 2 resets: soft reset and hard reset. The soft reset is able to recover from an infinite loop and even some GPU hangs due to bad shaders or bad states. The soft reset uses a signal that kills all currently-running shaders of a certain process (VM context), whic

Re: [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-03-25 Thread kernel test robot
Hi Zhi, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm/drm-next next-20220325] [cannot apply to tegra-drm/drm/tegra/for-next airlied/drm-next v5.17] [If your patch is applied to the wrong git

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-25 Thread Francisco Jerez
Matt Atwood writes: > Newer platforms have DSS that aren't necessarily available for both > geometry and compute, two queries will need to exist. This introduces > the first, when passing a valid engine class and engine instance in the > flags returns a topology describing geometry. > > v2: fix w

Re: [git pull] drm fixes for 5.18-rc1

2022-03-25 Thread Linus Torvalds
On Thu, Mar 24, 2022 at 7:13 PM Dave Airlie wrote: > > Some fixes were queued up in and in light of the fbdev regressions, > I've pulled those in as well, Thanks, pulled. It sounds (from the other thread) that the mediatek DT issue is also about to be fixed, even if it's not yet here. But that

Re: [git pull] drm fixes for 5.18-rc1

2022-03-25 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Mar 2022 12:13:20 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-03-25 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/cb7cbaae7fd9cee64f19cdfd89d097d807b884f5 Thank you! -- Deet-doot-dot, I am a bot. https://ko

Re: [PATCH v6 02/12] clk: Introduce Kunit Tests for the framework

2022-03-25 Thread Stephen Boyd
Quoting Daniel Latypov (2022-02-24 15:21:57) > On Thu, Feb 24, 2022 at 2:54 PM Stephen Boyd wrote: > > > > Quoting Daniel Latypov (2022-02-23 14:50:59) > > > On Wed, Feb 23, 2022 at 2:56 AM Maxime Ripard wrote: > > > > > > > > Let's test various parts of the rate-related clock API with the kunit

[RFC PATCH] drm/amd/display: dont ignore alpha property

2022-03-25 Thread Melissa Wen
Hi all, I'm examining the IGT kms_plane_alpha_blend test, specifically the alpha-7efc. It fails on AMD and Intel gen8 hw, but passes on Intel gen11. At first, I thought it was a rounding issue. In fact, it may be the problem for different results between intel hw generations. However, I changed t

Re: [Intel-gfx] [PATCH] drm/i915: fix remaining_timeout in intel_gt_retire_requests_timeout

2022-03-25 Thread Ceraolo Spurio, Daniele
On 3/25/2022 11:37 AM, Das, Nirmoy wrote: On 3/25/2022 6:58 PM, Daniele Ceraolo Spurio wrote: In intel_gt_wait_for_idle, we use the remaining timeout returned from intel_gt_retire_requests_timeout to wait on the GuC being idle. However, the returned variable can have a negative value if some

Re: [git pull] drm for 5.18-rc1

2022-03-25 Thread Rob Herring
On Thu, Mar 24, 2022 at 10:01 PM Dave Airlie wrote: > > > FYI, this breaks the DT bindings. The relevant patches didn't get > > reviewed nor run thru automated testing because their encoding was > > 'charset=y'[1]. (While email clients seem to just ignore that > > encoding, patchwork and b4 do not

Re: [PATCH] drm/amd/display: Fix pointer dereferenced before checking

2022-03-25 Thread Alex Deucher
Applied both patches. Thanks! Alex On Thu, Mar 24, 2022 at 9:46 AM Haowen Bai wrote: > > The value actual_pix_clk_100Hz is dereferencing pointer pix_clk_params > before pix_clk_params is being null checked. Fix this by assigning > pix_clk_params->requested_pix_clk_100hz to actual_pix_clk_100Hz

RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Stephen Boyd
Quoting Sankeerth Billakanti (QUIC) (2022-03-25 06:30:58) > > > > > + vdda-1p2-supply = <&vreg_l6b_1p2>; > > > + vdda-0p9-supply = <&vreg_l10c_0p8>; > > > + > > > + aux-bus { > > > > Can this move to sc7280.dtsi and get a phandle? > > > > Okay, I will move this to sc7280.dtsi like

Re: [PATCH v2 1/4] drm/atomic: Print the state every commit

2022-03-25 Thread Daniel Vetter
On Fri, Mar 25, 2022 at 01:48:19PM +0100, Maxime Ripard wrote: > The DRM_UT_STATE controls whether we're calling > drm_atomic_print_new_state() whenever a new state is committed. However, > that call is made in the drm_mode_atomic_ioctl(), whereas we have > multiple users of the drm_atomic_commit()

Re: [PATCH 2/2] dma-buf/sync-file: fix warning about fence containers

2022-03-25 Thread Daniel Vetter
On Fri, Mar 25, 2022 at 11:35:49AM +0100, Christian König wrote: > Am 25.03.22 um 11:13 schrieb Daniel Vetter: > > On Fri, Mar 11, 2022 at 12:02:44PM +0100, Christian König wrote: > > > The dma_fence_chain containers can show up in sync_files as well > > > resulting in > > > warnings that those ca

Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

2022-03-25 Thread Zack Rusin
On Sun, 2022-03-13 at 06:06 +0100, Philipp Sieweck wrote: > The cases of vmw_user_bo_synccpu_grab failing with -ERESTARTSYS or - > EBUSY > are handled in vmw_user_bo_synccpu_ioctl by not printing an error > message. > However, the error value gets discarded, indicating success. This > leads > to re

Re: [PATCH] drm/selftest: plane_helper: Put test structures in static storage

2022-03-25 Thread Guenter Roeck
On Wed, Mar 02, 2022 at 04:59:09PM -0700, Nathan Chancellor wrote: > Clang warns on certain 32-bit architectures: > > drivers/gpu/drm/selftests/test-drm_plane_helper.c:76:5: warning: stack > frame size (1064) exceeds limit (1024) in 'igt_check_plane_state' > [-Wframe-larger-than] > int igt_c

Re: [PATCH 02/22] dt-bindings: mediatek,dp: Add Display Port binding

2022-03-25 Thread Rob Herring
On Fri, 25 Mar 2022 18:14:51 +0100, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The control

Re: [Intel-gfx] [PATCH] drm/i915: fix remaining_timeout in intel_gt_retire_requests_timeout

2022-03-25 Thread Das, Nirmoy
On 3/25/2022 6:58 PM, Daniele Ceraolo Spurio wrote: In intel_gt_wait_for_idle, we use the remaining timeout returned from intel_gt_retire_requests_timeout to wait on the GuC being idle. However, the returned variable can have a negative value if something goes wrong during the wait, leading to

[pull] amdgpu, amdkfd drm-next-5.18

2022-03-25 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.18. The following changes since commit c6e90a1c660874736bd09c1fec6312b4b4c2ff7b: Merge tag 'amd-drm-next-5.18-2022-03-18' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-03-21 13:48:20 +1000) are available in the Git repository at: https://g

Re: [PATCH] drm/i915: fix remaining_timeout in intel_gt_retire_requests_timeout

2022-03-25 Thread Matthew Brost
On Fri, Mar 25, 2022 at 10:58:39AM -0700, Daniele Ceraolo Spurio wrote: > In intel_gt_wait_for_idle, we use the remaining timeout returned from > intel_gt_retire_requests_timeout to wait on the GuC being idle. However, > the returned variable can have a negative value if something goes wrong > duri

[PATCH] drm/i915: fix remaining_timeout in intel_gt_retire_requests_timeout

2022-03-25 Thread Daniele Ceraolo Spurio
In intel_gt_wait_for_idle, we use the remaining timeout returned from intel_gt_retire_requests_timeout to wait on the GuC being idle. However, the returned variable can have a negative value if something goes wrong during the wait, leading to us hitting a GEM_BUG_ON in the GuC wait function. To fix

AW: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output

2022-03-25 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi, > > This commit corrects the printing of the IPU clock error percentage if > > it is between -0.1% to -0.9%. For example, if the pixel clock > > requested is 27.2 MHz but only 27.0 MHz can be achieved the deviation is - > 0.8%. > > But the fixed point math had a flaw and calculated error of 0.

Re: [PATCH 00/22] drm/mediatek: Add mt8195 DisplayPort driver

2022-03-25 Thread Guillaume Ranquet
On Fri, 25 Mar 2022 18:14, Guillaume Ranquet wrote: >this series is built around the DisplayPort driver. The dpi/dpintf >driver and the added helper functions are required for the DisplayPort >driver to work. > >This v9 is not quite ready yet, as project constraints forces me to >publish v9 this w

[PATCH v7 3/3] i915/gvt: Use the initial HW state snapshot saved in i915

2022-03-25 Thread Zhi Wang
The code of saving initial HW state snapshot has been moved into i915. Let the GVT-g core logic use that snapshot. Cc: Christoph Hellwig Cc: Jason Gunthorpe Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Vivi Rodrigo Cc: Zhenyu Wang Cc: Zhi Wang Signed-off-by: Zhi Wang --- drivers/gpu/drm/i915/g

[PATCH v7 2/3] i915/gvt: Save the initial HW state snapshot in i915

2022-03-25 Thread Zhi Wang
Save the initial HW state snapshot in i915 so that the rest code of GVT-g can be moved into a dedicated module while it can still get a clean initial HW state saved at the correct time during the initialization of i915. The futhrer vGPU created by GVT-g will use this HW state as the initial HW stat

[PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-03-25 Thread Zhi Wang
From: Zhi Wang To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g MMIO tracking table needs to be separated from GVT-g. v7: - Keep the marcos of device generation in GVT-g. (Christoph, Jani) v6: - Move the

[PATCH v7 0/3] Refactor GVT-g MMIO tracking table and handlers

2022-03-25 Thread Zhi Wang
To support the new mdev interfaces and the re-factor patches from Christoph, which moves the GVT-g code into a dedicated module, the GVT-g initialization path has to be separated into two phases: a) Early initialization. The early initialization of GVT requires to be done when loading i915. Mostl

Re: [PATCH 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-03-25 Thread Krzysztof Kozlowski
On 25/03/2022 18:43, Guillaume Ranquet wrote: > On Fri, 25 Mar 2022 18:31, Krzysztof Kozlowski wrote: >> On 25/03/2022 18:14, Guillaume Ranquet wrote: >>> From: Markus Schneider-Pargmann >>> >>> DP_INTF is similar to DPI but does not have the exact same feature set >>> or register layouts. >>> >>

Re: [PATCH 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-03-25 Thread Guillaume Ranquet
On Fri, 25 Mar 2022 18:31, Krzysztof Kozlowski wrote: >On 25/03/2022 18:14, Guillaume Ranquet wrote: >> From: Markus Schneider-Pargmann >> >> DP_INTF is similar to DPI but does not have the exact same feature set >> or register layouts. >> >> DP_INTF is the sink of the display pipeline that is co

Re: [PATCH 02/22] dt-bindings: mediatek,dp: Add Display Port binding

2022-03-25 Thread Krzysztof Kozlowski
On 25/03/2022 18:14, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > This controller is present on several mediatek hardware. Currently > mt8195 and mt8395 have this controller without a functional difference, > so only one compatible field is added. > > The controller can have tw

Re: [PATCH 03/22] dt-bindings: mediatek, dp_phy: Add Display Port PHY binding

2022-03-25 Thread Krzysztof Kozlowski
On 25/03/2022 18:14, Guillaume Ranquet wrote: > This phy controller is embedded in the Display Port Controller on mt8195 SoCs. > > Signed-off-by: Guillaume Ranquet > --- > .../bindings/phy/mediatek,dp-phy.yaml | 43 +++ > 1 file changed, 43 insertions(+) > create mode 10

Re: [PATCH 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-03-25 Thread Krzysztof Kozlowski
On 25/03/2022 18:14, Guillaume Ranquet wrote: > From: Markus Schneider-Pargmann > > DP_INTF is similar to DPI but does not have the exact same feature set > or register layouts. > > DP_INTF is the sink of the display pipeline that is connected to the > DisplayPort controller and encoder unit. It

[PATCH 14/22] drm/mediatek: dpi: move the csc_enable bit to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the csc_enable bit to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/d

[PATCH 17/22] phy: phy-mtk-dp: Add driver for DP phy

2022-03-25 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann This is a new driver that supports the integrated DisplayPort phy for mediatek SoCs, especially the mt8195. The phy is integrated into the DisplayPort controller and will be created by the mtk-dp driver. This driver expects a struct regmap to be able to work on the

[PATCH 21/22] drm/mediatek: change the aux retries times when receiving AUX_DEFER

2022-03-25 Thread Guillaume Ranquet
From: Jitao Shi DP 1.4a Section 2.8.7.1.5.6.1: A DP Source device shall retry at least seven times upon receiving AUX_DEFER before giving up the AUX transaction. Aux should retry to send msg whether how many bytes. Signed-off-by: Jitao Shi Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm

[PATCH 16/22] drm/meditek: dpi: Add matrix_sel helper

2022-03-25 Thread Guillaume Ranquet
Add a mtk_dpi_matrix_sel() helper to update the DPI_MATRIX_SET register depending on the color format. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/

[PATCH 22/22] drm/mediatek: DP audio support for mt8195

2022-03-25 Thread Guillaume Ranquet
This patch adds audio support to the DP driver for mt8195 with up to 8 channels. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 711 +- 1 file changed, 692 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/driv

[PATCH 12/22] drm/mediatek: dpi: move swap_shift to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the swap shift value to SoC specific config Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index

[PATCH 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver

2022-03-25 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. It supports the mt8195, the embedded DisplayPort units. It offers DisplayPort 1.4 with up to 4 lanes. The driver shares its iomap range with the mtk-dp-phy driver using the regmap/syscon facility.

[PATCH 20/22] drm/mediatek: add hpd debounce

2022-03-25 Thread Guillaume Ranquet
From: Jitao Shi >From the DP spec 1.4a chapter 3.3, upstream devices should implement HPD signal de-bouncing on an external connection. A period of 100ms should be used to detect an HPD connect event. To cover these cases, HPD de-bounce should be implemented only after HPD low has been detected f

[PATCH 15/22] drm/mediatek: dpi: Add dpintf support

2022-03-25 Thread Guillaume Ranquet
dpintf is the displayport interface hardware unit. This unit is similar to dpi and can reuse most of the code. This patch adds support for mt8195-dpintf to this dpi driver. Main differences are: - Some features/functional components are not available for dpintf which are now excluded from code

[PATCH 19/22] drm/mediatek: Add mt8195 External DisplayPort support

2022-03-25 Thread Guillaume Ranquet
This patch adds External DisplayPort support to the mt8195 eDP driver. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dp.c | 301 +++--- 1 file changed, 278 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/dr

[PATCH 13/22] drm/mediatek: dpi: move the yuv422_en_bit to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the yuv422 en bit to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/dr

[PATCH 11/22] drm/mediatek: dpi: move hvsize_mask to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the hvsize mask to SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c

[PATCH 09/22] drm/mediatek: dpi: implement a swap_input toggle in SoC config

2022-03-25 Thread Guillaume Ranquet
Adds a bit of flexibility to support SoCs without swap_input support Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_

[PATCH 07/22] drm/mediatek: dpi: move dpi limits to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the dpi limits to the SoC specific config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/med

[PATCH 10/22] drm/mediatek: dpi: move dimension mask to SoC config

2022-03-25 Thread Guillaume Ranquet
Add flexibility by moving the dimension mask to the SoC config Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/mediat

[PATCH 06/22] video/hdmi: Add audio_infoframe packing for DP

2022-03-25 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann Similar to HDMI, DP uses audio infoframes as well which are structured very similar to the HDMI ones. This patch adds a helper function to pack the HDMI audio infoframe for DP, called hdmi_audio_infoframe_pack_for_dp(). hdmi_audio_infoframe_pack_only() is split in

[PATCH 04/22] drm/edid: Convert cea_sad helper struct to kernelDoc

2022-03-25 Thread Guillaume Ranquet
Signed-off-by: Guillaume Ranquet --- include/drm/drm_edid.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index 144c495b99c4..5d4d840b9904 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -359,12

[PATCH 08/22] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config

2022-03-25 Thread Guillaume Ranquet
Adds a bit of flexibility to support SoCs without CK/DE pol support Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dpi.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediat

[PATCH 05/22] drm/edid: Add cea_sad helpers for freq/length

2022-03-25 Thread Guillaume Ranquet
This patch adds two helper functions that extract the frequency and word length from a struct cea_sad. For these helper functions new defines are added that help translate the 'freq' and 'byte2' fields into real numbers. Signed-off-by: Markus Schneider-Pargmann Signed-off-by: Guillaume Ranquet

[PATCH 03/22] dt-bindings: mediatek, dp_phy: Add Display Port PHY binding

2022-03-25 Thread Guillaume Ranquet
This phy controller is embedded in the Display Port Controller on mt8195 SoCs. Signed-off-by: Guillaume Ranquet --- .../bindings/phy/mediatek,dp-phy.yaml | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/mediatek,dp-phy.y

[PATCH 02/22] dt-bindings: mediatek,dp: Add Display Port binding

2022-03-25 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann This controller is present on several mediatek hardware. Currently mt8195 and mt8395 have this controller without a functional difference, so only one compatible field is added. The controller can have two forms, as a normal display port and as an embedded display

[PATCH 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

2022-03-25 Thread Guillaume Ranquet
From: Markus Schneider-Pargmann DP_INTF is similar to DPI but does not have the exact same feature set or register layouts. DP_INTF is the sink of the display pipeline that is connected to the DisplayPort controller and encoder unit. It takes the same clocks as DPI. Signed-off-by: Markus Schnei

[PATCH 00/22] drm/mediatek: Add mt8195 DisplayPort driver

2022-03-25 Thread Guillaume Ranquet
this series is built around the DisplayPort driver. The dpi/dpintf driver and the added helper functions are required for the DisplayPort driver to work. This v9 is not quite ready yet, as project constraints forces me to publish v9 this week, I'm sorry if it's not standard practice. Moreover, it

Re: [PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-25 Thread Doug Anderson
Hi, On Fri, Mar 25, 2022 at 7:11 AM Sankeerth Billakanti (QUIC) wrote: > > > > @@ -114,10 +114,12 @@ struct drm_bridge *dp_bridge_init(struct > > msm_dp *dp_display, struct drm_device * > > > bridge->funcs = &dp_bridge_ops; > > > bridge->type = dp_display->connector_type; > > > >

RE: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-25 Thread Sankeerth Billakanti
> -Original Message- > From: Doug Anderson > Sent: Friday, March 25, 2022 9:36 PM > To: Sankeerth Billakanti (QUIC) > Cc: Stephen Boyd ; David Airlie ; > dri-devel ; bjorn.anders...@linaro.org; > Thierry Reding ; Sam Ravnborg > ; Kuogee Hsieh (QUIC) ; > Andy Gross ; open list:OPEN FIRMW

Re: [PATCH v5 2/4] drm: introduce drm_writeback_connector_init_with_encoder() API

2022-03-25 Thread Abhinav Kumar
Hi Liviu On 3/25/2022 3:19 AM, Liviu Dudau wrote: On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks for the response. On 3/24/2022 3:12 AM, Liviu Dudau wrote: On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote: Hi Liviu Hello, Thanks f

Re: [PATCH v2 2/4] drm/atomic: Add atomic_print_state to private objects

2022-03-25 Thread kernel test robot
Hi Maxime, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.17 next-20220325] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-25 Thread Doug Anderson
Hi, On Fri, Mar 25, 2022 at 8:54 AM Sankeerth Billakanti (QUIC) wrote: > > > -Original Message- > > From: Doug Anderson > > Sent: Saturday, March 19, 2022 5:26 AM > > To: Stephen Boyd > > Cc: Sankeerth Billakanti (QUIC) ; open list:OPEN > > FIRMWARE AND FLATTENED DEVICE TREE BINDINGS >

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-25 Thread Adam Ford
On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski wrote: > > Hi Jagan, > > On 03.03.2022 17:36, Jagan Teki wrote: > > Updated series about drm bridge conversion of exynos dsi. > > > > Previous version can be accessible, here [1]. > > > > Patch 1: tc358764 panel_bridge API > > > > Patch 2: connecto

Re: [PATCH 1/2] dma-buf: add dma_fence_unwrap

2022-03-25 Thread Daniel Vetter
On Fri, Mar 25, 2022 at 01:56:23PM +0100, Christian König wrote: > Am 25.03.22 um 11:17 schrieb Daniel Vetter: > > On Fri, Mar 25, 2022 at 11:10:15AM +0100, Christian König wrote: > > > Am 25.03.22 um 11:07 schrieb Daniel Vetter: > > > > On Fri, Mar 25, 2022 at 11:03:54AM +0100, Daniel Vetter wrote

Re: Commit messages

2022-03-25 Thread Paul Menzel
Dear Christian, dear Daniel, dear Alex, Am 23.03.22 um 16:32 schrieb Christian König: Am 23.03.22 um 16:24 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: That's not what anyone's saying here ... No-one's demandi

RE: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-25 Thread Sankeerth Billakanti (QUIC)
> -Original Message- > From: Doug Anderson > Sent: Saturday, March 19, 2022 5:26 AM > To: Stephen Boyd > Cc: Sankeerth Billakanti (QUIC) ; open list:OPEN > FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; dri-devel ; > freedreno ; linux-arm-msm m...@vger.kernel.org>; LKML ; Rob Clark >

Re: [PATCH v4 6/6] drm/msm: make mdp5/dpu devices master components

2022-03-25 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-25 05:17:36) > The msm_mdss serves several roles at this moment. It provides IRQ domain > used by MDP5 and DPU drivers but it also serves as a component master > for both those usecases. MDP4 (which does not have separate MDSS device) > is the component master on i

[PATCH] dma-buf: WIP dma_fence_array_first fix

2022-03-25 Thread Christian König
Looks like somebody is creating an empty dma_fence_array. Signed-off-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c index 52b85d292383..5c8a7084577b 100644 -

Re: [PATCH] drm/amd: Re-classify some log messages in commit path

2022-03-25 Thread Alex Deucher
Thanks. Fixed up the title when I applied it. Alex On Fri, Mar 25, 2022 at 10:55 AM Harry Wentland wrote: > > On 2022-03-24 20:06, Sean Paul wrote: > > From: Sean Paul > > > > ATOMIC and DRIVER log categories do not typically contain per-frame log > > messages. This patch re-classifies some me

Re: [PATCH 1/2] dma-buf: add dma_fence_unwrap

2022-03-25 Thread Christian König
Am 25.03.22 um 16:25 schrieb Ville Syrjälä: On Fri, Mar 11, 2022 at 12:02:43PM +0100, Christian König wrote: Add a general purpose helper to deep dive into dma_fence_chain/dma_fence_array structures and iterate over all the fences in them. This is useful when we need to flatten out all fences i

Re: [PATCH 1/2] dma-buf: add dma_fence_unwrap

2022-03-25 Thread Ville Syrjälä
On Fri, Mar 11, 2022 at 12:02:43PM +0100, Christian König wrote: > Add a general purpose helper to deep dive into dma_fence_chain/dma_fence_array > structures and iterate over all the fences in them. > > This is useful when we need to flatten out all fences in those structures. > > Signed-off-by:

Re: [PATCH] drm/vmwgfx: Propagate error on failed ioctl

2022-03-25 Thread Javier Martinez Canillas
Hello Philipp, On 3/13/22 06:06, Philipp Sieweck wrote: > The cases of vmw_user_bo_synccpu_grab failing with -ERESTARTSYS or -EBUSY > are handled in vmw_user_bo_synccpu_ioctl by not printing an error message. > However, the error value gets discarded, indicating success. This leads > to rendering

Re: [PATCH v6 6/6] drm: exynos: dsi: Switch to atomic funcs

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > The new support drm bridges are moving towards atomic functions. > > Replace atomic version of functions to continue the transition > to the atomic API. > > Signed-off-by: Jagan Teki Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski > --- > Chan

Re: [PATCH v6 5/6] drm: exynos: dsi: Convert to bridge driver

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > Convert the encoders to bridge drivers in order to standardize on > a single API with built-in dumb encoder support for compatibility > with existing component drivers. > > Driver bridge conversion will help to reuse the same bridge on > different platform

Re: [PATCH v6 4/6] drm: exynos: dsi: Use drm panel_bridge API

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > Replace the manual panel handling code by a drm panel_bridge via > devm_drm_of_get_bridge(). > > Adding panel_bridge handling, > > - Drops drm_connector and related operations as drm_bridge_attach >creates connector during attachment. > > - Drops panel

Re: [PATCH v6 3/6] exynos: drm: dsi: Attach in_bridge in MIC driver

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > MIC drivers in the Exynos5433 display pipeline are already registered > as bridge drivers and it is more advisable to attach the downstream > bridge on the bridge attach call instead of doing the same in the > DSI driver. > > This makes bridge attachment m

Re: [PATCH v6 2/6] drm: bridge: panel: Reset the connector state pointer

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > Trigger hotplug event with drm_kms_helper_hotplug_event might fail if the > connector state pointer is NULL. > > BUG observed in exynos dsi driver where drm_bridge_attach is trying to > register > a connector in panel_bridge before the hotplug event is tr

Re: [PATCH v6 1/6] drm: bridge: tc358764: Use drm panel_bridge API

2022-03-25 Thread Marek Szyprowski
On 03.03.2022 17:36, Jagan Teki wrote: > Replace the manual panel handling code by a drm panel_bridge via > devm_drm_of_get_bridge(). > > Adding panel_bridge handling, > > - Drops drm_connector and related operations as drm_bridge_attach >creates connector during attachment. > > - Drops panel

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-25 Thread Marek Szyprowski
Hi Jagan, On 03.03.2022 17:36, Jagan Teki wrote: > Updated series about drm bridge conversion of exynos dsi. > > Previous version can be accessible, here [1]. > > Patch 1: tc358764 panel_bridge API > > Patch 2: connector reset > > Patch 3: bridge attach in MIC > > Patch 4: panel_bridge API > > Pat

Re: [PATCH] drm/amd: Re-classify some log messages in commit path

2022-03-25 Thread Harry Wentland
On 2022-03-24 20:06, Sean Paul wrote: > From: Sean Paul > > ATOMIC and DRIVER log categories do not typically contain per-frame log > messages. This patch re-classifies some messages in amd to chattier > categories to keep ATOMIC/DRIVER quiet. > > Signed-off-by: Sean Paul With the subject line

Re: [PATCH v2 3/25] drm/amdgpu: Disable ABM when AC mode

2022-03-25 Thread Harry Wentland
On 2022-03-25 00:05, Ryan Lin wrote: > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. It says patch 3 out of 25. Are there other patches? If so, I can't find them in my mailbox and neither can patchwork https://patchwork.freedesktop.

Re: [git pull] drm fixes for 5.18-rc1

2022-03-25 Thread Thomas Zimmermann
Hi Am 25.03.22 um 03:13 schrieb Dave Airlie: Hi Linus, Some fixes were queued up in and in light of the fbdev regressions, I've pulled those in as well, I think the mediatek one is going to be a bit more painful, since now you have a merge and I need to have the mediatek stuff get rebased and r

RE: [PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-25 Thread Sankeerth Billakanti (QUIC)
> -Original Message- > From: Stephen Boyd > Sent: Friday, March 18, 2022 3:08 AM > To: Sankeerth Billakanti (QUIC) ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > freedr...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: robd

[PATCH v2 1/4] drm/atomic: Print the state every commit

2022-03-25 Thread Maxime Ripard
The DRM_UT_STATE controls whether we're calling drm_atomic_print_new_state() whenever a new state is committed. However, that call is made in the drm_mode_atomic_ioctl(), whereas we have multiple users of the drm_atomic_commit() function in the kernel (framebuffer emulation, drm_atomic_helper_dirty

RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Sankeerth Billakanti (QUIC)
> -Original Message- > From: Stephen Boyd > Sent: Friday, March 18, 2022 2:53 AM > To: Sankeerth Billakanti (QUIC) ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > freedr...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: robd

Re: Parallel modesets and private state objects broken, where to go with MST?

2022-03-25 Thread Maxime Ripard
Hi Lyude, On Mon, Mar 14, 2022 at 06:16:36PM -0400, Lyude Paul wrote: > Hi! First a little bit of background: I've recently been trying to get rid of > all of the non-atomic payload bandwidth management code in the MST helpers in > order to make it easier to implement DSC and fallback link rate re

Re: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Doug Anderson
Hi, On Fri, Mar 25, 2022 at 6:41 AM Sankeerth Billakanti (QUIC) wrote: > > > -Original Message- > > From: Doug Anderson > > Sent: Friday, March 18, 2022 10:51 PM > > To: Sankeerth Billakanti (QUIC) > > Cc: dri-devel ; linux-arm-msm > m...@vger.kernel.org>; freedreno ; > > LKML ; open l

RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-25 Thread Sankeerth Billakanti (QUIC)
> -Original Message- > From: Doug Anderson > Sent: Friday, March 18, 2022 10:51 PM > To: Sankeerth Billakanti (QUIC) > Cc: dri-devel ; linux-arm-msm m...@vger.kernel.org>; freedreno ; > LKML ; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS ; Rob Clark > ; Sean Paul ; Step

RE: [PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for eDP panel

2022-03-25 Thread Sankeerth Billakanti (QUIC)
> -Original Message- > From: Stephen Boyd > Sent: Friday, March 18, 2022 2:58 AM > To: Sankeerth Billakanti (QUIC) ; > devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > freedr...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: robd

Re: [PATCH v2 3/25] drm/amdgpu: Disable ABM when AC mode

2022-03-25 Thread Alex Deucher
On Fri, Mar 25, 2022 at 2:27 AM Ryan Lin wrote: > > Disable ABM feature when the system is running on AC mode to get > the more perfect contrast of the display. > > Signed-off-by: Ryan Lin > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device

Re: [PATCH 3/9] drm/edid: use struct detailed_timing member access in is_rb()

2022-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2022 at 02:25:25PM +0200, Jani Nikula wrote: > Use struct detailed_timing member access instead of direct offsets to > avoid casting. > > Use BUILD_BUG_ON() for sanity check. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > > --- > > Note: Why can we use range.formula.cvt.

Re: [PATCH v2 -next] drm/vc4: Fix build error when CONFIG_DRM_VC4=y && CONFIG_RASPBERRYPI_FIRMWARE=m

2022-03-25 Thread Maxime Ripard
Hi, On Fri, Mar 25, 2022 at 10:18:31AM +0800, Zheng Bin wrote: > If CONFIG_DRM_VC4=y, CONFIG_RASPBERRYPI_FIRMWARE=m, CONFIG_COMPILE_TEST=n, > bulding fails: > > drivers/gpu/drm/vc4/vc4_drv.o: In function `vc4_drm_bind': > vc4_drv.c:(.text+0x320): undefined reference to `rpi_firmware_get' > vc4_dr

Re: [PATCH 1/9] drm/edid: don't modify EDID while parsing

2022-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2022 at 02:25:23PM +0200, Jani Nikula wrote: > We'll want to keep the EDID immutable while parsing. Stop modifying the > EDID because of the quirks. > > In theory, this does have userspace implications, but the userspace is > supposed to use the modes exposed via KMS API, not by pa

[PATCH v2 2/4] drm/atomic: Add atomic_print_state to private objects

2022-03-25 Thread Maxime Ripard
A number of drivers (amdgpu, komeda, vc4, etc.) leverage the drm_private_state structure, but we don't have any infrastructure to provide debugging like we do for the other components state. Let's add an atomic_print_state hook to be consistent. Reviewed-by: Daniel Vetter Signed-off-by: Maxime Ri

Re: [PATCH 1/2] dma-buf: add dma_fence_unwrap

2022-03-25 Thread Christian König
Am 25.03.22 um 11:17 schrieb Daniel Vetter: On Fri, Mar 25, 2022 at 11:10:15AM +0100, Christian König wrote: Am 25.03.22 um 11:07 schrieb Daniel Vetter: On Fri, Mar 25, 2022 at 11:03:54AM +0100, Daniel Vetter wrote: On Fri, Mar 11, 2022 at 12:02:43PM +0100, Christian König wrote: Add a genera

Re: [PATCH 2/9] drm/edid: pass a timing pointer to is_display_descriptor()

2022-03-25 Thread Ville Syrjälä
On Fri, Mar 25, 2022 at 02:25:24PM +0200, Jani Nikula wrote: > Use struct member access instead of direct offsets to avoid lots of > casts all over the place. > > Use BUILD_BUG_ON() for sanity check. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 26 +++

[PATCH v2 3/4] drm/vc4: Constify private state accessors

2022-03-25 Thread Maxime Ripard
None of those helpers modify the pointed data, let's make them const. Acked-by: Daniel Vetter Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c i

[PATCH v2 4/4] drm/vc4: Implement atomic_print_state for HVS channel state

2022-03-25 Thread Maxime Ripard
The HVS state configuration is useful when debugging what's going on in the vc4 hardware pipeline. Add an implementation of .atomic_print_state. Acked-by: Daniel Vetter Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 17 + 1 file changed, 17 insertions(+) diff

[PATCH v2 0/4] drm/atomic: Atomic Private State debugging

2022-03-25 Thread Maxime Ripard
Hi, This series adds an atomic_print_state hook for drm_private_obj to ease the debugging of driver-specific sub-classes, and adds one for vc4. It also changes the call site of drm_atomic_print_new_state to make it more consistent. Let me know what you think, Maxime Changes from v1: - Added D

[PATCH 9/9] drm/edid: add more general struct edid constness in the interfaces

2022-03-25 Thread Jani Nikula
With this, the remaining non-const parts are the ones that actually modify the EDID, for example to fix corrupt EDID. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- include/drm/drm_edid.h | 10 +- 2 files changed, 16 insertion

[PATCH 7/9] drm/edid: constify struct edid passed to detailed blocks

2022-03-25 Thread Jani Nikula
Constify the first level of struct edid in detailed timing parsing. Also switch to struct edid instead of u8. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 ++ 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/

[PATCH 8/9] drm/edid: constify struct edid passed around in callbacks and closure

2022-03-25 Thread Jani Nikula
Finalize detailed timing parsing constness by making struct edid also const in callbacks and closure. Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/

  1   2   >