Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
Ted wrote: > On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > > Yes, right. DEPT has never been optimized. It rather turns on > > CONFIG_LOCKDEP and even CONFIG_PROVE_LOCKING when CONFIG_DEPT gets on > > because of porting issue. I have no choice but to rely on those to > >

[PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0

2022-05-09 Thread Wan Jiabing
Fix following coccicheck warning: ./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or | Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK. Signed-off-by: Wan Jiabing --- drivers/Gap/drm/amd/amdgpu/vcn_v4_0.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-09 Thread Rex-BC Chen
On 5/9/22 4:45 PM, Rex-BC Chen wrote: On Mon, 2022-05-09 at 15:31 +0800, Krzysztof Kozlowski wrote: On 09/05/2022 06:43, Rex-BC Chen wrote: From: "Nancy.Lin" Add vdosys1 RDMA definition. Signed-off-by: Nancy.Lin Reviewed-by: AngeloGioacchino Del Regno <

[PATCH] drm/amdgpu: Return true/false (not 1/0) from bool functions

2022-05-09 Thread Haowen Bai
Return boolean values ("true" or "false") instead of 1 or 0 from bool functions. Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-09 Thread Peter Geis
On Mon, May 9, 2022 at 3:49 PM Piotr Oniszczuk wrote: > > > > > If you want to confirm the hardware is configured correctly you can > > remove the cec pin from the hdmi node and set up a cec-gpio node. > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > Yes, right. DEPT has never been optimized. It rather turns on > CONFIG_LOCKDEP and even CONFIG_PROVE_LOCKING when CONFIG_DEPT gets on > because of porting issue. I have no choice but to rely on those to > develop DEPT out of tree.

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
On Mon, May 09, 2022 at 06:28:17PM -0400, Theodore Ts'o wrote: > Oh, one other problem with DEPT --- it's SLOW --- the overhead is > enormous. Using kvm-xfstests[1] running "kvm-xfstests smoke", here > are some sample times: Yes, right. DEPT has never been optimized. It rather turns on

Re: 5.18 vmwgfx seems to break booting VirtualBox VMs

2022-05-09 Thread Zack Rusin
> On May 9, 2022, at 6:57 AM, Hans de Goede wrote: > > Hi Zack, > > On 4/11/22 16:24, Zack Rusin wrote: >> On Mon, 2022-04-11 at 10:52 +0200, Hans de Goede wrote: >>> Hi All, >>> >>> Fedora has received a bug report here: >>> >>>

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
On Mon, May 09, 2022 at 04:47:12PM -0400, Steven Rostedt wrote: > On Mon, 9 May 2022 09:16:37 +0900 > Byungchul Park wrote: > > > CASE 2. > > > >lock L with depth n > >lock A > >lock_nested L' with depth n + 1 > >... > >unlock L' > >unlock A > >unlock L > > > > This

[PATCH v2] drm: Document the power requirements for DP AUX transfers

2022-05-09 Thread Douglas Anderson
When doing DP AUX transfers there are two actors that need to be powered in order for the DP AUX transfer to work: the DP source and the DP sink. Commit bacbab58f09d ("drm: Mention the power state requirement on side-channel operations") added some documentation saying that the DP source is

Re: [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-05-09 Thread Niranjana Vishwanathapura
On Wed, Apr 27, 2022 at 08:41:35AM -0700, Niranjana Vishwanathapura wrote: On Wed, Apr 20, 2022 at 03:45:25PM -0700, Niranjana Vishwanathapura wrote: On Thu, Mar 31, 2022 at 10:28:48AM +0200, Daniel Vetter wrote: Adding a pile of people who've expressed interest in vm_bind for their drivers.

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Javier Martinez Canillas
On 5/10/22 00:22, Andrzej Hajda wrote: [snip] >> static void drm_fbdev_fb_destroy(struct fb_info *info) >> { >> + if (info->cmap.len) >> + fb_dealloc_cmap(>cmap); >> + >> drm_fbdev_release(info->par); >> + framebuffer_release(info); > > I would put

Re: [PATCH 13/25] drm/msm/dpu: pass dpu_format to _dpu_hw_sspp_setup_scaler3()

2022-05-09 Thread Abhinav Kumar
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote: There is no need to pass full dpu_hw_pipe_cfg instance to _dpu_hw_sspp_setup_scaler3, pass just struct dpu_format pointer. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 9 -

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
Oh, one other problem with DEPT --- it's SLOW --- the overhead is enormous. Using kvm-xfstests[1] running "kvm-xfstests smoke", here are some sample times: LOCKDEP DEPT Time to first test 49 seconds 602 seconds ext4/0012 s 22

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Andrzej Hajda
On 09.05.2022 22:03, Javier Martinez Canillas wrote: On 5/9/22 20:12, Thomas Zimmermann wrote: [snip] I actually thought about the same but then remembered what Daniel said in [0] (AFAIU at least) that these should be done in .remove() so the current code looks like matches that and only

[PATCH v2] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-09 Thread Kuogee Hsieh
dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable interrupts after software reset of controller. This patch removes the enable flag condition

Re: [PATCH] drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl()

2022-05-09 Thread Kuogee Hsieh
On 5/6/2022 5:29 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-05-06 14:41:07) dp_catalog_ctrl_reset() will software reset DP controller. But it will not reset programmable registers to default value. DP driver still have to clear mask bits to interrupt status registers to disable

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread kernel test robot
Hi Jocelyn, Thank you for the patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on v5.18-rc6] [cannot apply to drm/drm-next drm-tip/drm-tip airlied/drm-next next-20220509] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
I tried DEPT-v6 applied against 5.18-rc5, and it reported the following positive. The reason why it's nonsense is that in context A's [W] wait: [ 1538.545054] [W] folio_wait_bit_common(pglocked:0): [ 1538.545370] [] __filemap_get_folio+0x3e4/0x420 [ 1538.545763] stacktrace: [ 1538.545928]

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread Jocelyn Falempe
On 09/05/2022 18:04, Michel Dänzer wrote: On 2022-05-09 16:22, Thomas Zimmermann wrote: It might also make sense to adjust the starting value of the lut table such that its final entry is used for the final entry in the HW palette. For typical gamma ramps ~2, the curve is fairly flat for

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Steven Rostedt
On Mon, 9 May 2022 09:16:37 +0900 Byungchul Park wrote: > CASE 2. > >lock L with depth n >lock A >lock_nested L' with depth n + 1 >... >unlock L' >unlock A >unlock L > > This case is allowed by Lockdep. > This case is *NOT* allowed by DEPT cuz it's a *DEADLOCK*. >

Re: [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

2022-05-09 Thread Luis Chamberlain
On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote: > Currently, kernel/module annotates module dependencies when > request_symbol is used, but it doesn't cover more complex inter-driver > dependencies that are subsystem and/or driver-specific. > At this pount v5.18-rc7 is out

Re: [PATCH v3 4/5] drm/gud: Map framebuffer BOs with drm_gem_fb_vmap()

2022-05-09 Thread Noralf Trønnes
Den 09.05.2022 10.32, skrev Thomas Zimmermann: > Hi Noralf > > Am 06.05.22 um 16:11 schrieb Thomas Zimmermann: >> Hi >> >> Am 06.05.22 um 16:01 schrieb Noralf Trønnes: >>> Hi Thomas, >>> >>> I'm getting this on Ubuntu 22.04: >>> >>> [    0.00] Linux version 5.15.0-27-generic

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Javier Martinez Canillas
On 5/9/22 20:12, Thomas Zimmermann wrote: [snip] >> I actually thought about the same but then remembered what Daniel said in [0] >> (AFAIU at least) that these should be done in .remove() so the current code >> looks like matches that and only framebuffer_release() should be moved. >> >> For

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Javier Martinez Canillas
Hello Thomas, On 5/9/22 20:32, Thomas Zimmermann wrote: > Hi > > Am 09.05.22 um 18:33 schrieb Javier Martinez Canillas: >> On 5/9/22 17:51, Andrzej Hajda wrote: >> >> [snip] >> >> + > Regarding drm: > What about drm_fb_helper_fini? It calls also framebuffer_release and is >

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-09 Thread Piotr Oniszczuk
> > If you want to confirm the hardware is configured correctly you can > remove the cec pin from the hdmi node and set up a cec-gpio node. > https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/media/cec-gpio.txt > > For some reason the board developers decided to

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Thomas Zimmermann
Hi Am 09.05.22 um 18:33 schrieb Javier Martinez Canillas: On 5/9/22 17:51, Andrzej Hajda wrote: [snip] + Regarding drm: What about drm_fb_helper_fini? It calls also framebuffer_release and is called often from _remove paths (checked intel/radeon/nouveau). I guess it should be fixed as well.

Re: [PATCH 00/14] drm/vc4: Properly separate v3d on BCM2711, and fix frame ordering

2022-05-09 Thread Melissa Wen
On 05/03, Maxime Ripard wrote: > Hi, > > Here's a series that fixes a significant issue we missed when adding support > for the BCM2711 / RaspberryPi4 in the vc4 driver. > > Indeed, before the introduction of the BCM2711 support, the GPU was fairly > intertwined with the display hardware, and

Re: [PATCH] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-09 Thread Lyude Paul
Also JFYI Mark - I just realized that your email client is defaulting to sending HTML mail when you reply to me, that doesn't really make it onto the mailing list at all so you probably want to fix that. Also - I misspoke here again, I think it should actually be a call to

RE: RX 5500 XT: PCIe link speed stuck at Gen1 2.5GT/s by default

2022-05-09 Thread Deucher, Alexander
[Public] > -Original Message- > From: Bjorn Helgaas > Sent: Wednesday, March 30, 2022 7:45 AM > To: linux-...@vger.kernel.org > Cc: Deucher, Alexander ; Robert Hancock > ; dri-devel@lists.freedesktop.org > Subject: RX 5500 XT: PCIe link speed stuck at Gen1 2.5GT/s by default > > See >

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Thomas Zimmermann
Hi Javier Am 09.05.22 um 18:33 schrieb Javier Martinez Canillas: On 5/9/22 17:51, Andrzej Hajda wrote: [snip] + Regarding drm: What about drm_fb_helper_fini? It calls also framebuffer_release and is called often from _remove paths (checked intel/radeon/nouveau). I guess it should be fixed

RE: [Bug 215958] New: thunderbolt3 egpu cannot disconnect cleanly

2022-05-09 Thread Deucher, Alexander
[Public] > -Original Message- > From: Bjorn Helgaas > Sent: Monday, May 9, 2022 12:23 PM > To: Linux PCI > Cc: r087...@yahoo.it; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; amd-gfx > mailing list ; dri-devel de...@lists.freedesktop.org> > Subject: Re: [Bug 215958] New:

Re: [PATCH] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-09 Thread Lyude Paul
On Mon, 2022-05-09 at 15:13 +0200, Mark Menzynski wrote: > I think there are no direct issues with initialization in the state how it > is now. I suspect it's because "drm_kms_helper_poll_enable()" starts the > first worker thread with a delay, which gives enough time to initialize > required

Re: [PATCH 13/14] drm/vc4: crtc: Fix out of order frames during asynchronous page flips

2022-05-09 Thread Melissa Wen
O 05/09, Melissa Wen wrote: > On 05/03, Maxime Ripard wrote: > > When doing an asynchronous page flip (PAGE_FLIP ioctl with the > > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the > > possible GPU buffer being rendered through a call to > > vc4_queue_seqno_cb(). > > > > On the

Re: [PATCH 13/14] drm/vc4: crtc: Fix out of order frames during asynchronous page flips

2022-05-09 Thread Melissa Wen
On 05/03, Maxime Ripard wrote: > When doing an asynchronous page flip (PAGE_FLIP ioctl with the > DRM_MODE_PAGE_FLIP_ASYNC flag set), the current code waits for the > possible GPU buffer being rendered through a call to > vc4_queue_seqno_cb(). > > On the BCM2835-37, the GPU driver is part of the

Re: [Intel-gfx] [PATCH v5 1/2] module: update dependencies at try_module_get()

2022-05-09 Thread Mauro Carvalho Chehab
Em Thu, 5 May 2022 23:35:29 +0200 Andi Shyti escreveu: > Hi Mauro, > > [...] > > > +static int ref_module_dependency(struct module *mod, struct module *this) > > +{ > > + int ret; > > + > > + if (!this || !this->name) > > + return -EINVAL; > > + > > + if (mod == this) > > +

Re: [PATCH 14/14] drm/vc4: Warn if some v3d code is run on BCM2711

2022-05-09 Thread Melissa Wen
On 05/03, Maxime Ripard wrote: > The BCM2711 has a separate driver for the v3d, and thus we can't call > into any of the driver entrypoints that rely on the v3d being there. > > Let's add a bunch of checks and complain loudly if that ever happen. > > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH 05/14] drm/vc4: drv: Register a different driver on BCM2711

2022-05-09 Thread Melissa Wen
On 05/03, Maxime Ripard wrote: > Prior to the BCM2711/RaspberryPi4, the GPU was a part of the display > components of the SoC. It was thus a part of the vc4 driver. > > However, with the BCM2711, it got split out and thus the v3d driver was > created. The vc4 driver now only handles the display

Re: [pull] drm/msm: drm-msm-next-2022-05-09 for v5.19

2022-05-09 Thread Rob Clark
On Mon, May 9, 2022 at 9:02 AM Rob Clark wrote: > > Hi Dave & Daniel, > > Here is the main drm/msm pull request for v5.19, containing: > > - Fourcc modifier for tiled but not compressed layouts > - Support for userspace allocated IOVA (GPU virtual address) > - Devfreq clamp_to_idle fix > -

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Javier Martinez Canillas
On 5/9/22 17:51, Andrzej Hajda wrote: [snip] + >>> Regarding drm: >>> What about drm_fb_helper_fini? It calls also framebuffer_release and is >>> called often from _remove paths (checked intel/radeon/nouveau). I guess >>> it should be fixed as well. Do you plan to fix it? >>> >> I think you

[PATCH v6 3/4] module: set holders when symbol_get() is used

2022-05-09 Thread Mauro Carvalho Chehab
Some Kernel modules use symbol_get() or symbol_request() in order to bind into other drivers. That's the case, for instance, of media dvb drivers that hook the frontend drivers via I2C using dvb_attach() macro. When such bindings happen, one needs first to unload/unbind the driver that got the

[PATCH v6 4/4] ALSA: hda - identify when audio is provided by a video driver

2022-05-09 Thread Mauro Carvalho Chehab
On some devices, the hda driver needs to hook into a video driver, in order to be able to properly access the audio hardware and/or the power management function. That's the case of several snd_hda_intel devices that depends on i915 driver. Ensure that a proper reference between the snd-hda

[PATCH v6 2/4] module: update dependencies at try_module_get()

2022-05-09 Thread Mauro Carvalho Chehab
Sometimes, device drivers are bound into each other via try_module_get(), making such references invisible when looking at /proc/modules or lsmod. Add a function to allow setting up module references for such cases, and call it when try_module_get() is used. Reviewed-by: Dan Williams

[PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

2022-05-09 Thread Mauro Carvalho Chehab
Currently, kernel/module annotates module dependencies when request_symbol is used, but it doesn't cover more complex inter-driver dependencies that are subsystem and/or driver-specific. That's because module_try_get() and symbol_get() doesn't try to setup the module owner. In the case of hdmi

[PATCH v6 1/4] module: drop prototype for non-existing __symbol_get_gpl()

2022-05-09 Thread Mauro Carvalho Chehab
There's no such function, and __symbol_get() is already declared as GPL. So, this is likely a left-over. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v6 0/4] at: https://lore.kernel.org/all/cover.1652113087.git.mche...@kernel.org/ include/linux/module.h | 1 - 1 file changed, 1

Re: [PATCH 5.10 1/1] drm/amdgpu: Ensure the AMDGPU file descriptor is legitimate

2022-05-09 Thread Greg KH
On Mon, May 09, 2022 at 03:49:03PM +0100, Lee Jones wrote: > On Thu, 14 Apr 2022, Greg KH wrote: > > > On Tue, Apr 12, 2022 at 04:20:57PM +0100, Lee Jones wrote: > > > [ Upstream commit b40a6ab2cf9213923bf8e821ce7fa7f6a0a26990 ] > > > > > > This is a partial cherry-pick of the above upstream

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread Michel Dänzer
On 2022-05-09 16:22, Thomas Zimmermann wrote: > > It might also make sense to adjust the starting value of the lut table such > that its final entry is used for the final entry in the HW palette. For > typical gamma ramps ~2, the curve is fairly flat for small values and goes up > steeply at

[pull] drm/msm: drm-msm-next-2022-05-09 for v5.19

2022-05-09 Thread Rob Clark
Hi Dave & Daniel, Here is the main drm/msm pull request for v5.19, containing: - Fourcc modifier for tiled but not compressed layouts - Support for userspace allocated IOVA (GPU virtual address) - Devfreq clamp_to_idle fix - DPU: DSC (Display Stream Compression) support - DPU: inline

Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a

2022-05-09 Thread Peter Geis
On Sun, May 8, 2022 at 2:21 PM Piotr Oniszczuk wrote: > > > >> > >> I think i have this already (pls see L231/L232 in > >> https://pastebin.com/67wu9QrH ) > > > > I see you have hdmitxm1_cec as the enabled pin. Are you certain it's > > the m1 pin and not the m0 pin? > > It depends on board ver.

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Andrzej Hajda
On 09.05.2022 17:30, Javier Martinez Canillas wrote: Hello Andrzej, On 5/9/22 16:56, Andrzej Hajda wrote: On 06.05.2022 00:04, Javier Martinez Canillas wrote: From: Daniel Vetter Most fbdev drivers have issues with the fb_info lifetime, because call to framebuffer_release() from their

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread Jocelyn Falempe
On 09/05/2022 16:22, Thomas Zimmermann wrote: Hi, first of all Tested-by: Thomas Zimemrmann on G200EH. I clicked a bit in Gnome settings and the display changed colors. It's pretty cool. yeah, I also played a bit with https://github.com/zb3/gnome-gamma-tool Am 09.05.22 um 11:49 schrieb

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Javier Martinez Canillas
Hello Andrzej, On 5/9/22 16:56, Andrzej Hajda wrote: > On 06.05.2022 00:04, Javier Martinez Canillas wrote: >> From: Daniel Vetter >> >> Most fbdev drivers have issues with the fb_info lifetime, because call to >> framebuffer_release() from their driver's .remove callback, rather than >> doing

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-09 Thread Mark Brown
On Mon, May 09, 2022 at 03:54:11PM +0200, Daniel Vetter wrote: > On Fri, May 06, 2022 at 01:42:37PM +0100, Mark Brown wrote: > > Not outside of the source. I did a presentation at ELC-E ages > > ago which you can probably find but I'm not sure how much it > > would add. > I watched that one!

Re: [RFC PATCH 0/1] drm/vkms: ConfigFS support

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 12:18:20AM +, Jim Shargo wrote: > Hi! > > I wanted to send this patch out early to get some feedback on the layout > of the code and new ConfigFS directory. I intend to follow this up with > a more complete patch set that uses this to, for instance, add more >

Re: [PATCH 8/8] drm: move ttm_execbuf_util into vmwgfx

2022-05-09 Thread Christian König
Am 09.05.22 um 16:33 schrieb Daniel Vetter: On Wed, May 04, 2022 at 09:47:39AM +0200, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it starts using GEM as well. Signed-off-by: Christian König I guess this is a bit annoying

Re: [PATCH 1/8] drm: execution context for GEM buffers v2

2022-05-09 Thread Christian König
Am 09.05.22 um 16:31 schrieb Daniel Vetter: On Wed, May 04, 2022 at 09:47:32AM +0200, Christian König wrote: [SNIP] +/* Make sure we have enough room and add an object the container */ +static int drm_exec_objects_add(struct drm_exec_objects *container, + struct

Re: [PATCH v3 1/4] fbdev: Prevent possible use-after-free in fb_release()

2022-05-09 Thread Andrzej Hajda
On 06.05.2022 00:04, Javier Martinez Canillas wrote: From: Daniel Vetter Most fbdev drivers have issues with the fb_info lifetime, because call to framebuffer_release() from their driver's .remove callback, rather than doing from fbops.fb_destroy callback. Doing that will destroy the fb_info

Re: [PATCH 5.10 1/1] drm/amdgpu: Ensure the AMDGPU file descriptor is legitimate

2022-05-09 Thread Lee Jones
On Thu, 14 Apr 2022, Greg KH wrote: > On Tue, Apr 12, 2022 at 04:20:57PM +0100, Lee Jones wrote: > > [ Upstream commit b40a6ab2cf9213923bf8e821ce7fa7f6a0a26990 ] > > > > This is a partial cherry-pick of the above upstream commit. > > > > It ensures the file descriptor passed in by userspace is

Re: [bug report] drm/msm: devcoredump iommu fault support

2022-05-09 Thread Rob Clark
On Sun, May 8, 2022 at 11:28 PM Dan Carpenter wrote: > > Hello Rob Clark, > > The patch e25e92e08e32: "drm/msm: devcoredump iommu fault support" > from Jun 10, 2021, leads to the following Smatch static checker > warning: > > drivers/gpu/drm/msm/msm_gpu.c:418 recover_worker() error: dereferencing

Re: [PATCH] drm: bridge: DRM_FSL_LDB should depend on ARCH_MXC

2022-05-09 Thread Marek Vasut
On 5/9/22 15:52, Geert Uytterhoeven wrote: The Freescale i.MX8MP LDB bridge is only present on Freescale i.MX8MP SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without i.MX SoC support. Fixes: 463db5c2ed4aed01 ("drm: bridge:

Re: [PATCH v2] Revert "fbdev: Make fb_release() return -ENODEV if fbdev was unregistered"

2022-05-09 Thread Javier Martinez Canillas
Hello Tim, On 5/9/22 16:01, pub...@timruffing.de wrote: > Thanks for this patch. Do you think this can be backported to LTS 5.17.y and You are welcome. > 5.15.y, which are still buggy? It's not a big deal for me but others might > profit. > > Background: > The patch solves a regression from

Re: [PATCH 8/8] drm: move ttm_execbuf_util into vmwgfx

2022-05-09 Thread Daniel Vetter
On Wed, May 04, 2022 at 09:47:39AM +0200, Christian König wrote: > VMWGFX is the only remaining user of this and should probably moved over > to drm_exec when it starts using GEM as well. > > Signed-off-by: Christian König I guess this is a bit annoying since it means we can't require drm_exec

Re: [PATCH 1/8] drm: execution context for GEM buffers v2

2022-05-09 Thread Daniel Vetter
On Wed, May 04, 2022 at 09:47:32AM +0200, Christian König wrote: > This adds the infrastructure for an execution context for GEM buffers > which is similar to the existinc TTMs execbuf util and intended to replace > it in the long term. > > The basic functionality is that we abstracts the

Re: [PATCH] mgag200: Enable atomic gamma lut update

2022-05-09 Thread Thomas Zimmermann
Hi, first of all Tested-by: Thomas Zimemrmann on G200EH. I clicked a bit in Gnome settings and the display changed colors. It's pretty cool. Am 09.05.22 um 11:49 schrieb Jocelyn Falempe: Add support for atomic update of gamma lut. With this patch the "Night light" feature of gnome3 is

Re: [PATCH 5/5] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-05-09 Thread Tvrtko Ursulin
On 07/05/2022 00:34, Matt Roper wrote: On Thu, Apr 28, 2022 at 01:18:42PM +0100, Tvrtko Ursulin wrote: Hi, On 28/04/2022 00:07, Matt Roper wrote: Rather than storing subslice masks internally as u8[] (inside the sseu structure) and u32 (everywhere else), let's move over to using an

Re: Tackling the indefinite/user DMA fence problem

2022-05-09 Thread Daniel Vetter
On Mon, May 09, 2022 at 08:56:41AM +0200, Christian König wrote: > Am 04.05.22 um 12:08 schrieb Daniel Vetter: > > On Mon, May 02, 2022 at 06:37:07PM +0200, Christian König wrote: > > > Hello everyone, > > > > > > it's a well known problem that the DMA-buf subsystem mixed > > > synchronization

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 01:42:37PM +0100, Mark Brown wrote: > On Fri, May 06, 2022 at 01:58:18PM +0300, Jani Nikula wrote: > > > Hey Mark, sorry for hijacking the thread a bit. regmap.h seems to have > > comprehensive API documentation, but there's very little in terms of > > higher level

[PATCH] drm: bridge: DRM_FSL_LDB should depend on ARCH_MXC

2022-05-09 Thread Geert Uytterhoeven
The Freescale i.MX8MP LDB bridge is only present on Freescale i.MX8MP SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about this driver when configuring a kernel without i.MX SoC support. Fixes: 463db5c2ed4aed01 ("drm: bridge: ldb: Implement simple Freescale i.MX8MP LDB

Re: [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 03:10:43AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:34, Thomas Zimmermann wrote: > > Hi > > > > Am 18.04.22 um 00:37 schrieb Dmitry Osipenko: > >> Introduce a common DRM SHMEM shrinker. It allows to reduce code > >> duplication among DRM drivers that implement theirs

Re: [PATCH v2 10/11] dt-bindings: display: convert Arm Mali-DP to DT schema

2022-05-09 Thread Andre Przywara
On Fri, 06 May 2022 17:39:53 -0500 Rob Herring wrote: > On Fri, 06 May 2022 15:05:32 +0100, Andre Przywara wrote: > > The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans > > out a framebuffer and hands the pixels over to a digital signal encoder. > > It supports multiple

Re: [PATCH] drm/todo: Add entry for converting kselftests to kunit

2022-05-09 Thread Maxime Ripard
On Mon, May 09, 2022 at 03:08:46PM +0200, Javier Martinez Canillas wrote: > Many of the kselftests in DRM can be converted to kunit tests instead, > since that framework is more suitable for unit testing. > > Suggested-by: Maxime Ripard > Signed-off-by: Javier Martinez Canillas Acked-by:

Re: [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks

2022-05-09 Thread Daniel Vetter
On Fri, May 06, 2022 at 01:49:12AM +0300, Dmitry Osipenko wrote: > On 5/5/22 11:12, Daniel Vetter wrote: > > On Wed, May 04, 2022 at 06:56:09PM +0300, Dmitry Osipenko wrote: > >> On 5/4/22 11:21, Daniel Vetter wrote: > >> ... > > - Maybe also do what you suggest and keep a separate lock for

Re: [PATCH] drm/nouveau: reorder nouveau_drm_device_fini

2022-05-09 Thread Mark Menzynski
I think there are no direct issues with initialization in the state how it is now. I suspect it's because "drm_kms_helper_poll_enable()" starts the first worker thread with a delay, which gives enough time to initialize required resources. I changed the initialization part to keep it consistent

[PATCH 11/11] drm/ttm: stop allocating a dummy resource for pipelined gutting

2022-05-09 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle a move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[PATCH 09/11] drm/ttm: audit bo->resource usage

2022-05-09 Thread Christian König
Allow BOs to exist without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 2b01cb30694a..a55564c8b57c 100644 ---

[PATCH 08/11] drm/nouveau: audit bo->resource usage

2022-05-09 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index

[PATCH 10/11] drm/ttm: stop allocating dummy resources during BO creation

2022-05-09 Thread Christian König
That should not be necessary any more when drivers should at least be able to handle the move without a resource. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[PATCH 06/11] drm/ttm: rename and cleanup ttm_bo_init_reserved

2022-05-09 Thread Christian König
Rename ttm_bo_init_reserved to ttm_bo_init_validate since that better matches what the function is actually doing. Remove the unused size parameter, move the function's kerneldoc to the implementation and cleanup the whole error handling. Signed-off-by: Christian König ---

[PATCH 07/11] drm/amdgpu: audit bo->resource usage

2022-05-09 Thread Christian König
Make sure we can at least move and release BOs without backing store. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 05/11] drm/ttm: drop ttm_bo_init

2022-05-09 Thread Christian König
Not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 26 - include/drm/ttm/ttm_bo_api.h | 44 2 files changed, 70 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 04/11] drm/ttm: move default BO destructor into VMWGFX

2022-05-09 Thread Christian König
It's the only driver using this. Signed-off-by: Christian König --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c index 85a66014c2b6..c4f376d5e1d0 100644 ---

[PATCH 02/11] drm/nouveau: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 05076e530e7d..858b9382036c

[PATCH 03/11] drm/vram-helper: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 123045b58fec..7449cbc2f925

[PATCH 01/11] drm/radeon: switch over to ttm_bo_init_reserved

2022-05-09 Thread Christian König
Use the new interface instead. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_object.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index

Improve TTMs empty object handling

2022-05-09 Thread Christian König
Hi everyone, re-sending this because Daniel was requesting a background why this is useful. When TTM creates a buffer this object initially should not have any backing store and there no resource object associated with it. The same can happen when a driver requests that the backing store of an

[PATCH] drm/todo: Add entry for converting kselftests to kunit

2022-05-09 Thread Javier Martinez Canillas
Many of the kselftests in DRM can be converted to kunit tests instead, since that framework is more suitable for unit testing. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- Documentation/gpu/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [PATCH 1/2] drm/i915: Enable THP on Icelake and beyond

2022-05-09 Thread Tvrtko Ursulin
On 09/05/2022 11:49, Matthew Auld wrote: On 29/04/2022 11:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a statement from HW designers that the GPU read regression when using 2M pages was fixed from Icelake onwards, which was also confirmed by bencharking Eero did last year: """

Re: [PATCH v2 01/12] drm: bridge: Add Samsung DSIM bridge driver

2022-05-09 Thread Marek Szyprowski
On 04.05.2022 13:40, Jagan Teki wrote: > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is via the drm

Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

2022-05-09 Thread Rob Herring
On Mon, 09 May 2022 12:43:00 +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 RDMA definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 94 +++ > 1 file changed, 94

Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

2022-05-09 Thread Rob Herring
On Mon, 09 May 2022 12:43:02 +0800, Rex-BC Chen wrote: > From: "Nancy.Lin" > > Add vdosys1 ETHDR definition. > > Signed-off-by: Nancy.Lin > Reviewed-by: Chun-Kuang Hu > Reviewed-by: AngeloGioacchino Del Regno > > --- > .../display/mediatek/mediatek,ethdr.yaml | 191 ++

[PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH v2 24/25] drm/displayid: convert to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++--- include/drm/drm_displayid.h | 6 +++--- include/drm/drm_edid.h | 6 -- 4

[PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

[PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

Re: [PATCH v2 07/12] drm: bridge: samsung-dsim: Add module init, exit

2022-05-09 Thread Marek Szyprowski
On 04.05.2022 13:40, Jagan Teki wrote: > Add module init and exit functions for the bridge to register > and unregister dsi_driver. > > Exynos drm driver stack will register the platform_driver separately > in the common of it's exynos_drm_drv.c including dsi_driver. > > Register again would

[PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

2022-05-09 Thread Jani Nikula
We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c

  1   2   >