Re: [PATCH v1 4/6] dma-buf: Acquire wait-wound context on attachment

2022-07-14 Thread kernel test robot
Hi Dmitry, I love your patch! Yet something to improve: [auto build test ERROR on next-20220714] [also build test ERROR on v5.19-rc6] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next media-tree/master linus/master v5.19-rc6 v5.19-rc5 v5.19-rc4] [If your patch is applied

[git pull] drm fixes for 5.19-rc7

2022-07-14 Thread Dave Airlie
Hi Linus, This is the regular fixes pull for this week. This has a bunch of amdgpu fixes, major one reverts the buddy allocator until it can be tested more, otherwise just small ones, then i915 has a bunch of fixes. The outstanding firmware regressions reported by phoronix will hopefully be

[PATCH v2 2/3] drm/bridge: it6505: Add i2c api power on check

2022-07-14 Thread allen
From: allen chen Use i2c bus to read/write when it6505 power off will occur i2c error. Add this check will prevent i2c error when it6505 power off. Signed-off-by: Pin-Yen Lin Signed-off-by: Allen Chen Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/ite-it6505.c | 12 ++-- 1 file

[PATCH v2 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message

2022-07-14 Thread allen
From: allen chen Speed up video clock calculation and remove redundant video debug message. Signed-off-by: Pin-Yen Lin Signed-off-by: Allen Chen Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/ite-it6505.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/3] drm/bridge: it6505: Modified power sequence

2022-07-14 Thread allen
From: allen chen Change power sequence to meet it6505 data sheet requirement when boot on. Signed-off-by: Pin-Yen Lin Signed-off-by: Allen Chen Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/ite-it6505.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 0/3] drm/bridge: it6505: Fixes bugs

2022-07-14 Thread allen
From: allen chen This series fixes some it6505 driver bugs and improve computing time. Changes in v2: - Change committe message occure to occur. allen chen (3): drm/bridge: it6505: Modified power sequence drm/bridge: it6505: Add i2c api power on check drm/bridge: it6505: Modified

[PATCH] mm/gup: migrate device coherent pages when pinning instead of failing

2022-07-14 Thread Alistair Popple
Currently any attempts to pin a device coherent page will fail. This is because device coherent pages need to be managed by a device driver, and pinning them would prevent a driver from migrating them off the device. However this is no reason to fail pinning of these pages. These are coherent and

Re: [PATCH] drm/i915/guc: Don't use pr_err when not necessary

2022-07-14 Thread John Harrison
On 7/14/2022 17:40, john.c.harri...@intel.com wrote: From: John Harrison A bunch of code was copy/pasted using pr_err as the default way to report errors. However, drm_err is significantly more useful in identifying where the error came from. So update the code to use that instead.

[PATCH v1 2/6] drm/gem: Take reservation lock for vmap/vunmap operations

2022-07-14 Thread Dmitry Osipenko
The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update QXL and i915 drivers to use the locked functions for the case where DRM core now holds the

[PATCH v1 6/6] dma-buf: Remove internal lock

2022-07-14 Thread Dmitry Osipenko
The internal dma-buf lock isn't needed anymore because the updated locking specification claims that dma-buf reservation must be locked by importers, and thus, the internal data is already protected by the reservation lock. Remove the obsoleted internal lock. Signed-off-by: Dmitry Osipenko ---

[PATCH v1 1/6] dma-buf: Add _unlocked postfix to function names

2022-07-14 Thread Dmitry Osipenko
Add _unlocked postfix to the dma-buf API function names in a preparation to move all non-dynamic dma-buf users over to the dynamic locking specification. This patch only renames API functions, preparing drivers to the common locking convention. Later on we will make the "unlocked" functions to

[PATCH v1 4/6] dma-buf: Acquire wait-wound context on attachment

2022-07-14 Thread Dmitry Osipenko
Intel i915 GPU driver uses wait-wound mutex to lock multiple GEMs on the attachment to the i915 dma-buf. In order to let all drivers utilize shared wait-wound context during attachment in a general way, make dma-buf core to acquire the ww context internally for the attachment operation and update

[PATCH v1 3/6] dma-buf: Move all dma-bufs to dynamic locking specification

2022-07-14 Thread Dmitry Osipenko
This patch moves the non-dynamic dma-buf users over to the dynamic locking specification. From now on all dma-buf importers are responsible for holding dma-buf's reservation lock around operations performed over dma-bufs. This strict locking convention prevents dead lock situation for dma-buf

[PATCH v1 5/6] media: videobuf2: Stop using internal dma-buf lock

2022-07-14 Thread Dmitry Osipenko
All drivers that use dma-bufs have been moved to the updated locking specification and now dma-buf reservation is guaranteed to be locked by importers during the mapping operations. There is no need to take the internal dma-buf lock anymore. Remove locking from the videobuf2 memory allocators.

[PATCH v1 0/6] Move all drivers to a common dma-buf locking convention

2022-07-14 Thread Dmitry Osipenko
Hello, This series moves all drivers to a dynamic dma-buf locking specification. >From now on all dma-buf importers are made responsible for holding dma-buf's reservation lock around all operations performed over dma-bufs. This common locking convention allows us to utilize reservation lock more

[PATCH] drm/i915/guc: Don't use pr_err when not necessary

2022-07-14 Thread John . C . Harrison
From: John Harrison A bunch of code was copy/pasted using pr_err as the default way to report errors. However, drm_err is significantly more useful in identifying where the error came from. So update the code to use that instead. Signed-off-by: John Harrison ---

Re: [PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-14 Thread Guenter Roeck
On Thu, Jul 14, 2022 at 04:51:40PM -0700, Guenter Roeck wrote: > On Fri, Jul 08, 2022 at 05:30:47PM -0300, Maíra Canal wrote: > > Considering the current adoption of the KUnit framework, convert the > > DRM format selftest to the KUnit API. > > > > Tested-by: David Gow > > Acked-by: Daniel

Re: [PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-14 Thread Guenter Roeck
On Fri, Jul 08, 2022 at 05:30:47PM -0300, Maíra Canal wrote: > Considering the current adoption of the KUnit framework, convert the > DRM format selftest to the KUnit API. > > Tested-by: David Gow > Acked-by: Daniel Latypov > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Maíra Canal

Re: [PATCH v2 00/29] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-07-14 Thread Lyude Paul
I assume you're probably good on review for the non-nouveau stuff, but if you end up needing any help with that feel free to poke me! On Tue, 2022-07-12 at 21:38 +0200, Hans de Goede wrote: > Hi All, > > As mentioned in my RFC titled "drm/kms: control display brightness through > drm_connector

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Update to GuC version 70.1.1

2022-07-14 Thread Dave Airlie
On Fri, 15 Apr 2022 at 10:15, Matt Roper wrote: > > On Tue, Apr 12, 2022 at 03:59:55PM -0700, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > The latest GuC firmware drops the context descriptor pool in favour of > > passing all creation data in the create H2G. It also greatly

Re: [PATCH v2 05/29] drm/nouveau: Don't register backlight when another backlight should be used

2022-07-14 Thread Lyude Paul
Reviewed-by: Lyude Paul You also have permission to push this to drm-misc-whatever On Tue, 2022-07-12 at 21:38 +0200, Hans de Goede wrote: > Before this commit when we want userspace to use the acpi_video backlight > device we register both the GPU's native backlight device and acpi_video's >

[PATCH RESEND v6] backlight: lp855x: Switch to atomic PWM API

2022-07-14 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Reviewed-by: Uwe Kleine-König Reviewed-by: Daniel Thompson Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simplify conditional loop V2 -> V3: Fix assignment of NULL

Re: [Freedreno] [PATCH v2.5] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-14 Thread Abhinav Kumar
On 7/12/2022 6:22 AM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig)

[pull] amdgpu, amdkfd, radeon drm-next-5.20

2022-07-14 Thread Alex Deucher
Hi Dave, Daniel, A few more new things for 5.20. The following changes since commit c5da61cf5bab30059f22ea368702c445ee87171a: drm/amdgpu/display: add missing FP_START/END checks dcn32_clk_mgr.c (2022-06-30 19:35:21 -0400) are available in the Git repository at:

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 1:58 PM Andrey Grodzovsky wrote: > > On 2022-07-14 12:22, Alex Deucher wrote: > > > On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-07-14 05:57, Dmitry Osipenko wrote: > >>> On 7/12/22 11:56, Dmitry Osipenko wrote: > On 7/6/22 18:46,

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-14 Thread Guenter Roeck
On 7/14/22 11:49, Melissa Wen wrote: O 07/13, Alex Deucher wrote: On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote: On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: The problem is not the FPU operations, but the fact that soft-float and hard-float compiled code is linked

Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks

2022-07-14 Thread Hans de Goede
Hi, On 7/13/22 19:21, Limonciello, Mario wrote: > [Public] > > > >> -Original Message- >> From: Werner Sembach >> Sent: Wednesday, July 13, 2022 12:08 >> To: Hans de Goede ; Ben Skeggs >> ; Karol Herbst ; Lyude >> ; Daniel Dadap ; Maarten >> Lankhorst ; Maxime Ripard >> ; Thomas

[PATCH v2 2/2] Documentation/gpu: Add GFXOFF section

2022-07-14 Thread André Almeida
Add a GFXOFF section at "GPU Power Controls" file, explaining what it is and how userspace can interact with it. Signed-off-by: André Almeida --- Changes from v1: file created Documentation/gpu/amdgpu/thermal.rst | 41 1 file changed, 41 insertions(+) diff --git

[PATCH v2 1/2] drm/amd/debugfs: Expose GFXOFF state to userspace

2022-07-14 Thread André Almeida
GFXOFF has two different "state" values: one to define if the GPU is allowed/disallowed to enter GFXOFF, usually called state; and another one to define if currently GFXOFF is being used, usually called status. Even when GFXOFF is allowed, GPU firmware can decide to not used it accordingly to the

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-14 Thread Melissa Wen
O 07/13, Alex Deucher wrote: > On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote: > > > > On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: > > > > > > > > The problem is not the FPU operations, but the fact that soft-float > > > > and hard-float compiled code is linked together.

Re: [PATCH v2 00/29] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-07-14 Thread Rafael J. Wysocki
On Tue, Jul 12, 2022 at 9:39 PM Hans de Goede wrote: > > Hi All, > > As mentioned in my RFC titled "drm/kms: control display brightness through > drm_connector properties": > https://lore.kernel.org/dri-devel/0d188965-d809-81b5-74ce-7d30c49fe...@redhat.com/ > > The first step towards this is to

Re: [PATCH 01/10] drm/sched: move calling drm_sched_entity_select_rq

2022-07-14 Thread Andrey Grodzovsky
Found the new use case from the 5/10 of reordering CS ioctl. Reviewed-by: Andrey Grodzovsky Andrey On 2022-07-14 12:26, Christian König wrote: We need this for limiting codecs like AV1 to the first instance for VCN3. Essentially the idea is that we first initialize the job with entity, id

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Andrey Grodzovsky
On 2022-07-14 12:22, Alex Deucher wrote: On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: On 2022-07-14 05:57, Dmitry Osipenko wrote: On 7/12/22 11:56, Dmitry Osipenko wrote: On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: On

[Bug 216120] [BISECTED][REGRESSION] drm/amdgpu: add drm buddy support to amdgpu

2022-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216120 --- Comment #6 from mat2003...@gmail.com --- not quite there yet, after some hours of working with latest linus+0001-drm-amdgpu-Fix-for-drm-buddy-memory-corruption.patch (latest commit "vf/remap: return the amount of bytes actually deduplicated")

[PATCH v2 0/2] Miscellaneous runtime PM fixes for Nouveau

2022-07-14 Thread Lyude Paul
Noticed these minor issues while trying to investigate https://bugzilla.redhat.com/show_bug.cgi?id=2086470 While unfortunately I've been unable to confirm whether these patches fix the specific problem in question, they're likely fixes we want to pull in regardless. Lyude Paul (2):

[PATCH v2 2/2] drm/nouveau: Don't pm_runtime_put_sync(), only pm_runtime_put_autosuspend()

2022-07-14 Thread Lyude Paul
While trying to fix another issue, it occurred to me that I don't actually think there is any situation where we want pm_runtime_put() in nouveau to be synchronous. In fact, this kind of just seems like it would cause issues where we may unexpectedly block a thread we don't expect to be blocked.

[PATCH v2 1/2] drm/nouveau/acpi: Don't print error when we get -EINPROGRESS from pm_runtime

2022-07-14 Thread Lyude Paul
Since this isn't actually a failure. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index

[Bug 216120] [BISECTED][REGRESSION] drm/amdgpu: add drm buddy support to amdgpu

2022-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216120 --- Comment #5 from mat2003...@gmail.com --- Created attachment 301427 --> https://bugzilla.kernel.org/attachment.cgi?id=301427=edit journal 2022-07-14 -- You may reply to this email to add a comment. You are receiving this mail because: You

Re: [PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-14 Thread Guenter Roeck
On 7/14/22 09:29, Alex Deucher wrote: Applied. Thanks! On Wed, Jul 13, 2022 at 4:03 PM Harry Wentland wrote: On 2022-07-12 18:42, Guenter Roeck wrote: The new display engine uses floating point math, which is not supported by KCOV. Commit 9d1d02ff3678 ("drm/amd/display: Don't build DCN1

Re: [PATCH] drm/amd/debugfs: Expose GFXOFF state to userspace

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 12:45 PM André Almeida wrote: > > > > Às 13:42 de 14/07/22, Alex Deucher escreveu: > > On Wed, Jul 13, 2022 at 11:15 AM André Almeida > > wrote: > >> > >> GFXOFF has two different "state" values: one to define if the GPU is > >> allowed/disallowed to enter GFXOFF,

Re: [PATCH] drm/amd/debugfs: Expose GFXOFF state to userspace

2022-07-14 Thread André Almeida
Às 13:42 de 14/07/22, Alex Deucher escreveu: > On Wed, Jul 13, 2022 at 11:15 AM André Almeida wrote: >> >> GFXOFF has two different "state" values: one to define if the GPU is >> allowed/disallowed to enter GFXOFF, usually called state; and another >> one to define if currently GFXOFF is being

Re: [PATCH] drm/amd/debugfs: Expose GFXOFF state to userspace

2022-07-14 Thread Alex Deucher
On Wed, Jul 13, 2022 at 11:15 AM André Almeida wrote: > > GFXOFF has two different "state" values: one to define if the GPU is > allowed/disallowed to enter GFXOFF, usually called state; and another > one to define if currently GFXOFF is being used, usually called status. > Even when GFXOFF is

Re: [PATCH] drm/amdgpu: Clarify asics naming in Kconfig options

2022-07-14 Thread Alex Deucher
Applied. Thanks! On Thu, Jul 14, 2022 at 9:50 AM André Almeida wrote: > > Clarify which architecture those asics acronyms refers to. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH][next] drm/amd/display: Fix spelling mistake "supporing" -> "supporting"

2022-07-14 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 14, 2022 at 6:34 AM Colin Ian King wrote: > > There is a spelling mistake in a dml_print message. Fix it. > > Signed-off-by: Colin Ian King > --- > .../gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c| 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-14 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 13, 2022 at 4:03 PM Harry Wentland wrote: > > On 2022-07-12 18:42, Guenter Roeck wrote: > > The new display engine uses floating point math, which is not supported > > by KCOV. Commit 9d1d02ff3678 ("drm/amd/display: Don't build DCN1 when kcov > > is enabled") tried

Re: [PATCH 01/10] drm/sched: move calling drm_sched_entity_select_rq

2022-07-14 Thread Christian König
We need this for limiting codecs like AV1 to the first instance for VCN3. Essentially the idea is that we first initialize the job with entity, id etc... and before we submit it we select a new rq for the entity. In the meantime the VCN3 inline parse will have modified the available rqs for

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 10:14 AM Andrey Grodzovsky wrote: > > > On 2022-07-14 05:57, Dmitry Osipenko wrote: > > On 7/12/22 11:56, Dmitry Osipenko wrote: > >> On 7/6/22 18:46, Alex Deucher wrote: > >>> On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky > >>> wrote: > On 2022-07-06 03:07,

[PATCH] mm: move page zone helpers from mm.h to mmzone.h

2022-07-14 Thread Alex Sierra
[WHY] It makes more sense to have these helpers in zone specific header file, rather than the generic mm.h Signed-off-by: Alex Sierra --- include/linux/memremap.h | 2 +- include/linux/mm.h | 78 --- include/linux/mmzone.h | 80

Re: [PATCH -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-07-14 Thread André Almeida
Às 12:06 de 14/07/22, Sebin Sebastian escreveu: > On Tue, Jul 12, 2022 at 12:14:27PM -0300, André Almeida wrote: >> Hi Sebin, >> >> Às 10:29 de 10/07/22, Sebin Sebastian escreveu: >>> Fix two coverity warning's double free and and an uninitialized pointer >>> read. Both tmp and new are pointing at

Re: [PATCH 01/10] drm/sched: move calling drm_sched_entity_select_rq

2022-07-14 Thread Andrey Grodzovsky
Can you please remind me of the use case that requires this ? I browsed through related mails in the past but haven't found when is that needed. For amdgpu drm_sched_job_init and drm_sched_job_arm are called together and amdgpu is the only one who supports modifying entity priority on the fly as

Re: [PATCH v2 16/21] drm/i915: Define GuC Based TLB invalidation routines

2022-07-14 Thread Michal Wajdeczko
On 14.07.2022 14:06, Mauro Carvalho Chehab wrote: > From: Prathap Kumar Valsan > > Add routines to interface with GuC firmware for selective TLB invalidation > supported on XeHP. > > Signed-off-by: Prathap Kumar Valsan > Cc: Matthew Brost > Signed-off-by: Mauro Carvalho Chehab > --- > >

Re: [PATCH -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-07-14 Thread Sebin Sebastian
On Tue, Jul 12, 2022 at 12:14:27PM -0300, André Almeida wrote: > Hi Sebin, > > Às 10:29 de 10/07/22, Sebin Sebastian escreveu: > > Fix two coverity warning's double free and and an uninitialized pointer > > read. Both tmp and new are pointing at same address and both are freed > > which leads to

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Christian König
Am 14.07.22 um 15:33 schrieb Alex Deucher: On Thu, Jul 14, 2022 at 9:09 AM Christian König wrote: Hi Mauro, well the last time I checked drm-tip was clean. The revert is necessary because we had some problems with the commit which we couldn't fix in the 5.19 cycle. Would it be worth

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 09:33:23 -0400 Alex Deucher wrote: > On Thu, Jul 14, 2022 at 9:09 AM Christian König > wrote: > > > > Hi Mauro, > > > > well the last time I checked drm-tip was clean. > > > > The revert is necessary because we had some problems with the commit > > which we couldn't fix in

Re: [PATCH 0/3] drm/vc4: use drm managed resources

2022-07-14 Thread Danilo Krummrich
Hi Maxime, On 7/13/22 11:10, Maxime Ripard wrote: Hi Danilo, On Wed, Jul 13, 2022 at 10:54:57AM +0200, Danilo Krummrich wrote: This patch series converts DRM modeset object allocations from devm_*() to drmm_*() memory allocators, or their corresponding convenience wrappers, respectively, in

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Dmitry Osipenko
On 7/14/22 17:14, Andrey Grodzovsky wrote: > > On 2022-07-14 05:57, Dmitry Osipenko wrote: >> On 7/12/22 11:56, Dmitry Osipenko wrote: >>> On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: > On 2022-07-06 03:07, Dmitry Osipenko wrote:

Re: [PATCH] drm: Fix EDID firmware load on resume

2022-07-14 Thread André Almeida
Hi Matthieu, Thanks for your patch. Às 11:58 de 06/07/22, Matthieu CHARETTE escreveu: > Loading an EDID using drm.edid_firmware parameter makes resume to fail > after firmware cache is being cleaned. This is because edid_load() use a > temporary device to request the firmware. This cause the

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-14 Thread Andrey Grodzovsky
On 2022-07-14 05:57, Dmitry Osipenko wrote: On 7/12/22 11:56, Dmitry Osipenko wrote: On 7/6/22 18:46, Alex Deucher wrote: On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: On 2022-07-06 03:07, Dmitry Osipenko wrote: Hello Andrey, On 5/17/22 17:48, Dmitry Osipenko wrote: On

[PULL] drm-misc-next-fixes

2022-07-14 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the first PR for drm-misc-next-fixes for v5.20. Best regards Thomas drm-misc-next-fixes-2022-07-14: Short summary of fixes: - dma-buf: revert change to fence handling - mgag200: fix PCI register initialization The following changes since commit

Re: [PATCH v2 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-07-14 Thread Michal Wajdeczko
On 14.07.2022 14:06, Mauro Carvalho Chehab wrote: > From: Prathap Kumar Valsan > > Add routines to interface with GuC firmware for TLB invalidation. > > Signed-off-by: Prathap Kumar Valsan > Cc: Bruce Chang > Cc: Michal Wajdeczko > Cc: Matthew Brost > Cc: Chris Wilson > Signed-off-by:

[PATCH] drm/amdgpu: Clarify asics naming in Kconfig options

2022-07-14 Thread André Almeida
Clarify which architecture those asics acronyms refers to. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig index

Re: [linux-next:master] BUILD REGRESSION 4662b7adea50bb62e993a67f611f3be625d3df0d

2022-07-14 Thread Philip Li
On Thu, Jul 14, 2022 at 01:35:35PM +0100, Russell King (Oracle) wrote: > Hi, > > I don't mean to discourge test systems, but looking at this, I just go > "meh" and delete it - it doesn't seem to contain obviously useful > information. One has to read every damn line to see if there's something >

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Alex Deucher
On Thu, Jul 14, 2022 at 9:09 AM Christian König wrote: > > Hi Mauro, > > well the last time I checked drm-tip was clean. > > The revert is necessary because we had some problems with the commit > which we couldn't fix in the 5.19 cycle. Would it be worth reverting the revert and applying the

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Christian König
Am 14.07.22 um 15:19 schrieb Mauro Carvalho Chehab: On Thu, 14 Jul 2022 15:08:48 +0200 Christian König wrote: Hi Mauro, well the last time I checked drm-tip was clean. The revert is necessary because we had some problems with the commit which we couldn't fix in the 5.19 cycle. I see. I

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 15:08:48 +0200 Christian König wrote: > Hi Mauro, > > well the last time I checked drm-tip was clean. > > The revert is necessary because we had some problems with the commit > which we couldn't fix in the 5.19 cycle. I see. I don't have any issues with the patch itself,

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Christian König
Hi Mauro, well the last time I checked drm-tip was clean. The revert is necessary because we had some problems with the commit which we couldn't fix in the 5.19 cycle. I will double check drm-tip once more. Regards, Christian. Am 14.07.22 um 14:54 schrieb Mauro Carvalho Chehab: On Fri, 8

[PATCH 2/2] drm/virtio: kms: use drm managed resources

2022-07-14 Thread Danilo Krummrich
Allocate driver structures with drm managed resource allocators in order to cleanup/simplify the drm driver .release callback. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/virtio/virtgpu_kms.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH 1/2] drm/virtio: plane: use drm managed resources

2022-07-14 Thread Danilo Krummrich
Use drm managed resource allocation (drmm_universal_plane_alloc()) in order to cleanup/simplify drm plane .destroy callback. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/virtio/virtgpu_plane.c | 30 +++--- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git

[PATCH 0/2] drm/virtio: use drm managed resources

2022-07-14 Thread Danilo Krummrich
This patch series converts plain memory allocations for driver structures and planes to drm managed allocations in order to cleanup/simply the corresponding release/destroy callbacks. Danilo Krummrich (2): drm/virtio: plane: use drm managed resources drm/virtio: kms: use drm managed resources

[PATCH] drm: flip-work: rename commited -> committed

2022-07-14 Thread Colin Ian King
There is a spelling mistake in the list head variable, rename it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_flip_work.c | 10 +- include/drm/drm_flip_work.h | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_flip_work.c

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Fri, 8 Jul 2022 03:21:24 -0700 Arunpravin Paneer Selvam wrote: > This reverts the following commits: > commit 708d19d9f362 ("drm/amdgpu: move internal vram_mgr function into the C > file") > commit 5e3f1e7729ec ("drm/amdgpu: fix start calculation in > amdgpu_vram_mgr_new") > commit

Re: [linux-next:master] BUILD REGRESSION 4662b7adea50bb62e993a67f611f3be625d3df0d

2022-07-14 Thread Russell King (Oracle)
Hi, I don't mean to discourge test systems, but looking at this, I just go "meh" and delete it - it doesn't seem to contain obviously useful information. One has to read every damn line to see if there's something of relevence, which I for one am not going to do. Is there some kind of

Re: [PATCH 3/3] drm/komeda - Fix handling of pending crtc state commit to avoid lock-up

2022-07-14 Thread Robin Murphy
On 2022-07-11 11:13, Liviu Dudau wrote: [...] But nothing worrying. It does work, though doesn't compile due to: drivers/gpu/drm/arm/display/komeda/komeda_kms.c: In function ‘komeda_kms_atomic_commit_hw_done’: drivers/gpu/drm/arm/display/komeda/komeda_kms.c:77:9: error: ‘for’ loop initial

Re: [PATCH v2 4/5] drm/modes: Add support for driver-specific named modes

2022-07-14 Thread Maxime Ripard
On Thu, Jul 14, 2022 at 11:04:09AM +0200, Geert Uytterhoeven wrote: > The mode parsing code recognizes named modes only if they are explicitly > listed in the internal whitelist, which is currently limited to "NTSC" > and "PAL". > > Provide a mechanism for drivers to override this list to support

[PATCH v2 08/21] drm/i915/gt: Move TLB invalidation to its own file

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH v2 19/21] drm/i915/gt: document TLB cache invalidation functions

2022-07-14 Thread Mauro Carvalho Chehab
Add a description for the kAPI functions inside intel_tlb.c. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/

[PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed, thus reducing the performance regression impact due to it. This becomes more significant with GuC, as it

[PATCH v2 15/21] drm/i915: Add platform macro for selective tlb flush

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add support for selective TLB invalidation, which is a platform feature supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing

[PATCH v2 14/21] drm/i915: document tlb field at struct drm_i915_gem_object

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation to the TLB field inside struct drm_i915_gem_object. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at:

[PATCH v2 02/21] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-14 Thread Mauro Carvalho Chehab
Add a kernel-doc markup to document this new macro. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/

[PATCH v2 18/21] drm/i915: Use selective tlb invalidations where supported

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan For platforms supporting selective tlb invalidations, we don't need to do a full tlb invalidation. Rather do a range based tlb invalidation for every unbind of purged vma belongs to an active vm. [mchehab: change moved from intel_ppgtt.c to i915_vma.c] Signed-off-by:

[PATCH v2 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for TLB invalidation. Signed-off-by: Prathap Kumar Valsan Cc: Bruce Chang Cc: Michal Wajdeczko Cc: Matthew Brost Cc: Chris Wilson Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of

[PATCH v2 11/21] drm/i915/guc: document the TLB invalidation struct members

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation for the 3 new members of struct intel_guc that are used to handle TLB cache invalidation logic. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at:

[PATCH v2 00/21] Fix performance regressions with TLB and add GuC support

2022-07-14 Thread Mauro Carvalho Chehab
TLB invalidation is a slow operation. It should not be doing lightly, as it causes performance regressions, like this: [178.821002] i915 :00:02.0: [drm] *ERROR* rcs0 TLB invalidation did not complete in 4ms! This series contain 1) some patches that makes TLB invalidation to happen only on

[PATCH v2 04/21] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Don't flush TLBs when the buffer is only used in the GGTT under full control of the kernel, as there's no risk of concurrent access and stale access from prefetch. We only need to invalidate the TLB if they are accessible by the user. That helps to reduce the performance

[PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Invalidate TLB in patch, in order to reduce performance regressions. Currently, every caller performs a full barrier around a TLB invalidation, ignoring all other invalidations that may have already removed their PTEs from the cache. As this is a synchronous operation and can

[PATCH v2 13/21] drm/i915: Invalidate the TLBs on each GT

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson With multi-GT devices, the object may have been bound on each GT. Invalidate the TLBs across all GT before releasing the pages back to the system. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of

[PATCH v2 03/21] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Ensure that the TLB of the OA unit is also invalidated on gen12 HW, as just invalidating the TLB of an engine is not enough. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc:

[PATCH v2 17/21] drm/i915: Add generic interface for tlb invalidation for XeHP

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add an interface for GuC TLB actions, supporting both selective and full TLB invalidations. After this change, when GuC is enabled, tlb invalidations use GuC ct. Otherwise, use mmio interface. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei

[PATCH v2 16/21] drm/i915: Define GuC Based TLB invalidation routines

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for selective TLB invalidation supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Matthew Brost Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were

[PATCH v2 20/21] drm/i915/guc: describe enum intel_guc_tlb_invalidation_type

2022-07-14 Thread Mauro Carvalho Chehab
Add a description for intel_guc_tlb_invalidation_type enum. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/

[PATCH v2 10/21] drm/i915/guc: use kernel-doc for enum intel_guc_tlb_inval_mode

2022-07-14 Thread Mauro Carvalho Chehab
Transform the comments for intel_guc_tlb_inval_mode into a kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at:

[PATCH v2 21/21] drm/i915/guc: document TLB cache invalidation functions

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation for the kAPI functions that do TLB cache invalidation via GuC. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at:

[PATCH v2 12/21] drm/i915/guc: Introduce TLB_INVALIDATION_ALL action

2022-07-14 Thread Mauro Carvalho Chehab
From: Piotr Piórkowski Add a new way to invalidate TLB via GuC using actions 0x7002 (TLB_INVALIDATION_ALL). Those actions will be used on upcoming patches. Signed-off-by: Piotr Piórkowski Cc: Michal Wajdeczko Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number

[PATCH v2 05/21] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Skip all further TLB invalidations once the device is wedged and had been reset, as, on such cases, it can no longer process instructions on the GPU and the user no longer has access to the TLB's in each engine. That helps to reduce the performance regression introduced by

[PATCH v2 07/21] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-14 Thread Mauro Carvalho Chehab
TLB cache invalidation can happen on two different situations: 1. synchronously, at __vma_put_pages(); 2. asynchronously. On the first case, TLB cache invalidation happens inside __vma_put_pages(). So, no need to do it later on. However, on the second case, the pages will keep in memory until

Re: [PATCH v2 5/5] drm/modes: parse_cmdline: Add support for named modes containing dashes

2022-07-14 Thread Maxime Ripard
On Thu, Jul 14, 2022 at 11:04:10AM +0200, Geert Uytterhoeven wrote: > It is fairly common for named video modes to contain dashes (e.g. > "tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names > are not recognized, as the dash is considered to be a separator between > mode name and

Re: [PATCH v2 3/5] drm/modes: parse_cmdline: Make mode->*specified handling more uniform

2022-07-14 Thread Maxime Ripard
On Thu, Jul 14, 2022 at 11:04:08AM +0200, Geert Uytterhoeven wrote: > The various mode->*specified flags are not handled in an uniform way: > some flags are set by the corresponding drm_mode_parse_cmdline_*() > function, some flags by the caller of the function, and some flags by > both. > > Make

Re: [PATCH v2 2/5] drm/modes: Extract drm_mode_parse_cmdline_named_mode()

2022-07-14 Thread Maxime Ripard
On Thu, Jul 14, 2022 at 11:04:07AM +0200, Geert Uytterhoeven wrote: > Extract the code to check for a named mode parameter into its own > function, to streamline the main parsing flow. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Hans de Goede > Acked-by: Thomas Zimmermann Acked-by:

Re: [PATCH v2 1/5] drm/modes: parse_cmdline: Handle empty mode name part

2022-07-14 Thread Maxime Ripard
Hi, On Thu, Jul 14, 2022 at 11:04:06AM +0200, Geert Uytterhoeven wrote: > If no mode name part was specified, mode_end is zero, and the "ret == > mode_end" check does the wrong thing. > > Fix this by skipping all named mode handling when mode_end is zero. > > Fixes: 7b1cce760afe38b4

  1   2   >