Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Stephen Rothwell
Hi Dave, On Wed, 27 Jul 2022 13:24:45 +1000 Dave Airlie wrote: > > My assumption is I fix this on sending my -next tree to Linus with a > resolution I create at that time? > > Is there another option, we have this fixed in out drm-tip tree already. Sounds good, no problem. -- Cheers, Stephen

[PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-26 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. v2: Fix commit description unwrapped warning [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in

Re: [PATCH] fbdev: Make registered_fb[] private to fbmem.c

2022-07-26 Thread Helge Deller
On 7/26/22 09:22, Helge Deller wrote: > On 7/25/22 09:54, Javier Martinez Canillas wrote: >> From: Daniel Vetter >> >> No driver access this anymore, except for the olpc dcon fbdev driver but >> that has been marked as broken anyways by commit de0952f267ff ("staging: >> olpc_dcon: mark driver as

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-26 Thread Marco Felsch
Hi Marek, Liu, On 22-07-26, Liu Ying wrote: > On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > > On 7/26/22 11:43, Marco Felsch wrote: > > > FIFO underruns are seen if a AXI bus master with a higher priority > > > do a > > > lot of memory access. Increase the burst size to 256B to avoid

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Dave Airlie
On Wed, 27 Jul 2022 at 12:55, Stephen Rothwell wrote: > > Hi all, > > On Mon, 18 Jul 2022 09:44:53 +1000 Stephen Rothwell > wrote: > > > > On Mon, 11 Jul 2022 10:05:45 +0200 Christian König > > wrote: > > > > > > Am 11.07.22 um 04:47 schrieb Stephen Rothwell: > > > > > > > > Today's

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-07-26 Thread Stephen Rothwell
Hi all, On Mon, 18 Jul 2022 09:44:53 +1000 Stephen Rothwell wrote: > > On Mon, 11 Jul 2022 10:05:45 +0200 Christian König > wrote: > > > > Am 11.07.22 um 04:47 schrieb Stephen Rothwell: > > > > > > Today's linux-next merge of the drm tree got a conflict in: > > > > > >

Re: [PATCH 02/10] drm: rcar-du: Add encoder lib support

2022-07-26 Thread kernel test robot
Hi Biju, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on next-20220726] [cannot apply to drm-intel/for-linux-next pinchartl-media/drm/du/next linus/master v5.19-rc8] [If your patch is applied to the wrong git tree

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread Melissa Wen
On 07/26, Magali Lemes wrote: > On 7/25/22 20:38, Melissa Wen wrote: > > > On 07/25, Magali Lemes wrote: > > > On 7/25/22 16:42, André Almeida wrote: > > > > Hi Magali, > > > > > > > > Às 15:15 de 25/07/22, Magali Lemes escreveu: > > > > > As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >

Re: [Freedreno] [PATCH] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-26 Thread Abhinav Kumar
On 7/25/2022 5:49 PM, Douglas Anderson wrote: As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually

[git pull] nouveau display patches

2022-07-26 Thread Dave Airlie
Just to work in the process, I've pulled a bunch of patches Lyude tested, that rework some of the nouveau display code. Dave. topic/nouveau-misc-2022-07-27: drm/nouveau-misc: display patches. These are just some precursor and cleanup display patches from Ben, tested by Lyude. The following

[PATCH v3 4/4] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb565()

2022-07-26 Thread José Expósito
Extend the existing test cases to test the conversion from XRGB to RGB565. The documentation and the color picker available on [1] are useful resources to understand this patch and validate the values returned by the conversion function. Tested-by: Tales L. Aparecida Acked-by: Thomas

[PATCH v3 3/4] drm/format-helper: Support multiple target formats results

2022-07-26 Thread José Expósito
In order to support multiple destination format conversions, store the destination pitch and the expected result in its own structure. Tested-by: Tales L. Aparecida Acked-by: Thomas Zimmermann Reviewed-by: David Gow Signed-off-by: José Expósito --- .../gpu/drm/tests/drm_format_helper_test.c

[PATCH v3 1/4] drm/format-helper: Fix test on big endian architectures

2022-07-26 Thread José Expósito
The tests fail on big endian architectures, like PowerPC: $ ./tools/testing/kunit/kunit.py run \ --kunitconfig=drivers/gpu/drm/tests \ --arch=powerpc --cross_compile=powerpc64-linux-gnu- Transform the XRGB buffer from little endian to the CPU endian before calling the conversion

[PATCH v3 2/4] drm/format-helper: Rename test cases to make them more generic

2022-07-26 Thread José Expósito
The tests available at the moment only check the conversion from XRGB to RGB332. However, more conversions will be tested in the future. In order to make the struct and functions present in the tests more generic, rename xrgb_to_rgb332_* to convert_xrgb_*. Tested-by: Tales L.

[PATCH v3 0/4] KUnit tests for RGB565 conversion

2022-07-26 Thread José Expósito
Hello everyone, This series is a follow up of the XRGB to RGB332 conversion KUnit tests. As I mentioned in v2 [1] I suspected that the inconsistency handling the endian might need to be fixed. Fortunately, Geert Uytterhoeven fixed it in commit 4d9db10576ff ("drm/format-helper: Fix endianness

[PATCH -next] drm/amd/display: remove unneeded semicolon

2022-07-26 Thread Yang Li
Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Bug 216290] New: [amdgpu] drm/ttm: fbdev race condition into fork()

2022-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216290 Bug ID: 216290 Summary: [amdgpu] drm/ttm: fbdev race condition into fork() Product: Drivers Version: 2.5 Kernel Version: 5.19.0-rc7+ 353afba44cdabdab9fdfaa6990a088718abd5d85 Hardware: AMD

[Bug 213145] AMDGPU resets, timesout and crashes after "*ERROR* Waiting for fences timed out!"

2022-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213145 Michal Przybylowicz (michal.przybylow...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Dave Airlie
On Wed, 27 Jul 2022 at 04:18, Thomas Zimmermann wrote: > > Hi > > Am 26.07.22 um 19:41 schrieb Sam Ravnborg: > > Hi Kevin. > > > > On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: > >> From: Kevin Brace > >> > >> Changed the uAPI. > >> > >> Signed-off-by: Kevin Brace > > > > It

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread André Almeida
Às 17:47 de 25/07/22, Magali Lemes escreveu: > > On 7/25/22 16:42, André Almeida wrote: >> Hi Magali, >> >> Às 15:15 de 25/07/22, Magali Lemes escreveu: >>> As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct >>> _vcs_dpi_soc_bounding_box_st", change their types accordingly. >>> >> I can see

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-26 Thread Javier Martinez Canillas
Hello Michal, On 7/26/22 16:40, Michal Suchánek wrote: > Hello, > > On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: >> On 7/20/22 16:27, Thomas Zimmermann wrote: >>> Add a per-model device-function structure in preparation of adding >>> color-management support.

Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing

2022-07-26 Thread Andrew Morton
On Mon, 25 Jul 2022 21:22:06 -0500 "Sierra Guiza, Alejandro (Alex)" wrote: > >> a) add the || to the end of the previous line > >> b) indent such the we have a nice-to-read alignment > >> > >> if (!list_empty(_page_list) || isolation_error_count || > >> coherent_pages) > >> > > I missed

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 01:53 schrieb Kevin Brace: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace --- include/uapi/drm/via_drm.h | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/include/uapi/drm/via_drm.h

[PATCH v2 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

2022-07-26 Thread André Almeida
Add comments to document gfx_off related members of struct amdgpu_gfx. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h

[PATCH v2 3/4] Documentation/gpu: Document GFXOFF's count and residency

2022-07-26 Thread André Almeida
Add documentation explaining those two new files. While here, add a note about the value type. Signed-off-by: André Almeida --- Documentation/gpu/amdgpu/thermal.rst | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/Documentation/gpu/amdgpu/thermal.rst

[PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh

2022-07-26 Thread André Almeida
This series adds new logging features for GFXOFF available for vangogh and documentation for it. I've created a small userspace program to interact with this new debugfs interface and it can be found at: https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool Changelog: v2: - Make entrycount

[PATCH v2 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh

2022-07-26 Thread André Almeida
Implement functions to get and set GFXOFF's entry count and residency for vangogh. Signed-off-by: André Almeida --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 5 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 92

[PATCH v2 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-26 Thread André Almeida
Add debugfs interface to log GFXOFF statistics: - Read amdgpu_gfxoff_count to get the total GFXOFF entry count at the time of query since system power-up - Write 1 to amdgpu_gfxoff_residency to start logging, and 0 to stop. Read it to get average GFXOFF residency % multiplied by 100 during

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 19:41 schrieb Sam Ravnborg: Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: From: Kevin Brace Changed the uAPI. Signed-off-by: Kevin Brace It would be great to have the new extensions to the UAPI documented using kernel-doc. As an example see:

[PATCH v5] drm: Add initial ci/ subdirectory

2022-07-26 Thread Tomeu Vizoso
And use it to store expectations about what the DRM drivers are supposed to pass in the IGT test suite. Also include a configuration file that points to the out-of-tree CI scripts. By storing the test expectations along the code we can make sure both stay in sync with each other, and so we can

[pull] amdgpu, amdkfd drm-next-5.20

2022-07-26 Thread Alex Deucher
Hi Dave, Daniel, Bug fixes for 5.20 and a few new things. I know it's a bit late for new stuff, but this is mainly fixes for new IPs that were just added in 5.20 and more DC cleanup which is just code shuffling to group FP code into separate code objects and spliting up the DC DM code into more

Re: [PATCH 1/2] drm/i915/gem: Avoid taking runtime-pm under the shrinker

2022-07-26 Thread Matthew Auld
On 20/07/2022 11:16, Janusz Krzysztofik wrote: From: Chris Wilson Inside the shrinker, we cannot wake the device as that may cause recursion into fs-reclaim, so instead we only unbind vma if the device is currently awake. (In order to provide reclaim while asleep, we do wake the device up

[PATCH v3 06/15] drm/msm/gem: Rename to pin/unpin_pages

2022-07-26 Thread Rob Clark
From: Rob Clark Since that is what these fxns actually do.. they are getting *pinned* pages (as opposed to cases where we need pages, but don't need them pinned, like CPU mappings). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 18 +-

[PATCH v3 11/15] drm/msm/gem: Unpin buffers earlier

2022-07-26 Thread Rob Clark
From: Rob Clark We've already attached the fences, so obj->resv (which shrinker checks) tells us whether they are still active. So we can unpin sooner, before we drop the queue lock. This also avoids the need to grab the obj lock in the retire path, avoiding potential for lock contention

[PATCH v3 12/15] drm/msm/gem: Consolidate shrinker trace

2022-07-26 Thread Rob Clark
From: Rob Clark Combine separate trace events for purge vs evict into one. When we add support for purging/evicting active buffers we'll just add more info into this one trace event, rather than adding a bunch more events. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c |

[PATCH v3 14/15] drm/msm/gem: Add msm_gem_assert_locked()

2022-07-26 Thread Rob Clark
From: Rob Clark All use of msm_gem_is_locked() is just for WARN_ON()s, so extract out into an msm_gem_assert_locked() patch. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 36 +-- drivers/gpu/drm/msm/msm_gem.h | 8 +++- 2 files changed, 25

[PATCH v3 13/15] drm/msm/gem: Evict active GEM objects when necessary

2022-07-26 Thread Rob Clark
From: Rob Clark If we are under enough memory pressure, we should stall waiting for active buffers to become idle in order to evict. v2: Check for __GFP_ATOMIC before blocking Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_shrinker.c | 70 +-

[PATCH v3 15/15] drm/msm/gem: Convert to lockdep assert

2022-07-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index 3c6add51d13b..c4844cf3a585 100644 ---

[PATCH v3 10/15] drm/msm/gem: Convert to using drm_gem_lru

2022-07-26 Thread Rob Clark
From: Rob Clark This converts over to use the shared GEM LRU/shrinker helpers. Note that it means we are no longer tracking purgeable or willneed buffers that are active separately. But the most recently pinned buffers should be at the tail of the various LRUs, and the shrinker is already

[PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-07-26 Thread Rob Clark
From: Rob Clark Add a simple LRU helper to assist with driver's shrinker implementation. It handles tracking the number of backing pages associated with a given LRU, and provides a helper to implement shrinker_scan. A driver can use multiple LRU instances to track objects in various states, for

[PATCH v3 03/15] drm/msm: Split out idr_lock

2022-07-26 Thread Rob Clark
From: Rob Clark Otherwise if we hit reclaim pinning objects in the submit path, we'll be blocking retire_worker trying to free a submit. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- drivers/gpu/drm/msm/msm_gem_submit.c | 10 --

[PATCH v3 07/15] drm/msm/gem: Consolidate pin/unpin paths

2022-07-26 Thread Rob Clark
From: Rob Clark Avoid having multiple spots where we increment/decrement pin_count (and associated LRU updating) Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v3 05/15] drm/msm/gem: Rename update_inactive

2022-07-26 Thread Rob Clark
From: Rob Clark Really what this is doing is updating various LRU lists. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c

[PATCH v3 08/15] drm/msm/gem: Remove active refcnt

2022-07-26 Thread Rob Clark
From: Rob Clark At this point the pinned refcnt is sufficient, and the shrinker is already prepared to encounter objects which are still active according to fences attached to the resv. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c| 45 ++--

[PATCH v3 04/15] drm/msm/gem: Check for active in shrinker path

2022-07-26 Thread Rob Clark
From: Rob Clark Currently in our shrinker path we shouldn't be encountering anything that is active, but this will change in subsequent patches. So check if there are unsignaled fences. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 10 ++

[PATCH v3 02/15] drm/msm: Small submit cleanup

2022-07-26 Thread Rob Clark
From: Rob Clark Move more initialization into submit_create(). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c

[PATCH v3 01/15] drm/msm: Reorder lock vs submit alloc

2022-07-26 Thread Rob Clark
From: Rob Clark This lets us drop the NORETRY. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index

[PATCH v3 00/15] drm+msm: Shrinker and LRU rework

2022-07-26 Thread Rob Clark
From: Rob Clark Mostly a resend with switch to lockdep asserts for the GEM LRU helper and conversion of msm locking checks to lockdep asserts, since that seemed like a good idea. original description below: This is mostly motivated by getting drm/msm to pass an i-g-t shrinker test that I've

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-07-26 Thread Sam Ravnborg
Hi Kevin. On Mon, Jul 25, 2022 at 04:53:53PM -0700, Kevin Brace wrote: > From: Kevin Brace > > Changed the uAPI. > > Signed-off-by: Kevin Brace It would be great to have the new extensions to the UAPI documented using kernel-doc. As an example see: vc4_drm.h There are a lot of UAPI that is

[PATCH v2 6/7] regulator: core: Allow drivers to define their init data as const

2022-07-26 Thread Douglas Anderson
Drivers tend to want to define the names of their regulators somewhere in their source file as "static const". This means, inevitable, that every driver out there open codes something like this: static const char * const supply_names[] = { "vcc", "vccl", }; static int get_regulators(struct

[PATCH v2 7/7] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-07-26 Thread Douglas Anderson
In the patch ("regulator: core: Allow drivers to define their init data as const") we no longer need to do copying of regulator bulk data from initdata to something dynamic. Let's take advantage of that. In addition to saving some code, this also moves us to using ARRAY_SIZE() to specify how many

[PATCH v2 5/7] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-07-26 Thread Douglas Anderson
As of the patch ("regulator: core: Allow specifying an initial load w/ the bulk API") we can now specify the initial load in the bulk data rather than having to manually call regulator_set_load() on each regulator. Let's use it. Signed-off-by: Douglas Anderson --- Changes in v2: - ("Use the new

[PATCH v2 4/7] regulator: core: Allow specifying an initial load w/ the bulk API

2022-07-26 Thread Douglas Anderson
There are a number of drivers that follow a pattern that looks like this: 1. Use the regulator bulk API to get a bunch of regulators. 2. Set the load on each of the regulators to use whenever the regulators are enabled. Let's make this easier by just allowing the drivers to pass the load in.

[PATCH v2 1/7] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg

2022-07-26 Thread Douglas Anderson
3 regulators are specified listed but the number 2 is specified. Fix it. Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") Signed-off-by: Douglas Anderson --- Changes in v2: - ("Fix number of regulators for msm8996_dsi_cfg") new for v2. drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 +- 1

[PATCH v2 3/7] drm/msm/dsi: Don't set a load before disabling a regulator

2022-07-26 Thread Douglas Anderson
As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually doing anything useful. Let's remove it. It should be

[PATCH v2 2/7] drm/msm/dsi: Fix number of regulators for SDM660

2022-07-26 Thread Douglas Anderson
1 regulators is specified listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") Signed-off-by: Douglas Anderson --- Changes in v2: - ("Fix number of regulators for

[PATCH v2 0/7] drm/msm/dsi regulator improvements

2022-07-26 Thread Douglas Anderson
The main goal of this series is to make a small dent in cleaning up the way we deal with regulator loads. The idea is to add some extra functionality to the regulator "bulk" API so that consumers can specify the load using that. Though I didn't convert everyone over, I include patches in this

Re: [PATCH] component: try_module_get() to prevent unloading while in use

2022-07-26 Thread Greg KH
On Tue, Jul 26, 2022 at 11:32:28AM +0100, Richard Fitzgerald wrote: > On 25/07/2022 19:09, Greg KH wrote: > > On Mon, Jul 25, 2022 at 05:08:59PM +0100, Richard Fitzgerald wrote: > > > Call try_module_get() on a component before attempting to call its > > > bind() function, to ensure that a

Re: [PATCH] drm/via: Add new condition to via_dma_cleanup()

2022-07-26 Thread Sam Ravnborg
Hi Alisa, On Mon, Jul 25, 2022 at 01:45:55PM +0300, Alisa Khabibrakhmanova wrote: > Pointer dev_priv->mmio, which was checked for NULL at via_do_init_map(), > is passed to via_do_cleanup_map() and is dereferenced there without check. > > The patch adds the condition in via_dma_cleanup() which

[PATCH 10/10] drm: rcar-du: Add rcar_du_lib_vsp_init()

2022-07-26 Thread Biju Das
RZ/G2L does not have plane registers as well as it uses different CRTC. The below functions are SoC specific * rcar_du_crtc_finish_page_flip() * __rcar_du_plane_setup * __rcar_du_plane_atomic_check All other function can be handled in common code. This patch introduces rcar_du_lib_vsp_init() to

[PATCH 07/10] drm: rcar-du: Move vsp rcar_du_vsp_{map,unmap}_fb()

2022-07-26 Thread Biju Das
Move vsp rcar_du_vsp_{map,unmap}_fb() to RCar DU VSP lib. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 75 --- drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 15 - drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 75 +++

[PATCH 09/10] drm: rcar-du: Move rcar_du_gem_prime_import_sg_table()

2022-07-26 Thread Biju Das
Move rcar_du_gem_prime_import_sg_table() to RCar DU KMS lib. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 45 --- drivers/gpu/drm/rcar-du/rcar_du_kms.h | 4 -- drivers/gpu/drm/rcar-du/rcar_du_kms_lib.c | 45 +++

[PATCH 08/10] drm: rcar-du: Move rcar_du_dumb_create()

2022-07-26 Thread Biju Das
Move rcar_du_dumb_create() to RCar DU KMS lib. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 21 --- drivers/gpu/drm/rcar-du/rcar_du_kms.h | 3 --- drivers/gpu/drm/rcar-du/rcar_du_kms_lib.c | 25 +++

[PATCH 02/10] drm: rcar-du: Add encoder lib support

2022-07-26 Thread Biju Das
Add RCar DU encoder lib support by moving rcar_du_encoder_count_ports() and rcar_du_encoder_funcs to the lib file and added rcar_du_encoder_funcs() to share the common code between RCar and RZ/G2L DU encoder drivers. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/Kconfig |

[PATCH 06/10] drm: rcar-du: Move rcar_du_vsp_atomic_flush()

2022-07-26 Thread Biju Das
Move rcar_du_vsp_atomic_flush() to RCar DU vsp lib. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 13 - drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 -- drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 13 +

[PATCH 03/10] drm: rcar-du: Add kms lib support

2022-07-26 Thread Biju Das
Add RCar DU kms lib support by moving rcar_du_format_infos table and rcar_du_format_infos() to the lib file to share the common code between RCar and RZ/G2L DU KMS drivers. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/Makefile | 3 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c

[PATCH 01/10] drm: rcar-du: Add RZ/G2L reset and clocks to struct rcar_du_crtc

2022-07-26 Thread Biju Das
Add RZ/G2L reset and clocks to struct rcar_du_crtc, so that we can share and optimize the common code between RCar and RZ/G2L driver using RCar DU library. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 05/10] drm: rcar-du: Move rcar_du_vsp_atomic_begin()

2022-07-26 Thread Biju Das
Move rcar_du_vsp_atomic_begin() to RCar DU VSP lib. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 5 - drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 -- drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.c | 5 + drivers/gpu/drm/rcar-du/rcar_du_vsp_lib.h | 2 ++ 4 files

[PATCH 04/10] drm: rcar-du: Add vsp lib support

2022-07-26 Thread Biju Das
Add RCar DU vsp lib support by moving rcar_du_vsp_disable() to the lib file so that same function can be used by both RCar and RZ/G2L DU VSP drivers. Signed-off-by: Biju Das --- drivers/gpu/drm/rcar-du/Kconfig | 5 ++ drivers/gpu/drm/rcar-du/Makefile | 1 +

[PATCH 00/10] Add RCar DU lib support

2022-07-26 Thread Biju Das
Adding RCar DU lib support(Encoder, vsp and KMS) proved that it can save 50% code saving on RZ/G2L compared to patch series [1]. The current patchset contains just movement of codes with some trivial changes. The subsequent patch series will have more additions to vsp and kms library. There is

Re: [Freedreno] [PATCH v2 1/1] drm/msm/a6xx: Fix null pointer access in a6xx_get_indexed_registers

2022-07-26 Thread Rob Clark
On Mon, Jul 25, 2022 at 9:46 PM wrote: > > From: Akhil P Oommen > > Fix a null pointer access when memory allocation fails in > a6xx_get_indexed_registers(). > > Change-Id: I33e13745cd8e5841d2f377f48a199af98be2ed02 > Signed-off-by: Akhil P Oommen > Signed-off-by: Devi prasad Dhamarasingi > ---

[PATCH] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-26 Thread Arunpravin Paneer Selvam
Check the bo->resource value before accessing the resource mem_type. [ 40.191227][ T184] general protection fault, probably for non-canonical address 0xdc02: [#1] SMP KASAN PTI [ 40.192995][ T184] KASAN: null-ptr-deref in range [0x0010-0x0017] [

Re: [PATCH] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-26 Thread Dan Carpenter
Thanks for the patch. On Tue, Jul 26, 2022 at 10:21:13AM +0200, Peter Suti wrote: > fb_deferred_io_init depends on smem_len being filled > to be able to initialize the virtual page lists since > commit 856082f021a2 ("fbdev: defio: fix the pagelist corruption") > This code has changed since then

[PATCH v5] drm/i915: stop using swiotlb

2022-07-26 Thread Robert Beckett
Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace swiotlb_max_segment() calls with dma_max_mapping_size(). In i915_gem_object_get_pages_internal() no longer consider max_segment only if CONFIG_SWIOTLB is

Re: [PATCH] drm/simpledrm: Fix return type of simpledrm_simple_display_pipe_mode_valid()

2022-07-26 Thread Thomas Zimmermann
Hi Am 26.07.22 um 02:12 schrieb Sami Tolvanen: On Mon, Jul 25, 2022 at 4:37 PM Nathan Chancellor wrote: When booting a kernel compiled with clang's CFI protection (CONFIG_CFI_CLANG), there is a CFI failure in drm_simple_kms_crtc_mode_valid() when trying to call

[Bug 216277] X11 doesn't wait for amdgpu driver to be up

2022-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216277 --- Comment #6 from dark_syl...@yahoo.com.ar --- OK today it happened again so changing 78-graphics-card.rules did not fix it. I just found this: https://bbs.archlinux.org/viewtopic.php?id=260525 Which leads me to this:

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-26 Thread Liu Ying
On Tue, 2022-07-26 at 16:19 +0200, Marek Vasut wrote: > On 7/26/22 11:43, Marco Felsch wrote: > > FIFO underruns are seen if a AXI bus master with a higher priority > > do a > > lot of memory access. Increase the burst size to 256B to avoid such > > underruns and to improve the memory access

Re: [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator

2022-07-26 Thread Greg KH
On Tue, Jul 26, 2022 at 06:10:37AM +, yuji2.ishik...@toshiba.co.jp wrote: > Hi Greg > > Thank you for your comments. > > > -Original Message- > > From: Greg KH > > Sent: Monday, July 25, 2022 9:51 PM > > To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開) > > > > Cc: Rob Herring ; Hans Verkuil

Re: [PATCH 01/20] drm/amd/display: Clean up some inconsistent indenting

2022-07-26 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Jul 26, 2022 at 3:26 AM Jiapeng Chong wrote: > > No functional modification involved. > > smatch warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:910 > dcn32_init_hw() warn: inconsistent indenting. > > Reported-by: Abaci Robot

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-26 Thread Michal Suchánek
Hello, On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: > On 7/20/22 16:27, Thomas Zimmermann wrote: > > Add a per-model device-function structure in preparation of adding > > color-management support. Detection of the individual models has been > > taken from fbdev's

Re: [PATCH v4] drm/i915: stop using swiotlb

2022-07-26 Thread Robert Beckett
On 26/07/2022 14:12, Tvrtko Ursulin wrote: On 25/07/2022 15:18, Robert Beckett wrote: Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace swiotlb_max_segment() calls with dma_max_mapping_size(). In

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-07-26 Thread Marek Vasut
On 7/26/22 11:43, Marco Felsch wrote: FIFO underruns are seen if a AXI bus master with a higher priority do a lot of memory access. Increase the burst size to 256B to avoid such underruns and to improve the memory access efficiency. Sigh, this again ... diff --git

Re: [fs/lock] 0064b3d9f9: BUG:kernel_NULL_pointer_dereference,address

2022-07-26 Thread Jeff Layton
(cc'ing dri-devel) This looks like it died down in the DRM code. It seems doubtful that the flock code would be affecting this, but let me know if I'm incorrect here. Thanks, Jeff On Tue, 2022-07-26 at 21:14 +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-07-26 Thread Javier Martinez Canillas
On 7/20/22 16:27, Thomas Zimmermann wrote: > Support the CRTC's color-management property and implement each model's > palette support. > > The OF hardware has different methods of setting the palette. The > respective code has been taken from fbdev's offb and refactored into > per-model device

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-07-26 Thread Javier Martinez Canillas
On 7/20/22 16:27, Thomas Zimmermann wrote: > Add a per-model device-function structure in preparation of adding > color-management support. Detection of the individual models has been > taken from fbdev's offb. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas

Re: [PATCH v2 08/10] drm/ofdrm: Add CRTC state

2022-07-26 Thread Javier Martinez Canillas
On 7/20/22 16:27, Thomas Zimmermann wrote: > Add a dedicated CRTC state to ofdrm to later store information for > palette updates. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/tiny/ofdrm.c | 62 ++-- > Reviewed-by: Javier Martinez Canillas

[PATCH] staging: fbtft: core: set smem_len before fb_deferred_io_init call

2022-07-26 Thread Peter Suti
fb_deferred_io_init depends on smem_len being filled to be able to initialize the virtual page lists since commit 856082f021a2 ("fbdev: defio: fix the pagelist corruption") Signed-off-by: Peter Suti --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/4] drm/amd: Add detailed GFXOFF stats to debugfs

2022-07-26 Thread Alex Deucher
On Mon, Jul 25, 2022 at 11:03 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > > > > -Original Message- > > From: André Almeida > > Sent: Tuesday, July 26, 2022 12:15 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian > > ; Pan, Xinhui ; David > > Airlie ;

Re: [PATCH v2 07/10] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-07-26 Thread Javier Martinez Canillas
Hello Thomas, On 7/20/22 16:27, Thomas Zimmermann wrote: > Open Firmware provides basic display output via the 'display' node. > DT platform code already provides a device that represents the node's > framebuffer. Add a DRM driver for the device. The display mode and > color format is

[PATCH][next] drm/i915/gt: remove redundant pointer sseu

2022-07-26 Thread Colin Ian King
Pointer sseu is being assigned a value that is never read. The pointer is redundant and can be removed. Cleans up clang scan warning: drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c:300:2: warning: Value stored to 'sseu' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King ---

Re: [PATCH v4] drm/i915: stop using swiotlb

2022-07-26 Thread Tvrtko Ursulin
On 25/07/2022 15:18, Robert Beckett wrote: Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace swiotlb_max_segment() calls with dma_max_mapping_size(). In i915_gem_object_get_pages_internal() no longer

Re: [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL

2022-07-26 Thread Mark Brown
On Fri, 22 Jul 2022 21:15:38 +0200, Krzysztof Kozlowski wrote: > Rebased on Linus' master > > Changes since v1 > > 1. Rework patchset as Rob suggested, so there is only one patch - changing spi >and display/panel. > v1: >

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-26 Thread Andy Shevchenko
On Tue, Jul 26, 2022 at 1:46 PM ChiaEn Wu wrote: > On Mon, Jul 25, 2022 at 4:41 PM Andy Shevchenko > wrote: ... > > > +struct mt6370_led { > > > + union { > > > + struct led_classdev isink; > > > + struct led_classdev_mc mc; > > > + }; > > > > Where is

Re: [PATCH 1/2] drm/amd/display: change variables type

2022-07-26 Thread Magali Lemes
On 7/25/22 20:38, Melissa Wen wrote: On 07/25, Magali Lemes wrote: On 7/25/22 16:42, André Almeida wrote: Hi Magali, Às 15:15 de 25/07/22, Magali Lemes escreveu: As "dcn3_15_soc" and "dcn3_16_soc" are of type "struct _vcs_dpi_soc_bounding_box_st", change their types accordingly. I can see

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-26 Thread Daniel Thompson
On Tue, Jul 26, 2022 at 07:28:48PM +0800, ChiaEn Wu wrote: > On Tue, Jul 26, 2022 at 5:31 PM Daniel Thompson > wrote: > ... > > > > Does the MT6372 support more steps than this? In other words does it use > > > > a fourteen bit scale or does it use an 11-bit scale at a different > > > > register

Re: [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

2022-07-26 Thread ChiaEn Wu
On Mon, Jul 25, 2022 at 4:41 PM Andy Shevchenko wrote: ... > > From: ChiYuan Huang > > (Note this and read below) ... > In conjunction with above what SoB of Alice means? > > You really need to take your time and (re-)read >

Re: [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support

2022-07-26 Thread ChiaEn Wu
On Tue, Jul 26, 2022 at 5:31 PM Daniel Thompson wrote: ... > > > Does the MT6372 support more steps than this? In other words does it use > > > a fourteen bit scale or does it use an 11-bit scale at a different > > > register location? > > > > Hi Daniel, > > > > Thanks for your reply. > > Yes,

Re: [PATCH v2 4/6] drm/i915: Implement intersect/compatible functions

2022-07-26 Thread Matthew Auld
On 25/07/2022 12:42, Arunpravin Paneer Selvam wrote: Implemented a new intersect and compatible callback function fetching start offset from drm buddy allocator. Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 43

[PATCH v3 2/2] drm: panel: Add novatek nt35596s panel driver

2022-07-26 Thread Molly Sophia
Novatek NT35596s is a generic DSI IC that drives command and video mode panels. Add the driver for it. Currently add support for the LCD panel from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones. Changes in v3: - Embed the support into existing driver (panel-novatek-nt36672a), as

[PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-26 Thread Molly Sophia
Add documentation for "novatek,nt35596s" panel. Changes in v3: - Embed the documentation into existing one (novatek,nt36672a). Signed-off-by: Molly Sophia --- .../display/panel/novatek,nt36672a.yaml | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

  1   2   >