Re: [PATCH v1] drivers:adp8870_bl: check the return value of adp8870_write

2022-09-22 Thread Daniel Thompson
On Wed, Sep 21, 2022 at 02:50:49PM -0700, Li Zhong wrote: > Subject: [PATCH v1] drivers:adp8870_bl: check the return value of > adp8870_write Should be backlight: adp8870_bl. > Check and propagate the return value of adp8870_write() when it fails, > which

Re: [Intel-gfx] [RFC v4 07/14] drm/i915/vm_bind: Add out fence support

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add support for handling out fence for vm_bind call. > > Signed-off-by: Niranjana Vishwanathapura > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gem/i915_gem_vm_bind.h | 4 + > .../drm/i915/gem/i915_gem_vm_bind_object.c|

Re: [Intel-gfx] [RFC v4 04/14] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add uapi and implement support for bind and unbind of an > object at the specified GPU virtual addresses. > > The vm_bind mode is not supported in legacy execbuf2 ioctl. > It will be supported only in the newer execbuf3 ioctl. > > Signed-off

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused function parameter

2022-09-22 Thread Tvrtko Ursulin
On 22/09/2022 05:43, Niranjana Vishwanathapura wrote: The function parameter 'exclude' in funciton i915_sw_fence_await_reservation() is not used. Remove it. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++--- drivers/gpu/drm/i915/gem/i9

Re: [RFC v4 02/14] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-22 Thread Jani Nikula
On Wed, 21 Sep 2022, Niranjana Vishwanathapura wrote: > Add function __i915_sw_fence_await_reservation() for > asynchronous wait on a dma-resv object with specified > dma_resv_usage. This is required for async vma unbind > with vm_bind. > > Signed-off-by: Niranjana Vishwanathapura > --- > drive

Re: [PATCH 11/12] slab: Remove __malloc attribute from realloc functions

2022-09-22 Thread Miguel Ojeda
On Thu, Sep 22, 2022 at 5:10 AM Kees Cook wrote: > > -#ifdef __alloc_size__ > -# define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > -#else > -# define __alloc_size(x, ...) __malloc > -#endif > +#define __alloc_size(x, ...) __alloc_size__(x, ## __VA_ARGS__) __malloc > +#de

[PATCH resend v2] drm/amdgpu: fix enum conversion in display_mode_vba

2022-09-22 Thread Zeng Heng
Fix below compile warning when open enum-conversion option check (compiled with -Wenum-conversion): drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: In function ‘dml20_ModeSupportAndSystemConfigurationFull’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_v

Re: [Intel-gfx] [RFC v4 08/14] drm/i915/vm_bind: Abstract out common execbuf functions

2022-09-22 Thread Tvrtko Ursulin
On 21/09/2022 19:17, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 11:18:53AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Share code between thes

[PATCH] drm/i915: Fix double word in comments

2022-09-22 Thread Bo Liu
Remove the repeated word "not" in comments. Signed-off-by: Bo Liu --- drivers/gpu/drm/i915/display/intel_bw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 4ace026b29bd..a5cb253f6dc

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set

Re: [Intel-gfx] [PATCH] drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms

2022-09-22 Thread Balasubramani Vivekanandan
On 07.09.2022 16:08, Lucas De Marchi wrote: > Except for graphics version 8 and 9, nothing is done in > lrc_init_wa_ctx(). Assume this won't be needed on future platforms as > well and remove the warning. > > Note that this function is not called for anything below version 8 since > those don't us

Re: [Intel-gfx] [RFC v4 03/14] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-22 Thread Tvrtko Ursulin
On 21/09/2022 19:00, Niranjana Vishwanathapura wrote: On Wed, Sep 21, 2022 at 10:13:12AM +0100, Tvrtko Ursulin wrote: On 21/09/2022 08:09, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Ni

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-22 Thread Thomas Zimmermann
Hi Am 22.09.22 um 09:28 schrieb Maxime Ripard: On Thu, Sep 22, 2022 at 08:42:23AM +0200, Thomas Zimmermann wrote: Hi Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann wrote: Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt: On

Re: [PATCH v7,1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei . lee
On Thu, 2022-09-22 at 15:29 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > The difference between MT8186 and other ICs is that when modifying > the > output format, we need to modify the mmsys_base+0x400 register to > take > effect. > So when setting the dpi output format, we need t

Re: [PATCH v7,3/3] drm: mediatek: Add mt8186 dpi compatible to

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 09:29, xinlei@mediatek.com ha scritto: From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee Please fix the commit title. drm: mediatek: Add mt8186 dpi compatibles and platform data

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski wrote: > > On 15/09/2022 15:37, Dmitry Baryshkov wrote: > > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > > will be added later, once msm8998

Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Dmitry Baryshkov
On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski wrote: > > On 15/09/2022 15:37, Dmitry Baryshkov wrote: > > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > > > Note, this removes description of individual DPU port@ nodes. However > > such definitions add no additional val

Re: [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV

2022-09-22 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Extend hwmon power/energy for XEHPSDV especially per gt level energy usage. v2: Update to latest HWMON spec (Ashutosh) v3: Fixed review comments (Ashutosh) Signed-off-by: Ashutosh Dixit Signed-off-by: Dale B Stimson Signed-o

[PATCH v7, 1/3] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee The difference between MT8186 and other ICs is that when modifying the output format, we need to modify the mmsys_base+0x400 register to take effect. So when setting the dpi output format, we need to call mmsys_func to set it to MT8186 synchronously. Co-developed-by: Jitao Shi

[PATCH v7,2/3] drm: mediatek: Adjust the dpi output format to MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Due to the mt8186 hardware changes, we need to modify the dpi output format corresponding to the mmsys register(mmsys_base+0x400). Because different sink ICs may support other output formats. The current DRM architecture supports retrieving the output format of all bridges (eg

[PATCH v7,3/3] drm: mediatek: Add mt8186 dpi compatible to

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Add the compatible because use edge_cfg_in_mmsys in mt8186. Signed-off-by: Xinlei Lee --- drivers/gpu/drm/mediatek/mtk_dpi.c | 21 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/mediatek

[PATCH v7,0/3] Add dpi output format control for MT8186

2022-09-22 Thread xinlei.lee
From: Xinlei Lee Base on the branch of ck-linux-next/mediatek-drm-fixes. Changes since v6: 1. Different from other ICs, when mt8186 DPI changes the output format, the mmsys_base+400 register needs to be set to be valid at the same time. In this series, all the situations that mmsys need to be

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-22 Thread Maxime Ripard
On Thu, Sep 22, 2022 at 08:42:23AM +0200, Thomas Zimmermann wrote: > Hi > > Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven: > > Hi Thomas, > > > > On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann > > wrote: > > > Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt: > > > > On Wed, 2022-07-20

[PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_p

Re: [PATCH v1 11/17] drm/mediatek: hdmi: add mt8195 support

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Adds hdmi and hdmi-ddc support for mt8195. > > Signed-off-by: Guillaume Ranquet > +static int mtk_hdmi_ddc_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_hdmi_ddc *ddc; > + int ret; > + > +

Re: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
On Wed, Sep 21, 2022 at 7:11 PM Chen, Guchun wrote: > > Perhaps you need to update the prefix of patch subject to 'drm/amd/pm: check > return value ...'. > > With above addressed, it's: Acked-by: Guchun Chen > > Regards, > Guchun > > -Original Message- > From: Li Zhong > Sent: Thursday,

[PATCH -next] video: fbdev: tridentfb: Fix missing pci_disable_device() in probe and remove

2022-09-22 Thread ruanjinjie
Replace pci_enable_device() with pcim_enable_device(), pci_disable_device() and pci_release_regions() will be called in release automatically. Signed-off-by: ruanjinjie --- drivers/video/fbdev/tridentfb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbde

[PATCH v2] drivers/amd/pm: check the return value of amdgpu_bo_kmap

2022-09-22 Thread Li Zhong
amdgpu_bo_kmap() returns error when fails to map buffer object. Add the error check and propagate the error. Signed-off-by: Li Zhong --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_p

[PATCH v1] drivers:adp8870_bl: check the return value of adp8870_write

2022-09-22 Thread Li Zhong
Check and propagate the return value of adp8870_write() when it fails, which is possible when SMBus writing byte fails. Signed-off-by: Li Zhong --- drivers/video/backlight/adp8870_bl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/adp8870_bl.c

Re: [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add the DPI1 hdmi path support in mtk dpi driver > > Signed-off-by: Guillaume Ranquet > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 630a4e301ef6..91212b7610e8 100644 > --- a/drivers/gpu/drm/medi

Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add dpi support to enable the HDMI path. > > Signed-off-by: Guillaume Ranquet > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 72049a530ae1..27f029ca760b 100644 > --- a/drivers/gpu/drm/medi

Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > b/Documentation/devicetree/bindings/display/mediatek/media

Re: [PATCH v1 06/17] dt-bindings: mediatek: set the hdmi to be compatible with syscon

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > In order to share register with a dedicated ddc driver, set the hdmi > compatible to syscon. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,hdmi.yaml > b/Documentation/devicetre

Re: [PATCH v1 04/17] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add mt8195 SoC bindings for hdmi and hdmi-ddc > > Make port1 optional for mt8195 as it only supports HDMI tx for now. > Requires a ddc-i2c-bus phandle. > Requires a power-domains phandle. > > Signed-off-by: Guillaume Ranquet > > diff --git > a/Do

Re: [PATCH 01/18] phy: mediatek: add a new helper to update bitfield

2022-09-22 Thread AngeloGioacchino Del Regno
Il 22/09/22 04:36, Chunfeng Yun ha scritto: On Wed, 2022-09-21 at 10:15 +0200, AngeloGioacchino Del Regno wrote: Il 20/09/22 11:00, Chunfeng Yun ha scritto: Due to FIELD_PREP() macro can be used to prepare a bitfield value, local ones can be remove; add the new helper to make bitfield update ea

Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-22 Thread Gupta, Anshuman
On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)). v2: Update date and kernel ver

Re: [PATCH v1 03/17] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:56, Guillaume Ranquet wrote: > Add a compatible for the HDMI PHY on MT8195 > > Signed-off-by: Guillaume Ranquet The same... maybe it works, maybe not, I don't know. Any reason not using standard tools and producing standard patches? Best regards, Krzysztof

Re: [PATCH 00/12] slab: Introduce kmalloc_size_roundup()

2022-09-22 Thread Christian König
Am 22.09.22 um 05:10 schrieb Kees Cook: Hi, This series fixes up the cases where callers of ksize() use it to opportunistically grow their buffer sizes, which can run afoul of the __alloc_size hinting that CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE use to perform dynamic buffer bounds checkin

Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks

2022-09-22 Thread Krzysztof Kozlowski
On 19/09/2022 18:55, Guillaume Ranquet wrote: > From: Pablo Sun > > Expand dt-bindings slot for VDOSYS1 of MT8195. > This clock is required by the DPI1 hardware > and is a downstream of the HDMI pixel clock. > > Signed-off-by: Pablo Sun > Signed-off-by: Guillaume Ranquet > Reviewed-by: Mattijs

Re: [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-common.yaml | 4 +- > .../bindings/display/msm/qcom,sm8250-dpu.yaml | 92 +++

Re: [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/qcom,msm8998-mdss.yaml| 12 + > .../display/msm/qcom,qcm2290-mdss.ya

Re: [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-22 Thread Gupta, Anshuman
On 9/21/2022 8:23 PM, Nilawar, Badal wrote: On 21-09-2022 17:15, Gupta, Anshuman wrote: On 9/16/2022 8:30 PM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2:    - Fix review comments (Ashutosh)    - Do not restore po

Re: [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > +--

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > -

Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to hardware INTF indices. The d

Re: [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845

2022-09-22 Thread Krzysztof Kozlowski
On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema. Reviewed-by: Krzysztof K

<    1   2   3