[PATCH v2 2/2] drm/bridge: it6505: Add pre_enable/post_disable callback

2022-10-02 Thread Pin-yen Lin
Add atomic_pre_enable and atomic_post_disable callback to make sure the bridge is not powered off until atomic_post_disable is called. This prevents a power leakage when it6505 is powered off, but the upstream DRM bridge is still sending display signals. Fixes: b5c84a9edcd4 ("drm/bridge: add

[PATCH v2 1/2] drm/bridge: it6505: Adapt runtime power management framework

2022-10-02 Thread Pin-yen Lin
Use pm_runtime_(get|put)_sync to control the bridge power, and add SET_SYSTEM_SLEEP_PM_OPS with pm_runtime_force_(suspend|resume) to it6505 driver. Without SET_SYSTEM_SLEEP_PM_OPS, the bridge will be powered on unnecessarily when no external display is connected. Fixes: b5c84a9edcd4 ("drm/bridge:

[PATCH v2 0/2] drm/bridge: it6505: Power management fixes for it6505 bridge

2022-10-02 Thread Pin-yen Lin
This series contains 2 fixes related to it6505 power management. Changes in v2: - Handle the error from pm_runtime_get_sync in it6505_extcon_work Pin-yen Lin (2): drm/bridge: it6505: Adapt runtime power management framework drm/bridge: it6505: Add pre_enable/post_disable callback

Re: [PATCH] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-02 Thread Zheng Hacker
> That is a horrible way to make an api (and it should be a bool too.) > Now every time you see this call in the code, you have to go look up > what the last parameter means. Just make 2 functions, one that does the > "is error" thing, and one that does not, and that will be much easier to >

Re: [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding

2022-10-02 Thread Pin-yen Lin
Hi all, Are there any thoughts or comments about this proposal? On Sat, Sep 17, 2022 at 2:22 AM Prashant Malani wrote: > > Hi folks, > > On Fri, Sep 2, 2022 at 12:41 AM Prashant Malani wrote: > > > > Hi Rob, > > > > On Jul 12 11:45, Rob Herring wrote: > > > > > > That's not the right

Re: [PATCH v2 1/8] mm/memory.c: Fix race when faulting a device private page

2022-10-02 Thread Alistair Popple
Felix Kuehling writes: > On 2022-09-28 08:01, Alistair Popple wrote: >> When the CPU tries to access a device private page the migrate_to_ram() >> callback associated with the pgmap for the page is called. However no >> reference is taken on the faulting page. Therefore a concurrent >>

[PATCH AUTOSEL 5.10 14/14] drm/amd/display: skip audio setup when audio stream is enabled

2022-10-02 Thread Sasha Levin
From: zhikzhai [ Upstream commit 65fbfb02c2734cacffec5e3f492e1b4f1dabcf98 ] [why] We have minimal pipe split transition method to avoid pipe allocation outage.However, this method will invoke audio setup which cause audio output stuck once pipe reallocate. [how] skip audio setup for pipelines

[PATCH AUTOSEL 5.10 13/14] drm/amd/display: update gamut remap if plane has changed

2022-10-02 Thread Sasha Levin
From: Hugo Hu [ Upstream commit 52bb21499cf54fa65b56d97cd0d68579c90207dd ] [Why] The desktop plane and full-screen game plane may have different gamut remap coefficients, if switching between desktop and full-screen game without updating the gamut remap will cause incorrect color. [How] Update

[PATCH AUTOSEL 5.15 20/20] drm/amd/display: skip audio setup when audio stream is enabled

2022-10-02 Thread Sasha Levin
From: zhikzhai [ Upstream commit 65fbfb02c2734cacffec5e3f492e1b4f1dabcf98 ] [why] We have minimal pipe split transition method to avoid pipe allocation outage.However, this method will invoke audio setup which cause audio output stuck once pipe reallocate. [how] skip audio setup for pipelines

[PATCH AUTOSEL 5.15 19/20] drm/amd/display: update gamut remap if plane has changed

2022-10-02 Thread Sasha Levin
From: Hugo Hu [ Upstream commit 52bb21499cf54fa65b56d97cd0d68579c90207dd ] [Why] The desktop plane and full-screen game plane may have different gamut remap coefficients, if switching between desktop and full-screen game without updating the gamut remap will cause incorrect color. [How] Update

[PATCH AUTOSEL 5.15 18/20] drm/amd/display: Assume an LTTPR is always present on fixed_vs links

2022-10-02 Thread Sasha Levin
From: Michael Strauss [ Upstream commit 29956d0fded036a570bd8e7d4ea4b1a1730307d2 ] [WHY] LTTPRs can in very rare instsances fail to increment DPCD LTTPR count. This results in aux-i LTTPR requests to be sent to the wrong DPCD address, which causes link training failure. [HOW] Override internal

[PATCH AUTOSEL 5.15 17/20] drm/amd/display: Fix double cursor on non-video RGB MPO

2022-10-02 Thread Sasha Levin
From: Leo Li [ Upstream commit b261509952bc19d1012cf732f853659be6ebc61e ] [Why] DC makes use of layer_index (zpos) when picking the HW plane to enable HW cursor on. However, some compositors will not attach zpos information to each DRM plane. Consequently, in amdgpu, we default layer_index to

[PATCH AUTOSEL 5.19 28/29] drm/amd/display: increase dcn315 pstate change latency

2022-10-02 Thread Sasha Levin
From: Dmytro Laktyushkin [ Upstream commit dcc2527df918edfe297c5074ccc1f05eae361ca6 ] [Why & How] Update after new measurment came in Reviewed-by: Jun Lei Acked-by: Wayne Lin Signed-off-by: Dmytro Laktyushkin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 5.19 27/29] drm/amd/display: Fix DP MST timeslot issue when fallback happened

2022-10-02 Thread Sasha Levin
From: Cruise Hung [ Upstream commit 20c6168b3c8aadef7d2853c925d99eb546bd5e1c ] [Why] When USB4 DP link training failed and fell back to lower link rate, the time slot calculation uses the verified_link_cap. And the verified_link_cap was not updated to the new one. It caused the wrong VC payload

[PATCH AUTOSEL 5.19 26/29] drm/amd/display: skip audio setup when audio stream is enabled

2022-10-02 Thread Sasha Levin
From: zhikzhai [ Upstream commit 65fbfb02c2734cacffec5e3f492e1b4f1dabcf98 ] [why] We have minimal pipe split transition method to avoid pipe allocation outage.However, this method will invoke audio setup which cause audio output stuck once pipe reallocate. [how] skip audio setup for pipelines

[PATCH AUTOSEL 5.19 25/29] drm/amd/display: update gamut remap if plane has changed

2022-10-02 Thread Sasha Levin
From: Hugo Hu [ Upstream commit 52bb21499cf54fa65b56d97cd0d68579c90207dd ] [Why] The desktop plane and full-screen game plane may have different gamut remap coefficients, if switching between desktop and full-screen game without updating the gamut remap will cause incorrect color. [How] Update

[PATCH AUTOSEL 5.19 24/29] drm/amd/display: Assume an LTTPR is always present on fixed_vs links

2022-10-02 Thread Sasha Levin
From: Michael Strauss [ Upstream commit 29956d0fded036a570bd8e7d4ea4b1a1730307d2 ] [WHY] LTTPRs can in very rare instsances fail to increment DPCD LTTPR count. This results in aux-i LTTPR requests to be sent to the wrong DPCD address, which causes link training failure. [HOW] Override internal

[PATCH AUTOSEL 5.19 23/29] drm/amd/display: Fix double cursor on non-video RGB MPO

2022-10-02 Thread Sasha Levin
From: Leo Li [ Upstream commit b261509952bc19d1012cf732f853659be6ebc61e ] [Why] DC makes use of layer_index (zpos) when picking the HW plane to enable HW cursor on. However, some compositors will not attach zpos information to each DRM plane. Consequently, in amdgpu, we default layer_index to

[PATCH AUTOSEL 5.19 11/29] drm/amdgpu/mes: zero the sdma_hqd_mask of 2nd SDMA engine for SDMA 6.0.1

2022-10-02 Thread Sasha Levin
From: Yifan Zhang [ Upstream commit 0af4ed0c329ebb4cef95fda4fcdbfcdea0255442 ] there is only one SDMA engine in SDMA 6.0.1, the sdma_hqd_mask has to be zeroed for the 2nd engine, otherwise MES scheduler will consider 2nd engine exists and map/unmap SDMA queues to the non-existent engine.

[Bug 216549] AMDGPU crash with kernel NULL pointer dereference, RIP: 0010:amdgpu_bo_get_memory

2022-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216549 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 213823] Broken power management for amdgpu

2022-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213823 Bruno Pagani (bruno.n.pag...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 216549] New: AMDGPU crash with kernel NULL pointer dereference, RIP: 0010:amdgpu_bo_get_memory

2022-10-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216549 Bug ID: 216549 Summary: AMDGPU crash with kernel NULL pointer dereference, RIP: 0010:amdgpu_bo_get_memory Product: Drivers Version: 2.5 Kernel Version: 5.19.12

Re: [PATCH] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-10-02 Thread Greg KH
On Wed, Sep 28, 2022 at 11:33:40AM +0800, Zheng Wang wrote: > If intel_gvt_dma_map_guest_page failed, it will call > ppgtt_invalidate_spt, which will finally free the spt. > But the caller does not notice that, it will free spt again in error path. > > Fix this by only freeing spt in

Re: [PATCH v3 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

2022-10-02 Thread Krzysztof Kozlowski
On 30/09/2022 20:08, Konrad Dybcio wrote: > Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2 > Compact smartphones. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[RFC PATCH 4/4] drm/rockchip: rgb: Add dphy connection to rgb output

2022-10-02 Thread Michael Trimarchi
Dispite the commit 1f0f015151727, the rgb output has an option to allow to sent the output pin using the dsi/lvds/ttl logic. The only way to do and stay on the same design is let the rockchip_rgb block to grab the handle if it is present and enable it. The present of this handle depends on dts

[RFC PATCH 2/4] phy: rockchip: Add inno_is_valid_phy_mode

2022-10-02 Thread Michael Trimarchi
The function is used to avoid to enable clock on the hardware if the mode requested is invalid Signed-off-by: Michael Trimarchi --- .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[RFC PATCH 3/4] phy: rockchip: Implement TTY phy mode

2022-10-02 Thread Michael Trimarchi
The rockchip phy can be programmed in 3 modes: - dsi - lvds - ttl For instance in px30 there are two sets of rgb interface pins m0 and m1. The logic can go outside from the VOP using m0 set or go outside using the m1 set and the ttl logic enable. There are combination where a set of pin can be

[RFC PATCH 1/4] phy: add PHY_MODE_TTL

2022-10-02 Thread Michael Trimarchi
There are combo phys out there that can be switched between doing dsi, lvds, and ttl. So add a mode definition for it. Signed-off-by: Michael Trimarchi --- include/linux/phy/phy.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/phy/phy.h

[RFC PATCH 0/4] Add RGB ttl connection on rockchip phy

2022-10-02 Thread Michael Trimarchi
The rockchip phy can be convigured in ttl mode. The phy is shared between lvds, dsi, ttl. The configuration that now I'm able to support has the display output on some set of pins on standard vop output and a set of pins using the ttl phy. The solution is not clean as I would like to have because

Re: [PATCH 14/16] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2022-10-02 Thread Niranjana Vishwanathapura
On Fri, Sep 30, 2022 at 10:47:48AM +0100, Matthew Auld wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti ---