Re: [Intel-gfx] [PATCH 0/3] Add _PICK_EVEN_RANGES

2022-10-21 Thread Lucas De Marchi
On Wed, Oct 12, 2022 at 12:05:31PM -0700, Lucas De Marchi wrote: On Wed, Oct 12, 2022 at 11:51:48AM +0300, Jani Nikula wrote: On Tue, 11 Oct 2022, Lucas De Marchi wrote: Add a new macro, _PICK_EVEN_RANGES, that supports using 2 address ranges. This should cover most of our needs for _MMIO_PLL3

[PATCH] drm/i915: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index b4f69364f9a1..7b29ef36941a 100644 --- a/drivers/gpu/drm/i915/gvt

[PATCH] drm/i915: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/i915_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 73d5195146b0..9caf99a13c61 100644 --- a/drivers/

[PATCH] i915/display: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/i915/display/intel_crt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c index 6a3893c8ff22..fead011c87b5 100644

[PATCH] gpu/drm: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/drm_rect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c index 0460e874896e..85c79a38c13a 100644 --- a/drivers/gpu/drm/drm_rect.c +++ b/dri

[PATCH] gpu/drm: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index c40bde96cfdf..ae12cca8b123 100644 --- a/drivers/gpu/drm/drm_mipi

[PATCH] drm/radeon: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/radeon/radeon_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 15692cb241fc..ff52b5f4c1e6 100644 --- a

[PATCH] amd/amdgpu: fix repeated words in comments

2022-10-21 Thread wangjianli
Delete the redundant word 'the'. Signed-off-by: wangjianli --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index e9155dc1c30c..3de990bbbf2f

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-21 Thread Dixit, Ashutosh
On Fri, 21 Oct 2022 18:38:57 -0700, Belgaumkar, Vinay wrote: > On 10/20/2022 3:57 PM, Dixit, Ashutosh wrote: > > On Tue, 18 Oct 2022 11:30:31 -0700, Vinay Belgaumkar wrote: > > Hi Vinay, > > > >> diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c > >> b/drivers/gpu/drm/i915/gt/selftest_slpc.c >

[PATCH v4 09/17] drm/vmwgfx: Diff cursors when using cmds

2022-10-21 Thread Zack Rusin
From: Michael Banack Extend the cursor diffing support to support the command-path. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 120 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 + 2 files changed, 62 insertions(+

[PATCH v4 10/17] drm/vmwgfx: Refactor ttm reference object hashtable to use linux/hashtable.

2022-10-21 Thread Zack Rusin
From: Maaz Mombasawala This is part of an effort to move from the vmwgfx_open_hash hashtable to linux/hashtable implementation. Refactor the ref_hash hashtable, used for fast lookup of reference objects associated with a ttm file. This also exposed a problem related to inconsistently using 32-bit

[PATCH v4 16/17] drm/vmwgfx: Optimize initial sizes of cotables

2022-10-21 Thread Zack Rusin
From: Zack Rusin It's important to get the initial size of cotables right because otherwise every app needs to start with a synchronous cotable resize. This has an measurable impact on system wide performance but is not relevant for long running single full screen apps for which the cotable resi

[PATCH v4 13/17] drm/vmwgfx: Port the framebuffer code to drm fb helpers

2022-10-21 Thread Zack Rusin
From: Zack Rusin Instead of using vmwgfx specific framebuffer implementation use the drm fb helpers. There's no change in functionality, the only difference is a reduction in the amount of code inside the vmwgfx module. drm fb helpers do not deal correctly with changes in crtc preferred mode at

[PATCH v4 06/17] drm/vmwgfx: Clean up cursor mobs

2022-10-21 Thread Zack Rusin
From: Michael Banack Clean up the cursor mob path by moving ownership of the mobs into the plane_state, and just leaving a cache of unused mobs in the plane itself. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 441 --

[PATCH v4 08/17] drm/vmwgfx: Support cursor surfaces with mob cursor

2022-10-21 Thread Zack Rusin
From: Michael Banack Add support for cursor surfaces when using mob cursors. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 78 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 1 + 2 files changed, 50 insertions(+), 29 de

[PATCH v4 12/17] drm/vmwgfx: Do not allow invalid bpp's for dumb buffers

2022-10-21 Thread Zack Rusin
From: Zack Rusin Dumb buffers allow a very limited set of formats. Basically everything apart from 1, 2 and 4 is expected to return an error. Make vmwgfx follow those guidelines. This fixes igt's dumb_buffer invalid_bpp test on vmwgfx. Signed-off-by: Zack Rusin Reviewed-by: Martin Krastev Rev

[PATCH v4 11/17] drm/vmwgfx: Remove vmwgfx_hashtab

2022-10-21 Thread Zack Rusin
From: Maaz Mombasawala The vmwgfx driver has migrated from using the hashtable in vmwgfx_hashtab to the linux/hashtable implementation. Remove the vmwgfx_hashtab from the driver. Signed-off-by: Maaz Mombasawala Reviewed-by: Martin Krastev Reviewed-by: Zack Rusin Signed-off-by: Zack Rusin ---

[PATCH v4 01/17] drm/vmwgfx: Write the driver id registers

2022-10-21 Thread Zack Rusin
From: Zack Rusin Driver id registers are a new mechanism in the svga device to hint to the device which driver is running. This should not change device behavior in any way, but might be convenient to work-around specific bugs in guest drivers. Signed-off-by: Zack Rusin Reviewed-by: Martin Kras

[PATCH v4 14/17] drm/vmwgfx: Remove explicit and broken vblank handling

2022-10-21 Thread Zack Rusin
From: Zack Rusin The explicit vblank handling was never finished. The driver never had the full implementation of vblank and what was there is emulated by DRM when the driver doesn't pretend to be implementing it itself. Let DRM handle the vblank emulation and stop pretending the driver is doing

[PATCH v4 07/17] drm/vmwgfx: Start diffing new mob cursors against old ones

2022-10-21 Thread Zack Rusin
From: Michael Banack Avoid making the SVGA device do extra work if the new cursor image matches the old one. Signed-off-by: Michael Banack Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 95 ++--- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 12 ++-- 2 fil

[PATCH v4 17/17] drm/vmwgfx: Fix a sparse warning in kernel docs

2022-10-21 Thread Zack Rusin
From: Zack Rusin Fixes a warning about extra docs about a function argument that has been removed a while back: drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user' Fixes: a0f90c881570 ("drm/vmwgfx: Fix stale fi

[PATCH v4 15/17] drm/vmwgfx: Add a mksstat counter for cotable resizes

2022-10-21 Thread Zack Rusin
From: Zack Rusin There's been a lot of cotable resizes on startup which we can track by adding a mks stat to measure both the invocation count and time spent doing cotable resizes. This is only used if kernel is configured with CONFIG_DRM_VMWGFX_MKSSTATS The stats are collected on the host size

[PATCH v4 02/17] drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctl

2022-10-21 Thread Zack Rusin
From: Martin Krastev Function vmw_mksstat_add_ioctl allocates three big arrays on stack. That triggers frame-size [-Wframe-larger-than=] warning. Refactor that function to use kmalloc_array instead. v2: Initialize page to null to avoid possible uninitialized use of it, spotted by the kernel

[PATCH v4 03/17] drm/vmwgfx: Refactor resource manager's hashtable to use linux/hashtable implementation.

2022-10-21 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenance burden. Refactor cmdbuf resource manager to use linux/hashtable.h implementation as part of this effort. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: M

[PATCH v4 04/17] drm/vmwgfx: Remove ttm object hashtable

2022-10-21 Thread Zack Rusin
From: Maaz Mombasawala The object_hash hashtable for ttm objects is not being used. Remove it and perform refactoring in ttm_object init function. Signed-off-by: Maaz Mombasawala Reviewed-by: Zack Rusin Reviewed-by: Martin Krastev Signed-off-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/ttm_obj

[PATCH v4 00/17] drm/vmwgfx: fb, cursors and hashtable refactor

2022-10-21 Thread Zack Rusin
From: Zack Rusin v4: Fix one more LPK warning found in the "Fix frame-size warning in vmw_mksstat_add_ioctl" change v3: Add improvements suggested by Thomas for the fb port change and add a commit that fixes a sparse kernel doc warning v2: Fix LKP and sparse reported issues This is a bit lar

[PATCH v4 05/17] drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.

2022-10-21 Thread Zack Rusin
From: Maaz Mombasawala Vmwgfx's hashtab implementation needs to be replaced with linux/hashtable to reduce maintenence burden. As part of this effort, refactor the res_ht hashtable used for resource validation during execbuf execution to use linux/hashtable implementation. This also refactors vmw

Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-21 Thread Dixit, Ashutosh
On Fri, 21 Oct 2022 17:24:52 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > Waitboost (when SLPC is enabled) results in a H2G message. This can result > in thousands of messages during a stress test and fill up an already full > CTB. There is no need to request for RP0 if boost_freq and the min sof

Re: [RFC PATCH] drm/scheduler: Set the FIFO schedulig policy as the default

2022-10-21 Thread Luben Tuikov
Please comment on the v1 of this patch, which I sent right after. Regards, Luben On 2022-10-21 21:09, Luben Tuikov wrote: > The currently default Round-Robin GPU scheduling can result in starvation > of entities which have a large number of jobs, over entities which have > a very small number of

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-21 Thread Belgaumkar, Vinay
On 10/20/2022 3:57 PM, Dixit, Ashutosh wrote: On Tue, 18 Oct 2022 11:30:31 -0700, Vinay Belgaumkar wrote: Hi Vinay, diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu/drm/i915/gt/selftest_slpc.c index 4c6e9257e593..e42bc215e54d 100644 --- a/drivers/gpu/drm/i915/gt/selftest_sl

[RFC PATCH v1] drm/scheduler: Set the FIFO scheduling policy as the default

2022-10-21 Thread Luben Tuikov
The currently default Round-Robin GPU scheduling can result in starvation of entities which have a large number of jobs, over entities which have a very small number of jobs (single digit). This can be illustrated in the following diagram, where jobs are alphabetized to show their chronological or

[RFC PATCH] drm/scheduler: Set the FIFO schedulig policy as the default

2022-10-21 Thread Luben Tuikov
The currently default Round-Robin GPU scheduling can result in starvation of entities which have a large number of jobs, over entities which have a very small number of jobs (single digit). This can be illustrated in the following diagram, where jobs are alphabetized to show their chronological or

[PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-21 Thread Vinay Belgaumkar
Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for RP0 if boost_freq and the min softlimit are the same. v2: Add the tracing back, and check requested freq in the

Re: [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2022-10-21 Thread Umesh Nerlige Ramappa
On Fri, Oct 21, 2022 at 09:42:53AM +0100, Tvrtko Ursulin wrote: On 27/10/2021 01:48, Umesh Nerlige Ramappa wrote: [snip] +static void guc_timestamp_ping(struct work_struct *wrk) +{ + struct intel_guc *guc = container_of(wrk, typeof(*guc), +tim

[PATCH v3 4/7] drm/i915/guc: Add GuC deprivilege feature to MTL

2022-10-21 Thread Daniele Ceraolo Spurio
From: Stuart Summers MTL supports GuC deprivilege. Add the feature flag to this platform. Signed-off-by: Stuart Summers Cc: Radhakrishna Sripada Cc: John Harrison Cc: Alan Previn Reviewed-by: John Harrison --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v3 7/7] drm/i915/guc: handle interrupts from media GuC

2022-10-21 Thread Daniele Ceraolo Spurio
The render and media GuCs share the same interrupt enable register, so we can no longer disable interrupts when we disable communication for one of the GuCs as this would impact the other GuC. Instead, we keep the interrupts always enabled in HW and use a variable in the GuC structure to determine

[PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-21 Thread Daniele Ceraolo Spurio
From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lower 2MB for SA Media and upper 2MB for GCD/GT. +=+===> ++ <== WOPCM TOP

[PATCH v3 6/7] drm/i915/guc: define media GT GuC send regs

2022-10-21 Thread Daniele Ceraolo Spurio
The media GT shares the G-unit with the root GT, so a second set of communication registers is required for the media GuC. Signed-off-by: Daniele Ceraolo Spurio Cc: John Harrison Cc: Alan Previn Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 14 ++ dri

[PATCH v3 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-21 Thread Daniele Ceraolo Spurio
Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be loaded on the same GGTT at the same time. On MTL, however, this can happen if both GTs are reset at th

[PATCH v3 1/7] drm/i915/huc: only load HuC on GTs that have VCS engines

2022-10-21 Thread Daniele Ceraolo Spurio
On MTL the primary GT doesn't have any media capabilities, so no video engines and no HuC. We must therefore skip the HuC fetch and load on that specific case. Given that other multi-GT platforms might have HuC on the primary GT, we can't just check for that and it is easier to instead check for th

[PATCH v3 2/7] drm/i915/uc: fetch uc firmwares for each GT

2022-10-21 Thread Daniele Ceraolo Spurio
The FW binaries are independently loaded on each GT. On MTL, the memory is shared so we could potentially re-use a single allocation, but on discrete multi-gt platforms we are going to need independent copies, so it is easier to do the same on MTL as well, given that the amount of duplicated memory

[PATCH v3 0/7] drm/i915: prepare for uC loading on MTL

2022-10-21 Thread Daniele Ceraolo Spurio
The introduction of the media GT brings a few changes for GuC/HuC. The main difference between the 2 GTs is that only the media one has the HuC, while both have the GuC. Also, the fact that both GTs use the same G-unit and GGTT means we now have parallel interrupt/communication paths. Lastly, WOPCM

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-21 Thread Belgaumkar, Vinay
On 10/21/2022 11:40 AM, Dixit, Ashutosh wrote: On Fri, 21 Oct 2022 11:24:42 -0700, Belgaumkar, Vinay wrote: On 10/20/2022 4:36 PM, Dixit, Ashutosh wrote: On Thu, 20 Oct 2022 13:16:00 -0700, Belgaumkar, Vinay wrote: On 10/20/2022 11:33 AM, Dixit, Ashutosh wrote: On Wed, 19 Oct 2022 17:29:44

Re: [PATCH v2] drm/msm/mdp5: stop overriding drvdata

2022-10-21 Thread Abhinav Kumar
Hi Dmitry A couple of comments below. On 10/21/2022 12:26 PM, Dmitry Baryshkov wrote: The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do not override the mdp5's drvdata. Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") S

Re: [PATCH] drm/edid: Dump the EDID when drm_edid_get_panel_id() has an error

2022-10-21 Thread Abhinav Kumar
Hi Doug On 10/21/2022 1:07 PM, Douglas Anderson wrote: If we fail to get a valid panel ID in drm_edid_get_panel_id() we'd like to see the EDID that was read so we have a chance of understanding what's wrong. There's already a function for that, so let's call it in the error case. NOTE: edid_blo

Re: [PATCH -next] nouveau/dmem: Remove duplicated include in nouveau_dmem.c

2022-10-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push in just a moment to drm-misc-next, thanks! On Mon, 2022-10-17 at 08:07 +0800, Yang Li wrote: > ./drivers/gpu/drm/nouveau/nouveau_dmem.c: nvif/if000c.h is included more > than once. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2404 > Reported-by: Aba

Re: [PATCH v4] drm: Remove drm_mode_config::fb_base

2022-10-21 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Tue, 2022-10-18 at 22:43 -0400, Zack Rusin wrote: > From: Zack Rusin > > v4: Fix issue spotted by the kernel test robot > > The fb_base in struct drm_mode_config has been unused for a long time. > Some drivers set it and some don't leading to a

[PATCH 16/21] fbdev: remove s3c2410 framebuffer

2022-10-21 Thread Arnd Bergmann
From: Arnd Bergmann The s3c24xx platform was removed, so the framebuffer driver is no longer needed. Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/Kconfig | 33 +- drivers/video/fbdev/Makefile |1 - drivers/video/fbdev/s3c2410fb-regs-lcd.h | 143 --- driv

Re: [PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-21 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Thu, 2022-10-20 at 14:56 -0700, Dan Williams wrote: > A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE > pages. The pgmap is a reference counted object that serves a similar > role as a 'struct request_queue'. Live references

[PATCH 00/21] ARM: s3c: clean out obsolete platforms

2022-10-21 Thread Arnd Bergmann
From: Arnd Bergmann The s3c24xx platform was marked as deprecated a while ago, and for the s3c64xx platform, we marked all except one legacy board file as unused. This series removes all of those, leaving only s3c64xx support for DT based boots as well as the cragg6410 board file. About half of

Re: [PATCH] drm/nouveau: Remove unused variable

2022-10-21 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to drm-misc-next as well On Thu, 2022-10-20 at 21:07 -0400, Zack Rusin wrote: > From: Zack Rusin > > Trivial removal of an unused variable. Not sure how it snuck by me and > build bots in the 7c99616e3fe7. > > Fixes: 7c99616e3fe7 ("drm: Remove drm_mode_config

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2022-10-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #46 from Alex Deucher (alexdeuc...@gmail.com) --- Please try with the prefer_shadow patch. It sounds like we may be on the right track. -- You may reply to this email to add a comment. You are receiving this mail because: You are w

[PATCH] drm/edid: Dump the EDID when drm_edid_get_panel_id() has an error

2022-10-21 Thread Douglas Anderson
If we fail to get a valid panel ID in drm_edid_get_panel_id() we'd like to see the EDID that was read so we have a chance of understanding what's wrong. There's already a function for that, so let's call it in the error case. NOTE: edid_block_read() has a retry loop in it, so actually we'll only p

Re: [PATCH v3 17/17] drm/vmwgfx: Fix a sparse warning in kernel docs

2022-10-21 Thread "Maaz Mombasawala (VMware)
On 10/20/22 20:44, Zack Rusin wrote: > From: Zack Rusin > > Fixes a warning about extra docs about a function argument that has been > removed a while back: > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function > parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user

[PATCH v2] drm/msm/mdp5: stop overriding drvdata

2022-10-21 Thread Dmitry Baryshkov
The rest of the code expects that master's device drvdata is the struct msm_drm_private instance. Do not override the mdp5's drvdata. Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- Abhinav, Rob, please pick

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-21 Thread Dixit, Ashutosh
On Fri, 21 Oct 2022 11:24:42 -0700, Belgaumkar, Vinay wrote: > > > On 10/20/2022 4:36 PM, Dixit, Ashutosh wrote: > > On Thu, 20 Oct 2022 13:16:00 -0700, Belgaumkar, Vinay wrote: > >> On 10/20/2022 11:33 AM, Dixit, Ashutosh wrote: > >>> On Wed, 19 Oct 2022 17:29:44 -0700, Vinay Belgaumkar wrote: > >

Re: [PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-21 Thread Felix Kuehling
On 2022-10-20 19:17, Dan Williams wrote: Felix Kuehling wrote: Am 2022-10-20 um 17:56 schrieb Dan Williams: A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE pages. The pgmap is a reference counted object that serves a similar role as a 'struct request_queue'. Live referen

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-21 Thread Belgaumkar, Vinay
On 10/20/2022 4:36 PM, Dixit, Ashutosh wrote: On Thu, 20 Oct 2022 13:16:00 -0700, Belgaumkar, Vinay wrote: On 10/20/2022 11:33 AM, Dixit, Ashutosh wrote: On Wed, 19 Oct 2022 17:29:44 -0700, Vinay Belgaumkar wrote: Hi Vinay, Waitboost (when SLPC is enabled) results in a H2G message. This can

Re: [PATCH v4 4/4] hwmon: adm1177: simplify using devm_regulator_get_enable()

2022-10-21 Thread Guenter Roeck
On Fri, Oct 21, 2022 at 04:19:04PM +0300, Matti Vaittinen wrote: > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > add_action_or_reset(regulator_disable)' and use the > devm_regulator_get_enable() and drop the pointer to the regulator. > This simplifies code and makes it less

Re: [PATCH v4 3/4] hwmon: lm90: simplify using devm_regulator_get_enable()

2022-10-21 Thread Guenter Roeck
On Fri, Oct 21, 2022 at 04:18:43PM +0300, Matti Vaittinen wrote: > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > add_action_or_reset(regulator_disable)' and use the > devm_regulator_get_enable(). > > Signed-off-by: Matti Vaittinen > Acked-by: Guenter Roeck Applied to hwm

[PATCH v8 4/5] drm/bridge: cdns-dsi: Create a header file

2022-10-21 Thread Rahul T R
Create a header file for cdns dsi and move register offsets and structure to header, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R --- .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 446 + .../gpu/drm/bridge/cadence/cdns-dsi-core.h| 458 +++

[PATCH v8 1/5] dt-bindings: display: bridge: Convert cdns, dsi.txt to yaml

2022-10-21 Thread Rahul T R
Convert cdns,dsi.txt binding to yaml format Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.txt | 112 - .../bindings/display/bridge/cdns,dsi.yaml | 157 ++ 2 files changed, 157 insertions(+), 112 deletions(-) dele

[PATCH v8 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2022-10-21 Thread Rahul T R
Move the cadence dsi bridge under drm/bridge/cadence directory, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R --- drivers/gpu/drm/bridge/Kconfig| 11 --- drivers/gpu/drm/bridge/Makefile | 1 - drivers/gpu/drm/bridge/ca

[PATCH v8 0/5] Add support for CDNS DSI J721E wrapper

2022-10-21 Thread Rahul T R
Following series of patches adds supports for CDNS DSI bridge on j721e. v8: - Rebased to 6.1-rc1 v7: - Rebased to next-20220920 - Accumulated the Reviewed-by acks v6: - Dropped generic definations for properties like reg, resets etc.. - Fixed the defination for port@0 and port@1 - removed

[PATCH v8 2/5] dt-bindings: display: bridge: cdns, dsi: Add compatible for dsi on j721e

2022-10-21 Thread Rahul T R
Add compatible to support dsi bridge on j721e Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.yaml | 25 ++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yam

[PATCH v8 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2022-10-21 Thread Rahul T R
Add support for wrapper settings for DSI bridge on j721e. Also set the DPI input to DPI0 Signed-off-by: Rahul T R --- drivers/gpu/drm/bridge/cadence/Kconfig| 10 drivers/gpu/drm/bridge/cadence/Makefile | 1 + .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 37 +-

Re: [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:21PM -0700, Ashutosh Dixit wrote: > From: Badal Nilawar > > Add support for C6 residency and C state type for MTL SAMedia. Also add > mtl_drpc. I believe this patch deserves a slip between the actual support and the debugfs, but I'm late to the review, so feel free

[PATCH] drm/amd/display: don't print messages that contain %f in dml

2022-10-21 Thread Hamza Mahfooz
Unfortunately, printk() doesn't currently support the printing of %f entries. So, print statements that contain "%f" should be removed. However, since DC is used on other OSes that can still benefit from the additional debugging information, we should instead remove the problematic print statements

Re: [PATCH 4/5] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:20PM -0700, Ashutosh Dixit wrote: > Previously RC6 residency functions directly accepted RC6 residency register > MMIO offsets (there are four RC6 residency registers). This worked but > required an assumption on the residency register layout so was not future > proof.

Re: [Intel-gfx] [PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-21 Thread Rodrigo Vivi
On Fri, Oct 21, 2022 at 09:02:03AM -0700, Dixit, Ashutosh wrote: > On Wed, 19 Oct 2022 16:37:19 -0700, Ashutosh Dixit wrote: > > > > From: Badal Nilawar > > > > Update CAGF functions for MTL to get actual resolved frequency of 3D and > > SAMedia. > > > > v2: Update MTL_MIRROR_TARGET_WP1 position/f

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:18PM -0700, Ashutosh Dixit wrote: > From: Don Hiatt > > On GEN12+ use GEN12_RPSTAT register to get actual resolved GT > freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if > GT is in RC6. > > v2: > - Fixed review comments(Ashutosh) > - Adde

Re: [PATCH 1/5] drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf

2022-10-21 Thread Rodrigo Vivi
On Wed, Oct 19, 2022 at 04:37:17PM -0700, Ashutosh Dixit wrote: > Instead of masks/shifts settle on REG_FIELD_GET as the standard way to > extract reg fields. This allows future patches touching this code to also > consistently use REG_FIELD_GET and friends. > > Suggested-by: Rodrigo Vivi > Signe

Re: [Intel-gfx] [PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-21 Thread Dixit, Ashutosh
On Wed, 19 Oct 2022 16:37:19 -0700, Ashutosh Dixit wrote: > > From: Badal Nilawar > > Update CAGF functions for MTL to get actual resolved frequency of 3D and > SAMedia. > > v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) > Move MTL branches in cagf functions to top (MattR) >

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-21 Thread Abhinav Kumar
Hi Johan On 10/20/2022 11:27 PM, Johan Hovold wrote: On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: The MSM DRM driver is currently broken in multiple ways with respect to probe deferral. Not only does the driver curr

Re: [PATCH v4] overflow: Introduce overflows_type() and castable_to_type()

2022-10-21 Thread Nathan Chancellor
Hi Gwan-gyeong, On Fri, Oct 21, 2022 at 11:33:33AM +0300, Gwan-gyeong Mun wrote: > From: Kees Cook > > Implement a robust overflows_type() macro to test if a variable or > constant value would overflow another variable or type. This can be > used as a constant expression for static_assert() (whi

[PATCH 02/11] ARM: sa1100: remove unused board files

2022-10-21 Thread Arnd Bergmann
From: Arnd Bergmann The Cerf, H3100, Badge4, Hackkit, LART, NanoEngine, PLEB, Shannon and Simpad machines were all marked as unused as there are no known users left. Remove all of these, along with references to them in defconfig files and drivers. Four machines remain now: Assabet, Collie (Zaur

[PATCH 00/11] ARM: sa1100, mmp: drop unused board files

2022-10-21 Thread Arnd Bergmann
From: Arnd Bergmann A number of board files were marked as 'unused' in 2022 and can get removed in linux-6.2 at the beginning of 2023. I wanted to group these two platforms with the PXA series, but that one is already too big. MMP is now DT-only, which allows removing most of the platform specif

Re: [PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-21 Thread Nícolas F . R . A . Prado
On Fri, Oct 21, 2022 at 08:18:25PM +0800, xinlei.lee wrote: > On Thu, 2022-10-20 at 12:40 -0400, Nícolas F. R. A. Prado wrote: > > On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com > > wrote: [..] > > > @@ -448,8 +453,12 @@ static void mtk_dpi_dual_edge(struct mtk_dpi > > > *dpi) >

Re: [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Neil Armstrong
Hi, On 21/10/2022 17:02, Laurent Pinchart wrote: Hi Matti, On Fri, Oct 21, 2022 at 04:18:01PM +0300, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen --- v3 => v4: - spl

Re: [PATCH v12,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-21 Thread Nícolas F . R . A . Prado
On Fri, Oct 21, 2022 at 07:59:02PM +0800, xinlei.lee wrote: > On Thu, 2022-10-20 at 12:33 -0400, Nícolas F. R. A. Prado wrote: > > Hi, > > > > On Wed, Oct 19, 2022 at 10:52:14AM +0800, xinlei@mediatek.com > > wrote: > > > From: Xinlei Lee > > > > > > The difference between MT8186 and other I

Re: [PATCH] drm/amd/display: Remove duplicate code for DCN314 DML calculation

2022-10-21 Thread Harry Wentland
On 2022-10-20 18:10, Rafael Mendonca wrote: > This is an extension of commit fd3bc691fc7b ("drm/amd/display: Remove > duplicate code across dcn30 and dcn31"), which removed duplicate code for > the function CalculateBytePerPixelAnd256BBlockSizes() across dcn30 and > dcn31. At the time the aforem

Re: [PATCH] drm/bridge: ps8640: Add back the 50 ms mystery delay after HPD

2022-10-21 Thread Doug Anderson
Hi, On Wed, Oct 19, 2022 at 11:22 AM Doug Anderson wrote: > > Hi, > > On Wed, Oct 19, 2022 at 11:18 AM Stephen Boyd wrote: > > > > Quoting Douglas Anderson (2022-10-17 12:18:51) > > > Back in commit 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable > > > runtime power management") we removed a my

Re: [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Laurent Pinchart
Hi Matti, On Fri, Oct 21, 2022 at 04:18:01PM +0300, Matti Vaittinen wrote: > Simplify using the devm_regulator_get_enable_optional(). Also drop the > seemingly unused struct member 'hdmi_supply'. > > Signed-off-by: Matti Vaittinen > > --- > v3 => v4: > - split meson part to own patch > > RFCv1

Re: [PATCH] drm/panel-edp: Add INX N116BGE-EA2 (HW: C4)

2022-10-21 Thread Doug Anderson
Hi, On Thu, Oct 20, 2022 at 8:10 PM Sean Hong wrote: > > Add support for the INX - N116BGE-EA2 (HW: C4) panel. > > Signed-off-by: Sean Hong > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Douglas Anderson NOTE: please send patches in a 2-part se

Re: [PATCH] drm/panel-edp: Add INX N116BGE-EA2 (HW: C2)

2022-10-21 Thread Doug Anderson
Hi, On Thu, Oct 20, 2022 at 7:58 PM Sean Hong wrote: > > Add support for the INX - N116BGE-EA2 (HW: C2) panel. > > Signed-off-by: Sean Hong > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Douglas Anderson For these simple table entries, I don't

Re: [PATCH v3 17/17] drm/vmwgfx: Fix a sparse warning in kernel docs

2022-10-21 Thread Martin Krastev (VMware)
From: Martin Krastev On 21.10.22 г. 6:44 ч., Zack Rusin wrote: From: Zack Rusin Fixes a warning about extra docs about a function argument that has been removed a while back: drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function parameter 'sync_file' description in 'vmw_exec

Re: [PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Neil Armstrong
On 21/10/2022 15:18, Matti Vaittinen wrote: Simplify using the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen --- v3 => v4: - split meson part to own patch RFCv1 => v2: - Change also sii902x to use devm_regulato

Re: [PATCH v4 2/4] gpu: drm: sii902x: Use devm_regulator_bulk_get_enable()

2022-10-21 Thread Matti Vaittinen
On 10/21/22 16:18, Matti Vaittinen wrote: Simplify using devm_regulator_bulk_get_enable() Signed-off-by: Matti Vaittinen Reviewed-by: Robert Foss Robert, I did slightly modify the return from probe when using the dev_err_probe(). I still decided to keep your RBT - please let me know if you

[PATCH v4 4/4] hwmon: adm1177: simplify using devm_regulator_get_enable()

2022-10-21 Thread Matti Vaittinen
Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), add_action_or_reset(regulator_disable)' and use the devm_regulator_get_enable() and drop the pointer to the regulator. This simplifies code and makes it less tempting to add manual control for the regulator which is also controlled

[PATCH v4 3/4] hwmon: lm90: simplify using devm_regulator_get_enable()

2022-10-21 Thread Matti Vaittinen
Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), add_action_or_reset(regulator_disable)' and use the devm_regulator_get_enable(). Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- RFCv1 => v2: - No changes --- drivers/hwmon/lm90.c | 20 ++-- 1 file c

[PATCH v4 2/4] gpu: drm: sii902x: Use devm_regulator_bulk_get_enable()

2022-10-21 Thread Matti Vaittinen
Simplify using devm_regulator_bulk_get_enable() Signed-off-by: Matti Vaittinen Reviewed-by: Robert Foss --- v3 => v4: - split to own patch. - return directly the value returned by the dev_err_probe() Please note - this is only compile-tested due to the lack of HW. Careful review and testing is

[PATCH v4 1/4] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-10-21 Thread Matti Vaittinen
Simplify using the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen --- v3 => v4: - split meson part to own patch RFCv1 => v2: - Change also sii902x to use devm_regulator_bulk_get_enable() Please note - this is onl

[PATCH v4 0/4] Use devm helpers for regulator get and enable

2022-10-21 Thread Matti Vaittinen
Simplify couple of drivers by using the new devm_regulator_*get_enable*() These patches were previously part of the series: https://lore.kernel.org/lkml/cover.1660934107.git.mazziesacco...@gmail.com/ "Devm helpers for regulator get and enable". I did keep the patch series versioning even though I

[PATCH v2] drm/vc4: hdmi: Fix HSM clock too low on Pi4

2022-10-21 Thread maxime
Commit ae71ab585c81 ("drm/vc4: hdmi: Enforce the minimum rate at runtime_resume") reintroduced the call to clk_set_min_rate in an attempt to fix the boot without a monitor connected on the RaspberryPi3. However, that introduced a regression breaking the display output entirely (black screen but no

[PATCH] drm/vc4: hdmi: Fix HSM clock too low on Pi4

2022-10-21 Thread maxime
Commit ae71ab585c81 ("drm/vc4: hdmi: Enforce the minimum rate at runtime_resume") reintroduced the call to clk_set_min_rate in an attempt to fix the boot without a monitor connected on the RaspberryPi3. However, that introduced a regression breaking the display output entirely (black screen but no

Re: [6.1][regression] after commit dd80d9c8eecac8c516da5b240d01a35660ba6cb6 some games (Cyberpunk 2077, Forza Horizon 4/5) hang at start

2022-10-21 Thread Mikhail Gavrilov
On Fri, Oct 21, 2022 at 1:33 PM Christian König wrote: > > Hi, > > yes Bas already reported this issue, but I couldn't reproduce it. Need > to come up with a patch to narrow this down further. > > Can I send you something to test? I would appreciate to test any patches and ideas. -- Best Regard

Re: [PATCH v12,2/3] drm: mediatek: Set dpi format in mmsys

2022-10-21 Thread xinlei . lee
On Thu, 2022-10-20 at 12:40 -0400, Nícolas F. R. A. Prado wrote: > On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com > wrote: > [..] > > @@ -134,6 +137,7 @@ struct mtk_dpi_yc_limit { > > * @yuv422_en_bit: Enable bit of yuv422. > > * @csc_enable_bit: Enable bit of CSC. > > * @p

Re: [PATCH v12,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func

2022-10-21 Thread xinlei . lee
On Thu, 2022-10-20 at 12:33 -0400, Nícolas F. R. A. Prado wrote: > Hi, > > On Wed, Oct 19, 2022 at 10:52:14AM +0800, xinlei@mediatek.com > wrote: > > From: Xinlei Lee > > > > The difference between MT8186 and other ICs is that when modifying > > the > > output format, we need to modify the m

RE: [Intel-gfx] Random submitter change in Freedesktop Patchwork

2022-10-21 Thread Saarinen, Jani
Hi, > -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjälä > Sent: torstai 20. lokakuuta 2022 19.21 > To: Jani Nikula > Cc: Sarvela, Tomi P ; > intel-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org; Vivi, Rodrigo > Subject: Re: [Intel-gfx] Random submitter ch

Re: [PATCH v5 09/10] gna: add power management

2022-10-21 Thread Linus Walleij
On Thu, Oct 20, 2022 at 7:57 PM Maciej Kwapulinski wrote: > Implement power management in GNA driver > > Signed-off-by: Maciej Kwapulinski > Tested-by: Mikolaj Grzybowski > Co-developed-by: Tomasz Jankowski > Signed-off-by: Tomasz Jankowski > Co-developed-by: Jianxun Zhang > Signed-off-by: J

  1   2   >