Re: [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread Lucas De Marchi
On Wed, Nov 02, 2022 at 12:21:08PM -0700, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling priority was left at zero (meaning

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used

[PATCH 2/2] drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code

2022-11-04 Thread Lyude Paul
Looks like that we're accidentally dropping a pretty important return code here. For some reason, we just return -EINVAL if we fail to get the MST topology state. This is wrong: error codes are important and should never be squashed without being handled, which here seems to have the potential to

[PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-04 Thread Lyude Paul
It appears that amdgpu makes the mistake of completely ignoring the return values from the DP MST helpers, and instead just returns a simple true/false. In this case, it seems to have come back to bite us because as a result of simply returning false from compute_mst_dsc_configs_for_state(),

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit

[PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-04 Thread Antonio Gomes
From: antoniospg Summary: * Add support to turn on/off backlight when changing values in bl_power file. This is achieved by using function backlight_get_brightness() in nva3_set_intensity to get current brightness. Test plan: * Turn off: echo 1 > /sys/class/backlight/nv_backlight/bl_power

[PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-04 Thread Antonio Gomes
From: antoniospg Summary: * Add support to turn on/off backlight when changing values in bl_power file. This is achieved by using function backlight_get_brightness() in nva3_set_intensity to get current brightness. Test plan: * Turn off: echo 1 > /sys/class/backlight/nv_backlight/bl_power

Re: [git pull] drm fixes for 6.1-rc4

2022-11-04 Thread pr-tracker-bot
The pull request you sent on Fri, 4 Nov 2022 13:21:02 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-11-04-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fde25beb382b7dd6f2eab8022ab017cbdfaa3ff6 Thank you! -- Deet-doot-dot, I am a bot.

[pull] amdgpu, amdkfd, radeon, drm drm-next-6.2

2022-11-04 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.2. The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-6.2-2022-11-04 for you to

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Dmitry Osipenko
On 11/4/22 23:37, Robin Murphy wrote: > On 2022-11-04 20:11, Dmitry Osipenko wrote: >> On 8/23/22 01:01, Robin Murphy wrote: >>> Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old >>> single-page interfaces eventually go away. Unmapping heap BOs still >>> wants to be done a

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 04:38:34PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 15:42:09 -0400 > Steven Rostedt wrote: > [ ... ] > > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > >

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 03:42:09PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 12:22:32 -0700 > Guenter Roeck wrote: > > > Unfortunately the renaming caused some symbol conflicts. > > > > Global definition: timer_shutdown > > > > File Line > > 0 time.c93 static

Re: Coverity: kfd_parse_subtype_cache(): Memory - corruptions

2022-11-04 Thread Felix Kuehling
On 2022-11-04 15:41, coverity-bot wrote: Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221104 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 15:42:09 -0400 Steven Rostedt wrote: > $ git grep '\btimer_shutdown' > arch/arm/mach-spear/time.c:static inline void timer_shutdown(struct > clock_event_device *evt) > arch/arm/mach-spear/time.c: timer_shutdown(evt); > arch/arm/mach-spear/time.c: timer_shutdown(evt);

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Robin Murphy
On 2022-11-04 20:11, Dmitry Osipenko wrote: On 8/23/22 01:01, Robin Murphy wrote: Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old single-page interfaces eventually go away. Unmapping heap BOs still wants to be done a page at a time, but everything else can get the full

Re: [PATCH] drm/panfrost: Update io-pgtable API

2022-11-04 Thread Dmitry Osipenko
On 8/23/22 01:01, Robin Murphy wrote: > Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old > single-page interfaces eventually go away. Unmapping heap BOs still > wants to be done a page at a time, but everything else can get the full > benefit of the more efficient interface.

Re: [PATCH 07/10] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-04 Thread Jason Gunthorpe
On Tue, Nov 01, 2022 at 08:21:20AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, October 26, 2022 2:51 AM > > > > +int vfio_iommufd_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx) > > +{ > > + u32 ioas_id; > > + u32 device_id; > > + int ret; > > + > > +

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Fri, Nov 4, 2022 at 12:42 PM Steven Rostedt wrote: > > Linus, should I also add any patches that has already been acked by the > respective maintainer? No, I'd prefer to keep only the ones that are 100% unambiguously not changing any semantics. Linus

Re: [PATCH 05/10] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-04 Thread Jason Gunthorpe
On Thu, Nov 03, 2022 at 04:38:16AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, November 1, 2022 8:26 PM > > And this: > > > > /* > > * If the device does not have > > IOMMU_CAP_ENFORCE_CACHE_COHERENCY then > > * any domain later attached to it will also

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 12:22:32 -0700 Guenter Roeck wrote: > Unfortunately the renaming caused some symbol conflicts. > > Global definition: timer_shutdown > > File Line > 0 time.c93 static inline void timer_shutdown(struct > clock_event_device *evt) > 1 arm_arch_timer.c

Coverity: kfd_parse_subtype_cache(): Memory - corruptions

2022-11-04 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221104 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Daniel Latypov
On Fri, Nov 4, 2022 at 12:50 AM Mauro Carvalho Chehab wrote: > > On Thu, 3 Nov 2022 15:43:26 -0700 > Daniel Latypov wrote: > > > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Hi, > > > > > > I'm facing a couple of issues when testing KUnit with the i915 driver. > >

Re: [PATCH 2/2] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-04 Thread Belgaumkar, Vinay
On 10/31/2022 8:36 PM, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. C6 entry instead of RC6. Also *needs*. Bspec: 71496 Cc: Daniele Ceraolo Spurio Signed-off-by: Vinay

Re: [RFC][PATCH v3 13/33] timers: drm: Use timer_shutdown_sync() before freeing timer

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 08:48:28 + Tvrtko Ursulin wrote: > If it stays all DRM drivers in one patch then I guess it needs to go via > drm-misc, which for i915 would be okay I think in this case since patch > is extremely unlikely to clash with anything. Or split it up per driver > and then we

Re: [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread John Harrison
On 11/4/2022 11:53, Ceraolo Spurio, Daniele wrote: On 11/2/2022 12:21 PM, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling

Re: [RFC][PATCH v3 12/33] timers: dma-buf: Use timer_shutdown_sync() before freeing timer

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 08:15:53 +0100 Christian König wrote: > > index fb6e0a6ae2c9..5d3e7b503501 100644 > > --- a/drivers/dma-buf/st-dma-fence.c > > +++ b/drivers/dma-buf/st-dma-fence.c > > @@ -412,7 +412,7 @@ static int test_wait_timeout(void *arg) > > > > err = 0; > > err_free: > > -

[linux-next:master] BUILD SUCCESS WITH WARNING 0cdb3579f1ee4c1e55acf8dfb0697b660067b1f8

2022-11-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0cdb3579f1ee4c1e55acf8dfb0697b660067b1f8 Add linux-next specific files for 20221104 Warning reports: https://lore.kernel.org/oe-kbuild-all/202211041320.coq8eelj-...@intel.com https

Re: [PATCH v2 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-11-04 Thread Ceraolo Spurio, Daniele
On 11/2/2022 12:21 PM, john.c.harri...@intel.com wrote: From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling priority was left at zero (meaning super high

Re: [PATCH 1/2] drm/radeon: Using unsigned long instead of unsigned to fix possible overflow

2022-11-04 Thread Alex Deucher
On Fri, Nov 4, 2022 at 6:05 AM Hanjun Guo wrote: > > VBIOSImageOffset in struct UEFI_ACPI_VFCT is ULONG (unsigned long), > but it will be assigned to "unsigned offset", so use unsigned long > instead of unsigned for the offset, to avoid possible overflow. ULONG in atombios is 32 bits so an int

Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources

2022-11-04 Thread Liviu Dudau
On Wed, Oct 26, 2022 at 05:34:27PM +0200, Danilo Krummrich wrote: > Hi, Hi Danilo, > > This patch series converts the driver to use drm managed resources to prevent > potential use-after-free issues on driver unbind/rebind and to get rid of the > usage of deprecated APIs. > > Changes in v2: >

Re: [PATCH v3 3/8] dt-bindings: display/msm: add support for the display on SM8450

2022-11-04 Thread Rob Herring
On Fri, 04 Nov 2022 16:03:19 +0300, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/qcom,sm8450-dpu.yaml | 132 +++ >

Re: [PATCH v2] drm/i915/mtl: Add Wa_14017073508 for SAMedia

2022-11-04 Thread Rodrigo Vivi
On Fri, Nov 04, 2022 at 12:15:59AM +0530, Badal Nilawar wrote: > This workaround is added for Media tile of MTL A step. It is to help > pcode workaround which handles the hardware issue seen during package C2/C3 > transitions due to RC6 entry/exit transitions on Media tile. As a part of >

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-04 Thread John Harrison
On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin wrote: On 03/11/2022 09:18, Tvrtko Ursulin wrote: On 03/11/2022 01:33, John Harrison wrote: On 11/2/2022 07:20, Tvrtko Ursulin wrote: On 02/11/2022 12:12, Jani Nikula

Re: [PATCH RESEND 00/13] Convert omapfb drivers to gpiod API

2022-11-04 Thread Helge Deller
On 11/4/22 04:16, Dmitry Torokhov wrote: This series converts various OMAPFB drivers to use the newer gpiod API that respects line polarity specified in DTS. Unfortunately existing DTS files specify incorrect (active high) polarity for reset lines. As discussed in [1] we will not try to correct

Re: [PATCH v2 5/5] drm/i915/mtl: don't expose GSC command streamer to the user

2022-11-04 Thread Matt Roper
On Wed, Nov 02, 2022 at 10:10:47AM -0700, Daniele Ceraolo Spurio wrote: > There is no userspace user for this CS yet, we only need it for internal > kernel ops (e.g. HuC, PXP), so don't expose it. > > v2: even if it's not exposed, rename the engine so it is easier to > identify in the debug logs

[PATCH 0/2] Add GT oriented dmesg output

2022-11-04 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[PATCH 2/2] drm/i915/uc: Update the gt/uc code to use GT_ERR and friends

2022-11-04 Thread John . C . Harrison
From: John Harrison Use the new GT oriented output message helpers where possible. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 25 +++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 9 +- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 50 --

[PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-04 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

Re: [PATCH v2 22/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-04 Thread David Lechner
On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip "clk48" clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most

Re: [PATCH v2 54/65] clk: da8xx: clk48: Switch to determine_rate

2022-11-04 Thread David Lechner
On 11/4/22 8:18 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely

Re: [PATCH v2 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2022-11-04 Thread David Lechner
On 11/4/22 8:17 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most

Re: [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Thu, Nov 3, 2022 at 10:48 PM Steven Rostedt wrote: > > Ideally, I would have the first patch go into this rc cycle, which is mostly > non functional as it will allow the other patches to come in via the > respective > subsystems in the next merge window. Ack. I also wonder if we could do

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-11-04 Thread Hans de Goede
Hi Matthew, Rafael, On 10/27/22 14:09, Rafael J. Wysocki wrote: > On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote: >> >> Hi, >> >> On 10/27/22 11:52, Matthew Garrett wrote: >>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: >>> The *only* behavior which actually is new

Re: [PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

2022-11-04 Thread Andrew Davis
On 11/4/22 11:05 AM, Dawei Li wrote: Racing conflict could be: task A task B list_for_each_entry strcmp(h->name)) list_for_each_entry strcmp(h->name) kzallockzalloc .. . device_create

[PATCH v4] dma-buf: fix racing conflict of dma_heap_add()

2022-11-04 Thread Dawei Li
Racing conflict could be: task A task B list_for_each_entry strcmp(h->name)) list_for_each_entry strcmp(h->name) kzallockzalloc .. . device_create device_create list_add

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-11-04 Thread Jon Hunter
On 04/11/2022 15:48, Krzysztof Kozlowski wrote: On 04/11/2022 11:46, Jon Hunter wrote: On 04/11/2022 15:35, Krzysztof Kozlowski wrote: On 04/11/2022 11:33, Jon Hunter wrote: Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote: > Just filling determine_rate if it's missing with > __clk_mux_determine_rate will possibly pick different parents, and I'm > fairly certain that this have never been tested on most platforms, and > will be completely broken. And I

[RFC] drm/msm: Boost on waits

2022-11-04 Thread Rob Clark
From: Rob Clark Minimize interactive latency by boosting frequency when userspace is waiting on the GPU to finish. Signed-off-by: Rob Clark --- I did contemplate also boosting on dma_fence_wait(), but (a) that would require some extra plumbing thru gpu-sched, (b) that only captures a sub-set

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Maxime Ripard
Hi Mark, On Fri, Nov 04, 2022 at 03:44:53PM +, Mark Brown wrote: > On Fri, Nov 04, 2022 at 02:18:00PM +0100, Maxime Ripard wrote: > > > So, the set_parent hook is effectively unused, possibly because of an > > oversight. However, it could also be an explicit decision by the > > original

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 11:46, Jon Hunter wrote: > > On 04/11/2022 15:35, Krzysztof Kozlowski wrote: >> On 04/11/2022 11:33, Jon Hunter wrote: >>> Hi Thierry, Krzysztof, >>> >>> On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: > From:

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-11-04 Thread Jon Hunter
On 04/11/2022 15:35, Krzysztof Kozlowski wrote: On 04/11/2022 11:33, Jon Hunter wrote: Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: From: Mikko Perttunen On Tegra234 NVDEC firmware is loaded from a

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 02:18:00PM +0100, Maxime Ripard wrote: > So, the set_parent hook is effectively unused, possibly because of an > oversight. However, it could also be an explicit decision by the > original author to avoid any reparenting but through an explicit call to > clk_set_parent().

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 11:33, Jon Hunter wrote: > Hi Thierry, Krzysztof, > > On 24/10/2022 14:15, Thierry Reding wrote: >> On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: >>> From: Mikko Perttunen >>> >>> On Tegra234 NVDEC firmware is loaded from a secure carveout, where it >>> has been

Re: [PATCH v3 1/8] memory: tegra: Add API for retrieving carveout bounds

2022-11-04 Thread Jon Hunter
Hi Thierry, Krzysztof, On 24/10/2022 14:15, Thierry Reding wrote: On Tue, Sep 20, 2022 at 11:11:56AM +0300, Mikko Perttunen wrote: From: Mikko Perttunen On Tegra234 NVDEC firmware is loaded from a secure carveout, where it has been loaded by a bootloader. When booting NVDEC, we need to tell

Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-04 Thread Vinod Koul
On 04-11-22, 16:13, Dmitry Baryshkov wrote: > Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel > configuration (yet). > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git

[PATCH v3 2/2] drm/msm: Hangcheck progress detection

2022-11-04 Thread Rob Clark
From: Rob Clark If the hangcheck timer expires, check if the fw's position in the cmdstream has advanced (changed) since last timer expiration, and allow it up to three additional "extensions" to it's alotted time. The intention is to continue to catch "shader stuck in a loop" type hangs

[PATCH v3 1/2] drm/msm/adreno: Simplify read64/write64 helpers

2022-11-04 Thread Rob Clark
From: Rob Clark The _HI reg is always following the _LO reg, so no need to pass these offsets seprately. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 3 +-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c |

[PATCH v3 0/2] drm/msm: Improved hang detection

2022-11-04 Thread Rob Clark
From: Rob Clark Try to detect when submit jobs are making forward progress and give them a bit more time. Rob Clark (2): drm/msm/adreno: Simplify read64/write64 helpers drm/msm: Hangcheck progress detection drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 3 +-

Re: Try to address the DMA-buf coherency problem

2022-11-04 Thread Christian König
Am 04.11.22 um 15:58 schrieb Rob Clark: On Wed, Nov 2, 2022 at 5:21 AM Christian König wrote: Hi Lucas, Am 02.11.22 um 12:39 schrieb Lucas Stach: Hi Christian, going to reply in more detail when I have some more time, so just some quick thoughts for now. Am Mittwoch, dem 02.11.2022 um

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-04 Thread Maxime Ripard
Hi Paul, On Fri, Nov 04, 2022 at 02:31:20PM +, Paul Cercueil wrote: > Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a > écrit : > > The Ingenic CGU clocks implements a mux with a set_parent hook, but > > doesn't provide a determine_rate implementation. > > > > This is a bit odd, since

Re: Try to address the DMA-buf coherency problem

2022-11-04 Thread Rob Clark
On Wed, Nov 2, 2022 at 5:21 AM Christian König wrote: > > Hi Lucas, > > Am 02.11.22 um 12:39 schrieb Lucas Stach: > > Hi Christian, > > > > going to reply in more detail when I have some more time, so just some > > quick thoughts for now. > > > > Am Mittwoch, dem 02.11.2022 um 12:18 +0100 schrieb

Re: [PATCH v27 6/7] drm/mediatek: add drm ovl_adaptor sub driver for MT8195

2022-11-04 Thread Nícolas F . R . A . Prado
On Fri, Nov 04, 2022 at 10:57:28AM +, Nancy Lin (林欣螢) wrote: > Dear Nicolas, > > Thanks for the review. > > On Thu, 2022-11-03 at 17:28 -0400, Nícolas F. R. A. Prado wrote: > > On Thu, Nov 03, 2022 at 11:26:09AM +0800, Nancy.Lin wrote: > > > Add drm ovl_adaptor sub driver. Bring up

Re: Try to address the DMA-buf coherency problem

2022-11-04 Thread Christian König
Am 04.11.22 um 14:38 schrieb Nicolas Dufresne: Le vendredi 04 novembre 2022 à 10:03 +0100, Christian König a écrit : Am 03.11.22 um 23:16 schrieb Nicolas Dufresne: [SNIP] Was there APIs suggested to actually make it manageable by userland to allocate from the GPU? Yes, this what Linux Device

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-04 Thread Deepak R Varma
On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > I took a look, but it's pretty complex. You could take the code and > > reorganize it so that it is more readable, and then take the definition of > > the

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2022-11-04 Thread Paul Cercueil
Hi Maxime, Le ven. 4 nov. 2022 à 14:18:13 +0100, Maxime Ripard a écrit : The Ingenic CGU clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a

[PATCH v2 65/65] clk: Warn if we register a mux without determine_rate

2022-11-04 Thread Maxime Ripard
The determine_rate hook allows to select the proper parent and its rate for a given clock configuration. On another hand, set_parent is there to change the parent of a mux. Some clocks provide a set_parent hook but don't implement determine_rate. In such a case, set_parent is pretty much useless

[PATCH v2 64/65] ASoC: tlv320aic32x4: div: Switch to determine_rate

2022-11-04 Thread Maxime Ripard
The tlv320aic32x4 divider clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely candidate to trigger that parent change is

[PATCH v2 63/65] ASoC: tlv320aic32x4: pll: Switch to determine_rate

2022-11-04 Thread Maxime Ripard
The tlv320aic32x4 PLL clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely candidate to trigger that parent change is a

Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the HDMI display nodes and link it to DSI. Also enable missing dispcc > nodes > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > + { > +

[PATCH v3 1/7] vfio/ccw: create a parent struct

2022-11-04 Thread Eric Farman
Move the stuff associated with the mdev parent (and thus the subchannel struct) into its own struct, and leave the rest in the existing private structure. The subchannel will point to the parent, and the parent will point to the private, for the areas where one or both are needed. Further

[PATCH v3 7/7] vfio: Remove vfio_free_device

2022-11-04 Thread Eric Farman
With the "mess" sorted out, we should be able to inline the vfio_free_device call introduced by commit cb9ff3f3b84c ("vfio: Add helpers for unifying vfio_device life cycle") and remove them from driver release callbacks. Signed-off-by: Eric Farman Reviewed-by: Jason Gunthorpe Reviewed-by: Kevin

[PATCH v3 6/7] vfio/ccw: replace vfio_init_device with _alloc_

2022-11-04 Thread Eric Farman
Now that we have a reasonable separation of structs that follow the subchannel and mdev lifecycles, there's no reason we can't call the official vfio_alloc_device routine for our private data, and behave like everyone else. Signed-off-by: Eric Farman Reviewed-by: Kevin Tian Acked-by: Alex

[PATCH v3 2/7] vfio/ccw: remove private->sch

2022-11-04 Thread Eric Farman
These places all rely on the ability to jump from a private struct back to the subchannel struct. Rather than keeping a copy in our back pocket, let's use the relationship provided by the vfio_device embedded within the private. Signed-off-by: Eric Farman Reviewed-by: Matthew Rosato ---

[PATCH v3 5/7] vfio/ccw: remove release completion

2022-11-04 Thread Eric Farman
There's enough separation between the parent and private structs now, that it is fine to remove the release completion hack. Signed-off-by: Eric Farman Reviewed-by: Kevin Tian Reviewed-by: Matthew Rosato --- drivers/s390/cio/vfio_ccw_ops.c | 14 +-

[PATCH v3 4/7] vfio/ccw: move private to mdev lifecycle

2022-11-04 Thread Eric Farman
Now that the mdev parent data is split out into its own struct, it is safe to move the remaining private data to follow the mdev probe/remove lifecycle. The mdev parent data will remain where it is, and follow the subchannel and the css driver interfaces. Signed-off-by: Eric Farman Reviewed-by:

[PATCH v3 3/7] vfio/ccw: move private initialization to callback

2022-11-04 Thread Eric Farman
There's already a device initialization callback that is used to initialize the release completion workaround that was introduced by commit ebb72b765fb49 ("vfio/ccw: Use the new device life cycle helpers"). Move the other elements of the vfio_ccw_private struct that require distinct

[PATCH v3 0/7] vfio-ccw parent rework

2022-11-04 Thread Eric Farman
Hi Alex, Here's the (last?) update to the vfio-ccw lifecycle changes that I've sent recently, and were previously discussed at various points [1][2]. Patches 1-5 rework the behavior of the vfio-ccw driver's private struct. In summary, the mdev pieces are split out of vfio_ccw_private and into a

Re: [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > From: Vinod Koul > > Add the LT9611uxc DSI-HDMI bridge and supplies > > Signed-off-by: Vinod Koul > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 + > 1 file changed, 61

Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:13, Dmitry Baryshkov wrote: From: Vinod Koul Add the HDMI display nodes and link it to DSI. Also enable missing dispcc nodes Signed-off-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 45 + 1 file

Re: [PATCH v1 4/5] arm64: dts: qcom: sm8450-hdk: Add LT9611uxc HDMI bridge

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:13, Dmitry Baryshkov wrote: From: Vinod Koul Add the LT9611uxc DSI-HDMI bridge and supplies Signed-off-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 61 + 1 file changed, 61 insertions(+) diff

Re: [PATCH v1 2/5] arm64: dts: qcom: sm8450: add display hardware devices

2022-11-04 Thread Krzysztof Kozlowski
On 04/11/2022 09:13, Dmitry Baryshkov wrote: > Add devices tree nodes describing display hardware on SM8450: > - Display Clock Controller > - MDSS > - MDP > - two DSI controllers and DSI PHYs > > This does not provide support for DP controllers present on SM8450. > > Signed-off-by: Dmitry

Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:13, Dmitry Baryshkov wrote: Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel configuration (yet). Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH v1 2/5] arm64: dts: qcom: sm8450: add display hardware devices

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:13, Dmitry Baryshkov wrote: Add devices tree nodes describing display hardware on SM8450: - Display Clock Controller - MDSS - MDP - two DSI controllers and DSI PHYs This does not provide support for DP controllers present on SM8450. Signed-off-by: Dmitry Baryshkov ---

[PATCH v3 04/12] drm/mediatek: extract common functions from the mtk hdmi driver

2022-11-04 Thread Guillaume Ranquet
Create a common "framework" that can be used to add support for different hdmi IPs within the mediatek range of products. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c| 620 ++---

[PATCH v3 11/12] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195

2022-11-04 Thread Guillaume Ranquet
Add dt-binding documentation of dpi for MediaTek MT8195 SoC. Acked-by: Krzysztof Kozlowski Signed-off-by: Guillaume Ranquet --- Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 10/12] phy: mediatek: add support for phy-mtk-hdmi-mt8195

2022-11-04 Thread Guillaume Ranquet
Add basic support for the mediatek hdmi phy on MT8195 SoC Signed-off-by: Guillaume Ranquet --- drivers/phy/mediatek/Makefile | 1 + drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 543 + drivers/phy/mediatek/phy-mtk-hdmi-mt8195.h | 109 ++

[PATCH v3 08/12] drm/mediatek: hdmi: v2: add audio support

2022-11-04 Thread Guillaume Ranquet
Add HDMI audio support for v2 Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 + drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 2 +- drivers/gpu/drm/mediatek/mtk_hdmi_v2.c | 213 + drivers/gpu/drm/mediatek/mtk_hdmi_v2.h

[PATCH v3 12/12] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver

2022-11-04 Thread Guillaume Ranquet
Add the DPI1 hdmi path support in mtk dpi driver Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_dpi.c | 143 ++-- drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 5 ++ 2 files changed, 141 insertions(+), 7 deletions(-) diff --git

[PATCH v3 09/12] phy: phy-mtk-hdmi: Add generic phy configure callback

2022-11-04 Thread Guillaume Ranquet
Some phys, such as mt8195, needs to have a configure callback defined. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Guillaume Ranquet --- drivers/phy/mediatek/phy-mtk-hdmi.c | 12 drivers/phy/mediatek/phy-mtk-hdmi.h | 1 + 2 files changed, 13 insertions(+) diff --git

[PATCH v3 06/12] drm/mediatek: hdmi: add frame_colorimetry flag

2022-11-04 Thread Guillaume Ranquet
Add a flag to indicate support for frame colorimetry. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++ drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c

[PATCH v3 07/12] drm/mediatek: hdmi: add v2 support

2022-11-04 Thread Guillaume Ranquet
Adds hdmi and hdmi-ddc support for v2 IP. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/Makefile |2 + drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 14 + drivers/gpu/drm/mediatek/mtk_hdmi_common.h |1 + drivers/gpu/drm/mediatek/mtk_hdmi_ddc_v2.c | 367

[PATCH v3 05/12] drm/mediatek: hdmi: make the cec dev optional

2022-11-04 Thread Guillaume Ranquet
Make cec device optional in order to support newer versions of the hdmi IP which doesn't require it Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi.c| 8 +++-- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 54 --

[PATCH v3 03/12] drm/mediatek: hdmi: use a regmap instead of iomem

2022-11-04 Thread Guillaume Ranquet
To prepare support for newer chips that need to share their address range with a dedicated ddc driver, use a regmap. Signed-off-by: Guillaume Ranquet --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 43 +++-- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git

[PATCH v3 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2022-11-04 Thread Guillaume Ranquet
Add mt8195 SoC bindings for hdmi and hdmi-ddc On mt8195 the ddc i2c controller is part of the hdmi IP block and thus has no specific register range, power domain or interrupt, making it simpler than its the legacy "mediatek,hdmi-ddc" binding. Signed-off-by: Guillaume Ranquet ---

[PATCH v3 01/12] dt-bindings: phy: mediatek: hdmi-phy: Add mt8195 compatible

2022-11-04 Thread Guillaume Ranquet
Add a compatible for the HDMI PHY on MT8195 Acked-by: Krzysztof Kozlowski Signed-off-by: Guillaume Ranquet --- Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml

[PATCH v3 00/12] Add MT8195 HDMI support

2022-11-04 Thread Guillaume Ranquet
and the dpi/drm_drv adjustments to support hdmi. Based on next-20221104 test branch with dts and various "in flight" patches available here: https://gitlab.com/granquet/linux/-/tree/granquet/linux-next_HDMI I haven't updated the vdosys/mmsys/ethdr and mutex patches in a while in that test

Re: [PATCH v1 1/5] arm64: dts: qcom: sm8450: add RPMH_REGULATOR_LEVEL_LOW_SVS_D1

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:13, Dmitry Baryshkov wrote: Add another power saving state used on SM8450. Unfortunately adding it in proper place causes renumbering of all the opp states in sm8450.dtsi Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 8/8] drm/msm: mdss: add support for SM8450

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:03, Dmitry Baryshkov wrote: Add support for the MDSS block on SM8450 platform. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad drivers/gpu/drm/msm/msm_mdss.c | 5 + 1 file changed, 5

Re: [PATCH v3 7/8] drm/msm/dpu: add support for SM8450

2022-11-04 Thread Konrad Dybcio
On 04/11/2022 14:03, Dmitry Baryshkov wrote: Add definitions for the display hardware used on Qualcomm SM8450 platform. Tested-by: Vinod Koul Reviewed-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

  1   2   3   >