[PULL] drm-misc-fixes

2023-01-04 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2023-01-05: Several fixes to fix the error path of dma_buf_export, add a missing structure declaration resulting in a compiler warning, fix the GEM handle refcounting in panfrost, fix a corrupted image with AFBC on meson,

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-04 Thread Maxime Ripard
On Wed, Jan 04, 2023 at 10:17:54PM +0100, Daniel Vetter wrote: > The documentation for struct drm_minor already states this, but that's > not always that easy to find. > > Also due to historical reasons we still have the minor-centric (like > drm_debugfs_create_files), but since this is now

Re: [PATCH v6 05/45] drm/amd: Add a new helper for loading/validating microcode

2023-01-04 Thread Mario Limonciello
On 1/4/23 23:29, Lazar, Lijo wrote: On 1/5/2023 10:53 AM, Mario Limonciello wrote: On 1/4/23 23:07, Lazar, Lijo wrote: On 1/5/2023 9:12 AM, Mario Limonciello wrote: All microcode runs a basic validation after it's been loaded. Each IP block as part of init will run both. Introduce a

Re: [PATCH v6 05/45] drm/amd: Add a new helper for loading/validating microcode

2023-01-04 Thread Lazar, Lijo
On 1/5/2023 10:53 AM, Mario Limonciello wrote: On 1/4/23 23:07, Lazar, Lijo wrote: On 1/5/2023 9:12 AM, Mario Limonciello wrote: All microcode runs a basic validation after it's been loaded. Each IP block as part of init will run both. Introduce a wrapper for request_firmware and

[PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-04 Thread Yi Xie
Some libraries including Mesa and virglrenderer require a render node to fully function. By adding a render node to vkms those libraries will work properly, supporting use cases like running crosvm with virgl GPU support via llvmpipe on a headless virtual machine. Signed-off-by: Yi Xie ---

Re: [PATCH v6 05/45] drm/amd: Add a new helper for loading/validating microcode

2023-01-04 Thread Mario Limonciello
On 1/4/23 23:07, Lazar, Lijo wrote: On 1/5/2023 9:12 AM, Mario Limonciello wrote: All microcode runs a basic validation after it's been loaded. Each IP block as part of init will run both. Introduce a wrapper for request_firmware and amdgpu_ucode_validate. This wrapper will also remap any

Re: [PATCH v6 05/45] drm/amd: Add a new helper for loading/validating microcode

2023-01-04 Thread Lazar, Lijo
On 1/5/2023 9:12 AM, Mario Limonciello wrote: All microcode runs a basic validation after it's been loaded. Each IP block as part of init will run both. Introduce a wrapper for request_firmware and amdgpu_ucode_validate. This wrapper will also remap any error codes from request_firmware to

Re: [PATCH] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dan Carpenter
Hi Dmitry, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-another-fix-for-the-headless-Adreno-GPU/20221231-103022 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link:

Re: [PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Abhinav Kumar
On 1/4/2023 5:47 PM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU working in the headless mode (e.g. iMX platforms). Unable to handle kernel NULL pointer dereference at virtual address when read [] *pgd=74936831,

Re: [PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Rob Clark
On Wed, Jan 4, 2023 at 5:47 PM Dmitry Baryshkov wrote: > > Fix another oops reproducible when rebooting the board with the Adreno > GPU working in the headless mode (e.g. iMX platforms). > > Unable to handle kernel NULL pointer dereference at virtual address > when read > []

linux-next: build warnings after merge of the drm tree

2023-01-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced these warnings: include/drm/drm_debugfs.h:93: warning: Function parameter or member 'name' not described in 'drm_debugfs_info' include/drm/drm_debugfs.h:93: warning: Function parameter or member 'show' not

[PATCH v6 43/45] drm/amd: Use `amdgpu_ucode_release` helper for powerplay

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_release` helper is replacing all calls to release_firmware. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release argument change --- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 3 +-- 1 file changed, 1 insertion(+),

[PATCH v6 42/45] drm/amd: Use `amdgpu_ucode_*` helpers for DMCU

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello ---

[PATCH v6 45/45] drm/amd: make amdgpu_ucode_validate static

2023-01-04 Thread Mario Limonciello
No consumers outside of amdgpu_ucode.c use amdgpu_ucode_validate anymore, so make the function static. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 - 2 files changed, 1

[PATCH v6 41/45] drm/amd: Use `amdgpu_ucode_*` helpers for GPU info bin

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 39/45] drm/amd: Use `amdgpu_ucode_*` helpers for VCE

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 40/45] drm/amd: Use `amdgpu_ucode_*` helpers for CGS

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 37/45] drm/amd: Use `amdgpu_ucode_*` helpers for SDMA on CIK

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 36/45] drm/amd: Use `amdgpu_ucode_*` helpers for SDMA3.0

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 44/45] drm/amd: Use `amdgpu_ucode_release` helper for si

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_release` helper is replacing all calls to release_firmware. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release argument change --- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 11 ++- 1 file changed, 2

[PATCH v6 38/45] drm/amd: Use `amdgpu_ucode_*` helpers for UVD

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 34/45] drm/amd: Use `amdgpu_ucode_*` helpers for GMC8

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 27/45] drm/amd: Load SMU microcode during early_init

2023-01-04 Thread Mario Limonciello
This will ensure that the microcode is available before the firmware framebuffer has been destroyed. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

[PATCH v6 33/45] drm/amd: Use `amdgpu_ucode_*` helpers for GMC7

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 31/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX8

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 35/45] drm/amd: Use `amdgpu_ucode_*` helpers for SDMA2.4

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 32/45] drm/amd: Use `amdgpu_ucode_*` helpers for GMC6

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 26/45] drm/amd: Use `amdgpu_ucode_*` helpers for SMU

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 30/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX7

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 28/45] drm/amd: Optimize SRIOV switch/case for PSP microcode load

2023-01-04 Thread Mario Limonciello
Now that IP version decoding is used, a number of case statements can be combined. Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH v6 29/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX6

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 24/45] drm/amd/display: Load DMUB microcode during early_init

2023-01-04 Thread Mario Limonciello
If DMUB is required for an ASIC, ensure that the microcode is available and validates during early_init. Any failures will cause the driver to fail to probe before the firmware framebuffer has been removed. Reviewed-by: Alex Deucher Reviewed-by: Harry Wentland Signed-off-by: Mario Limonciello

[PATCH v6 25/45] drm/amd: Use `amdgpu_ucode_release` helper for DMUB

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release argument change --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH v6 22/45] drm/amd: Load PSP microcode during early_init

2023-01-04 Thread Mario Limonciello
Simplifies the code so that all PSP versions will get the firmware name from `amdgpu_ucode_ip_version_decode` and then use this filename to load microcode as part of the early_init process. Any failures will cause the driver to fail to probe before the firmware framebuffer has been removed.

[PATCH v6 23/45] drm/amd: Use `amdgpu_ucode_*` helpers for PSP

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unloading. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 20/45] drm/amd: Parse both v1 and v2 TA microcode headers using same function

2023-01-04 Thread Mario Limonciello
Several IP versions duplicate code and can't use the common helpers. Move this code into a single function so that the helpers can be used. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Rebase on earlier patches --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 120

[PATCH v6 12/45] drm/amd: Use `amdgpu_ucode_*` helpers for MES

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper provides symmetry for releasing firmware. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 21/45] drm/amd: Avoid BUG() for case of SRIOV missing IP version

2023-01-04 Thread Mario Limonciello
No need to crash the kernel. AMDGPU will now fail to probe. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH v6 19/45] drm/amd: Load GFX11 microcode during early_init

2023-01-04 Thread Mario Limonciello
If GFX11 microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for GFX11 microcode into the early_init phase so that if it's not available, driver init will fail. Reviewed-by: Alex Deucher

[PATCH v6 18/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX11

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper will provide symmetery on unload. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 17/45] drm/amd: Load GFX10 microcode during early_init

2023-01-04 Thread Mario Limonciello
Simplifies the code so that GFX10 will get the firmware name from `amdgpu_ucode_ip_version_decode` and then use this filename to load microcode as part of the early_init process. Any failures will cause the driver to fail to probe before the firmware framebuffer has been removed. Reviewed-by:

[PATCH v6 16/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX10

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry on unload. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release

[PATCH v6 15/45] drm/amd: Load GFX9 microcode during early_init

2023-01-04 Thread Mario Limonciello
If GFX9 microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 58 +-- 1 file

[PATCH v6 14/45] drm/amd: Use `amdgpu_ucode_*` helpers for GFX9

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper will provide symmetry on unload. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for

[PATCH v6 11/45] drm/amd: Load MES microcode during early_init

2023-01-04 Thread Mario Limonciello
Add an early_init phase to MES for fetching and validating microcode from the filesystem. If MES microcode is required but not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request for MES microcode into the early_init

[PATCH v6 13/45] drm/amd: Remove superfluous assignment for `adev->mes.adev`

2023-01-04 Thread Mario Limonciello
`amdgpu_mes_init` already sets `adev->mes.adev`, so there is no need to also set it in the IP specific versions. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 1 - drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 1 - 2 files changed, 2

[PATCH v6 10/45] drm/amd: Load VCN microcode during early_init

2023-01-04 Thread Mario Limonciello
Simplifies the code so that all VCN versions will get the firmware name from `amdgpu_ucode_ip_version_decode` and then use this filename to load microcode as part of the early_init process. Signed-off-by: Mario Limonciello --- v5->v6: * Fix whitespace problem in firmware file names * Adjust

[PATCH v6 05/45] drm/amd: Add a new helper for loading/validating microcode

2023-01-04 Thread Mario Limonciello
All microcode runs a basic validation after it's been loaded. Each IP block as part of init will run both. Introduce a wrapper for request_firmware and amdgpu_ucode_validate. This wrapper will also remap any error codes from request_firmware to -ENODEV. This is so that early_init will fail if

[PATCH v6 07/45] drm/amd: Convert SDMA to use `amdgpu_ucode_ip_version_decode`

2023-01-04 Thread Mario Limonciello
Simplifies the code so that all SDMA versions will get the firmware name from `amdgpu_ucode_ip_version_decode`. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 12 -- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 4 +-

[PATCH v6 06/45] drm/amd: Use `amdgpu_ucode_request` helper for SDMA

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release argument change --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c

[PATCH v6 08/45] drm/amd: Make SDMA firmware load failures less noisy.

2023-01-04 Thread Mario Limonciello
When firmware is missing we get failures at every step. ``` [3.855086] amdgpu :04:00.0: Direct firmware load for amdgpu/green_sardine_sdma.bin failed with error -2 [3.855087] [drm:amdgpu_sdma_init_microcode [amdgpu]] *ERROR* SDMA: Failed to init firmware

[PATCH v6 09/45] drm/amd: Use `amdgpu_ucode_*` helpers for VCN

2023-01-04 Thread Mario Limonciello
The `amdgpu_ucode_request` helper will ensure that the return code for missing firmware is -ENODEV so that early_init can fail. The `amdgpu_ucode_release` helper is for symmetry. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Adjust for amdgpu_ucode_release argument

[PATCH v6 04/45] drm/amd: Convert SMUv13 microcode to use `amdgpu_ucode_ip_version_decode`

2023-01-04 Thread Mario Limonciello
The special case for the one dGPU has been moved into `amdgpu_ucode_ip_version_decode`, so simplify this code. Signed-off-by: Mario Limonciello Acked-by: Christian König Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 12 ++-- 1 file changed, 2

[PATCH v6 03/45] drm/amd: Convert SMUv11 microcode to use `amdgpu_ucode_ip_version_decode`

2023-01-04 Thread Mario Limonciello
Remove the special casing from SMU v11 code. No intended functional changes. Signed-off-by: Mario Limonciello Acked-by: Christian König Reviewed-by: Alex Deucher --- .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c| 35 ++- 1 file changed, 3 insertions(+), 32 deletions(-) diff

[PATCH v6 02/45] drm/amd: Add a legacy mapping to "amdgpu_ucode_ip_version_decode"

2023-01-04 Thread Mario Limonciello
This will allow other parts of the driver that currently special case firmware file names to before IP version style naming to just have a single call to `amdgpu_ucode_ip_version_decode`. Signed-off-by: Mario Limonciello Acked-by: Christian König Reviewed-by: Alex Deucher ---

[PATCH v6 00/45] Recover from failure to probe GPU

2023-01-04 Thread Mario Limonciello
One of the first thing that KMS drivers do during initialization is destroy the system firmware framebuffer by means of `drm_aperture_remove_conflicting_pci_framebuffers` This means that if for any reason the GPU failed to probe the user will be stuck with at best a screen frozen at the last

[PATCH v6 01/45] drm/amd: Delay removal of the firmware framebuffer

2023-01-04 Thread Mario Limonciello
Removing the firmware framebuffer from the driver means that even if the driver doesn't support the IP blocks in a GPU it will no longer be functional after the driver fails to initialize. This change will ensure that unsupported IP blocks at least cause the driver to work with the EFI

linux-next: build warning after merge of the drm tree

2023-01-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: include/drm/drm_connector.h:203: warning: Enum value 'DRM_MODE_TV_MODE_MAX' not described in enum 'drm_connector_tv_mode' Introduced by commit 7d63cd8526f1 ("drm/connector: Add TV standard

[pull] amdgpu, amdkfd drm-fixes-6.2

2023-01-04 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit c8de526215fdab9f2dd0d9675582cf9f1391a919: Merge tag 'drm-misc-next-fixes-2023-01-03' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2023-01-03 21:02:57 +0100) are available in the Git repository at:

linux-next: build warnings after merge of the drm-intel tree

2023-01-04 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write' drivers/gpu/drm/i915/display/intel_dsb.c:201: warning:

linux-next: build warning after merge of the drm tree

2023-01-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: drivers/gpu/drm/drm_connector.c:1849: warning: bad line: Introduced by commit 7d63cd8526f1 ("drm/connector: Add TV standard property") -- Cheers, Stephen Rothwell pgpct7zIVq0YG.pgp Description:

linux-next: build warning after merge of the drm tree

2023-01-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: drivers/gpu/drm/drm_atomic_state_helper.c:560: warning: Cannot understand * @drm_atomic_helper_connector_tv_check: Validate an analog TV connector state on line 560 - I thought it was a doc line

Re: [PATCH 2/6] dt-bindings: display/msm: document the display hardware for SM8550

2023-01-04 Thread Rob Herring
On Wed, 04 Jan 2023 10:08:44 +0100, Neil Armstrong wrote: > Document the MDSS and DPU blocks found on the Qualcomm SM8550 > platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + > .../bindings/display/msm/qcom,sm8550-mdss.yaml

Re: [RFC PATCH v3 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2:

Re: [RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is

Re: [RFC PATCH v3 2/3] drm: Adjust atomic checks for solid fill color

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when

Re: [RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Dmitry Baryshkov
On 05/01/2023 01:40, Jessica Zhang wrote: Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is

[PATCH v3] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dmitry Baryshkov
Fix another oops reproducible when rebooting the board with the Adreno GPU working in the headless mode (e.g. iMX platforms). Unable to handle kernel NULL pointer dereference at virtual address when read [] *pgd=74936831, *pte=, *ppte= Internal error: Oops: 17

Re: [PATCH V7 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-04 Thread kernel test robot
-Morgan/drm-of-Add-drm_of_get_dsi_bus-helper-function/20230104-030847 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next patch link: https://lore.kernel.org/r/20230103190707.104595-2-macroalpha82%40gmail.com patch subject: [PATCH V7 1/4] drm: of: Add

linux-next: duplicate patches in the drm tree

2023-01-04 Thread Stephen Rothwell
Hi all, The following commits also exist in other trees in linux-next as different commits (but the same patch): 9f1ecfc5dcb4 ("drm/scheduler: Fix lockup in drm_sched_entity_kill()") 4333472f8d7b ("drm/imx: ipuv3-plane: Fix overlay plane width") They are also in the drm-misc-fixes tree. --

Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Dragos-Marian Panait
On 04.01.2023 16:48, Greg KH wrote: On Wed, Jan 04, 2023 at 09:35:03AM -0500, Alex Deucher wrote: On Wed, Jan 4, 2023 at 8:23 AM Christian König wrote: Am 04.01.23 um 13:41 schrieb Greg KH: On Tue, Jan 03, 2023 at 08:43:08PM +0200, Dragos-Marian Panait wrote: From: Jiasheng Jiang [

[PATCH 5.4 0/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Dragos-Marian Panait
The following commit is needed to fix CVE-2022-3108: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abfaf0eee97925905e742aa3b0b72e04a918fa9e Jiasheng Jiang (1): drm/amdkfd: Check for null pointer after calling kmemdup drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3

[PATCH 5.4 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Dragos-Marian Panait
From: Jiasheng Jiang [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] As the possible failure of the allocation, kmemdup() may return NULL pointer. Therefore, it should be better to check the 'props2' in order to prevent the dereference of NULL pointer. Fixes: 3a87177eb141

[PATCH 5.10 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Dragos-Marian Panait
From: Jiasheng Jiang [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] As the possible failure of the allocation, kmemdup() may return NULL pointer. Therefore, it should be better to check the 'props2' in order to prevent the dereference of NULL pointer. Fixes: 3a87177eb141

[PATCH 5.10 0/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-04 Thread Dragos-Marian Panait
The following commit is needed to fix CVE-2022-3108: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abfaf0eee97925905e742aa3b0b72e04a918fa9e Jiasheng Jiang (1): drm/amdkfd: Check for null pointer after calling kmemdup drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3

[RFC PATCH v3 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-04 Thread Jessica Zhang
Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2: - Fixed dropped 'const' warning - Dropped

[RFC PATCH v3 1/3] drm: Introduce solid fill property for drm plane

2023-01-04 Thread Jessica Zhang
Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is formatted as such: struct drm_solid_fill {

[RFC PATCH v3 2/3] drm: Adjust atomic checks for solid fill color

2023-01-04 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when solid fill is enabled. Changes in V2: -

[RFC PATCH v3 0/3] Support for Solid Fill Planes

2023-01-04 Thread Jessica Zhang
Introduce and add support for a solid_fill property. When the solid_fill property is set, and the framebuffer is set to NULL, memory fetch will be disabled. In addition, loosen the NULL FB checks within the atomic commit callstack to allow a NULL FB when the solid_fill property is set and add FB

Re: [PATCH v3 5/7] drm/i915/pxp: Trigger the global teardown for before suspending

2023-01-04 Thread Juston Li
On Wed, 2022-12-21 at 15:06 -0800, Alan Previn wrote: > A driver bug was recently discovered where the security firmware was > receiving internal HW signals indicating that session key expirations > had occurred. Architecturally, the firmware was expecting a response > from the GuC to acknowledge

Re: [PATCH v3 4/7] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2023-01-04 Thread Juston Li
On Wed, 2022-12-21 at 15:06 -0800, Alan Previn wrote: > A gap was recently discovered where if an application did not > invalidate all of the stream keys (intentionally or not), and the > driver did a full PXP global teardown on the GT subsystem, we > find that future session creation would fail

Re: [PATCH V7 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-04 Thread kernel test robot
-Morgan/drm-of-Add-drm_of_get_dsi_bus-helper-function/20230104-030847 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next patch link: https://lore.kernel.org/r/20230103190707.104595-2-macroalpha82%40gmail.com patch subject: [PATCH V7 1/4] drm: of: Add

Re: [PATCH] drm/amd/display: fix array-bounds errors in dc_stream_remove_writeback()

2023-01-04 Thread Hamza Mahfooz
On 12/25/22 10:10, wenyang.li...@foxmail.com wrote: From: Wen Yang The following errors occurred when using gcc 7.5.0-3ubuntu1~18.04: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function  ‘dc_stream_remove_writeback’:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2023-01-04 Thread Andrzej Hajda
On 04.01.2023 18:41, Matt Roper wrote: On Wed, Jan 04, 2023 at 10:08:29AM +, Tvrtko Ursulin wrote: On 03/01/2023 19:57, Matt Roper wrote: On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote: On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for

linux-next: duplicate patches in the drm-intel tree

2023-01-04 Thread Stephen Rothwell
Hi all, The following commits already exist in Linus Torvald's tree as different commits (but the same patches): 50490ce05b7a ("drm/i915: Remove __maybe_unused from mtl_info") f087cfe6fcff ("drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence") a561933c5717 ("drm/i915/dsi: fix

[PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-04 Thread Daniel Vetter
The documentation for struct drm_minor already states this, but that's not always that easy to find. Also due to historical reasons we still have the minor-centric (like drm_debugfs_create_files), but since this is now getting fixed we can put a few more pointers in place as to how this should be

Re: [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Dmitry Baryshkov
On 04/01/2023 20:15, Rob Clark wrote: On Wed, Jan 4, 2023 at 10:09 AM Abhinav Kumar wrote: On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU wokring in the headless mode (e.g. iMX platforms). wokring ---> working

[PATCH 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

2023-01-04 Thread Nathan Chancellor
When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it warns: clang-16: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument] Similar to commit 84edc2eff827 ("selftest/fpu: avoid clang warning"), just add this flag to GCC builds.

[PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-04 Thread Nathan Chancellor
Hi all, Clang can emit a few different warnings when it encounters a flag that it recognizes but does not support internally. These warnings are elevated to errors within {as,cc}-option via -Werror to catch unsupported flags that should not be added to KBUILD_{A,C}FLAGS; see commit c3f0d0bc5b01

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-04 Thread Matt Roper
On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: > > On 23/12/2022 18:28, Lucas De Marchi wrote: > > On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: > > > > > > On 22/12/2022 15:55, Lucas De Marchi wrote: > > > > On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-04 Thread Rayyan Ansari
Hello, I am not a maintainer, but I thought I might give a few comments. On 03/01/2023 14:22, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed

Re: [PATCH] fbdev: omapfb: avoid stack overflow warning

2023-01-04 Thread Helge Deller
On 12/15/22 18:02, Arnd Bergmann wrote: From: Arnd Bergmann The dsi_irq_stats structure is a little too big to fit on the stack of a 32-bit task, depending on the specific gcc options: fbdev/omap2/omapfb/dss/dsi.c: In function 'dsi_dump_dsidev_irqs': fbdev/omap2/omapfb/dss/dsi.c:1621:1:

Re: [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Rob Clark
On Wed, Jan 4, 2023 at 10:09 AM Abhinav Kumar wrote: > > > > On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: > > Fix another oops reproducible when rebooting the board with the Adreno > > GPU wokring in the headless mode (e.g. iMX platforms). > wokring ---> working > > > > Unable to handle kernel

Re: [PATCH v2] drm/msm: another fix for the headless Adreno GPU

2023-01-04 Thread Abhinav Kumar
On 1/3/2023 7:51 AM, Dmitry Baryshkov wrote: Fix another oops reproducible when rebooting the board with the Adreno GPU wokring in the headless mode (e.g. iMX platforms). wokring ---> working Unable to handle kernel NULL pointer dereference at virtual address when read []

Re: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-04 Thread Rodrigo Vivi
On Wed, Jan 04, 2023 at 06:51:37PM +0100, Julia Lawall wrote: > > > On Tue, 3 Jan 2023, Deepak R Varma wrote: > > > On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > > > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > > > On Tue, Dec 27, 2022 at 12:13:56PM

Re: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-04 Thread Julia Lawall
On Tue, 3 Jan 2023, Deepak R Varma wrote: > On Wed, Dec 28, 2022 at 06:18:12AM -0500, Rodrigo Vivi wrote: > > On Tue, Dec 27, 2022 at 11:36:13PM +0530, Deepak R Varma wrote: > > > On Tue, Dec 27, 2022 at 12:13:56PM -0500, Rodrigo Vivi wrote: > > > > On Tue, Dec 27, 2022 at 01:30:53PM +0530,

Re: [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-04 Thread Dmitry Baryshkov
On Wed, 4 Jan 2023 at 12:08, Neil Armstrong wrote: > > On 04/01/2023 10:45, Dmitry Baryshkov wrote: > > On 04/01/2023 11:08, Neil Armstrong wrote: > >> Add definitions for the display hardware used on Qualcomm SM8550 > >> platform. > >> > >> Signed-off-by: Neil Armstrong > >> --- > >>

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2023-01-04 Thread Matt Roper
On Wed, Jan 04, 2023 at 10:08:29AM +, Tvrtko Ursulin wrote: > > On 03/01/2023 19:57, Matt Roper wrote: > > On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote: > > > On 19.12.2022 11:13, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > As the logic for selecting

Re: [PATCH v5 45/45] drm/amd: make amdgpu_ucode_validate static

2023-01-04 Thread Alex Deucher
Other than the patches I commented directly on, this series is: Reviewed-by: Alex Deucher On Wed, Jan 4, 2023 at 11:45 AM Mario Limonciello wrote: > > No consumers outside of amdgpu_ucode.c use amdgpu_ucode_validate > anymore, so make the function static. > > Signed-off-by: Mario Limonciello >

Re: [PATCH 5/6] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-04 Thread Dmitry Baryshkov
On Wed, 4 Jan 2023 at 12:11, Neil Armstrong wrote: > > On 04/01/2023 10:53, Dmitry Baryshkov wrote: > > On 04/01/2023 11:08, Neil Armstrong wrote: > >> SM8550 use a 4nm DSI PHYs, which share register definitions > >> with 7nm DSI PHYs. Rather than duplicating the driver, handle > >> 4nm variant

  1   2   3   >