[PATCH v2] ASoC: dt-bindings: maxim,max98371: DT schema improvement

2023-03-31 Thread André Morishita
Improve Maxim Integrated MAX98371 audio codec bindings DT schema conversion Signed-off-by: André Morishita --- Changes in v2 - Generic node names - codec (Krzysztof) - Drop label max98371 (Krzysztof) - Add sound-dai-cells in example (Krzysztof) .../devicetree/bindings/sound/max98371.txt|

Re: [Intel-gfx] [PATCH v8 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-31 Thread kernel test robot
Hi Mark, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next-fixes] [also build test ERROR on linus/master v6.3-rc4] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next drm/drm-next next-20230331] [If your patch is applied to the wrong

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-03-31 Thread Dixit, Ashutosh
On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc > *slpc, u32 val) > val > slpc->max_freq_softlimit) > return -EINVAL; > > + /* Ignore efficient freq if lower min

Re: [Intel-gfx] [PATCH v2] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

2023-03-31 Thread Dixit, Ashutosh
On Fri, 31 Mar 2023 03:23:33 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > > @@ -385,8 +395,22 @@ static int > > hwm_power_max_write(struct hwm_drvdata *ddat, long val) > > { > > struct i915_hwmon *hwmon = ddat->hwmon; > > + intel_wakeref_t wakeref; > > u32 nval; > > + if (val ==

[PATCH v3] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

2023-03-31 Thread Ashutosh Dixit
On ATSM the PL1 limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when the PL1 limit is disabled. For example at power up, the disabled ATSM PL1 limit

[PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-03-31 Thread Vinay Belgaumkar
SLPC enables use of efficient freq at init by default. It is possible for GuC to request frequencies that are higher than the 'software' max if user has set it lower than the efficient level. Scenarios/tests that require strict fixing of freq below the efficient level will need to disable it

[PATCH AUTOSEL 5.4 4/6] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

2023-03-31 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 03aecb1acbcd7a660f97d645ca6c09d9de27ff9d ] Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was

[PATCH AUTOSEL 5.10 5/7] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

2023-03-31 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 03aecb1acbcd7a660f97d645ca6c09d9de27ff9d ] Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was

[PATCH AUTOSEL 5.15 07/11] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

2023-03-31 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 03aecb1acbcd7a660f97d645ca6c09d9de27ff9d ] Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was

[PATCH AUTOSEL 6.1 23/24] drm/amdgpu/gfx: set cg flags to enter/exit safe mode

2023-03-31 Thread Sasha Levin
From: Jane Jian [ Upstream commit e06bfcc1a1c41bcb8c31470d437e147ce9f0acfd ] sriov needs to enter/exit safe mode in update umd p state add the cg flag to let it enter or exit while needed Signed-off-by: Jane Jian Reviewed-by: Lijo Lazar Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 6.1 22/24] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-31 Thread Sasha Levin
From: YuBiao Wang [ Upstream commit 033c56474acf567a450f8bafca50e0b610f2b716 ] [Why] For engines not supporting soft reset, i.e. VCN, there will be a failed ib test before mode 1 reset during asic reset. The fences in this case are never signaled and next time when we try to free the sa_bo,

[PATCH AUTOSEL 6.1 21/24] drm/amdgpu: add mes resume when do gfx post soft reset

2023-03-31 Thread Sasha Levin
From: Tong Liu01 [ Upstream commit 4eb0b49a0ad3e004a6a65b84efe37bc7e66d560f ] [why] when gfx do soft reset, mes will also do reset, if mes is not resumed when do recover from soft reset, mes is unable to respond in later sequence [how] resume mes when do gfx post soft reset Signed-off-by:

[PATCH AUTOSEL 6.1 13/24] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

2023-03-31 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 03aecb1acbcd7a660f97d645ca6c09d9de27ff9d ] Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was

[PATCH AUTOSEL 6.2 24/25] drm/amdgpu/gfx: set cg flags to enter/exit safe mode

2023-03-31 Thread Sasha Levin
From: Jane Jian [ Upstream commit e06bfcc1a1c41bcb8c31470d437e147ce9f0acfd ] sriov needs to enter/exit safe mode in update umd p state add the cg flag to let it enter or exit while needed Signed-off-by: Jane Jian Reviewed-by: Lijo Lazar Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin

[PATCH AUTOSEL 6.2 22/25] drm/amdgpu: add mes resume when do gfx post soft reset

2023-03-31 Thread Sasha Levin
From: Tong Liu01 [ Upstream commit 4eb0b49a0ad3e004a6a65b84efe37bc7e66d560f ] [why] when gfx do soft reset, mes will also do reset, if mes is not resumed when do recover from soft reset, mes is unable to respond in later sequence [how] resume mes when do gfx post soft reset Signed-off-by:

[PATCH AUTOSEL 6.2 23/25] drm/amdgpu: Force signal hw_fences that are embedded in non-sched jobs

2023-03-31 Thread Sasha Levin
From: YuBiao Wang [ Upstream commit 033c56474acf567a450f8bafca50e0b610f2b716 ] [Why] For engines not supporting soft reset, i.e. VCN, there will be a failed ib test before mode 1 reset during asic reset. The fences in this case are never signaled and next time when we try to free the sa_bo,

[PATCH AUTOSEL 6.2 14/25] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

2023-03-31 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 03aecb1acbcd7a660f97d645ca6c09d9de27ff9d ] Like the Windows Lenovo Yoga Book X91F/L the Android Lenovo Yoga Book X90F/L has a portrait 1200x1920 screen used in landscape mode, add a quirk for this. When the quirk for the X91F/L was initially added it was

Re: [PATCH v3 04/38] drm/msm/dpu: move UBWC/memory configuration to separate struct

2023-03-31 Thread Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote: UBWC and highest bank settings differ slightly between different DPU units of the same generation, while the dpu_caps and dpu_mdp_cfg are much more stable. To ease configuration reuse move ubwc_swizzle and highest_bank_bit data to separate

Re: [PATCH v3 03/38] drm/msm/dpu: mark remaining pp data as const

2023-03-31 Thread Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote: Fix several leftover _pp strutures and mark them as const, making all hw catalog fit into the rodata section. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH v3 02/38] drm/msm/dpu: constify DSC data structures

2023-03-31 Thread Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote: DSC hw catalog data is not supposed to be changed, so mark it as const data. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [PATCH v3 01/38] drm/msm/dpu: Allow variable SSPP/INTF_BLK size

2023-03-31 Thread Abhinav Kumar
On 3/30/2023 2:52 PM, Dmitry Baryshkov wrote: From: Konrad Dybcio These blocks are of variable length on different SoCs. Set the correct values where I was able to retrieve it from downstream DTs and leave the old defaults (0x1c8 for sspp and 0x280 for intf) otherwise. Signed-off-by:

Re: [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-31 Thread kernel test robot
Hi Mark, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on drm/drm-next linus/master v6.3-rc4 next-20230331] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next] [If your patch is applied

Re: [PATCH] drm/nouveau/disp: Support more modes by checking with lower bpc

2023-03-31 Thread Karol Herbst
On Fri, Mar 31, 2023 at 12:39 AM Karol Herbst wrote: > > This allows us to advertise more modes especially on HDR displays. > > Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP > adapter. Also fixes similiar issues for users running into this. > > Cc:

Re: [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Nathan Chancellor
> [ 20.550987] do_fbcon_takeover+0x74/0xf8 > > [ 20.550989] do_fb_registered+0x13c/0x158 > > [ 20.550992] fbcon_register_existing_fbs+0x78/0xc0 > > [ 20.550995] process_one_work+0x1ec/0x478 > > [ 20.551000] worker_thread+0x74/0x418 > > [ 20.551002]

[CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-03-31 Thread John . C . Harrison
From: John Harrison First release of GuC for Meteorlake. NB: As this is still pre-release and likely to change, use explicit versioning for now. The official, full release will use reduced version naming. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file

[pull] amdgpu, amdkfd, radeon drm-next-6.4

2023-03-31 Thread Alex Deucher
Hi Dave, Daniel, More new stuff for 6.4. The following changes since commit d36d68fd1925d33066d52468b7c7c6aca6521248: Merge tag 'drm-habanalabs-next-2023-03-20' of https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux into drm-next (2023-03-22 10:35:46 +1000) are available in the

[CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-03-31 Thread John . C . Harrison
From: John Harrison First release of GuC for Meteorlake. NB: As this is still pre-release and likely to change, use explicit versioning for now. The official, full release will use reduced version naming. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file

Re: [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Rob Clark
20.551011] Code: f944 b9409013 f940a082 9ba30a73 (b9407662) > [ 20.551013] ---[ end trace ]--- > > If there is any additional information that I can provide or patches I > can test, I am more than happy to do so. > > Cheers, >

[PATCH v8 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-03-31 Thread Mark Yacoub
From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Reviewed-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v3: -Split off into a new

[PATCH v8 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-31 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi

[PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-31 Thread Mark Yacoub
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2:

[PATCH v8 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-31 Thread Mark Yacoub
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

[PATCH v8 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-31 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring Reviewed-by:

[PATCH v8 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-31 Thread Mark Yacoub
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, rename to drm_hdcp_has_changed and return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean

[PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-31 Thread Mark Yacoub
From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could make good

[PATCH v8 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2023-03-31 Thread Mark Yacoub
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Change-Id: Ib358a503fa4520d072e477f708f1705b19f1c4fc Signed-off-by: Sean Paul --- Changes

[PATCH v8 03/10] drm/hdcp: Update property value on content type and user changes

2023-03-31 Thread Mark Yacoub
From: Sean Paul Update the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to DESIRED

[PATCH v8 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-31 Thread Mark Yacoub
From: Sean Paul Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Reviewed-by: Dmitry Baryshkov Signed-off-by: Sean Paul Signed-off-by:

[PATCH v8 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-03-31 Thread Mark Yacoub
Hi all, This is v7 of the HDCP patches. The patches are authored by Sean Paul. I rebased and addressed the review comments in v6-v8. Patches 1-4 focus on moving the common HDCP helpers to common DRM. This introduces a slight change in the original intel flow as it splits the unique driver

Re: [Intel-xe] [PATCH 1/3] drm/xe: Remove unused revid from firmware name

2023-03-31 Thread Lucas De Marchi
On Mon, Mar 27, 2023 at 09:59:55AM -0700, Matt Roper wrote: On Thu, Mar 23, 2023 at 10:17:52PM -0700, Lucas De Marchi wrote: The rev field is always 0 so it ends up never used. In i915 it was introduced because of CML: up to rev 5 it reuses the guc and huc firmware blobs from KBL. After that

Re: [PATCH] drm/ttm: add NUMA node id to the pool

2023-03-31 Thread Alex Deucher
On Fri, Mar 31, 2023 at 4:02 PM Felix Kuehling wrote: > > There is a subsequent patch where amdgpu directly calls ttm_pool_init to > create pools per NUMA node. That will depend on the updated function > signature. Then we probably want to take this through amdgpu then. Alex > > Regards, >

Re: [Intel-xe] [PATCH 2/3] drm/xe: Fix platform order

2023-03-31 Thread Lucas De Marchi
On Fri, Mar 31, 2023 at 01:47:20PM -0700, Matt Roper wrote: On Fri, Mar 31, 2023 at 07:22:06AM -0600, Lucas De Marchi wrote: On Mon, Mar 27, 2023 at 10:02:38AM -0700, Matt Roper wrote: > On Thu, Mar 23, 2023 at 10:17:53PM -0700, Lucas De Marchi wrote: > > Platform order is important when

Re: [PATCH] drm/nouveau/disp: Support more modes by checking with lower bpc

2023-03-31 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2023-03-31 at 00:39 +0200, Karol Herbst wrote: > This allows us to advertise more modes especially on HDR displays. > > Fixes using 4K@60 modes on my TV and main display both using a HDMI to DP > adapter. Also fixes similiar issues for users running into this. >

Re: [Intel-xe] [PATCH 2/3] drm/xe: Fix platform order

2023-03-31 Thread Matt Roper
On Fri, Mar 31, 2023 at 07:22:06AM -0600, Lucas De Marchi wrote: > On Mon, Mar 27, 2023 at 10:02:38AM -0700, Matt Roper wrote: > > On Thu, Mar 23, 2023 at 10:17:53PM -0700, Lucas De Marchi wrote: > > > Platform order is important when looping through the list of guc > > > firmware blobs since we

Re: [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Nathan Chancellor
20.551013] ---[ end trace ]--- If there is any additional information that I can provide or patches I can test, I am more than happy to do so. Cheers, Nathan # bad: [4b0f4525dc4fe8af17b3daefe585f0c2eb0fe0a5] Add linux-next specific files for 20230331 # good: [b2bc47e9b2011a183f9d3d3454a294

[PATCH] drm/nouveau/acr: remove unused loc variable

2023-03-31 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable 'loc' set but not used [-Werror,-Wunused-but-set-variable] u32 loc, sig, cnt, *meta; ^ This variable is not used so remove it. Signed-off-by: Tom Rix ---

Re: [PATCH] drm/bridge: ps8640: Use constant sleep time for polling hpd

2023-03-31 Thread Doug Anderson
Hi, On Thu, Mar 30, 2023 at 8:02 PM Pin-yen Lin wrote: > > The default hpd_wait_us in panel_edp.c is 2 seconds. This makes the > sleep time in the polling of _ps8640_wait_hpd_asserted become 200ms. > Change it to a constant 20ms to speed up the function. Ah, I see why I never ran into this. All

Re: [PATCH] drm/ttm: add NUMA node id to the pool

2023-03-31 Thread Felix Kuehling
There is a subsequent patch where amdgpu directly calls ttm_pool_init to create pools per NUMA node. That will depend on the updated function signature. Regards,   Felix On 2023-03-31 15:17, Alex Deucher wrote: On Fri, Mar 31, 2023 at 2:54 AM Christian König wrote: Should I push this to

[PATCH] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-03-31 Thread Fabio Estevam
From: Jagan Teki Samsung MIPI DSIM bridge can be found on Exynos and NXP's i.MX8M Mini and Nano SoC's. Convert exynos_dsim.txt to yaml. Used the example node from latest Exynos SoC instead of the one used in legacy exynos_dsim.txt. Signed-off-by: Jagan Teki Signed-off-by: Fabio Estevam ---

Re: [PATCH 1/4] dt-bindings: display: xinpeng,xpp055c272: document port

2023-03-31 Thread Rob Herring
On Sun, Mar 26, 2023 at 10:42:21PM +0200, Krzysztof Kozlowski wrote: > Panels are supposed to have one port (defined in panel-common.yaml > binding): > > px30-evb.dtb: panel@0: 'port' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- >

Re: [PATCH] dt-bindings: display: sitronix, st7789v: document dc-gpios

2023-03-31 Thread Rob Herring
On Sun, 26 Mar 2023 18:47:00 +0200, Krzysztof Kozlowski wrote: > The device comes with DCX pin which is already used in > canaan/sipeed_maixduino.dts (although not in Linux driver). > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/display/panel/sitronix,st7789v.yaml |

Re: [PATCH] accel/ivpu: Remove D3hot delay for Meteorlake

2023-03-31 Thread Bjorn Helgaas
On Fri, Mar 31, 2023 at 01:40:27PM +0200, Stanislaw Gruszka wrote: > From: Karol Wachowski > > VPU on MTL has hardware optimizations and does not require 10ms > D0 - D3hot transition delay imposed by PCI specification. PCIe r6.0, sec 5.9. > The delay removal is traditionally done by adding PCI

Re: [PATCH] drm/ttm: add NUMA node id to the pool

2023-03-31 Thread Alex Deucher
On Fri, Mar 31, 2023 at 2:54 AM Christian König wrote: > > Should I push this to drm-misc-next or do we take it through > amd-staging-drm-next? I think either way is fine. We can carry it internally as needed for testing if you want to commit it to drm-misc-next. I don't think there are any

[PATCH RFC v2 6/6] drm/msm/dsi: Fix calculations for eol_byte_num and pkt_per_line

2023-03-31 Thread Jessica Zhang
Use the correct calculations for eol_byte_num and pkt_per_line. Currently, pkt_per_line is calculated by dividing slice_per_intf by slice_count. This is incorrect, as slice_per_intf should be divided by slice_per_pkt, which is not always equivalent to slice_count as it is possible for there to be

[PATCH RFC v2 5/6] drm/msm/dsi: Use MSM and DRM DSC helper methods

2023-03-31 Thread Jessica Zhang
Use MSM and DRM DSC helper methods to configure DSC for DSI. Changes in V2: - *_calculate_initial_scale_value --> *_set_initial_scale_value - Split pkt_per_line and eol_byte_num changes to a separate patch - Moved pclk_per_line calculation to hdisplay adjustment in `if (dsc)` block of

[PATCH RFC v2 2/6] drm/msm: Add MSM-specific DSC helper methods

2023-03-31 Thread Jessica Zhang
Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Changes in v2: - Moved files up to msm/ directory - Dropped get_comp_ratio() helper - Used drm_int2fixp() to convert to integers to fp - Style changes to improve readability - Dropped unused bpp

[PATCH RFC v2 3/6] drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness

2023-03-31 Thread Jessica Zhang
Use the DRM DSC helper for det_thresh_flatness to match downstream implementation and the DSC spec. Changes in V2: - Added a Fixes tag Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 4 +++- 1 file

[PATCH RFC v2 0/6] Introduce MSM-specific DSC helpers

2023-03-31 Thread Jessica Zhang
There are some overlap in calculations for MSM-specific DSC variables between DP and DSI. In addition, the calculations for initial_scale_value and det_thresh_flatness that are defined within the DSC 1.2 specifications, but aren't yet included in drm_dsc_helper.c. This series moves these

[PATCH RFC v2 4/6] drm/msm/dpu: Fix slice_last_group_size calculation

2023-03-31 Thread Jessica Zhang
Correct the math for slice_last_group_size so that it matches the calculations downstream. Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Signed-off-by: Jessica Zhang Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 6 +- 1 file changed, 5

[PATCH RFC v2 1/6] drm/display/dsc: Add flatness and initial scale value calculations

2023-03-31 Thread Jessica Zhang
Add helpers to calculate det_thresh_flatness and initial_scale_value as these calculations are defined within the DSC spec. Changes in v2: - Renamed det_thresh_flatness to flatness_det_thresh - Set initial_scale_value directly in helper Signed-off-by: Jessica Zhang ---

Re: [RFC PATCH v8] media: mediatek: vcodec: support stateless AV1 decoder

2023-03-31 Thread Nicolas Dufresne
Hi Xiao, Le lundi 30 janvier 2023 à 20:38 +0800, Xiaoyong Lu a écrit : > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > I think this no longer needs an RFC tag. While at it, it would be nice for the maintainer to rebase on top if latest media stage (you still

[PATCH] dt-bindings: arm: nvidia: Drop unneeded quotes

2023-03-31 Thread Rob Herring
Cleanup bindings dropping unneeded quotes. Once all these are fixed, checking for this can be enabled in yamllint. Signed-off-by: Rob Herring --- .../devicetree/bindings/arm/nvidia,tegra194-ccplex.yaml | 6 +++--- .../bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 6 +++---

Re: [PATCH 14/19] drm/i915/i915_gem: Provide function names to complete the expected kerneldoc format

2023-03-31 Thread kernel test robot
Hi Lee, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-misc/drm-misc-next next-20230331] [cannot apply to drm-intel/for-linux-next-fixes lee-leds/for-leds-next linus/master v6.3-rc4] [If your patch

Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC

2023-03-31 Thread Matthias Brugger
On 09/03/2023 15:23, Alexandre Mergnat wrote: Add compatible for the MT8365 SoC. Signed-off-by: Alexandre Mergnat Applied, thanks! --- Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] drm/qxl: remove unused num_relocs variable

2023-03-31 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/qxl/qxl_ioctl.c:149:14: error: variable 'num_relocs' set but not used [-Werror,-Wunused-but-set-variable] int i, ret, num_relocs; ^ This variable is not used so remove it. Signed-off-by: Tom Rix ---

Re: [PATCH] Revert "drm/sched: Use parent fence instead of finished"

2023-03-31 Thread Rob Clark
On Fri, Dec 2, 2022 at 9:24 AM Arvind Yadav wrote: > > This reverts commit e4dc45b1848bc6bcac31eb1b4ccdd7f6718b3c86. > > This is causing instability on Linus' desktop, and Observed System > hung when running MesaGL benchmark or VK CTS runs. > > netconsole got me the following oops: >

[PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-03-31 Thread Tom Rix
clang with W=1 reports drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: variable 'num_of_active_display' set but not used [-Werror,-Wunused-but-set-variable] int num_of_active_display = 0; ^ This variable is not used so remove it. Signed-off-by: Tom Rix

[PULL] drm-misc-next

2023-03-31 Thread Maarten Lankhorst
Hi Dave, Daniel, Small update. Slow week. Felt like sending a pull request regardless. drm-misc-next-2023-03-31: drm-misc-next for v6.4-rc1: Cross-subsystem Changes: - DT bindings update for adding Mali MT81xx devices. - Assorted DT binding updates. Core Changes: - Documentation update to

Re: [PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-03-31 Thread Thomas Zimmermann
Hi Reviewed-by: Thomas Zimmermann for the whole patchset. Best regards Thomas Am 31.03.23 um 16:48 schrieb Geert Uytterhoeven: Hi all, Currently, there are two drivers for the LCD controller on Renesas SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: 1. sh_mobile_lcdcfb,

Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-03-31 Thread Fabio M. De Francesco
On venerdì 31 marzo 2023 13:30:20 CEST Tvrtko Ursulin wrote: > On 31/03/2023 05:18, Ira Weiny wrote: > > Zhao Liu wrote: > >> From: Zhao Liu > >> > >> The use of kmap_atomic() is being deprecated in favor of > >> kmap_local_page()[1], and this patch converts the calls from > >> kmap_atomic() to

Re: [PATCH 07/19] drm/i915/gem/i915_gem_create: Provide the function names for proper kerneldoc headers

2023-03-31 Thread kernel test robot
Hi Lee, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-misc/drm-misc-next next-20230331] [cannot apply to drm-intel/for-linux-next-fixes lee-leds/for-leds-next linus/master v6.3-rc4] [If your patch

Re: [PING] drm/bochs: replace ioremap with devm_ioremap to avoid immo leak

2023-03-31 Thread Sui Jingfeng
Hi, I'm noticed you patch, interesting! On 2023/3/29 13:26, Gencen Gan wrote: From: Gan Gecen Smatch reports: drivers/gpu/drm/tiny/bochs.c:290 bochs_hw_init() warn: 'bochs->mmio' from ioremap() not released on lines: 246,250,254. In the function bochs_load() that

Re: [PATCH] drm/amd/display: remove unused average_render_time_in_us and i variables

2023-03-31 Thread Hamza Mahfooz
On 3/30/23 20:10, Tom Rix wrote: clang with W=1 reports drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:1132:15: error: variable 'average_render_time_in_us' set but not used [-Werror,-Wunused-but-set-variable] unsigned int average_render_time_in_us = 0;

Re: [PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running

2023-03-31 Thread Dmitry Baryshkov
On Fri, 31 Mar 2023 at 16:59, Vinod Polimera wrote: > > In certain CPU stress conditions, there can be a delay in scheduling commit > work and it was observed that PSR commit from a different work queue was > scheduled. Avoid these commits as display is already in PSR mode. > > Signed-off-by:

Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-03-31 Thread Matthias Brugger
Hi Chun-Kuang Hu, On 13/03/2023 16:02, Chun-Kuang Hu wrote: Hi, Alexandre: Alexandre Mergnat 於 2023年3月9日 週四 下午10:23寫道: Display Adaptive Ambient Light for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Reviewed-by: Chun-Kuang Hu I'm a bit puzzled

[PATCH 1/5] drm: shmobile: Use %p4cc to print fourcc codes

2023-03-31 Thread Geert Uytterhoeven
Replace the printing of hexadecimal fourcc format codes by pretty-printed format names, using the "%p4cc" format specifier. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- drivers/gpu/drm/shmobile/shmob_drm_kms.c | 4 ++-- 2 files changed, 4

[PATCH 4/5] drm: shmobile: Add missing call to drm_fbdev_generic_setup()

2023-03-31 Thread Geert Uytterhoeven
Set up generic fbdev emulation, to enable support for the Linux console. Use 16 as the preferred depth, as that is a good compromise between colorfulness and resource utilization, and the default of the fbdev driver. Suggested-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven ---

[PATCH 5/5] drm: shmobile: Make DRM_SHMOBILE visible on Renesas SoC platforms

2023-03-31 Thread Geert Uytterhoeven
The LCD Controller supported by the drm-shmob driver is not only present on SuperH SH-Mobile SoCs, but also on Renesas ARM SH/R-Mobile SoCs. Make its option visible, so the user can enable support for it. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/Kconfig | 2 +- 1 file

[PATCH 2/5] drm: shmobile: Add support for DRM_FORMAT_XRGB8888

2023-03-31 Thread Geert Uytterhoeven
DRM_FORMAT_XRGB aka XR24 is the modus francus of DRM, and should be supported by all drivers. The handling for DRM_FORMAT_XRGB is similar to DRM_FORMAT_ARGB, just ignore the alpha channel. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1 +

[PATCH 3/5] drm: shmobile: Switch to drm_crtc_init_with_planes()

2023-03-31 Thread Geert Uytterhoeven
The SH-Mobile DRM driver uses the legacy drm_crtc_init(), which advertizes only the formats in safe_modeset_formats[] (XR24 and AR24) as being supported. Switch to drm_crtc_init_with_planes(), and advertize all supported (A)RGB modes, so we can use RGB565 as the default mode for the console.

[PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-03-31 Thread Geert Uytterhoeven
Hi all, Currently, there are two drivers for the LCD controller on Renesas SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: 1. sh_mobile_lcdcfb, using the fbdev framework, 2. shmob_drm, using the DRM framework. However, only the former driver can be used, as all platform

Re: [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 15:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm

Re: [PATCH v1 2/3] msm/disp/dpu: allow atomic_check in PSR usecase

2023-03-31 Thread Dmitry Baryshkov
On Fri, 31 Mar 2023 at 16:59, Vinod Polimera wrote: > > Certain flags like dirty_fb will be updated into the plane state > during crtc atomic_check. Allow those updates during PSR commit. > > Reported-by: Bjorn Andersson > Link: https://lore.kernel.org/all/20230326162723.3lo6pnsfdwzsvbhj@ripper/

Re: [PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode

2023-03-31 Thread Dmitry Baryshkov
On Fri, 31 Mar 2023 at 16:59, Vinod Polimera wrote: > > While in virtual terminal mode with PSR enabled, there will be > no atomic commits triggered without dirty_fb being set. This > will create a notion of no screen update. Allow atomic commit > when dirty_fb ioctl is issued, so that it can

Re: [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property

2023-03-31 Thread Matthias Brugger
On 09/03/2023 15:23, Alexandre Mergnat wrote: According to the mtk-mutex.c driver and the SoC DTS, the clock isn't required to work properly for some of MTK SoC. Improve the clock requirement by adding a condition which is function to the compatible. Signed-off-by: Alexandre Mergnat

[PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-03-31 Thread Andrzej Hajda
From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-by: Chris Wilson [ahajda: removed

[PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running

2023-03-31 Thread Vinod Polimera
In certain CPU stress conditions, there can be a delay in scheduling commit work and it was observed that PSR commit from a different work queue was  scheduled. Avoid these commits as display is already in PSR mode. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/msm_atomic.c | 3 +++ 1

[PATCH v1 2/3] msm/disp/dpu: allow atomic_check in PSR usecase

2023-03-31 Thread Vinod Polimera
Certain flags like dirty_fb will be updated into the plane state during crtc atomic_check. Allow those updates during PSR commit. Reported-by: Bjorn Andersson Link: https://lore.kernel.org/all/20230326162723.3lo6pnsfdwzsvbhj@ripper/ Signed-off-by: Vinod Polimera ---

[PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode

2023-03-31 Thread Vinod Polimera
While in virtual terminal mode with PSR enabled, there will be no atomic commits triggered without dirty_fb being set. This will create a notion of no screen update. Allow atomic commit when dirty_fb ioctl is issued, so that it can trigger a PSR exit and shows update on the screen. Reported-by:

[PATCH v1 0/3] Fixes for PSR

2023-03-31 Thread Vinod Polimera
while in virtual terminal with PSR enabled, there will be no atomic commits triggered resulting in no screen update. Update the dirtyfb flag into plane state during atomic check to flush the pixel data explicitly. Avoid scheduling PSR commits from different work queues while running in PSR mode

Re: [Intel-xe] [PATCH 2/3] drm/xe: Fix platform order

2023-03-31 Thread Lucas De Marchi
On Mon, Mar 27, 2023 at 10:02:38AM -0700, Matt Roper wrote: On Thu, Mar 23, 2023 at 10:17:53PM -0700, Lucas De Marchi wrote: Platform order is important when looping through the list of guc firmware blobs since we use it to prevent loading a blob for a newer platform onto an older one. Move PVC

Re: [PATCH] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-03-31 Thread Luben Tuikov
On 2023-03-31 01:59, Christian König wrote: > Am 31.03.23 um 02:06 schrieb Danilo Krummrich: >> It already happend a few times that patches slipped through which >> implemented access to an entity through a job that was already removed >> from the entities queue. Since jobs and entities might have

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-31 Thread Tvrtko Ursulin
On 30/03/2023 20:44, Teres Alexis, Alan Previn wrote: On Thu, 2023-03-30 at 13:25 +0100, Tvrtko Ursulin wrote: On 30/03/2023 01:10, Teres Alexis, Alan Previn wrote: On Wed, 2023-03-29 at 08:43 +0100, Tvrtko Ursulin wrote: On 28/03/2023 18:52, Rodrigo Vivi wrote: On Tue, Mar 28, 2023 at

Re: [PATCHv1 3/7] drm/panel: sitronix-st7789v: add SPI ID table

2023-03-31 Thread Michael Riesch
Hi Sebastian, On 3/18/23 00:23, Sebastian Reichel wrote: > SPI device drivers should also have a SPI ID table. > > Signed-off-by: Sebastian Reichel > --- > drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCHv1 7/7] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-03-31 Thread Michael Riesch
Hi Sebastian, Thanks for your work and for the beautiful timing :-) On 3/18/23 00:23, Sebastian Reichel wrote: > UNI-T UTi260b has a Inanbo T28CP45TN89 v17 panel. I could not find > proper documentation for the panel apart from a technical drawing, but > according to the vendor U-Boot it is

[PATCH] accel/ivpu: Remove D3hot delay for Meteorlake

2023-03-31 Thread Stanislaw Gruszka
From: Karol Wachowski VPU on MTL has hardware optimizations and does not require 10ms D0 - D3hot transition delay imposed by PCI specification. The delay removal is traditionally done by adding PCI ID to quirk_remove_dhot_delay() in drivers/pci/quirks.c . But since we do not need that

[PATCH 2/2] accel/ivpu: Fix S3 system suspend when not idle

2023-03-31 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Wait for VPU to be idle in ivpu_pm_suspend_cb() before powering off the device, so jobs are not lost and TDRs are not triggered after resume. Fixes: 852be13f3bd3 ("accel/ivpu: Add PM support") Signed-off-by: Jacek Lawrynowicz Signed-off-by: Stanislaw Gruszka ---

[PATCH 1/2] accel/ivpu: Add dma fence to command buffers only

2023-03-31 Thread Stanislaw Gruszka
From: Karol Wachowski Currently job->done_fence is added to every BO handle within a job. If job handle (command buffer) is shared between multiple submits, KMD will add the fence in each of them. Then bo_wait_ioctl() executed on command buffer will exit only when all jobs containing that handle

[PATCH 0/2] accel/ivpu: Fixes for linux-6.3-rc6

2023-03-31 Thread Stanislaw Gruszka
Jacek Lawrynowicz (1): accel/ivpu: Fix S3 system suspend when not idle Karol Wachowski (1): accel/ivpu: Add dma fence to command buffers only drivers/accel/ivpu/ivpu_job.c | 18 +++--- drivers/accel/ivpu/ivpu_pm.c | 26 +++--- 2 files changed, 18

Re: [PATCH v2 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c

2023-03-31 Thread Tvrtko Ursulin
On 31/03/2023 05:18, Ira Weiny wrote: Zhao Liu wrote: From: Zhao Liu The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1], and this patch converts the calls from kmap_atomic() to kmap_local_page(). The main difference between atomic and local mappings is that local

  1   2   >