On Wed, Apr 12, 2023 at 06:00:07PM +0700, Ammar Faizi wrote:
> On Wed, Apr 12, 2023 at 11:17:22AM +0700, Bagas Sanjaya wrote:
> > From gitlab issue above, I don't see any progress on bisection attempt.
> > Ammar, have you successfully boot Ubuntu 20.04 with v5.10 kernel and
> > test there?
>
> I
Hi Nikita,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on tegra/for-next drm-intel/for-linux-next
drm-intel/for-linux-next-fixes linus/master v6.3-rc6 next-20230412]
[If your patch is applied to the wrong git
From: Xinlei Lee
Mainly add the following two flag:
1.The audio packet arrangement function is to only arrange audio
packets into the Hblanking area. In order to align with the HW
default setting of g1200, this function needs to be turned off.
2.Due to the difference of HW, different dividers
From: Xinlei Lee
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.
Signed-off-by: Xinlei Lee
Signed-off-by: Jitao Shi
---
.../devicetree/bindings/display/mediatek/mediatek,dp.yaml| 1 +
1 file changed, 1 insertion(+)
diff --git
From: Xinlei Lee
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.
Mainly add the following two flag:
1.The audio packet arrangement function is to only arrange audio
packets into the Hblanking area. In order to align with the HW
default setting of g1200, this function needs to be
On Wed, Apr 12, 2023 at 09:46:02PM +0200, Konrad Dybcio wrote:
> Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3
> video mode display. Add support for these panels.
>
> Signed-off-by: Konrad Dybcio
> ---
> drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491
>
On Wed, Apr 12, 2023 at 09:46:01PM +0200, Konrad Dybcio wrote:
> Some bright vendors mount their display panels upside down. Add the
> required pieces to allow for accounting for that.
>
> Signed-off-by: Konrad Dybcio
Reviewed-by: Jianhua Lu
> ---
>
On Wed, Apr 12, 2023 at 09:46:00PM +0200, Konrad Dybcio wrote:
> This chip supports controlling the backlight via DCS commands, on at
> least some panels. Add support for doing so.
>
> Note this may only concern the NT36523*W* variant. Nobody knows, really,
> there's no docs.
>
> Signed-off-by:
> (not tested)
Tested. It fixes the regression on my laptop.
> diff --git a/drivers/firmware/sysfb_simplefb.c
> b/drivers/firmware/sysfb_simplefb.c
> index 82c64cb9f531..9f5299d54732 100644
> --- a/drivers/firmware/sysfb_simplefb.c
> +++ b/drivers/firmware/sysfb_simplefb.c
> @@ -56,10 +56,11 @@
After careful reading of the comments in f35cd3fa7729, would this
be an appropriate fix ? Does it still address all the issues raised
by Thomas ?
(not tested)
diff --git a/drivers/firmware/sysfb_simplefb.c
b/drivers/firmware/sysfb_simplefb.c
index 82c64cb9f531..9f5299d54732 100644
---
On 12/04/2023 23:34, Rob Clark wrote:
On Wed, Apr 12, 2023 at 1:19 PM Dmitry Baryshkov
wrote:
On Wed, 12 Apr 2023 at 23:09, Rob Clark wrote:
On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote:
On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
On Wed, Apr 12, 2023 at
On 13/04/2023 02:25, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to convert to integers to fp
- Style changes to
On 13/04/2023 01:40, Abhinav Kumar wrote:
On 4/12/2023 12:24 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
Add a check for valid dsc->slice_width value in dsi_timing_setup.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++
1 file
Hi, Daniel:
Daniel Vetter 於 2023年4月11日 週二 下午6:32寫道：
>
> On Thu, Mar 30, 2023 at 11:26:13AM +0800, Nancy.Lin wrote:
> > Add mdp_rdma get_format and get_num_formats function.
> >
> > Signed-off-by: Nancy.Lin
>
> The mtk get_formats stuff seems like a lot of midlayering for not much
> reasons? Is
On 4/12/2023 4:25 PM, Jessica Zhang wrote:
From: Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
hdisplay for compressed images should be calculated as bytes_per_slice *
slice_count. Thus, use MSM DSC helper to calculate hdisplay for
dsi_timing_setup instead of directly using mode->hdisplay.
Changes in v3:
- Split from previous patch
- Initialized hdisplay as uncompressed pclk per line at
There are some overlap in calculations for MSM-specific DSC variables
between DP and DSI. In addition, the calculations for initial_scale_value
and det_thresh_flatness that are defined within the DSC 1.2 specifications,
but aren't yet included in drm_dsc_helper.c.
This series moves these
Correct the math for slice_last_group_size so that it matches the
calculations downstream.
Changes in v3:
- Reworded slice_last_group_size calculation to
`(dsc->slice_width + 2) % 3`
Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC")
Signed-off-by: Jessica Zhang
Reviewed-by:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to convert to integers to fp
- Style changes to improve readability
- Dropped unused bpp
Currently, pkt_per_line is calculated by dividing slice_per_intf by
slice_count. This is incorrect, as slice_per_intf should be divided by
slice_per_pkt, which is not always equivalent to slice_count as it is
possible for there to be multiple soft slices per interface even though
a panel only
Use MSM and DRM DSC helper methods to configure DSC for DSI.
Changes in v2:
- *_calculate_initial_scale_value --> *_set_initial_scale_value
- Split pkt_per_line and eol_byte_num changes to a separate patch
- Moved pclk_per_line calculation to hdisplay adjustment in `if (dsc)`
block of
Use the DRM DSC helper for det_thresh_flatness to match downstream
implementation and the DSC spec.
Changes in V2:
- Added a Fixes tag
Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC")
Signed-off-by: Jessica Zhang
Reviewed-by: Dmitry Baryshkov
---
From: Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by: Dmitry Baryshkov
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 61
(Okay, can't back out *all* of the first patch, just the assignment
to mode->stride.)
Anyway, here you go:
grub: gfxpayload=keep
[0.00] Console: colour dummy device 128x48
[0.00] printk: console [tty0] enabled
[0.419983] fbcon: Taking over console
[0.516198] pci
On 3/30/23 07:27, Rob Clark wrote:
> From: Rob Clark
>
> Fixes warning:
>
> include/uapi/linux/sync_file.h:77: warning: Function parameter or member
> 'num_fences' not described in 'sync_file_info'
>
> Reported-by: Stephen Rothwell
> Fixes: 2d75c88fefb2 ("staging/android: refactor SYNC
From: Rob Clark
Use the new helper to export stats about memory usage.
v2: Drop unintended hunk
v3: Rebase
Signed-off-by: Rob Clark
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/msm/msm_gem.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_gem.c
From: Rob Clark
Add support to dump GEM stats to fdinfo.
v2: Fix typos, change size units to match docs, use div_u64
v3: Do it in core
v4: more kerneldoc
Signed-off-by: Rob Clark
Reviewed-by: Emil Velikov
Reviewed-by: Daniel Vetter
---
Documentation/gpu/drm-usage-stats.rst | 21
From: Rob Clark
Signed-off-by: Rob Clark
---
drivers/gpu/drm/i915/i915_driver.c | 3 ++-
drivers/gpu/drm/i915/i915_drm_client.c | 18 +-
drivers/gpu/drm/i915/i915_drm_client.h | 2 +-
3 files changed, 8 insertions(+), 15 deletions(-)
diff --git
From: Rob Clark
Signed-off-by: Rob Clark
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +-
3 files changed, 9 insertions(+), 12 deletions(-)
diff --git
From: Rob Clark
Handle a bit of the boiler-plate in a single case, and make it easier to
add some core tracked stats.
v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo
Reviewed-by: Daniel Vetter
Signed-off-by: Rob Clark
---
Documentation/gpu/drm-usage-stats.rst | 10
From: Rob Clark
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_drv.c | 11 +--
drivers/gpu/drm/msm/msm_gpu.c | 2 --
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 5a10d28de9dd..3d73b98d6a9c
From: Rob Clark
Similar motivation to other similar recent attempt[1]. But with an
attempt to have some shared code for this. As well as documentation.
It is probably a bit UMA-centric, I guess devices with VRAM might want
some placement stats as well. But this seems like a reasonable start.
On 4/12/2023 12:24 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
Add a check for valid dsc->slice_width value in dsi_timing_setup.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
On Wed, Apr 12, 2023 at 12:59 AM Daniel Vetter wrote:
>
> On Tue, Apr 11, 2023 at 03:56:10PM -0700, Rob Clark wrote:
> > From: Rob Clark
> >
> > Signed-off-by: Rob Clark
>
> You're on an old tree, this got reverted. But I'm kinda wondering whether
> another patch on top shouldn't just includ
"Pierre Asselin" writes:
>> Javier Martinez Canillas writes:
>>
>> I still don't understand why this particular configuration didn't work...
>>
>> The framebuffer starts at 0xd800 and has a size of 0x24 bytes, so
>
> Says who ? It's the same grub, same video mode as before the
Hi Dave, Daniel,
Fixes for 6.3.
The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d:
Linux 6.3-rc6 (2023-04-09 11:15:57 -0700)
are available in the Git repository at:
https://gitlab.freedesktop.org/agd5f/linux.git
tags/amd-drm-fixes-6.3-2023-04-12
for you to
> Javier Martinez Canillas writes:
>
> I still don't understand why this particular configuration didn't work...
>
> The framebuffer starts at 0xd800 and has a size of 0x24 bytes, so
Says who ? It's the same grub, same video mode as before the regression,
so the size is probably
On 13/04/2023 00:49, Jessica Zhang wrote:
On 4/12/2023 12:16 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped
On 4/12/2023 12:16 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp()
Javier Martinez Canillas writes:
[...]
>> == Bad after patch, typing blind to log in !==
>> grub: gfxpayload=keep
>> [0.00] Console: colour dummy device 128x48
>> [0.00] printk: console [tty0] enabled
>> [0.423925] fbcon: Taking over console
>> [
From: Jonathan Cavitt
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is
because
MTL reports as not supporting 64K pages, or more accurately, the system that
reports
whether a platform has 64K pages reports false for MTL. This is only half
correct,
as the 64K page
Hi,
just taking these patches over and respinning them, almost as
they were the last time, just did some trivial cosmetic.
Andi
Changelog
=
v5 -> v6
- Trivial variable declaration reordering
v4 -> v5
- Reorder
v3 -> v4
- Break mock subtest changes into separate patch.
v2 -> v3
-
From: Jonathan Cavitt
Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into
live selftests as their requirements have recently become platform-dependent.
Additionally, apply necessary platform dependency checks to these tests.
Signed-off-by: Jonathan Cavitt
Hi,
On Mon, Apr 10, 2023 at 9:59 AM Dmitry Baryshkov
wrote:
>
> Move GMU mutex initialization earlier to make sure that it is always
> initialized. a6xx_destroy can be called from ther failure path before
> GMU initialization.
>
> This fixes the following backtrace:
>
> [ cut here
"Pierre Asselin" writes:
>> And can you share the "linelength=" print out from simplefb ?
>
> Okay. Three cases, see below.
>
> Your patch tries to fix the stride, but what if it's the _depth_
> that's wrong ? Grub sets the mode, the pre-regression kernel picks this:
> format=x8r8g8b8,
On Wed, 12 Apr 2023 13:27:25 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's UFOE block: this
> is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,ufoe.yaml| 3
On Wed, 12 Apr 2023 13:27:19 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's RDMA block: this
> is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 4
On Wed, 12 Apr 2023 13:27:15 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using
> the same parameters as MT8183.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../display/mediatek/mediatek,dpi.yaml| 23
On Wed, 12 Apr 2023 13:27:21 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's COLOR block: this
> is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,color.yaml
On Wed, 12 Apr 2023 13:27:17 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795, using the same
> DSI block as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../display/mediatek/mediatek,dsi.yaml| 19 ---
On Wed, 12 Apr 2023 13:27:18 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's OVL block: this
> is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml| 4
On Wed, 12 Apr 2023 13:27:26 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's OverDrive (OD)
> block: this is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
>
On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote:
> Add a compatible string for MediaTek Helio X10 MT6795's display PWM
> block: this is the same as MT8173.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
> ---
>
On 4/12/2023 12:10 PM, Dmitry Baryshkov wrote:
On 12/04/2023 22:09, Jessica Zhang wrote:
From: Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by:
On Wed, Apr 12, 2023 at 1:19 PM Dmitry Baryshkov
wrote:
>
> On Wed, 12 Apr 2023 at 23:09, Rob Clark wrote:
> >
> > On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote:
> > >
> > > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
> > > > On Wed, Apr 12, 2023 at 01:36:52AM +0300,
On Wed, Apr 12, 2023 at 4:10 PM Rob Clark wrote:
>
> On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote:
> >
> > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
> > > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote:
> > > > On 11/04/2023 21:28, Rob Clark wrote:
>
Hi,
On Sat, Apr 8, 2023 at 1:20 AM Nikita Travkin wrote:
>
> This bridge doesn't actually implement HPD due to it being way too slow
> but instead expects the panel driver to wait enough to assume HPD is
> asserted. However some panels (such as the generic 'edp-panel') expect
> the bridge to
On Wed, 12 Apr 2023 at 23:09, Rob Clark wrote:
>
> On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote:
> >
> > On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
> > > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote:
> > > > On 11/04/2023 21:28, Rob Clark wrote:
> >
On Wed, Apr 12, 2023 at 5:47 AM Rodrigo Vivi wrote:
>
> On Wed, Apr 12, 2023 at 10:11:32AM +0200, Daniel Vetter wrote:
> > On Wed, Apr 12, 2023 at 01:36:52AM +0300, Dmitry Baryshkov wrote:
> > > On 11/04/2023 21:28, Rob Clark wrote:
> > > > On Tue, Apr 11, 2023 at 10:36 AM Dmitry Baryshkov
> > >
On 4/12/23 20:36, Daniel Vetter wrote:
On Fri, Mar 24, 2023 at 09:21:31PM +0100, Helge Deller wrote:
Fix a kernel crash in the fbdev modedb code which can happen if you boot
a system without any graphic card driver, in which case the dummycon
driver takes the console. If you then load a fbdev
Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3
video mode display. Document it and allow rotation while at it (Lenovo
mounted it upside down!).
Signed-off-by: Konrad Dybcio
---
.../bindings/display/panel/novatek,nt36523.yaml | 16 +++-
1 file changed, 11
Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3
video mode display. Add support for these panels.
Signed-off-by: Konrad Dybcio
---
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 491 ++
1 file changed, 491 insertions(+)
diff --git
Some bright vendors mount their display panels upside down. Add the
required pieces to allow for accounting for that.
Signed-off-by: Konrad Dybcio
---
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
This chip supports controlling the backlight via DCS commands, on at
least some panels. Add support for doing so.
Note this may only concern the NT36523*W* variant. Nobody knows, really,
there's no docs.
Signed-off-by: Konrad Dybcio
---
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 67
Using 'port' instead of 'ports' for single-DSI usecases allows for saving
a couple of DTS LoC, including a level of indentation. Allow that.
Signed-off-by: Konrad Dybcio
---
.../bindings/display/panel/novatek,nt36523.yaml | 15 +--
1 file changed, 13 insertions(+), 2
/drm/panel/panel-novatek-nt36523.c | 573 -
2 files changed, 594 insertions(+), 10 deletions(-)
---
base-commit: 7d8214bba44c1aa6a75921a09a691945d26a8d43
change-id: 20230412-topic-lenovopanel-0d3a057e3c23
Best regards,
--
Konrad Dybcio
On 12/04/2023 22:09, Jessica Zhang wrote:
Add a check for valid dsc->slice_width value in dsi_timing_setup.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote:
> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote:
> >
> > On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote:
> > > On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin
> > > wrote:
> > > >
> > > >
> > > > On 11/04/2023 23:56, Rob
On 12/04/2023 22:09, Jessica Zhang wrote:
Use MSM and DRM DSC helper methods to configure DSC for DSI.
Changes in v2:
- *_calculate_initial_scale_value --> *_set_initial_scale_value
- Split pkt_per_line and eol_byte_num changes to a separate patch
- Moved pclk_per_line calculation to hdisplay
On 12/04/2023 22:09, Jessica Zhang wrote:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to convert to integers to fp
- Style changes to
On 12/04/2023 22:09, Jessica Zhang wrote:
From: Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by: Dmitry Baryshkov
Since you are resending this
Currently, pkt_per_line is calculated by dividing slice_per_intf by
slice_count. This is incorrect, as slice_per_intf should be divided by
slice_per_pkt, which is not always equivalent to slice_count as it is
possible for there to be multiple soft slices per interface even though
a panel only
hdisplay for compressed images should be calculated as bytes_per_slice *
slice_count. Thus, use MSM DSC helper to calculate hdisplay for
dsi_timing_setup instead of directly using mode->hdisplay.
Changes in v3:
- Split from previous patch
- Initialized hdisplay as uncompressed pclk per line at
Use MSM and DRM DSC helper methods to configure DSC for DSI.
Changes in v2:
- *_calculate_initial_scale_value --> *_set_initial_scale_value
- Split pkt_per_line and eol_byte_num changes to a separate patch
- Moved pclk_per_line calculation to hdisplay adjustment in `if (dsc)`
block of
From: Dmitry Baryshkov
Use new DRM DSC helpers to setup DSI DSC configuration. The
initial_scale_value needs to be adjusted according to the standard, but
this is a separate change.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 61
Use the DRM DSC helper for det_thresh_flatness to match downstream
implementation and the DSC spec.
Changes in V2:
- Added a Fixes tag
Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC")
Signed-off-by: Jessica Zhang
Reviewed-by: Dmitry Baryshkov
---
Add a check for valid dsc->slice_width value in dsi_timing_setup.
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
b/drivers/gpu/drm/msm/dsi/dsi_host.c
index
Correct the math for slice_last_group_size so that it matches the
calculations downstream.
Changes in v3:
- Reworded slice_last_group_size calculation to
`(dsc->slice_width + 2) % 3`
Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC")
Signed-off-by: Jessica Zhang
Reviewed-by:
Introduce MSM-specific DSC helper methods, as some calculations are
common between DP and DSC.
Changes in v2:
- Moved files up to msm/ directory
- Dropped get_comp_ratio() helper
- Used drm_int2fixp() to convert to integers to fp
- Style changes to improve readability
- Dropped unused bpp
There are some overlap in calculations for MSM-specific DSC variables
between DP and DSI. In addition, the calculations for initial_scale_value
and det_thresh_flatness that are defined within the DSC 1.2 specifications,
but aren't yet included in drm_dsc_helper.c.
This series moves these
On 4/12/2023 11:50 AM, Marijn Suijten wrote:
On 2023-04-12 10:48:18, Abhinav Kumar wrote:
[..]
The only way to trigger this newly introduced range check is by omitting
the DSC_x constants and manually writing e.g. an out-of-range value 10
here, or setting DSC_NONE. This is only allowed for
On 12/04/2023 21:50, Marijn Suijten wrote:
On 2023-04-12 10:48:18, Abhinav Kumar wrote:
[..]
The only way to trigger this newly introduced range check is by omitting
the DSC_x constants and manually writing e.g. an out-of-range value 10
here, or setting DSC_NONE. This is only allowed for
> And can you share the "linelength=" print out from simplefb ?
Okay. Three cases, see below.
Your patch tries to fix the stride, but what if it's the _depth_
that's wrong ? Grub sets the mode, the pre-regression kernel picks this:
format=x8r8g8b8, mode=1024x768x32, linelength=4096
On 2023-04-12 10:48:18, Abhinav Kumar wrote:
[..]
> > The only way to trigger this newly introduced range check is by omitting
> > the DSC_x constants and manually writing e.g. an out-of-range value 10
> > here, or setting DSC_NONE. This is only allowed for interfaces.
> >
>
> Correct, its just
Hi Rob,
On 12/04/2023 11:43, Rob Herring wrote:
No, this should be video-interfaces.yaml since you use properties from
it.
Ok, will change it.
+unevaluatedProperties: false
+
+properties:
+ data-lanes:
+oneOf:
+ -
On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote:
>
> On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote:
> > On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin
> > wrote:
> > >
> > >
> > > On 11/04/2023 23:56, Rob Clark wrote:
> > > > From: Rob Clark
> > > >
> > > > Add support to dump
On Fri, Mar 24, 2023 at 09:21:31PM +0100, Helge Deller wrote:
> Fix a kernel crash in the fbdev modedb code which can happen if you boot
> a system without any graphic card driver, in which case the dummycon
> driver takes the console. If you then load a fbdev graphics driver and
> start a the
Hi Nikita,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on tegra/for-next drm-intel/for-linux-next
drm-intel/for-linux-next-fixes linus/master v6.3-rc6 next-20230412]
[If your patch is applied to the wrong
On Wed, Apr 12, 2023 at 8:12 PM Pierre Asselin wrote:
>
>
> > Interesting. So you don't have the simplefb output that you had before ?
>
> I do now, after a 'make clean' and "make bzImage'.
>
> In between, I had tried CONFIG_SYSFB_SIMPLEFB=n . That "works", by
> falling back to vesafb in every
On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote:
> On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin
> wrote:
> >
> >
> > On 11/04/2023 23:56, Rob Clark wrote:
> > > From: Rob Clark
> > >
> > > Add support to dump GEM stats to fdinfo.
> > >
> > > v2: Fix typos, change size units to match
On Wed, Apr 12, 2023 at 04:12:41PM +0100, Tvrtko Ursulin wrote:
>
> On 12/04/2023 14:51, Daniel Vetter wrote:
> > On Wed, Apr 12, 2023 at 01:32:43PM +0100, Tvrtko Ursulin wrote:
> > >
> > > On 11/04/2023 23:56, Rob Clark wrote:
> > > > From: Rob Clark
> > > >
> > > > Signed-off-by: Rob Clark
> Interesting. So you don't have the simplefb output that you had before ?
I do now, after a 'make clean' and "make bzImage'.
In between, I had tried CONFIG_SYSFB_SIMPLEFB=n . That "works", by
falling back to vesafb in every case. I restored the .config before
testing the patch, but there
On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin
wrote:
>
>
> On 11/04/2023 23:56, Rob Clark wrote:
> > From: Rob Clark
> >
> > Add support to dump GEM stats to fdinfo.
> >
> > v2: Fix typos, change size units to match docs, use div_u64
> > v3: Do it in core
> >
> > Signed-off-by: Rob Clark
> >
From: Fabio Estevam
video-interface.txt does not exist anymore, as it has been converted
to video-interfaces.yaml.
Instead of referencing video-interfaces.yaml multiple times,
pass it as a $ref to the schema.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Pass video-interfaces.yaml as
On 4/12/2023 12:38 AM, Marijn Suijten wrote:
On 2023-04-11 18:50:24, Abhinav Kumar wrote:
On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote:
On 12/04/2023 01:32, Abhinav Kumar wrote:
Hi Marijn
On 4/11/2023 3:24 PM, Marijn Suijten wrote:
Again, don't forget to include previous reviewers in
On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote:
> Hi,
>
> On 2023/4/11 22:53, Daniel Vetter wrote:
> > On Sun, Apr 09, 2023 at 09:21:10PM +0800, Sui Jingfeng wrote:
> > > From: Sui Jingfeng
> > >
> > > We should setting the screen buffer size according to the screen's actual
> > >
On 4/12/2023 12:24 AM, Marijn Suijten wrote:
On 2023-04-11 16:45:34, Abhinav Kumar wrote:
[..]
Does this flush all DSCs programmed in CTL_DSC_FLUSH as set above? That
is currently still in `if (cfg->dsc)` and never overwritten if all DSCs
are disabled, should it be taken out of the `if` to
"Pierre Asselin" writes:
>> The commit f35cd3fa7729 ("firmware/sysfb: Fix EFI/VESA format selection")
>> fixed format selection, by calculating the bits-per-pixel instead of just
>> using the reported color depth.
>>
>> But unfortunately this broke some modes because the stride is always set
>>
On 03-04-23, 17:47, Paul Cercueil wrote:
> This function can be used to initiate a scatter-gather DMA transfer
> where the DMA addresses and lengths are located inside arrays.
>
> The major difference with dmaengine_prep_slave_sg() is that it supports
> specifying the lengths of each DMA
On 2023/4/13 01:13, Sui Jingfeng wrote:
I finally got reject by drm_fbdev_generic_helper_fb_dirty() with
follow code:
It finally got rejected by drm_fbdev_generic_helper_fb_dirty() function
with follow code:
1 - 100 of 272 matches
Mail list logo
