Re: [PATCH] MAINTAINERS: Update Alain Volmat's email address for drm/sti

2023-04-19 Thread Patrice CHOTARD
Hi Alain On 4/16/23 22:27, Alain Volmat wrote: > Update my email address for maintainer of the STi DRM driver. > > Signed-off-by: Alain Volmat > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-04-19 Thread Steven Price
On 19/04/2023 10:44, Lucas Stach wrote: > Hi Steven, > > Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: >> On 18/04/2023 11:04, Danilo Krummrich wrote: >>> It already happend a few times that patches slipped through which >>> implemented access to an entity through a job that

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-04-19 Thread Lucas Stach
Hi Steven, Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: > On 18/04/2023 11:04, Danilo Krummrich wrote: > > It already happend a few times that patches slipped through which > > implemented access to an entity through a job that was already removed > > from the entities queue.

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-04-19 Thread Steven Price
On 18/04/2023 11:04, Danilo Krummrich wrote: > It already happend a few times that patches slipped through which > implemented access to an entity through a job that was already removed > from the entities queue. Since jobs and entities might have different > lifecycles, this can potentially cause

Re: [PATCH] drm/etnaviv: don't block scheduler when GPU is still active

2023-04-19 Thread Lucas Stach
Hi, does anyone have some bandwidth to review this? Regards, Lucas Am Freitag, dem 31.03.2023 um 13:00 +0200 schrieb Lucas Stach: > Since 45ecaea73883 ("drm/sched: Partial revert of 'drm/sched: Keep > s_fence->parent pointer'") still active jobs aren't put back in the > pending list on

Re: [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-19 Thread Marijn Suijten
On 2023-04-18 09:06:34, Abhinav Kumar wrote: > > On 4/17/2023 4:14 PM, Marijn Suijten wrote: > > The WB debug log mask ended up never being assigned, leading to writes > > to this block to never be logged even if the mask is enabled in > > dpu_hw_util_log_mask via sysfs. > > This should be

[PULL] drm-intel-fixes

2023-04-19 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2023-04-19: drm/i915 fixes for v6.3 final: - Fix fast wake AUX sync len BR, Jani. The following changes since commit 6a8f57ae2eb07ab39a6f0ccad60c760743051026: Linux 6.3-rc7 (2023-04-16 15:23:53 -0700) are available in the Git repository at:

Re: [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-04-19 Thread Christian König
Am 19.04.23 um 10:57 schrieb hackyzh002: The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Signed-off-by: hackyzh002 ---

Re: [PATCH] dt-bindings: display: panel: add common definition of ports

2023-04-19 Thread Krzysztof Kozlowski
On 19/04/2023 00:26, Rob Herring wrote: > On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: >> Few panel bindings for dual-link connections just type "ports: true", >> which does not enforce any type. Add common definition of ports, so the >> type will be fixed. >> >>

Re: [PATCH v4 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-04-19 Thread Christian König
Am 18.04.23 um 17:49 schrieb Lorenzo Stoakes: No invocation of get_user_pages() uses the vmas parameter, so remove it. The GUP API is confusing and caveated. Recent changes have done much to improve that, however there is more we can do. Exporting vmas is a prime target as the caller has to be

Re: [PATCH V2 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-19 Thread Christian König
Am 19.04.23 um 10:27 schrieb hackyzh002: The type of size is unsigned int, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later. Signed-off-by: hackyzh002 ---

Re: [PATCH 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-04-19 Thread Christian König
Am 19.04.23 um 06:24 schrieb hackyzh002: The type of size is unsigned, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later Well good catch, but this is actually harmless. Userspace

Re: [PATCH] kunit: drm: make DRM buddy test compatible with other pages sizes

2023-04-19 Thread Christian König
Am 18.04.23 um 19:15 schrieb Nico Pache: The DRM buddy test uses a fixed 12 bit shift to covert from pages to bytes. This number is then used to confirm that (chunk_size < PAGE_SIZE) which can lead to a failing drm_buddy_init on systems with PAGE_SIZE > 4k. Since the buddy allocator is used

Re: [PATCH] kunit: drm: make DRM buddy test compatible with other pages sizes

2023-04-19 Thread David Gow
On Wed, 19 Apr 2023 at 01:15, Nico Pache wrote: > > The DRM buddy test uses a fixed 12 bit shift to covert from pages to > bytes. This number is then used to confirm that (chunk_size < PAGE_SIZE) > which can lead to a failing drm_buddy_init on systems with PAGE_SIZE > 4k. > > Fixes: 92937f170d3f

Re: [PATCH v2] firmware/sysfb: Fix VESA format selection

2023-04-19 Thread Javier Martinez Canillas
Pierre Asselin writes: Hello Pierre, > Some legacy BIOSes report no reserved bits in their 32-bit rgb mode, > breaking the calculation of bits_per_pixel in commit f35cd3fa7729 > [firmware/sysfb: Fix EFI/VESA format selection]. However they report > lfb_depth correctly for those modes. Keep

Re: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-19 Thread Christian König
Am 19.04.23 um 06:51 schrieb hackyzh002: The type of size is unsigned int, if size is 0x4000, there will be an integer overflow, size will be zero after size *= sizeof(uint32_t), will cause uninitialized memory to be referenced later. Signed-off-by: hackyzh002 ---

Re: BUG: KASAN: null-ptr-deref in drm_sched_job_cleanup+0x96/0x290 [gpu_sched]

2023-04-19 Thread Christian König
Am 19.04.23 um 09:00 schrieb Mikhail Gavrilov: Christian? I'm already looking into this, but can't figure out why we run into problems here. What happens is that a CS is aborted without sending the job to the scheduler and in this case the cleanup function doesn't seem to work.

Re: [PATCH 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-19 Thread kernel test robot
to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/hackyzh002/drm-amdgpu-Fix-integer-overflow-in-amdgpu_cs_pass1/20230419-125344 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch

Re: [PATCH v2] firmware/sysfb: Fix VESA format selection

2023-04-19 Thread Thomas Zimmermann
Hi Am 19.04.23 um 06:48 schrieb Pierre Asselin: Some legacy BIOSes report no reserved bits in their 32-bit rgb mode, breaking the calculation of bits_per_pixel in commit f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]. However they report lfb_depth correctly for those modes. Keep

Re: BUG: KASAN: null-ptr-deref in drm_sched_job_cleanup+0x96/0x290 [gpu_sched]

2023-04-19 Thread Mikhail Gavrilov
Christian? ❯ /usr/src/kernels/6.3.0-0.rc7.56.fc39.x86_64/scripts/faddr2line /lib/debug/lib/modules/6.3.0-0.rc7.56.fc39.x86_64/kernel/drivers/gpu/drm/scheduler/gpu-sched.ko.debug drm_sched_job_cleanup+0x9a drm_sched_job_cleanup+0x9a/0x130: drm_sched_job_cleanup at

Re: [PATCH] PCI: Add ASPEED vendor ID

2023-04-19 Thread Thomas Zimmermann
Hi Am 19.04.23 um 00:57 schrieb Patrick McLean: Currently the ASPEED PCI vendor ID is defined in drivers/gpu/drm/ast/ast_drv.c, move that to include/linux/pci_ids.h with all the rest of the PCI vendor ID definitions. Rename the definition to follow the format that the other definitions follow.

Re: [PATCH 2/4] mei: gsc_proxy: add gsc proxy driver

2023-04-19 Thread Teres Alexis, Alan Previn
On Wed, 2023-03-29 at 09:56 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > Add GSC proxy driver. It to allows messaging between GSC component > on Intel on board graphics card and CSE device. alan:nit: isn't "Intel integrated GPU" clearer than "Intel on-board graphics

Re: [PATCH net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-19 Thread Heiner Kallweit
On 19.04.2023 02:10, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN using magic packets > -

Re: [PATCH] drm/mediatek: Clarify/finish documentation for some driver structures

2023-04-19 Thread AngeloGioacchino Del Regno
Il 21/03/23 12:14, AngeloGioacchino Del Regno ha scritto: The documentation for some of the driver structures in mediatek-drm was set to be kerneldoc but some code additions didn't actually update the comments accordingly and this caused triggering some warnings. Add comments for the remaining

<    1   2   3