Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()

2023-06-15 Thread Uwe Kleine-König
Hello, On Sun, Jun 11, 2023 at 10:27:40PM +0200, Uwe Kleine-König wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") >

Re: [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers

2023-06-15 Thread Zack Rusin
On Thu, 2023-06-15 at 11:31 +0200, Thomas Zimmermann wrote: > Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() > for all DRM drivers. Even drivers that do not support PRIME import > or export of dma-bufs can now import their own buffer objects. This > is required by some

Re: [PATCH v3] drm/vkms: Add support to 1D gamma LUT

2023-06-15 Thread kernel test robot
Hi Arthur, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.4-rc6 next-20230615

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-15 Thread Doug Anderson
Hi, On Thu, Jun 15, 2023 at 12:49 AM Neil Armstrong wrote: > > On 14/06/2023 22:58, Linus Walleij wrote: > > On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold > > wrote: > > > >> I'm still quite confused about what exactly is supposed to be in > >> (un)prepare and what in enable/disable. I've

[PATCH v9 20/20] drm/msm/a6xx: Add A610 speedbin support

2023-06-15 Thread Konrad Dybcio
A610 is implemented on at least three SoCs: SM6115 (bengal), SM6125 (trinket) and SM6225 (khaje). Trinket does not support speed binning (only a single SKU exists) and we don't yet support khaje upstream. Hence, add a fuse mapping table for bengal to allow for per-chip frequency limiting.

[PATCH v9 19/20] drm/msm/a6xx: Add A619_holi speedbin support

2023-06-15 Thread Konrad Dybcio
A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just that to enable frequency limiting on these

[PATCH v9 15/20] drm/msm/a6xx: Add A610 support

2023-06-15 Thread Konrad Dybcio
A610 is one of (if not the) lowest-tier SKUs in the A6XX family. It features no GMU, as it's implemented solely on SoCs with SMD_RPM. What's more interesting is that it does not feature a VDDGX line either, being powered solely by VDDCX and has an unfortunate hardware quirk that makes its reset

[PATCH v9 14/20] drm/msm/a6xx: Add support for A619_holi

2023-06-15 Thread Konrad Dybcio
A619_holi is a GMU-less variant of the already-supported A619 GPU. It's present on at least SM4350 (holi) and SM6375 (blair). No mesa changes are required. Add the required kernel-side support for it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 27

[PATCH v9 18/20] drm/msm/a6xx: Use adreno_is_aXYZ macros in speedbin matching

2023-06-15 Thread Konrad Dybcio
Before transitioning to using per-SoC and not per-Adreno speedbin fuse values (need another patchset to land elsewhere), a good improvement/stopgap solution is to use adreno_is_aXYZ macros in place of explicit revision matching. Do so to allow differentiating between A619 and A619_holi.

[PATCH v9 17/20] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching

2023-06-15 Thread Konrad Dybcio
The GPU can only be one at a time. Turn a series of ifs into if + elseifs to save some CPU cycles. Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v9 06/20] drm/msm/a6xx: Move a6xx_bus_clear_pending_transactions to a6xx_gpu

2023-06-15 Thread Konrad Dybcio
This function is responsible for telling the GPU to halt transactions on all of its relevant buses, drain them and leave them in a predictable state, so that the GPU can be e.g. reset cleanly. Move the function to a6xx_gpu.c, remove the static keyword and add a prototype in a6xx_gpu.h to

[PATCH v9 11/20] drm/msm/a6xx: Move CX GMU power counter enablement to hw_init

2023-06-15 Thread Konrad Dybcio
Since the introduction of A6xx support, we've been enabling the CX GMU power counter 0 in a bit of a weird spot. Move it to hw_init so that GMU wrapper GPUs can reuse the same code paths. As a bonus, this order makes it easier to compare mainline and downstream register access traces.

[PATCH v9 16/20] drm/msm/a6xx: Fix some A619 tunables

2023-06-15 Thread Konrad Dybcio
Adreno 619 expects some tunables to be set differently. Make up for it. Fixes: b7616b5c69e6 ("drm/msm/adreno: Add A619 support") Reviewed-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- 1 file changed, 5

[PATCH v9 13/20] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations

2023-06-15 Thread Konrad Dybcio
A610 and A619_holi don't support the feature. Disable it to make the GPU stop crashing after almost each and every submission - the received data on the GPU end was simply incomplete in garbled, resulting in almost nothing being executed properly. Extend the disablement to adreno_has_gmu_wrapper,

[PATCH v9 12/20] drm/msm/a6xx: Introduce GMU wrapper support

2023-06-15 Thread Konrad Dybcio
Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs but don't implement the associated GMUs. This is due to the fact that the GMU directly pokes at RPMh. Sadly, this means we have to take care of enabling & scaling power rails, clocks and bandwidth ourselves. Reuse existing

[PATCH v9 09/20] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init

2023-06-15 Thread Konrad Dybcio
Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also need REG_A6XX_GBIF_HALT to be set to 0. This is typically done automatically on successful GX collapse, but in case that fails, we should take care of it. Also, add a memory barrier to ensure it's gone through before jumping

[PATCH v9 10/20] drm/msm/a6xx: Extend and explain UBWC config

2023-06-15 Thread Konrad Dybcio
Rename lower_bit to hbb_lo and explain what it signifies. Add explanations (wherever possible to other tunables). Port setting min_access_length, ubwc_mode and hbb_hi from downstream. Reviewed-by: Rob Clark Reviewed-by: Akhil P Oommen Signed-off-by: Konrad Dybcio ---

[PATCH v9 04/20] drm/msm/a6xx: Remove static keyword from sptprac en/disable functions

2023-06-15 Thread Konrad Dybcio
These two will be reused by at least A619_holi in the non-gmu paths. Turn them non-static them to make it possible. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 ++-- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 ++ 2 files changed, 4

[PATCH v9 07/20] drm/msm/a6xx: Improve a6xx_bus_clear_pending_transactions()

2023-06-15 Thread Konrad Dybcio
Unify the indentation and explain the cryptic 0xF value. Reviewed-by: Akhil P Oommen Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c

[PATCH v9 08/20] drm/msm/a6xx: Add a helper for software-resetting the GPU

2023-06-15 Thread Konrad Dybcio
Introduce a6xx_gpu_sw_reset() in preparation for adding GMU wrapper GPUs and reuse it in a6xx_gmu_force_off(). This helper, contrary to the original usage in GMU code paths, adds a readback+delay sequence to ensure that the reset is never deasserted too quickly due to e.g. OoO execution going

[PATCH v9 05/20] drm/msm/a6xx: Move force keepalive vote removal to a6xx_gmu_force_off()

2023-06-15 Thread Konrad Dybcio
As pointed out by Akhil during the review process of GMU wrapper introduction [1], it makes sense to move this write into the function that's responsible for forcibly shutting the GMU off. It is also very convenient to move this to GMU-specific code, so that it does not have to be guarded by an

[PATCH v9 01/20] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-06-15 Thread Konrad Dybcio
The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks we'd normally assign to the GMU as if they were a part of the GMU, even though they are not". It's a (good) software representation of the GMU_CX and GMU_GX register spaces within the GPUSS that helps us programatically treat

[PATCH v9 03/20] drm/msm/adreno: Use adreno_is_revn for A690

2023-06-15 Thread Konrad Dybcio
The adreno_is_revn rework came at the same time as A690 introduction and that resulted in it not covering all cases. Fix it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v9 02/20] dt-bindings: display/msm/gmu: Add GMU wrapper

2023-06-15 Thread Konrad Dybcio
The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks we'd normally assign to the GMU as if they were a part of the GMU, even though they are not". It's a (good) software representation of the GMU_CX and GMU_GX register spaces within the GPUSS that helps us programatically treat

[PATCH v9 00/20] GMU-less A6xx support (A610, A619_holi)

2023-06-15 Thread Konrad Dybcio
v8 -> v9: - Re-pick-up Krzysztof's lost r-b tag (I messed up, sorry) - Rebase on constifying-adreno_is_aXYZ and A690 changes - Fix A610 inactive period - Move the stray A619 register write from A610 patch to the A619 patch - Add one more commit, cleaning up A690 addition for git context (for

Re: [PATCH v2 06/22] drm/msm/dpu: simplify peer LM handling

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:45, Dmitry Baryshkov wrote: > For each LM there is at max 1 peer LM which can be driven by the same > CTL, so there no need to have a mask instead of just an ID of the peer > LM. > > Signed-off-by: Dmitry Baryshkov Nit: I think you can describe the the patch contents in the

[PATCH] Remove incorrect hard coded cache coherrency setting

2023-06-15 Thread Zhanjun Dong
The previouse i915_gem_object_create_internal already set it with proper value before function return. This hard coded setting is incorrect for platforms like MTL, thus need to be removed. Signed-off-by: Zhanjun Dong --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 -- 1 file changed, 2

Re: [PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-15 Thread Marijn Suijten
On 2023-06-15 14:31:22, Dmitry Baryshkov wrote: > > On Tue, 13 Jun 2023 03:09:39 +0300, Dmitry Baryshkov wrote: > > Having a macro with 10 arguments doesn't seem like a good idea. It makes > > it inherently harder to compare the actual structure values. Also this > > leads to adding macros

Re: [PATCH v2 05/22] drm/msm/dpu: always use MSM_DP/DSI_CONTROLLER_n

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:44, Dmitry Baryshkov wrote: > In several catalog entries we did not use existing MSM_DP_CONTROLLER_n > constants. Fill them in. Also use freshly defined MSM_DSI_CONTROLLER_n > for DSI interfaces. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH v2 04/22] drm/msm: enumerate DSI interfaces

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:43, Dmitry Baryshkov wrote: > Follow the DP example and define MSM_DSI_CONTROLLER_n enumeration. > > Signed-off-by: Dmitry Baryshkov Nice, that'll be cleaner. Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/msm_drv.h | 8 +++- > 1 file changed, 7

Re: [PATCH v2 03/22] drm/msm/dpu: remove unused INTF_NONE interfaces

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:42, Dmitry Baryshkov wrote: > sm6115 and qcm2290 do not have INTF_0. Drop corresponding interface > definitions. As Abhinav said, add sm6375. If it wasn't for sc8280xp using INTF_NONE for fake MST, we could have dropped INTF_NONE and the special-cases in dpu_hw_interrupts.c

Re: [PATCH v2 02/22] drm/msm/dpu: correct MERGE_3D length

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:41, Dmitry Baryshkov wrote: > Each MERGE_3D block has just two registers. Correct the block length > accordingly. > > Fixes: 4369c93cf36b ("drm/msm/dpu: initial support for merge3D hardware > block") > Signed-off-by: Dmitry Baryshkov Indeed, and that patch wasn't even

Re: [PATCH v2 01/22] drm/msm/dpu: fix sc7280 and sc7180 PINGPONG done interrupts

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:40, Dmitry Baryshkov wrote: > During IRQ conversion we have lost the PP_DONE interrupts for sc7280 > platform. This was left unnoticed, because this interrupt is only used > for CMD outputs and probably no sc7[12]80 systems use DSI CMD panels. > > Fixes: 667e9985ee24

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-06-15 Thread Dave Airlie
On Wed, 3 May 2023 at 22:23, Lisovskiy, Stanislav wrote: > > On Wed, May 03, 2023 at 02:07:04PM +0300, Ville Syrjälä wrote: > > On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > > > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä >

Re: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences

2023-06-15 Thread kernel test robot
: ac9a78681b921877518763ba0e89202254349d1b patch link: https://lore.kernel.org/r/20230615-fix-boe-tv101wum-nl6-v1-1-8ac378405fb7%40linaro.org patch subject: [PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences config: alpha-allyesconfig (https://download.01.org/0day-ci

Re: [PATCH v2 00/22]drm/msm/dpu: another catalog rework

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:39, Dmitry Baryshkov wrote: > Having a macro with 10 arguments doesn't seem like a good idea. It makes > it inherently harder to compare the actual structure values. Also this > leads to adding macros covering varieties of the block. > > As it was previously discussed, inline

Re: [PATCH v2 16/21] drm/msm/dpu: inline DSC_BLK macros

2023-06-15 Thread Dmitry Baryshkov
On 16/06/2023 01:05, Marijn Suijten wrote: On 2023-06-13 03:09:56, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Signed-off-by: Dmitry

Re: [PATCH v2 16/21] drm/msm/dpu: inline DSC_BLK macros

2023-06-15 Thread Marijn Suijten
On 2023-06-13 03:09:56, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH v3] drm/vkms: Add support to 1D gamma LUT

2023-06-15 Thread kernel test robot
Hi Arthur, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.4-rc6 next-20230615

Re: [PATCH v2 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-15 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Hello, > > While working on adding support for the SSD132X family of 4-bit grayscale > Solomon OLED panel controllers, I noticed a few things in the driver that > can be improved and make extending to support other chip families easier. > > I've split the

Re: [RFC] Plane color pipeline KMS uAPI

2023-06-15 Thread Christopher Braga
On 6/14/2023 5:00 AM, Pekka Paalanen wrote: On Tue, 13 Jun 2023 12:29:55 -0400 Christopher Braga wrote: On 6/13/2023 4:23 AM, Pekka Paalanen wrote: On Mon, 12 Jun 2023 12:56:57 -0400 Christopher Braga wrote: On 6/12/2023 5:21 AM, Pekka Paalanen wrote: On Fri, 9 Jun 2023 19:11:25

Re: [PATCH v8 10/18] drm/msm/a6xx: Introduce GMU wrapper support

2023-06-15 Thread Konrad Dybcio
On 10.06.2023 00:06, Akhil P Oommen wrote: > On Mon, May 29, 2023 at 03:52:29PM +0200, Konrad Dybcio wrote: >> >> Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs >> but don't implement the associated GMUs. This is due to the fact that >> the GMU directly pokes at RPMh. Sadly,

Re: [PATCH v3] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-15 Thread Dong, Zhanjun
V3 is to follow John's suggestion option 1. The better option is in discussion and might have boarder impact. Meanwhile we can start with option 1, check CI system report and see if issue getting better. Regards, Zhanjun Dong On 2023-06-15 5:15 p.m., Zhanjun Dong wrote: This attempts to

[PATCH v1] drm/i915/gsc: Fix intel_gsc_uc_fw_proxy_init_done with directed wakerefs

2023-06-15 Thread Alan Previn
intel_gsc_uc_fw_proxy_init_done is used by a few code paths and usages. However, certain paths need a wakeref while others can't take a wakeref such as from the runtime_pm_resume callstack. Add a param into this helper to allow callers to direct whether to take the wakeref or not. This resolves

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-06-15 Thread Cyril Brulebois
Hi Rob, Rob Herring (2023-06-15): > On Thu, Jun 15, 2023 at 03:21:07PM +0200, Michal Suchánek wrote: > > At the time this was proposed it was said that "of-display", is wrong, > > and that "of-display.0" must be used for the first device instead, and > > if something breaks an alias can be

Re: [PATCH v8 07/18] drm/msm/a6xx: Add a helper for software-resetting the GPU

2023-06-15 Thread Akhil P Oommen
On Thu, Jun 15, 2023 at 10:59:23PM +0200, Konrad Dybcio wrote: > > On 15.06.2023 22:11, Akhil P Oommen wrote: > > On Thu, Jun 15, 2023 at 12:34:06PM +0200, Konrad Dybcio wrote: > >> > >> On 6.06.2023 19:18, Akhil P Oommen wrote: > >>> On Mon, May 29, 2023 at 03:52:26PM +0200, Konrad Dybcio wrote:

[PATCH v3] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-15 Thread Zhanjun Dong
This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-15 Thread Alex Deucher
On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/13 11:01, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the > > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > >

Re: [PATCH v8 07/18] drm/msm/a6xx: Add a helper for software-resetting the GPU

2023-06-15 Thread Konrad Dybcio
On 15.06.2023 22:11, Akhil P Oommen wrote: > On Thu, Jun 15, 2023 at 12:34:06PM +0200, Konrad Dybcio wrote: >> >> On 6.06.2023 19:18, Akhil P Oommen wrote: >>> On Mon, May 29, 2023 at 03:52:26PM +0200, Konrad Dybcio wrote: Introduce a6xx_gpu_sw_reset() in preparation for adding GMU

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-06-15 Thread Rob Herring
On Tue, Jun 13, 2023 at 9:20 AM Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > > Signed-off-by: Sarah Walker > --- > .../devicetree/bindings/gpu/img,powervr.yaml | 71 +++ > MAINTAINERS

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

2023-06-15 Thread Peter Xu
On Thu, Jun 15, 2023 at 09:15:26PM +0100, Matthew Wilcox wrote: > On Thu, Jun 15, 2023 at 03:33:12PM -0400, Peter Xu wrote: > > My question is whether page_zonenum() is ready for taking all kinds of tail > > pages? > > > > Zone device tail pages all look fine, per memmap_init_zone_device(). The

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

2023-06-15 Thread Matthew Wilcox
On Thu, Jun 15, 2023 at 03:33:12PM -0400, Peter Xu wrote: > My question is whether page_zonenum() is ready for taking all kinds of tail > pages? > > Zone device tail pages all look fine, per memmap_init_zone_device(). The > question was other kinds of usual compound pages, like either thp or >

[PATCH 1/2] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences

2023-06-15 Thread Linus Walleij
The boe-tv101wum-nl6 is reinventing the mechanism to send command sequences that we usually nix during review, but I missed this one so fixing it up myself. Also use the explicit function calls to mipi_dsi_dcs_exit_sleep_mode() and mipi_dsi_dcs_set_display_on() instead of reimplementing them with

[PATCH 2/2] drm/panel: boe-tv101wum-nl6: Drop surplus prepare tracking

2023-06-15 Thread Linus Walleij
The DRM panel core already keeps track of if the panel is already prepared so do not reimplement this. Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c

[PATCH 0/2] Fix up the boe-tv101wum-nl6 panel driver

2023-06-15 Thread Linus Walleij
: Drop surplus prepare tracking drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2420 1 file changed, 1193 insertions(+), 1227 deletions(-) --- base-commit: ac9a78681b921877518763ba0e89202254349d1b change-id: 20230615-fix-boe-tv101wum-nl6-6aa3fab22b44 Best regards

Re: [PATCH v2 2/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-15 Thread Rob Herring
On Thu, Jun 15, 2023 at 12:35:25PM +0200, Noralf Trønnes wrote: > > > On 6/14/23 14:32, Leonard Göhrs wrote: > > The Shineworld LH133K is a 1.3" 240x240px RGB LCD with a MIPI DBI > > compatible SPI interface. > > The initialization procedure is quite basic with the exception of > > requiring

[PATCH 5/5] drm/bridge: tc358762: Handle HS/VS polarity

2023-06-15 Thread Marek Vasut
Add support for handling the HS/VS sync signals polarity in the bridge driver, otherwise e.g. DSIM bridge feeds the TC358762 inverted polarity sync signals and the image is shifted to the left, up, and wobbly. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie

[PATCH 4/5] drm/bridge: tc358762: Guess the meaning of LCDCTRL bits

2023-06-15 Thread Marek Vasut
The register content and behavior is very similar to TC358764 VP_CTRL. All the bits except for unknown bit 6 also seem to match, even though the datasheet is just not available. Add a comment and reuse the bit definitions. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc:

[PATCH 2/5] drm/bridge: tc358762: Switch to atomic ops

2023-06-15 Thread Marek Vasut
Switch the bridge driver over to atomic ops. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Neil Armstrong Cc: Robert Foss Cc: dri-devel@lists.freedesktop.org ---

[PATCH 3/5] drm/bridge: tc358762: Instruct DSI host to generate HSE packets

2023-06-15 Thread Marek Vasut
This bridge seems to need the HSE packet, otherwise the image is shifted up and corrupted at the bottom. This makes the bridge work with Samsung DSIM on i.MX8MM and i.MX8MP. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas

[PATCH 1/5] drm/bridge: tc358762: Split register programming from pre-enable to enable

2023-06-15 Thread Marek Vasut
Move the register programming part, which actually enables the bridge and makes it push data out of its DPI side, into the enable callback. The DSI host like DSIM may not be able to transmit commands in pre_enable, moving the register programming into enable assures it can transmit commands.

[PATCH] drm/bridge: tc358764: Use BIT() macro for actual bits

2023-06-15 Thread Marek Vasut
None of these four bits are bitfields, use BIT() macro and treat them as bits. No functional change. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Laurent Pinchart Cc: Neil Armstrong Cc: Robert Foss Cc:

[PATCH] drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags

2023-06-15 Thread Marek Vasut
Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC flags. Those are used by various bridges in the pipeline to correctly configure its sync signals polarity. Fixes: d69de69f2be1 ("drm/panel: simple: Add Powertip PH800480T013 panel") Signed-off-by: Marek Vasut --- Cc: Daniel

[PATCH] drm: bridge: samsung-dsim: Drain command transfer FIFO before transfer

2023-06-15 Thread Marek Vasut
Wait until the command transfer FIFO is empty before loading in the next command. The previous behavior where the code waited until command transfer FIFO was not full suffered from transfer corruption, where the last command in the FIFO could be overwritten in case the FIFO indicates not full, but

Re: [PATCH v8 07/18] drm/msm/a6xx: Add a helper for software-resetting the GPU

2023-06-15 Thread Akhil P Oommen
On Thu, Jun 15, 2023 at 12:34:06PM +0200, Konrad Dybcio wrote: > > On 6.06.2023 19:18, Akhil P Oommen wrote: > > On Mon, May 29, 2023 at 03:52:26PM +0200, Konrad Dybcio wrote: > >> > >> Introduce a6xx_gpu_sw_reset() in preparation for adding GMU wrapper > >> GPUs and reuse it in

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-06-15 Thread Rob Herring
On Thu, Jun 15, 2023 at 03:21:07PM +0200, Michal Suchánek wrote: > Hello, > > On Thu, Jun 15, 2023 at 03:06:28PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 15.06.23 um 15:03 schrieb Linux regression tracking (Thorsten Leemhuis): > > > On 16.04.23 14:34, Salvatore Bonaccorso wrote: > > > >

[PATCH v3] drm/vkms: Add support to 1D gamma LUT

2023-06-15 Thread Arthur Grillo
Support a 1D gamma LUT with interpolation for each color channel on the VKMS driver. Add a check for the LUT length by creating vkms_atomic_check(). Tested with: igt@kms_color@gamma igt@kms_color@legacy-gamma igt@kms_color@invalid-gamma-lut-sizes v2: - Add interpolation between the values of

Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

2023-06-15 Thread Linus Walleij
Hi Paulo, thanks for your patch! Overall this looks very good. I doubt that the display controller is actually by Fannal, but I guess you tried to find out? We usually try to identify the underlying display controller so the driver can be named after it and reused for more display panels. Some

Re: [PATCH v9 02/14] mm: move page zone helpers from mm.h to mmzone.h

2023-06-15 Thread Peter Xu
Hello, all, On Fri, Jul 15, 2022 at 10:05:09AM -0500, Alex Sierra wrote: > +static inline enum zone_type page_zonenum(const struct page *page) > +{ > + ASSERT_EXCLUSIVE_BITS(page->flags, ZONES_MASK << ZONES_PGSHIFT); > + return (page->flags >> ZONES_PGSHIFT) & ZONES_MASK; > +} Sorry to

Re: [PATCH 3/3] drm/amdgpu: use new scheduler accounting

2023-06-15 Thread Luben Tuikov
On 2023-06-15 07:56, Christian König wrote: > Instead of implementing this ourself. Spellcheck: "ourselves". Acked-by: Luben Tuikov Regards, Luben > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 52 - > 1 file changed, 8

Re: [PATCH 1/3] drm/scheduler: implement hw time accounting

2023-06-15 Thread Luben Tuikov
On 2023-06-15 07:56, Christian König wrote: > Multiple drivers came up with the requirement to measure how > much time each submission spend on the hw. "spends" > > A previous attempt of accounting this had to be reverted because > hw submissions can live longer than the entity originally >

Re: [PATCH 2/2] drm/amdgpu: Move clocks closer to its only usage in amdgpu_parse_cg_state()

2023-06-15 Thread Alex Deucher
Applied the series. Thanks! Alex On Thu, Jun 15, 2023 at 1:06 PM Nathan Chancellor wrote: > > After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), > there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is > disabled: > >

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-06-15 Thread Cyril Brulebois
Linux regression tracking (Thorsten Leemhuis) (2023-06-15): > No reply to my status inquiry[1] a few weeks ago, so I have to assume > nobody cares anymore. If somebody still cares, holler! I still care about a proper bugfix, for upstream and for the Debian distribution, and so does Salvatore.

Re: [RFC PATCH v2 00/18] Add DRM CRTC 3D LUT interface

2023-06-15 Thread Jacopo Mondi
Hi Pekka thanks for the reply On Thu, Jun 15, 2023 at 10:14:05AM +0300, Pekka Paalanen wrote: > On Tue, 13 Jun 2023 17:43:55 +0200 > Jacopo Mondi wrote: > > > Hello > > > >I'm completing the support for 3D LUT on R-Car DU peripheral > > and I have used this series as a base. > > > > I'm

Re: [PATCH] dt-bindings: display: Add missing property types

2023-06-15 Thread Rob Herring
On Tue, 13 Jun 2023 14:11:14 -0600, Rob Herring wrote: > A couple of display bridge properties are missing a type definition. Add > the types to them. > > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/display/bridge/analogix,dp.yaml | 1 + >

Re: [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-15 Thread Dixit, Ashutosh
On Fri, 09 Jun 2023 15:02:52 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > We were skipping when min_softlimit was equal to RPn. We need to apply > it rergardless as efficient frequency will push the SLPC min to RPe. > This will break scenarios where user sets a min softlimit < RPe before > reset

Re: [PATCH] drm/amd/pm: remove unneeded variable

2023-06-15 Thread Alex Deucher
Applied, but please check your mailer. I had to manually fix this up. Alex On Wed, Jun 14, 2023 at 3:21 AM wrote: > > fix the following coccicheck warning: > > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:1657:14-18: Unneeded > variable: "size". > > Signed-off-by: Mingtong Bao > --- >

Re: [PATCH] drm/amdgpu: remove unneeded variable

2023-06-15 Thread Alex Deucher
On Wed, Jun 14, 2023 at 3:20 AM wrote: > > fix the following coccicheck warning: > > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c:1156:5-11: > Unneeded variable: "result". > This variable is used and the code fails to compile with it removed. Alex > Signed-off-by: Mingtong Bao >

Re: [PATCH v2 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

2023-06-15 Thread Jocelyn Falempe
On 15/06/2023 16:24, Thomas Zimmermann wrote: Hi Jocelyn Am 31.05.23 um 11:21 schrieb Jocelyn Falempe: Even if the transfer is not faster, it brings significant improvement in latencies and CPU usage. CPU usage drops from 100% of one core to 3% when continuously refreshing the screen. I

Re: [PATCH] amd/display/dc:remove repeating expression

2023-06-15 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 14, 2023 at 1:36 AM Ammar Faizi wrote: > > On 6/14/23 10:49 AM, Wang Ming wrote: > > Identify issues that arise by using the tests/doubletest.cocci > > semantic patch.Need to remove duplicate expression in if statement. > > > > Signed-off-by: Wang Ming > >

[PATCH 0/2] drm/amdgpu: Fix instances of -Wunused-const-variable with CONFIG_DEBUG_FS=n

2023-06-15 Thread Nathan Chancellor
| 76 - 2 files changed, 38 insertions(+), 40 deletions(-) --- base-commit: d297eedf83f5af96751c0da1e4355c19244a55a2 change-id: 20230615-amdgpu-wunused-const-variable-wo-debugfs-308ce8e17329 Best regards, -- Nathan Chancellor

[PATCH 2/2] drm/amdgpu: Move clocks closer to its only usage in amdgpu_parse_cg_state()

2023-06-15 Thread Nathan Chancellor
After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is disabled: drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:38:34: error: unused variable 'clocks' [-Werror,-Wunused-const-variable] 38 | static const

[PATCH 1/2] drm/amdgpu: Remove CONFIG_DEBUG_FS guard around body of amdgpu_rap_debugfs_init()

2023-06-15 Thread Nathan Chancellor
After commit a25a9dae2067 ("drm/amd/amdgpu: enable W=1 for amdgpu"), there is an instance of -Wunused-const-variable when CONFIG_DEBUG_FS is disabled: drivers/gpu/drm/amd/amdgpu/amdgpu_rap.c:110:37: error: unused variable 'amdgpu_rap_debugfs_ops' [-Werror,-Wunused-const-variable] 110 |

Re: [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-15 Thread Danilo Krummrich
On 6/7/23 00:31, Danilo Krummrich wrote: Maple Tree: - Maple tree uses the 'unsinged long' type for node entries. While this works for 64bit, it's incompatible with the DRM GPUVA Manager on 32bit, since the DRM GPUVA Manager uses the u64 type and so do drivers using it.

Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-06-15 Thread Bjorn Andersson
On Tue, Jun 13, 2023 at 03:30:10PM -0700, Bjorn Andersson wrote: > On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote: > > Convert TI LP855X backlight controller bindings from TXT to YAML and, > > while we're at it, rework some of the code related to PWM handling. > > Also correct existing DTS

Re: [Intel-xe] [RFC PATCH 1/1] drm/xe: Introduce function pointers for MMIO functions

2023-06-15 Thread Matt Roper
On Thu, Jun 15, 2023 at 04:04:18PM +0300, Oded Gabbay wrote: > On Thu, Jun 15, 2023 at 3:01 AM Matt Roper wrote: > > > > On Mon, Jun 12, 2023 at 06:31:57PM +0200, Francois Dugast wrote: > > > On Thu, Jun 08, 2023 at 10:35:29AM -0700, Lucas De Marchi wrote: > > > > On Fri, Jun 02, 2023 at

Re: [PATCH v6 3/8] drm: bridge: Cadence: Add MHDP8501 DP driver

2023-06-15 Thread Sam Ravnborg
Hi Sandor, On Thu, Jun 15, 2023 at 09:38:13AM +0800, Sandor Yu wrote: > Add a new DRM DisplayPort bridge driver for Candence MHDP8501 > used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort > standards according embedded Firmware running in the uCPU. > > For iMX8MQ SOC, the DisplayPort

Re: [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-06-15 Thread Danilo Krummrich
On 6/14/23 09:58, Donald Robson wrote: On Tue, 2023-06-13 at 16:20 +0200, Danilo Krummrich wrote: I'm definitely up improving the existing documentation. Anything in particular you think should be described in more detail? - Danilo Hi Danilo, As I said, with inexperience it's possible I

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-15 Thread Andy Shevchenko
On Fri, May 12, 2023 at 09:29:23AM -0700, Lucas De Marchi wrote: > On Fri, May 12, 2023 at 02:14:19PM +0300, Andy Shevchenko wrote: > > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > > > Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > > > masks for

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-15 Thread Andy Shevchenko
On Fri, May 12, 2023 at 02:45:19PM +0300, Jani Nikula wrote: > On Fri, 12 May 2023, Andy Shevchenko > wrote: > > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: > >> On Fri, 12 May 2023, Andy Shevchenko > >> wrote: > >> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi

[PATCH] drm/bridge: tc358764: Fix debug print parameter order

2023-06-15 Thread Marek Vasut
The debug print parameters were swapped in the output and they were printed as decimal values, both the hardware address and the value. Update the debug print to print the parameters in correct order, and use hexadecimal print for both address and value. Fixes: f38b7cca6d0e ("drm/bridge:

Re: [PATCH] accel/qaic: Call DRM helper function to destroy prime GEM

2023-06-15 Thread Jeffrey Hugo
On 6/15/2023 1:05 AM, Christian König wrote: Am 14.06.23 um 18:15 schrieb Jeffrey Hugo: From: Pranjal Ramajor Asha Kanojiya smatch warning: drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:     dereferencing freed memory 'obj->import_attach' obj->import_attach is

Re: [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers

2023-06-15 Thread Thomas Zimmermann
Hi Am 15.06.23 um 16:50 schrieb Simon Ser: On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann wrote: Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() for all DRM drivers. Even drivers that do not support PRIME import or export of dma-bufs can now import their own

Re: [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers

2023-06-15 Thread Simon Ser
On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann wrote: > Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() > for all DRM drivers. Even drivers that do not support PRIME import > or export of dma-bufs can now import their own buffer objects. This > is required by some

Re: [PATCH 1/3] drm: Enable PRIME import/export for all drivers

2023-06-15 Thread Simon Ser
On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann wrote: > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 89e2706cac561..10af1899236a0 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -309,6 +309,9 @@ struct drm_driver { >* >*

[PATCH v15 2/2] MAINTAINERS: add maintainers for DRM LOONGSON driver

2023-06-15 Thread Sui Jingfeng
From: Sui Jingfeng This patch add Sui Jingfeng as maintainer to drm/loongson driver. Signed-off-by: Sui Jingfeng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 225e20582a96..70262eb6e614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v15 0/2] drm: Add kms driver for loongson display controller

2023-06-15 Thread Sui Jingfeng
From: Sui Jingfeng Loongson display controller IP has been integrated in both Loongson north bridge chipset (ls7a1000/ls7a2000) and Loongson SoCs (ls2k1000/ls2k2000). It has even been included in Loongson's BMC products. It has two display pipes, and each display pipe supports a primary plane

Re: [PATCH] drm/bridge: ps8640: Drop the ability of ps8640 to fetch the EDID

2023-06-15 Thread Doug Anderson
Hi, On Thu, Jun 15, 2023 at 1:47 AM Pin-yen Lin wrote: > > Hi Doug, > > On Thu, Jun 15, 2023 at 5:31 AM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Jun 14, 2023 at 1:22 AM AngeloGioacchino Del Regno > > wrote: > > > > > > Il 13/06/23 01:32, Douglas Anderson ha scritto: > > > > In order to

Re: [PATCH drm-next v4 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-15 Thread Danilo Krummrich
On Tue, Jun 13, 2023 at 08:29:35PM -0400, Liam R. Howlett wrote: > * Danilo Krummrich [230606 18:32]: > > Add infrastructure to keep track of GPU virtual address (VA) mappings > > with a decicated VA space manager implementation. > > > > New UAPIs, motivated by Vulkan sparse memory bindings

Re: [PATCH v2 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

2023-06-15 Thread Thomas Zimmermann
Hi Jocelyn Am 31.05.23 um 11:21 schrieb Jocelyn Falempe: Even if the transfer is not faster, it brings significant improvement in latencies and CPU usage. CPU usage drops from 100% of one core to 3% when continuously refreshing the screen. I tried your patchset on a HP Proliant server with a

  1   2   >