Re: [PATCH v2] drm/msm/adreno: Assign revn to A635

2023-07-01 Thread Dmitry Baryshkov
On Sat, 1 Jul 2023 at 18:50, Rob Clark wrote: > > On Fri, Jun 30, 2023 at 4:12 PM Konrad Dybcio > wrote: > > > > Recently, a WARN_ON() was introduced to ensure that revn is filled before > > adreno_is_aXYZ is called. This however doesn't work very well when revn is > > 0 by design (such as for

Re: [PATCH] drm/msm/adreno: warn if GPU revision is not known yet

2023-07-01 Thread Rob Clark
On Sat, Jul 1, 2023 at 10:15 AM Rob Clark wrote: > > From: Rob Clark > > The commit 010c8bbad2cb ("drm: msm: adreno: Disable preemption on Adreno > 510") tried to check GPU's revn before revn being set. Add WARN_ON_ONCE > to prevent such bugs from happening again. A separate helper is >

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Arnd Bergmann
On Sat, Jul 1, 2023, at 23:44, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB > and so

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Randy Dunlap
Hi, Does this series apply on top of the previous series or on what? On 7/1/23 14:44, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has

Re: [PATCH v2 2/2] drm: Make fbdev emulation select FB_CORE instead of depends on FB

2023-07-01 Thread Arnd Bergmann
On Sat, Jul 1, 2023, at 23:44, Javier Martinez Canillas wrote: > Now that the fbdev core has been split in FB_CORE and FB, make DRM fbdev > emulation layer to just select the former. > > This allows to disable the CONFIG_FB option if is not needed, which will > avoid the need to explicitly disable

Re: [PATCH 1/1] backlight: apple_bl_usb: Add Apple Studio Display support

2023-07-01 Thread Sam Ravnborg
Hi Julius. Thanks for posting this. I few nits in the following where you as the author decide what to ignore and what to update. Sam On Sat, Jul 01, 2023 at 02:08:03PM +0200, Julius Zint wrote: > The Apple Studio Display does not have any physical buttons and the only > way to get or

[PATCH v2 2/2] drm: Make fbdev emulation select FB_CORE instead of depends on FB

2023-07-01 Thread Javier Martinez Canillas
Now that the fbdev core has been split in FB_CORE and FB, make DRM fbdev emulation layer to just select the former. This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers. Signed-off-by: Javier Martinez

[PATCH v2 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-07-01 Thread Javier Martinez Canillas
This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still having the the core fbdev support needed for the CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically

[PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-07-01 Thread Javier Martinez Canillas
Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles). The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well. That

Re: [PATCH 1/1] backlight: apple_bl_usb: Add Apple Studio Display support

2023-07-01 Thread Rafał Miłecki
On 1.07.2023 14:08, Julius Zint wrote: The Apple Studio Display does not have any physical buttons and the only way to get or set the brightness is by sending USB control transfers to a HID device exposed by the display. These control transfers take the form of a HID_(GET|SET)_REPORT request

[PATCH 1/1] backlight: apple_bl_usb: Add Apple Studio Display support

2023-07-01 Thread Julius Zint
The Apple Studio Display does not have any physical buttons and the only way to get or set the brightness is by sending USB control transfers to a HID device exposed by the display. These control transfers take the form of a HID_(GET|SET)_REPORT request and the payload looks like this:

[PATCH 0/1] Backlight driver for the Apple Studio Display

2023-07-01 Thread Julius Zint
I have been using and testing this as a DKMS for 6 months now without any known issues. It bothers me, that it needs to be part of the initramfs instead of just working out of the box. Maybe someone else here knows, how to tell the USB HID driver, that this is not a HID device and it should keep

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-07-01 Thread Arnd Bergmann
On Fri, Jun 30, 2023, at 13:19, Thomas Zimmermann wrote: > Am 30.06.23 um 00:51 schrieb Javier Martinez Canillas: >> This patch series splits the fbdev core support in two different Kconfig >> symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to >> be disabled, while still

Re: [PATCH v2] drm/msm/adreno: Assign revn to A635

2023-07-01 Thread Rob Clark
On Sat, Jul 1, 2023 at 8:49 AM Rob Clark wrote: > > On Fri, Jun 30, 2023 at 4:12 PM Konrad Dybcio > wrote: > > > > Recently, a WARN_ON() was introduced to ensure that revn is filled before > > adreno_is_aXYZ is called. This however doesn't work very well when revn is > > 0 by design (such as

[PATCH] drm/msm/adreno: warn if GPU revision is not known yet

2023-07-01 Thread Rob Clark
From: Rob Clark The commit 010c8bbad2cb ("drm: msm: adreno: Disable preemption on Adreno 510") tried to check GPU's revn before revn being set. Add WARN_ON_ONCE to prevent such bugs from happening again. A separate helper is necessary so that the warning is displayed really just once instead of

[PATCH] drm/msm/a690: Remove revn and name

2023-07-01 Thread Rob Clark
From: Rob Clark These fields are deprecated. But any userspace new enough to support a690 also knows how to identify the GPU based on chip-id. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 --

[Bug 217621] AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

2023-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217621 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v2] drm/msm/adreno: Assign revn to A635

2023-07-01 Thread Rob Clark
On Fri, Jun 30, 2023 at 4:12 PM Konrad Dybcio wrote: > > Recently, a WARN_ON() was introduced to ensure that revn is filled before > adreno_is_aXYZ is called. This however doesn't work very well when revn is > 0 by design (such as for A635). Fill it in as a stopgap solution for > -fixes. > >

Re: [PATCH 1/1] backlight: apple_bl_usb: Add Apple Studio Display support

2023-07-01 Thread kernel test robot
-apple_bl_usb-Add-Apple-Studio-Display-support/20230701-202142 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git for-backlight-next patch link:https://lore.kernel.org/r/20230701120806.11812-2-julius%40zint.sh patch subject: [PATCH 1/1] backlight: apple_bl_usb: Add Apple

[Bug 217621] AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

2023-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217621 --- Comment #3 from Timo Schröder (der.timo...@gmail.com) --- Created attachment 304517 --> https://bugzilla.kernel.org/attachment.cgi?id=304517=edit Patch to revert edcfed8671ee57bb599184f2e12a1b3e11b32306 -- You may reply to this email to

[Bug 217621] AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

2023-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217621 --- Comment #2 from Timo Schröder (der.timo...@gmail.com) --- Created attachment 304516 --> https://bugzilla.kernel.org/attachment.cgi?id=304516=edit Commit edcfed8671ee57bb599184f2e12a1b3e11b32306 -- You may reply to this email to add a

[Bug 217621] AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

2023-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217621 --- Comment #1 from Timo Schröder (der.timo...@gmail.com) --- Created attachment 304515 --> https://bugzilla.kernel.org/attachment.cgi?id=304515=edit inxi output -- You may reply to this email to add a comment. You are receiving this mail

[Bug 217621] New: AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

2023-07-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217621 Bug ID: 217621 Summary: AMDGPU - Internal 4K display used with 1920x1080 leads to screen flickering and distortion, regression from commit edcfed8671ee57bb599184f2e12a1b3e11b32306

Re: [PATCH] drm/exynos: fix a possible null-pointer dereference due to data race in exynos_drm_crtc_atomic_disable()

2023-07-01 Thread Krzysztof Kozlowski
On 30/06/2023 04:19, Tuo Li wrote: > The variable crtc->state->event is often protected by the lock > crtc->dev->event_lock when is accessed. However, it is accessed as a > condition of an if statement in exynos_drm_crtc_atomic_disable() without > holding the lock: > > if (crtc->state->event

Re: [PATCH v6 5/9] drm/meson: gate px_clk when setting rate

2023-07-01 Thread George Stark
Hello Neil On 6/30/23 19:29, Neil Armstrong wrote: Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong ---