Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: >> static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { >> .mode_valid = ssd130x_crtc_helper_mode_valid, >> -.atomic_check =

[PATCH] MAINTAINERS: add drm_bridge_connector.[ch] files under bridge chips

2023-09-14 Thread Jani Nikula
Clearly this should be under bridge chips. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Signed-off-by: Jani Nikula --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 354ac7ef553d..c331f2ea89d7 100644 --- a/MAINTAINERS +++

[PATCH] drm: bridge: it66121: ->get_edid callback must not return err pointers

2023-09-14 Thread Jani Nikula
The drm stack does not expect error valued pointers for EDID anywhere. Fixes: e66856508746 ("drm: bridge: it66121: Set DDC preamble only once before reading EDID") Cc: Paul Cercueil Cc: Robert Foss Cc: Phong LE Cc: Neil Armstrong Cc: Andrzej Hajda Cc: Robert Foss Cc: Laurent Pinchart Cc:

[PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path

2023-09-14 Thread Jani Nikula
Setting new_edid to NULL leaks the buffer. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Cc: Markus Schneider-Pargmann Cc: Guillaume Ranquet Cc: Bo-Chen Chen Cc: CK Hu Cc: AngeloGioacchino Del Regno Cc: Dmitry Osipenko Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc:

[PATCH] drm/meson: fix memory leak on ->hpd_notify callback

2023-09-14 Thread Jani Nikula
The EDID returned by drm_bridge_get_edid() needs to be freed. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") Cc: Neil Armstrong Cc: Sam Ravnborg Cc: Martin Blumenstingl Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc:

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: > static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { > .mode_valid = ssd130x_crtc_helper_mode_valid, > - .atomic_check = drm_crtc_helper_atomic_check, > + .atomic_check =

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 14:58, Boris Brezillon wrote: > On Thu, 14 Sep 2023 14:36:23 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 11:27, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 10:50:32 +0300 >>> Dmitry Osipenko wrote: >>> On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023

[PULL] drm-intel-fixes

2023-09-14 Thread Rodrigo Vivi
Hi Dave and Daniel, Only a fix for blank-screen regression on Chromebooks, targeting stable 6.5. Here goes drm-intel-fixes-2023-09-14: - Only check eDP HPD when AUX CH is shared. (Ville) Thanks, Rodrigo. The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux

[PULL] drm-misc-fixes

2023-09-14 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-09-14: Short summary of fixes pull: * radeon: Uninterruptible fence waiting * tests: Fix use-after-free bug * vkms: Revert hrtimer fix The following changes since commit

Re: [PATCH] drm/tests: provide exit function

2023-09-14 Thread Maxime Ripard
On Wed, Sep 13, 2023 at 07:35:57PM +0300, José Pekkarinen wrote: > On 2023-09-13 17:41, mrip...@kernel.org wrote: > > On Wed, Sep 13, 2023 at 05:01:40PM +0300, José Pekkarinen wrote: > > > On 2023-09-13 12:50, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Wed, Sep 13, 2023 at 11:32:23AM

Re: (subset) [PATCH v3 1/2] drm/tests: helpers: Avoid a driver uaf

2023-09-14 Thread Maxime Ripard
On Thu, 07 Sep 2023 15:53:38 +0200, Thomas Hellström wrote: > when using __drm_kunit_helper_alloc_drm_device() the driver may be > dereferenced by device-managed resources up until the device is > freed, which is typically later than the kunit-managed resource code > frees it. Fix this by simply

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 14:36:23 +0300 Dmitry Osipenko wrote: > On 9/14/23 11:27, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 10:50:32 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/14/23 10:36, Boris Brezillon wrote: > >>> On Thu, 14 Sep 2023 07:02:52 +0300 > >>> Dmitry Osipenko wrote: >

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 12:45:44 +0200 Thomas Hellström wrote: > On 9/14/23 10:20, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 15:22:56 +0200 > > Thomas Hellström wrote: > > > >> On 9/13/23 13:33, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 12:39:01 +0200 > >>> Thomas Hellström wrote:

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 11:27, Boris Brezillon wrote: > On Thu, 14 Sep 2023 10:50:32 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 10:36, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 07:02:52 +0300 >>> Dmitry Osipenko wrote: >>> On 9/13/23 10:48, Boris Brezillon wrote: > On Wed, 13 Sep 2023

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On 9/14/23 12:57, Danilo Krummrich wrote: On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma-resv locks, neat! However, what if two tasks are trying to lock the VA space concurrently? What do we do when the drm_gpuvm_bo's refcount drops to

[PATCH] drm/edid: Fixup h/vsync_end instead of h/vtotal

2023-09-14 Thread Ville Syrjala
From: Ville Syrjälä There are some weird EDIDs floating around that have the sync pulse extending beyond the end of the blanking period. On the currently problemtic machine (HP Omni 120) EDID reports the following mode: "1600x900": 60 108000 1600 1780 1860 1800 900 910 913 1000 0x40 0x5 which

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma-resv locks, neat! However, what if two tasks are trying to lock the VA space concurrently? What do we do when the drm_gpuvm_bo's refcount drops to zero in drm_gpuva_unlink()? Are we guaranteed

[PATCH] Revert "drm/vkms: Fix race-condition between the hrtimer and the atomic commit"

2023-09-14 Thread Maíra Canal
This reverts commit a0e6a017ab56936c0405fe914a793b241ed25ee0. Unlocking a mutex in the context of a hrtimer callback is violating mutex locking rules, as mutex_unlock() from interrupt context is not permitted. Links: https://lore.kernel.org/dri-devel/ZQLAc%2FFwkv%2FGiVoK@phenom.ffwll.local/T/#t

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On 9/14/23 10:20, Boris Brezillon wrote: On Wed, 13 Sep 2023 15:22:56 +0200 Thomas Hellström wrote: On 9/13/23 13:33, Boris Brezillon wrote: On Wed, 13 Sep 2023 12:39:01 +0200 Thomas Hellström wrote: Hi, On 9/13/23 09:19, Boris Brezillon wrote: On Wed, 13 Sep 2023 17:05:42 +1000

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Dmitry Baryshkov
On Thu, 14 Sept 2023 at 12:26, Heikki Krogerus wrote: > > Hi Dmitry, > > On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > > On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > > wrote: > > > > > > On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: > > > > Hi

Re: [PATCH v10 11/16] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-09-14 Thread AngeloGioacchino Del Regno
tree node in mt8195.dtsi, and the node has compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma"; so, no devicetree and/or bindings modification is needed. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/mediatek/mt8195.dtsi?h=next-20230914#n2724 Regards, Angelo ChenYu {}, }; MODULE_DEVICE_TABLE(of, mtk_disp_gamma_driver_dt_match); -- 2.41.0

Re: [PATCH 6/9] dma-buf: heaps: mtk_sec_heap: Add tee service call for buffer allocating/freeing

2023-09-14 Thread kernel test robot
Hi Yong, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on robh/for-next linus/master v6.6-rc1 next-20230914] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Dmitry Baryshkov
On Thu, 14 Sept 2023 at 12:35, Neil Armstrong wrote: > > On 14/09/2023 11:26, Heikki Krogerus wrote: > > Hi Dmitry, > > > > On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > >> On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > >> wrote: > >>> > >>> On Wed, Sep 13, 2023 at

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-14 Thread Maxime Ripard
Hi, On Tue, Sep 12, 2023 at 02:16:41PM +0100, Daniel Stone wrote: > Hopefully less mangled formatting this time: turns out Thunderbird + > plain text is utterly unreadable, so that's one less MUA that is > actually usable to send email to kernel lists without getting shouted > at. Sorry if it

RE: [PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Cong Liu Sent: Thursday, September 14, 2023 17:46 To: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Yang, Stanley ; Zhang, Hawking Cc: Cong

[PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Cong Liu
This patch fixes a memory leak in the amdgpu_ras_feature_enable() function. The leak occurs when the function sends a command to the firmware to enable or disable a RAS feature for a GFX block. If the command fails, the kfree() function is not called to free the info memory. Fixes: bf7aa8bea9cb

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Neil Armstrong
On 14/09/2023 11:26, Heikki Krogerus wrote: Hi Dmitry, On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus wrote: On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: Hi Heikki, On Wed, 13 Sept 2023 at 12:27, Heikki

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Heikki Krogerus
Hi Dmitry, On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > wrote: > > > > On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: > > > Hi Heikki, > > > > > > On Wed, 13 Sept 2023 at 12:27, Heikki Krogerus > > >

[PATCH v4 7/7] drm: ci: Use scripts/config to enable/disable configs

2023-09-14 Thread Vignesh Raman
Instead of modifying files in git to enable/disable configs, use scripts/config on the .config file which will be used for building the kernel. Suggested-by: Jani Nikula Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - Added a new patch in the series to use scripts/config to

[PATCH v4 6/7] drm: ci: Enable new jobs

2023-09-14 Thread Vignesh Raman
Enable the following jobs, as the issues noted in the TODO comments have been resolved. This will ensure that these jobs are now included and executed as part of the CI/CD pipeline. msm:apq8016: TODO: current issue: it is not fiding the NFS root. Fix and remove this rule. mediatek:mt8173: TODO:

[PATCH v4 5/7] drm: ci: Update xfails

2023-09-14 Thread Vignesh Raman
Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the *-flakes file and tests that are failing into the

[PATCH v4 4/7] drm: ci: Enable regulator

2023-09-14 Thread Vignesh Raman
Enable CONFIG_REGULATOR_DA9211=y to fix mt8173 boot issue. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - Remove CONFIG_RTC_DRV_MT6397=y as it is already enabled in defconfig v4: - No changes --- drivers/gpu/drm/ci/arm64.config | 1 + 1 file changed, 1

[PATCH v4 3/7] drm: ci: virtio: Update ci variables

2023-09-14 Thread Vignesh Raman
Update ci variables to fix the below error, ERROR - Igt error: malloc(): corrupted top size ERROR - Igt error: Received signal SIGABRT. ERROR - Igt error: Stack trace: ERROR - Igt error: #0 [fatal_sig_handler+0x17b] Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes

[PATCH v4 2/7] drm: ci: Force db410c to host mode

2023-09-14 Thread Vignesh Raman
Force db410c to host mode to fix network issue which results in failure to mount root fs via NFS. See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 Use apq8016-sbc-usb-host.dtb which allows the USB controllers to work in host mode. Acked-by: Helen

[PATCH v4 1/7] drm: ci: igt_runner: Remove todo

2023-09-14 Thread Vignesh Raman
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver. We do not test non-atomic drivers, so remove the todo. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - No changes v4: - No changes --- drivers/gpu/drm/ci/igt_runner.sh | 1 - 1 file

[PATCH v4 0/7] drm: ci: fixes

2023-09-14 Thread Vignesh Raman
The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. This series is intended for drm branch drm-next. v2: - Use fdtoverlay command to merge

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 10:50:32 +0300 Dmitry Osipenko wrote: > On 9/14/23 10:36, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 07:02:52 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/13/23 10:48, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 03:56:14 +0300 > >>> Dmitry Osipenko wrote: >

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Boris Brezillon
On Wed, 13 Sep 2023 15:22:56 +0200 Thomas Hellström wrote: > On 9/13/23 13:33, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 12:39:01 +0200 > > Thomas Hellström wrote: > > > >> Hi, > >> > >> On 9/13/23 09:19, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 17:05:42 +1000 > >>> Dave Airlie

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 09:23:29AM -0700, Doug Anderson wrote: > On Wed, Sep 6, 2023 at 1:39 AM Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > > > This commit is only compile-time tested. > > > > > > > > > > NOTE: this patch touches a lot more

Re: drm/vkms: deadlock between dev->event_lock and timer

2023-09-14 Thread Daniel Vetter
On Thu, Sep 14, 2023 at 03:33:41PM +0900, Tetsuo Handa wrote: > On 2023/09/14 6:08, Thomas Gleixner wrote: > > Maybe the VKMS people need to understand locking in the first place. The > > first thing I saw in this code is: > > > > static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023 07:02:52 +0300 > Dmitry Osipenko wrote: > >> On 9/13/23 10:48, Boris Brezillon wrote: >>> On Wed, 13 Sep 2023 03:56:14 +0300 >>> Dmitry Osipenko wrote: >>> On 9/5/23 11:03, Boris Brezillon wrote: >>*

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 07:02:52 +0300 Dmitry Osipenko wrote: > On 9/13/23 10:48, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 03:56:14 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/5/23 11:03, Boris Brezillon wrote: > * But > + * acquiring the obj

Fwd: Kernel 6.6-rc1 fails to reboot or shutdown Ryzen 5825U

2023-09-14 Thread Bagas Sanjaya
Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > The Kernel stalls at boot very long with a drm-amdgpu message, but fails to > restart or shutdown with secure boot enabled or not. Magic key works to exit. > Nothing wrong in the Kernel 6.5 cycle. Later, the reporter (Cc'ed)

[PATCH] alpha: clean up some inconsistent indenting

2023-09-14 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:491 dcn32_auto_dpm_test_log() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6574 Signed-off-by: Jiapeng Chong ---

Re: drm/vkms: deadlock between dev->event_lock and timer

2023-09-14 Thread Tetsuo Handa
On 2023/09/14 6:08, Thomas Gleixner wrote: > Maybe the VKMS people need to understand locking in the first place. The > first thing I saw in this code is: > > static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) > { >... >mutex_unlock(>enabled_lock); > > What? > >

<    1   2