[Bug 201957] amdgpu: ring gfx timeout

2023-09-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 KC (kco...@gmail.com) changed: What|Removed |Added CC||kco...@gmail.com --- Comment #91

Re: [PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-22 Thread Abhinav Kumar
Hi Stephen On 9/22/2023 2:54 PM, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2023-09-19 02:50:12) On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: Add pm_runtime_force_suspend()/resume()

Re: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-22 Thread Randy Dunlap
Hi Geert, On 9/22/23 00:23, Geert Uytterhoeven wrote: > Hi Randy, > > On Thu, Sep 21, 2023 at 10:43 PM Randy Dunlap wrote: >> Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: >> >> sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': >> sh7760fb.c:(.text+0x374):

Re: [PATCH v3 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-22 Thread Kuogee Hsieh
On 9/15/2023 5:29 PM, Dmitry Baryshkov wrote: On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() which ties irq registration to the DPU device's life cycle, while depending on resources that are released as the DP

Re: [PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

[PATCH 1/3] drm/i915/guc: Support new and improved engine busyness

2023-09-22 Thread John . C . Harrison
From: John Harrison The GuC has been extended to support a much more friendly engine busyness interface. So partition the old interface into a 'busy_v1' space and add 'busy_v2' support alongside. And if v2 is available, use that in preference to v1. Note that v2 provides extra features over and

[PATCH 3/3] drm/i915/mtl: Add counters for engine busyness ticks

2023-09-22 Thread John . C . Harrison
From: Umesh Nerlige Ramappa In new version of GuC engine busyness, GuC provides engine busyness ticks as a 64 bit counter. Add a new counter to relay this value to the user as is. Signed-off-by: Umesh Nerlige Ramappa Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_engine.h

[PATCH 0/3] Engine busyness v2

2023-09-22 Thread John . C . Harrison
From: John Harrison The latest GuC implements a new and improved scheme for tracking engine busyness. So make use of it. Note that this change comes along with a new set of PMU counters. The old counters have a fundamental problem that they are defined in terms of wall time but the sampling is

[PATCH 2/3] drm/i915/mtl: Add a PMU counter for total active ticks

2023-09-22 Thread John . C . Harrison
From: Umesh Nerlige Ramappa Current engine busyness interface exposed by GuC has a few issues: - The busyness of active engine is calculated using 2 values provided by GuC and is prone to race between CPU reading those values and GuC updating them. Any sort of HW synchronization would be at

Re: [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-22 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2023-09-19 02:50:12) > On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: > > > > > > On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: > > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh > > > wrote: > > >> Add pm_runtime_force_suspend()/resume() to complete incorporating

Re: [PATCH 8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by

2023-09-22 Thread Zack Rusin
On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

Re: [RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-09-22 Thread Lyude Paul
actually very glad to see this because I think I've seen one bug in the wild as a result of things not getting shut down :) Reviewed-by: Lyude Paul Tested-by: Lyude Paul On Thu, 2023-09-21 at 12:26 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 14:04, Mario Limonciello wrote: On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface

Re: [PATCH 3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Gustavo A. R. Silva
On 9/22/23 11:32, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

Re: [PATCH][V3] drm/amd/display: Remove unwanted drm edid references

2023-09-22 Thread Harry Wentland
On 2023-09-18 09:04, Alex Hung wrote: [WHY] edid_override and drm_edid_override_connector_update, according to drm documentation, should not be referred outside drm_edid. [HOW] Remove and replace them accordingly. This can tested by IGT's kms_hdmi_inject test. Signed-off-by: Alex Hung

Re: [PATCH] drm/mst: check connector state before dereference

2023-09-22 Thread Lyude Paul
(sorry if there's been discussion on the gitlab about this or related issues, I've been trying to let amd folks handle more issues like this) Warnings would be fine but - I'm pretty sure the solution to this is already mentioned in the documentation for these functions. Explanations below On

[PATCH] drm/amd: Fix the size of a buffer in amdgpu_vcn_idle_work_handler()

2023-09-22 Thread Christophe JAILLET
In order to be sure that fw_name is not truncated, this buffer should be at least 41 bytes long. Let the compiler compute the correct length by itself. When building with W=1, this fixes the following warnings: drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c: In function ‘amdgpu_vcn_early_init’:

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Lyude Paul
…ugh, thanks for catching that :| yes you're completely right - NAK on this patch then On Fri, 2023-09-22 at 22:22 +0300, Imre Deak wrote: > On Fri, Sep 22, 2023 at 03:02:23PM -0400, Lyude Paul wrote: > > > > Oh! wow thank you for catching this: > > > > Reviewed-by: Lyude Paul > > > > I will

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Imre Deak
On Fri, Sep 22, 2023 at 03:02:23PM -0400, Lyude Paul wrote: > > Oh! wow thank you for catching this: > > Reviewed-by: Lyude Paul > > I will go and push this to drm-misc-next in just a moment > > On Fri, 2023-09-15 at 10:24 +0530, Ramya SR wrote: > > Modeset mutex unlock is missing in

Re: [PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K

Re: [PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam

Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-22 Thread Andrew Davis
On 9/22/23 12:57 PM, Adam Jackson wrote: On Wed, Sep 6, 2023 at 5:57 AM Sarah Walker mailto:sarah.wal...@imgtec.com>> wrote: + *    :BYPASS_CACHE: There are very few situations where this flag is useful. Could you also expand on what these few useful situations are? Andrew + *   

Re: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Lyude Paul
Oh! wow thank you for catching this: Reviewed-by: Lyude Paul I will go and push this to drm-misc-next in just a moment On Fri, 2023-09-15 at 10:24 +0530, Ramya SR wrote: > Modeset mutex unlock is missing in drm_dp_mst_detect_port function. > This will lead to deadlock if calling the function

Re: [PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even

Re: [PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Fri, 2023-09-22 at 10:32 -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via

Re: [PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Mario Limonciello
On 9/22/2023 12:50, Shyam Sundar S K wrote: PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary

Re: [PATCH 2/9] dma-heap: Add proper kref handling on dma-buf heaps

2023-09-22 Thread T.J. Mercier
On Mon, Sep 11, 2023 at 2:49 AM Christian König wrote: > > Am 11.09.23 um 04:30 schrieb Yong Wu: > > From: John Stultz > > > > Add proper refcounting on the dma_heap structure. > > While existing heaps are built-in, we may eventually > > have heaps loaded from modules, and we'll need to be > >

Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

2023-09-22 Thread Adam Jackson
On Wed, Sep 6, 2023 at 5:57 AM Sarah Walker wrote: > > + *:BYPASS_CACHE: There are very few situations where this flag is > useful. > + * By default, the device flushes its memory caches after every job. > Presumably BYPASS_CACHE does something other than "after every job". Is that

[PATCH] accel/ivpu: Annotate struct ivpu_job with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 14/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-22 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

[PATCH 15/15] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-22 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by:

[PATCH 13/15] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-09-22 Thread Shyam Sundar S K
For the Smart PC Solution to fully work, it has to enact to the actions coming from TA. Add the initial code path for set interface to AMDGPU. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 21

[PATCH 12/15] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-09-22 Thread Shyam Sundar S K
In order to provide GPU inputs to TA for the Smart PC solution to work, we need to have interface between the PMF driver and the AMDGPU driver. Add the initial code path for get interface from AMDGPU. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam

[PATCH 11/15] platform/x86/amd/pmf: dump policy binary data

2023-09-22 Thread Shyam Sundar S K
Sometimes policy binary retrieved from the BIOS maybe incorrect that can end up in failing to enable the Smart PC solution feature. Use print_hex_dump_debug() to dump the policy binary in hex, so that we debug the issues related to the binary even before sending that to TA. Signed-off-by: Shyam

[PATCH 05/15] platform/x86/amd/pmf: change debugfs init sequence

2023-09-22 Thread Shyam Sundar S K
amd_pmf_dbgfs_register() needs to be called before amd_pmf_init_features(). Hence change the sequence. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 10/15] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-09-22 Thread Shyam Sundar S K
A policy binary is OS agnostic, and the same policies are expected to work across the OSes. At times it becomes difficult to debug when the policies inside the policy binaries starts to misbehave. Add a way to sideload such policies independently to debug them via a debugfs entry. Reviewed-by:

[PATCH 09/15] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-09-22 Thread Shyam Sundar S K
PMF driver sends constant inputs to TA which its gets via the other subsystems in the kernel. To debug certain TA issues knowing what inputs being sent to TA becomes critical. Add debug facility to the driver which can isolate Smart PC and TA related issues. Reviewed-by: Mario Limonciello

[PATCH 08/15] platform/x86/amd/pmf: Add support to update system state

2023-09-22 Thread Shyam Sundar S K
PMF driver based on the output actions from the TA can request to update the system states like entering s0i3, lock screen etc. by generating an uevent. Based on the udev rules set in the userspace the event id matching the uevent shall get updated accordingly using the systemctl. Sample udev

[PATCH 07/15] platform/x86/amd/pmf: Add support update p3t limit

2023-09-22 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++

[PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-09-22 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K ---

[PATCH 04/15] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-09-22 Thread Shyam Sundar S K
PMF Policy binary is a encrypted and signed binary that will be part of the BIOS. PMF driver via the ACPI interface checks the existence of Smart PC bit. If the advertised bit is found, PMF driver walks the acpi namespace to find out the policy binary size and the address which has to be passed to

[PATCH 03/15] platform/x86/amd/pmf: Change signature of amd_pmf_set_dram_addr

2023-09-22 Thread Shyam Sundar S K
Make amd_pmf_set_dram_addr() as non-static so that same function can be used across files. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 14 -- drivers/platform/x86/amd/pmf/pmf.h | 1 + 2 files changed, 9 insertions(+), 6

[PATCH 02/15] platform/x86/amd/pmf: Add support PMF-TA interaction

2023-09-22 Thread Shyam Sundar S K
PMF TA (Trusted Application) loads via the TEE environment into the AMD ASP. PMF-TA supports two commands: 1) Init: Initialize the TA with the PMF Smart PC policy binary and start the policy engine. A policy is a combination of inputs and outputs, where; - the inputs are the changing dynamics of

[PATCH 01/15] platform/x86/amd/pmf: Add PMF TEE interface

2023-09-22 Thread Shyam Sundar S K
AMD PMF driver loads the PMF TA (Trusted Application) into the AMD ASP's (AMD Security Processor) TEE (Trusted Execution Environment). PMF Trusted Application is a secured firmware placed under /lib/firmware/amdtee gets loaded only when the TEE environment is initialized. Add the initial code

[PATCH 00/15] Introduce PMF Smart PC Solution Builder Feature

2023-09-22 Thread Shyam Sundar S K
Smart PC Solutions Builder allows for OEM to define a large number of custom system states to dynamically switch to. The system states are referred to as policies, and multiple policies can be loaded onto the system at any given time, however only one policy can be active at a given time. Policy

[PATCH] video: mmp: Annotate struct mmp_path with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH] video: fbdev: mmp: Annotate struct mmphw_ctrl with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

Re: [Freedreno] [PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-09-22 Thread Jessica Zhang
On 8/29/2023 1:22 AM, Pekka Paalanen wrote: On Mon, 28 Aug 2023 17:05:13 -0700 Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas

Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Alex Deucher
On Fri, Sep 22, 2023 at 1:33 PM Kees Cook wrote: > > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

[PATCH 9/9] drm/v3d: Annotate struct v3d_perfmon with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

Re: [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Alex Deucher
On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array

[PATCH 8/9] drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 5/9] drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 6/9] drm/vc4: Annotate struct vc4_perfmon with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 7/9] drm/virtio: Annotate struct virtio_gpu_object_array with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH 0/9] drm: Annotate structs with __counted_by

2023-09-22 Thread Kees Cook
Hi, This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and

[PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family

[PATCH v2 2/2] drm/ci: add tests on vkms

2023-09-22 Thread Helen Koike
Add job that runs igt on top of vkms. Signed-off-by: Helen Koike --- See pipeline: https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/990494 v2: - do not mv modules to /lib/modules in the job definition, leave it to crosvm-runner.sh --- MAINTAINERS

[PATCH v2 1/2] drm/ci: uprev mesa version - fix container build

2023-09-22 Thread Helen Koike
When building containers, some rust packages were installed without locking the dependencies version, which got updated and started giving errors like: error: failed to compile `bindgen-cli v0.62.0`, intermediate artifacts can be found at `/tmp/cargo-installkNKRwf` Caused by: package `rustix

[PATCH v2 0/2] drm/ci: Update Mesa and Introduce VKMS Support

2023-09-22 Thread Helen Koike
This patchset offers two enhancements to drm/ci: 1. Mesa Version Update. drm/ci re-uses components from Mesa project. A recent bug in MesaCI was fixed. The first patch updates drm/ci Mesa's version, re-allowing containers rebuilds when uncached, essencial for new runs. 2. VKMS Driver Testing,

Re: [git pull] drm fixes for 6.6-rc3

2023-09-22 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Sep 2023 16:14:46 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b41b28366d3b176c8297961de4f095f2e392402d Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v4 5/7] drm: ci: Update xfails

2023-09-22 Thread Helen Koike
Hi o/ On 14/09/2023 05:54, Vignesh Raman wrote: Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the

Re: [PATCH 0/7] accel/qaic: Extend uAPI to support undoing ATTACH_SLICE_BO

2023-09-22 Thread Jeffrey Hugo
On 9/1/2023 11:22 AM, Jeffrey Hugo wrote: A BO for a QAIC device has two states - 1. Allocated 2. Sliced A BO can be allocated at any time, and is initialized in the allocated state. A BO can transition to the sliced state via ATTACH_SLICE_BO. This prepares the BO for use with an active

Re: [7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is set then while iterating over output

Re: [2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Ankit Nautiyal DSC parameter bits_per_pixel is stored in U6.4 format. The 4 bits represent the fractional part of the bpp. Currently we use compressed_bpp member of dsc structure to store only the integral part of the bits_per_pixel. To store

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 04:49:14PM +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > > Add a compatible string for the COLOR block in MediaTek MT8195 that > > is controlled by MDP3. > > > > Signed-off-by: Moudy Ho > > --- > >

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > Add a compatible string for the COLOR block in MediaTek MT8195 that > is controlled by MDP3. > > Signed-off-by: Moudy Ho > --- > .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v6 11/16] dt-bindings: display: mediatek: aal: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:11PM +0800, Moudy Ho wrote: > Add a compatible string for the AAL block in MediaTek MT8195 that > is controlled by MDP3. > > Signed-off-by: Moudy Ho Acked-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml |

Re: [PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:05PM +0800, Moudy Ho wrote: > Support for MT8195 RDMA has been added, allowing for > the configuration of multiple MDP3 pipes. > Furthermore, this particular device does not require > sharing SRAM with RSZ. I'm sorry if I am going over past arguments, if this is 90%

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Doug Anderson
Hi, On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu wrote: > > Hi, > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among

Re: [PATCH v6 04/16] dt-bindings: media: mediatek: mdp3: rename to MT8183 RDMA

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:04PM +0800, Moudy Ho wrote: > The file was renamed to support future scalability in response to > the changes in general properties separation. > > Signed-off-by: Moudy Ho Same with this, not all too sure why this is a commit of its own. > --- >

Re: [PATCH v6 03/16] dt-bindings: media: mediatek: mdp3: include common properties

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:03PM +0800, Moudy Ho wrote: > To minimize duplication and standardize the document style, > include the common properties for MT8183 RDMA. Duplication that you created in the previous patch? Why not combine patches 2 & 3? Cheers, Conor. > > Signed-off-by: Moudy Ho

Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support

2023-09-22 Thread Chris Morgan
On Fri, Aug 11, 2023 at 09:41:48AM -0500, Chris Morgan wrote: > On Thu, Aug 10, 2023 at 05:24:09PM -0600, Rob Herring wrote: > > On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Document the Anbernic RG351V panel, which appears to be identical to

Re: [PATCH] accel/ivpu: Add Arrow Lake pci id

2023-09-22 Thread Jeffrey Hugo
On 9/22/2023 7:22 AM, Stanislaw Gruszka wrote: Enable VPU on Arrow Lake CPUs. Reviewed-by: Krystian Pradzynski Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_drv.h | 2 ++ 2 files changed, 3 insertions(+)

Re: [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-22 Thread Steven Price
On 22/09/2023 14:53, Tvrtko Ursulin wrote: > > On 22/09/2023 11:57, Adrián Larumbe wrote: >> On 20.09.2023 16:40, Tvrtko Ursulin wrote: >>> On 20/09/2023 00:34, Adrián Larumbe wrote: The drm-stats fdinfo tags made available to user space are drm-engine, drm-cycles, drm-max-freq and

Re: [RFC 3/4] accel/ivpu: Remove support for uncached buffers

2023-09-22 Thread Jeffrey Hugo
On 9/19/2023 3:49 AM, Stanislaw Gruszka wrote: On Mon, Sep 11, 2023 at 09:24:42AM -0600, Jeffrey Hugo wrote: On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC. There is no functional benefit from

Re: [RFC 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback

2023-09-22 Thread Jeffrey Hugo
On 9/19/2023 3:24 AM, Stanislaw Gruszka wrote: On Mon, Sep 11, 2023 at 09:19:03AM -0600, Jeffrey Hugo wrote: On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz gem->open() is called during handle creation for a gem object. It is called during prime import and in BO_CREATE

Re: [PATCH 0/7] accel/qaic: Extend uAPI to support undoing ATTACH_SLICE_BO

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:58 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:40AM -0600, Jeffrey Hugo wrote: A BO for a QAIC device has two states - 1. Allocated 2. Sliced A BO can be allocated at any time, and is initialized in the allocated state. A BO can transition to the sliced state via

Re: [PATCH 7/7] accel/qaic: Add QAIC_DETACH_SLICE_BO IOCTL

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:56 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:47AM -0600, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Once a BO is attached with slicing configuration that BO can only be used for that particular setting. With this new feature user can detach slicing

Re: [3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj

Re: [PATCH 6/7] accel/qaic: Create a function to initialize BO

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:48 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:46AM -0600, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya This makes sure that we have a single place to initialize and re-initialize BO. Use this new API to cleanup release_dbc() We will need this for

Re: [1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-22 Thread Sui Jingfeng
Hi, The word 'prescision' in the commit title is a typo, perhaps it's more better correct it as 'precision' when merge. On 2023/9/13 14:05, Mitul Golani wrote: From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal

Re: [PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-22 Thread Lucas Stach
Am Freitag, dem 22.09.2023 um 09:51 + schrieb Ying Liu: > On Friday, September 22, 2023 4:03 AM Lucas Stach > wrote: > > drm_atomic_helper_commit_tail_rpm makes it hard for drivers to follow > > the documented encoder/bridge enable flow, as it commits all CRTC enables > > before the planes

[PATCH v6 07/16] dt-bindings: media: mediatek: mdp3: add component HDR for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component HDR, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-hdr.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644

[PATCH v6 14/16] dt-bindings: display: mediatek: ovl: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the OVL block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 02/16] dt-bindings: media: mediatek: mdp3: split out general properties

2023-09-22 Thread Moudy Ho
In order to minimize duplication and standardize the document style, it is necessary to separate the general properties specific to MediaTek MDP3 RDMA. Signed-off-by: Moudy Ho --- .../media/mediatek,mdp3-rdma-common.yaml | 72 +++ 1 file changed, 72 insertions(+) create

[PATCH v6 09/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component STITCH, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-tcc.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644

[PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA

2023-09-22 Thread Moudy Ho
Support for MT8195 RDMA has been added, allowing for the configuration of multiple MDP3 pipes. Furthermore, this particular device does not require sharing SRAM with RSZ. Signed-off-by: Moudy Ho --- .../media/mediatek,mdp3-rdma-8195.yaml| 64 +++ 1 file changed, 64

[PATCH v6 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the PAD block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../bindings/display/mediatek/mediatek,padding.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v6 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the SPLIT block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,split.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the COLOR block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v6 04/16] dt-bindings: media: mediatek: mdp3: rename to MT8183 RDMA

2023-09-22 Thread Moudy Ho
The file was renamed to support future scalability in response to the changes in general properties separation. Signed-off-by: Moudy Ho --- .../{mediatek,mdp3-rdma.yaml => mediatek,mdp3-rdma-8183.yaml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename

[PATCH v6 13/16] dt-bindings: display: mediatek: merge: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the MERGE block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Ramya SR
Gentle Reminder. Please review the commit. -Original Message- From: Ramya SR (QUIC) Sent: Friday, September 15, 2023 10:25 AM To: David Airlie ; Daniel Vetter ; Lyude Paul ; Wayne Lin ; Jani Nikula ; Imre Deak ; Alex Deucher ; Jeff Layton ; dri-devel@lists.freedesktop.org;

[PATCH v6 06/16] dt-bindings: media: mediatek: mdp3: add component FG for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component FG, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-fg.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644

  1   2   >