Re: [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Andrzej Hajda
On 27.10.2023 16:07, Harshit Mogalapalli wrote: When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before the commit in the Fixes tag. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver

[PATCH v3 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Imre Deak
Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in

[PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls

2023-10-27 Thread Harshit Mogalapalli
When i915 perf interface is not available dereferencing it will lead to NULL dereferences. Fix this by using DRM_DEBUG() which the scenario before the commit in the Fixes tag. Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver specific drm_dbg call") Signed-off-by: Harshit

Re: [bug report] drm: Warn about negative sizes when calculating scale factor

2023-10-27 Thread Dan Carpenter
On Fri, Oct 20, 2023 at 05:11:24PM +0300, Dan Carpenter wrote: > On Fri, Oct 20, 2023 at 02:55:37PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 20, 2023 at 02:39:04PM +0300, Dan Carpenter wrote: > > > On Wed, Oct 18, 2023 at 05:17:42PM +0300, Dan Carpenter wrote: > > > > drivers/gpu/drm/drm_rect.c

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Xaver Hugl
I'm afraid that would not be very useful. It indeed depends on the refresh rate, but also on how close to vblank the compositor does its commits / on what the latency requirements for the currently shown content are. When the compositor presents a fullscreen video with frames that are queued up in

Re: [PATCH 4/8] dt-bindings: display: msm: document the SM8650 Mobile Display Subsystem

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the Mobile Display Subsystem (MDSS) on the SM8650 Platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8650-mdss.yaml | 322 > + > 1 file changed, 322 insertions(+) > Reviewed-by:

Re: [PATCH 3/8] dt-bindings: display: msm: document the SM8650 DPU

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DPU Display Controller on the SM8650 Platform. > > Signed-off-by: Neil Armstrong > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/8] dt-bindings: display: msm-dsi-controller-main: document the SM8650 DSI Controller

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DSI Controller on the SM8650 Platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/8] dt-bindings: display: msm-dsi-phy-7nm: document the SM8650 DSI PHY

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:34, Neil Armstrong wrote: > Document the DSI PHY on the SM8650 Platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-27 Thread Emil Abildgaard Svendsen
On Fri, Oct 27, 2023 at 12:51:07PM +0300, Jani Nikula wrote: > On Thu, 26 Oct 2023, Emil Abildgaard Svendsen wrote: > > Currently reading EDID only works because usually only two EDID blocks > > of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID > > blocks. And the first EDID

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Xaver Hugl
Am Fr., 27. Okt. 2023 um 12:01 Uhr schrieb Sebastian Wick < sebastian.w...@redhat.com>: > On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > > On 10/26/23 21:25, Alex Goins wrote: > > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka

Re: [PATCH] gpu/drm/drm_framebuffer.c: Add judgement for return value of drm_get_format_info().

2023-10-27 Thread Ville Syrjälä
On Fri, Oct 27, 2023 at 05:19:12PM +0800, Peng Hao wrote: > Since drm_get_format_info() may return NULL, Not in this case since we already checked it earlier. > so a judgement of return > value is needed to add. > > Signed-off-by: Peng Hao > --- > drivers/gpu/drm/drm_framebuffer.c | 4 >

Re: drm/panel: panel-simple power-off sequencing

2023-10-27 Thread Jonas Mark (BT-FS/ENG1-GRB)
Hi Doug, Many thanks for your reply. > Hi, > > On Thu, Oct 26, 2023 at 7:37 AM Jonas Mark (BT-FS/ENG1-GRB) > wrote: > > > > Hi, > > > > We have a parallel LCD panel which is driven by panel/panel-simple. > The power-off sequence specified in the datasheet requires that the > enable-gpio must

[PATCH v2 2/2] drm: bridge: adv7511: fix edid read in idle state

2023-10-27 Thread Emil Abildgaard Svendsen
Change check of DDC status. Instead of silently not reading EDID when in "IDLE" state [1]. Always read EDID but add a debug log when DDC controller is in reset. [1] ADV7511 Programming Guide: Table 11: DDCController Status: 0xC8 [3:0] DDC Controller State In Reset (No Hot Plug

[PATCH v2 1/2] drm: bridge: adv7511: fix reading edid segments

2023-10-27 Thread Emil Abildgaard Svendsen
Currently reading EDID only works because usually only two EDID blocks of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID blocks. And the first EDID segment read works fine but E-EDID specifies up to 128 segments. The logic is broken so change EDID segment index to multiple

Re: [Intel-gfx] [PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

2023-10-27 Thread Lisovskiy, Stanislav
On Tue, Oct 24, 2023 at 01:22:17PM +0300, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On > 128b/132b links the FEC

[PATCH 2/2] fbdev/imsttfb: fix a resource leak in probe

2023-10-27 Thread Dan Carpenter
I've re-written the error handling but the bug is that if init_imstt() fails we need to call iounmap(par->cmap_regs). Fixes: c75f5a550610 ("fbdev: imsttfb: Fix use after free bug in imsttfb_probe") Signed-off-by: Dan Carpenter --- drivers/video/fbdev/imsttfb.c | 29 -

[PATCH 1/2] fbdev/imsttfb: fix double free in probe()

2023-10-27 Thread Dan Carpenter
The init_imstt() function calls framebuffer_release() on error and then the probe() function calls it again. It should only be done in probe. Fixes: 518ecb6a209f ("fbdev: imsttfb: Fix error path of imsttfb_probe()") Signed-off-by: Dan Carpenter --- drivers/video/fbdev/imsttfb.c | 6 +- 1

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Pekka Paalanen
On Fri, 27 Oct 2023 12:01:32 +0200 Sebastian Wick wrote: > On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > > On 10/26/23 21:25, Alex Goins wrote: > > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > > >>>

[PATCH] gpu/drm/drm_framebuffer.c: Add judgement for return value of drm_get_format_info().

2023-10-27 Thread Peng Hao
Since drm_get_format_info() may return NULL, so a judgement of return value is needed to add. Signed-off-by: Peng Hao --- drivers/gpu/drm/drm_framebuffer.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index

Re: [PATCH v2] drm/atomic-helper: Fix spelling mistake "preceeding" -> "preceding"

2023-10-27 Thread Hamza Mahfooz
On 10/26/23 22:44, chentao wrote: From: Kunwu Chan There is a typo in the kernel documentation for function drm_atomic_helper_wait_for_dependencies. Fix it. Signed-off-by: Kunwu Chan Applied, thanks! --- drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
Hi Christian, On Fri, 27 Oct 2023 11:06:44 +0200 Christian König wrote: > Am 27.10.23 um 10:22 schrieb Boris Brezillon: > > On Fri, 27 Oct 2023 09:44:13 +0200 > > Christian König wrote: > > > >> Am 27.10.23 um 09:39 schrieb Boris Brezillon: > >>> On Fri, 27 Oct 2023 09:35:01 +0200 > >>>

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Sebastian Wick
On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > On 10/26/23 21:25, Alex Goins wrote: > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > >>> On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) > >>> Alex Goins wrote: > >>> >

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-27 Thread Jani Nikula
On Thu, 26 Oct 2023, Emil Abildgaard Svendsen wrote: > Currently reading EDID only works because usually only two EDID blocks > of 128 bytes is used. Where an EDID segment holds 256 bytes or two EDID > blocks. And the first EDID segment read works fine but E-EDID specifies > up to 128 segments. >

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-27 Thread Emil Abildgaard Svendsen
On Thu, Oct 26, 2023 at 11:49:00AM -0300, Fabio Estevam wrote: > Hi Emil, > > On Thu, Oct 26, 2023 at 11:47 AM Emil Abildgaard Svendsen > wrote: > > > > Currently reading EDID only works because usually only two EDID blocks > > of 128 bytes is used. Where an EDID segment holds 256 bytes or two

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-27 Thread Emil Abildgaard Svendsen
On Thu, Oct 26, 2023 at 09:11:53PM +0200, Frieder Schrempf wrote: > [You don't often get email from frieder.schre...@kontron.de. Learn why this > is important at https://aka.ms/LearnAboutSenderIdentification ] > > On 26.10.23 13:30, Emil Abildgaard Svendsen wrote: > > [Sie erhalten nicht häufig

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-27 Thread Javier Martinez Canillas
Jocelyn Falempe writes: > Hi, > > On 21/10/2023 00:52, Javier Martinez Canillas wrote: >> Avoid a possible uninitialized use of the crtc_state variable in function >> ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: >> >> drivers/gpu/drm/solomon/ssd130x.c:921 >>

Re: [PATCH] dt-bindings: display: ssd132x: Remove '-' before compatible enum

2023-10-27 Thread Javier Martinez Canillas
Rob Herring writes: > On Sat, 21 Oct 2023 00:30:17 +0200, Javier Martinez Canillas wrote: >> This is a leftover from when the binding schema had the compatible string >> property enum as a 'oneOf' child and the '-' was not removed when 'oneOf' >> got dropped during the binding review process. >>

[PATCH v4 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-10-27 Thread Sean Young
In order to introduce a pwm api which can be used from atomic context, we will need two functions for applying pwm changes: int pwm_apply_cansleep(struct pwm *, struct pwm_state *); int pwm_apply_atomic(struct pwm *, struct pwm_state *); This commit just deals with renaming

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Christian König
Am 27.10.23 um 10:22 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:44:13 +0200 Christian König wrote: Am 27.10.23 um 09:39 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:35:01 +0200 Christian König wrote: Am 27.10.23 um 09:32 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:22:12

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Michel Dänzer
On 10/26/23 21:25, Alex Goins wrote: > On Thu, 26 Oct 2023, Sebastian Wick wrote: >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: >>> On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) >>> Alex Goins wrote: >>> Despite being programmable, the LUTs are updated in a manner that is

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
Hi Danilo, On Thu, 26 Oct 2023 18:13:00 +0200 Danilo Krummrich wrote: > Currently, job flow control is implemented simply by limiting the number > of jobs in flight. Therefore, a scheduler is initialized with a credit > limit that corresponds to the number of jobs which can be sent to the >

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
On Fri, 27 Oct 2023 09:44:13 +0200 Christian König wrote: > Am 27.10.23 um 09:39 schrieb Boris Brezillon: > > On Fri, 27 Oct 2023 09:35:01 +0200 > > Christian König wrote: > > > >> Am 27.10.23 um 09:32 schrieb Boris Brezillon: > >>> On Fri, 27 Oct 2023 09:22:12 +0200 > >>> Christian König

Re: [PATCH] drm/ssd130x: Fix possible uninitialized usage of crtc_state variable

2023-10-27 Thread Jocelyn Falempe
Hi, On 21/10/2023 00:52, Javier Martinez Canillas wrote: Avoid a possible uninitialized use of the crtc_state variable in function ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check()

Re: [GIT PULL v2] drm: renesas: shmobile: Atomic conversion + DT support (was: Re: [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support)

2023-10-27 Thread Geert Uytterhoeven
Hi David, Daniel, On Tue, Oct 24, 2023 at 12:08 PM Geert Uytterhoeven wrote: > On Mon, Oct 16, 2023 at 11:59 AM Geert Uytterhoeven > wrote: > > The following changes since commit 389af786f92ecdff35883551d54bf4e507ffcccb: > > > > Merge tag 'drm-intel-next-2023-09-29' of > >

Re: [PATCH 4/9] dma-buf: heaps: Initialise MediaTek secure heap

2023-10-27 Thread 吴勇
On Thu, 2023-10-26 at 10:18 +0530, Vijayanand Jitta wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 10/20/2023 3:29 PM, Yong Wu (吴勇) wrote: > > On Thu, 2023-10-19 at 10:15 +0530, Vijayanand Jitta

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Christian König
Am 27.10.23 um 09:39 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:35:01 +0200 Christian König wrote: Am 27.10.23 um 09:32 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:22:12 +0200 Christian König wrote: + + /** +* @update_job_credits: Called once the scheduler is

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
On Fri, 27 Oct 2023 09:35:01 +0200 Christian König wrote: > Am 27.10.23 um 09:32 schrieb Boris Brezillon: > > On Fri, 27 Oct 2023 09:22:12 +0200 > > Christian König wrote: > > > >>> + > >>> + /** > >>> + * @update_job_credits: Called once the scheduler is considering this > >>> + * job for

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Christian König
Am 27.10.23 um 09:32 schrieb Boris Brezillon: On Fri, 27 Oct 2023 09:22:12 +0200 Christian König wrote: + + /** +* @update_job_credits: Called once the scheduler is considering this +* job for execution. +* +* Drivers may use this to update the job's

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
On Fri, 27 Oct 2023 09:22:12 +0200 Christian König wrote: > > + > > + /** > > +* @update_job_credits: Called once the scheduler is considering this > > +* job for execution. > > +* > > +* Drivers may use this to update the job's submission credits, which is > > +* useful to

[PATCH] drm/panel-edp: Add panel entry for AUO B116XTN02 and BOE NT116WHM-N21, 836X2 and NV116WHM-N49 V8.0

2023-10-27 Thread Sheng-Liang Pan
Add panel identification entry for - AUO B116XTN02 family (product ID:0x235c) - BOE NT116WHM-N21,836X2 (product ID:0x09c3) - BOE NV116WHM-N49 V8.0 (product ID:0x0979) Signed-off-by: Sheng-Liang Pan --- drivers/gpu/drm/panel/panel-edp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Christian König
Am 26.10.23 um 18:13 schrieb Danilo Krummrich: Currently, job flow control is implemented simply by limiting the number of jobs in flight. Therefore, a scheduler is initialized with a credit limit that corresponds to the number of jobs which can be sent to the hardware. This implies that for

[PULL] drm-misc-next

2023-10-27 Thread Maarten Lankhorst
drm-misc-next-2023-10-27: drm-misc-next for v6.7-rc1: drm-misc-next-2023-10-19 + following: UAPI Changes: Cross-subsystem Changes: - Convert fbdev drivers to use fbdev i/o mem helpers. Core Changes: - Use cross-references for macros in docs. - Make drm_client_buffer_addb use addfb2. - Add

Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
Hi Danilo, On Thu, 26 Oct 2023 18:13:00 +0200 Danilo Krummrich wrote: > + > + /** > + * @update_job_credits: Called once the scheduler is considering this > + * job for execution. > + * > + * Drivers may use this to update the job's submission credits, which is > +

Re: [PATCH drm-misc-next v2] drm/sched: implement dynamic job-flow control

2023-10-27 Thread Boris Brezillon
Hi Danilo, On Tue, 24 Oct 2023 00:57:47 +0200 Danilo Krummrich wrote: > > > + > > > + /** > > > + * @update_job_credits: Called once the scheduler is considering this > > > + * job for execution. > > > + * > > > + * Drivers may use this to update the job's submission credits, which is > > >

Re: [Intel-gfx] [PATCH] drm/i915: Skip pxp init if gt is wedged

2023-10-27 Thread Jani Nikula
On Thu, 26 Oct 2023, Zhanjun Dong wrote: > gt wedged is fatal error, skip the pxp init on this situation. More information is needed in the commit message. When do you encounter this situation? I'll note that nobody checks intel_pxp_init() return status, so this silently skips PXP. BR, Jani.

Re: [PATCH] MAINTAINERS: Update the GPU Scheduler email

2023-10-27 Thread Christian König
Am 26.10.23 um 21:32 schrieb Alex Deucher: On Thu, Oct 26, 2023 at 1:45 PM Luben Tuikov wrote: Update the GPU Scheduler maintainer email. Cc: Alex Deucher Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Cc: AMD Graphics Cc: Direct Rendering Infrastructure - Development

Re: [git pull] drm fixes for 6.6 final

2023-10-27 Thread pr-tracker-bot
The pull request you sent on Fri, 27 Oct 2023 16:15:45 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-10-27 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/750b95887e567848ac2c851dae47922cac6db946 Thank you! -- Deet-doot-dot, I am a bot.

[git pull] drm fixes for 6.6 final

2023-10-27 Thread Dave Airlie
Hi Linus, This is the final set of fixes for 6.6, just misc bits mainly in amdgpu and i915, nothing too noteworthy. Dave. drm-fixes-2023-10-27: drm fixes for 6.6 final amdgpu: - ignore duplicated BOs in CS parser - remove redundant call to amdgpu_ctx_priority_is_valid() - Extend VI APSM quirks

<    1   2