Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-11-07 Thread Uwe Kleine-König
Hello Inki, On Wed, Nov 08, 2023 at 01:16:18PM +0900, Inki Dae wrote: > Sorry for late. There was a merge conflict so I fixed it manually and > merged. And seems your patch description is duplicated so dropped > duplicated one. Ah. I have a template that generates one patch per driver. I guess

[PATCH] nouveau/gsp/r535: Fix a NULL vs error pointer bug

2023-11-07 Thread Dan Carpenter
The r535_gsp_cmdq_get() function returns error pointers but this code checks for NULL. Also we need to propagate the error pointer back to the callers in r535_gsp_rpc_get(). Returning NULL will lead to a NULL pointer dereference. Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for

[PATCH v9 4/6] drm/i915/panelreplay: Enable panel replay dpcd initialization for DP

2023-11-07 Thread Animesh Manna
Due to similarity panel replay dpcd initialization got added in psr function which is specific for edp panel. This patch enables panel replay initialization for dp connector. Cc: Jouni Högander Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Animesh Manna ---

[PATCH v9 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-11-07 Thread Animesh Manna
Add debugfs support which will print source and sink status per connector basis. Existing i915_psr_status and i915_psr_sink_status will be used to get the source and sink status of panel replay. v1: Initial version. [rb-ed by Arun] v2: Added check for DP 2.0 and connector type in

[PATCH v9 5/6] drm/i915/panelreplay: enable/disable panel replay

2023-11-07 Thread Animesh Manna
TRANS_DP2_CTL register is programmed to enable panel replay from source and sink is enabled through panel replay dpcd configuration address. Bspec: 1407940617 v1: Initial version. v2: - Use pr_* flags instead psr_* flags. [Jouni] - Remove intel_dp_is_edp check as edp1.5 also has panel replay.

[PATCH v9 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

2023-11-07 Thread Animesh Manna
Modify existing PSR implementation to enable panel replay feature of DP 2.0 which is similar to PSR feature of EDP panel. There is different DPCD address to check panel capability compare to PSR and vsc sdp header is different. v1: Initial version. v2: - Set source_panel_replay_support flag under

[PATCH v9 2/6] drm/i915/psr: Move psr specific dpcd init into own function

2023-11-07 Thread Animesh Manna
From: Jouni Högander This patch is preparing adding panel replay specific dpcd init. Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 41 +--- 1 file changed, 23 insertions(+), 18

[PATCH v9 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-11-07 Thread Animesh Manna
Add DPCD register definition for discovering, enabling and checking status of panel replay of the sink. Cc: Jouni Högander Cc: Arun R Murthy Cc: Jani Nikula Reviewed-by: Arun R Murthy Signed-off-by: Animesh Manna --- include/drm/display/drm_dp.h | 23 +++ 1 file changed,

[PATCH v9 0/6] Panel replay phase1 implementation

2023-11-07 Thread Animesh Manna
Panel Replay is a power saving feature for DP 2.0 monitor and similar to PSR on EDP. These patches are basic enablement patches added on top of existing psr framework to enable full-screen live active frame update mode of panel replay. Panel replay also can be enabled in selective update mode

Re: [PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-07 Thread Greg KH
On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote: > The following case seems to be safe to be replaced with a flexible array > to clean up the added coccinelle warning. This patch will just do it. > > drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h:76:38-63: WARNING use >

Re: [PATCH v2] drm/mediatek: Add spinlock for setting vblank event in atomic_begin

2023-11-07 Thread 胡俊光

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread José Pekkarinen
On 2023-11-07 20:03, Guenter Roeck wrote: On 11/7/23 09:26, José Pekkarinen wrote: On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also

[PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-07 Thread José Pekkarinen
While the structures affected seems to be unused along the driver the following patch will care of replacing their members to flexible array, removing the following warnings: drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h:169:47-54: WARNING use flexible-array member instead

Re: [PATCH] drm/qxl: prevent memory leak

2023-11-07 Thread Zongmin Zhou
Thanks for your reply. Best regards! On 2023/11/6 17:49, Maxime Ripard wrote: Hi, On Wed, Nov 01, 2023 at 12:58:17PM +1000, Dave Airlie wrote: On Wed, 22 Mar 2023 at 19:04, Zongmin Zhou wrote: The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object

[PATCH] drm/amdgpu: remove unused MES_LOG_BUFFER struct

2023-11-07 Thread José Pekkarinen
The mention struct seems not to be used along the driver, and is also triggering a warning to migrate to flexible array. This patch will remove the full structure and get rid of the warning. drivers/gpu/drm/amd/include/mes_v11_api_def.h:192:27-34: WARNING use flexible-array member instead

[PATCH] drm/amd/pm: replace 1-element arrays with flexible-array members

2023-11-07 Thread José Pekkarinen
The following case seems to be safe to be replaced with a flexible array to clean up the added coccinelle warning. This patch will just do it. drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h:76:38-63: WARNING use flexible-array member instead

Re: [PATCH] drm/sched: fix potential page fault in drm_sched_job_init()

2023-11-07 Thread Luben Tuikov
On 2023-11-08 00:46, Luben Tuikov wrote: > Hi, > > Could you please use my gmail address, the one one I'm responding from--I > don't want > to miss any DRM scheduler patches. BTW, the luben.tui...@amd.com email should > bounce > as undeliverable. > > On 2023-11-07 21:26, Danilo Krummrich

Re: [PATCH] drm/sched: fix potential page fault in drm_sched_job_init()

2023-11-07 Thread Luben Tuikov
Hi, Could you please use my gmail address, the one one I'm responding from--I don't want to miss any DRM scheduler patches. BTW, the luben.tui...@amd.com email should bounce as undeliverable. On 2023-11-07 21:26, Danilo Krummrich wrote: > Commit 56e449603f0a ("drm/sched: Convert the GPU

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-07 Thread Evan Preston
On 2023-11-06 Mon 09:39pm, Evan Preston wrote: > Hi Huacai, > > On 2023-11-07 Tue 09:49am, Huacai Chen wrote: > > Hi, Evan, > > > > On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > > > > > Hi Huacai, > > > > > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > > > On Mon, Nov 6, 2023 at

Re: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-11-07 Thread Inki Dae
Hi, Sorry for late. There was a merge conflict so I fixed it manually and merged. And seems your patch description is duplicated so dropped duplicated one. Thanks, Inki Dae 2023년 11월 3일 (금) 오전 1:57, Uwe Kleine-König 님이 작성: > The .remove() callback for a platform driver returns an int which

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Yunsheng Lin
On 2023/11/8 6:10, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: >> >> On 11/5/23 7:44 PM, Mina Almasry wrote: >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>> index eeeda849115c..1c351c138a5b 100644 >>> --- a/include/linux/netdevice.h >>> +++

Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-07 Thread Lazar, Lijo
On 11/7/2023 9:58 PM, Hunter Chasens wrote: Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-07 Thread Yunsheng Lin
On 2023/11/8 5:59, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 11:46 PM Yunsheng Lin wrote: >> >> On 2023/11/6 10:44, Mina Almasry wrote: >>> + >>> +void __netdev_devmem_binding_free(struct netdev_dmabuf_binding *binding) >>> +{ >>> + size_t size, avail; >>> + >>> +

Re: [PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-07 Thread Luben Tuikov
On 2023-11-07 12:53, Danilo Krummrich wrote: > On 11/7/23 05:10, Luben Tuikov wrote: >> Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, >> rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let >> it do just that, schedule the work item for

Re: [PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-07 Thread Luben Tuikov
On 2023-11-07 06:48, Matthew Brost wrote: > On Mon, Nov 06, 2023 at 11:10:21PM -0500, Luben Tuikov wrote: >> Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, >> rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let >> it do just that, schedule

Re: Blank screen on boot of Linux 6.5 and later on Lenovo ThinkPad L570

2023-11-07 Thread Huacai Chen
Hi, Thorsten and Jaak, On Tue, Nov 7, 2023 at 4:32 AM Evan Preston wrote: > > Hi Huacai, > > On 2023-11-06 Mon 10:22pm, Huacai Chen wrote: > > On Mon, Nov 6, 2023 at 9:49 PM Jaak Ristioja wrote: > > > > > > On 06.11.23 04:15, Huacai Chen wrote: > > > > Hi, Jaak and Evan, > > > > > > > > On Mon,

[PATCH] drm/Makefile: Move tiny drivers before native drivers

2023-11-07 Thread Huacai Chen
After commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync") some Lenovo laptops get a blank screen until the display manager starts. This regression occurs with such a Kconfig combination: CONFIG_SYSFB=y CONFIG_SYSFB_SIMPLEFB=y

[PATCH] drm/sched: fix potential page fault in drm_sched_job_init()

2023-11-07 Thread Danilo Krummrich
Commit 56e449603f0a ("drm/sched: Convert the GPU scheduler to variable number of run-queues") introduces drm_err() in drm_sched_job_init(), in order to indicate that the given entity has no runq, however at this time job->sched is not yet set, likely to be NULL initialized, and hence shouldn't be

Re: [git pull] drm next + fixes for 6.7-rc1

2023-11-07 Thread pr-tracker-bot
The pull request you sent on Tue, 7 Nov 2023 12:03:00 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2023-11-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/25b6377007ebe1c3ede773fd6979f613386db000 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-07 Thread Danilo Krummrich
On 11/7/23 05:10, Luben Tuikov wrote: Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let it do just that, schedule the work item for execution. The problem is that drm_sched_run_job_queue()

[PATCH drm-misc-next v9 12/12] drm/nouveau: use GPUVM common infrastructure

2023-11-07 Thread Danilo Krummrich
GPUVM provides common infrastructure to track external and evicted GEM objects as well as locking and validation helpers. Especially external and evicted object tracking is a huge improvement compared to the current brute force approach of iterating all mappings in order to lock and validate the

[PATCH drm-misc-next v9 11/12] drm/gpuvm: track/lock/validate external/evicted objects

2023-11-07 Thread Danilo Krummrich
Currently the DRM GPUVM offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more complex mapping operations on the GPU VA space. However, there are more design patterns commonly used by drivers, which can

[PATCH drm-misc-next v9 10/12] drm/gpuvm: add an abstraction for a VM / BO combination

2023-11-07 Thread Danilo Krummrich
Add an abstraction layer between the drm_gpuva mappings of a particular drm_gem_object and this GEM object itself. The abstraction represents a combination of a drm_gem_object and drm_gpuvm. The drm_gem_object holds a list of drm_gpuvm_bo structures (the structure representing this abstraction),

[PATCH drm-misc-next v9 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-07 Thread Danilo Krummrich
Implement reference counting for struct drm_gpuvm. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c| 56 +- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 20 ++--- include/drm/drm_gpuvm.h| 31 +- 3 files changed, 90

[PATCH drm-misc-next v9 08/12] drm/nouveau: separately allocate struct nouveau_uvmm

2023-11-07 Thread Danilo Krummrich
Allocate struct nouveau_uvmm separately in preparation for subsequent commits introducing reference counting for struct drm_gpuvm. While at it, get rid of nouveau_uvmm_init() as indirection of nouveau_uvmm_ioctl_vm_init() and perform some minor cleanups. Reviewed-by: Dave Airlie Signed-off-by:

[PATCH drm-misc-next v9 07/12] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm

2023-11-07 Thread Danilo Krummrich
Introduce flags for struct drm_gpuvm, this required by subsequent commits. Reviewed-by: Boris Brezillon Reviewed-by: Thomas Hellström Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c| 3 +++ drivers/gpu/drm/nouveau/nouveau_uvmm.c | 2 +- include/drm/drm_gpuvm.h

[PATCH drm-misc-next v9 06/12] drm/nouveau: make use of the GPUVM's shared dma-resv

2023-11-07 Thread Danilo Krummrich
DRM GEM objects private to a single GPUVM can use a shared dma-resv. Make use of the shared dma-resv of GPUVM rather than a driver specific one. The shared dma-resv originates from a "root" GEM object serving as container for the dma-resv to make it compatible with drm_exec. In order to make

[PATCH drm-misc-next v9 05/12] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-11-07 Thread Danilo Krummrich
Provide a common dma-resv for GEM objects not being used outside of this GPU-VM. This is used in a subsequent patch to generalize dma-resv, external and evicted object handling and GEM validation. Reviewed-by: Boris Brezillon Reviewed-by: Thomas Hellström Signed-off-by: Danilo Krummrich ---

[PATCH drm-misc-next v9 04/12] drm/nouveau: make use of drm_gpuvm_range_valid()

2023-11-07 Thread Danilo Krummrich
Use drm_gpuvm_range_valid() in order to validate userspace requests. Reviewed-by: Dave Airlie Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_uvmm.c | 17 + drivers/gpu/drm/nouveau/nouveau_uvmm.h | 3 --- 2 files changed, 1 insertion(+), 19 deletions(-)

[PATCH drm-misc-next v9 03/12] drm/gpuvm: export drm_gpuvm_range_valid()

2023-11-07 Thread Danilo Krummrich
Drivers may use this function to validate userspace requests in advance, hence export it. Reviewed-by: Thomas Hellström Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c | 14 +- include/drm/drm_gpuvm.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-)

[PATCH drm-misc-next v9 02/12] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow()

2023-11-07 Thread Danilo Krummrich
Don't always WARN in drm_gpuvm_check_overflow() and separate it into a drm_gpuvm_check_overflow() and a dedicated drm_gpuvm_warn_check_overflow() variant. This avoids printing warnings due to invalid userspace requests. Reviewed-by: Thomas Hellström Signed-off-by: Danilo Krummrich ---

[PATCH drm-misc-next v9 01/12] drm/gpuvm: convert WARN() to drm_WARN() variants

2023-11-07 Thread Danilo Krummrich
Use drm_WARN() and drm_WARN_ON() variants to indicate drivers the context the failing VM resides in. Reviewed-by: Boris Brezillon Reviewed-by: Thomas Hellström Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_gpuvm.c| 32 ++

[PATCH drm-misc-next v9 00/12] [RFC] DRM GPUVM features

2023-11-07 Thread Danilo Krummrich
Currently GPUVM offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more complex mapping operations on the GPU VA space. However, there are more design patterns commonly used by drivers, which can

Fwd: 01f05940a9a75e11a2be64993c44ad8dd06e6e26 causes Wayland servers to flicker in non-gl virtio QEMU cards

2023-11-07 Thread Bagas Sanjaya
Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > It seems that commit 01f05940a9a75e11a2be64993c44ad8dd06e6e26 introduced an > issue impacting wlroots and Weston (possibly others) on QEMU with the virtio > card. happens on QEMU, and it happens in virt-manager when I do NOT

Re: [PATCH 0/3] drm/ci: Add support for SM8250 Gitlab Runner

2023-11-07 Thread Jessica Zhang
On 11/6/2023 9:35 AM, Jessica Zhang wrote: On 11/4/2023 6:02 AM, Helen Koike wrote: Hi Jessica, On 10/10/2023 19:25, Jessica Zhang wrote: Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will be hosted and maintained in Qualcomm labs. This series will add a

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-07 Thread David Ahern
On 11/7/23 5:02 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 1:02 PM Stanislav Fomichev wrote: >> >> On 11/05, Mina Almasry wrote: >>> +static inline bool page_is_page_pool_iov(const struct page *page) >>> +{ >>> + return (unsigned long)page & PP_DEVMEM; >>> +} >> >> Speaking of bpf: one

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 1:02 PM Stanislav Fomichev wrote: > > On 11/05, Mina Almasry wrote: > > +static inline bool page_is_page_pool_iov(const struct page *page) > > +{ > > + return (unsigned long)page & PP_DEVMEM; > > +} > > Speaking of bpf: one thing that might be problematic with this

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-07 Thread David Ahern
On 11/7/23 4:55 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 4:03 PM Willem de Bruijn > wrote: >> >> On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: >>> >>> On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > The concise notification API returns tokens as a range for > compression,

Re: [Nouveau] [PATCH] nouveau/gsp: fix UBSAN array bounds warning in PACKED_REGISTRY_TABLE

2023-11-07 Thread Timur Tabi
On Wed, 2023-11-08 at 00:52 +0100, Danilo Krummrich wrote: > On 11/8/23 00:47, Timur Tabi wrote: > > Change PACKED_REGISTRY_TABLE so that its last member is a variable- > > length > > array instead of a zero-length array.  UBSAN treats zero-length arrays > > literally and warns if they are

Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-07 Thread Bagas Sanjaya
On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote: > Resolves Sphinx unexpected indentation warning when compiling > documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds > a literal block to keep vertical formatting of the > example power state list. > >

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:03 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: > > > > On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > > >> The concise notification API returns tokens as a range for > > >> compression, encoding as two 32-bit unsigned integers start

Re: [Nouveau] [PATCH] nouveau/gsp: fix UBSAN array bounds warning in PACKED_REGISTRY_TABLE

2023-11-07 Thread Danilo Krummrich
On 11/8/23 00:47, Timur Tabi wrote: Change PACKED_REGISTRY_TABLE so that its last member is a variable-length array instead of a zero-length array. UBSAN treats zero-length arrays literally and warns if they are dereferenced. Changing the "[0]" to "[]" tells the compiler that the array is

[PATCH] nouveau/gsp: fix UBSAN array bounds warning in PACKED_REGISTRY_TABLE

2023-11-07 Thread Timur Tabi
Change PACKED_REGISTRY_TABLE so that its last member is a variable-length array instead of a zero-length array. UBSAN treats zero-length arrays literally and warns if they are dereferenced. Changing the "[0]" to "[]" tells the compiler that the array is variable-length. This fixes the following

Re: [Nouveau] [PATCH] nouveau: use an rwlock for the event lock.

2023-11-07 Thread Danilo Krummrich
On 11/7/23 06:32, Dave Airlie wrote: From: Dave Airlie This allows it to break the following circular locking dependency. Aug 10 07:01:29 dg1test kernel: == Aug 10 07:01:29 dg1test kernel: WARNING: possible circular locking dependency

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

2023-11-07 Thread Mikhail Gavrilov
On Wed, Nov 8, 2023 at 12:12 AM Alex Deucher wrote: > > The attached patch should fix it. Not sure why your GPU shows up as > busy. The AGP aperture was just disabled. Tested-by: Mikhail Gavrilov Thanks, after applying the patch GPU loading meets expectations. Games are working so overall all

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 2:55 PM David Ahern wrote: > > On 11/7/23 3:10 PM, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: > >> > >> On 11/5/23 7:44 PM, Mina Almasry wrote: > >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > >>> index

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread David Ahern
On 11/7/23 3:10 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: >> >> On 11/5/23 7:44 PM, Mina Almasry wrote: >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>> index eeeda849115c..1c351c138a5b 100644 >>> --- a/include/linux/netdevice.h >>> +++

Re: [PATCH v5 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Tue, 2023-11-07 at 02:14 +0200, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On >

Re: [PATCH v4 09/30] drm/dp: Add helpers to calculate the link BW overhead

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote: > Add helpers drivers can use to calculate the BW allocation overhead - > due to SSC, FEC, DSC and data alignment on symbol cycles - and the > channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On >

Re: [PATCH v4 08/30] drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote: > Add a quirk for Synaptics MST hubs, which require a workaround - at leat > on i915 - for some modes, on which the hub applies HBLANK expansion. > These modes will only work by enabling DSC decompression for them, a >

Re: [PATCH v4 07/30] drm/dp: Add DP_HBLANK_EXPANSION_CAPABLE and DSC_PASSTHROUGH_EN DPCD flags

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote: > Add the DPCD flag to enable DSC passthrough in a last branch device, > used in a follow-up i915 patch. > > Also add a flag to detect HBLANK expansion support in a branch device, > used by a workaround in a follow-up

Re: [PATCH v4 06/30] drm/dp_mst: Allow DSC in any Synaptics last branch device

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote: > The Synaptics MST branch devices support DSC decompression on all their > output ports, provided that they are last branch devices (with their > output ports connected to the sinks). The Thinkpad 40B0 TBT dock for >

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Eric Dumazet wrote: > On Tue, Nov 7, 2023 at 10:05 PM Stanislav Fomichev wrote: > > > > > I don't understand. We require an elaborate setup to receive devmem cmsgs, > > why would some random application receive those? > > > A TCP socket can receive 'valid TCP packets' from many

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: > > On 11/5/23 7:44 PM, Mina Almasry wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index eeeda849115c..1c351c138a5b 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -843,6

Re: [PATCH] drm/ttm: Schedule delayed_delete worker closer

2023-11-07 Thread Felix Kuehling
On 2023-11-07 14:45, Rajneesh Bhardwaj wrote: When a TTM BO is getting freed, to optimize the clearing operation on the workqueue, schedule it closer to a NUMA node where the memory was allocated. This avoids the cases where the ttm_bo_delayed_delete gets scheduled on the CPU cores that are

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 11:46 PM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > + > > +void __netdev_devmem_binding_free(struct netdev_dmabuf_binding *binding) > > +{ > > + size_t size, avail; > > + > > + gen_pool_for_each_chunk(binding->chunk_pool, > > +

Re: [RFC PATCH v3 07/12] page-pool: device memory support

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 12:00 AM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > Overload the LSB of struct page* to indicate that it's a page_pool_iov. > > > > Refactor mm calls on struct page* into helpers, and add page_pool_iov > > handling on those helpers. Modify callers

[PATCH] drm: i915: Adapt to -Walloc-size

2023-11-07 Thread Sam James
GCC 14 introduces a new -Walloc-size included in -Wextra which errors out like: ``` drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c: In function ‘eb_copy_relocations’: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1681:24: error: allocation of insufficient size ‘1’ for type ‘struct

Re: [PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Hsin-Yi Wang
On Tue, Nov 7, 2023 at 12:57 PM Greg KH wrote: > > On Tue, Nov 07, 2023 at 12:41:53PM -0800, Hsin-Yi Wang wrote: > > Add a few generic edp panels used by mt8186 chromebooks. > > > > Signed-off-by: Hsin-Yi Wang > > Reviewed-by: Douglas Anderson > > --- > > no change. > > --- > >

Re: [PATCH v3 2/6] dt-bindings: display/msm: Add reg bus and rotator interconnects

2023-11-07 Thread Konrad Dybcio
On 11/6/23 16:45, Neil Armstrong wrote: Hi, On 28/09/2023 13:35, Dmitry Baryshkov wrote: From: Konrad Dybcio Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are other connection paths: - a path that connects rotator block to the DDR. - a path that needs to be handled to

[PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-07 Thread Hunter Chasens
Resolves Sphinx unexpected indentation warning when compiling documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds a literal block to keep vertical formatting of the example power state list. Signed-off-by: Hunter Chasens --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-07 Thread Dmitry Baryshkov
On Tue, 7 Nov 2023 at 23:01, Kuogee Hsieh wrote: > > > On 11/6/2023 5:55 PM, Dmitry Baryshkov wrote: > > On Sat, 7 Oct 2023 at 01:55, Kuogee Hsieh wrote: > >> The purpose of this patch series is to incorporate pm runtime framework > >> into MSM eDP/DP driver so that eDP panel can be detected by

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 1:00 AM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > Make skb_frag_page() fail in the case where the frag is not backed > > by a page, and fix its relevent callers to handle this case. > > > > Correctly handle skb_frag refcounting in the

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Eric Dumazet
On Tue, Nov 7, 2023 at 10:05 PM Stanislav Fomichev wrote: > > I don't understand. We require an elaborate setup to receive devmem cmsgs, > why would some random application receive those? A TCP socket can receive 'valid TCP packets' from many different sources, especially with BPF hooks...

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-07 Thread Sebastian Wick
On Tue, Nov 07, 2023 at 11:52:11AM -0500, Harry Wentland wrote: > > > On 2023-10-26 13:30, Sebastian Wick wrote: > > On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > >> On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) > >> Alex Goins wrote: > >> > >>> Thank you Harry and all other

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 5:06 PM Stanislav Fomichev wrote: > [..] > > > > > And the socket has to know this association; otherwise those tokens > > > > > are useless since they don't carry anything to identify the dmabuf. > > > > > > > > > > I think my other issue

Re: [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-07 Thread Kuogee Hsieh
On 11/6/2023 5:55 PM, Dmitry Baryshkov wrote: On Sat, 7 Oct 2023 at 01:55, Kuogee Hsieh wrote: The purpose of this patch series is to incorporate pm runtime framework into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel driver during system probe time. During

Re: [PATCH v6 4/5] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:54PM -0800, Hsin-Yi Wang wrote: > Generic edp gets mode from edid. However, some panels report incorrect > mode in this way, resulting in glitches on panel. Introduce a new quirk > additional_mode to the generic edid to pick a correct hardcoded mode. > >

Re: [PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Greg KH
On Tue, Nov 07, 2023 at 12:41:53PM -0800, Hsin-Yi Wang wrote: > Add a few generic edp panels used by mt8186 chromebooks. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Douglas Anderson > --- > no change. > --- > drivers/gpu/drm/panel/panel-edp.c | 51 +++ > 1 file

[PATCH v6 3/5] drm/panel-edp: drm/panel-edp: Add several generic edp panels

2023-11-07 Thread Hsin-Yi Wang
Add a few generic edp panels used by mt8186 chromebooks. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- no change. --- drivers/gpu/drm/panel/panel-edp.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c

[PATCH v6 5/5] drm/panel-edp: Avoid adding multiple preferred modes

2023-11-07 Thread Hsin-Yi Wang
If a non generic edp-panel is under aux-bus, the mode read from edid would still be selected as preferred and results in multiple preferred modes, which is ambiguous. If both hard-coded mode and edid exists, only add mode from hard-coded. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas

[PATCH v6 4/5] drm/panel-edp: Add override_edid_mode quirk for generic edp

2023-11-07 Thread Hsin-Yi Wang
Generic edp gets mode from edid. However, some panels report incorrect mode in this way, resulting in glitches on panel. Introduce a new quirk additional_mode to the generic edid to pick a correct hardcoded mode. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- no change. ---

[PATCH v6 1/5] drm/panel-edp: drm/panel-edp: Fix AUO B116XAK01 name and timing

2023-11-07 Thread Hsin-Yi Wang
Rename AUO 0x405c B116XAK01 to B116XAK01.0 and adjust the timing of auo_b116xak01: T3=200, T12=500, T7_max = 50 according to decoding edid and datasheet. Fixes: da458286a5e2 ("drm/panel: Add support for AUO B116XAK01 panel") Cc: sta...@vger.kernel.org Signed-off-by: Hsin-Yi Wang Reviewed-by:

[PATCH v6 2/5] drm/panel-edp: drm/panel-edp: Fix AUO B116XTN02 name

2023-11-07 Thread Hsin-Yi Wang
Rename AUO 0x235c B116XTN02 to B116XTN02.3 according to decoding edid. Fixes: 3db2420422a5 ("drm/panel-edp: Add AUO B116XTN02, BOE NT116WHM-N21,836X2, NV116WHM-N49 V8.0") Cc: sta...@vger.kernel.org Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- v5->v6: split to 2 patches. ---

[PATCH v6 0/5] Add a few panels and use correct modes

2023-11-07 Thread Hsin-Yi Wang
This series contains following patches: 1-2. Fix 2 panel naming and timing. 3. Add a few new generic edp panels. 4. Support a new quirk to override the mode read from edid 5. Only add hard-coded mode if both edid and hard-coded modes presents. v1:

Re: [PATCH] drm/amd/display: clean up redundant conversions to bool

2023-11-07 Thread José Pekkarinen
On 2023-11-07 17:39, Alex Deucher wrote: On Tue, Nov 7, 2023 at 4:44 AM José Pekkarinen wrote: This patch will address the following couple of warnings retrieved by using coccinelle, where there is an explicit conversion to bool that are redundant.

Re: [PATCH 02/22] fb: atmel_lcdfb: Stop using platform_driver_probe()

2023-11-07 Thread Helge Deller
On 11/7/23 21:01, Uwe Kleine-König wrote: On Tue, Nov 07, 2023 at 10:17:43AM +0100, Uwe Kleine-König wrote: On today's platforms the benefit of platform_driver_probe() isn't that relevant any more. It allows to drop some code after booting (or module loading) for .probe() and discard the

Re: [PATCH v2] drm: amd: Resolve Sphinx unexpected indentation warning

2023-11-07 Thread Hunter Chasens
On Monday, November 6, 2023 11:45:24 PM EST Lazar, Lijo wrote: > On 11/7/2023 1:47 AM, Hunter Chasens wrote: > > Resolves Sphinx unexpected indentation warning when compiling > > documentation (e.g. `make htmldocs`). Replaces tabs with spaces and > > adds > > a literal block to keep vertical

Re: [PATCH 02/22] fb: atmel_lcdfb: Stop using platform_driver_probe()

2023-11-07 Thread Uwe Kleine-König
On Tue, Nov 07, 2023 at 10:17:43AM +0100, Uwe Kleine-König wrote: > On today's platforms the benefit of platform_driver_probe() isn't that > relevant any more. It allows to drop some code after booting (or module > loading) for .probe() and discard the .remove() function completely if > the driver

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 5:06 PM Stanislav Fomichev wrote: [..] > > > > And the socket has to know this association; otherwise those tokens > > > > are useless since they don't carry anything to identify the dmabuf. > > > > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is

[PATCH] drm/ttm: Schedule delayed_delete worker closer

2023-11-07 Thread Rajneesh Bhardwaj
When a TTM BO is getting freed, to optimize the clearing operation on the workqueue, schedule it closer to a NUMA node where the memory was allocated. This avoids the cases where the ttm_bo_delayed_delete gets scheduled on the CPU cores that are across interconnect boundaries such as xGMI, PCIe

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 1:18 PM Mikhail Gavrilov wrote: > > On Mon, Nov 6, 2023 at 8:29 PM Alex Deucher wrote: > > > > Already fixed in this commit: > > https://gitlab.freedesktop.org/agd5f/linux/-/commit/d1d4c0b7b65b7fab2bc6f97af9e823b1c42ccdb0 > > Which is in included in last weeks PR. > > > >

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Timur Tabi
On Wed, 2023-11-08 at 04:54 +1000, Dave Airlie wrote: yes that is probably the right answer for this, if we want to reuse the structs that we get from the nvidia driver. ok, I'll submit a patch.

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Dave Airlie
On Wed, 8 Nov 2023 at 04:51, Timur Tabi wrote: > > On Tue, 2023-10-31 at 15:18 +1000, Dave Airlie wrote: > > + strings = (char *)>entries[NV_GSP_REG_NUM_ENTRIES]; > > > I get a UBSAN index-out-of-bounds error on boot at this line. > > [ 17.765746] nouveau :65:00.0: gsp: cmdq: wptr 1 > [

Re: [Nouveau] [PATCH 3/3] nouveau/gsp: add some basic registry entries.

2023-11-07 Thread Timur Tabi
On Tue, 2023-10-31 at 15:18 +1000, Dave Airlie wrote: + strings = (char *)>entries[NV_GSP_REG_NUM_ENTRIES]; I get a UBSAN index-out-of-bounds error on boot at this line. [ 17.765746] nouveau :65:00.0: gsp: cmdq: wptr 1 [ 17.765748]

Re: [PATCH] drm/sched: Don't disturb the entity when in RR-mode scheduling

2023-11-07 Thread Matthew Brost
On Mon, Nov 06, 2023 at 11:10:21PM -0500, Luben Tuikov wrote: > Don't call drm_sched_select_entity() in drm_sched_run_job_queue(). In fact, > rename __drm_sched_run_job_queue() to just drm_sched_run_job_queue(), and let > it do just that, schedule the work item for execution. > > The problem is

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

2023-11-07 Thread Aradhya Bhatia
Hi Sam, On 07-Nov-23 21:11, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Nov 07, 2023 at 01:17:03AM +0530, Aradhya Bhatia wrote: >> Hi Sam, >> >> Thank you for the suggestion! >> >> On 06-Nov-23 18:08, Sam Ravnborg wrote: >>> Hi Aradhya, >>> >>> On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

2023-11-07 Thread Mikhail Gavrilov
On Mon, Nov 6, 2023 at 8:29 PM Alex Deucher wrote: > > Already fixed in this commit: > https://gitlab.freedesktop.org/agd5f/linux/-/commit/d1d4c0b7b65b7fab2bc6f97af9e823b1c42ccdb0 > Which is in included in last weeks PR. > Thanks, it fixed the issue above. But, unfortunately this is not the only

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Willem de Bruijn wrote: > On Tue, Nov 7, 2023 at 12:44 PM Stanislav Fomichev wrote: > > > > On 11/06, Willem de Bruijn wrote: > > > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is > > > > > > > that > > > > > > > it somehow implies that I have an option of

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread Guenter Roeck
On 11/7/23 09:26, José Pekkarinen wrote: On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative

  1   2   3   >