[PATCH] drm/i915: eliminate warnings

2023-11-12 Thread heminhong
Current, the dewake_scanline variable is defined as unsigned int, an unsigned int variable that is always greater than or equal to 0. when _intel_dsb_commit function is called by intel_dsb_commit function, the dewake_scanline variable may have an int value. So the dewake_scanline variable is

Re: [PATCH 3/8] accel/ivpu: Stop job_done_thread on suspend

2023-11-12 Thread Daniel Vetter
This conflicts with the kthread change in 6.7-rc1 6309727ef271 ("kthread: add kthread_stop_put") Please double-check that the conflict resolution I've done in drm-tip is correct and then ask drm-misc/accel maintainers to backmerge -rc2 to bake this in properly. Adding them as fyi. -Sima On Sat,

Re: [PATCH v2] Remove custom dumb_map_offset implementations in i915 driver

2023-11-12 Thread kernel test robot
Hello, kernel test robot noticed "BUG:unable_to_handle_page_fault_for_address" on: commit: a09fc21ac1126b7a5542d2653aa2c319d3bbf5f4 ("[PATCH v2] Remove custom dumb_map_offset implementations in i915 driver") url:

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-12 Thread Christian König
Am 10.11.23 um 17:57 schrieb Danilo Krummrich: On 11/10/23 09:50, Christian König wrote: [SNIP] Another issue Christian brought up is that something intended to be embeddable (a base class) shouldn't really have its own refcount. I think that's a valid point. If you at some point need to

Re: [PATCH v2 6/8] dt-bindings: reserved-memory: Add secure CMA reserved memory range

2023-11-12 Thread 吴勇
On Sat, 2023-11-11 at 13:48 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 11/11/2023 12:15, Yong Wu wrote: > > Add a binding for describing the secure CMA reserved memory

[Bug 218134] Null pointer when rearranging screen layout in XFCE.

2023-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218134 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-12 Thread Mina Almasry
On Fri, Nov 10, 2023 at 3:19 PM Jakub Kicinski wrote: > > On Sun, 5 Nov 2023 18:44:07 -0800 Mina Almasry wrote: > > #include > > #include > > +#include > > +#include > > > /** > > * DOC: skb checksums > > @@ -3402,15 +3404,38 @@ static inline void skb_frag_off_copy(skb_frag_t > >

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-12 Thread Mina Almasry
On Fri, Nov 10, 2023 at 3:16 PM Jakub Kicinski wrote: > > On Sun, 5 Nov 2023 18:44:05 -0800 Mina Almasry wrote: > > +static int mp_dmabuf_devmem_init(struct page_pool *pool) > > +{ > > + struct netdev_dmabuf_binding *binding = pool->mp_priv; > > + > > + if (!binding) > > +

Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

2023-11-12 Thread Mina Almasry
j On Fri, Nov 10, 2023 at 6:36 PM Jakub Kicinski wrote: > > On Fri, 10 Nov 2023 18:27:08 -0800 Mina Almasry wrote: > > Thanks for the clear requirement. I clearly had something different in mind. > > > > Might be dumb suggestions, but instead of creating a new ndo that we > > maybe end up

[Bug 218134] Null pointer when rearranging screen layout in XFCE.

2023-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218134 --- Comment #4 from Gerhard Mack (gm...@innerfire.net) --- I have opened the bug report as requested (https://gitlab.freedesktop.org/drm/amd/-/issues/2981) I also found this while I was digging in the logs and it was just prior to the crash: [

Re: [RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers

2023-11-12 Thread Mina Almasry
On Fri, Nov 10, 2023 at 3:19 PM Jakub Kicinski wrote: > > On Sun, 5 Nov 2023 18:44:01 -0800 Mina Almasry wrote: > > diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h > > index 6fc5134095ed..d4bea053bb7e 100644 > > --- a/include/net/page_pool/types.h > > +++

Re: (subset) [PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-11-12 Thread Michael Ellerman
On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote: > Clean up and rename fb_pgprotect() to work without struct file. Then > refactor the implementation for PowerPC. This change has been discussed > at [1] in the context of refactoring fbdev's mmap code. > > The first two patches update

[Bug 218134] Null pointer when rearranging screen layout in XFCE.

2023-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218134 Bagas Sanjaya (bagasdo...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH] Replace ioremap_cache() with memremap()

2023-11-12 Thread Wei Liu
On Wed, Nov 01, 2023 at 09:01:48AM -0700, Nischala Yelchuri wrote: > Current Hyper-V code for CoCo VMs uses ioremap_cache() to map normal memory > as decrypted. > ioremap_cache() is ideally used to map I/O device memory when it has the > characteristics > of normal memory. It should not be used

Re: Dependencies of DRM_LOONGSON

2023-11-12 Thread Sui Jingfeng
Hi, On 2023/11/11 00:58, Jean Delvare wrote: Hi Jingfeng, You recently added the loongson drm driver to the Linux kernel tree. Unlike all other loongson drivers, the drm driver doesn't have any dependency set on the platform or architecture, and is therefore proposed on all architectures. As

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-12 Thread Hans de Goede
Hi, On 11/10/23 17:58, Owen T. Heisler wrote: > Hi everyone, > > On 11/10/23 06:52, Kai-Heng Feng wrote: >> On Fri, Nov 10, 2023 at 2:19 PM Hans de Goede wrote: >>> On 11/10/23 07:09, Kai-Heng Feng wrote: On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler wrote: > #regzbot introduced:

Re: [RFC v6 0/8] DRM scheduling cgroup controller

2023-11-12 Thread Tejun Heo
Hello, >From cgroup POV, it generally looks fine to me. As before, I'm really curious whether this is something other non-intel drivers can get behind. Just one nit. On Tue, Oct 24, 2023 at 05:07:19PM +0100, Tvrtko Ursulin wrote: > * Allowing per DRM card configuration and queries is

github version complaints about the gitlab CI requirements.txt

2023-11-12 Thread Linus Torvalds
So every time I push to my github mirror, github now ends up having a 'dependabot' thing that warns about some of the CI version requirements for the gitlab automated testing file. It wants to update the pip requirements from 23.2.1 to 23.3 - When installing a package from a Mercurial VCS URL,

Re: [PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
On Sun, Nov 12, 2023 at 01:00:37PM -0500, Alex Deucher wrote: On Sun, Nov 12, 2023 at 8:27 AM Sasha Levin wrote: From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link:

[PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains

2023-11-12 Thread Krzysztof Kozlowski
Provide specific constraints for iommus and power-domains, based on current DTS. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/gpu/samsung-scaler.yaml | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains

2023-11-12 Thread Krzysztof Kozlowski
Provide specific constraints for iommus and power-domains, based on current DTS. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/gpu/samsung-g2d.yaml | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties

2023-11-12 Thread Krzysztof Kozlowski
When number of clock varies between variants, the Devicetree bindings coding convention expects to have widest constraints in top-level definition of the properties and narrow them in allOf:if:then block. This is more readable and sometimes allows to spot some errors in the bindings.

[PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention

2023-11-12 Thread Krzysztof Kozlowski
The Devicetree bindings coding convention, as used in most of the files and expressed in Documentation/devicetree/bindings/example-schema.yaml, expects "allOf:" block with if-statements after "required:" block. Re-order few schemas to match the convention to avoid repeating review comments for

[PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes

2023-11-12 Thread Krzysztof Kozlowski
Compatibles should not use quotes in the bindings. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.yaml

Re: Radeon regression in 6.6 kernel

2023-11-12 Thread Phillip Susi
Bagas Sanjaya writes: > Please show the full bisect log, and also tell why these commits are > skipped. Two of them would not compile and one would not boot. Here's the log. # bad: [4bbdb725a36b0d235f3b832bd0c1e885f0442d9f] Merge tag 'iommu-updates-v6.7' of

[Bug 218133] kernel panic when opening spotify/firefox 6.5.0.10.12 ubuntu 23.10 vega 64

2023-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218133 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Alex Deucher
On Sun, Nov 12, 2023 at 8:27 AM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] > > For pptable structs that use flexible array sizes, use flexible arrays. > > Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 >

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-12 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] > > Reported-by: Andrew Worsley > Signed-off-by: Javier Martinez Canillas > --- > drivers/of/platform.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > Forgot to include the header file and just pointed out by the robot, so

Re: [RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-11-12 Thread Tomer Tayar
On 10/11/2023 14:27, Tomer Tayar wrote: > On 20/10/2023 18:58, Aravind Iddamsetty wrote: >> Whenever a correctable or an uncorrectable error happens an event is sent >> to the corresponding listeners of these groups. >> >> v2: Rebase >> >> Signed-off-by: Aravind Iddamsetty >> --- >>

Re: [PATCH] of/platform: Disable sysfb if a simple-framebuffer node is

2023-11-12 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/of-platform-Disable-sysfb-if-a-simple-framebuffer-node-is/20231112-183751 base: https

Re: Fbdev issue after the drm updates 'drm-next-2023-10-31-1'

2023-11-12 Thread Christian Zigotzky
+ Helge Deller + Gerd Knorr + Geert Uytterhoeven On 07 November 2023 at 09:36 am, Christian Zigotzky wrote: Hello, I have found out that fbdev no longer works with virtio-gpu-pci and virtio-vga. It is not a problem with the penguin logos. Could you please check fbdev in QEMU virtual

[PATCH AUTOSEL 4.14 4/4] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 4.19 5/5] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 4.19 4/5] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 5.4 6/6] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.4 5/6] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 5.10 8/8] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.10 7/8] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 5.15 9/9] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 5.15 8/9] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 6.1 9/9] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 6.1 8/9] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

Re: [PATCH] of/platform: Disable sysfb if a simple-framebuffer node is

2023-11-12 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/of-platform-Disable-sysfb-if-a-simple-framebuffer-node-is/20231112-183751 base: https

[PATCH AUTOSEL 6.5 10/10] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 6.5 09/10] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

[PATCH AUTOSEL 6.6 10/11] drm/amd/display: Avoid NULL dereference of timing generator

2023-11-12 Thread Sasha Levin
From: Wayne Lin [ Upstream commit b1904ed480cee3f9f4036ea0e36d139cb5fee2d6 ] [Why & How] Check whether assigned timing generator is NULL or not before accessing its funcs to prevent NULL dereference. Reviewed-by: Jun Lei Acked-by: Hersen Wu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler

[PATCH AUTOSEL 6.6 09/11] drm/amd: Fix UBSAN array-index-out-of-bounds for Powerplay headers

2023-11-12 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 49afe91370b86566857a3c2c39612cf098110885 ] For pptable structs that use flexible array sizes, use flexible arrays. Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039926 Reviewed-by: Mario Limonciello Acked-by: Christian König Signed-off-by:

Re: mainline build failure due to 7966f319c66d ("drm/amd/display: Introduce DML2")

2023-11-12 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux kernel regression tracking. See link in footer if these mails annoy you.] On 04.11.23 10:42, Sudip Mukherjee wrote: > On Thu, 2 Nov 2023 at 22:53, Alex Deucher wrote: >> On Thu, Nov 2, 2023 at 1:07 PM Sudip Mukherjee >> wrote: >>> On Thu, 2 Nov

Re: Radeon regression in 6.6 kernel

2023-11-12 Thread Bagas Sanjaya
On Sat, Nov 11, 2023 at 07:46:41PM -0500, Phillip Susi wrote: > I had been testing some things on a post 6.6-rc5 kernel for a week or > two and then when I pulled to a post 6.6 release kernel, I found that > system suspend was broken. It seems that the radeon driver failed to > suspend, leaving

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-12 Thread Javier Martinez Canillas
Andrew Worsley writes: Hello Andrew, > On Sat, 11 Nov 2023 at 20:10, Javier Martinez Canillas > wrote: >> > >> > On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: >> >> >> >>The simpledrm.c does not call aperture_remove_conflicting_devices() in >> >> it's probe >> >>function

Radeon regression in 6.6 kernel

2023-11-12 Thread Phillip Susi
I had been testing some things on a post 6.6-rc5 kernel for a week or two and then when I pulled to a post 6.6 release kernel, I found that system suspend was broken. It seems that the radeon driver failed to suspend, leaving the display dead, the wayland display server hung, and the system still