Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Maíra Canal
On 3/18/24 10:28, Maíra Canal wrote: Hi Christian, On 3/18/24 10:10, Christian König wrote: Am 18.03.24 um 13:42 schrieb Maíra Canal: Hi Christian, On 3/12/24 10:48, Christian König wrote: Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin: On 12/03/2024 10:37, Christian König wrote: Am

[PATCH] drm/i915/gt: Reset queue_priority_hint on parking

2024-03-18 Thread Janusz Krzysztofik
From: Chris Wilson Originally, with strict in order execution, we could complete execution only when the queue was empty. Preempt-to-busy allows replacement of an active request that may complete before the preemption is processed by HW. If that happens, the request is retired from the queue,

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Steven Price
On 18/03/2024 13:08, Boris Brezillon wrote: > On Mon, 18 Mar 2024 11:31:05 + > Steven Price wrote: > >> On 18/03/2024 08:58, Boris Brezillon wrote: >>> Putting a hard dependency on CONFIG_PM is not possible because of a >>> circular dependency issue, and it's actually not desirable either.

Re: [PATCH v9 20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-18 Thread Maxime Ripard
Hi, On Fri, Mar 15, 2024 at 10:22:05AM +0200, Ville Syrjälä wrote: > On Mon, Mar 11, 2024 at 03:49:48PM +0100, Maxime Ripard wrote: > > Infoframes in KMS is usually handled by a bunch of low-level helpers > > that require quite some boilerplate for drivers. This leads to > > discrepancies with

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Luca Weiss
On Mon Mar 18, 2024 at 11:59 AM CET, Jani Nikula wrote: > On Mon, 18 Mar 2024, Jani Nikula wrote: > > On Mon, 18 Mar 2024, Neil Armstrong wrote: > >> Hi, > >> > >> On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > >>> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > >>>

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2024 at 12:52:10PM +0200, Jani Nikula wrote: > On Mon, 18 Mar 2024, Neil Armstrong wrote: > > Hi, > > > > On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > >> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > >> bridge/panel.o to drm_kms_helper object, we need to

Re: [PATCH v9 14/27] drm/connector: hdmi: Compute bpc and format automatically

2024-03-18 Thread Ville Syrjälä
On Mon, Mar 18, 2024 at 01:05:22PM +0100, Maxime Ripard wrote: > Hi Ville, > > Thanks for your review ! > > On Fri, Mar 15, 2024 at 10:05:16AM +0200, Ville Syrjälä wrote: > > On Mon, Mar 11, 2024 at 03:49:42PM +0100, Maxime Ripard wrote: > > > +static bool > > > +sink_supports_format_bpc(const

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Maíra Canal
Hi Christian, On 3/18/24 10:10, Christian König wrote: Am 18.03.24 um 13:42 schrieb Maíra Canal: Hi Christian, On 3/12/24 10:48, Christian König wrote: Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin: On 12/03/2024 10:37, Christian König wrote: Am 12.03.24 um 11:31 schrieb Tvrtko Ursulin:

Re: [v3,5/5] drm/xe: Enable 32bits build

2024-03-18 Thread Lucas De Marchi
On Sun, Mar 17, 2024 at 09:14:14AM -0700, Guenter Roeck wrote: Hi, On Thu, Jan 18, 2024 at 04:16:12PM -0800, Lucas De Marchi wrote: Now that all the issues with 32bits are fixed, enable it again. Reviewed-by: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/Kconfig | 2 +-

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Christian König
Am 18.03.24 um 13:42 schrieb Maíra Canal: Hi Christian, On 3/12/24 10:48, Christian König wrote: Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin: On 12/03/2024 10:37, Christian König wrote: Am 12.03.24 um 11:31 schrieb Tvrtko Ursulin: On 12/03/2024 10:23, Christian König wrote: Am 12.03.24

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 11:31:05 + Steven Price wrote: > On 18/03/2024 08:58, Boris Brezillon wrote: > > Putting a hard dependency on CONFIG_PM is not possible because of a > > circular dependency issue, and it's actually not desirable either. In > > order to support this use case, we forcibly

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
On Mon, 18 Mar 2024 12:18:53 + Robin Murphy wrote: > On 18/03/2024 8:58 am, Boris Brezillon wrote: > > Putting a hard dependency on CONFIG_PM is not possible because of a > > circular dependency issue, and it's actually not desirable either. In > > order to support this use case, we forcibly

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Imre Deak
On Mon, Mar 18, 2024 at 12:59:29PM +0200, Jani Nikula wrote: > On Mon, 18 Mar 2024, Jani Nikula wrote: > > On Mon, 18 Mar 2024, Neil Armstrong wrote: > >> Hi, > >> > >> On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > >>> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > >>>

Re: [PATCH 2/5] drm/gem: Add a mountpoint parameter to drm_gem_object_init()

2024-03-18 Thread Maíra Canal
Hi Christian, On 3/12/24 10:48, Christian König wrote: Am 12.03.24 um 14:09 schrieb Tvrtko Ursulin: On 12/03/2024 10:37, Christian König wrote: Am 12.03.24 um 11:31 schrieb Tvrtko Ursulin: On 12/03/2024 10:23, Christian König wrote: Am 12.03.24 um 10:30 schrieb Tvrtko Ursulin: On

Re: [PATCH] drm/amdgpu: remove the adev check for NULL

2024-03-18 Thread Christian König
Am 18.03.24 um 07:29 schrieb Sunil Khatri: adev is a global data structure and isn't expected to be NULL and hence removing the redundant adev check from the devcoredump code. CC: Dan Carpenter Signed-off-by: Sunil Khatri Suggested-by: Dan Carpenter Acked-by: Christian König ---

Re: [PATCH] drm/panfrost: Only display fdinfo's engine and cycle tags when profiling is on

2024-03-18 Thread Steven Price
On 16/03/2024 23:13, Adrián Larumbe wrote: > If job accounting is disabled, then both fdinfo's drm-engine and drm-cycle > key values will remain immutable. In that case, it makes more sense not to > display them at all to avoid confusing user space profiling tools. > > Signed-off-by: Adrián

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Robin Murphy
On 18/03/2024 8:58 am, Boris Brezillon wrote: Putting a hard dependency on CONFIG_PM is not possible because of a circular dependency issue, and it's actually not desirable either. In order to support this use case, we forcibly resume at init time, and suspend at unplug time. Reported-by:

Re: [PATCH 6/6] backlight: Remove fb_blank from struct backlight_properties

2024-03-18 Thread Daniel Thompson
On Wed, Mar 13, 2024 at 04:45:05PM +0100, Thomas Zimmermann wrote: > Remove the field fb_blank from struct backlight_properties and remove > all code that still sets or reads it. Backlight blank status is now > tracked exclusively in struct backlight_properties.state. > > The core backlight code

Re: [PATCH 3/6] backlight/omap1-bl: Replace FB_BLANK_ states with simple on/off

2024-03-18 Thread Daniel Thompson
On Wed, Mar 13, 2024 at 04:45:02PM +0100, Thomas Zimmermann wrote: > The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for > any other value in fb_blank. But the field fb_blank in struct > backlight_properties is deprecated and should not be used any > longer. > > Replace the test for

Re: [PATCH v9 14/27] drm/connector: hdmi: Compute bpc and format automatically

2024-03-18 Thread Maxime Ripard
Hi Ville, Thanks for your review ! On Fri, Mar 15, 2024 at 10:05:16AM +0200, Ville Syrjälä wrote: > On Mon, Mar 11, 2024 at 03:49:42PM +0100, Maxime Ripard wrote: > > +static bool > > +sink_supports_format_bpc(const struct drm_connector *connector, > > +const struct

Re: [PATCH v3 0/2] Fixes for omapdrm console

2024-03-18 Thread Tomi Valkeinen
Hi, On 28/02/2024 08:35, Tony Lindgren wrote: Here are two fixes for omapdrm for missing drm_framebuffer_funcs.dirty that needs to be paired with omap_framebuffer_dirty(), and to add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS so things behave as earlier with drm_fb_helper_sys_write(). Without these

Re: [PATCH 2/6] backlight/omap1-bl: Remove unused struct omap_backlight_config.set_power

2024-03-18 Thread Daniel Thompson
On Wed, Mar 13, 2024 at 04:45:01PM +0100, Thomas Zimmermann wrote: > The callback set_power in struct omap_backlight_config is not > implemented anywhere. Remove it from the structure and driver. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Steven Price
On 18/03/2024 08:58, Boris Brezillon wrote: > Putting a hard dependency on CONFIG_PM is not possible because of a > circular dependency issue, and it's actually not desirable either. In > order to support this use case, we forcibly resume at init time, and > suspend at unplug time. > >

RE: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread FLAVIO SULIGOI
Hi Dan, > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't cause an > issue at runtime because devm_kcalloc() won't allocate negative sizes. > However, it's still worth fixing. > > Fixes: b54c828bdba9 ("backlight:

Re: [PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Liviu Dudau
On Mon, Mar 18, 2024 at 09:58:55AM +0100, Boris Brezillon wrote: > Putting a hard dependency on CONFIG_PM is not possible because of a > circular dependency issue, and it's actually not desirable either. In > order to support this use case, we forcibly resume at init time, and > suspend at unplug

Re: Future handling of complex RGB devices on Linux v3

2024-03-18 Thread Hans de Goede
Hi Werner, Sorry for the late reply. On 2/22/24 2:14 PM, Werner Sembach wrote: > Hi, > > Thanks everyone for the exhaustive feedback. And at least this thread is a > good comprehesive reference for the future ^^. > > To recap the hopefully final UAPI for complex RGB lighting devices: > > -

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Jani Nikula
On Mon, 18 Mar 2024, Jani Nikula wrote: > On Mon, 18 Mar 2024, Neil Armstrong wrote: >> Hi, >> >> On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: >>> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding >>> bridge/panel.o to drm_kms_helper object, we need to select >>>

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread Daniel Thompson
On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Jani Nikula
On Mon, 18 Mar 2024, Neil Armstrong wrote: > Hi, > > On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: >> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding >> bridge/panel.o to drm_kms_helper object, we need to select >> DRM_KMS_HELPER to make sure the file is actually getting

Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-18 Thread Andy Shevchenko
On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's

Re: [PATCH v1 1/1] drm/mediatek/ dp: Adjust bandwidth limit for DP

2024-03-18 Thread AngeloGioacchino Del Regno
Il 15/03/24 02:52, Liankun Yang ha scritto: By adjusting the order of link training and relocating it to HPD, link training can identify the usability of each lane in the current link. It also supports handling signal instability and weakness due to environmental issues, enabling the

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-03-18 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Mon, Mar 18, 2024 at 08:59:01AM +0100, Thomas Zimmermann wrote: >> Hi >> >> Am 18.03.24 um 03:35 schrieb Zack Rusin: >> > On Tue, Mar 12, 2024 at 11:48 AM Thomas Zimmermann >> > wrote: >> > > Framebuffer memory is allocated via vmalloc() from non-contiguous >> > >

Re: [PATCH 12/43] drm/mgag200: Use fbdev-shmem

2024-03-18 Thread Jocelyn Falempe
On 18/03/2024 08:56, Thomas Zimmermann wrote: Hi Am 13.03.24 um 15:03 schrieb Jocelyn Falempe: Hi, Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Thanks. Do you still have access to that broken realtime system? I wonder if this patch makes a difference, as there's now one

Re: [PATCH] drm/panel: ilitek-ili9881c: Fix warning with GPIO controllers that sleep

2024-03-18 Thread Laurent Pinchart
Hi Neil, On Mon, Mar 18, 2024 at 10:03:21AM +0100, Neil Armstrong wrote: > On 17/03/2024 16:48, Laurent Pinchart wrote: > > The ilitek-ili9881c controls the reset GPIO using the non-sleeping > > gpiod_set_value() function. This complains loudly when the GPIO > > controller needs to sleep. As the

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Neil Armstrong
Hi, On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > bridge/panel.o to drm_kms_helper object, we need to select > DRM_KMS_HELPER to make sure the file is actually getting built. > > Otherwise with certain defconfigs e.g.

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-18 Thread Robin van der Gracht
Hi Thomas, Thank you for submitting your patch, it looks fine to me. Reviewed-by: Robin van der Gracht On Wed, 13 Mar 2024 16:45:00 +0100 Thomas Zimmermann wrote: > Replace the use of struct backlight_properties.fb_blank with a > call to backlight_get_brightness(). The helper implement the

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread neil . armstrong
On 08/03/2024 10:29, Luca Weiss wrote: On Sun Mar 3, 2024 at 9:37 PM CET, Dmitry Baryshkov wrote: On Thu, 29 Feb 2024 at 11:27, Luca Weiss wrote: On Wed Jan 17, 2024 at 9:59 AM CET, Luca Weiss wrote: On Mon Jan 15, 2024 at 9:43 AM CET, Neil Armstrong wrote: Hi Luca, On 11/01/2024 13:38,

Re: [PATCH] drm/panel: ilitek-ili9881c: Fix warning with GPIO controllers that sleep

2024-03-18 Thread Neil Armstrong
Hi Laurent, On 17/03/2024 16:48, Laurent Pinchart wrote: The ilitek-ili9881c controls the reset GPIO using the non-sleeping gpiod_set_value() function. This complains loudly when the GPIO controller needs to sleep. As the caller can sleep, use gpiod_set_value_cansleep() to fix the issue.

Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: Add Startek KD050HDFIA020-C020A support

2024-03-18 Thread Neil Armstrong
On 17/03/2024 16:57, Laurent Pinchart wrote: Add support for the Startek KD050HDFIA020-C020A panel. The init table comes from the Compulab BSP ([1]). [1]

[PATCH] drm/panthor: Fix the CONFIG_PM=n case

2024-03-18 Thread Boris Brezillon
Putting a hard dependency on CONFIG_PM is not possible because of a circular dependency issue, and it's actually not desirable either. In order to support this use case, we forcibly resume at init time, and suspend at unplug time. Reported-by: kernel test robot Closes:

Re: [PATCH 1/3] accel/qaic: Add bootlog debugfs

2024-03-18 Thread Jacek Lawrynowicz
On 15.03.2024 16:39, Jeffrey Hugo wrote: > On 3/14/2024 5:41 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> On 11.03.2024 17:58, Jeffrey Hugo wrote: >>> During the boot process of AIC100, the bootloaders (PBL and SBL) log >>> messages to device RAM. During SBL, if the host opens the QAIC_LOGGING >>>

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-03-18 Thread Maxime Ripard
On Mon, Mar 18, 2024 at 08:59:01AM +0100, Thomas Zimmermann wrote: > Hi > > Am 18.03.24 um 03:35 schrieb Zack Rusin: > > On Tue, Mar 12, 2024 at 11:48 AM Thomas Zimmermann > > wrote: > > > Framebuffer memory is allocated via vmalloc() from non-contiguous > > > physical pages. The physical

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-03-18 Thread Thomas Zimmermann
Hi Am 17.03.24 um 13:43 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Framebuffer memory is allocated via vmalloc() from non-contiguous It's vmalloc() true, but through vzmalloc() so I would mention that function instead in the commit message. Ok. physical

Re: [PATCH v2] fbmon: prevent division by zero in fb_videomode_from_videomode()

2024-03-18 Thread Roman Smirnov
On Fri, 15 Mar 2024 09:44:08 +0100 Helge Deller wrote: > On 3/5/24 14:51, Roman Smirnov wrote: > > The expression htotal * vtotal can have a zero value on > > overflow. > > I'm not sure if thos always results in zero in kernel on overflow. > Might be architecture-depended too, but let's assume it

Re: [PATCH 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-03-18 Thread Thomas Zimmermann
Hi Am 18.03.24 um 03:35 schrieb Zack Rusin: On Tue, Mar 12, 2024 at 11:48 AM Thomas Zimmermann wrote: Framebuffer memory is allocated via vmalloc() from non-contiguous physical pages. The physical framebuffer start address is therefore meaningless. Do not set it. The value is not used within

Re: [PATCH 12/43] drm/mgag200: Use fbdev-shmem

2024-03-18 Thread Thomas Zimmermann
Hi Am 13.03.24 um 15:03 schrieb Jocelyn Falempe: Hi, Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Thanks. Do you still have access to that broken realtime system? I wonder if this patch makes a difference, as there's now one large memcpy() less. Best regards Thomas -- --

[PATCH] drm/amdgpu: remove the adev check for NULL

2024-03-18 Thread Sunil Khatri
adev is a global data structure and isn't expected to be NULL and hence removing the redundant adev check from the devcoredump code. CC: Dan Carpenter Signed-off-by: Sunil Khatri Suggested-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 57 ++- 1 file

<    1   2