Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-11-12 Thread 胡俊光

Re: [PATCH v4 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc

2024-11-12 Thread kernel test robot
Hi Yongbang, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on drm-misc/drm-misc-next v6.12-rc7 next-20241112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: linux-next: build warning after merge of the drm-misc tree

2024-11-12 Thread Stephen Rothwell
Hi all, On Fri, 8 Nov 2024 17:56:55 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/gpu/drm-mm:571: drivers/gpu/drm/scheduler/sched_main.c:1359: > ERROR: Unexpected indentation. > > Introduced by

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-12 Thread Matthew Wilcox
On Tue, Nov 12, 2024 at 03:22:46PM +0100, David Hildenbrand wrote: > On 12.11.24 14:53, Jason Gunthorpe wrote: > > On Tue, Nov 12, 2024 at 10:10:06AM +0100, David Hildenbrand wrote: > > > On 12.11.24 06:26, Matthew Wilcox wrote: > > > > I don't want you to respin. I think this is a bad idea. > > >

Re: [PATCH V3 drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc

2024-11-12 Thread Yongbang Shi
On Fri, Nov 01, 2024 at 06:50:25PM +0800, Yongbang Shi wrote: From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: baihan li Signed-off-by: yongbang shi Is this a proper capitalization of your names? Usually the first letter of eac

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-12 Thread Matthew Brost
On Tue, Nov 12, 2024 at 06:27:31PM -0800, Matthew Brost wrote: > On Tue, Nov 12, 2024 at 12:09:52PM +0100, Christian König wrote: > > Am 12.11.24 um 04:29 schrieb Matthew Brost: > > > On Mon, Nov 11, 2024 at 02:42:02PM +0100, Christian König wrote: > > > > Am 09.11.24 um 18:29 schrieb Matthew Brost

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-12 Thread Matthew Brost
On Tue, Nov 12, 2024 at 12:09:52PM +0100, Christian König wrote: > Am 12.11.24 um 04:29 schrieb Matthew Brost: > > On Mon, Nov 11, 2024 at 02:42:02PM +0100, Christian König wrote: > > > Am 09.11.24 um 18:29 schrieb Matthew Brost: > > > > The motivation for this series comes from pending UMD submiss

Re: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

2024-11-12 Thread Liu Ying
On 11/12/2024, Dan Carpenter wrote: > If devm_i2c_new_dummy_device() fails then we were supposed to return an > error code, but instead the function continues and will crash on the next > line. Add the missing return statement. > > Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI con

Re:[PATCH 1/2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-11-12 Thread Andy Yan
+ Sebastina, Hi Sebastian, I think you also need this patch when you test DSI on rk3588 with DSI2 support patch from Heiko. At 2024-04-26 03:55:05, "Heiko Stuebner" wrote: >From: Heiko Stuebner > >The clock is in Hz while the value checked against is in kHz, so >actual frequencies will never

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-12 Thread John Watts
Hi there, On Tue, Nov 12, 2024 at 10:43:44PM +0530, Parthiban wrote: > #define TCON_TOP_PORT_DE0_MSK GENMASK(1, 0) > #define TCON_TOP_PORT_DE1_MSK GENMASK(5, 4) > > references towards DE0 and DE1 is for DE itself, not the mixers in the > current implementation.

Re: [PATCH 2/2] nouveau/dp: handle retries for AUX CH transfers with GSP.

2024-11-12 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2024-11-11 at 13:41 +1000, Dave Airlie wrote: > From: Dave Airlie > > eb284f4b3781 drm/nouveau/dp: Honor GSP link training retry timeouts > > tried to fix a problem with panel retires, however it appears > the auxch also needs the same treatment, so add the same

Re: [PATCH 1/2] nouveau: handle EBUSY and EAGAIN for GSP aux errors.

2024-11-12 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2024-11-11 at 13:41 +1000, Dave Airlie wrote: > From: Dave Airlie > > The upper layer transfer functions expect EBUSY as a return > for when retries should be done. > > Fix the AUX error translation, but also check for both errors > in a few places. > > Fixes:

Re: [PATCH] drm/bridge: Constify struct i2c_device_id

2024-11-12 Thread Laurent Pinchart
Hi Christophe, Thank you for the patch. On Tue, Nov 12, 2024 at 10:12:25PM +0100, Christophe JAILLET wrote: > 'struct i2c_device_id' is not modified in these drivers. > > Constifying this structure moves some data to a read-only section, so > increase overall security. > > On a x86_64, with all

Re: [PATCH] drm/bridge: Constify struct i2c_device_id

2024-11-12 Thread Doug Anderson
Hi, On Tue, Nov 12, 2024 at 1:12 PM Christophe JAILLET wrote: > > 'struct i2c_device_id' is not modified in these drivers. > > Constifying this structure moves some data to a read-only section, so > increase overall security. > > On a x86_64, with allmodconfig, as an example: > Before: > == >

[PATCH] drm/bridge: Constify struct i2c_device_id

2024-11-12 Thread Christophe JAILLET
'struct i2c_device_id' is not modified in these drivers. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig, as an example: Before: == textdata bss dec hex filename 15566 987 32 16585

Re: [PATCH v2 2/2] drm/msm/adreno: Setup SMMU aparture for per-process page table

2024-11-12 Thread Akhil P Oommen
On 11/11/2024 8:38 PM, Rob Clark wrote: > On Sun, Nov 10, 2024 at 9:31 AM Bjorn Andersson > wrote: >> >> Support for per-process page tables requires the SMMU aparture to be >> setup such that the GPU can make updates with the SMMU. On some targets >> this is done statically in firmware, on others

Re: Ensure progress for dma_fence_array

2024-11-12 Thread Chia-I Wu
On Tue, Nov 12, 2024 at 4:00 AM Christian König wrote: > > Am 09.11.24 um 01:32 schrieb Chia-I Wu: > > On Fri, Nov 8, 2024 at 1:43 AM Christian König > > wrote: > >> Hi guys, > >> > >> as pointed out by Chia-I userspace doesn't see any progress when > >> signaling is not enabled and Boris noted t

Re: [PATCH v3 1/2] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-11-12 Thread Akhil P Oommen
On 10/30/2024 12:32 PM, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Add gpu and gmu nodes for sa8775p chipset. As of now all > SKUs have the same GPU fmax, so there is no requirement of > speed bin support. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oommen > Revi

Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

2024-11-12 Thread Akhil P Oommen
On 10/30/2024 12:32 PM, Akhil P Oommen wrote: > From: Puranam V G Tejaswi > > Enable GPU for sa8775p-ride platform and provide path for zap > shader. > > Signed-off-by: Puranam V G Tejaswi > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sa8775

Re: [PATCH] drm/msm/a6xx: Add support for Adreno 612

2024-11-12 Thread Akhil P Oommen
On 11/1/2024 8:40 PM, Akhil P Oommen wrote: > From: Jie Zhang > > Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. > A612 falls under ADRENO_6XX_GEN1 family and is a cut down version > of A615 GPU. > > A612 has a new IP called Reduced Graphics Management Unit or RGMU > which is a

Re: [PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev

2024-11-12 Thread Akhil P Oommen
On 11/12/2024 11:52 PM, Colin Ian King wrote: > The call chain on a5xx_gpu_init is such that pdev is not going to be > null, so the null check on pdev can be removed. This also cleans up > a static analysis warning where pdev is dereferenced before the null > check which cannot actually occur. > >

[PATCH] video: fbdev: metronomefb: Fix buffer overflow in load_waveform()

2024-11-12 Thread Suraj Sonawane
Fix an error detected by the Smatch tool: drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer overflow 'wfm_hdr->stuff2a' 2 <= 4 drivers/video/fbdev/metronomefb.c:220 load_waveform() error: buffer overflow 'wfm_hdr->stuff2a' 2 <= 4 The access to wfm_hdr->stuff2a in the loop can le

Re: [RFC PATCH 2/6] drm/sched: Teach scheduler about DMA_RESV_USAGE_PREEMPT

2024-11-12 Thread Matthew Brost
On Tue, Nov 12, 2024 at 10:06:21AM +0100, Philipp Stanner wrote: > Hi Matt, > > On Sat, 2024-11-09 at 09:29 -0800, Matthew Brost wrote: > > Follow the semantics of DMA_RESV_USAGE_PREEMPT in the DRM scheduler > > by > > storing preemptive fences in a dedicated xarray, which is waited on > > after a

Re: [REGRESSION] GM20B pmu timeout

2024-11-12 Thread Dave Airlie
On Tue, 12 Nov 2024 at 22:34, Linux regression tracking (Thorsten Leemhuis) wrote: > > [CCing Danilo, who committed the culprit] > > On 04.11.24 13:11, Diogo Ivo wrote: > > On Tue Oct 15, 2024 at 7:13 PM WEST, Linux regression tracking (Thorsten > > Leemhuis) wrote: > >> On 10.10.24 15:32, Diogo

[PATCH V10 05/10] accel/amdxdna: Add hardware context

2024-11-12 Thread Lizhi Hou
The hardware can be shared among multiple user applications. The hardware resources are allocated/freed based on the request from user application via driver IOCTLs. DRM_IOCTL_AMDXDNA_CREATE_HWCTX Allocate tile columns and create a hardware context structure to track the usage and status of the re

[PATCH V10 07/10] accel/amdxdna: Add command execution

2024-11-12 Thread Lizhi Hou
Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c | 607 +- drivers/accel/amdxdna/aie2_message.c | 343 ++

[PATCH V10 01/10] accel/amdxdna: Add documentation for AMD NPU accelerator driver

2024-11-12 Thread Lizhi Hou
AMD NPU (Neural Processing Unit) is a multi-user AI inference accelerator integrated into AMD client APU. NPU enables efficient execution of Machine Learning applications like CNN, LLM, etc. NPU is based on AMD XDNA Architecture. NPU is managed by amdxdna driver. Co-developed-by: Sonal Santan Sig

[PATCH V10 10/10] accel/amdxdna: Add query functions

2024-11-12 Thread Lizhi Hou
Add GET_INFO ioctl to retrieve hardware information, including AIE, clock, hardware context etc. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_message.c| 65 +++ drivers/accel/amdxdna/aie2_pci.c

[PATCH V10 02/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-11-12 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa

[PATCH V10 09/10] accel/amdxdna: Add error handling

2024-11-12 Thread Lizhi Hou
When there is a hardware error, the NPU firmware notifies the host through a mailbox message. The message includes details of the error, such as the tile and column indexes where the error occurred. The driver starts a thread to handle the NPU error message. The thread stops the clients which are

[PATCH V10 04/10] accel/amdxdna: Add hardware resource solver

2024-11-12 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1

[PATCH V10 03/10] accel/amdxdna: Support hardware mailbox

2024-11-12 Thread Lizhi Hou
The hardware mailboxes are used by the driver to submit requests to firmware and receive the completion notices from hardware. Initially, a management mailbox channel is up and running. The driver may request firmware to create/destroy more channels dynamically through management channel. Add dri

[PATCH V10 06/10] accel/amdxdna: Add GEM buffer object management

2024-11-12 Thread Lizhi Hou
There different types of BOs are supported: - shmem A user application uses shmem BOs as input/output for its workload running on NPU. - device memory heap The fixed size buffer dedicated to the device. - device buffer The buffer object allocated from device memory heap. - command buffer The bu

[PATCH V10 08/10] accel/amdxdna: Add suspend and resume

2024-11-12 Thread Lizhi Hou
Implement PCI power management suspend and resume callbacks. Co-developed-by: Narendra Gutta Signed-off-by: Narendra Gutta Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Co-developed-by: Min Ma Signed-off-by: Min Ma Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou --- drivers

[PATCH V10 00/10] AMD XDNA driver

2024-11-12 Thread Lizhi Hou
This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine Learning applications like CNNs, LLMs, etc

Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example

2024-11-12 Thread Abhinav Kumar
it up while applying. Thanks Abhinav With that fixed, Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Changes in v2: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v1: https://lore.kernel.org/r/20241112-fd

Re: [PATCH V9 07/10] accel/amdxdna: Add command execution

2024-11-12 Thread Lizhi Hou
On 11/11/24 22:07, Matthew Brost wrote: On Mon, Nov 11, 2024 at 10:17:08AM -0800, Lizhi Hou wrote: Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.

[PATCH v2 5/7] drm/amd/display: Switch dc_sink to struct drm_edid

2024-11-12 Thread Thomas Weißschuh
The custom "struct dc_edid" can be replaced by the standard "struct drm_edid. Rename the member to make sure that no usage sites are missed, as "struct drm_edid" has some restrictions, for example it can not be used with kfree(). Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/a

[PATCH v2 6/7] drm/amd/display: Drop opencoded edid panel id extraction

2024-11-12 Thread Thomas Weißschuh
Now that a struct drm_edid is available make use of the standard drm_edid_get_panel_id(). Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/a

[PATCH v2 3/7] drm/amd/display: Use struct edid in dc_link_add_remote_sink()

2024-11-12 Thread Thomas Weißschuh
The callers of dc_link_add_remote_sink() are using 'struct edid' which they all need to cast to uint8_t *. Allow the direct passing of 'struct edid' to avoid these cast and also move the length calculation so it does not need to be duplicated everywhere. Signed-off-by: Thomas Weißschuh --- drive

[PATCH v3] drm/radeon: Switch radeon_connector to struct drm_edid

2024-11-12 Thread Thomas Weißschuh
"struct drm_edid" is the safe and recommended alternative to "struct edid". Rename the member to make sure that no usage sites are missed, as "struct drm_edid" has some restrictions, for example it can not be used with kfree(). Signed-off-by: Thomas Weißschuh --- Changes in v3: - Rebase onto drm

[PATCH v2 0/7] drm/amd: Switch over to struct drm_edid

2024-11-12 Thread Thomas Weißschuh
The AMD DRM drivers use 'struct edid', raw pointers and even custom structs to represent EDID data. Uniformly switch to the safe and recommended "struct drm_edid". Some uses of "struct edid" are left because some ad-hoc parsing is still being done inside the drivers. Patches 1 and 2 delete some d

[PATCH v2 4/7] drm/amdgpu: Switch amdgpu_connector to struct drm_edid

2024-11-12 Thread Thomas Weißschuh
"struct drm_edid" is the safe and recommended alternative to "struct edid". Rename the member to make sure that no usage sites are missed, as "struct drm_edid" has some restrictions, for example it can not be used with kfree(). Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/amdg

[PATCH v2 7/7] drm/amd/display: Switch dc_link_add_remote_sink() to struct drm_edid

2024-11-12 Thread Thomas Weißschuh
"struct drm_edid" is the safe and recommended alternative to "struct edid". Now that all callers of dc_link_add_remote_sink() have access to a validate struct drm_edid, pass it around directly. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +-

[PATCH v2 2/7] drm/amd/display: Remove EDID members of ddc_service

2024-11-12 Thread Thomas Weißschuh
All usages of these fields have been removed. Fixes: 7c7f5b15be65 ("drm/amd/display: Refactor edid read.") Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_ddc_types.h b/dri

[PATCH v2 1/7] drm/amd/display: Remove spurious declaration of dm_helpers_get_sbios_edid()

2024-11-12 Thread Thomas Weißschuh
The prototype is the whole content of commit 575d0df6dae4 ("drm/amd/display: refine the EDID override"). Apparently the definition was never added. Fixes: 575d0df6dae4 ("drm/amd/display: refine the EDID override") Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/dc/dm_helpers.h |

[PATCH][V2] drm/msm/a5xx: remove null pointer check on pdev

2024-11-12 Thread Colin Ian King
The call chain on a5xx_gpu_init is such that pdev is not going to be null, so the null check on pdev can be removed. This also cleans up a static analysis warning where pdev is dereferenced before the null check which cannot actually occur. Signed-off-by: Colin Ian King --- V2: rewrite Subject,

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Laurent Pinchart
On Tue, Nov 12, 2024 at 10:44:29AM -0700, Shuah Khan wrote: > On 11/11/24 22:18, Laurent Pinchart wrote: > > On Mon, Nov 11, 2024 at 05:35:11PM -0700, Shuah Khan wrote: > >> On 11/11/24 15:35, Laurent Pinchart wrote: > >>> On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: > On 11/11/

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Shuah Khan
On 11/12/24 07:43, Mark Brown wrote: On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: Personal take, but I think a forced public apology as the primary or at least initial coc enforcement approach is one of the worst. ... This document is

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Shuah Khan
On 11/11/24 22:18, Laurent Pinchart wrote: On Mon, Nov 11, 2024 at 05:35:11PM -0700, Shuah Khan wrote: On 11/11/24 15:35, Laurent Pinchart wrote: On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah

Re: [PATCH v2] dt-bindings: display/msm: qcom,sa8775p-mdss: fix the example

2024-11-12 Thread Rob Herring (Arm)
sqj0zoyazagztyj8xmspy+yzrbf-yg1vpn6tfofxqaw...@mail.gmail.com/c > Signed-off-by: Dmitry Baryshkov > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: > https://lore.kernel.org/r/20241112-fd-dp

Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

2024-11-12 Thread Sean Anderson
On 11/12/24 11:43, Laurent Pinchart wrote: > On Tue, Nov 12, 2024 at 09:41:58AM -0500, Sean Anderson wrote: >> On 11/12/24 00:27, Laurent Pinchart wrote: >> > Hi Dan, >> > >> > Thank you for the patch. >> > >> > On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote: >> >> We added some lo

Re: [PATCH RESEND v9 2/2] drm/amdgpu: Enable async flip on overlay planes

2024-11-12 Thread André Almeida
Hi Harry, thanks for the reply! Em 11/11/2024 18:10, Harry Wentland escreveu: On 2024-11-01 14:23, André Almeida wrote: amdgpu can handle async flips on overlay planes, so allow it for atomic async checks. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plan

Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

2024-11-12 Thread Laurent Pinchart
On Tue, Nov 12, 2024 at 09:41:58AM -0500, Sean Anderson wrote: > On 11/12/24 00:27, Laurent Pinchart wrote: > > Hi Dan, > > > > Thank you for the patch. > > > > On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote: > >> We added some locking to this function, but accidentally forgot to u

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-12 Thread Thomas Hellström
On Tue, 2024-11-12 at 17:25 +0100, Christian König wrote: > Am 12.11.24 um 17:22 schrieb Thomas Hellström: > > On Tue, 2024-11-12 at 15:41 +0200, Joonas Lahtinen wrote: > > > (+ Thomas) > > > > > > Quoting Christian König (2024-11-12 11:23:36) > > > > Am 11.11.24 um 23:45 schrieb Matthew Brost: >

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-12 Thread Thomas Hellström
On Tue, 2024-11-12 at 15:41 +0200, Joonas Lahtinen wrote: > (+ Thomas) > > Quoting Christian König (2024-11-12 11:23:36) > > Am 11.11.24 um 23:45 schrieb Matthew Brost: > > > >     [SNIP] > > > >     So I think only way to allow interactive debugging is > > to avoid the > >     d

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-12 Thread Christian König
Am 12.11.24 um 17:22 schrieb Thomas Hellström: On Tue, 2024-11-12 at 15:41 +0200, Joonas Lahtinen wrote: (+ Thomas) Quoting Christian König (2024-11-12 11:23:36) Am 11.11.24 um 23:45 schrieb Matthew Brost:     [SNIP]     So I think only way to allow interactive debugging is to avoi

Re: [RFC PATCH v1 06/10] mm/hugetlb: use separate folio->_hugetlb_list for hugetlb-internals

2024-11-12 Thread David Hildenbrand
On 12.11.24 16:28, wang wei wrote: Signed-off-by: wang wei --- diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 80fef38d9d64..365c73be0bb4 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -310,6 +310,7 @@ typedef struct { * @_hugetlb_cgroup: Do not

Re: [RFC PATCH 6/6 6.6] libfs: fix infinite directory reads for offset dir

2024-11-12 Thread Chuck Lever III
> On Nov 11, 2024, at 10:43 PM, yangerkun wrote: > > > > 在 2024/11/11 23:34, Chuck Lever III 写道: >>> On Nov 11, 2024, at 10:20 AM, yangerkun wrote: >>> >>> >>> >>> 在 2024/11/11 22:39, Chuck Lever III 写道: > On Nov 10, 2024, at 9:36 PM, Yu Kuai wrote: > > Hi, > > 在 20

Re: [PATCH 3/6] drm/amdgpu: enable GTT fallback handling for dGPUs only

2024-11-12 Thread Alex Deucher
On Tue, Jun 4, 2024 at 12:12 PM Christian König wrote: > > That is just a waste of time on APUs. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3704 Fixes: 216c1282dde3 ("drm/amdgpu: use GTT only as fallback for VRAM|GTT") a

Re: [PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null check on pdev

2024-11-12 Thread Konrad Dybcio
On 11/12/24 14:20, Colin Ian King wrote: The pointer config is dereferencing pointer pdev before pdev is null checked, this could lead to a potential null pointer dereference on pdev. Fix this by only assinging config after pdev has been null checked. Fixes: 736a93273656 ("drm/msm/a5xx: reall

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-11-12 Thread Christian König
Am 08.11.24 um 05:00 schrieb Dave Airlie: On Wed, 18 Sept 2024 at 23:48, Christian König wrote: Tearing down the scheduler with jobs still on the pending list can lead to use after free issues. Add a warning if drivers try to destroy a scheduler which still has work pushed to the HW. When the

Re: [PATCH v4 6/7] PCI: Allow drivers to control VF BAR size

2024-11-12 Thread Michał Winiarski
On Mon, Oct 28, 2024 at 11:50:31AM -0500, Bjorn Helgaas wrote: > On Fri, Oct 25, 2024 at 11:50:37PM +0200, Michał Winiarski wrote: > > Drivers could leverage the fact that the VF BAR MMIO reservation is > > created for total number of VFs supported by the device by resizing the > > BAR to larger si

Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable()

2024-11-12 Thread Sean Anderson
On 11/12/24 00:27, Laurent Pinchart wrote: > Hi Dan, > > Thank you for the patch. > > On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote: >> We added some locking to this function, but accidentally forgot to unlock >> if zynqmp_dp_mode_configure() failed. Use a guard lock to fix it. >

Re: Document drm_sched_fini and add some warnings and a BUG_ON()

2024-11-12 Thread Philipp Stanner
On Tue, 2024-11-12 at 13:36 +0100, Christian König wrote: > Gentle ping. > > Dave Philip noted in private chat that you had some comments? I don't > see anything in my inbox. Hi, that was a misunderstanding – Dave answered on this one: https://lore.kernel.org/all/CAPM=9tzacady1qn_wmaz_wp3n_pfta

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Mark Brown
On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: > On 11/11/24 13:07, Simona Vetter wrote: > > Personal take, but I think a forced public apology as the primary or at > > least initial coc enforcement approach is one of the worst. ... > This document isn't intended to be a complete su

Re: [PATCH v4 3/7] PCI: Add a helper to convert between standard and IOV resources

2024-11-12 Thread Michał Winiarski
On Wed, Nov 06, 2024 at 04:22:11PM +0200, Ilpo Järvinen wrote: > On Fri, 25 Oct 2024, Michał Winiarski wrote: > > > There are multiple places where conversions between IOV resources and > > standard resources are done. > > > > Extract the logic to pci_resource_to_iov() and pci_resource_from_iov()

Re: [PATCH v4 5/7] PCI/IOV: Check that VF BAR fits within the reservation

2024-11-12 Thread Michał Winiarski
On Wed, Oct 30, 2024 at 11:55:01AM -0500, Bjorn Helgaas wrote: > On Wed, Oct 30, 2024 at 12:43:19PM +0100, Michał Winiarski wrote: > > On Mon, Oct 28, 2024 at 11:56:04AM -0500, Bjorn Helgaas wrote: > > > On Fri, Oct 25, 2024 at 11:50:36PM +0200, Michał Winiarski wrote: > > > > VF MMIO resource rese

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-12 Thread David Hildenbrand
On 12.11.24 14:53, Jason Gunthorpe wrote: On Tue, Nov 12, 2024 at 10:10:06AM +0100, David Hildenbrand wrote: On 12.11.24 06:26, Matthew Wilcox wrote: On Mon, Nov 11, 2024 at 08:26:54AM +, Fuad Tabba wrote: Thanks for your comments Jason, and for clarifying my cover letter David. I think Da

Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops

2024-11-12 Thread Jason Gunthorpe
On Tue, Nov 12, 2024 at 10:10:06AM +0100, David Hildenbrand wrote: > On 12.11.24 06:26, Matthew Wilcox wrote: > > On Mon, Nov 11, 2024 at 08:26:54AM +, Fuad Tabba wrote: > > > Thanks for your comments Jason, and for clarifying my cover letter > > > David. I think David has covered everything, a

Re: [PATCH 1/6] drm/fsl-dcu: Include

2024-11-12 Thread Thomas Zimmermann
ping Am 11.10.24 um 16:41 schrieb Thomas Zimmermann: Include directly to get of_parse_phandle(). Avoids the proxy include via Signed-off-by: Thomas Zimmermann Cc: Stefan Agner Cc: Alison Wang --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-12 Thread Joonas Lahtinen
(+ Thomas) Quoting Christian König (2024-11-12 11:23:36) > Am 11.11.24 um 23:45 schrieb Matthew Brost: > > [SNIP] > > So I think only way to allow interactive debugging is to avoid the > dma_fences. Curious to hear if there are ideas for otherwise. > > You ne

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-12 Thread Joonas Lahtinen
(+ Thomas and Francois related to the page-faults and scheduling) Quoting Christian König (2024-11-12 10:58:18) > Am 12.11.24 um 09:28 schrieb Simona Vetter: > > On Mon, Nov 11, 2024 at 04:00:02PM +0200, Joonas Lahtinen wrote: > >> Quoting Christian König (2024-11-11 13:34:12) > >>> Am 11.11.24 um

[PATCH v4 drm-dp 5/5] drm/hisilicon/hibmc: add dp module in hibmc

2024-11-12 Thread Yongbang Shi
From: baihan li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - static inline hibmc_dp_prepare(), suggested by Dmitry Baryshkov. --- drivers/gpu/drm/hisilicon/hibmc

[PATCH v4 drm-dp 4/5] drm/hisilicon/hibmc: separate struct of vdac

2024-11-12 Thread Yongbang Shi
From: baihan li Refactored struct hibmc_drm_private to separate VGA module from generic struct. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - separating hibmc_vdac and hibmc_dp changes into separate patche, suggested by Dmitry Baryshkov. v2 -> v3: - fix b

[PATCH v4 drm-dp 2/5] drm/hisilicon/hibmc: add dp link moduel in hibmc

2024-11-12 Thread Yongbang Shi
From: baihan li Add link training process functions in this moduel. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- Changelog: v3 -> v4: - optimizing hibmc_dp_link_get_adjust_train() to delete for loop, suggested by Dmitry Baryshkov. - changing ELNRNG to EIO error code, suggested

[PATCH v4 drm-dp 0/4] Add dp module in hibmc driver

2024-11-12 Thread Yongbang Shi
From: baihan li Realizing the basic display function of DP cable for DP connector displaying. Add DP module in hibmc drm driver, which is for Hisilicon Hibmc SoC which used for Out-of-band management. Blow is the general hardware connection, both the Hibmc and the host CPU are on the same mother

[PATCH v4 drm-dp 3/5] drm/hisilicon/hibmc: add dp hw moduel in hibmc

2024-11-12 Thread Yongbang Shi
From: baihan li Build a dp level that hibmc driver can enable dp by calling their functions. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - changed the type of train_set to array, suggested by Dmitry Baryshkov. - using actual link rate instead of magic num,

[PATCH v4 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc

2024-11-12 Thread Yongbang Shi
From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v3 -> v4: - retun error codes in result incorrect branch, suggested by Dmitry Baryshkov. - replacing all ret= with returns

Re: [PATCH v2] dt-bindings: display/msm: qcom, sa8775p-mdss: fix the example

2024-11-12 Thread Dmitry Baryshkov
up for -fixes or would you prefer to have a clean version in patchwork? > > With that fixed, > > Reviewed-by: Abhinav Kumar > > > Signed-off-by: Dmitry Baryshkov > > --- > > Changes in v2: > > - EDITME: describe what is new in this series revision. > >

[PATCH] drm/msm/a5xx: Fix dereference of pointer pdev before null check on pdev

2024-11-12 Thread Colin Ian King
The pointer config is dereferencing pointer pdev before pdev is null checked, this could lead to a potential null pointer dereference on pdev. Fix this by only assinging config after pdev has been null checked. Fixes: 736a93273656 ("drm/msm/a5xx: really check for A510 in a5xx_gpu_init") Signed-off

[PATCH v4] drm/i915/cx0: Set power state to ready only on owned PHY lanes

2024-11-12 Thread Vamsi Krishna Brahmajosyula
In DP alt mode, when pin assignment is D, only one PHY lane is owned by the display. intel_cx0pll_enable currently performs a power state ready on both the lanes in all cases. Address the following todo to perfom power state ready on owned lanes. TODO: For DP alt mode use only one lane. Teste

Re: Document drm_sched_fini and add some warnings and a BUG_ON()

2024-11-12 Thread Christian König
Gentle ping. Dave Philip noted in private chat that you had some comments? I don't see anything in my inbox. Thanks, Christian. Am 27.09.24 um 16:27 schrieb Christian König: Sorry for sending incomplete patches earlier today, I've messed up my branch and had to re-create it. Let's try this

Re: [REGRESSION] GM20B pmu timeout

2024-11-12 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing Danilo, who committed the culprit] On 04.11.24 13:11, Diogo Ivo wrote: > On Tue Oct 15, 2024 at 7:13 PM WEST, Linux regression tracking (Thorsten > Leemhuis) wrote: >> On 10.10.24 15:32, Diogo Ivo wrote: >>> >>> Somewhere between 6.11-rc4 and 6.11-rc5 the following error message is >>> di

[PATCH] dma-buf: fix dma_fence_array_signaled v3

2024-11-12 Thread Christian König
The function silently assumed that signaling was already enabled for the dma_fence_array. This meant that without enabling signaling first we would never see forward progress. Fix that by falling back to testing each individual fence when signaling isn't enabled yet. v2: add the comment suggested

Re: [PATCH] dma-buf: fix dma_fence_array_signaled

2024-11-12 Thread Christian König
Am 08.11.24 um 16:52 schrieb Tvrtko Ursulin: On 08/11/2024 14:18, Christian König wrote: Am 08.11.24 um 14:01 schrieb Tvrtko Ursulin: On 08/11/2024 09:42, Christian König wrote: The function silently assumed that signaling was already enabled for the dma_fence_array. This meant that without e

[PATCH] dma-buf: fix dma_fence_array_signaled v2

2024-11-12 Thread Christian König
The function silently assumed that signaling was already enabled for the dma_fence_array. This meant that without enabling signaling first we would never see forward progress. Fix that by falling back to testing each individual fence when signaling isn't enabled yet. v2: add the comment suggested

Re: Ensure progress for dma_fence_array

2024-11-12 Thread Christian König
Am 09.11.24 um 01:32 schrieb Chia-I Wu: On Fri, Nov 8, 2024 at 1:43 AM Christian König wrote: Hi guys, as pointed out by Chia-I userspace doesn't see any progress when signaling is not enabled and Boris noted that this is because dma_fence_array_signaled() never returns true in this case. Imp

Re: [PATCH] drm/sun4i: Workaround TCON TOP conflict between DE0 and DE1

2024-11-12 Thread John Watts
Hey everyone, I'm not sure exactly where to add this but I discussed some of this with Parthiban on #linux-sunxi a few days ago, so I want to write it down before I work on the next version of the patch. I had assumed for some reason in my mind that DE0 and DE1 here referred to mixers, but they a

Re: [PATCH] drm/panthor: Fix handling of partial GPU mapping of BOs

2024-11-12 Thread Boris Brezillon
On Mon, 11 Nov 2024 11:31:12 + Steven Price wrote: > On 11/11/2024 09:26, Akash Goel wrote: > > This commit fixes the handling of partial GPU mapping of buffer objects > > in Panthor. > > VM_BIND ioctl allows Userspace to partially map the BOs to GPU. > > To map a BO, Panthor walks through th

Re: [RFC PATCH 0/6] Common preempt fences and semantics

2024-11-12 Thread Christian König
Am 12.11.24 um 04:29 schrieb Matthew Brost: On Mon, Nov 11, 2024 at 02:42:02PM +0100, Christian König wrote: Am 09.11.24 um 18:29 schrieb Matthew Brost: The motivation for this series comes from pending UMD submission work by AMD [1], ARM [3], and the Xe team, who are also beginning to look at

[Bug 219492] amdgpu: failed to write reg 28b4 wait reg 28c6 and amdgpu: failed to write reg 1a6f4 wait reg 1a706

2024-11-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219492 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH v3 08/10] ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy Tab 2 7.0

2024-11-12 Thread Andreas Kemnade
Hi Mithil, Am Fri, 8 Nov 2024 20:04:37 + schrieb Mithil Bavishi : > Create a device tree for the 7 inch variants (P3100, P3110, P3113) > > Signed-off-by: Mithil Bavishi > --- > .../dts/ti/omap/omap4-samsung-espresso7.dts | 70 +++ > 1 file changed, 70 insertions(+) > cr

[PATCH] drm/mediatek: Initialize pointer in mtk_drm_of_ddp_path_build_one()

2024-11-12 Thread AngeloGioacchino Del Regno
The struct device_node *next pointer is not initialized, and it is used in an error path in which it may have never been modified by function mtk_drm_of_get_ddp_ep_cid(). Since the error path is relying on that pointer being NULL for the OVL Adaptor and/or invalid component check and since said po

Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

2024-11-12 Thread Andreas Kemnade
Am Fri, 8 Nov 2024 20:04:39 + schrieb Mithil Bavishi : > Create a device tree for the 10 inch variants (P5100, P5110, P5113) > > Signed-off-by: Mithil Bavishi > --- > .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++ > 1 file changed, 102 insertions(+) > create mode

[PATCH AUTOSEL 6.1 11/12] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-11-12 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 052ef642bd6c108a24f375f9ad174b97b425a50b ] There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it turns out that the 2G version has a DMI product name of "CHERRYVIEW D1 PLATFORM" where as the 4G version has "CHERRYVIEW C0 PLATFORM". The sys-ve

[PATCH AUTOSEL 6.6 14/15] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-11-12 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 052ef642bd6c108a24f375f9ad174b97b425a50b ] There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it turns out that the 2G version has a DMI product name of "CHERRYVIEW D1 PLATFORM" where as the 4G version has "CHERRYVIEW C0 PLATFORM". The sys-ve

[PATCH AUTOSEL 6.11 15/16] drm: panel-orientation-quirks: Make Lenovo Yoga Tab 3 X90F DMI match less strict

2024-11-12 Thread Sasha Levin
From: Hans de Goede [ Upstream commit 052ef642bd6c108a24f375f9ad174b97b425a50b ] There are 2G and 4G RAM versions of the Lenovo Yoga Tab 3 X90F and it turns out that the 2G version has a DMI product name of "CHERRYVIEW D1 PLATFORM" where as the 4G version has "CHERRYVIEW C0 PLATFORM". The sys-ve

RE: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

2024-11-12 Thread Biju Das
Hi Dan Carpenter, Thanks for the patch. > -Original Message- > From: Dan Carpenter > Sent: 12 November 2024 10:23 > Subject: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer > dereference in probe() > > If devm_i2c_new_dummy_device() fails then we were supposed to return an e

[PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

2024-11-12 Thread Dan Carpenter
If devm_i2c_new_dummy_device() fails then we were supposed to return an error code, but instead the function continues and will crash on the next line. Add the missing return statement. Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter") Signed-off-by: Dan Carpenter --- dr

  1   2   >