Re: [PATCH v1 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios

2024-12-19 Thread Dmitry Baryshkov
On Fri, Dec 20, 2024 at 11:48:53AM +0530, ANANDU KRISHNAN E wrote: > During fastrpc_rpmsg_probe, if secure device node registration > succeeds but non-secure device node registration fails, the secure > device node deregister is not called during error cleanup. Add proper > exit paths to ensure pro

[PATCH] drm: xlnx: zynqmp_dpsub: Fix kernel doc

2024-12-19 Thread Tomi Valkeinen
Fix two kernel doc warnings introduced by the recent DP audio patch: - Add a doc line for the new "audio" field - Remove a reference to zynqmp_dpsub.c from zynqmp.rst, as the .c file no longer has structured comments Fixes: 3ec5c1579305 ("drm: xlnx: zynqmp_dpsub: Add DP audio support") Closes:

Re: [PATCH v3 21/33] drm/mediatek: mtk_hdmi: Remove unused members of struct mtk_hdmi

2024-12-19 Thread 胡俊光

[git pull] drm fixes for 6.13-rc4

2024-12-19 Thread Dave Airlie
Hi Linus, Probably the last pull before Christmas holidays, I'll still be around for most of the time anyways, nothing too major in here, bunch of amdgpu and i915 along with a smattering of fixes across the board. Dave. drm-fixes-2024-12-20: drm fixes for 6.13-rc4 core: - fix FB dependency - av

[PATCH v1 2/2] misc: fastrpc: Add meaningful labels for exit paths

2024-12-19 Thread ANANDU KRISHNAN E
In fastrpc_rpmsg_probe function, exit path labels are not intuitive. It does not metion what the goto does or why the goto exists. Rename goto labels to make it more intuitive and to align with labels of other functions. Signed-off-by: ANANDU KRISHNAN E --- drivers/misc/fastrpc.c | 16 --

[PATCH v1 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios

2024-12-19 Thread ANANDU KRISHNAN E
During fastrpc_rpmsg_probe, if secure device node registration succeeds but non-secure device node registration fails, the secure device node deregister is not called during error cleanup. Add proper exit paths to ensure proper cleanup in case of error. Signed-off-by: ANANDU KRISHNAN E --- drive

[PATCH v1 0/2] Improve error handling in fastrpc_rpmsg_probe

2024-12-19 Thread ANANDU KRISHNAN E
Following changes are getting added as part of this patch series: - Add proper exit path label to handle deregister of device node properly in error scenarios. - Add meaningful labels for exit paths in fastrpc_rpmsg_probe function to make it intuitive. ANANDU KRISHNAN E (2): misc: fastrp

Re: [PATCH v3 18/33] drm/mediatek: mtk_hdmi: Move vendor/product strings to drm_bridge

2024-12-19 Thread 胡俊光

Re: [PATCH v4 24/25] drm/msm/dpu: Reorder encoder kickoff for CWB

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:35PM -0800, Jessica Zhang wrote: > Add a helper that will handle the correct order of the encoder kickoffs > for concurrent writeback. > > For concurrent writeback, the realtime encoder must always kickoff last > as it will call the trigger flush and start. > > This

Re: [PATCH v4 19/25] drm/msm/dpu: Configure CWB in writeback encoder

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:30PM -0800, Jessica Zhang wrote: > Cache the CWB block mask in the DPU virtual encoder and configure CWB > according to the CWB block mask within the writeback phys encoder > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c|

Re: [PATCH v4 18/25] drm/msm/dpu: Reserve resources for CWB

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:29PM -0800, Jessica Zhang wrote: > Add support for RM to reserve dedicated CWB PINGPONGs and CWB muxes > > For concurrent writeback, even-indexed CWB muxes must be assigned to > even-indexed LMs and odd-indexed CWB muxes for odd-indexed LMs. The same > even/odd rule a

Re: [PATCH v3 17/33] drm/mediatek: mtk_hdmi: Move N/CTS setting to new function

2024-12-19 Thread 胡俊光

Re: [PATCH v4 17/25] drm/msm/dpu: Fail atomic_check if CWB and CDM are enabled

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:28PM -0800, Jessica Zhang wrote: > We cannot support both CWB and CDM simultaneously as this would require > 2 CDM blocks and currently our hardware only supports 1 CDM block at > most. Why would CWB require a second CDM block? I think that YUV output over DP (needs_c

Re: [PATCH v4 16/25] drm/msm/dpu: Require modeset if clone mode status changes

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:27PM -0800, Jessica Zhang wrote: > If the clone mode enabled status is changing, a modeset needs to happen > so that the resources can be reassigned > > Signed-off-by: Jessica Zhang > --- > > NOTE: As noted by Sima in the v1 [1], the DPU driver doesn't handle > crtc

Re: [PATCH v3 14/15] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

2024-12-19 Thread Dmitry Baryshkov
On Fri, 20 Dec 2024 at 04:38, Damon Ding wrote: > > Hi Dmitry, > > On 2024/12/20 8:20, Dmitry Baryshkov wrote: > > On Thu, Dec 19, 2024 at 04:06:03PM +0800, Damon Ding wrote: > >> Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: > >> - Add edp-panel node > >> - Set pinctrl of pwm

Re: [PATCH v3 07/15] drm/bridge: analogix_dp: Add support for phy configuration.

2024-12-19 Thread Dmitry Baryshkov
On Fri, 20 Dec 2024 at 05:37, Damon Ding wrote: > > Hi Dmitry, > > On 2024/12/20 8:13, Dmitry Baryshkov wrote: > > On Thu, Dec 19, 2024 at 04:05:56PM +0800, Damon Ding wrote: > >> Add support to configurate link rate, lane count, voltage swing and > >> pre-emphasis with phy_configure(). It is help

Re: [PATCH v3 16/33] drm/mediatek: mtk_hdmi: Move plugged_cb/codec_dev setting to new function

2024-12-19 Thread 胡俊光

Re: [PATCH v4 00/25] drm/msm/dpu: Add Concurrent Writeback Support for DPU 10.x+

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:11PM -0800, Jessica Zhang wrote: > DPU supports a single writeback session running concurrently with primary > display when the CWB mux is configured properly. This series enables > clone mode for DPU driver and adds support for programming the CWB mux > in cases where

Re: [PATCH v4 15/25] drm/msm/dpu: Add CWB to msm_display_topology

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 04:43:26PM -0800, Jessica Zhang wrote: > Add the cwb_enabled flag to msm_display topology and adjust the toplogy > to account for concurrent writeback Why? > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 11 ++- > drivers/gpu/

Re: [PATCH v6 41/44] drm/colorop: allow non-bypass colorops

2024-12-19 Thread Alex Hung
On 10/4/24 05:43, Louis Chauvet wrote: On 03/10/24 - 16:01, Harry Wentland wrote: Not all HW will be able to do bypass on all color operations. Introduce an 'allow_bypass' boolean for all colorop init functions and only create the BYPASS property when it's true. Signed-off-by: Harry Wentland

[V7 35/45] drm/amd/display: add 3x4 matrix colorop

2024-12-19 Thread Alex Hung
This adds support for a 3x4 color transformation matrix. With this change the following IGT tests pass: kms_colorop --run plane-XR30-XR30-ctm_3x4_50_desat kms_colorop --run plane-XR30-XR30-ctm_3x4_overdrive kms_colorop --run plane-XR30-XR30-ctm_3x4_oversaturate kms_colorop --run plane-XR30-XR30-ct

[V7 44/45] drm/colorop: Add kernel doc for data blob

2024-12-19 Thread Alex Hung
Add layout of data blob for colorop types: DRM_COLOROP_1D_LUT, DRM_COLOROP_CTM_3X4 and DRM_COLOROP_3D_LUT Signed-off-by: Alex Hung --- include/drm/drm_colorop.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h index 7b5

[V7 45/45] drm/colorop: Add destroy functions for color pipeline

2024-12-19 Thread Alex Hung
The functions are to clean up color pipeline when a device driver fails to create its color pipeline. Signed-off-by: Alex Hung --- .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 3 +- drivers/gpu/drm/drm_colorop.c | 41 +++ drivers/gpu/drm/vkms/vkms_colorop.c

[V7 38/45] drm/amd/display: Swap matrix and multiplier

2024-12-19 Thread Alex Hung
Swap the order of matrix and multiplier as designed in hardware. Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 12 ++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c| 8 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

[V7 33/45] drm/colorop: Add 1D Curve Custom LUT type

2024-12-19 Thread Alex Hung
We've previously introduced DRM_COLOROP_1D_CURVE for pre-defined 1D curves. But we also have HW that supports custom curves and userspace needs the ability to pass custom curves, aka LUTs. This patch introduces a new colorop type, called DRM_COLOROP_1D_LUT that provides a SIZE property which is us

[V7 43/45] drm/amd/display: Add AMD color pipeline doc

2024-12-19 Thread Alex Hung
From: Harry Wentland Add kernel doc for AMD color pipeline. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 122 +++--- 1 file changed, 102 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[V7 42/45] drm/amd/display: add 3D LUT colorop

2024-12-19 Thread Alex Hung
This adds support for a 3D LUT. The color pipeline now consists of the following colorops: 1. 1D curve colorop 2. Multiplier 3. 3x4 CTM 4. 1D curve colorop 5. 1D LUT 6. 3D LUT 7. 1D curve colorop 8. 1D LUT Signed-off-by: Alex Hung --- v7: - Simplify 3D LUT according to drm_colorop changes (Simo

[V7 41/45] drm/colorop: Add 3D LUT supports to color pipeline

2024-12-19 Thread Alex Hung
It is to be used to enable HDR by allowing userpace to create and pass 3D LUTs to kernel and hardware. new drm_colorop_type: DRM_COLOROP_3D_LUT. Signed-off-by: Alex Hung --- v7: - Simplify 3D LUT by removing lut_3d_modes and related functions (Simon Ser) drivers/gpu/drm/drm_atomic.c | 6

[V7 40/45] drm/colorop: allow non-bypass colorops

2024-12-19 Thread Alex Hung
From: Harry Wentland Not all HW will be able to do bypass on all color operations. Introduce an 'allow_bypass' boolean for all colorop init functions and only create the BYPASS property when it's true. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- .../amd/display/amdgpu_dm/amdgpu

[V7 39/45] drm/colorop: Define LUT_1D interpolation

2024-12-19 Thread Alex Hung
From: Harry Wentland We want to make sure userspace is aware of the 1D LUT interpolation. While linear interpolation is common it might not be supported on all HW. Give driver implementers a way to specify their interpolation. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - F

[V7 37/45] drm/amd/display: add multiplier colorop

2024-12-19 Thread Alex Hung
This adds support for a multiplier. This multiplier is programmed via the HDR Multiplier in DCN. With this change the following IGT tests pass: kms_colorop --run plane-XR30-XR30-multiply_125 kms_colorop --run plane-XR30-XR30-multiply_inv_125 The color pipeline now consists of the following coloro

[V7 36/45] drm/colorop: Add mutliplier type

2024-12-19 Thread Alex Hung
This introduces a new drm_colorop_type: DRM_COLOROP_MULTIPLIER. It's a simple multiplier to all pixel values. The value is specified via a S31.32 fixed point provided via the "MULTIPLIER" property. Signed-off-by: Alex Hung --- v7: - Modify size_property to lut_size_property drivers/gpu/drm/dr

[V7 34/45] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT

2024-12-19 Thread Alex Hung
This patch adds colorops for custom 1D LUTs in the SHAPER and BLND HW blocks. With this change the following IGT tests pass: kms_colorop --run plane-XR30-XR30-srgb_inv_eotf_lut kms_colorop --run plane-XR30-XR30-srgb_inv_eotf_lut-srgb_eotf_lut The color pipeline now consists of the following color

[V7 32/45] drm/amd/display: Add support for BT.709 and BT.2020 TFs

2024-12-19 Thread Alex Hung
From: Harry Wentland This adds support for the BT.709/BT.2020 transfer functions on all current 1D curve plane colorops, i.e., on DEGAM, SHAPER, and BLND blocks. With this change the following IGT subtests pass: kms_colorop --run plane-XR30-XR30-bt2020_inv_oetf kms_colorop --run plane-XR30-XR30-

[V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF

2024-12-19 Thread Alex Hung
From: Harry Wentland The BT.709 and BT.2020 OETFs are the same, the only difference being that the BT.2020 variant is defined with more precision for 10 and 12-bit per color encodings. Both are used as encoding functions for video content, and are therefore defined as OETF (opto-electronic trans

[V7 30/45] drm/amd/display: Enable support for PQ 125 EOTF and Inverse

2024-12-19 Thread Alex Hung
From: Harry Wentland This patchset enables support for the PQ_125 EOTF and its inverse on all existing plane 1D curve colorops, i.e., on DEGAM, SHAPER, and BLND blocks. With this patchset the following IGT subtests are passing: kms_colorop --run plane-XR30-XR30-pq_125_eotf kms_colorop --run plan

[V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse

2024-12-19 Thread Alex Hung
From: Harry Wentland The PQ function defines a mapping of code values to nits (cd/m^2). The max code value maps to 10,000 nits. Windows DWM's canonical composition color space (CCCS) defaults to composing SDR contents to 80 nits and uses a float value of 1.0 to represent this. For this reason A

[V7 28/45] drm/amd/display: Add support for sRGB EOTF in BLND block

2024-12-19 Thread Alex Hung
Expose a 3rd 1D curve colorop, with support for DRM_COLOROP_1D_CURVE_SRGB_EOTF and program the BLND block to perform the sRGB transform when the colorop is not in bypass With this change the following IGT test passes: kms_colorop --run plane-XR30-XR30-srgb_eotf-srgb_inv_eotf-srgb_eotf The color p

linux-next: build warnings after merge of the drm-misc tree

2024-12-19 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/xlnx/zynqmp_dpsub.h:86: warning: Function parameter or struct member 'audio' not described in 'zynqmp_dpsub' drivers/gpu/drm/xlnx/zynqmp_dpsub.c:1: warning: no structured comment

[V7 26/45] drm/amd/display: Add support for sRGB EOTF in DEGAM block

2024-12-19 Thread Alex Hung
Expose one 1D curve colorop with support for DRM_COLOROP_1D_CURVE_SRGB_EOTF and program HW to perform the sRGB transform when the colorop is not in bypass. With this change the following IGT test passes: kms_colorop --run plane-XR30-XR30-srgb_eotf The color pipeline now consists of a single color

[V7 27/45] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block

2024-12-19 Thread Alex Hung
Expose a 2nd curve colorop with support for DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF and program HW to perform the sRGB Inverse EOTF on the shaper block when the colorop is not in bypass. With this change the follow IGT tests pass: kms_colorop --run plane-XR30-XR30-srgb_inv_eotf kms_colorop --run plane-

[V7 24/45] drm/amd/display: Add bypass COLOR PIPELINE

2024-12-19 Thread Alex Hung
From: Harry Wentland Add the default Bypass pipeline and ensure it passes the kms_colorop test plane-XR30-XR30-bypass. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 19 +++ 1 file changed, 19 insertions(+) diff --gi

[V7 25/45] drm/amd/display: Skip color pipeline initialization for cursor plane

2024-12-19 Thread Alex Hung
cursor plane does not need to have color pipeline. Signed-off-by: Alex Hung --- v7: - Add a commit messages drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/

[V7 23/45] drm/amd/display: Ignore deprecated props when plane_color_pipeline set

2024-12-19 Thread Alex Hung
From: Harry Wentland When the plane_color_pipeline bit is set we should ignore deprecated properties, such as COLOR_RANGE and COLOR_ENCODING. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 1 file changed, 4 insertions(+)

[V7 22/45] drm/colorop: define a new macro for_each_new_colorop_in_state

2024-12-19 Thread Alex Hung
Create a new macro for_each_new_colorop_in_state to access new drm_colorop_state updated from uapi. Signed-off-by: Alex Hung --- include/drm/drm_atomic.h | 20 1 file changed, 20 insertions(+) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index f3afc1ef3f

[V7 21/45] drm/colorop: pass plane_color_pipeline client cap to atomic check

2024-12-19 Thread Alex Hung
From: Harry Wentland Drivers will need to know whether an atomic check/commit originated from a client with DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE so they can ignore deprecated properties, like COLOR_ENCODING and COLOR_RANGE. Pass the plane_color_pipeline bit to drm_atomic_state. Signed-off-by: Al

[V7 20/45] drm/vkms: Add tests for CTM handling

2024-12-19 Thread Alex Hung
From: Harry Wentland A whole slew of tests for CTM handling that greatly helped in debugging the CTM code. The extent of tests might seem a bit silly but they're fast and might someday help save someone else's day when debugging this. Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-

[V7 19/45] drm/tests: Add a few tests around drm_fixed.h

2024-12-19 Thread Alex Hung
From: Harry Wentland While working on the CTM implementation of VKMS I had to ascertain myself of a few assumptions. One of those is whether drm_fixed.h treats its numbers using signed-magnitude or twos-complement. It is twos-complement. In order to make someone else's day easier I am adding the

[V7 18/45] drm/vkms: add 3x4 matrix in color pipeline

2024-12-19 Thread Alex Hung
From: Harry Wentland We add two 3x4 matrices into the VKMS color pipeline. The reason we're adding matrices is so that we can test that application of a matrix and its inverse yields an output equal to the input image. One complication with the matrix implementation has to do with the fact that

[V7 16/45] drm/colorop: Add 3x4 CTM type

2024-12-19 Thread Alex Hung
From: Harry Wentland This type is used to support a 3x4 matrix in colorops. A 3x4 matrix uses the last column as a "bias" column. Some HW exposes support for 3x4. The calculation looks like: out matrixin |R| |0 1 2 3 | | R | |G| = |4 5 6 7 | x | G | |B| |8 9 10 11| | B

[V7 17/45] drm/vkms: Use s32 for internal color pipeline precision

2024-12-19 Thread Alex Hung
From: Harry Wentland Certain operations require us to preserve values below 0.0 and above 1.0 (0x0 and 0x respectively in 16 bpc unorm). One such operation is a BT709 encoding operation followed by its decoding operation, or the reverse. We'll use s32 values as intermediate in and outputs of

[V7 15/45] drm/vkms: Add kunit tests for linear and sRGB LUTs

2024-12-19 Thread Alex Hung
From: Harry Wentland Two tests are added to VKMS LUT handling: - linear - inv_srgb Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Fix checkpatch warnings (Louis Chauvet) - Adde a commit messages - Fix code styles by adding and removing spaces

[V7 14/45] drm/vkms: Add enumerated 1D curve colorop

2024-12-19 Thread Alex Hung
From: Harry Wentland This patch introduces a VKMS color pipeline that includes two drm_colorops for named transfer functions. For now the only ones supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. We will expand this in the future but I don't want to do so without accompanying IGT tes

[V7 12/45] drm/plane: Add COLOR PIPELINE property

2024-12-19 Thread Alex Hung
From: Harry Wentland We're adding a new enum COLOR PIPELINE property. This property will have entries for each COLOR PIPELINE by referencing the DRM object ID of the first drm_colorop of the pipeline. 0 disables the entire COLOR PIPELINE. Userspace can use this to discover the available color pi

[V7 13/45] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

2024-12-19 Thread Alex Hung
From: Harry Wentland With the introduction of the pre-blending color pipeline we can no longer have color operations that don't have a clear position in the color pipeline. We deprecate all existing plane properties. For upstream drivers those are: - COLOR_ENCODING - COLOR_RANGE Drivers are ex

[V7 11/45] drm/colorop: Add atomic state print for drm_colorop

2024-12-19 Thread Alex Hung
From: Harry Wentland Print atomic state for drm_colorop in debugfs Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Add a commit messages - Squash "drm/colorop: Add NEXT to colorop state print" (Simon Ser) drivers/gpu/drm/drm_atomic.c | 26 +- 1 file

[V7 10/45] drm/colorop: Add NEXT property

2024-12-19 Thread Alex Hung
From: Harry Wentland We'll construct color pipelines out of drm_colorop by chaining them via the NEXT pointer. NEXT will point to the next drm_colorop in the pipeline, or by 0 if we're at the end of the pipeline. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v5: - move next comme

[V7 09/45] drm/colorop: Add BYPASS property

2024-12-19 Thread Alex Hung
From: Harry Wentland We want to be able to bypass each colorop at all times. Introduce a new BYPASS boolean property for this. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v6: - clarify that bypass is only valid if BYPASS prop exists (Louis Chauvet) drivers/gpu/drm/drm_atomic_

[V7 07/45] drm/colorop: Add 1D Curve subtype

2024-12-19 Thread Alex Hung
From: Harry Wentland Add a new drm_colorop with DRM_COLOROP_1D_CURVE with two subtypes: DRM_COLOROP_1D_CURVE_SRGB_EOTF and DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF. Signed-off-by: Harry Wentland Co-developed-by: Alex Hung Signed-off-by: Alex Hung --- v5: - Add drm_get_colorop_curve_1d_type_name in

[V7 08/45] Documentation/gpu: document drm_colorop

2024-12-19 Thread Alex Hung
From: Harry Wentland Add kernel doc for drm_colorop objects. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Add a commit messages v5: - Drop TODO Documentation/gpu/drm-kms.rst | 15 +++ drivers/gpu/drm/drm_colorop.c | 31 +++ 2 fil

[V7 04/45] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2024-12-19 Thread Alex Hung
From: Harry Wentland Add documentation for color pipeline API. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland --- v7: - Add a commit messages v5: - Don't require BYPASS to succeed (Sebastian) - use DATA for 1D and 3D LUT types (Sebastian) - update 3DLUT ops to use 3DLUT_MODES and

[V7 06/45] drm/colorop: Add TYPE property

2024-12-19 Thread Alex Hung
From: Harry Wentland Add a read-only TYPE property. The TYPE specifies the colorop type, such as enumerated curve, 1D LUT, CTM, 3D LUT, PWL LUT, etc. For now we're only introducing an enumerated 1D LUT type to illustrate the concept. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland ---

[V7 05/45] drm/colorop: Introduce new drm_colorop mode object

2024-12-19 Thread Alex Hung
From: Harry Wentland This patches introduces a new drm_colorop mode object. This object represents color transformations and can be used to define color pipelines. We also introduce the drm_colorop_state here, as well as various helpers and state tracking bits. Signed-off-by: Alex Hung Signed-

[V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16

2024-12-19 Thread Alex Hung
From: Harry Wentland fixp2int always rounds down, fixp2int_ceil rounds up. We need the new fixp2int_round. Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Reviewed-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling

2024-12-19 Thread Alex Hung
From: Harry Wentland Debugging LUT math is much easier when we can unit test it. Add kunit functionality to VKMS and add tests for - get_lut_index - lerp_u16 Reviewed-by: Louis Chauvet Signed-off-by: Alex Hung Signed-off-by: Harry Wentland Cc: Arthur Grillo --- v7: - Fix checkpatch warnin

[V7 01/45] drm: Add helper for conversion from signed-magnitude

2024-12-19 Thread Alex Hung
From: Harry Wentland CTM values are defined as signed-magnitude values. Add a helper that converts from CTM signed-magnitude fixed point value to the twos-complement value used by drm_fixed. Signed-off-by: Harry Wentland --- include/drm/drm_fixed.h | 18 ++ 1 file changed, 18 i

[V7 00/45] Color Pipeline API w/ VKMS

2024-12-19 Thread Alex Hung
This is an RFC set for a color pipeline API, along with implementations in VKMS and amdgpu. It is tested with a set of IGT tests that can be found at [1]. The IGT tests run a pixel-by-pixel comparison with an allowable delta variation as the goal for these transformations is perceptual correctness,

Re: [PATCH v3 14/33] drm/mediatek: mtk_hdmi: Move audio params selection to new function

2024-12-19 Thread 胡俊光

Re: [PATCH v3 07/15] drm/bridge: analogix_dp: Add support for phy configuration.

2024-12-19 Thread Damon Ding
Hi Dmitry, On 2024/12/20 8:13, Dmitry Baryshkov wrote: On Thu, Dec 19, 2024 at 04:05:56PM +0800, Damon Ding wrote: Add support to configurate link rate, lane count, voltage swing and pre-emphasis with phy_configure(). It is helpful in application scenarios where analogix controller is mixed wit

Re: [PATCH v4 08/25] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-12-19 Thread Dmitry Baryshkov
On Fri, Dec 20, 2024 at 04:40:52AM +0200, Dmitry Baryshkov wrote: > On Mon, Dec 16, 2024 at 05:39:15PM -0800, Abhinav Kumar wrote: > > > > > > On 12/16/2024 4:43 PM, Jessica Zhang wrote: > > > From: Dmitry Baryshkov > > > > > > Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resour

Re: [PATCH v3 13/33] drm/mediatek: mtk_hdmi: Fix typo for aud_sampe_size member

2024-12-19 Thread 胡俊光

Re: [PATCH v4 07/25] drm/msm/dpu: move resource allocation to CRTC

2024-12-19 Thread Dmitry Baryshkov
On Fri, Dec 20, 2024 at 04:32:34AM +0200, Dmitry Baryshkov wrote: > On Mon, Dec 16, 2024 at 05:47:50PM -0800, Abhinav Kumar wrote: > > > > > > On 12/16/2024 4:43 PM, Jessica Zhang wrote: > > > From: Dmitry Baryshkov > > > > > > All resource allocation is centered around the LMs. Then other bloc

Re: [PATCH v3 12/33] drm/mediatek: hdmi: Use regmap instead of iomem for main registers

2024-12-19 Thread 胡俊光

Re: [PATCH v3 10/15] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus

2024-12-19 Thread Damon Ding
Hi Dmitry, On 2024/12/20 8:18, Dmitry Baryshkov wrote: On Thu, Dec 19, 2024 at 04:05:59PM +0800, Damon Ding wrote: According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml, it is a good way to get panel through the DP AUX bus. Signed-off-by: Damon Ding --- .../bindings/display

Re: [PATCH v4 08/25] drm/msm/dpu: fill CRTC resources in dpu_crtc.c

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 05:39:15PM -0800, Abhinav Kumar wrote: > > > On 12/16/2024 4:43 PM, Jessica Zhang wrote: > > From: Dmitry Baryshkov > > > > Stop poking into CRTC state from dpu_encoder.c, fill CRTC HW resources > > from dpu_crtc_assign_resources(). > > > > Signed-off-by: Dmitry Baryshk

Re: [PATCH v3 14/15] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

2024-12-19 Thread Damon Ding
Hi Dmitry, On 2024/12/20 8:20, Dmitry Baryshkov wrote: On Thu, Dec 19, 2024 at 04:06:03PM +0800, Damon Ding wrote: Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: - Add edp-panel node - Set pinctrl of pwm12 for backlight - Enable edp0/hdptxphy0/vp2 Signed-off-by: Damon Ding

Re: [PATCH v4 07/25] drm/msm/dpu: move resource allocation to CRTC

2024-12-19 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 05:47:50PM -0800, Abhinav Kumar wrote: > > > On 12/16/2024 4:43 PM, Jessica Zhang wrote: > > From: Dmitry Baryshkov > > > > All resource allocation is centered around the LMs. Then other blocks > > (except DSCs) are allocated basing on the LMs that was selected, and LM >

Re: [PATCH v3 0/2] drm: Allow encoder modeset when connectors are changed

2024-12-19 Thread Dmitry Baryshkov
On Tue, Dec 17, 2024 at 04:02:21PM +0100, Maxime Ripard wrote: > On Mon, Dec 16, 2024 at 10:27:44AM -0800, Abhinav Kumar wrote: > > > > > > On 12/16/2024 3:06 AM, Maxime Ripard wrote: > > > On Wed, Dec 11, 2024 at 01:18:41PM -0800, Jessica Zhang wrote: > > > > Call encoder mode_set() when connect

Re: [PATCH v3 04/15] phy: phy-rockchip-samsung-hdptx: Rename some register names related to DP

2024-12-19 Thread Dmitry Baryshkov
On Fri, Dec 20, 2024 at 09:46:24AM +0800, Damon Ding wrote: > Hi Dmitry, > > On 2024/12/20 8:22, Dmitry Baryshkov wrote: > > On Thu, Dec 19, 2024 at 04:05:53PM +0800, Damon Ding wrote: > > > The modifications of DP register names are as follows: > > > - Add the '_MASK' suffix to some registers to

Re: [PATCH v7 0/3] drm: adv7511: ADV7535 fixes

2024-12-19 Thread Dmitry Baryshkov
On Tue, 19 Nov 2024 19:20:28 +, Biju Das wrote: > This patch series aims to fix 2 bugs in the ADV7535 driver > > 1) use-after-free bug in adv7533_attach_dsi() > 2) Drop unsupported single lane. > > Changes in v7: > - Dropped check for host_node as of_node_put() is a no-op when called >wi

Re: [PATCH v4] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

2024-12-19 Thread Dmitry Baryshkov
On Tue, 19 Nov 2024 08:40:29 +0100, Stefan Ekenberg wrote: > AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1 > while updating Audio InfoFrame information and then set to 0 when done. > Otherwise partially updated Audio InfoFrames could be sent out. Two > cases where this rule we

Re: [PATCH v3 04/15] phy: phy-rockchip-samsung-hdptx: Rename some register names related to DP

2024-12-19 Thread Damon Ding
Hi Dmitry, On 2024/12/20 8:22, Dmitry Baryshkov wrote: On Thu, Dec 19, 2024 at 04:05:53PM +0800, Damon Ding wrote: The modifications of DP register names are as follows: - Add the '_MASK' suffix to some registers to ensure consistency. - Complete the names of some register to their full names.

Re: [PATCH v4] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

2024-12-19 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 08:40:29AM +0100, Stefan Ekenberg wrote: > AUDIO_UPDATE bit (Bit 5 of MAIN register 0x4A) needs to be set to 1 > while updating Audio InfoFrame information and then set to 0 when done. > Otherwise partially updated Audio InfoFrames could be sent out. Two > cases where this r

Re: [PATCH 1/3] drm: bridge: adv7511: fill i2s stream capabilities

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 03:49:45PM +0100, Olivier MOYSAN wrote: > Hi Dmitry, > > On 12/11/24 23:52, Dmitry Baryshkov wrote: > > On Tue, Dec 10, 2024 at 02:42:52PM +0100, Olivier Moysan wrote: > > > Set no_i2s_capture flag in hdmi_codec_pdata structure to report > > > that the ADV7511 HDMI bridge d

[PATCH v2 7/8] drm/msm/dpu: link DSPP_2/_3 blocks on SM8650

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: b94747f7d8c7 ("drm/msm/dpu: add support for SM8650 DPU") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers

[PATCH v2 6/8] drm/msm/dpu: link DSPP_2/_3 blocks on SM8550

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu

[PATCH v2 8/8] drm/msm/dpu: link DSPP_2/_3 blocks on X1E80100

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: e3b1f369db5a ("drm/msm/dpu: Add X1E80100 support") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/d

[PATCH v2 5/8] drm/msm/dpu: link DSPP_2/_3 blocks on SM8350

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/g

[PATCH v2 4/8] drm/msm/dpu: link DSPP_2/_3 blocks on SM8250

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: 05ae91d960fd ("drm/msm/dpu: enable DSPP support on SM8[12]50") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- d

[PATCH v2 3/8] drm/msm/dpu: link DSPP_2/_3 blocks on SC8180X

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: f5abecfe339e ("drm/msm/dpu: enable DSPP and DSC on sc8180x") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- dri

[PATCH v2 2/8] drm/msm/dpu: link DSPP_2/_3 blocks on SM8150

2024-12-19 Thread Dmitry Baryshkov
Link DSPP_2 to the LM_2 and DSPP_3 to the LM_3 mixer blocks. This allows using colour transformation matrix (aka night mode) with more outputs at the same time. Fixes: 05ae91d960fd ("drm/msm/dpu: enable DSPP support on SM8[12]50") Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- d

[PATCH v2 1/8] drm/msm/dpu: provide DSPP and correct LM config for SDM670

2024-12-19 Thread Dmitry Baryshkov
On SDM670 the DPU has two DSPP blocks compared to 4 DSPP blocks on SDM845. Currently SDM670 just reuses LMs and DSPPs from SDM845. Define platform-specific configuration for those blocks. Fixes: e140b7e496b7 ("drm/msm/dpu: Add hw revision 4.1 (SDM670)") Reviewed-by: Abhinav Kumar Signed-off-by: D

[PATCH v2 0/8] drm/msm/dpu: catalog corrections

2024-12-19 Thread Dmitry Baryshkov
After checking the DSPP units in the catalog vs the vendor devicetrees, link several DSPP units to the corresponding LM units. Each correction is submitted separately in order to be able to track and apply / skip them separately based on the feedback from Qualcomm. I think at this point only CrOS c

Re: [PATCH v3 1/2] drm/bridge-connector: Prioritize supported_formats over ycbcr_420_allowed

2024-12-19 Thread Dmitry Baryshkov
On Tue, Dec 17, 2024 at 02:38:55AM +0200, Cristian Ciocaltea wrote: > On 12/17/24 1:27 AM, Dmitry Baryshkov wrote: > > On Tue, Dec 17, 2024 at 12:54:07AM +0200, Cristian Ciocaltea wrote: > >> Bridges having the DRM_BRIDGE_OP_HDMI flag set in drm_bridge->ops are > >> supposed to rely on drm_bridge->

Re: [PATCH v7 00/10] drm: add DRM HDMI Codec framework

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 04:16:37PM +, Dave Stevenson wrote: > On Wed, 18 Dec 2024 at 14:52, Dave Stevenson > wrote: > > > > Hi Maxime & Dmitry > > > > On Wed, 18 Dec 2024 at 07:59, Maxime Ripard wrote: > > > > > > On Wed, Dec 18, 2024 at 07:24:23AM +0200, Dmitry Baryshkov wrote: > > > > On Tu

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-19 Thread Marek Olšák
On Thu, Dec 19, 2024 at 5:32 AM Brian Starkey wrote: > On Wed, Dec 18, 2024 at 09:53:56PM +, Marek Olšák wrote: > > On Wed, Dec 18, 2024 at 5:32 AM Brian Starkey > wrote: > > > > > On Wed, Dec 18, 2024 at 11:24:58AM +, Simona Vetter wrote: > > > > > > > > For that reason I think linear m

Re: [PATCH v4] drm/bridge:anx7625: Update HDCP content status

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 03:03:29PM +0800, Xin Ji wrote: > When user enabled HDCP feature, userspace will set HDCP content > to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update > HDCP content to DRM_MODE_CONTENT_PROTECTION_ENABLED if down stream > support HDCP feature. > > As anx7625

Re: [PATCH v3 04/15] phy: phy-rockchip-samsung-hdptx: Rename some register names related to DP

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 04:05:53PM +0800, Damon Ding wrote: > The modifications of DP register names are as follows: > - Add the '_MASK' suffix to some registers to ensure consistency. > - Complete the names of some register to their full names. > - Swap the definitions of LCPLL_REF and ROPLL_REF.

Re: [PATCH v3 14/15] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 04:06:03PM +0800, Damon Ding wrote: > Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: > - Add edp-panel node > - Set pinctrl of pwm12 for backlight > - Enable edp0/hdptxphy0/vp2 > > Signed-off-by: Damon Ding > > --- > > Changes in v2: > - Remove bright

Re: [PATCH v3 10/15] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus

2024-12-19 Thread Dmitry Baryshkov
On Thu, Dec 19, 2024 at 04:05:59PM +0800, Damon Ding wrote: > According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml, > it is a good way to get panel through the DP AUX bus. > > Signed-off-by: Damon Ding > --- > .../bindings/display/rockchip/rockchip,analogix-dp.yaml| 3 +

  1   2   3   >