Re: [PATCH v2 3/8] x86, lib: Drop the unused return value from wbinvd_on_all_cpus()

2025-05-16 Thread Ingo Molnar
* Sean Christopherson wrote: > Drop wbinvd_on_all_cpus()'s return value; both the "real" version and the > stub always return '0', and none of the callers check the return. > > Signed-off-by: Sean Christopherson > --- > arch/x86/include/asm/smp.h | 5 ++--- > arch/x86/lib/cache-smp.c | 3 +

Re: [PATCH v2 4/8] x86, lib: Add WBNOINVD helper functions

2025-05-16 Thread Ingo Molnar
* Sean Christopherson wrote: > From: Kevin Loughlin > > In line with WBINVD usage, add WBONINVD helper functions. Fall back to > WBINVD (via alternative()) if WBNOINVD isn't supported, as WBINVD provides > a superset of functionality, just more slowly. > > Note, alternative() ensures compat

[PATCH v6 10/10] drm/bridge: adv7511: switch to the HDMI connector helpers

2025-05-16 Thread Dmitry Baryshkov
Rewrite the ADV7511 driver to use implementation provided by the DRM HDMI connector framework, including the Audio and CEC bits. Drop the in-bridge connector support and use drm_bridge_connector if the host requires the connector to be provided by the bridge. Note: currently only AVI InfoFrames ar

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-16 Thread Xu Yilun
On Fri, May 16, 2025 at 09:49:53AM -0300, Jason Gunthorpe wrote: > On Fri, May 16, 2025 at 02:19:45PM +0800, Xu Yilun wrote: > > > I don't know why you'd disable a viommu while the VM is running, > > > doesn't make sense. > > > > Here it means remove the CC setup for viommu, shared setup is still

[PATCH v6 07/10] drm/vc4: hdmi: switch to generic CEC helpers

2025-05-16 Thread Dmitry Baryshkov
Switch VC4 driver to using CEC helpers code, simplifying hotplug and registration / cleanup. The existing vc4_hdmi_cec_release() is kept for now. Signed-off-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/Kconfig| 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 137

[PATCH v6 03/10] drm/connector: add CEC-related fields

2025-05-16 Thread Dmitry Baryshkov
As a preparation to adding HDMI CEC helper code, add CEC-related fields to the struct drm_connector. The callbacks abstract CEC infrastructure in order to support CEC adapters and CEC notifiers in a universal way. CEC data is a void pointer as it allows us to make CEC data helper-specific. For exa

[PATCH v6 04/10] drm/display: move CEC_CORE selection to DRM_DISPLAY_HELPER

2025-05-16 Thread Dmitry Baryshkov
THe Kconfig symbol DRM_DISPLAY_DP_AUX_CEC is a boolean which simply toggles whether DP_AUX_CEC support should be built into the drm_display_helper (which can be eithera module or built-in into the kernel). If DRM_DISPLAY_DP_AUX_CEC is selected, then CEC_CORE is selected to be built-in into the kern

[PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-16 Thread Dmitry Baryshkov
Currently it is next to impossible to implement CEC handling for the setup using drm_bridges and drm_bridge_connector: bridges don't have a hold of the connector at the proper time to be able to route CEC events. At the same time it not very easy and obvious to get the CEC physical address handlin

[PATCH v6 01/10] drm/bridge: move private data to the end of the struct

2025-05-16 Thread Dmitry Baryshkov
WHen adding HDMI fields I didn't notice the private: declaration for HPD fields. Move private fields to the end of the struct drm_bride to have clear distinction between private and public fields. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- in

[PATCH v6 08/10] drm/display: bridge-connector: hook in CEC notifier support

2025-05-16 Thread Dmitry Baryshkov
Allow HDMI DRM bridges to create CEC notifier. Physical address is handled automatically by drm_atomic_helper_connector_hdmi_hotplug() being called from .detect() path. Signed-off-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_br

[PATCH v6 09/10] drm/display: bridge-connector: handle CEC adapters

2025-05-16 Thread Dmitry Baryshkov
Implement necessary glue code to let DRM bridge drivers to implement CEC adapters support. Signed-off-by: Dmitry Baryshkov Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/Kconfig| 1 + drivers/gpu/drm/display/drm_bridge_connector.c | 83 +

[PATCH v6 05/10] drm/display: add CEC helpers code

2025-05-16 Thread Dmitry Baryshkov
Add generic CEC helpers to be used by HDMI drivers. Both notifier and and adapter are supported for registration. Once registered, the driver can call common set of functions to update physical address, to invalidate it or to unregister CEC data. Unlike drm_connector_cec_funcs (which provides inter

[PATCH v6 06/10] drm/display: hdmi-state-helper: handle CEC physical address

2025-05-16 Thread Dmitry Baryshkov
Call HDMI CEC helpers in order to update physical address of the adapter. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v6 02/10] drm/bridge: allow limiting I2S formats

2025-05-16 Thread Dmitry Baryshkov
By default HDMI codec registers all formats supported on the I2S bus. Allow bridges (and connectors) to limit the list of the PCM formats supported by the HDMI codec. Reviewed-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_brid

Re: [PATCH V8 40/43] drm/colorop: Add 3D LUT support to color pipeline

2025-05-16 Thread Xaver Hugl
Am Do., 27. März 2025 um 00:58 Uhr schrieb Alex Hung : > > It is to be used to enable HDR by allowing userpace to create and pass > 3D LUTs to kernel and hardware. > > new drm_colorop_type: DRM_COLOROP_3D_LUT. > > Signed-off-by: Alex Hung > --- > v8: > - Fix typo in subject (Simon Ser) > - Updat

Re: [PATCH v5 00/24] drm/msm: Add support for SM8750

2025-05-16 Thread Jessica Zhang
On 4/30/2025 6:00 AM, Krzysztof Kozlowski wrote: Hi, Dependency / Rabased on top of == https://lore.kernel.org/all/20241214-dpu-drop-features-v1-0-988f0662c...@linaro.org/ Hey Krzysztof, JFYI, I think there was some discussion on IRC (specifically #linux-msm) a

Re: [git pull] drm fixes for 6.15-rc7

2025-05-16 Thread pr-tracker-bot
The pull request you sent on Sat, 17 May 2025 06:44:48 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-05-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/12b6c62c038e85354154aee4eb2cf7a2168b3ecc Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH v3 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-16 Thread Chaoyi Chen
Hi Heiko, On 2025/5/15 21:00, Heiko Stübner wrote: Hi, Am Dienstag, 13. Mai 2025, 03:19:04 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen: From: Chaoyi Chen + ports: +$ref: /schemas/graph.yaml#/properties/ports + +properties: + port@0: +$ref: /schemas/graph.yaml#/prop

Re: [PATCH v10 02/10] mtd: intel-dg: implement region enumeration

2025-05-16 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:37PM +0300, Alexander Usyskin wrote: > In intel-dg, there is no access to the spi controller, > the information is extracted from the descriptor region. ... > +static int intel_dg_nvm_init(struct intel_dg_nvm *nvm, struct device *device) > +{ > + int ret; > +

Re: [PATCH v10 01/10] mtd: add driver for intel graphics non-volatile memory device

2025-05-16 Thread Raag Jadav
On Thu, May 15, 2025 at 04:33:36PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. A few nits below but we're good to go. Reviewed-by: Raag Jadav ... > +static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > +

Re: [PATCH 4/5] drm/msm/dpu: Filter writeback modes using writeback maxlinewidth

2025-05-16 Thread Dmitry Baryshkov
On Thu, May 15, 2025 at 05:48:09PM -0700, Jessica Zhang wrote: > > > On 5/14/2025 5:17 PM, Dmitry Baryshkov wrote: > > On Thu, 15 May 2025 at 02:52, Jessica Zhang > > wrote: > > > > > > Since the max mixer width is not a strict hardware limit, use the actual > > > > Is it? What is the actual m

[PATCH v2 1/8] KVM: SVM: Remove wbinvd in sev_vm_destroy()

2025-05-16 Thread Sean Christopherson
From: Zheyun Shen Before sev_vm_destroy() is called, kvm_arch_guest_memory_reclaimed() has been called for SEV and SEV-ES and kvm_arch_gmem_invalidate() has been called for SEV-SNP. These functions have already handled flushing the memory. Therefore, this wbinvd_on_all_cpus() can simply be droppe

[PATCH v2 7/8] x86, lib: Add wbinvd and wbnoinvd helpers to target multiple CPUs

2025-05-16 Thread Sean Christopherson
From: Zheyun Shen Extract KVM's open-coded calls to do writeback caches on multiple CPUs to common library helpers for both WBINVD and WBNOINVD (KVM will use both). Put the onus on the caller to check for a non-empty mask to simplify the SMP=n implementation, e.g. so that it doesn't need to check

[PATCH v2 3/8] x86, lib: Drop the unused return value from wbinvd_on_all_cpus()

2025-05-16 Thread Sean Christopherson
Drop wbinvd_on_all_cpus()'s return value; both the "real" version and the stub always return '0', and none of the callers check the return. Signed-off-by: Sean Christopherson --- arch/x86/include/asm/smp.h | 5 ++--- arch/x86/lib/cache-smp.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletio

[PATCH v2 8/8] KVM: SVM: Flush cache only on CPUs running SEV guest

2025-05-16 Thread Sean Christopherson
From: Zheyun Shen On AMD CPUs without ensuring cache consistency, each memory page reclamation in an SEV guest triggers a call to do WBNOINVD/WBINVD on all CPUs, thereby affecting the performance of other programs on the host. Typically, an AMD server may have 128 cores or more, while the SEV gu

[PATCH v2 5/8] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency

2025-05-16 Thread Sean Christopherson
From: Kevin Loughlin AMD CPUs currently execute WBINVD in the host when unregistering SEV guest memory or when deactivating SEV guests. Such cache maintenance is performed to prevent data corruption, wherein the encrypted (C=1) version of a dirty cache line might otherwise only be written back af

[PATCH v2 2/8] drm/gpu: Remove dead checks on wbinvd_on_all_cpus()'s return value

2025-05-16 Thread Sean Christopherson
Remove the checks and associated pr_err() on wbinvd_on_all_cpus() failure, as the helper has unconditionally returned 0/success since commit caa759323c73 ("smp: Remove smp_call_function() and on_each_cpu() return values"). Signed-off-by: Sean Christopherson --- drivers/gpu/drm/drm_cache.c | 9 ++

[PATCH v2 4/8] x86, lib: Add WBNOINVD helper functions

2025-05-16 Thread Sean Christopherson
From: Kevin Loughlin In line with WBINVD usage, add WBONINVD helper functions. Fall back to WBINVD (via alternative()) if WBNOINVD isn't supported, as WBINVD provides a superset of functionality, just more slowly. Note, alternative() ensures compatibility with early boot code as needed. Signed

[PATCH v2 6/8] KVM: x86: Use wbinvd_on_cpu() instead of an open-coded equivalent

2025-05-16 Thread Sean Christopherson
Use wbinvd_on_cpu() to target a single CPU instead of open-coding an equivalent. In addition to deduplicating code, this will allow removing KVM's wbinvd_ipi() once the other usage is gone. No functional change intended. Reviewed-by: Tom Lendacky Signed-off-by: Sean Christopherson --- arch/x8

[PATCH v2 0/8] x86, KVM: Optimize SEV cache flushing

2025-05-16 Thread Sean Christopherson
This is the combination of Kevin's WBNOINVD series[1] with Zheyun's targeted flushing series[2]. The combined goal is to use WBNOINVD instead of WBINVD when doing cached maintenance to prevent data corruption due to C-bit aliasing, and to reduce the number of cache invalidations by only performing

[pull] drm/msm: drm-msm-next-2025-05-16 for v6.16

2025-05-16 Thread Rob Clark
Hi Dave, Simona, Pull for v6.16 as described below. There are a pair of x1e80100 dts patches, ack'd by Bjorn, to preserve ordering (the driver part needs to land before the dts part). These should not conflict with any other dts patches in flight this cycle. The following changes since commit 0

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-16 Thread Anusha Srivatsa
On Wed, May 14, 2025 at 5:22 AM Jani Nikula wrote: > On Tue, 13 May 2025, Maxime Ripard wrote: > > Is it really surprising you get some pushback when you are using a > > design that is the complete opposite to what every user of it for the > > last decade has been doing? > > The opposite is also

[pull] amdgpu, amdkfd, radeon drm-next-6.16

2025-05-16 Thread Alex Deucher
Hi Dave, Simona, Last few updates for 6.16. The following changes since commit 1faeeb315fdbd005bbc1bc74214e39087971dda9: Merge tag 'amd-drm-next-6.16-2025-05-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2025-05-12 07:14:34 +1000) are available in the Git repository at:

[git pull] drm fixes for 6.15-rc7

2025-05-16 Thread Dave Airlie
Hi Linus, Weekly drm fixes, I'll be honest and say I think this is larger than I'd prefer at this point, the main blow out point is that xe has two larger fixes. One is a fix for active context utilisation reporting, it's for a reported regression and will end up in stable anyways, so I don't see

Re: [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends

2025-05-16 Thread Bill Wendling
On Fri, May 16, 2025 at 2:48 AM Jani Nikula wrote: > On Thu, 15 May 2025, Bill Wendling wrote: > > On 1/23/25 7:09 AM, Jani Nikula wrote: > >> The expectation is that the struct drm_device based logging helpers get > >> passed an actual struct drm_device pointer rather than some random > >> struc

Re: [PATCH v3 16/19] nova-core: Add support for VBIOS ucode extraction for boot

2025-05-16 Thread Timur Tabi
On Wed, 2025-05-07 at 22:52 +0900, Alexandre Courbot wrote: > +impl FwSecBiosImage { > +    fn setup_falcon_data( > +    &mut self, > +    pdev: &pci::Device, > +    pci_at_image: &PciAtBiosImage, > +    first_fwsec_image: &FwSecBiosImage, > +    ) -> Result<()> { > +    let mut

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Dave Airlie
On Sat, 17 May 2025 at 06:04, Johannes Weiner wrote: > > On Fri, May 16, 2025 at 07:42:08PM +0200, Christian König wrote: > > On 5/16/25 18:41, Johannes Weiner wrote: > > >>> Listen, none of this is even remotely new. This isn't the first cache > > >>> we're tracking, and it's not the first consum

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Johannes Weiner
On Fri, May 16, 2025 at 07:42:08PM +0200, Christian König wrote: > On 5/16/25 18:41, Johannes Weiner wrote: > >>> Listen, none of this is even remotely new. This isn't the first cache > >>> we're tracking, and it's not the first consumer that can outlive the > >>> controlling cgroup. > >> > >> Yes,

Re: [PATCH v3] drm: drm_fourcc: add 10/12/16bit software decoder YCbCr formats

2025-05-16 Thread Robert Mader
Hey Dave, sorry for the noise, I just wanted to quickly ask if with Daniels R-b below this patch is good to go into 6.16 once the window opens? Still new to the process here, therefore want to double-check :) Thanks and best regards, Robert Mader On 12.05.25 16:26, Daniel Stone wrote: Hi R

Re: [PATCH v4 6/8] backlight: led-backlight: add devlink to supplier LEDs

2025-05-16 Thread Luca Ceresoli
Hello Alexander, On Mon, 12 May 2025 12:13:54 + "Sverdlin, Alexander" wrote: > > I've tested the patch wit LP8864 LED as a provider for led_bl, removing the > > underlying I2C bus. The patch avoids the crash for me (by removing led_bl > > device as well), > > thanks for fixing it! > > > >

Re: [PATCH 2/2] dmabuf/heaps: implement DMA_BUF_IOCTL_RW_FILE for system_heap

2025-05-16 Thread T.J. Mercier
On Fri, May 16, 2025 at 1:36 AM Christian König wrote: > > On 5/16/25 09:40, wangtao wrote: > > > > > >> -Original Message- > >> From: Christian König > >> Sent: Thursday, May 15, 2025 10:26 PM > >> To: wangtao ; sumit.sem...@linaro.org; > >> benjamin.gaign...@collabora.com; brian.star...

Re: [PATCH v3] drm/amdkfd: Change svm_range_get_info return type

2025-05-16 Thread Felix Kuehling
On 2025-04-02 10:12, Ваторопин Андрей wrote: > From: Andrey Vatoropin > > Static analysis shows that pointer "svms" cannot be NULL because it points > to the object "struct svm_range_list". Remove the extra NULL check. It is > meaningless and harms the readability of the code. > > In the function

Re: [PATCH v3 01/10] dt-bindings: npu: rockchip,rknn: Add bindings

2025-05-16 Thread Rob Herring (Arm)
tation/devicetree/bindings/npu/rockchip,rknn-core.example.dtb: npu-core@fdac (rockchip,rk3588-rknn-core): reg: [[0, 4255907840, 0, 36864]] is too short from schema $id: http://devicetree.org/schemas/npu/rockchip,rknn-core.yaml# doc reference errors (make refcheckdocs): See h

Re: [PATCH] drm/panel-edp: Add BOE NV133WUM-N61 panel entry

2025-05-16 Thread Doug Anderson
Hi, On Thu, May 15, 2025 at 2:11 PM Rob Clark wrote: > > From: Rob Clark > > Add an eDP panel for BOE NV133WUM-N61, which appears to be a 3rd panel > option on the lenevo x13s laptop. > > edid: > 00 ff ff ff ff ff ff 00 09 e5 64 09 00 00 00 00 > 16 1e 01 04 a5 1d 12 78 03 55 8e a7 51 4c 9c 26 >

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Christian König
On 5/16/25 18:41, Johannes Weiner wrote: >>> Listen, none of this is even remotely new. This isn't the first cache >>> we're tracking, and it's not the first consumer that can outlive the >>> controlling cgroup. >> >> Yes, I knew about all of that and I find that extremely questionable >> on existi

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

2025-05-16 Thread Philipp Stanner
On Fri, 2025-05-16 at 15:30 +0100, Tvrtko Ursulin wrote: > > On 16/05/2025 14:38, Philipp Stanner wrote: > > On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: > > > > > > On 16/05/2025 12:53, Tvrtko Ursulin wrote: > > > > > > > > On 16/05/2025 08:28, Philipp Stanner wrote: > > > > > On Th

[PATCH v2 4/4] rust: drm: gem: Drop Object::SIZE

2025-05-16 Thread Lyude Paul
Drive-by fix, it doesn't seem like anything actually uses this constant anymore. Signed-off-by: Lyude Paul --- rust/kernel/drm/gem/mod.rs | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs index 2b81298d29765..d0f8da54f

[PATCH v2 0/4] rust: drm: gem: More (and final) cleanup

2025-05-16 Thread Lyude Paul
Look mom, no generic soup! Anyway - this is just the last of the cleanup stuff I ended up while working on cleaning up the gem shmem patch series. It simplifies the use of generics and also adds a type alias for some very long types currently in use. Also, drop one unused constant I noticed. Appl

[PATCH v2 1/4] rust: drm: gem: Simplify use of generics

2025-05-16 Thread Lyude Paul
Now that my rust skills have been honed, I noticed that there's a lot of generics in our gem bindings that don't actually need to be here. Currently the hierarchy of traits in our gem bindings looks like this: * Drivers implement: * BaseDriverObject (has the callbacks) * DriverObject (ha

[PATCH v2 3/4] rust: drm: gem: Add ObjectFile type alias

2025-05-16 Thread Lyude Paul
Just to reduce the clutter with the File<…> types in gem.rs. Signed-off-by: Lyude Paul --- rust/kernel/drm/gem/mod.rs | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs index c17b36948bae3..2b81

[PATCH v2 2/4] rust: drm: gem: Add DriverObject type alias

2025-05-16 Thread Lyude Paul
Now that we've cleaned up the generics for gem objects a bit, we're still left with a bit of generic soup around referring to the Object implementation for a given driver. Let's clean this up a bit by re-using the DriverObject identifier we just freed up and turning it into a type alias for referri

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

2025-05-16 Thread Alex Deucher
On Thu, May 15, 2025 at 9:23 PM Leonardo Gomes wrote: > > Thanks for your reply Alex, > > I just realize with your comment that > drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c import dal_hw_gpio_get_value > and dal_hw_gpio_set_value. > So to make those functions inside > drivers/gpu/drm/amd/dis

[PATCH v3 07/10] accel/rocket: Add job submission IOCTL

2025-05-16 Thread Tomeu Vizoso
Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was initially based on Panfrost. v2: - Remove hardcoded number

[PATCH v3 09/10] arm64: dts: rockchip: add pd_npu label for RK3588 power domains

2025-05-16 Thread Tomeu Vizoso
From: Nicolas Frattaroli The NPU of the RK3588 has an external supply. This supply also affects the power domain of the NPU, not just the NPU device nodes themselves. Since correctly modelled boards will want the power domain to be aware of the regulator so that it doesn't always have to be on, a

[PATCH v3 10/10] arm64: dts: rockchip: enable NPU on ROCK 5B

2025-05-16 Thread Tomeu Vizoso
From: Nicolas Frattaroli The NPU on the ROCK5B uses the same regulator for both the sram-supply and the npu's supply. Add this regulator, and enable all the NPU bits. Also add the regulator as a domain-supply to the pd_npu power domain. Signed-off-by: Nicolas Frattaroli Signed-off-by: Tomeu Viz

[PATCH v3 03/10] arm64: dts: rockchip: Enable the NPU on quartzpro64

2025-05-16 Thread Tomeu Vizoso
Enable the nodes added in a previous commit to the rk3588s device tree. v2: - Split nodes (Sebastian Reichel) - Sort nodes (Sebastian Reichel) - Add board regulators (Sebastian Reichel) Signed-off-by: Tomeu Vizoso --- .../arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 30 +

[PATCH v3 08/10] accel/rocket: Add IOCTLs for synchronizing memory accesses

2025-05-16 Thread Tomeu Vizoso
The NPU cores have their own access to the memory bus, and this isn't cache coherent with the CPUs. Add IOCTLs so userspace can mark when the caches need to be flushed, and also when a writer job needs to be waited for before the buffer can be accessed from the CPU. Initially based on the same IO

[PATCH v3 06/10] accel/rocket: Add IOCTL for BO creation

2025-05-16 Thread Tomeu Vizoso
This uses the SHMEM DRM helpers and we map right away to the CPU and NPU sides, as all buffers are expected to be accessed from both. v2: - Sync the IOMMUs for the other cores when mapping and unmapping. v3: - Make use of GPL-2.0-only for the copyright notice (Jeff Hugo) Signed-off-by: Tomeu Viz

[PATCH v3 05/10] accel/rocket: Add a new driver for Rockchip's NPU

2025-05-16 Thread Tomeu Vizoso
This initial version supports the NPU as shipped in the RK3588 SoC and described in the first part of its TRM, in Chapter 36. This NPU contains 3 independent cores that the driver can submit jobs to. This commit adds just hardware initialization and power management. v2: - Split cores and IOMMUs

[PATCH v3 02/10] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2025-05-16 Thread Tomeu Vizoso
See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). This is a derivative of NVIDIA's NVDLA, but with its own front-end processor. The IP is divided in three cores, programmed independently. The first core though is special, requiring to be powered on before any of the others can be used. The IOM

[PATCH v3 00/10] New DRM accel driver for Rockchip's RKNN NPU

2025-05-16 Thread Tomeu Vizoso
This series adds a new driver for the NPU that Rockchip includes in its newer SoCs, developed by them on the NVDLA base. In its current form, it supports the specific NPU in the RK3588 SoC. The userspace driver is part of Mesa and an initial draft can be found at: https://gitlab.freedesktop.org/

[PATCH v3 01/10] dt-bindings: npu: rockchip,rknn: Add bindings

2025-05-16 Thread Tomeu Vizoso
Add the bindings for the Neural Processing Unit IP from Rockchip. v2: - Adapt to new node structure (one node per core, each with its own IOMMU) - Several misc. fixes from Sebastian Reichel v3: - Split register block in its constituent subblocks, and only require the ones that the kernel woul

[PATCH v8 3/3] drm/tests: bridge: add KUnit tests for devm_drm_bridge_alloc()

2025-05-16 Thread Luca Ceresoli
Add KUnit tests for the newly introduced devm_drm_bridge_alloc(). Signed-off-by: Luca Ceresoli --- Changed in v8: - rebase on new patch converting drm_bridge_test.c to devm_drm_bridge_alloc() - add check that bridge is removed (thanks to the .destroy callback) - add a check with get/put

[PATCH v8 1/3] drm/tests: bridge: convert to devm_drm_bridge_alloc() API

2025-05-16 Thread Luca Ceresoli
Use the new DRM bridge allocation API, which is the only supported now, for the kunit tests. This change is more massive than for the typical DRM bridge driver because struct drm_bridge_init_priv currently embeds a struct drm_bridge, which is not supported anymore. We new have to use devm_drm_brid

[PATCH v8 2/3] dmr/bridge: add a .destroy func

2025-05-16 Thread Luca Ceresoli
Some users of DRM bridges may need to execute specific code just before deallocation. As of now the only known user would be KUnit tests. Suggested-by: Maxime Ripard Signed-off-by: Luca Ceresoli --- This patch is new in v8. The .destroy callback had appeared in v5 as well [5], but as part of

[PATCH v8 0/3] drm/bridge: add kunit tests for devm_drm_bridge_alloc()

2025-05-16 Thread Luca Ceresoli
This small series adds a few kunit tests for the new DRM bridge allocation flow, based on the recently introduced devm_drm_bridge_alloc() [0]. It is part of the work towards removal of bridges from a still existing DRM pipeline without use-after-free. The steps in the grand plan [1] are: 1. ➜ a

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Johannes Weiner
On Fri, May 16, 2025 at 05:35:12PM +0200, Christian König wrote: > On 5/16/25 16:53, Johannes Weiner wrote: > > On Fri, May 16, 2025 at 08:53:07AM +0200, Christian König wrote: > >> The cgroup who originally allocated it has no reference to the > >> memory any more and also no way of giving it back

Re: [PATCH 1/2] rust: drm: gem: Simplify use of generics

2025-05-16 Thread Lyude Paul
I need to actually re-spin this one more time - I realized this mistakenly hardcodes the gem object type for all callbacks (e.g. we wouldn't get an shmem gem object when we add shmem support in the future) so i'll have to add a type alias for this On Thu, 2025-05-15 at 17:42 -0400, Lyude Paul wrot

Re: [PATCH v4 01/40] drm/gpuvm: Don't require obj lock in destructor path

2025-05-16 Thread Rob Clark
On Fri, May 16, 2025 at 2:01 AM Danilo Krummrich wrote: > > On Thu, May 15, 2025 at 02:57:46PM -0700, Rob Clark wrote: > > On Thu, May 15, 2025 at 10:55 AM Danilo Krummrich wrote: > > > Anyways, I don't agree with that. Even if you can tweak your driver to > > > not run > > > into trouble with t

Re: [PATCH 3/5] drm/msm/dpu: Check mode against PINGPONG or DSC max width

2025-05-16 Thread Dmitry Baryshkov
On Fri, 16 May 2025 at 03:39, Jessica Zhang wrote: > > > > On 5/14/2025 5:28 PM, Dmitry Baryshkov wrote: > > On Wed, May 14, 2025 at 04:52:31PM -0700, Jessica Zhang wrote: > >> Validate requested mode and topology based on the PINGPONG or DSC encoder > >> max width. In addition, drop MAX_HDISPLAY_

[PATCH] drm/amdgpu: check return value of xa_store()

2025-05-16 Thread Salah Triki
xa_store() may fail so check its return value and if error occurred free numa_info and return NULL. Signed-off-by: Salah Triki --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/driv

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Johannes Weiner
On Thu, May 15, 2025 at 01:02:07PM +1000, Dave Airlie wrote: > > I have to admit I'm pretty clueless about the gpu driver internals and > > can't really judge how feasible this is. But from a cgroup POV, if you > > want proper memory isolation between groups, it seems to me that's the > > direction

[PATCH v4 1/7] drm/panthor: Add performance counter uAPI

2025-05-16 Thread Lukas Zapolskas
This patch extends the DEV_QUERY ioctl to return information about the performance counter setup for userspace, and introduces the new ioctl DRM_PANTHOR_PERF_CONTROL in order to allow for the sampling of performance counters. The new design is inspired by the perf aux ringbuffer, with the insert a

[PATCH v2] accel/qaic: Add Reliability, Accessibility, Serviceability (RAS)

2025-05-16 Thread Jeff Hugo
AIC100 devices generates Reliability, Availability, Serviceability events via MHI QAIC_STATUS channel. Support such events and print a structured log with details of the events, and if the event describes an uncorrected error, reset the device to put it back into service. As these events may not al

[PATCH v4 7/7] drm/panthor: Expose the panthor perf ioctls

2025-05-16 Thread Lukas Zapolskas
This patch implements the PANTHOR_PERF_CONTROL ioctl series, and a PANTHOR_GET_UOBJ wrapper to deal with the backwards and forwards compatibility of the uAPI. The minor version is bumped to indicate that the feature is now supported. Signed-off-by: Lukas Zapolskas Reviewed-by: Adrián Larumbe --

[PATCH v4 3/7] drm/panthor: Add panthor perf initialization and termination

2025-05-16 Thread Lukas Zapolskas
Added the panthor_perf system initialization and unplug code to allow for the handling of userspace sessions to be added in follow-up patches. Signed-off-by: Lukas Zapolskas --- drivers/gpu/drm/panthor/panthor_device.c | 2 + drivers/gpu/drm/panthor/panthor_device.h | 5 +- drivers/gpu/drm/pan

[PATCH v4 5/7] drm/panthor: Implement the counter sampler and sample handling

2025-05-16 Thread Lukas Zapolskas
From: Adrián Larumbe The sampler aggregates counter and set requests coming from userspace and mediates interactions with the FW interface, to ensure that user sessions cannot override the global configuration. >From the top-level interface, the sampler supports two different types of samples: c

[PATCH v4 6/7] drm/panthor: Add suspend, resume and reset handling

2025-05-16 Thread Lukas Zapolskas
The sampler must disable and re-enable counter sampling around suspends, and must re-program the FW interface after a reset to avoid losing data. Signed-off-by: Lukas Zapolskas --- drivers/gpu/drm/panthor/panthor_device.c | 7 +- drivers/gpu/drm/panthor/panthor_perf.c | 102 +

[PATCH v4 2/7] drm/panthor: Add DEV_QUERY.PERF_INFO handling for Gx10

2025-05-16 Thread Lukas Zapolskas
This change adds the IOCTL to query data about the performance counter setup. Some of this data was available via previous DEV_QUERY calls, for instance for GPU info, but exposing it via PERF_INFO minimizes the overhead of creating a single session to just the one aggregate IOCTL. Signed-off-by: L

[PATCH v4 4/7] drm/panthor: Introduce sampling sessions to handle userspace clients

2025-05-16 Thread Lukas Zapolskas
To allow for combining the requests from multiple userspace clients, an intermediary layer between the HW/FW interfaces and userspace is created, containing the information for the counter requests and tracking of insert and extract indices. Each session starts inactive and must be explicitly activ

[PATCH v4 0/7] Performance counter implementation with single manual client support

2025-05-16 Thread Lukas Zapolskas
Hello, This patch set implements initial support for performance counter sampling in Panthor, as a follow-up for Adrián Larumbe's patch set [1]. This version of the patch series fixes a number of issues, including FW ring buffer wrapping and IRQ handling for the performance counter IRQs. The size

Re: Kernels >= 6.3 disable video output

2025-05-16 Thread Steven J Abner
On Fri, May 16 2025 at 03:38:04 PM +, Steven J Abner wrote: A boot param like 'amd_prefcore=disable' could work But kinda a band aid. What if you just download a Mainline kernel (as I did to verify not a build/configure issue). Writing bug report to OS provider could take a while for the

Re: [PATCH v2 2/6] drm/sched: Prevent teardown waitque from blocking too long

2025-05-16 Thread Tvrtko Ursulin
On 16/05/2025 13:00, Danilo Krummrich wrote: On Fri, May 16, 2025 at 12:35:52PM +0100, Tvrtko Ursulin wrote: On 16/05/2025 11:54, Danilo Krummrich wrote: On Fri, May 16, 2025 at 11:19:50AM +0100, Tvrtko Ursulin wrote: On 16/05/2025 10:53, Danilo Krummrich wrote: On Fri, May 16, 2025 at 10

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-05-16 Thread Luca Ceresoli
Hi Maxime, On Thu, 15 May 2025 10:11:33 +0200 Maxime Ripard wrote: > On Tue, Apr 15, 2025 at 01:22:14PM +0200, Luca Ceresoli wrote: > > > > +/* > > > > + * Mimick the typical struct defined by a bridge driver, which embeds a > > > > + * bridge plus other fields. > > > > + */ > > > > +struct dumm

Re: Kernels >= 6.3 disable video output

2025-05-16 Thread Steven J Abner
On Fri, May 16 2025 at 03:02:47 PM +, Michel Dänzer wrote: FWIW, with GNOME the "max bpc" property value can be set Issue is pre-DE, gnome or Xorg. A boot param like 'amd_prefcore=disable' could work. Issue then becomes putting into dmesg so can figure its needed. Blacked out console har

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Christian König
On 5/16/25 16:53, Johannes Weiner wrote: > On Fri, May 16, 2025 at 08:53:07AM +0200, Christian König wrote: >> On 5/15/25 18:08, Johannes Weiner wrote: Stop for a second. As far as I can see the shrinker for the TTM pool should *not* be memcg aware. Background is that pages who

Re: Kernels >= 6.3 disable video output

2025-05-16 Thread Michel Dänzer
On 2025-05-15 19:59, Harry Wentland wrote: > Hi Steven, > > thanks for the bisect. > > In order to avoid display artifacts (especially for HDR) we had to > allow higher bit depth color output on the wire. The driver should > fallback to a lower resolution as needed but looks like there's a > bug

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-16 Thread Johannes Weiner
On Fri, May 16, 2025 at 08:53:07AM +0200, Christian König wrote: > On 5/15/25 18:08, Johannes Weiner wrote: > >> Stop for a second. > >> > >> As far as I can see the shrinker for the TTM pool should *not* be > >> memcg aware. Background is that pages who enter the pool are > >> considered freed by

Re: [PATCH] drm/ttm: Make pool shrinker more responsive

2025-05-16 Thread Tvrtko Ursulin
On 16/05/2025 15:03, Christian König wrote: On 5/16/25 15:41, Tvrtko Ursulin wrote: But because TTM shrinker does not currently update shrinkerctl->nr_scanned, shrinker core assumes TTM looked at full SHRINK_BATCH pages with every call, and adds and decrements that value to the counters it u

Re: [PATCH] accel/ivpu: Add inference_timeout_ms module parameter

2025-05-16 Thread Jeff Hugo
On 5/15/2025 3:31 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Add new inference_timeout_ms parameter that allows specifying maximum allowed duration in milliseconds that inference can take before triggering a recovery. Calculate maximum number of heartbeat retries based on ratio between

Re: [PATCH] accel/ivpu: Reorder Doorbell Unregister and Command Queue Destruction

2025-05-16 Thread Jeff Hugo
On 5/15/2025 3:41 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered before destroying the command queue. The NPU firmware requires doorbells to be unregistered prior to command queue destruction. If doorbell remains regist

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

2025-05-16 Thread Tvrtko Ursulin
On 16/05/2025 14:38, Philipp Stanner wrote: On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: On 16/05/2025 12:53, Tvrtko Ursulin wrote: On 16/05/2025 08:28, Philipp Stanner wrote: On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: On 15/05/2025 16:00, Christian König wrote:

Re: [PATCH] drm/nouveau/dp: convert to use ERR_CAST()

2025-05-16 Thread Danilo Krummrich
On 5/15/25 2:11 PM, zhang.en...@zte.com.cn wrote: From: Zhang Enpei As opposed to open-code, use ERR_CAST to clearly indicate that this is a pointer to an error value and a type conversion is performed. Applied to drm-misc-next, thanks!

Re: [PATCH 0/4] drm/nouveau: Simplify nouveau_fence.c

2025-05-16 Thread Danilo Krummrich
On 4/24/25 3:02 PM, Philipp Stanner wrote: Just some minor attempts at improving the readability of nouveau_fence.c Applied to drm-misc-next, thanks!

Re: [PATCH] drm/nouveau/fifo: small cleanup in nvkm_chan_cctx_get()

2025-05-16 Thread Danilo Krummrich
On 4/30/25 10:06 AM, Dan Carpenter wrote: "&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use "&cgrp->mutex" consistently. It looks nicer and it silences a Smatch static checker warning. Applied to drm-misc-next, thanks!

Re: [PATCH v3 0/7] drm/panthor: Add performance counters with manual sampling mode

2025-05-16 Thread Lukas Zapolskas
Hello Adrián, Thank you for reaching out about the matter. Could you please clarify what you would like me to elaborate on? I have responded to most, if not all, of the comments you raised in that review, including providing more information about the approach (please see [1] for more details

Re: [PATCH] drm/ttm: Make pool shrinker more responsive

2025-05-16 Thread Christian König
On 5/16/25 15:41, Tvrtko Ursulin wrote: >>> But because TTM shrinker does not currently update shrinkerctl->nr_scanned, >>> shrinker core assumes TTM looked at full SHRINK_BATCH pages with every >>> call, and adds and decrements that value to the counters it uses to >>> determine when to stop tr

Re: [PATCH] drm: ci: skip msm_mapping@shadow on SM8350

2025-05-16 Thread Helen Koike
On 5/13/25 15:49, Dmitry Baryshkov wrote: The msm_mapping@shadow test fails on SM8350, which means that the write might get through (hopefully not though). Disable the test completely for now until we can fix the issue. Link: https://gitlab.freedesktop.org/drm/msm/-/issues/77 Signed-off-by: D

Re: [PATCH] drm/ttm: Make pool shrinker more responsive

2025-05-16 Thread Tvrtko Ursulin
On 16/05/2025 12:46, Christian König wrote: On 5/16/25 13:21, Tvrtko Ursulin wrote: On 16/05/2025 09:23, Christian König wrote: On 5/15/25 22:57, Tvrtko Ursulin wrote: Currently the TTM pool shrinker ensures it frees at least something every time it is invoked, but it also lies to the core

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

2025-05-16 Thread Philipp Stanner
On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: > > On 16/05/2025 12:53, Tvrtko Ursulin wrote: > > > > On 16/05/2025 08:28, Philipp Stanner wrote: > > > On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: > > > > > > > > On 15/05/2025 16:00, Christian König wrote: > > > > > Sometim

  1   2   >