Re: [PATCH RESEND v5 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-06-19 Thread AngeloGioacchino Del Regno
Il 14/06/24 09:27, Alexandre Mergnat ha scritto: Add MT8365 audio front-end bindings Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH RESEND v5 07/16] ASoC: mediatek: mt8365: Add ADDA DAI support

2024-06-19 Thread AngeloGioacchino Del Regno
Il 14/06/24 09:27, Alexandre Mergnat ha scritto: Add ADDA Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH RESEND v5 06/16] ASoC: mediatek: mt8365: Add I2S DAI support

2024-06-19 Thread AngeloGioacchino Del Regno
Il 14/06/24 09:27, Alexandre Mergnat ha scritto: Add I2S Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH RESEND v5 05/16] ASoC: mediatek: mt8365: Add audio clock control support

2024-06-19 Thread AngeloGioacchino Del Regno
Il 14/06/24 09:27, Alexandre Mergnat ha scritto: Add audio clock wrapper and audio tuner control. Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH RESEND v5 08/16] ASoC: mediatek: mt8365: Add DMIC DAI support

2024-06-19 Thread AngeloGioacchino Del Regno
Il 14/06/24 09:27, Alexandre Mergnat ha scritto: Add Digital Micro Device Audio Interface support for MT8365 SoC. Signed-off-by: Alexandre Mergnat Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/17/24 17:17, Jason Gunthorpe wrote: > [You don't often get email from j...@ziepe.ca. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote: >> Add an RDMA driver of Gaudi ASICs family for AI

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 19:01, Przemek Kitszel wrote: > On 6/18/24 13:08, Omer Shpigelman wrote: >> On 6/17/24 22:04, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is important at >>>

Re: [PATCH] drm: Remove unused function rcar_cmm_write

2024-06-19 Thread Sergey Shtylyov
On 6/19/24 10:54 AM, Jiapeng Chong wrote: > The function are defined in the rcar_cmm.c file, but not called s/are/is/. > elsewhere, so delete the unused function. Anywhere, maybe? > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function > 'rcar_cmm_read'. > >

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 15:58, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 11:08:34AM +, Omer Shpigelman wrote: >> On 6/17/24 22:04, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is important at >>>

Re: [PATCH] drm: Remove unused function rcar_cmm_write

2024-06-19 Thread Kieran Bingham
Quoting Jiapeng Chong (2024-06-19 08:54:36) > The function are defined in the rcar_cmm.c file, but not called > elsewhere, so delete the unused function. > > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function > 'rcar_cmm_read'. Indeed it's unused. Reviewed-by: Kieran

[PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-06-19 Thread Tomi Valkeinen
From: Tomi Valkeinen When a bridge driver uses devm_mipi_dsi_device_register_full() or devm_mipi_dsi_attach(), the resource management is moved to devres, which releases the resource automatically when the bridge driver is unbound. However, if the DSI host goes away first, the host

Re: (subset) [PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-19 Thread Maxime Ripard
On Tue, 18 Jun 2024 18:19:59 +0200, Marc Gonzalez wrote: > simple_bridge_probe() calls drm_bridge_add() > Thus, drm_bridge_remove() must be called in the remove() callback. > > If we call devm_drm_bridge_add() instead, then drm_bridge_remove() > will be called automatically at device release, and

Re: [PATCH v5 06/12] drm/ttm: Use the LRU walker helper for swapping

2024-06-19 Thread Thomas Hellström
On Wed, 2024-06-19 at 04:23 +, Matthew Brost wrote: > On Tue, Jun 18, 2024 at 09:18:14AM +0200, Thomas Hellström wrote: > > Rework the TTM swapping to use the LRU walker helper. > > This helps fixing up the ttm_bo_swapout() interface > > to be consistent about not requiring any locking. > > >

Re: [PATCH v5 04/12] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-06-19 Thread Thomas Hellström
On Wed, 2024-06-19 at 03:37 +, Matthew Brost wrote: > On Tue, Jun 18, 2024 at 09:18:12AM +0200, Thomas Hellström wrote: > > Ugh, replying to correct version again... > > > To address the problem with hitches moving when bulk move > > sublists are lru-bumped, register the list cursors with

Re: [PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-19 Thread Neil Armstrong
On 18/06/2024 18:19, Marc Gonzalez wrote: simple_bridge_probe() calls drm_bridge_add() Thus, drm_bridge_remove() must be called in the remove() callback. If we call devm_drm_bridge_add() instead, then drm_bridge_remove() will be called automatically at device release, and the remove() callback

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Przemek Kitszel
On 6/19/24 09:16, Omer Shpigelman wrote: On 6/18/24 17:19, Andrew Lunn wrote: [...] +module_param(poll_enable, bool, 0444); +MODULE_PARM_DESC(poll_enable, + "Enable Rx polling rather than IRQ + NAPI (0 = no, 1 = yes, default: no)"); Module parameters are not liked. This

[PATCH] drm: Remove unused function rcar_cmm_write

2024-06-19 Thread Jiapeng Chong
The function are defined in the rcar_cmm.c file, but not called elsewhere, so delete the unused function. drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c:35:19: warning: unused function 'rcar_cmm_read'. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9364

Re: [PATCH v5 05/12] drm/ttm: Provide a generic LRU walker helper

2024-06-19 Thread Thomas Hellström
Hi, Matthew. Thanks for reviewing. On Tue, 2024-06-18 at 22:11 +, Matthew Brost wrote: > On Tue, Jun 18, 2024 at 09:18:13AM +0200, Thomas Hellström wrote: > > Replying to correct version... > > > Provide a generic LRU walker in TTM, in the spirit of > > drm_gem_lru_scan() > > but building

Re: Design session notes: GPU acceleration in Xen

2024-06-19 Thread Christian König
Am 18.06.24 um 16:12 schrieb Demi Marie Obenour: On Tue, Jun 18, 2024 at 08:33:38AM +0200, Christian König wrote: > Am 18.06.24 um 02:57 schrieb Demi Marie Obenour: >> On Mon, Jun 17, 2024 at 10:46:13PM +0200, Marek Marczykowski-Górecki >> wrote: >>> On Mon, Jun 17, 2024 at 09:46:29AM +0200,

Re: [PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-19 Thread Tejas Vipin
On 6/19/24 12:06 PM, Dmitry Baryshkov wrote: > On Wed, Jun 19, 2024 at 09:03:49AM GMT, Tejas Vipin wrote: >> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce >> mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe >> ("drm/mipi-dsi: wrap more functions for streamline

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 17:19, Andrew Lunn wrote: +static u32 hbl_en_get_mtu(struct hbl_aux_dev *aux_dev, u32 port_idx) +{ + struct hbl_en_port *port = HBL_EN_PORT(aux_dev, port_idx); + struct net_device *ndev = port->ndev; + u32 mtu; + + if

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Ekansh Gupta
On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned >> to be added for PD notifications and other missing features. Adding >> and maintaining new files from within

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Ekansh Gupta
On 6/19/2024 12:21 PM, Dmitry Baryshkov wrote: > On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta wrote: >> >> >> On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: >>> On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned

Patch "drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)" has been added to the 6.9-stable tree

2024-06-19 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE) to the 6.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)" has been added to the 6.6-stable tree

2024-06-19 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE) to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: [PATCH 1/9] accel/habanalbs/gaudi2: reduce interrupt count to 128

2024-06-19 Thread Tomer Tayar
On 19/06/2024 9:34, Ofir Bitton wrote: > Some systems allow a maximum number of 128 MSI-X interrupts. > Hence we reduce the interrupt count to 128 instead of 512. > > Signed-off-by: Ofir Bitton > Reviewed-by: Ofir Bitton Reviewed-by: Tomer Tayar > --- >

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 10:01, Ekansh Gupta wrote: > > > > On 6/19/2024 12:21 PM, Dmitry Baryshkov wrote: > > On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta > > wrote: > >> > >> > >> On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > >>> On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: >

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta wrote: > > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and other

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Greg KH
On Wed, Jun 19, 2024 at 12:15:03PM +0530, Ekansh Gupta wrote: > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and

Re: [PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-19 Thread Dmitry Baryshkov
On Wed, Jun 19, 2024 at 09:03:49AM GMT, Tejas Vipin wrote: > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > raydium rm692e5 panel. > >

[PATCH 2/9] MAINTAINERS: Change habanalabs maintainer and git repo path

2024-06-19 Thread Ofir Bitton
From: Oded Gabbay Because I left habana, Ofir Bitton is now the habanalabs driver maintainer. The git repo also changed location to the Habana GitHub website. Signed-off-by: Oded Gabbay Acked-by: Daniel Vetter --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 8/9] accel/habanalabs: move heartbeat work initialization to early init

2024-06-19 Thread Ofir Bitton
From: Tomer Tayar The device heartbeat work is currently initialized at device_heartbeat_schedule() which is called at the end of hl_device_init(). However hl_device_init() can fail at a previous step, and in such a case, a subsequent call to hl_device_fini() will lead to calling

[PATCH 6/9] accel/habanalabs: dump the EQ entries headers on EQ heartbeat failure

2024-06-19 Thread Ofir Bitton
From: Tomer Tayar Add a dump of the EQ entries headers upon a EQ heartbeat failure. Signed-off-by: Tomer Tayar Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/device.c | 2 ++ drivers/accel/habanalabs/common/habanalabs.h | 1 + drivers/accel/habanalabs/common/irq.c

[PATCH 9/9] accel/habanalabs: gradual sleep in polling memory macro

2024-06-19 Thread Ofir Bitton
From: Didi Freiman It’s better to avoid long sleeps right from the beginning of the polling since the data may be available much sooner than the sleep period. Because polling host memory is inexpensive, this change gradually increases the sleep time up to the user-requested period.

[PATCH 7/9] accel/habanalabs: print timestamp of last PQ heartbeat on EQ heartbeat failure

2024-06-19 Thread Ofir Bitton
From: Tomer Tayar The test packet which is sent to FW for the PQ heartbeat is used also as the trigger in FW to send the EQ heartbeat event. Add the time of the last sent packet to the debug info which is printed upon a EQ heartbeat failure. Signed-off-by: Tomer Tayar Reviewed-by: Ofir Bitton

[PATCH 3/9] accel/habanalabs: additional print in device-in-use info

2024-06-19 Thread Ofir Bitton
From: Ilia Levi When device release triggers a hard reset, there is a printout of the cause. Currently listed causes (that increment context refcount) are active command submissions and exported DMA buffer objects. In any other case, the printout emits "unknown reason". We identify and print

[PATCH 5/9] accel/habanalabs: revise print on EQ heartbeat failure

2024-06-19 Thread Ofir Bitton
From: Tomer Tayar Don't print the "previous EQ index" value in case of a EQ heartbeat failure, because it is incremented along with the EQ CI and therefore redundant. In addition, as the CPU-CP PI is zeroed when it reaches a value that is twice the queue size, add a value of the CI with a

[PATCH 4/9] accel/habanalabs: add more info upon cpu pkt timeout

2024-06-19 Thread Ofir Bitton
From: Farah Kassabri In order to have better debuggability upon encountering FW issues, We are adding additional info once CPU packet timeout expires. Signed-off-by: Farah Kassabri Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/firmware_if.c | 14 +++--- 1 file changed,

[PATCH 1/9] accel/habanalbs/gaudi2: reduce interrupt count to 128

2024-06-19 Thread Ofir Bitton
Some systems allow a maximum number of 128 MSI-X interrupts. Hence we reduce the interrupt count to 128 instead of 512. Signed-off-by: Ofir Bitton Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/gaudi2/gaudi2P.h| 8 drivers/accel/habanalabs/include/gaudi2/gaudi2.h | 4

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-19 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:11:58PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 20:55, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > > > > > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > > > On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread Nuno Sá
On Wed, 2024-06-19 at 11:15 +0800, kernel test robot wrote: > Hi Paul, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on jic23-iio/togreg] > [also build test ERROR on vkoul-dmaengine/next linus/master v6.10-rc4 next- > 20240618] > [If your patch is applied

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2024-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 TiaPadavano (jiloxe4...@elahan.com) changed: What|Removed |Added CC|

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne wrote: > > Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > > Hi TaoJiang, > > > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > > > From: Ming Qian > > > > > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device

Re: [PATCH v5 06/12] drm/ttm: Use the LRU walker helper for swapping

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:14AM +0200, Thomas Hellström wrote: > Rework the TTM swapping to use the LRU walker helper. > This helps fixing up the ttm_bo_swapout() interface > to be consistent about not requiring any locking. > > For now mimic the current behaviour of using trylock > only. We

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Mario Limonciello
On 6/18/2024 17:36, Leo Li wrote: On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the

Re: [PATCH v5 04/12] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:12AM +0200, Thomas Hellström wrote: Ugh, replying to correct version again... > To address the problem with hitches moving when bulk move > sublists are lru-bumped, register the list cursors with the > ttm_lru_bulk_move structure when traversing its list, and > when

[PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-18 Thread Tejas Vipin
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") for the raydium rm692e5 panel. Signed-off-by: Tejas Vipin --- Changes in v2: - Change rm692e5_on to

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 01:56, Abhinav Kumar wrote: > On 6/13/2024 4:20 PM, Abhinav Kumar wrote: > > On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > >> The dpu_crtc_atomic_check() already calls the function > >> _dpu_crtc_check_and_setup_lm_bounds(). There is no need to call it > >> again from

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-18 Thread 胡俊光

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread kernel test robot
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on vkoul-dmaengine/next linus/master v6.10-rc4 next-20240618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: Correct sequencing of usage of DRM writeback connector

2024-06-18 Thread Abhinav Kumar
On 6/18/2024 2:33 AM, Daniel Vetter wrote: On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: Hi On 6/17/2024 9:54 AM, Brian Starkey wrote: Hi, On Mon, Jun 17, 2024 at 05:16:36PM +0200, Daniel Vetter wrote: On

Re: [PATCH v2 08/14] drm/msm/hdmi: add runtime PM calls to DDC transfer function

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:51 AM, Dmitry Baryshkov wrote: We must be sure that the HDMI controller is powered on, while performing the DDC transfer. Add corresponding runtime PM calls to msm_hdmi_i2c_xfer(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang ---

Re: [PATCH v2 07/14] drm/msm/hdmi: switch to pm_runtime_resume_and_get()

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The pm_runtime_get_sync() function is a bad choise for runtime power [nit: s/choise/choice/] Reviewed-by: Jessica Zhang management. Switch HDMI driver to pm_runtime_resume_and_get() and add proper error handling, while we are at it.

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher wrote: > > On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > > > Hi, > > > > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > > wrote: > > > > > > > > Based on

Re: [PATCH v2 06/14] drm/msm/hdmi: switch to clk_bulk API

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The last platform using legacy clock names for HDMI block (APQ8064) switched to new clock names in 5.16. It's time to stop caring about old DT, drop hand-coded helpers and switch to clk_bulk_* API. Signed-off-by: Dmitry Baryshkov Reviewed-by:

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:22 AM Daniel Vetter wrote: > > > I'm really not convinced that hacking with device links in order to > > get the shutdown notification in the right order is correct, though. > > The idea is that after we're confident that all DRM modeset drivers > > are calling

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:17 AM Daniel Vetter wrote: > > > That all being said, I'm also totally OK with any of the following: > > > > 1. Dropping my patch and just accepting that we will have warnings > > printed out for all DRM drivers that do things correctly and have no > > warnings for

Device / Driver and PCI Rust abstractions

2024-06-18 Thread Danilo Krummrich
https://lore.kernel.org/lkml/20240618234025.15036-1-d...@redhat.com/

[PATCH v2 10/10] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to

[PATCH v2 8/8] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to

[PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina The DRM GEM subsystem is the DRM memory management subsystem used by most modern drivers. Add a Rust abstraction to allow Rust DRM driver implementations to use it. Signed-off-by: Asahi Lina Co-developed-by: Danilo Krummrich Signed-off-by: Danilo Krummrich ---

[PATCH v2 6/8] rust: drm: file: Add File abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[PATCH v2 5/8] rust: drm: add DRM driver registration

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver `Registration`. The `Registration` structure is responsible to register and unregister a DRM driver. It makes use of the `Devres` container in order to allow the `Registration` to be owned by devres, such that it is automatically dropped (and the DRM driver unregistered)

[PATCH v2 4/8] rust: drm: add device abstraction

2024-06-18 Thread Danilo Krummrich
Implement the abstraction for a `struct drm_device`. A `drm::device::Device` creates a static const `struct drm_driver` filled with the data from the `drm::drv::Driver` trait implementation of the actual driver creating the `drm::device::Device`. Co-developed-by: Asahi Lina Signed-off-by: Asahi

[PATCH v2 2/8] rust: Add a Sealed trait

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina Some traits exposed by the kernel crate may not be intended to be implemented by downstream modules. Add a Sealed trait to allow avoiding this using the sealed trait pattern. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/kernel/lib.rs | 5 + 1 file

[PATCH v2 3/8] rust: drm: add driver abstractions

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver abstractions. The `Driver` trait provides the interface to the actual driver to fill in the driver specific data, such as the `DriverInfo`, driver features and IOCTLs. Co-developed-by: Asahi Lina Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[PATCH v2 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the

[PATCH v2 0/8] DRM Rust abstractions and Nova

2024-06-18 Thread Danilo Krummrich
This patch series implements some basic DRM Rust abstractions and a stub implementation of the Nova GPU driver. Nova is intended to be developed upstream, starting out with just a stub driver to lift some initial required infrastructure upstream. A more detailed explanation can be found in [1].

Re: [PATCH v2 05/14] drm/msm/hdmi: drop clock frequency assignment

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The only clock which has frequency being set through hpd_freqs is the "core" aka MDSS_HDMI_CLK clock. It always has the specified frequency, so we can drop corresponding clk_set_rate() call together with the hpd_freq infrastructure.

Re: [PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:16 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback.

Re: [PATCH v3 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:20 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_crtc_atomic_check() already calls the function _dpu_crtc_check_and_setup_lm_bounds().  There is no need to call it again from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov ---  

Re: [PATCH v3 6/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++

Re: [PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-18 Thread Abhinav Kumar
On 6/14/2024 3:34 AM, Dmitry Baryshkov wrote: On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as

Re: [PATCH v3 4/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++-

Re: [PATCH v3 3/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:14 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43

Re: [PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:13 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by:

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask

Re: [PATCH v5 05/12] drm/ttm: Provide a generic LRU walker helper

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:13AM +0200, Thomas Hellström wrote: Replying to correct version... > Provide a generic LRU walker in TTM, in the spirit of drm_gem_lru_scan() > but building on the restartable TTM LRU functionality. > > The LRU walker optionally supports locking objects as part of

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Alex Deucher
On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > Hi, > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > wrote: > > > > > > Based on grepping through the source code this driver appears to be > > > missing a call to

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > wrote: > > > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among other things,

Re: [PATCH] drm/amd/display: Disable CONFIG_DRM_AMD_DC_FP for RISC-V with clang

2024-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 18, 2024 at 10:17 AM Harry Wentland wrote: > > > > On 2024-06-14 15:54, Nathan Chancellor wrote: > > Commit 77acc6b55ae4 ("riscv: add support for kernel-mode FPU") and > > commit a28e4b672f04 ("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") > > enabled

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR ---   tests/amdgpu/amd_psr.c | 74 ++   1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 14:43, Dmitry Baryshkov escreveu: On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 01:48, Joe Damato wrote: > [You don't often get email from jdam...@fastly.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:02AM +0300, Omer Shpigelman wrote: >> This ethernet driver is initialized via auxiliary bus

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-18 Thread Omer Shpigelman
On 6/18/24 10:08, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 05:50:15AM +, Omer Shpigelman wrote: >> On 6/17/24 16:18, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is important at >>>

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 14:48, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 08:08:26AM +, Omer Shpigelman wrote: >> On 6/13/24

[PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread TaoJiang
From: Ming Qian When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know whether the dma buffer is coherent or synchronized. The videobuf2-core will skip cache syncs as it think the DMA exporter should take care of cache syncs But in fact it's likely that the client doesn't

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread ming qian
Hi TaoJiang, On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: From: Ming Qian When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know whether the dma buffer is coherent or synchronized. The videobuf2-core will skip cache syncs as it think the DMA exporter should take care

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 13:55, Zhu Yanjun wrote: > [You don't often get email from yanjun@linux.dev. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > 在 2024/6/13 16:22, Omer Shpigelman 写道: >> + >> +/* This function should be called after ctrl_lock was taken */ > >

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 03:16, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +/* get the src IP as it is done in devinet_ioctl() */ >> +static int hbl_en_get_src_ip(struct

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 18:02, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 04:05:57PM +0200, Markus Elfring wrote: >> … >>> +++

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 22:04, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 05:43:49PM +, Omer Shpigelman wrote: >> On 6/13/24

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Leo Li
On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Leo Li
Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to

Re: [PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-18 Thread Rodrigo Vivi
On Fri, Jun 14, 2024 at 03:53:04PM -0400, Rodrigo Vivi wrote: > On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote: > > Describe newly added parameter target_rr_divider in struct > > drm_dp_as_sdp. > > > > -v2: > > Remove extra line from commit message.(Lucas) > > > > Fixes:

RE: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen

2024-06-18 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Monday, June 17, 2024 11:43 AM To: intel-gfx ; dri-devel Cc: Andi Shyti ; Cavitt, Jonathan ; De Marchi, Lucas Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen > > Hi Jonathan, > > Commit 05da7d9f717b ("drm/i915/gem: Downgrade

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Dragan Simic
On 2024-06-18 12:33, Dragan Simic wrote: Hello Qiang and Maxime, On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, >

<    5   6   7   8   9   10   11   12   13   14   >